rubocop-rspec 1.7.0 → 3.0.2

data/spec/rubocop/cop/rspec/file_path_spec.rb

@@ -1,236 +0,0 @@
-describe RuboCop::Cop::RSpec::FilePath, :config do
-  subject(:cop) { described_class.new(config) }
-
-  shared_examples 'invalid spec path' do |source, expected:, actual:|
-    context "when `#{source}` is defined in #{actual}" do
-      before do
-        inspect_source(cop, source, actual)
-      end
-
-      it 'flags an offense' do
-        expect(cop.offenses.size).to eq(1)
-      end
-
-      it 'registers the offense on line 1' do
-        expect(cop.offenses.map(&:line)).to eq([1])
-      end
-
-      it 'adds a message saying what the path should end with' do
-        expect(cop.messages).to eql(["Spec path should end with `#{expected}`"])
-      end
-    end
-  end
-
-  include_examples 'invalid spec path',
-                   "describe MyClass, 'foo' do; end",
-                   expected: 'my_class*foo*_spec.rb',
-                   actual:   'wrong_path_foo_spec.rb'
-
-  include_examples 'invalid spec path',
-                   "describe MyClass, '#foo' do; end",
-                   expected: 'my_class*foo*_spec.rb',
-                   actual: 'wrong_class_foo_spec.rb'
-
-  include_examples 'invalid spec path',
-                   "describe MyClass, '#foo' do; end",
-                   expected: 'my_class*foo*_spec.rb',
-                   actual: 'my_class/foo_spec.rb.rb'
-
-  include_examples 'invalid spec path',
-                   "describe MyClass, '#foo' do; end",
-                   expected: 'my_class*foo*_spec.rb',
-                   actual: 'my_class/foo_specorb'
-
-  include_examples 'invalid spec path',
-                   "describe MyClass, '#foo', blah: :blah do; end",
-                   expected: 'my_class*foo*_spec.rb',
-                   actual: 'wrong_class_foo_spec.rb'
-
-  include_examples 'invalid spec path',
-                   'describe MyClass do; end',
-                   expected: 'my_class*_spec.rb',
-                   actual: 'wrong_class_spec.rb'
-
-  include_examples 'invalid spec path',
-                   'describe MyClass, :foo do; end',
-                   expected: 'my_class*_spec.rb',
-                   actual: 'wrong_class_spec.rb'
-
-  it 'skips specs that do not describe a class / method' do
-    inspect_source(
-      cop,
-      "describe 'Test something' do; end",
-      'some/class/spec.rb'
-    )
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'skips specs that do have multiple top level describes' do
-    inspect_source(
-      cop,
-      [
-        "describe MyClass, 'do_this' do; end",
-        "describe MyClass, 'do_that' do; end"
-      ],
-      'some/class/spec.rb'
-    )
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'checks class specs' do
-    inspect_source(
-      cop,
-      'describe Some::Class do; end',
-      'some/class_spec.rb'
-    )
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'handles CamelCaps class names' do
-    inspect_source(
-      cop,
-      'describe MyClass do; end',
-      'my_class_spec.rb'
-    )
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'handles ACRONYMClassNames' do
-    inspect_source(
-      cop,
-      'describe ABCOne::Two do; end',
-      'abc_one/two_spec.rb'
-    )
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'handles ALLCAPS class names' do
-    inspect_source(
-      cop,
-      'describe ALLCAPS do; end',
-      'allcaps_spec.rb'
-    )
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'handles alphanumeric class names' do
-    inspect_source(
-      cop,
-      'describe IPv4AndIPv6 do; end',
-      'i_pv4_and_i_pv6_spec.rb'
-    )
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'checks instance methods' do
-    inspect_source(
-      cop,
-      "describe Some::Class, '#inst' do; end",
-      'some/class/inst_spec.rb'
-    )
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'checks class methods' do
-    inspect_source(
-      cop,
-      "describe Some::Class, '.inst' do; end",
-      'some/class/inst_spec.rb'
-    )
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'allows flat hierarchies for instance methods' do
-    inspect_source(
-      cop,
-      "describe Some::Class, '#inst' do; end",
-      'some/class_inst_spec.rb'
-    )
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'allows flat hierarchies for class methods' do
-    inspect_source(
-      cop,
-      "describe Some::Class, '.inst' do; end",
-      'some/class_inst_spec.rb'
-    )
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'allows subdirs for instance methods' do
-    inspect_source(
-      cop,
-      "describe Some::Class, '#inst' do; end",
-      'some/class/instance_methods/inst_spec.rb'
-    )
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'allows subdirs for class methods' do
-    inspect_source(
-      cop,
-      "describe Some::Class, '.inst' do; end",
-      'some/class/class_methods/inst_spec.rb'
-    )
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'ignores non-alphanumeric characters' do
-    inspect_source(
-      cop,
-      "describe Some::Class, '#pred?' do; end",
-      'some/class/pred_spec.rb'
-    )
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'allows bang method' do
-    inspect_source(
-      cop,
-      "describe Some::Class, '#bang!' do; end",
-      'some/class/bang_spec.rb'
-    )
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'allows flexibility with predicates' do
-    inspect_source(
-      cop,
-      "describe Some::Class, '#thing?' do; end",
-      'some/class/thing_predicate_spec.rb'
-    )
-    expect(cop.offenses).to be_empty
-  end
-
-  it 'allows flexibility with operators' do
-    inspect_source(
-      cop,
-      "describe MyLittleClass, '#<=>' do; end",
-      'my_little_class/spaceship_operator_spec.rb'
-    )
-    expect(cop.offenses).to be_empty
-  end
-
-  context 'when configured' do
-    let(:cop_config) { { 'CustomTransform' => { 'FooFoo' => 'foofoo' } } }
-
-    it 'respects custom module name transformation' do
-      inspect_source(
-        cop,
-        "describe FooFoo::Some::Class, '#bar' do; end",
-        'foofoo/some/class/bar_spec.rb'
-      )
-      expect(cop.offenses).to be_empty
-    end
-
-    it 'ignores routing specs' do
-      inspect_source(
-        cop,
-        'describe MyController, "#foo", type: :routing do; end',
-        'foofoo/some/class/bar_spec.rb'
-      )
-      expect(cop.offenses).to be_empty
-    end
-  end
-end

data/spec/rubocop/cop/rspec/focus_spec.rb

@@ -1,130 +0,0 @@
-describe RuboCop::Cop::RSpec::Focus do
-  subject(:cop) { described_class.new }
-
-  # rubocop:disable RSpec/ExampleLength
-  it 'flags all rspec example blocks with that include `focus: true`' do
-    expect_violation(<<-RUBY)
-      example 'test', meta: true, focus: true do; end
-                                  ^^^^^^^^^^^ Focused spec found.
-      xit 'test', meta: true, focus: true do; end
-                              ^^^^^^^^^^^ Focused spec found.
-      describe 'test', meta: true, focus: true do; end
-                                   ^^^^^^^^^^^ Focused spec found.
-      it 'test', meta: true, focus: true do; end
-                             ^^^^^^^^^^^ Focused spec found.
-      xspecify 'test', meta: true, focus: true do; end
-                                   ^^^^^^^^^^^ Focused spec found.
-      specify 'test', meta: true, focus: true do; end
-                                  ^^^^^^^^^^^ Focused spec found.
-      example_group 'test', meta: true, focus: true do; end
-                                        ^^^^^^^^^^^ Focused spec found.
-      scenario 'test', meta: true, focus: true do; end
-                                   ^^^^^^^^^^^ Focused spec found.
-      xexample 'test', meta: true, focus: true do; end
-                                   ^^^^^^^^^^^ Focused spec found.
-      xdescribe 'test', meta: true, focus: true do; end
-                                    ^^^^^^^^^^^ Focused spec found.
-      context 'test', meta: true, focus: true do; end
-                                  ^^^^^^^^^^^ Focused spec found.
-      xcontext 'test', meta: true, focus: true do; end
-                                   ^^^^^^^^^^^ Focused spec found.
-      feature 'test', meta: true, focus: true do; end
-                                  ^^^^^^^^^^^ Focused spec found.
-      xfeature 'test', meta: true, focus: true do; end
-                                   ^^^^^^^^^^^ Focused spec found.
-      xscenario 'test', meta: true, focus: true do; end
-                                    ^^^^^^^^^^^ Focused spec found.
-    RUBY
-  end
-
-  it 'flags all rspec example blocks that include `:focus`' do
-    expect_violation(<<-RUBY)
-      example_group 'test', :focus do; end
-                            ^^^^^^ Focused spec found.
-      feature 'test', :focus do; end
-                      ^^^^^^ Focused spec found.
-      xexample 'test', :focus do; end
-                       ^^^^^^ Focused spec found.
-      xdescribe 'test', :focus do; end
-                        ^^^^^^ Focused spec found.
-      xscenario 'test', :focus do; end
-                        ^^^^^^ Focused spec found.
-      specify 'test', :focus do; end
-                      ^^^^^^ Focused spec found.
-      example 'test', :focus do; end
-                      ^^^^^^ Focused spec found.
-      xfeature 'test', :focus do; end
-                       ^^^^^^ Focused spec found.
-      xspecify 'test', :focus do; end
-                       ^^^^^^ Focused spec found.
-      scenario 'test', :focus do; end
-                       ^^^^^^ Focused spec found.
-      describe 'test', :focus do; end
-                       ^^^^^^ Focused spec found.
-      xit 'test', :focus do; end
-                  ^^^^^^ Focused spec found.
-      context 'test', :focus do; end
-                      ^^^^^^ Focused spec found.
-      xcontext 'test', :focus do; end
-                       ^^^^^^ Focused spec found.
-      it 'test', :focus do; end
-                 ^^^^^^ Focused spec found.
-    RUBY
-  end
-
-  it 'does not flag unfocused specs' do
-    expect_no_violations(<<-RUBY)
-      xcontext      'test' do; end
-      xscenario     'test' do; end
-      xspecify      'test' do; end
-      describe      'test' do; end
-      example       'test' do; end
-      xexample      'test' do; end
-      scenario      'test' do; end
-      specify       'test' do; end
-      xit           'test' do; end
-      feature       'test' do; end
-      xfeature      'test' do; end
-      context       'test' do; end
-      it            'test' do; end
-      example_group 'test' do; end
-      xdescribe     'test' do; end
-    RUBY
-  end
-
-  it 'does not flag a method that is focused twice' do
-    expect_violation(<<-RUBY)
-      fit "foo", :focus do
-      ^^^^^^^^^^^^^^^^^ Focused spec found.
-      end
-    RUBY
-  end
-
-  it 'ignores non-rspec code with :focus blocks' do
-    expect_no_violations(<<-RUBY)
-      some_method "foo", focus: true do
-      end
-    RUBY
-  end
-
-  it 'flags focused block types' do
-    expect_violation(<<-RUBY)
-      fdescribe 'test' do; end
-      ^^^^^^^^^^^^^^^^ Focused spec found.
-      ffeature 'test' do; end
-      ^^^^^^^^^^^^^^^ Focused spec found.
-      fcontext 'test' do; end
-      ^^^^^^^^^^^^^^^ Focused spec found.
-      fit 'test' do; end
-      ^^^^^^^^^^ Focused spec found.
-      fscenario 'test' do; end
-      ^^^^^^^^^^^^^^^^ Focused spec found.
-      fexample 'test' do; end
-      ^^^^^^^^^^^^^^^ Focused spec found.
-      fspecify 'test' do; end
-      ^^^^^^^^^^^^^^^ Focused spec found.
-      focus 'test' do; end
-      ^^^^^^^^^^^^ Focused spec found.
-    RUBY
-  end
-end

data/spec/rubocop/cop/rspec/hook_argument_spec.rb

@@ -1,189 +0,0 @@
-# encoding: utf-8
-
-describe RuboCop::Cop::RSpec::HookArgument, :config do
-  subject(:cop) { described_class.new(config) }
-
-  let(:cop_config) do
-    { 'EnforcedStyle' => enforced_style }
-  end
-
-  let(:enforced_style) { :implicit }
-
-  shared_examples 'ignored hooks' do
-    it 'ignores :context and :suite' do
-      expect_no_violations(<<-RUBY)
-        before(:suite) { true }
-        after(:suite) { true }
-        before(:context) { true }
-        after(:context) { true }
-      RUBY
-    end
-
-    it 'ignores hooks with more than one argument' do
-      expect_no_violations(<<-RUBY)
-        before(:each, :something_custom) { true }
-      RUBY
-    end
-
-    it 'ignores non-rspec hooks' do
-      expect_no_violations(<<-RUBY)
-        setup(:each) { true }
-      RUBY
-    end
-  end
-
-  shared_examples 'generated config' do |source, detected_style|
-    it 'generates a todo based on the detected style' do
-      inspect_source(cop, source, 'foo_spec.rb')
-
-      expect(cop.config_to_allow_offenses)
-        .to eq('EnforcedStyle' => detected_style)
-    end
-  end
-
-  shared_examples 'hook autocorrect' do |output|
-    it 'autocorrects :each to EnforcedStyle' do
-      corrected =
-        autocorrect_source(cop, 'before(:each) { }', 'spec/foo_spec.rb')
-
-      expect(corrected).to eql(output)
-    end
-
-    it 'autocorrects :example to EnforcedStyle' do
-      corrected =
-        autocorrect_source(cop, 'before(:example) { }', 'spec/foo_spec.rb')
-
-      expect(corrected).to eql(output)
-    end
-
-    it 'autocorrects :implicit to EnforcedStyle' do
-      corrected =
-        autocorrect_source(cop, 'before { }', 'spec/foo_spec.rb')
-
-      expect(corrected).to eql(output)
-    end
-  end
-
-  shared_examples 'an example hook' do
-    include_examples 'ignored hooks'
-    include_examples 'generated config', 'before(:each) { foo }', 'each'
-    include_examples 'generated config', 'before(:example) { foo }', 'example'
-    include_examples 'generated config', 'before { foo }', 'implicit'
-  end
-
-  context 'when EnforcedStyle is :implicit' do
-    let(:enforced_style) { :implicit }
-
-    it 'detects :each for hooks' do
-      expect_violation(<<-RUBY)
-        before(:each) { true }
-        ^^^^^^^^^^^^^ Omit the default `:each` argument for RSpec hooks.
-        after(:each)  { true }
-        ^^^^^^^^^^^^ Omit the default `:each` argument for RSpec hooks.
-        around(:each) { true }
-        ^^^^^^^^^^^^^ Omit the default `:each` argument for RSpec hooks.
-      RUBY
-    end
-
-    it 'detects :example for hooks' do
-      expect_violation(<<-RUBY)
-        before(:example) { true }
-        ^^^^^^^^^^^^^^^^ Omit the default `:example` argument for RSpec hooks.
-        after(:example)  { true }
-        ^^^^^^^^^^^^^^^ Omit the default `:example` argument for RSpec hooks.
-        around(:example) { true }
-        ^^^^^^^^^^^^^^^^ Omit the default `:example` argument for RSpec hooks.
-      RUBY
-    end
-
-    it 'does not flag hooks without default scopes' do
-      expect_no_violations(<<-RUBY)
-        before { true }
-        after { true }
-        before { true }
-        after { true }
-      RUBY
-    end
-
-    include_examples 'an example hook'
-    include_examples 'hook autocorrect', 'before { }'
-  end
-
-  context 'when EnforcedStyle is :each' do
-    let(:enforced_style) { :each }
-
-    it 'detects :each for hooks' do
-      expect_no_violations(<<-RUBY)
-        before(:each) { true }
-        after(:each)  { true }
-        around(:each) { true }
-      RUBY
-    end
-
-    it 'detects :example for hooks' do
-      expect_violation(<<-RUBY)
-        before(:example) { true }
-        ^^^^^^^^^^^^^^^^ Use `:each` for RSpec hooks.
-        after(:example)  { true }
-        ^^^^^^^^^^^^^^^ Use `:each` for RSpec hooks.
-        around(:example) { true }
-        ^^^^^^^^^^^^^^^^ Use `:each` for RSpec hooks.
-      RUBY
-    end
-
-    it 'does not flag hooks without default scopes' do
-      expect_violation(<<-RUBY)
-        before { true }
-        ^^^^^^ Use `:each` for RSpec hooks.
-        after { true }
-        ^^^^^ Use `:each` for RSpec hooks.
-        before { true }
-        ^^^^^^ Use `:each` for RSpec hooks.
-        after { true }
-        ^^^^^ Use `:each` for RSpec hooks.
-      RUBY
-    end
-
-    include_examples 'an example hook'
-    include_examples 'hook autocorrect', 'before(:each) { }'
-  end
-
-  context 'when EnforcedStyle is :example' do
-    let(:enforced_style) { :example }
-
-    it 'detects :example for hooks' do
-      expect_no_violations(<<-RUBY)
-        before(:example) { true }
-        after(:example)  { true }
-        around(:example) { true }
-      RUBY
-    end
-
-    it 'detects :each for hooks' do
-      expect_violation(<<-RUBY)
-        before(:each) { true }
-        ^^^^^^^^^^^^^ Use `:example` for RSpec hooks.
-        after(:each)  { true }
-        ^^^^^^^^^^^^ Use `:example` for RSpec hooks.
-        around(:each) { true }
-        ^^^^^^^^^^^^^ Use `:example` for RSpec hooks.
-      RUBY
-    end
-
-    it 'does not flag hooks without default scopes' do
-      expect_violation(<<-RUBY)
-        before { true }
-        ^^^^^^ Use `:example` for RSpec hooks.
-        after { true }
-        ^^^^^ Use `:example` for RSpec hooks.
-        before { true }
-        ^^^^^^ Use `:example` for RSpec hooks.
-        after { true }
-        ^^^^^ Use `:example` for RSpec hooks.
-      RUBY
-    end
-
-    include_examples 'an example hook'
-    include_examples 'hook autocorrect', 'before(:example) { }'
-  end
-end

data/spec/rubocop/cop/rspec/instance_variable_spec.rb

@@ -1,75 +0,0 @@
-describe RuboCop::Cop::RSpec::InstanceVariable do
-  subject(:cop) { described_class.new }
-
-  it 'finds an instance variable inside a describe' do
-    expect_violation(<<-RUBY)
-      describe MyClass do
-        before { @foo = [] }
-        it { expect(@foo).to be_empty }
-                    ^^^^ Use `let` instead of an instance variable
-      end
-    RUBY
-  end
-
-  it 'ignores non-spec blocks' do
-    expect_no_violations(<<-RUBY)
-      not_rspec do
-        before { @foo = [] }
-        it { expect(@foo).to be_empty }
-      end
-    RUBY
-  end
-
-  it 'finds an instance variable inside a shared example' do
-    expect_violation(<<-RUBY)
-      shared_examples 'shared example' do
-        it { expect(@foo).to be_empty }
-                    ^^^^ Use `let` instead of an instance variable
-      end
-    RUBY
-  end
-
-  it 'ignores an instance variable without describe' do
-    expect_no_violations(<<-RUBY)
-      @foo = []
-      @foo.empty?
-    RUBY
-  end
-
-  # Regression test for nevir/rubocop-rspec#115
-  it 'ignores instance variables outside of specs' do
-    expect_no_violations(<<-RUBY, filename: 'lib/source_code.rb')
-      feature do
-        @foo = bar
-
-        @foo
-      end
-    RUBY
-  end
-
-  context 'when configured with AssignmentOnly', :config do
-    subject(:cop) { described_class.new(config) }
-
-    let(:cop_config) do
-      { 'AssignmentOnly' => true }
-    end
-
-    it 'flags an instance variable when it is also assigned' do
-      expect_violation(<<-RUBY)
-        describe MyClass do
-          before { @foo = [] }
-          it { expect(@foo).to be_empty }
-                      ^^^^ Use `let` instead of an instance variable
-        end
-      RUBY
-    end
-
-    it 'ignores an instance variable when it is not assigned' do
-      expect_no_violations(<<-RUBY)
-        describe MyClass do
-          it { expect(@foo).to be_empty }
-        end
-      RUBY
-    end
-  end
-end

data/spec/rubocop/cop/rspec/leading_subject_spec.rb

@@ -1,54 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe RuboCop::Cop::RSpec::LeadingSubject do
-  subject(:cop) { described_class.new }
-
-  it 'checks subject below let' do
-    expect_violation(<<-RUBY)
-      RSpec.describe User do
-        let(:params) { foo }
-
-        subject { described_class.new }
-        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Declare `subject` above any other `let` declarations
-      end
-    RUBY
-  end
-
-  it 'approves of subject above let' do
-    expect_no_violations(<<-RUBY)
-      RSpec.describe User do
-        context 'blah' do
-        end
-
-        subject { described_class.new }
-
-        let(:params) { foo }
-      end
-    RUBY
-  end
-
-  it 'handles subjects in contexts' do
-    expect_no_violations(<<-RUBY)
-      RSpec.describe User do
-        let(:params) { foo }
-
-        context "when something happens" do
-          subject { described_class.new }
-        end
-      end
-    RUBY
-  end
-
-  it 'handles subjects in tests' do
-    expect_no_violations(<<-RUBY)
-      RSpec.describe User do
-        # This shouldn't really ever happen in a sane codebase but I still
-        # want to avoid false positives
-        it "doesn't mind me calling a method called subject in the test" do
-          let(foo)
-          subject { bar }
-        end
-      end
-    RUBY
-  end
-end