rubocop-rspec 1.4.1 → 1.5.0

data/spec/rubocop/cop/rspec/focus_spec.rb

@@ -0,0 +1,70 @@
+# encoding: utf-8
+
+describe RuboCop::Cop::RSpec::Focus do
+  subject(:cop) { described_class.new }
+
+  [
+    :example_group, :describe, :context, :xdescribe, :xcontext,
+    :it, :example, :specify, :xit, :xexample, :xspecify,
+    :feature, :scenario, :xfeature, :xscenario
+  ].each do |block_type|
+    it "finds `#{block_type}` blocks with `focus: true`" do
+      inspect_source(
+        cop,
+        [
+          "#{block_type} 'test', focus: true do",
+          'end'
+        ]
+      )
+      expect(cop.offenses.size).to eq(1)
+      expect(cop.offenses.map(&:line).sort).to eq([1])
+      expect(cop.messages).to eq(['Focused spec found.'])
+      expect(cop.highlights).to eq(['focus: true'])
+    end
+
+    it "finds `#{block_type}` blocks with `:focus`" do
+      inspect_source(
+        cop,
+        [
+          "#{block_type} 'test', :focus do",
+          'end'
+        ]
+      )
+      expect(cop.offenses.size).to eq(1)
+      expect(cop.offenses.map(&:line).sort).to eq([1])
+      expect(cop.messages).to eq(['Focused spec found.'])
+      expect(cop.highlights).to eq([':focus'])
+    end
+
+    it 'detects no offense when spec is not focused' do
+      inspect_source(
+        cop,
+        [
+          "#{block_type} 'test' do",
+          'end'
+        ]
+      )
+      expect(subject.messages).to be_empty
+    end
+  end
+
+  [
+    :fdescribe, :fcontext,
+    :focus, :fexample, :fit, :fspecify,
+    :ffeature, :fscenario
+  ].each do |block_type|
+    it "finds `#{block_type}` blocks" do
+      inspect_source(
+        cop,
+        [
+          "#{block_type} 'test' do",
+          'end'
+        ]
+      )
+      expect(cop.offenses.size).to eq(1)
+      expect(cop.offenses.map(&:line).sort).to eq([1])
+      expect(cop.messages).to eq(['Focused spec found.'])
+      expect(cop.highlights).to eq(["#{block_type} 'test'"])
+    end
+  end
+end

data/spec/rubocop/cop/rspec/instance_variable_spec.rb

@@ -4,27 +4,36 @@ describe RuboCop::Cop::RSpec::InstanceVariable do
   subject(:cop) { described_class.new }
 
   it 'finds an instance variable inside a describe' do
-    inspect_source(cop, ['describe MyClass do',
-                         '  before { @foo = [] }',
-                         '  it { expect(@foo).to be_empty }',
-                         'end'])
+    inspect_source(
+      cop,
+      [
+        'describe MyClass do',
+        '  before { @foo = [] }',
+        '  it { expect(@foo).to be_empty }',
+        'end'
+      ]
+    )
     expect(cop.offenses.size).to eq(1)
     expect(cop.offenses.map(&:line).sort).to eq([3])
     expect(cop.messages).to eq(['Use `let` instead of an instance variable'])
   end
 
   it 'finds an instance variable inside a shared example' do
-    inspect_source(cop, ["shared_examples 'shared example' do",
-                         '  it { expect(@foo).to be_empty }',
-                         'end'])
+    inspect_source(
+      cop,
+      [
+        "shared_examples 'shared example' do",
+        '  it { expect(@foo).to be_empty }',
+        'end'
+      ]
+    )
     expect(cop.offenses.size).to eq(1)
     expect(cop.offenses.map(&:line).sort).to eq([2])
     expect(cop.messages).to eq(['Use `let` instead of an instance variable'])
   end
 
   it 'ignores an instance variable without describe' do
-    inspect_source(cop, ['@foo = []',
-                         '@foo.empty?'])
+    inspect_source(cop, ['@foo = []', '@foo.empty?'])
     expect(cop.offenses).to be_empty
   end
 end

data/spec/rubocop/cop/rspec/multiple_describes_spec.rb

@@ -4,8 +4,13 @@ describe RuboCop::Cop::RSpec::MultipleDescribes do
   subject(:cop) { described_class.new }
 
   it 'finds multiple top level describes with class and method' do
-    inspect_source(cop, ["describe MyClass, '.do_something' do; end",
-                         "describe MyClass, '.do_something_else' do; end"])
+    inspect_source(
+      cop,
+      [
+        "describe MyClass, '.do_something' do; end",
+        "describe MyClass, '.do_something_else' do; end"
+      ]
+    )
     expect(cop.offenses.size).to eq(1)
     expect(cop.offenses.map(&:line).sort).to eq([1])
     expect(cop.messages).to eq(['Do not use multiple top level describes - ' \
@@ -13,8 +18,13 @@ describe RuboCop::Cop::RSpec::MultipleDescribes do
   end
 
   it 'finds multiple top level describes only with class' do
-    inspect_source(cop, ['describe MyClass do; end',
-                         'describe MyOtherClass do; end'])
+    inspect_source(
+      cop,
+      [
+        'describe MyClass do; end',
+        'describe MyOtherClass do; end'
+      ]
+    )
     expect(cop.offenses.size).to eq(1)
     expect(cop.offenses.map(&:line).sort).to eq([1])
     expect(cop.messages).to eq(['Do not use multiple top level describes - ' \
@@ -22,9 +32,14 @@ describe RuboCop::Cop::RSpec::MultipleDescribes do
   end
 
   it 'skips single top level describe' do
-    inspect_source(cop, ["require 'spec_helper'",
-                         '',
-                         'describe MyClass do; end'])
+    inspect_source(
+      cop,
+      [
+        "require 'spec_helper'",
+        '',
+        'describe MyClass do; end'
+      ]
+    )
     expect(cop.offenses).to be_empty
   end
 end

data/spec/rubocop/cop/rspec/not_to_not_spec.rb

@@ -3,13 +3,13 @@
 describe RuboCop::Cop::RSpec::NotToNot, :config do
   subject(:cop) { described_class.new(config) }
 
-  context 'when AcceptedMethod is `not_to`' do
-    let(:cop_config) { { 'AcceptedMethod' => 'not_to' } }
+  context 'when EnforcedStyle is `not_to`' do
+    let(:cop_config) { { 'EnforcedStyle' => 'not_to' } }
 
     it 'detects the `to_not` offense' do
       inspect_source(subject, 'it { expect(false).to_not be_true }')
 
-      expect(subject.messages).to eq(['Use `not_to` instead of `to_not`'])
+      expect(subject.messages).to eq(['Prefer `not_to` over `to_not`'])
       expect(subject.highlights).to eq(['expect(false).to_not be_true'])
       expect(subject.offenses.map(&:line).sort).to eq([1])
     end
@@ -19,15 +19,20 @@ describe RuboCop::Cop::RSpec::NotToNot, :config do
 
       expect(subject.messages).to be_empty
     end
+
+    it 'auto-corrects `to_not` to `not_to`' do
+      corrected = autocorrect_source(cop, ['it { expect(0).to_not equal 1 }'])
+      expect(corrected).to eq 'it { expect(0).not_to equal 1 }'
+    end
   end
 
   context 'when AcceptedMethod is `to_not`' do
-    let(:cop_config) { { 'AcceptedMethod' => 'to_not' } }
+    let(:cop_config) { { 'EnforcedStyle' => 'to_not' } }
 
     it 'detects the `not_to` offense' do
       inspect_source(subject, 'it { expect(false).not_to be_true }')
 
-      expect(subject.messages).to eq(['Use `to_not` instead of `not_to`'])
+      expect(subject.messages).to eq(['Prefer `to_not` over `not_to`'])
       expect(subject.highlights).to eq(['expect(false).not_to be_true'])
       expect(subject.offenses.map(&:line).sort).to eq([1])
     end
@@ -37,5 +42,10 @@ describe RuboCop::Cop::RSpec::NotToNot, :config do
 
       expect(subject.messages).to be_empty
     end
+
+    it 'auto-corrects `not_to` to `to_not`' do
+      corrected = autocorrect_source(cop, ['it { expect(0).not_to equal 1 }'])
+      expect(corrected).to eq 'it { expect(0).to_not equal 1 }'
+    end
   end
 end

data/spec/rubocop/cop/rspec/verified_doubles_spec.rb

@@ -1,9 +1,9 @@
 # encoding: utf-8
 
-describe RuboCop::Cop::RSpec::VerifiedDoubles do
-  subject(:cop) { described_class.new }
+describe RuboCop::Cop::RSpec::VerifiedDoubles, :config do
+  subject(:cop) { described_class.new(config) }
 
-  it 'finds `double` instead of a verifying double' do
+  it 'finds a `double` instead of an `instance_double`' do
     inspect_source(cop, ['it do',
                          '  foo = double("Widget")',
                          'end'])
@@ -12,4 +12,42 @@ describe RuboCop::Cop::RSpec::VerifiedDoubles do
     expect(cop.highlights).to eq(['double("Widget")'])
     expect(cop.offenses.map(&:line).sort).to eq([2])
   end
+
+  it 'finds a `spy` instead of an `instance_spy`' do
+    inspect_source(cop, ['it do',
+                         '  foo = spy("Widget")',
+                         'end'])
+    expect(cop.messages)
+      .to eq(['Prefer using verifying doubles over normal doubles.'])
+    expect(cop.highlights).to eq(['spy("Widget")'])
+    expect(cop.offenses.map(&:line).sort).to eq([2])
+  end
+
+  it 'find doubles whose name is a symbol' do
+    inspect_source(cop, ['it do',
+                         '  foo = double(:widget)',
+                         'end'])
+    expect(cop.messages)
+      .to eq(['Prefer using verifying doubles over normal doubles.'])
+    expect(cop.highlights).to eq(['double(:widget)'])
+    expect(cop.offenses.map(&:line).sort).to eq([2])
+  end
+
+  context 'when configured to ignore symbolic names' do
+    let(:cop_config) { { 'IgnoreSymbolicNames' => true } }
+
+    it 'ignores doubles whose name is a symbol' do
+      inspect_source(cop, ['it do',
+                           '  foo = double(:widget)',
+                           'end'])
+      expect(cop.messages).to be_empty
+    end
+  end
+
+  it 'ignores doubles without a name' do
+    inspect_source(cop, ['it do',
+                         '  foo = double',
+                         'end'])
+    expect(cop.messages).to be_empty
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rspec
 version: !ruby/object:Gem::Version
-  version: 1.4.1
+  version: 1.5.0
 platform: ruby
 authors:
 - Ian MacLeod
@@ -9,22 +9,22 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-03 00:00:00.000000000 Z
+date: 2016-05-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.39.0
+        version: 0.40.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.39.0
+        version: 0.40.0
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -90,8 +90,10 @@ files:
 - lib/rubocop/cop/rspec/describe_class.rb
 - lib/rubocop/cop/rspec/describe_method.rb
 - lib/rubocop/cop/rspec/described_class.rb
+- lib/rubocop/cop/rspec/example_length.rb
 - lib/rubocop/cop/rspec/example_wording.rb
 - lib/rubocop/cop/rspec/file_path.rb
+- lib/rubocop/cop/rspec/focus.rb
 - lib/rubocop/cop/rspec/instance_variable.rb
 - lib/rubocop/cop/rspec/multiple_describes.rb
 - lib/rubocop/cop/rspec/not_to_not.rb
@@ -105,8 +107,10 @@ files:
 - spec/rubocop/cop/rspec/describe_class_spec.rb
 - spec/rubocop/cop/rspec/describe_method_spec.rb
 - spec/rubocop/cop/rspec/described_class_spec.rb
+- spec/rubocop/cop/rspec/example_length_spec.rb
 - spec/rubocop/cop/rspec/example_wording_spec.rb
 - spec/rubocop/cop/rspec/file_path_spec.rb
+- spec/rubocop/cop/rspec/focus_spec.rb
 - spec/rubocop/cop/rspec/instance_variable_spec.rb
 - spec/rubocop/cop/rspec/multiple_describes_spec.rb
 - spec/rubocop/cop/rspec/not_to_not_spec.rb
@@ -142,8 +146,10 @@ test_files:
 - spec/rubocop/cop/rspec/describe_class_spec.rb
 - spec/rubocop/cop/rspec/describe_method_spec.rb
 - spec/rubocop/cop/rspec/described_class_spec.rb
+- spec/rubocop/cop/rspec/example_length_spec.rb
 - spec/rubocop/cop/rspec/example_wording_spec.rb
 - spec/rubocop/cop/rspec/file_path_spec.rb
+- spec/rubocop/cop/rspec/focus_spec.rb
 - spec/rubocop/cop/rspec/instance_variable_spec.rb
 - spec/rubocop/cop/rspec/multiple_describes_spec.rb
 - spec/rubocop/cop/rspec/not_to_not_spec.rb