rubocop-rspec 1.4.1 → 1.5.0

data/spec/rubocop/cop/rspec/describe_class_spec.rb

@@ -12,8 +12,13 @@ describe RuboCop::Cop::RSpec::DescribeClass do
   end
 
   it 'checks describe statements after a require' do
-    inspect_source(cop, ["require 'spec_helper'",
-                         'describe "bad describe" do; end'])
+    inspect_source(
+      cop,
+      [
+        "require 'spec_helper'",
+        'describe "bad describe" do; end'
+      ]
+    )
     expect(cop.offenses.size).to eq(1)
     expect(cop.offenses.map(&:line).sort).to eq([2])
     expect(cop.messages).to eq(['The first argument to describe should be ' \
@@ -21,9 +26,14 @@ describe RuboCop::Cop::RSpec::DescribeClass do
   end
 
   it 'ignores nested describe statements' do
-    inspect_source(cop, ['describe Some::Class do',
-                         '  describe "bad describe" do; end',
-                         'end'])
+    inspect_source(
+      cop,
+      [
+        'describe Some::Class do',
+        '  describe "bad describe" do; end',
+        'end'
+      ]
+    )
     expect(cop.offenses).to be_empty
   end
 
@@ -38,9 +48,14 @@ describe RuboCop::Cop::RSpec::DescribeClass do
   end
 
   it 'ignores feature specs - also with complex options' do
-    inspect_source(cop, ["describe 'my new feature',",
-                         '  :test, :type => :feature, :foo => :bar do;',
-                         'end'])
+    inspect_source(
+      cop,
+      [
+        "describe 'my new feature',",
+        '  :test, :type => :feature, :foo => :bar do;',
+        'end'
+      ]
+    )
     expect(cop.offenses).to be_empty
   end
 
@@ -49,6 +64,11 @@ describe RuboCop::Cop::RSpec::DescribeClass do
     expect(cop.offenses).to be_empty
   end
 
+  it 'ignores view specs' do
+    inspect_source(cop, "describe 'widgets/index', type: :view do; end")
+    expect(cop.offenses).to be_empty
+  end
+
   it "doesn't blow up on single-line describes" do
     inspect_source(cop, 'describe Some::Class')
     expect(cop.offenses).to be_empty

data/spec/rubocop/cop/rspec/described_class_spec.rb

@@ -4,11 +4,16 @@ describe RuboCop::Cop::RSpec::DescribedClass do
   subject(:cop) { described_class.new }
 
   it 'checks for the use of the described class' do
-    inspect_source(cop, ['describe MyClass do',
-                         '  include MyClass',
-                         '  subject { MyClass.do_something }',
-                         '  before { MyClass.do_something }',
-                         'end'])
+    inspect_source(
+      cop,
+      [
+        'describe MyClass do',
+        '  include MyClass',
+        '  subject { MyClass.do_something }',
+        '  before { MyClass.do_something }',
+        'end'
+      ]
+    )
     expect(cop.offenses.size).to eq(3)
     expect(cop.offenses.map(&:line).sort).to eq([2, 3, 4])
     expect(cop.messages)
@@ -17,41 +22,61 @@ describe RuboCop::Cop::RSpec::DescribedClass do
   end
 
   it 'ignores described class as string' do
-    inspect_source(cop, ['describe MyClass do',
-                         '  subject { "MyClass" }',
-                         'end'])
+    inspect_source(
+      cop,
+      [
+        'describe MyClass do',
+        '  subject { "MyClass" }',
+        'end'
+      ]
+    )
     expect(cop.offenses).to be_empty
   end
 
   it 'ignores describe that do not referece to a class' do
-    inspect_source(cop, ['describe "MyClass" do',
-                         '  subject { "MyClass" }',
-                         'end'])
+    inspect_source(
+      cop,
+      [
+        'describe "MyClass" do',
+        '  subject { "MyClass" }',
+        'end'
+      ]
+    )
     expect(cop.offenses).to be_empty
   end
 
   it 'ignores class if the scope is changing' do
-    inspect_source(cop, ['describe MyClass do',
-                         '  def method',
-                         '    include MyClass',
-                         '  end',
-                         '  class OtherClass',
-                         '    include MyClass',
-                         '  end',
-                         '  module MyModle',
-                         '    include MyClass',
-                         '  end',
-                         'end'])
+    inspect_source(
+      cop,
+      [
+        'describe MyClass do',
+        '  def method',
+        '    include MyClass',
+        '  end',
+        '  class OtherClass',
+        '    include MyClass',
+        '  end',
+        '  module MyModle',
+        '    include MyClass',
+        '  end',
+        'end'
+      ]
+    )
     expect(cop.offenses).to be_empty
   end
 
   it 'only takes class from top level describes' do
-    inspect_source(cop, ['describe MyClass do',
-                         '  describe MyClass::Foo do',
-                         '    subject { MyClass::Foo }',
-                         '    let(:foo) { MyClass }',
-                         '  end',
-                         'end'])
+    inspect_source(
+      cop,
+      [
+        'describe MyClass do',
+        '  describe MyClass::Foo do',
+        '    subject { MyClass::Foo }',
+        '    let(:foo) { MyClass }',
+        '  end',
+        'end'
+      ]
+    )
     expect(cop.offenses.size).to eq(1)
     expect(cop.offenses.map(&:line).sort).to eq([4])
     expect(cop.messages)
@@ -60,24 +85,39 @@ describe RuboCop::Cop::RSpec::DescribedClass do
   end
 
   it 'ignores subclasses' do
-    inspect_source(cop, ['describe MyClass do',
-                         '  subject { MyClass::SubClass }',
-                         'end'])
+    inspect_source(
+      cop,
+      [
+        'describe MyClass do',
+        '  subject { MyClass::SubClass }',
+        'end'
+      ]
+    )
     expect(cop.offenses).to be_empty
   end
 
   it 'ignores if namespace is not matching' do
-    inspect_source(cop, ['describe MyNamespace::MyClass do',
-                         '  subject { ::MyClass }',
-                         '  let(:foo) { MyClass }',
-                         'end'])
+    inspect_source(
+      cop,
+      [
+        'describe MyNamespace::MyClass do',
+        '  subject { ::MyClass }',
+        '  let(:foo) { MyClass }',
+        'end'
+      ]
+    )
     expect(cop.offenses).to be_empty
   end
 
   it 'checks for the use of described class with namespace' do
-    inspect_source(cop, ['describe MyNamespace::MyClass do',
-                         '  subject { MyNamespace::MyClass }',
-                         'end'])
+    inspect_source(
+      cop,
+      [
+        'describe MyNamespace::MyClass do',
+        '  subject { MyNamespace::MyClass }',
+        'end'
+      ]
+    )
     expect(cop.offenses.size).to eq(1)
     expect(cop.offenses.map(&:line).sort).to eq([2])
     expect(cop.messages)
@@ -87,11 +127,16 @@ describe RuboCop::Cop::RSpec::DescribedClass do
 
   it 'checks for the use of described class with module' do
     skip
-    inspect_source(cop, ['module MyNamespace',
-                         '  describe MyClass do',
-                         '    subject { MyNamespace::MyClass }',
-                         '  end',
-                         'end'])
+    inspect_source(
+      lcop,
+      [
+        'module MyNamespace',
+        '  describe MyClass do',
+        '    subject { MyNamespace::MyClass }',
+        '  end',
+        'end'
+      ]
+    )
     expect(cop.offenses.size).to eq(1)
     expect(cop.offenses.map(&:line).sort).to eq([2])
     expect(cop.messages)
@@ -100,15 +145,24 @@ describe RuboCop::Cop::RSpec::DescribedClass do
   end
 
   it 'autocorrects an offenses' do
-    new_source = autocorrect_source(cop, ['describe MyClass do',
-                                          '  include MyClass',
-                                          '  subject { MyClass.do_something }',
-                                          '  before { MyClass.do_something }',
-                                          'end'])
-    expect(new_source).to eq(['describe MyClass do',
-                              '  include described_class',
-                              '  subject { described_class.do_something }',
-                              '  before { described_class.do_something }',
-                              'end'].join("\n"))
+    new_source = autocorrect_source(
+      cop,
+      [
+        'describe MyClass do',
+        '  include MyClass',
+        '  subject { MyClass.do_something }',
+        '  before { MyClass.do_something }',
+        'end'
+      ]
+    )
+    expect(new_source).to eq(
+      [
+        'describe MyClass do',
+        '  include described_class',
+        '  subject { described_class.do_something }',
+        '  before { described_class.do_something }',
+        'end'
+      ].join("\n")
+    )
   end
 end

data/spec/rubocop/cop/rspec/example_length_spec.rb

@@ -0,0 +1,83 @@
+# encoding: utf-8
+
+describe RuboCop::Cop::RSpec::ExampleLength, :config do
+  subject(:cop) { described_class.new(config) }
+  let(:cop_config) { { 'Max' => 3 } }
+
+  it 'allows an empty example' do
+    inspect_source(
+      cop,
+      [
+        'it do',
+        'end'
+      ]
+    )
+    expect(cop.offenses).to be_empty
+  end
+
+  it 'allows a short example' do
+    inspect_source(
+      cop,
+      [
+        'it do',
+        '  line 1',
+        '  line 2',
+        '  line 3',
+        'end'
+      ]
+    )
+    expect(cop.offenses).to be_empty
+  end
+
+  it 'doesn\t allow a long example' do
+    inspect_source(
+      cop,
+      [
+        'it do',
+        '  line 1',
+        '  line 2',
+        '  line 3',
+        '  line 4',
+        'end'
+      ]
+    )
+    expect(cop.offenses.size).to eq(1)
+    expect(cop.offenses.map(&:line).sort).to eq([1])
+    expect(cop.messages).to eq(['Example has too many lines. [4/3]'])
+  end
+
+  it 'ignores comments' do
+    inspect_source(
+      cop,
+      [
+        'it do',
+        '  line 1',
+        '  line 2',
+        '  # comment',
+        '  line 3',
+        'end'
+      ]
+    )
+    expect(cop.offenses).to be_empty
+  end
+
+  context 'with CountComments enabled' do
+    before { cop_config['CountComments'] = true }
+
+    it 'counts comments' do
+      inspect_source(
+        cop, [
+          'it do',
+          '  line 1',
+          '  line 2',
+          '  # comment',
+          '  line 3',
+          'end'
+        ]
+      )
+      expect(cop.offenses.size).to eq(1)
+      expect(cop.offenses.map(&:line).sort).to eq([1])
+      expect(cop.messages).to eq(['Example has too many lines. [4/3]'])
+    end
+  end
+end

data/spec/rubocop/cop/rspec/example_wording_spec.rb

@@ -37,9 +37,14 @@ describe RuboCop::Cop::RSpec::ExampleWording, :config do
   end
 
   it 'skips descriptions without `should` at the beginning' do
-    inspect_source(cop, ["it 'finds no should ' \\",
-                         "   'here' do",
-                         'end'])
+    inspect_source(
+      cop,
+      [
+        "it 'finds no should ' \\",
+        "   'here' do",
+        'end'
+      ]
+    )
     expect(cop.offenses).to be_empty
   end
 
@@ -60,8 +65,10 @@ describe RuboCop::Cop::RSpec::ExampleWording, :config do
   end
 
   it "autocorrects shouldn't" do
-    new_source =
-      autocorrect_source(cop, 'it "shouldn\'t return something" do; end')
+    new_source = autocorrect_source(
+      cop,
+      'it "shouldn\'t return something" do; end'
+    )
     expect(new_source).to eq('it "does not return something" do; end')
   end
 end

data/spec/rubocop/cop/rspec/file_path_spec.rb

@@ -5,9 +5,11 @@ describe RuboCop::Cop::RSpec::FilePath, :config do
   let(:cop_config) { { 'CustomTransform' => { 'FooFoo' => 'foofoo' } } }
 
   it 'checks the path' do
-    inspect_source(cop,
-                   "describe MyClass, 'foo' do; end",
-                   'wrong_path_foo_spec.rb')
+    inspect_source(
+      cop,
+      "describe MyClass, 'foo' do; end",
+      'wrong_path_foo_spec.rb'
+    )
     expect(cop.offenses.size).to eq(1)
     expect(cop.offenses.map(&:line).sort).to eq([1])
     expect(cop.messages)
@@ -15,9 +17,11 @@ describe RuboCop::Cop::RSpec::FilePath, :config do
   end
 
   it 'checks the path' do
-    inspect_source(cop,
-                   "describe MyClass, '#foo' do; end",
-                   'wrong_class_foo_spec.rb')
+    inspect_source(
+      cop,
+      "describe MyClass, '#foo' do; end",
+      'wrong_class_foo_spec.rb'
+    )
     expect(cop.offenses.size).to eq(1)
     expect(cop.offenses.map(&:line).sort).to eq([1])
     expect(cop.messages)
@@ -25,9 +29,11 @@ describe RuboCop::Cop::RSpec::FilePath, :config do
   end
 
   it 'checks class spec paths' do
-    inspect_source(cop,
-                   'describe MyClass do; end',
-                   'wrong_class_spec.rb')
+    inspect_source(
+      cop,
+      'describe MyClass do; end',
+      'wrong_class_spec.rb'
+    )
     expect(cop.offenses.size).to eq(1)
     expect(cop.offenses.map(&:line).sort).to eq([1])
     expect(cop.messages)
@@ -35,24 +41,32 @@ describe RuboCop::Cop::RSpec::FilePath, :config do
   end
 
   it 'skips specs that do not describe a class / method' do
-    inspect_source(cop,
-                   "describe 'Test something' do; end",
-                   'some/class/spec.rb')
+    inspect_source(
+      cop,
+      "describe 'Test something' do; end",
+      'some/class/spec.rb'
+    )
     expect(cop.offenses).to be_empty
   end
 
   it 'skips specs that do have multiple top level describes' do
-    inspect_source(cop,
-                   ["describe MyClass, 'do_this' do; end",
-                    "describe MyClass, 'do_that' do; end"],
-                   'some/class/spec.rb')
+    inspect_source(
+      cop,
+      [
+        "describe MyClass, 'do_this' do; end",
+        "describe MyClass, 'do_that' do; end"
+      ],
+      'some/class/spec.rb'
+    )
     expect(cop.offenses).to be_empty
   end
 
   it 'ignores second argument if is not a string' do
-    inspect_source(cop,
-                   'describe MyClass, :foo do; end',
-                   'wrong_class_spec.rb')
+    inspect_source(
+      cop,
+      'describe MyClass, :foo do; end',
+      'wrong_class_spec.rb'
+    )
     expect(cop.offenses.size).to eq(1)
     expect(cop.offenses.map(&:line).sort).to eq([1])
     expect(cop.messages)
@@ -60,100 +74,146 @@ describe RuboCop::Cop::RSpec::FilePath, :config do
   end
 
   it 'checks class specs' do
-    inspect_source(cop,
-                   'describe Some::Class do; end',
-                   'some/class_spec.rb')
+    inspect_source(
+      cop,
+      'describe Some::Class do; end',
+      'some/class_spec.rb'
+    )
     expect(cop.offenses).to be_empty
   end
 
   it 'handles CamelCaps class names' do
-    inspect_source(cop,
-                   'describe MyClass do; end',
-                   'my_class_spec.rb')
+    inspect_source(
+      cop,
+      'describe MyClass do; end',
+      'my_class_spec.rb'
+    )
     expect(cop.offenses).to be_empty
   end
 
   it 'handles ACRONYMClassNames' do
-    inspect_source(cop,
-                   'describe ABCOne::Two do; end',
-                   'abc_one/two_spec.rb')
+    inspect_source(
+      cop,
+      'describe ABCOne::Two do; end',
+      'abc_one/two_spec.rb'
+    )
     expect(cop.offenses).to be_empty
   end
 
   it 'handles ALLCAPS class names' do
-    inspect_source(cop,
-                   'describe ALLCAPS do; end',
-                   'allcaps_spec.rb')
+    inspect_source(
+      cop,
+      'describe ALLCAPS do; end',
+      'allcaps_spec.rb'
+    )
+    expect(cop.offenses).to be_empty
+  end
+
+  it 'handles alphanumeric class names' do
+    inspect_source(
+      cop,
+      'describe IPV6 do; end',
+      'ipv6_spec.rb'
+    )
     expect(cop.offenses).to be_empty
   end
 
   it 'checks instance methods' do
-    inspect_source(cop,
-                   "describe Some::Class, '#inst' do; end",
-                   'some/class/inst_spec.rb')
+    inspect_source(
+      cop,
+      "describe Some::Class, '#inst' do; end",
+      'some/class/inst_spec.rb'
+    )
     expect(cop.offenses).to be_empty
   end
 
   it 'checks class methods' do
-    inspect_source(cop,
-                   "describe Some::Class, '.inst' do; end",
-                   'some/class/inst_spec.rb')
+    inspect_source(
+      cop,
+      "describe Some::Class, '.inst' do; end",
+      'some/class/inst_spec.rb'
+    )
     expect(cop.offenses).to be_empty
   end
 
   it 'allows flat hierarchies for instance methods' do
-    inspect_source(cop,
-                   "describe Some::Class, '#inst' do; end",
-                   'some/class_inst_spec.rb')
+    inspect_source(
+      cop,
+      "describe Some::Class, '#inst' do; end",
+      'some/class_inst_spec.rb'
+    )
     expect(cop.offenses).to be_empty
   end
 
   it 'allows flat hierarchies for class methods' do
-    inspect_source(cop,
-                   "describe Some::Class, '.inst' do; end",
-                   'some/class_inst_spec.rb')
+    inspect_source(
+      cop,
+      "describe Some::Class, '.inst' do; end",
+      'some/class_inst_spec.rb'
+    )
     expect(cop.offenses).to be_empty
   end
 
   it 'allows subdirs for instance methods' do
-    inspect_source(cop,
-                   "describe Some::Class, '#inst' do; end",
-                   'some/class/instance_methods/inst_spec.rb')
+    inspect_source(
+      cop,
+      "describe Some::Class, '#inst' do; end",
+      'some/class/instance_methods/inst_spec.rb'
+    )
     expect(cop.offenses).to be_empty
   end
 
   it 'allows subdirs for class methods' do
-    inspect_source(cop,
-                   "describe Some::Class, '.inst' do; end",
-                   'some/class/class_methods/inst_spec.rb')
+    inspect_source(
+      cop,
+      "describe Some::Class, '.inst' do; end",
+      'some/class/class_methods/inst_spec.rb'
+    )
     expect(cop.offenses).to be_empty
   end
 
   it 'ignores non-alphanumeric characters' do
-    inspect_source(cop,
-                   "describe Some::Class, '#pred?' do; end",
-                   'some/class/pred_spec.rb')
+    inspect_source(
+      cop,
+      "describe Some::Class, '#pred?' do; end",
+      'some/class/pred_spec.rb'
+    )
     expect(cop.offenses).to be_empty
   end
 
   it 'allows flexibility with predicates' do
-    inspect_source(cop,
-                   "describe Some::Class, '#thing?' do; end",
-                   'some/class/thing_predicate_spec.rb')
+    inspect_source(
+      cop,
+      "describe Some::Class, '#thing?' do; end",
+      'some/class/thing_predicate_spec.rb'
+    )
     expect(cop.offenses).to be_empty
   end
 
   it 'allows flexibility with operators' do
-    inspect_source(cop,
-                   "describe MyClass, '#<=>' do; end",
-                   'my_class/spaceship_operator_spec.rb')
+    inspect_source(
+      cop,
+      "describe MyClass, '#<=>' do; end",
+      'my_class/spaceship_operator_spec.rb'
+    )
     expect(cop.offenses).to be_empty
   end
 
   it 'respects custom module name transformation' do
-    inspect_source(cop,
-                   "describe FooFoo::Some::Class, '#bar' do; end",
-                   'foofoo/some/class/bar_spec.rb')
+    inspect_source(
+      cop,
+      "describe FooFoo::Some::Class, '#bar' do; end",
+      'foofoo/some/class/bar_spec.rb'
+    )
+    expect(cop.offenses).to be_empty
+  end
+
+  it 'ignores routing specs' do
+    inspect_source(
+      cop,
+      'describe MyController, type: :routing do; end',
+      'foofoo/some/class/bar_spec.rb'
+    )
     expect(cop.offenses).to be_empty
   end
 end