rubocop-rspec 1.27.0 → 1.28.0

data/lib/rubocop/cop/rspec/factory_bot/dynamic_attribute_defined_statically.rb

@@ -1,93 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module RSpec
-      module FactoryBot
-        # Prefer declaring dynamic attribute values in a block.
-        #
-        # @see StaticAttributeDefinedDynamically
-        #
-        # @example
-        #   # bad
-        #   kind [:active, :rejected].sample
-        #
-        #   # good
-        #   kind { [:active, :rejected].sample }
-        #
-        #   # bad
-        #   closed_at 1.day.from_now
-        #
-        #   # good
-        #   closed_at { 1.day.from_now }
-        class DynamicAttributeDefinedStatically < Cop
-          MSG = 'Use a block to set a dynamic value to an attribute.'.freeze
-
-          def_node_matcher :value_matcher, <<-PATTERN
-            (send nil? _ $...)
-          PATTERN
-
-          def_node_search :factory_attributes, <<-PATTERN
-            (block (send nil? {:factory :trait} ...) _ { (begin $...) $(send ...) } )
-          PATTERN
-
-          def on_block(node)
-            factory_attributes(node).to_a.flatten.each do |attribute|
-              next if static_or_proc?(attribute)
-              add_offense(attribute, location: :expression)
-            end
-          end
-
-          def autocorrect(node)
-            if !method_uses_parens?(node.location)
-              autocorrect_without_parens(node)
-            elsif value_hash_without_braces?(node.descendants.first)
-              autocorrect_hash_without_braces(node)
-            else
-              autocorrect_replacing_parens(node)
-            end
-          end
-
-          private
-
-          def static_or_proc?(attribute)
-            value_matcher(attribute).to_a.all? do |value|
-              value.block_pass_type? || value.recursive_literal_or_const?
-            end
-          end
-
-          def value_hash_without_braces?(node)
-            node.hash_type? && !node.braces?
-          end
-
-          def method_uses_parens?(location)
-            return false unless location.begin && location.end
-            location.begin.source == '(' && location.end.source == ')'
-          end
-
-          def autocorrect_hash_without_braces(node)
-            autocorrect_replacing_parens(node, ' { { ', ' } }')
-          end
-
-          def autocorrect_replacing_parens(node,
-                                           start_token = ' { ',
-                                           end_token = ' }')
-            lambda do |corrector|
-              corrector.replace(node.location.begin, start_token)
-              corrector.replace(node.location.end, end_token)
-            end
-          end
-
-          def autocorrect_without_parens(node)
-            lambda do |corrector|
-              arguments = node.descendants.first
-              expression = arguments.location.expression
-              corrector.insert_before(expression, '{ ')
-              corrector.insert_after(expression, ' }')
-            end
-          end
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/rspec/factory_bot/static_attribute_defined_dynamically.rb

@@ -1,81 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module RSpec
-      module FactoryBot
-        # Prefer declaring static attribute values without a block.
-        #
-        # @see DynamicAttributeDefinedStatically
-        #
-        # @example
-        #   # bad
-        #   kind { :static }
-        #
-        #   # good
-        #   kind :static
-        #
-        #   # bad
-        #   comments_count { 0 }
-        #
-        #   # good
-        #   comments_count 0
-        #
-        #   # bad
-        #   type { User::MAGIC }
-        #
-        #   # good
-        #   type User::MAGIC
-        class StaticAttributeDefinedDynamically < Cop
-          MSG = 'Do not use a block to set a static value ' \
-                'to an attribute.'.freeze
-
-          def_node_matcher :block_value_matcher, <<-PATTERN
-            (block (send nil? _) _ $...)
-          PATTERN
-
-          def_node_search :factory_attributes, <<-PATTERN
-            (block (send nil? { :factory :trait } ...) _ { (begin $...) $(send ...) $(block ...) } )
-          PATTERN
-
-          def on_block(node)
-            factory_attributes(node).to_a.flatten.each do |attribute|
-              values = block_value_matcher(attribute)
-              next if values.to_a.all? { |v| dynamic?(v) }
-              add_offense(attribute, location: :expression)
-            end
-          end
-
-          def autocorrect(node)
-            lambda do |corrector|
-              corrector.replace(
-                node.loc.expression,
-                autocorrected_source(node)
-              )
-            end
-          end
-
-          private
-
-          def dynamic?(node)
-            node && !node.recursive_literal_or_const?
-          end
-
-          def autocorrected_source(node)
-            "#{node.send_node.source}#{autocorrected_attribute(node.body)}"
-          end
-
-          def autocorrected_attribute(body)
-            if body.nil?
-              ' nil'
-            elsif body.hash_type?
-              "(#{body.source})"
-            else
-              ' ' + body.source
-            end
-          end
-        end
-      end
-    end
-  end
-end

data/spec/rubocop/cop/rspec/factory_bot/dynamic_attribute_defined_statically_spec.rb

@@ -1,139 +0,0 @@
-# frozen_string_literal: true
-
-# rubocop:disable Metrics/LineLength
-RSpec.describe RuboCop::Cop::RSpec::FactoryBot::DynamicAttributeDefinedStatically do
-  # rubocop:enable Metrics/LineLength
-
-  subject(:cop) { described_class.new(config) }
-
-  let(:config) { RuboCop::Config.new }
-
-  %w[FactoryBot FactoryGirl].each do |factory_bot|
-    context "when using #{factory_bot}" do
-      it 'registers an offense for offending code' do
-        expect_offense(<<-RUBY)
-          #{factory_bot}.define do
-            factory :post do
-              published_at 1.day.from_now
-              ^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use a block to set a dynamic value to an attribute.
-              status [:draft, :published].sample
-              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use a block to set a dynamic value to an attribute.
-              created_at 1.day.ago
-              ^^^^^^^^^^^^^^^^^^^^ Use a block to set a dynamic value to an attribute.
-              update_times [Time.current]
-              ^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use a block to set a dynamic value to an attribute.
-              meta_tags(foo: Time.current)
-              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use a block to set a dynamic value to an attribute.
-            end
-          end
-        RUBY
-      end
-
-      it 'registers an offense in a trait' do
-        expect_offense(<<-RUBY)
-          #{factory_bot}.define do
-            factory :post do
-              title "Something"
-              trait :published do
-                published_at 1.day.from_now
-                ^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use a block to set a dynamic value to an attribute.
-              end
-            end
-          end
-        RUBY
-      end
-
-      it 'accepts valid factory definitions' do
-        expect_no_offenses(<<-RUBY)
-          #{factory_bot}.define do
-            factory :post do
-              trait :published do
-                published_at { 1.day.from_now }
-              end
-              created_at { 1.day.ago }
-              status :draft
-              comments_count 0
-              title "Static"
-              description { FFaker::Lorem.paragraph(10) }
-              recent_statuses [:published, :draft]
-              meta_tags(like_count: 2)
-              other_tags({ foo: nil })
-
-              before(:create, &:initialize_something)
-              after(:create, &:rebuild_cache)
-            end
-          end
-        RUBY
-      end
-
-      it 'accepts const as a static value' do
-        expect_no_offenses(<<-RUBY)
-          #{factory_bot}.define do
-            factory(:post, class: PrivatePost) do
-              tag Tag::MAGIC
-              options({priority: Priotity::HIGH})
-            end
-          end
-        RUBY
-      end
-
-      it 'does not add offense if out of factory girl block' do
-        expect_no_offenses(<<-RUBY)
-          status [:draft, :published].sample
-          published_at 1.day.from_now
-          created_at 1.day.ago
-          update_times [Time.current]
-          meta_tags(foo: Time.current)
-        RUBY
-      end
-
-      it 'accepts valid sequence definition' do
-        expect_no_offenses(<<-RUBY)
-          #{factory_bot}.define do
-            factory :post do
-              sequence :negative_numbers, &:-@
-            end
-          end
-        RUBY
-      end
-
-      bad = <<-RUBY
-        #{factory_bot}.define do
-          factory :post do
-            status([:draft, :published].sample)
-            published_at 1.day.from_now
-            created_at(1.day.ago)
-            updated_at Time.current
-            update_times [Time.current]
-            meta_tags(foo: Time.current)
-            other_tags({ foo: Time.current })
-
-            trait :old do
-              published_at 1.week.ago
-            end
-          end
-        end
-      RUBY
-
-      corrected = <<-RUBY
-        #{factory_bot}.define do
-          factory :post do
-            status { [:draft, :published].sample }
-            published_at { 1.day.from_now }
-            created_at { 1.day.ago }
-            updated_at { Time.current }
-            update_times { [Time.current] }
-            meta_tags { { foo: Time.current } }
-            other_tags { { foo: Time.current } }
-
-            trait :old do
-              published_at { 1.week.ago }
-            end
-          end
-        end
-      RUBY
-
-      include_examples 'autocorrect', bad, corrected
-    end
-  end
-end

data/spec/rubocop/cop/rspec/factory_bot/static_attribute_defined_dynamically_spec.rb

@@ -1,107 +0,0 @@
-# frozen_string_literal: true
-
-# rubocop:disable Metrics/LineLength
-RSpec.describe RuboCop::Cop::RSpec::FactoryBot::StaticAttributeDefinedDynamically do
-  # rubocop:enable Metrics/LineLength
-
-  subject(:cop) { described_class.new(config) }
-
-  let(:config) { RuboCop::Config.new }
-
-  %w[FactoryBot FactoryGirl].each do |factory_bot|
-    context "when using #{factory_bot}" do
-      it 'registers an offense for offending code' do
-        expect_offense(<<-RUBY)
-          #{factory_bot}.define do
-            factory :post do
-              kind { :static }
-              ^^^^^^^^^^^^^^^^ Do not use a block to set a static value to an attribute.
-              comments_count { 0 }
-              ^^^^^^^^^^^^^^^^^^^^ Do not use a block to set a static value to an attribute.
-              type { User::MAGIC }
-              ^^^^^^^^^^^^^^^^^^^^ Do not use a block to set a static value to an attribute.
-              description { nil }
-              ^^^^^^^^^^^^^^^^^^^ Do not use a block to set a static value to an attribute.
-              recent_statuses { [:published, :draft] }
-              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not use a block to set a static value to an attribute.
-              meta_tags { { foo: 1 } }
-              ^^^^^^^^^^^^^^^^^^^^^^^^ Do not use a block to set a static value to an attribute.
-              title {}
-              ^^^^^^^^ Do not use a block to set a static value to an attribute.
-            end
-          end
-        RUBY
-      end
-
-      it 'registers an offense in a trait' do
-        expect_offense(<<-RUBY)
-          #{factory_bot}.define do
-            factory :post do
-              title "Something"
-              trait :something_else do
-                title { "Something Else" }
-                ^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not use a block to set a static value to an attribute.
-              end
-            end
-          end
-        RUBY
-      end
-
-      it 'accepts valid factory definitions' do
-        expect_no_offenses(<<-RUBY)
-          #{factory_bot}.define do
-            factory :post do
-              trait :something_else do
-                title "Something Else"
-              end
-              title "Something"
-              comments_count 0
-              description { FFaker::Lorem.paragraph(10) }
-              tag Tag::MAGIC
-              recent_updates { [Time.current] }
-              meta_tags { { first_like: Time.current } }
-              before(:create) { 'foo' }
-            end
-          end
-        RUBY
-      end
-
-      it 'does not add offense if out of factory girl block' do
-        expect_no_offenses(<<-RUBY)
-          kind { :static }
-          comments_count { 0 }
-          type { User::MAGIC }
-          description { nil }
-        RUBY
-      end
-
-      bad = <<-RUBY
-        #{factory_bot}.define do
-          factory :post do
-            comments_count { 0 }
-            type { User::MAGIC }
-            description { nil }
-            title {}
-            recent_statuses { [:published, :draft] }
-            meta_tags { { foo: 1 } }
-          end
-        end
-      RUBY
-
-      corrected = <<-RUBY
-        #{factory_bot}.define do
-          factory :post do
-            comments_count 0
-            type User::MAGIC
-            description nil
-            title nil
-            recent_statuses [:published, :draft]
-            meta_tags({ foo: 1 })
-          end
-        end
-      RUBY
-
-      include_examples 'autocorrect', bad, corrected
-    end
-  end
-end