rubocop-rspec 1.27.0 → 1.28.0

data/spec/rubocop/cop/rspec/let_before_examples_spec.rb

@@ -86,11 +86,6 @@ RSpec.describe RuboCop::Cop::RSpec::LetBeforeExamples do
     RUBY
   end
 
-  it 'does not encounter an error when handling an empty describe' do
-    expect { inspect_source('RSpec.describe(User) do end', 'a_spec.rb') }
-      .not_to raise_error
-  end
-
   bad_code = <<-RUBY
     RSpec.describe User do
       include_examples('should be after let')

data/spec/rubocop/cop/rspec/missing_example_group_argument_spec.rb

@@ -0,0 +1,55 @@
+RSpec.describe RuboCop::Cop::RSpec::MissingExampleGroupArgument do
+  subject(:cop) { described_class.new }
+
+  it 'accepts describe with an argument' do
+    expect_no_offenses(<<-RUBY)
+      describe FooClass do
+      end
+
+      RSpec.describe FooClass do
+      end
+    RUBY
+  end
+
+  it 'accepts methods with a name like an example block' do
+    expect_no_offenses(<<-RUBY)
+      Scenario.context do
+        'static'
+      end
+    RUBY
+  end
+
+  it 'checks first argument of describe' do
+    expect_offense(<<-RUBY)
+      describe do
+      ^^^^^^^^^^^ The first argument to `describe` should not be empty.
+      end
+
+      RSpec.describe do
+      ^^^^^^^^^^^^^^^^^ The first argument to `describe` should not be empty.
+      end
+    RUBY
+  end
+
+  it 'checks first argument of nested describe' do
+    expect_offense(<<-RUBY)
+      describe FooClass do
+        describe do
+        ^^^^^^^^^^^ The first argument to `describe` should not be empty.
+        end
+
+        RSpec.describe do
+        ^^^^^^^^^^^^^^^^^ The first argument to `describe` should not be empty.
+        end
+      end
+    RUBY
+  end
+
+  it 'checks first argument of context' do
+    expect_offense(<<-RUBY)
+      context do
+      ^^^^^^^^^^ The first argument to `context` should not be empty.
+      end
+    RUBY
+  end
+end

data/spec/rubocop/cop/rspec/overwriting_setup_spec.rb

@@ -86,9 +86,4 @@ RSpec.describe RuboCop::Cop::RSpec::OverwritingSetup do
       end
     RUBY
   end
-
-  it 'does not encounter an error when handling an empty describe' do
-    expect { inspect_source('RSpec.describe(User) do end', 'a_spec.rb') }
-      .not_to raise_error
-  end
 end

data/spec/rubocop/cop/rspec/receive_never_spec.rb

@@ -0,0 +1,45 @@
+# frozen_string_literal: true
+
+RSpec.describe RuboCop::Cop::RSpec::ReceiveNever do
+  subject(:cop) { described_class.new }
+
+  it 'flags usage of `never`' do
+    expect_offense(<<-RUBY)
+      expect(foo).to receive(:bar).never
+                                   ^^^^^ Use `not_to receive` instead of `never`.
+    RUBY
+  end
+
+  it 'flags usage of `never` after `with`' do
+    expect_offense(<<-RUBY)
+      expect(foo).to receive(:bar).with(baz).never
+                                             ^^^^^ Use `not_to receive` instead of `never`.
+    RUBY
+  end
+
+  it 'flags usage of `never` with `is_expected`' do
+    expect_offense(<<-RUBY)
+      is_expected.to receive(:bar).with(baz).never
+                                             ^^^^^ Use `not_to receive` instead of `never`.
+    RUBY
+  end
+
+  it 'flags usage of `never` with `expect_any_instance_of`' do
+    expect_offense(<<-RUBY)
+      expect_any_instance_of(Foo).to receive(:bar).with(baz).never
+                                                             ^^^^^ Use `not_to receive` instead of `never`.
+    RUBY
+  end
+
+  it 'allows method called `never`' do
+    expect_no_offenses(<<-RUBY)
+      expect(foo).to receive(:bar).with(Value.never)
+      expect(foo.never).to eq(bar.never)
+      is_expected.to be never
+    RUBY
+  end
+
+  include_examples 'autocorrect',
+                   'expect(foo).to receive(:bar).with(0).never',
+                   'expect(foo).not_to receive(:bar).with(0)'
+end

data/spec/rubocop/cop/rspec/scattered_let_spec.rb

@@ -23,9 +23,4 @@ RSpec.describe RuboCop::Cop::RSpec::ScatteredLet do
       end
     RUBY
   end
-
-  it 'does not encounter an error when handling an empty describe' do
-    expect { inspect_source('RSpec.describe(User) do end', 'a_spec.rb') }
-      .not_to raise_error
-  end
 end

data/spec/shared/smoke_test_examples.rb

@@ -0,0 +1,25 @@
+RSpec.shared_examples 'smoke test', type: :cop_spec do
+  context 'with default configuration' do
+    # This is overridden to avoid a number of specs that define `cop_config`
+    # (so it is referenced in the 'config' shared context) but do not define
+    # all of the dependent configuration options until inside of a context
+    # that is out of scope, causing a NameError.
+    let(:cop_config) { {} }
+
+    stress_tests = Pathname.glob('spec/smoke_tests/*.rb')
+
+    raise 'No smoke tests could be found!' if stress_tests.empty?
+
+    stress_tests.each do |path|
+      it "does not crash on smoke test: #{path}" do
+        source    = path.read
+        file_name = path.to_s
+
+        aggregate_failures do
+          expect { inspect_source(source, file_name) }.not_to raise_error
+          expect { autocorrect_source(source, file_name) }.not_to raise_error
+        end
+      end
+    end
+  end
+end

data/spec/smoke_tests/factory_bot_spec.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+# Since FactoryBot is not a dependency, none of this should be executed. We just
+# need the AST to exist.
+if false
+  FactoryBot.define do
+    factory :foo do
+      bar {}
+    end
+  end
+end

data/spec/smoke_tests/no_tests_spec.rb

@@ -0,0 +1,4 @@
+# frozen_string_literal:
+
+# This is sort of a test, but there's no rspec to see here.
+raise 'Uh oh, the Party seems to have gotten into ruby.' if 2 + 2 == 5

data/spec/smoke_tests/weird_rspec_spec.rb

@@ -0,0 +1,233 @@
+RSpec.describe 'Weirdness' do
+  subject! { nil }
+  subject { nil }
+  subject(:foo) { nil }
+  subject!(:foo) { nil }
+
+  subject! (:foo) { |something| nil }
+  subject  :foo  do end
+
+  let(:foo) { |something| something }
+  let (:foo) { 1 }
+  let!   (:bar){}
+
+  let :a do end
+
+  let(:bar) { <<-HEREDOC }
+    What a pain.
+  HEREDOC
+
+  let(:bar) { <<-'HEREDOC' }
+    Even odder.
+  HEREDOC
+
+  let(:baz) do
+    <<-INSIDE
+      Hi. I'm in your lets.
+    INSIDE
+  end
+
+  let(:hi)      {}
+  let(:bye) do
+  end
+
+  let(:doop) { foo; 1 }
+
+  it {}
+  specify {}
+
+  it 'works', metadata: true do
+  end
+
+  describe {}
+  context {}
+
+  describe '#nothing' do
+  end
+
+  it 'is empty' do
+  end
+
+  it '' do end
+  describe do end
+  context do end
+  shared_examples 'a' do end
+
+  describe 'things' do
+    context 'with context' do
+    end
+  end
+
+  shared_examples 'weird rspec' do
+  end
+
+  shared_examples :something do
+  end
+
+  context 'test' do
+    include_examples 'weird rspec'
+    include_examples('weird rspec', serious: true) do
+      it_behaves_like :something
+    end
+  end
+
+  it_behaves_like :something
+  it_should_behave_like :something
+
+  it_behaves_like :something do
+    let(:foo) { 'bar' }
+  end
+
+  it_behaves_like(:something) do |arg, *args, &block|
+  end
+
+  before {}
+  context 'never run' do
+    around {}
+  end
+  after {}
+
+  before { <<-DOC }
+   Eh, what's up?
+  DOC
+
+  around { |test| test.run; <<-DOC }
+   Eh, what's up?
+  DOC
+
+  after { <<-DOC }
+   Eh, what's up?
+  DOC
+
+  around do |test|
+    test.run
+  end
+
+  it 'is expecting you' do
+    expect('you').to eql('you')
+  end
+
+  it 'is expecting you not to raise an error' do
+    expect { 'you' }.not_to raise_error
+  end
+
+  it 'has chained expectations' do
+    expect('you').to eql('you').and(match(/y/))
+  end
+
+  %w[who likes dynamic examples].each do |word|
+    let(word) { word }
+
+    describe "#{word}" do
+      context "#{word}" do
+        it "lets the word '#{word}' be '#{word}'" do
+          expect(send(word)).to eql(word)
+        end
+      end
+    end
+  end
+
+  it { foo; 1 && 2}
+  it('has a description too') { foo; 1 && 2}
+
+  it %{quotes a string weird} do
+  end
+
+  it((' '.strip! ; 1 && 'isnt a simple string')) do
+    expect(nil).to be(nil)
+  end
+
+  it((' '.strip! ; 1 && 'isnt a simple string')) do
+    double = double(:foo)
+
+    allow(double).to receive(:oogabooga).with(nil).and_return(nil)
+
+    expect(double.oogabooga(nil)).to be(nil)
+
+    expect(double).to have_received(:oogabooga).once
+  end
+
+  it 'uses a matcher' do
+    expect([].empty?).to be(true)
+    expect([]).to be_empty
+  end
+
+  let(:klass) do
+    Class.new do
+      def initialize(thing)
+        @thing = thing
+      end
+
+      def announce
+        'wooo, so dynamic!'
+      end
+    end
+  end
+
+  it 'it does a thing' do
+  end
+
+  it 'It does a thing' do
+  end
+
+  it 'should not do the thing' do
+  end
+
+  specify do
+    foo = double(:bar)
+    allow(foo).to receive_message_chain(bar: 42, baz: 42)
+    allow(foo).to receive(:bar)
+    allow(foo).to receive_messages(bar: 42, baz: 42)
+  end
+end
+
+RSpec.describe {}
+RSpec.shared_examples('pointless') {}
+RSpec.shared_context('even pointless-er') {}
+RSpec.describe do end
+RSpec.shared_examples('pointless2') do end
+RSpec.shared_context('even pointless-er2') do end
+
+class Broken
+end
+
+RSpec.describe Broken do
+end
+
+RSpec.describe 'RubocopBug' do
+  subject { true }
+
+  before do
+    each_row = allow(double(:exporter)).to receive(:each_row)
+
+    [1, 2].each do |sig|
+      each_row = each_row.and_yield(sig)
+    end
+  end
+
+  it 'has a single example' do
+    expect(subject).to be_truthy
+  end
+
+  it 'has an expectation' do
+    stats = double(event: nil)
+
+    stats.event('tada!')
+
+    expect(stats)
+      .to have_received(:event)
+      .with('tada!')
+  end
+end
+
+RSpec.describe do
+  let(:uh_oh) { <<-HERE.strip + ", #{<<-THERE.strip}" }
+      Seriously
+  HERE
+      who designed these things?
+  THERE
+
+  it 'is insane' do
+    expect(uh_oh).to eql('Seriously, who designed these things?')
+  end
+end

data/spec/spec_helper.rb

@@ -15,6 +15,10 @@ spec_helper_glob = File.expand_path('{support,shared}/*.rb', __dir__)
 Dir.glob(spec_helper_glob).map(&method(:require))
 
 RSpec.configure do |config|
+  config.define_derived_metadata(file_path: %r{/spec/rubocop/cop/}) do |meta|
+    meta[:type] = :cop_spec
+  end
+
   config.order = :random
 
   config.expect_with :rspec do |expectations|

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rspec
 version: !ruby/object:Gem::Version
-  version: 1.27.0
+  version: 1.28.0
 platform: ruby
 authors:
 - John Backus
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-06-14 00:00:00.000000000 Z
+date: 2018-08-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -18,14 +18,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.56.0
+        version: 0.58.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.56.0
+        version: 0.58.0
 - !ruby/object:Gem::Dependency
   name: rack
   requirement: !ruby/object:Gem::Requirement
@@ -143,9 +143,8 @@ files:
 - lib/rubocop/cop/rspec/expect_change.rb
 - lib/rubocop/cop/rspec/expect_in_hook.rb
 - lib/rubocop/cop/rspec/expect_output.rb
+- lib/rubocop/cop/rspec/factory_bot/attribute_defined_statically.rb
 - lib/rubocop/cop/rspec/factory_bot/create_list.rb
-- lib/rubocop/cop/rspec/factory_bot/dynamic_attribute_defined_statically.rb
-- lib/rubocop/cop/rspec/factory_bot/static_attribute_defined_dynamically.rb
 - lib/rubocop/cop/rspec/file_path.rb
 - lib/rubocop/cop/rspec/focus.rb
 - lib/rubocop/cop/rspec/hook_argument.rb
@@ -161,6 +160,7 @@ files:
 - lib/rubocop/cop/rspec/message_chain.rb
 - lib/rubocop/cop/rspec/message_expectation.rb
 - lib/rubocop/cop/rspec/message_spies.rb
+- lib/rubocop/cop/rspec/missing_example_group_argument.rb
 - lib/rubocop/cop/rspec/multiple_describes.rb
 - lib/rubocop/cop/rspec/multiple_expectations.rb
 - lib/rubocop/cop/rspec/multiple_subjects.rb
@@ -172,6 +172,7 @@ files:
 - lib/rubocop/cop/rspec/predicate_matcher.rb
 - lib/rubocop/cop/rspec/rails/http_status.rb
 - lib/rubocop/cop/rspec/receive_counts.rb
+- lib/rubocop/cop/rspec/receive_never.rb
 - lib/rubocop/cop/rspec/repeated_description.rb
 - lib/rubocop/cop/rspec/repeated_example.rb
 - lib/rubocop/cop/rspec/return_from_stub.rb
@@ -235,9 +236,8 @@ files:
 - spec/rubocop/cop/rspec/expect_change_spec.rb
 - spec/rubocop/cop/rspec/expect_in_hook_spec.rb
 - spec/rubocop/cop/rspec/expect_output_spec.rb
+- spec/rubocop/cop/rspec/factory_bot/attribute_defined_statically_spec.rb
 - spec/rubocop/cop/rspec/factory_bot/create_list_spec.rb
-- spec/rubocop/cop/rspec/factory_bot/dynamic_attribute_defined_statically_spec.rb
-- spec/rubocop/cop/rspec/factory_bot/static_attribute_defined_dynamically_spec.rb
 - spec/rubocop/cop/rspec/file_path_spec.rb
 - spec/rubocop/cop/rspec/focus_spec.rb
 - spec/rubocop/cop/rspec/hook_argument_spec.rb
@@ -253,6 +253,7 @@ files:
 - spec/rubocop/cop/rspec/message_chain_spec.rb
 - spec/rubocop/cop/rspec/message_expectation_spec.rb
 - spec/rubocop/cop/rspec/message_spies_spec.rb
+- spec/rubocop/cop/rspec/missing_example_group_argument_spec.rb
 - spec/rubocop/cop/rspec/multiple_describes_spec.rb
 - spec/rubocop/cop/rspec/multiple_expectations_spec.rb
 - spec/rubocop/cop/rspec/multiple_subjects_spec.rb
@@ -264,6 +265,7 @@ files:
 - spec/rubocop/cop/rspec/predicate_matcher_spec.rb
 - spec/rubocop/cop/rspec/rails/http_status_spec.rb
 - spec/rubocop/cop/rspec/receive_counts_spec.rb
+- spec/rubocop/cop/rspec/receive_never_spec.rb
 - spec/rubocop/cop/rspec/repeated_description_spec.rb
 - spec/rubocop/cop/rspec/repeated_example_spec.rb
 - spec/rubocop/cop/rspec/return_from_stub_spec.rb
@@ -285,6 +287,11 @@ files:
 - spec/rubocop/rspec/wording_spec.rb
 - spec/shared/autocorrect_behavior.rb
 - spec/shared/detects_style_behavior.rb
+- spec/shared/smoke_test_examples.rb
+- spec/smoke_tests/empty_spec.rb
+- spec/smoke_tests/factory_bot_spec.rb
+- spec/smoke_tests/no_tests_spec.rb
+- spec/smoke_tests/weird_rspec_spec.rb
 - spec/spec_helper.rb
 - spec/support/expect_offense.rb
 homepage: https://github.com/rubocop-hq/rubocop-rspec
@@ -301,7 +308,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.1.0
+      version: 2.2.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -344,9 +351,8 @@ test_files:
 - spec/rubocop/cop/rspec/expect_change_spec.rb
 - spec/rubocop/cop/rspec/expect_in_hook_spec.rb
 - spec/rubocop/cop/rspec/expect_output_spec.rb
+- spec/rubocop/cop/rspec/factory_bot/attribute_defined_statically_spec.rb
 - spec/rubocop/cop/rspec/factory_bot/create_list_spec.rb
-- spec/rubocop/cop/rspec/factory_bot/dynamic_attribute_defined_statically_spec.rb
-- spec/rubocop/cop/rspec/factory_bot/static_attribute_defined_dynamically_spec.rb
 - spec/rubocop/cop/rspec/file_path_spec.rb
 - spec/rubocop/cop/rspec/focus_spec.rb
 - spec/rubocop/cop/rspec/hook_argument_spec.rb
@@ -362,6 +368,7 @@ test_files:
 - spec/rubocop/cop/rspec/message_chain_spec.rb
 - spec/rubocop/cop/rspec/message_expectation_spec.rb
 - spec/rubocop/cop/rspec/message_spies_spec.rb
+- spec/rubocop/cop/rspec/missing_example_group_argument_spec.rb
 - spec/rubocop/cop/rspec/multiple_describes_spec.rb
 - spec/rubocop/cop/rspec/multiple_expectations_spec.rb
 - spec/rubocop/cop/rspec/multiple_subjects_spec.rb
@@ -373,6 +380,7 @@ test_files:
 - spec/rubocop/cop/rspec/predicate_matcher_spec.rb
 - spec/rubocop/cop/rspec/rails/http_status_spec.rb
 - spec/rubocop/cop/rspec/receive_counts_spec.rb
+- spec/rubocop/cop/rspec/receive_never_spec.rb
 - spec/rubocop/cop/rspec/repeated_description_spec.rb
 - spec/rubocop/cop/rspec/repeated_example_spec.rb
 - spec/rubocop/cop/rspec/return_from_stub_spec.rb
@@ -394,5 +402,10 @@ test_files:
 - spec/rubocop/rspec/wording_spec.rb
 - spec/shared/autocorrect_behavior.rb
 - spec/shared/detects_style_behavior.rb
+- spec/shared/smoke_test_examples.rb
+- spec/smoke_tests/empty_spec.rb
+- spec/smoke_tests/factory_bot_spec.rb
+- spec/smoke_tests/no_tests_spec.rb
+- spec/smoke_tests/weird_rspec_spec.rb
 - spec/spec_helper.rb
 - spec/support/expect_offense.rb