rubocop-rspec 1.12.0 → 1.13.0

data/spec/rubocop/cop/rspec/repeated_description_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::Cop::RSpec::RepeatedDescription do
+RSpec.describe RuboCop::Cop::RSpec::RepeatedDescription do
   subject(:cop) { described_class.new }
 
   it 'registers an offense for repeated descriptions' do

data/spec/rubocop/cop/rspec/repeated_example_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::Cop::RSpec::RepeatedExample do
+RSpec.describe RuboCop::Cop::RSpec::RepeatedExample do
   subject(:cop) { described_class.new }
 
   it 'registers an offense for repeated example' do

data/spec/rubocop/cop/rspec/scattered_setup_spec.rb

@@ -1,4 +1,4 @@
-describe RuboCop::Cop::RSpec::ScatteredSetup do
+RSpec.describe RuboCop::Cop::RSpec::ScatteredSetup do
   subject(:cop) { described_class.new }
 
   it 'flags multiple hooks in the same example group' do

data/spec/rubocop/cop/rspec/shared_context_spec.rb

@@ -0,0 +1,142 @@
+RSpec.describe RuboCop::Cop::RSpec::SharedContext do
+  subject(:cop) { described_class.new }
+
+  context 'shared_context' do
+    it 'does not register an offense for empty contexts' do
+      expect_no_violations(<<-RUBY)
+        shared_context 'empty' do
+        end
+      RUBY
+    end
+
+    it 'registers an offense for shared_context with only examples' do
+      expect_violation(<<-RUBY)
+        shared_context 'foo' do
+        ^^^^^^^^^^^^^^^^^^^^ Use `shared_examples` when you don't define context.
+          it 'performs actions' do
+          end
+        end
+      RUBY
+    end
+
+    it 'does not register an offense for `shared_context` with let' do
+      expect_no_violations(<<-RUBY)
+        shared_context 'foo' do
+          let(:foo) { :bar }
+
+          it 'performs actions' do
+          end
+        end
+      RUBY
+    end
+
+    it 'does not register an offense for `shared_context` with subject' do
+      expect_no_violations(<<-RUBY)
+        shared_context 'foo' do
+          subject(:foo) { :bar }
+
+          it 'performs actions' do
+          end
+        end
+      RUBY
+    end
+
+    it 'does not register an offense for `shared_context` with before' do
+      expect_no_violations(<<-RUBY)
+        shared_context 'foo' do
+          before do
+            something
+          end
+
+          it 'performs actions' do
+          end
+        end
+      RUBY
+    end
+  end
+
+  context 'shared_examples' do
+    it 'does not register an offense for empty examples' do
+      expect_no_violations(<<-RUBY)
+        shared_examples 'empty' do
+        end
+      RUBY
+    end
+
+    it 'registers an offense for shared_examples with only let' do
+      expect_violation(<<-RUBY)
+        shared_examples 'foo' do
+        ^^^^^^^^^^^^^^^^^^^^^ Use `shared_context` when you don't define examples.
+          let(:foo) { :bar }
+        end
+      RUBY
+    end
+
+    it 'registers an offense for shared_examples with only subject' do
+      expect_violation(<<-RUBY)
+        shared_examples 'foo' do
+        ^^^^^^^^^^^^^^^^^^^^^ Use `shared_context` when you don't define examples.
+          subject(:foo) { :bar }
+        end
+      RUBY
+    end
+
+    it 'registers an offense for shared_examples with only hooks' do
+      expect_violation(<<-RUBY)
+        shared_examples 'foo' do
+        ^^^^^^^^^^^^^^^^^^^^^ Use `shared_context` when you don't define examples.
+          before do
+            foo
+          end
+        end
+      RUBY
+    end
+
+    it 'does not register an offense for `shared_examples` with it' do
+      expect_no_violations(<<-RUBY)
+        shared_examples 'foo' do
+          subject(:foo) { 'foo' }
+          let(:bar) { :baz }
+          before { initialize }
+
+          it 'works' do
+          end
+        end
+      RUBY
+    end
+  end
+
+  bad_shared_context = <<-RUBY
+    shared_context 'foo' do
+      it 'performs actions' do
+      end
+    end
+  RUBY
+
+  good_shared_context = <<-RUBY
+    shared_examples 'foo' do
+      it 'performs actions' do
+      end
+    end
+  RUBY
+
+  include_examples 'autocorrect',
+                   bad_shared_context,
+                   good_shared_context
+
+  bad_shared_examples = <<-RUBY
+    shared_examples 'foo' do
+      let(:foo) { :bar }
+    end
+  RUBY
+
+  good_shared_examples = <<-RUBY
+    shared_context 'foo' do
+      let(:foo) { :bar }
+    end
+  RUBY
+
+  include_examples 'autocorrect',
+                   bad_shared_examples,
+                   good_shared_examples
+end

data/spec/rubocop/cop/rspec/single_argument_message_chain_spec.rb

@@ -1,4 +1,4 @@
-describe RuboCop::Cop::RSpec::SingleArgumentMessageChain do
+RSpec.describe RuboCop::Cop::RSpec::SingleArgumentMessageChain do
   subject(:cop) { described_class.new }
 
   describe 'receive_message_chain' do
@@ -6,7 +6,7 @@ describe RuboCop::Cop::RSpec::SingleArgumentMessageChain do
       expect_violation(<<-RUBY)
         before do
           allow(foo).to receive_message_chain(:one) { :two }
-                        ^^^^^^^^^^^^^^^^^^^^^ Use `receive` instead of calling `receive_message_chain` with a single argument
+                        ^^^^^^^^^^^^^^^^^^^^^ Use `receive` instead of calling `receive_message_chain` with a single argument.
         end
       RUBY
     end
@@ -29,7 +29,7 @@ describe RuboCop::Cop::RSpec::SingleArgumentMessageChain do
       expect_violation(<<-RUBY)
         before do
           allow(foo).to receive_message_chain("one") { :two }
-                        ^^^^^^^^^^^^^^^^^^^^^ Use `receive` instead of calling `receive_message_chain` with a single argument
+                        ^^^^^^^^^^^^^^^^^^^^^ Use `receive` instead of calling `receive_message_chain` with a single argument.
         end
       RUBY
     end
@@ -54,7 +54,7 @@ describe RuboCop::Cop::RSpec::SingleArgumentMessageChain do
       expect_violation(<<-RUBY)
         before do
           foo.stub_chain(:one) { :two }
-              ^^^^^^^^^^ Use `stub` instead of calling `stub_chain` with a single argument
+              ^^^^^^^^^^ Use `stub` instead of calling `stub_chain` with a single argument.
         end
       RUBY
     end
@@ -77,7 +77,7 @@ describe RuboCop::Cop::RSpec::SingleArgumentMessageChain do
       expect_violation(<<-RUBY)
         before do
           foo.stub_chain("one") { :two }
-              ^^^^^^^^^^ Use `stub` instead of calling `stub_chain` with a single argument
+              ^^^^^^^^^^ Use `stub` instead of calling `stub_chain` with a single argument.
         end
       RUBY
     end

data/spec/rubocop/cop/rspec/subject_stub_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::Cop::RSpec::SubjectStub do
+RSpec.describe RuboCop::Cop::RSpec::SubjectStub do
   subject(:cop) { described_class.new }
 
   it 'complains when subject is stubbed' do

data/spec/rubocop/cop/rspec/verified_doubles_spec.rb

@@ -1,4 +1,4 @@
-describe RuboCop::Cop::RSpec::VerifiedDoubles, :config do
+RSpec.describe RuboCop::Cop::RSpec::VerifiedDoubles, :config do
   subject(:cop) { described_class.new(config) }
 
   it 'finds a `double` instead of an `instance_double`' do
@@ -11,7 +11,7 @@ describe RuboCop::Cop::RSpec::VerifiedDoubles, :config do
   end
 
   context 'when configuration does not specify IgnoreSymbolicNames' do
-    let(:cop_config) { Hash.new }
+    let(:cop_config) { {} }
 
     it 'find doubles whose name is a symbol' do
       expect_violation(<<-RUBY)

data/spec/rubocop/rspec/config_formatter_spec.rb

@@ -31,18 +31,18 @@ RSpec.describe RuboCop::RSpec::ConfigFormatter do
     formatter = described_class.new(config, descriptions)
 
     expect(formatter.dump).to eql(<<-YAML.gsub(/^\s+\|/, ''))
-    |---
-    |AllCops:
-    |  Setting: fourty two
-    |
-    |RSpec/Foo:
-    |  Config: 2
-    |  Enabled: true
-    |  Description: Blah
-    |
-    |RSpec/Bar:
-    |  Enabled: true
-    |  Description: Wow
+      |---
+      |AllCops:
+      |  Setting: fourty two
+      |
+      |RSpec/Foo:
+      |  Config: 2
+      |  Enabled: true
+      |  Description: Blah
+      |
+      |RSpec/Bar:
+      |  Enabled: true
+      |  Description: Wow
     YAML
   end
 end

data/spec/rubocop/rspec/description_extractor_spec.rb

@@ -5,32 +5,32 @@ require 'rubocop/rspec/description_extractor'
 RSpec.describe RuboCop::RSpec::DescriptionExtractor do
   let(:yardocs) do
     YARD.parse_string(<<-RUBY)
-    # This is not a cop
-    class RuboCop::Cop::Mixin::Sneaky
-    end
-
-    # This is not a concrete cop
-    #
-    # @abstract
-    class RuboCop::Cop::RSpec::Cop
-    end
-
-    # Checks foo
-    #
-    # Some description
-    #
-    # @note only works with foo
-    class RuboCop::Cop::RSpec::Foo
-      # Hello
-      def bar
+      # This is not a cop
+      class RuboCop::Cop::Mixin::Sneaky
       end
-    end
 
-    class RuboCop::Cop::RSpec::Undocumented
-      # Hello
-      def bar
+      # This is not a concrete cop
+      #
+      # @abstract
+      class RuboCop::Cop::RSpec::Cop
+      end
+
+      # Checks foo
+      #
+      # Some description
+      #
+      # @note only works with foo
+      class RuboCop::Cop::RSpec::Foo
+        # Hello
+        def bar
+        end
+      end
+
+      class RuboCop::Cop::RSpec::Undocumented
+        # Hello
+        def bar
+        end
       end
-    end
     RUBY
 
     YARD::Registry.all

data/spec/rubocop/rspec/example_group_spec.rb

@@ -7,21 +7,21 @@ RSpec.describe RuboCop::RSpec::ExampleGroup do
 
   let(:source) do
     <<-RUBY
-    RSpec.describe Foo do
-      it 'does x' do
-        x
-      end
+      RSpec.describe Foo do
+        it 'does x' do
+          x
+        end
 
-      it 'does y' do
-        y
-      end
+        it 'does y' do
+          y
+        end
 
-      context 'nested' do
-        it 'does z' do
-          z
+        context 'nested' do
+          it 'does z' do
+            z
+          end
         end
       end
-    end
     RUBY
   end
 

data/spec/rubocop/rspec/example_spec.rb

@@ -37,7 +37,7 @@ RSpec.describe RuboCop::RSpec::Example do
   end
 
   context 'value object semantics' do
-    it 'compares by value' do # rubocop:disable RSpec/MultipleExpectations
+    it 'compares by value' do
       aggregate_failures 'equality semantics' do
         expect(example('it("foo")')).to eq(example('it("foo")'))
         expect(example('it("foo")')).not_to eq(example('it("bar")'))

data/spec/rubocop/rspec/language/selector_set_spec.rb

@@ -1,4 +1,4 @@
-describe RuboCop::RSpec::Language::SelectorSet do
+RSpec.describe RuboCop::RSpec::Language::SelectorSet do
   subject(:selector_set) { described_class.new(%i(foo bar)) }
 
   it 'composes sets' do

data/spec/rubocop/rspec/util/one_spec.rb

@@ -1,4 +1,4 @@
-describe RuboCop::RSpec::Util, '.one' do
+RSpec.describe RuboCop::RSpec::Util, '.one' do
   let(:first)  { instance_double(Object)                          }
   let(:array)  { instance_double(Array, one?: true, first: first) }
   let(:client) { Class.new.extend(described_class)                }

data/spec/rubocop/rspec/wording_spec.rb

@@ -1,4 +1,4 @@
-describe RuboCop::RSpec::Wording do
+RSpec.describe RuboCop::RSpec::Wording do
   let(:replacements) do
     { 'have' => 'has', 'not' => 'does not' }
   end

data/spec/shared/detects_style_behavior.rb

@@ -1,8 +1,7 @@
-RSpec.shared_examples 'detects style' do |source, detected_style|
+RSpec.shared_examples 'detects style' do |source, style, filename: 'x_spec.rb'|
   it 'generates a todo based on the detected style' do
-    inspect_source(cop, source, 'foo_spec.rb')
+    inspect_source(cop, source, filename)
 
-    expect(cop.config_to_allow_offenses)
-      .to eq('EnforcedStyle' => detected_style)
+    expect(cop.config_to_allow_offenses).to eq('EnforcedStyle' => style)
   end
 end

data/spec/spec_helper.rb

@@ -25,6 +25,16 @@ RSpec.configure do |config|
     mocks.syntax = :expect # Disable `should_receive` and `stub`
   end
 
+  # Forbid RSpec from monkey patching any of our objects
+  config.disable_monkey_patching!
+
+  # We should address configuration warnings when we upgrade
+  config.raise_errors_for_deprecations!
+
+  # RSpec gives helpful warnings when you are doing something wrong.
+  # We should take their advice!
+  config.raise_on_warning = true
+
   config.include(ExpectViolation)
 end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-rspec
 version: !ruby/object:Gem::Version
-  version: 1.12.0
+  version: 1.13.0
 platform: ruby
 authors:
 - John Backus
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-22 00:00:00.000000000 Z
+date: 2017-03-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -163,6 +163,7 @@ files:
 - lib/rubocop/cop/rspec/implicit_expect.rb
 - lib/rubocop/cop/rspec/instance_spy.rb
 - lib/rubocop/cop/rspec/instance_variable.rb
+- lib/rubocop/cop/rspec/it_behaves_like.rb
 - lib/rubocop/cop/rspec/leading_subject.rb
 - lib/rubocop/cop/rspec/let_setup.rb
 - lib/rubocop/cop/rspec/message_chain.rb
@@ -176,6 +177,7 @@ files:
 - lib/rubocop/cop/rspec/repeated_description.rb
 - lib/rubocop/cop/rspec/repeated_example.rb
 - lib/rubocop/cop/rspec/scattered_setup.rb
+- lib/rubocop/cop/rspec/shared_context.rb
 - lib/rubocop/cop/rspec/single_argument_message_chain.rb
 - lib/rubocop/cop/rspec/subject_stub.rb
 - lib/rubocop/cop/rspec/verified_doubles.rb
@@ -217,6 +219,7 @@ files:
 - spec/rubocop/cop/rspec/implicit_expect_spec.rb
 - spec/rubocop/cop/rspec/instance_spy_spec.rb
 - spec/rubocop/cop/rspec/instance_variable_spec.rb
+- spec/rubocop/cop/rspec/it_behaves_like_spec.rb
 - spec/rubocop/cop/rspec/leading_subject_spec.rb
 - spec/rubocop/cop/rspec/let_setup_spec.rb
 - spec/rubocop/cop/rspec/message_chain_spec.rb
@@ -230,6 +233,7 @@ files:
 - spec/rubocop/cop/rspec/repeated_description_spec.rb
 - spec/rubocop/cop/rspec/repeated_example_spec.rb
 - spec/rubocop/cop/rspec/scattered_setup_spec.rb
+- spec/rubocop/cop/rspec/shared_context_spec.rb
 - spec/rubocop/cop/rspec/single_argument_message_chain_spec.rb
 - spec/rubocop/cop/rspec/subject_stub_spec.rb
 - spec/rubocop/cop/rspec/verified_doubles_spec.rb
@@ -293,6 +297,7 @@ test_files:
 - spec/rubocop/cop/rspec/implicit_expect_spec.rb
 - spec/rubocop/cop/rspec/instance_spy_spec.rb
 - spec/rubocop/cop/rspec/instance_variable_spec.rb
+- spec/rubocop/cop/rspec/it_behaves_like_spec.rb
 - spec/rubocop/cop/rspec/leading_subject_spec.rb
 - spec/rubocop/cop/rspec/let_setup_spec.rb
 - spec/rubocop/cop/rspec/message_chain_spec.rb
@@ -306,6 +311,7 @@ test_files:
 - spec/rubocop/cop/rspec/repeated_description_spec.rb
 - spec/rubocop/cop/rspec/repeated_example_spec.rb
 - spec/rubocop/cop/rspec/scattered_setup_spec.rb
+- spec/rubocop/cop/rspec/shared_context_spec.rb
 - spec/rubocop/cop/rspec/single_argument_message_chain_spec.rb
 - spec/rubocop/cop/rspec/subject_stub_spec.rb
 - spec/rubocop/cop/rspec/verified_doubles_spec.rb