rubocop-rspec 1.12.0 → 1.13.0

data/spec/rubocop/cop/rspec/focus_spec.rb

@@ -1,4 +1,4 @@
-describe RuboCop::Cop::RSpec::Focus do
+RSpec.describe RuboCop::Cop::RSpec::Focus do
   subject(:cop) { described_class.new }
 
   # rubocop:disable RSpec/ExampleLength

data/spec/rubocop/cop/rspec/hook_argument_spec.rb

@@ -1,14 +1,12 @@
 # encoding: utf-8
 
-describe RuboCop::Cop::RSpec::HookArgument, :config do
+RSpec.describe RuboCop::Cop::RSpec::HookArgument, :config do
   subject(:cop) { described_class.new(config) }
 
   let(:cop_config) do
     { 'EnforcedStyle' => enforced_style }
   end
 
-  let(:enforced_style) { :implicit }
-
   shared_examples 'ignored hooks' do
     it 'ignores :context and :suite' do
       expect_no_violations(<<-RUBY)

data/spec/rubocop/cop/rspec/implicit_expect_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::Cop::RSpec::ImplicitExpect, :config do
+RSpec.describe RuboCop::Cop::RSpec::ImplicitExpect, :config do
   subject(:cop) { described_class.new(config) }
 
   context 'when EnforcedStyle is is_expected' do

data/spec/rubocop/cop/rspec/instance_spy_spec.rb

@@ -1,4 +1,4 @@
-describe RuboCop::Cop::RSpec::InstanceSpy do
+RSpec.describe RuboCop::Cop::RSpec::InstanceSpy do
   subject(:cop) { described_class.new }
 
   context 'when used with `have_received`' do
@@ -6,7 +6,7 @@ describe RuboCop::Cop::RSpec::InstanceSpy do
       expect_violation(<<-RUBY)
         it do
           foo = instance_double(Foo).as_null_object
-                ^^^^^^^^^^^^^^^^^^^^ Use `instance_spy` when you check your double with `have_received`
+                ^^^^^^^^^^^^^^^^^^^^ Use `instance_spy` when you check your double with `have_received`.
           expect(foo).to have_received(:bar)
         end
       RUBY
@@ -16,7 +16,7 @@ describe RuboCop::Cop::RSpec::InstanceSpy do
       expect_violation(<<-RUBY)
         it do
           foo = instance_double(Foo, :name).as_null_object
-                ^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use `instance_spy` when you check your double with `have_received`
+                ^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use `instance_spy` when you check your double with `have_received`.
           expect(foo).to have_received(:bar)
         end
       RUBY
@@ -44,16 +44,16 @@ describe RuboCop::Cop::RSpec::InstanceSpy do
   end
 
   original = <<-RUBY
-  it do
-    foo = instance_double(Foo, :name).as_null_object
-    expect(foo).to have_received(:bar)
-  end
+    it do
+      foo = instance_double(Foo, :name).as_null_object
+      expect(foo).to have_received(:bar)
+    end
   RUBY
   corrected = <<-RUBY
-  it do
-    foo = instance_spy(Foo, :name)
-    expect(foo).to have_received(:bar)
-  end
+    it do
+      foo = instance_spy(Foo, :name)
+      expect(foo).to have_received(:bar)
+    end
   RUBY
 
   include_examples 'autocorrect', original, corrected

data/spec/rubocop/cop/rspec/instance_variable_spec.rb

@@ -1,4 +1,4 @@
-describe RuboCop::Cop::RSpec::InstanceVariable do
+RSpec.describe RuboCop::Cop::RSpec::InstanceVariable do
   subject(:cop) { described_class.new }
 
   it 'finds an instance variable inside a describe' do
@@ -6,7 +6,7 @@ describe RuboCop::Cop::RSpec::InstanceVariable do
       describe MyClass do
         before { @foo = [] }
         it { expect(@foo).to be_empty }
-                    ^^^^ Use `let` instead of an instance variable
+                    ^^^^ Use `let` instead of an instance variable.
       end
     RUBY
   end
@@ -24,7 +24,7 @@ describe RuboCop::Cop::RSpec::InstanceVariable do
     expect_violation(<<-RUBY)
       shared_examples 'shared example' do
         it { expect(@foo).to be_empty }
-                    ^^^^ Use `let` instead of an instance variable
+                    ^^^^ Use `let` instead of an instance variable.
       end
     RUBY
   end
@@ -59,7 +59,7 @@ describe RuboCop::Cop::RSpec::InstanceVariable do
         describe MyClass do
           before { @foo = [] }
           it { expect(@foo).to be_empty }
-                      ^^^^ Use `let` instead of an instance variable
+                      ^^^^ Use `let` instead of an instance variable.
         end
       RUBY
     end

data/spec/rubocop/cop/rspec/it_behaves_like_spec.rb

@@ -0,0 +1,51 @@
+# encoding: utf-8
+
+RSpec.describe RuboCop::Cop::RSpec::ItBehavesLike, :config do
+  subject(:cop) { described_class.new(config) }
+
+  let(:cop_config) do
+    { 'EnforcedStyle' => enforced_style }
+  end
+
+  context 'when the enforced style is `it_behaves_like`' do
+    let(:enforced_style) { :it_behaves_like }
+
+    it 'flags a violation for it_should_behave_like' do
+      expect_violation(<<-RUBY)
+        it_should_behave_like 'a foo'
+        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer `it_behaves_like` over `it_should_behave_like` when including examples in a nested context.
+      RUBY
+    end
+
+    it 'does not flag a violation for it_behaves_like' do
+      expect_no_violations("it_behaves_like 'a foo'")
+    end
+
+    include_examples(
+      'autocorrect',
+      "foo(); it_should_behave_like 'a foo'",
+      "foo(); it_behaves_like 'a foo'"
+    )
+  end
+
+  context 'when the enforced style is `it_should_behave_like`' do
+    let(:enforced_style) { :it_should_behave_like }
+
+    it 'flags a violation for it_behaves_like' do
+      expect_violation(<<-RUBY)
+        it_behaves_like 'a foo'
+        ^^^^^^^^^^^^^^^^^^^^^^^ Prefer `it_should_behave_like` over `it_behaves_like` when including examples in a nested context.
+      RUBY
+    end
+
+    it 'does not flag a violation for it_behaves_like' do
+      expect_no_violations("it_should_behave_like 'a foo'")
+    end
+
+    include_examples(
+      'autocorrect',
+      "foo(); it_behaves_like 'a foo'",
+      "foo(); it_should_behave_like 'a foo'"
+    )
+  end
+end

data/spec/rubocop/cop/rspec/leading_subject_spec.rb

@@ -9,7 +9,7 @@ RSpec.describe RuboCop::Cop::RSpec::LeadingSubject do
         let(:params) { foo }
 
         subject { described_class.new }
-        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Declare `subject` above any other `let` declarations
+        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Declare `subject` above any other `let` declarations.
       end
     RUBY
   end

data/spec/rubocop/cop/rspec/let_setup_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::Cop::RSpec::LetSetup do
+RSpec.describe RuboCop::Cop::RSpec::LetSetup do
   subject(:cop) { described_class.new }
 
   it 'complains when let! is used and not referenced' do

data/spec/rubocop/cop/rspec/message_chain_spec.rb

@@ -1,11 +1,11 @@
-describe RuboCop::Cop::RSpec::MessageChain do
+RSpec.describe RuboCop::Cop::RSpec::MessageChain do
   subject(:cop) { described_class.new }
 
   it 'finds `receive_message_chain`' do
     expect_violation(<<-RUBY)
       before do
         allow(foo).to receive_message_chain(:one, :two) { :three }
-                      ^^^^^^^^^^^^^^^^^^^^^ Avoid stubbing using `receive_message_chain`
+                      ^^^^^^^^^^^^^^^^^^^^^ Avoid stubbing using `receive_message_chain`.
       end
     RUBY
   end
@@ -14,7 +14,7 @@ describe RuboCop::Cop::RSpec::MessageChain do
     expect_violation(<<-RUBY)
       before do
         foo.stub_chain(:one, :two).and_return(:three)
-            ^^^^^^^^^^ Avoid stubbing using `stub_chain`
+            ^^^^^^^^^^ Avoid stubbing using `stub_chain`.
       end
     RUBY
   end

data/spec/rubocop/cop/rspec/message_expectation_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::Cop::RSpec::MessageExpectation, :config do
+RSpec.describe RuboCop::Cop::RSpec::MessageExpectation, :config do
   subject(:cop) { described_class.new(config) }
 
   context 'when EnforcedStyle is allow' do
@@ -19,17 +19,8 @@ describe RuboCop::Cop::RSpec::MessageExpectation, :config do
       expect_no_violations('allow(foo).to receive(:bar)')
     end
 
-    it 'generates a todo based on the usage of the correct style' do
-      inspect_source(cop, 'allow(foo).to receive(:bar)', 'foo_spec.rb')
-
-      expect(cop.config_to_allow_offenses).to eq('EnforcedStyle' => 'allow')
-    end
-
-    it 'generates a todo based on the usage of the alternate style' do
-      inspect_source(cop, 'expect(foo).to receive(:bar)', 'foo_spec.rb')
-
-      expect(cop.config_to_allow_offenses).to eq('EnforcedStyle' => 'expect')
-    end
+    include_examples 'detects style', 'allow(foo).to receive(:bar)',  'allow'
+    include_examples 'detects style', 'expect(foo).to receive(:bar)', 'expect'
   end
 
   context 'when EnforcedStyle is expect' do
@@ -48,16 +39,7 @@ describe RuboCop::Cop::RSpec::MessageExpectation, :config do
       expect_no_violations('expect(foo).to receive(:bar)')
     end
 
-    it 'generates a todo based on the usage of the correct style' do
-      inspect_source(cop, 'expect(foo).to receive(:bar)', 'foo_spec.rb')
-
-      expect(cop.config_to_allow_offenses).to eq('EnforcedStyle' => 'expect')
-    end
-
-    it 'generates a todo based on the usage of the alternate style' do
-      inspect_source(cop, 'allow(foo).to receive(:bar)', 'foo_spec.rb')
-
-      expect(cop.config_to_allow_offenses).to eq('EnforcedStyle' => 'allow')
-    end
+    include_examples 'detects style', 'expect(foo).to receive(:bar)', 'expect'
+    include_examples 'detects style', 'allow(foo).to receive(:bar)',  'allow'
   end
 end

data/spec/rubocop/cop/rspec/message_spies_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::Cop::RSpec::MessageSpies, :config do
+RSpec.describe RuboCop::Cop::RSpec::MessageSpies, :config do
   subject(:cop) { described_class.new(config) }
 
   context 'when EnforcedStyle is have_received' do
@@ -69,18 +69,11 @@ describe RuboCop::Cop::RSpec::MessageSpies, :config do
       expect_no_violations('expect(foo).to have_received(:bar)')
     end
 
-    it 'generates a todo based on the usage of the correct style' do
-      inspect_source(cop, 'expect(foo).to have_received(:bar)', 'foo_spec.rb')
+    include_examples 'detects style', 'expect(foo).to receive(:bar)', 'receive'
 
-      expect(cop.config_to_allow_offenses)
-        .to eq('EnforcedStyle' => 'have_received')
-    end
-
-    it 'generates a todo based on the usage of the alternate style' do
-      inspect_source(cop, 'expect(foo).to receive(:bar)', 'foo_spec.rb')
-
-      expect(cop.config_to_allow_offenses).to eq('EnforcedStyle' => 'receive')
-    end
+    include_examples 'detects style',
+                     'expect(foo).to have_received(:bar)',
+                     'have_received'
   end
 
   context 'when EnforcedStyle is receive' do
@@ -149,17 +142,10 @@ describe RuboCop::Cop::RSpec::MessageSpies, :config do
       expect_no_violations('expect(foo).to receive(:bar)')
     end
 
-    it 'generates a todo based on the usage of the correct style' do
-      inspect_source(cop, 'expect(foo).to receive(:bar)', 'foo_spec.rb')
+    include_examples 'detects style', 'expect(foo).to receive(:bar)', 'receive'
 
-      expect(cop.config_to_allow_offenses).to eq('EnforcedStyle' => 'receive')
-    end
-
-    it 'generates a todo based on the usage of the alternate style' do
-      inspect_source(cop, 'expect(foo).to have_received(:bar)', 'foo_spec.rb')
-
-      expect(cop.config_to_allow_offenses)
-        .to eq('EnforcedStyle' => 'have_received')
-    end
+    include_examples 'detects style',
+                     'expect(foo).to have_received(:bar)',
+                     'have_received'
   end
 end

data/spec/rubocop/cop/rspec/multiple_describes_spec.rb

@@ -1,4 +1,4 @@
-describe RuboCop::Cop::RSpec::MultipleDescribes do
+RSpec.describe RuboCop::Cop::RSpec::MultipleDescribes do
   subject(:cop) { described_class.new }
 
   it 'finds multiple top level describes with class and method' do

data/spec/rubocop/cop/rspec/multiple_expectations_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::Cop::RSpec::MultipleExpectations, :config do
+RSpec.describe RuboCop::Cop::RSpec::MultipleExpectations, :config do
   subject(:cop) { described_class.new(config) }
 
   context 'without configuration' do
@@ -10,7 +10,7 @@ describe RuboCop::Cop::RSpec::MultipleExpectations, :config do
       expect_violation(<<-RUBY)
         describe Foo do
           it 'uses expect twice' do
-          ^^^^^^^^^^^^^^^^^^^^^^ Example has too many expectations [2/1]
+          ^^^^^^^^^^^^^^^^^^^^^^ Example has too many expectations [2/1].
             expect(foo).to eq(bar)
             expect(baz).to eq(bar)
           end
@@ -31,6 +31,69 @@ describe RuboCop::Cop::RSpec::MultipleExpectations, :config do
         end
       RUBY
     end
+
+    it 'counts aggregate_failures as one expectation' do
+      expect_no_violations(<<-RUBY)
+        describe Foo do
+          it 'aggregates failures' do
+            aggregate_failures do
+              expect(foo).to eq(bar)
+              expect(baz).to eq(bar)
+            end
+          end
+        end
+      RUBY
+    end
+
+    it 'counts every aggregate_failures as an expectation' do
+      expect_violation(<<-RUBY)
+        describe Foo do
+          it 'has multiple aggregate_failures calls' do
+          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Example has too many expectations [2/1].
+            aggregate_failures do
+            end
+            aggregate_failures do
+            end
+          end
+        end
+      RUBY
+    end
+  end
+
+  context 'with meta data' do
+    it 'ignores examples with `:aggregate_failures`' do
+      expect_no_violations(<<-RUBY)
+        describe Foo do
+          it 'uses expect twice', :aggregate_failures do
+            expect(foo).to eq(bar)
+            expect(baz).to eq(bar)
+          end
+        end
+      RUBY
+    end
+
+    it 'ignores examples with `aggregate_failures: true`' do
+      expect_no_violations(<<-RUBY)
+        describe Foo do
+          it 'uses expect twice', aggregate_failures: true do
+            expect(foo).to eq(bar)
+            expect(baz).to eq(bar)
+          end
+        end
+      RUBY
+    end
+
+    it 'checks examples with `aggregate_failures: false`' do
+      expect_violation(<<-RUBY)
+        describe Foo do
+          it 'uses expect twice', aggregate_failures: false do
+          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Example has too many expectations [2/1].
+            expect(foo).to eq(bar)
+            expect(baz).to eq(bar)
+          end
+        end
+      RUBY
+    end
   end
 
   context 'with configuration' do
@@ -53,7 +116,7 @@ describe RuboCop::Cop::RSpec::MultipleExpectations, :config do
       expect_violation(<<-RUBY)
         describe Foo do
           it 'uses expect three times' do
-          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Example has too many expectations [3/2]
+          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Example has too many expectations [3/2].
             expect(foo).to eq(bar)
             expect(baz).to eq(bar)
             expect(qux).to eq(bar)

data/spec/rubocop/cop/rspec/nested_groups_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe RuboCop::Cop::RSpec::NestedGroups, :config do
+RSpec.describe RuboCop::Cop::RSpec::NestedGroups, :config do
   subject(:cop) { described_class.new(config) }
 
   it 'flags nested contexts' do
@@ -9,7 +9,7 @@ describe RuboCop::Cop::RSpec::NestedGroups, :config do
         context 'when foo' do
           context 'when bar' do
             context 'when baz' do
-            ^^^^^^^^^^^^^^^^^^ Maximum example group nesting exceeded
+            ^^^^^^^^^^^^^^^^^^ Maximum example group nesting exceeded [4/3].
             end
           end
         end
@@ -41,9 +41,9 @@ describe RuboCop::Cop::RSpec::NestedGroups, :config do
         describe MyClass do
           context 'when foo' do
             context 'when bar' do
-            ^^^^^^^^^^^^^^^^^^ Maximum example group nesting exceeded
+            ^^^^^^^^^^^^^^^^^^ Maximum example group nesting exceeded [3/2].
               context 'when baz' do
-              ^^^^^^^^^^^^^^^^^^ Maximum example group nesting exceeded
+              ^^^^^^^^^^^^^^^^^^ Maximum example group nesting exceeded [4/2].
               end
             end
           end

data/spec/rubocop/cop/rspec/not_to_not_spec.rb

@@ -1,4 +1,4 @@
-describe RuboCop::Cop::RSpec::NotToNot, :config do
+RSpec.describe RuboCop::Cop::RSpec::NotToNot, :config do
   subject(:cop) { described_class.new(config) }
 
   context 'when EnforcedStyle is `not_to`' do
@@ -7,7 +7,7 @@ describe RuboCop::Cop::RSpec::NotToNot, :config do
     it 'detects the `to_not` offense' do
       expect_violation(<<-RUBY)
         it { expect(false).to_not be_true }
-             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer `not_to` over `to_not`
+             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer `not_to` over `to_not`.
       RUBY
     end
 
@@ -28,7 +28,7 @@ describe RuboCop::Cop::RSpec::NotToNot, :config do
     it 'detects the `not_to` offense' do
       expect_violation(<<-RUBY)
         it { expect(false).not_to be_true }
-             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer `to_not` over `not_to`
+             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer `to_not` over `not_to`.
       RUBY
     end