rubocop-airbnb 1.0.0 → 1.3.0

data/lib/rubocop/airbnb/version.rb

@@ -3,6 +3,6 @@
 module RuboCop
   module Airbnb
     # Version information for the the Airbnb RuboCop plugin.
-    VERSION = '1.0.0'.freeze
+    VERSION = '1.3.0'.freeze
   end
 end

data/lib/rubocop/cop/airbnb/simple_unless.rb

@@ -0,0 +1,19 @@
+module RuboCop
+  module Cop
+    module Airbnb
+      # Cop to tackle prevent unless statements with multiple conditions
+      # https://github.com/airbnb/ruby#unless-with-multiple-conditions
+      class SimpleUnless < Cop
+        MSG = 'Unless usage is okay when there is only one conditional'.freeze
+
+        def_node_matcher :multiple_conditionals?, '(if ({and or :^} ...) ...)'
+
+        def on_if(node)
+          return unless node.unless?
+
+          add_offense(node) if multiple_conditionals?(node)
+        end
+      end
+    end
+  end
+end

data/rubocop-airbnb.gemspec

@@ -26,7 +26,7 @@ Gem::Specification.new do |spec|
     'Gemfile',
   ]
 
-  spec.add_dependency('rubocop', '0.52.1')
+  spec.add_dependency('rubocop', '0.54.0')
   spec.add_dependency('rubocop-rspec', '1.22.1')
   spec.add_development_dependency('rspec', '~> 3.5')
 end

data/spec/rubocop/cop/airbnb/simple_unless_spec.rb

@@ -0,0 +1,36 @@
+describe RuboCop::Cop::Airbnb::SimpleUnless do
+  subject(:cop) { described_class.new }
+
+  it 'rejects unless with multiple conditionals' do
+    source = [
+      'unless boolean_condition || another_method',
+      '  return true',
+      'end',
+    ].join("\n")
+
+    inspect_source(source)
+    expect(cop.offenses.size).to eq(1)
+  end
+
+  it 'allows if with multiple conditionals' do
+    source = [
+      'if boolean_condition || another_method',
+      '  return true',
+      'end',
+    ].join("\n")
+
+    inspect_source(source)
+    expect(cop.offenses).to be_empty
+  end
+
+  it 'allows with modifier if operator conditional' do
+    source = [
+      'unless boolean_condition',
+      '  return true',
+      'end',
+    ].join("\n")
+
+    inspect_source(source)
+    expect(cop.offenses).to be_empty
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-airbnb
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.3.0
 platform: ruby
 authors:
 - Airbnb Engineering
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-01 00:00:00.000000000 Z
+date: 2018-06-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.52.1
+        version: 0.54.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.52.1
+        version: 0.54.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
@@ -101,6 +101,7 @@ files:
 - lib/rubocop/cop/airbnb/rspec_describe_or_context_under_namespace.rb
 - lib/rubocop/cop/airbnb/rspec_environment_modification.rb
 - lib/rubocop/cop/airbnb/simple_modifier_conditional.rb
+- lib/rubocop/cop/airbnb/simple_unless.rb
 - lib/rubocop/cop/airbnb/spec_constant_assignment.rb
 - lib/rubocop/cop/airbnb/unsafe_yaml_marshal.rb
 - rubocop-airbnb.gemspec
@@ -120,6 +121,7 @@ files:
 - spec/rubocop/cop/airbnb/rspec_describe_or_context_under_namespace_spec.rb
 - spec/rubocop/cop/airbnb/rspec_environment_modification_spec.rb
 - spec/rubocop/cop/airbnb/simple_modifier_conditional_spec.rb
+- spec/rubocop/cop/airbnb/simple_unless_spec.rb
 - spec/rubocop/cop/airbnb/spec_constant_assignment_spec.rb
 - spec/rubocop/cop/airbnb/unsafe_yaml_marshal_spec.rb
 - spec/spec_helper.rb
@@ -143,8 +145,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.2.5
 signing_key: 
 specification_version: 4
 summary: Custom code style checking for Airbnb.
 test_files: []
+has_rdoc: