rubocop-airbnb 1.0.0 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e606bf47c06053d42acc1100abc09b8984b80ebf
-  data.tar.gz: 03d2d05b1ec2d6e656b59e697618c8f020afbc92
+  metadata.gz: 0d2dcf1334e8eeb272ff56471391e73622488e26
+  data.tar.gz: 941186c8f5c022da98449b9133d19e67a3130293
 SHA512:
-  metadata.gz: a14424158bccca0d2506cedd884b77eeeaafa72680393948455859af6ba0b577278cba32beaa185e9bf6edfb8b0286706d9325fa9a4a54d7058049266a509c7f
-  data.tar.gz: f208056c32bc043c4ba9c8f446a83ee24e4b4a0aa1c62193f56ac86df6a96d8724a124f6b359a629bf649c1cb273c2d0367f03fe26c3bb7eed2fb987aac168bb
+  metadata.gz: 99a154982784e30d893d4349a46f97b50cffc73d64f32683aa202180dbfd8614954e93aabc508df149588171bf4fe9a37195b55e8ea5941a3e9709c9a13ff51e
+  data.tar.gz: b58a02873292060626dba0a0f48961250e02ea07d2034d310e291a69857be29757f63d255629a5d27df52ebc195047613b3490a117b3f78f6bac2a6c4f57a07a

data/CHANGELOG.md

@@ -1,2 +1,6 @@
+# 1.3.0
+* Upgrade to rubocop 0.54.0
+* Add SimpleUnless cop
+
 # 1.0.0
 * First public release of rubocop-airbnb

data/README.md

@@ -1,9 +1,9 @@
 # RuboCop Airbnb
 
-Airbnb specific analysis for [RuboCop](https://github.com/bbatsov/rubocop).
+Airbnb specific analysis for [RuboCop](https://github.com/rubocop-hq/rubocop).
 
 It contains Airbnb's internally used configuration for
-[RuboCop](https://github.com/bbatsov/rubocop) and
+[RuboCop](https://github.com/rubocop-hq/rubocop) and
 [RuboCop RSpec](https://github.com/backus/rubocop-rspec). It also includes a handful custom rules
 that are not currently addressed by other projects.
 

data/config/rubocop-airbnb.yml

@@ -85,6 +85,10 @@ Airbnb/SimpleModifierConditional:
   Enabled: true
   StyleGuide: https://github.com/airbnb/ruby#only-simple-if-unless
 
+Airbnb/SimpleUnless:
+  Enabled: true
+  StyleGuide: https://github.com/airbnb/ruby#unless-with-multiple-conditions
+
 Airbnb/SpecConstantAssignment:
   Description: Constant assignment in specs polute global namespace and are a cause of spurious
     specs. They should be avoided. Also modifing existing constants is bad too, use stub_const

data/config/rubocop-layout.yml

@@ -3,7 +3,7 @@
 Layout/AccessModifierIndentation:
   Description: Check indentation of private/protected visibility modifiers.
   # Airbnb: https://github.com/airbnb/ruby#access-modifiers
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#indent-public-private-protected
+  StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#indent-public-private-protected
   Enabled: true
   EnforcedStyle: indent
   SupportedStyles:
@@ -13,7 +13,7 @@ Layout/AccessModifierIndentation:
 # Supports --auto-correct
 Layout/AlignArray:
   Description: Align the elements of an array literal if they span more than one line.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#align-multiline-arrays
+  StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#align-multiline-arrays
   Enabled: true
 
 # Supports --auto-correct
@@ -32,13 +32,18 @@ Layout/AlignHash:
 # Supports --auto-correct
 Layout/AlignParameters:
   Description: Align the parameters of a method call if they span more than one line.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-double-indent
+  StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#no-double-indent
   Enabled: true
   EnforcedStyle: with_first_parameter
   SupportedStyles:
   - with_first_parameter
   - with_fixed_indentation
 
+# Supports --auto-correct
+Layout/BlockAlignment:
+  Description: Align block ends correctly.
+  Enabled: true
+
 # Supports --auto-correct
 Layout/BlockEndNewline:
   Description: Put end statement of multiline block on its own line.
@@ -47,7 +52,7 @@ Layout/BlockEndNewline:
 # Supports --auto-correct
 Layout/CaseIndentation:
   Description: Indentation of when in a case/when/[else/]end.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#indent-when-to-case
+  StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#indent-when-to-case
   Enabled: true
   EnforcedStyle: case
   IndentOneStep: false
@@ -78,6 +83,18 @@ Layout/CommentIndentation:
   Description: Indentation of comments.
   Enabled: true
 
+Layout/ConditionPosition:
+  Description: Checks for condition placed in a confusing position relative to the keyword.
+  StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#same-line-condition
+  Enabled: true
+
+# Supports --auto-correct
+Layout/DefEndAlignment:
+  Description: Align ends corresponding to defs correctly.
+  Enabled: true
+  EnforcedStyleAlignWith: start_of_line
+  AutoCorrect: false
+
 # Use trailing commas, because there are safer in ruby.
 Layout/DotPosition:
   Enabled: true
@@ -88,13 +105,17 @@ Layout/ElseAlignment:
   Description: Align elses and elsifs correctly.
   Enabled: true
 
+Layout/EmptyComment:
+  Description: 'Checks empty comment.'
+  Enabled: true
+
 Layout/EmptyLineAfterMagicComment:
   Enabled: true
 
 # Supports --auto-correct
 Layout/EmptyLineBetweenDefs:
   Description: Use empty lines between defs.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#empty-lines-between-methods
+  StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#empty-lines-between-methods
   Enabled: true
   AllowAdjacentOneLineDefs: false
 
@@ -130,7 +151,9 @@ Layout/EmptyLinesAroundClassBody:
   Enabled: true
   EnforcedStyle: no_empty_lines
   SupportedStyles:
+  - beginning_only
   - empty_lines
+  - end_only
   - no_empty_lines
 
 Layout/EmptyLinesAroundExceptionHandlingKeywords:
@@ -150,9 +173,23 @@ Layout/EmptyLinesAroundModuleBody:
   - empty_lines
   - no_empty_lines
 
+# Supports --auto-correct
+Layout/EndAlignment:
+  Description: Align ends correctly.
+  # The value `keyword` means that `end` should be aligned with the matching
+  # keyword (if, while, etc.).
+  # The value `variable` means that in assignments, `end` should be aligned
+  # with the start of the variable on the left hand side of `=`. In all other
+  # situations, `end` should still be aligned with the keyword.
+  # The value `start_of_line` means that `end` should be aligned with the start
+  # of the line which the matching keyword appears on.
+  Enabled: true
+  EnforcedStyleAlignWith: keyword
+  AutoCorrect: false
+
 Layout/EndOfLine:
   Description: Use Unix-style line endings.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#crlf
+  StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#crlf
   Enabled: false
 
 # Supports --auto-correct
@@ -231,7 +268,7 @@ Layout/IndentationConsistency:
 # Supports --auto-correct
 Layout/IndentationWidth:
   Description: Use 2 spaces for indentation.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#spaces-indentation
+  StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#spaces-indentation
   Enabled: true
   Width: 2
 
@@ -243,7 +280,7 @@ Layout/InitialIndentation:
 # Supports --auto-correct
 Layout/LeadingCommentSpace:
   Description: Comments should start with a space.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#hash-space
+  StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#hash-space
   Enabled: true
 
 # Supports --auto-correct
@@ -255,7 +292,7 @@ Layout/MultilineArrayBraceLayout:
 # Supports --auto-correct
 Layout/MultilineAssignmentLayout:
   Description: Check for a newline after the assignment operator in multi-line assignments.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#indent-conditional-assignment
+  StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#indent-conditional-assignment
   Enabled: false
   SupportedTypes:
   - block
@@ -324,32 +361,32 @@ Layout/RescueEnsureAlignment:
 # Supports --auto-correct
 Layout/SpaceAfterColon:
   Description: Use spaces after colons.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#spaces-operators
+  StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#spaces-operators
   Enabled: true
 
 # Supports --auto-correct
 Layout/SpaceAfterComma:
   Description: Use spaces after commas.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#spaces-operators
+  StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#spaces-operators
   Enabled: true
 
 # Supports --auto-correct
 Layout/SpaceAfterMethodName:
   Description: Do not put a space between a method name and the opening parenthesis
     in a method definition.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#parens-no-spaces
+  StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#parens-no-spaces
   Enabled: true
 
 # Supports --auto-correct
 Layout/SpaceAfterNot:
   Description: Tracks redundant space after the ! operator.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-space-bang
+  StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#no-space-bang
   Enabled: true
 
 # Supports --auto-correct
 Layout/SpaceAfterSemicolon:
   Description: Use spaces after semicolons.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#spaces-operators
+  StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#spaces-operators
   Enabled: true
 
 # Supports --auto-correct
@@ -362,7 +399,7 @@ Layout/SpaceAroundBlockParameters:
 Layout/SpaceAroundEqualsInParameterDefault:
   Description: Checks that the equals signs in parameter default assignments have or
     don't have surrounding space depending on configuration.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#spaces-around-equals
+  StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#spaces-around-equals
   Enabled: true
   EnforcedStyle: space
   SupportedStyles:
@@ -376,7 +413,7 @@ Layout/SpaceAroundKeyword:
 # Supports --auto-correct
 Layout/SpaceAroundOperators:
   Description: Use a single space around operators.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#spaces-operators
+  StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#spaces-operators
   Enabled: true
   AllowForAlignment: true
 
@@ -448,7 +485,7 @@ Layout/SpaceInsideArrayLiteralBrackets:
   Enabled: true
 
 Layout/SpaceInsideReferenceBrackets:
-  EnforcedStyle: no_space
+  EnforcedStyleForEmptyBrackets: no_space
   SupportedStyles:
     - space
     - no_space
@@ -457,7 +494,7 @@ Layout/SpaceInsideReferenceBrackets:
 # Supports --auto-correct
 Layout/SpaceInsideHashLiteralBraces:
   Description: Use spaces inside hash literal braces - or don't.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#spaces-operators
+  StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#spaces-operators
   Enabled: true
   EnforcedStyle: space
   EnforcedStyleForEmptyBraces: no_space
@@ -468,7 +505,7 @@ Layout/SpaceInsideHashLiteralBraces:
 # Supports --auto-correct
 Layout/SpaceInsideParens:
   Description: No spaces after ( or before ).
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-spaces-braces
+  StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#no-spaces-braces
   Enabled: true
 
 Layout/SpaceInsidePercentLiteralDelimiters:
@@ -478,13 +515,13 @@ Layout/SpaceInsidePercentLiteralDelimiters:
 # Supports --auto-correct
 Layout/SpaceInsideRangeLiteral:
   Description: No spaces inside range literals.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-space-inside-range-literals
+  StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#no-space-inside-range-literals
   Enabled: true
 
 # Supports --auto-correct
 Layout/SpaceInsideStringInterpolation:
   Description: Checks for padding/surrounding spaces inside string interpolation.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#string-interpolation
+  StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#string-interpolation
   Enabled: true
   EnforcedStyle: no_space
   SupportedStyles:
@@ -494,13 +531,13 @@ Layout/SpaceInsideStringInterpolation:
 # Supports --auto-correct
 Layout/Tab:
   Description: No hard tabs.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#spaces-indentation
+  StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#spaces-indentation
   Enabled: true
 
 # Supports --auto-correct
 Layout/TrailingBlankLines:
   Description: Checks trailing blank lines and final newline.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#newline-eof
+  StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#newline-eof
   Enabled: true
   EnforcedStyle: final_newline
   SupportedStyles:
@@ -510,5 +547,5 @@ Layout/TrailingBlankLines:
 # Supports --auto-correct
 Layout/TrailingWhitespace:
   Description: Avoid trailing whitespace.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-trailing-whitespace
+  StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#no-trailing-whitespace
   Enabled: true

data/config/rubocop-lint.yml

@@ -4,7 +4,7 @@ Lint/AmbiguousBlockAssociation:
 Lint/AmbiguousOperator:
   Description: Checks for ambiguous operators in the first argument of a method invocation
     without parentheses.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#parens-as-args
+  StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#parens-as-args
   Enabled: true
 
 Lint/AmbiguousRegexpLiteral:
@@ -14,14 +14,13 @@ Lint/AmbiguousRegexpLiteral:
 
 Lint/AssignmentInCondition:
   Description: Don't use assignment in conditions.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#safe-assignment-in-condition
+  StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#safe-assignment-in-condition
   Enabled: true
   AllowSafeAssignment: false
 
-# Supports --auto-correct
-Lint/BlockAlignment:
-  Description: Align block ends correctly.
-  Enabled: true
+Lint/BigDecimalNew:
+  Description: '`BigDecimal.new()` is deprecated. Use `BigDecimal()` instead.'
+  Enabled: false
 
 Lint/BooleanSymbol:
   Enabled: false
@@ -30,22 +29,10 @@ Lint/CircularArgumentReference:
   Description: Don't refer to the keyword argument in the default value.
   Enabled: false
 
-Lint/ConditionPosition:
-  Description: Checks for condition placed in a confusing position relative to the keyword.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#same-line-condition
-  Enabled: true
-
 Lint/Debugger:
   Description: Check for debugger calls.
   Enabled: true
 
-# Supports --auto-correct
-Lint/DefEndAlignment:
-  Description: Align ends corresponding to defs correctly.
-  Enabled: true
-  EnforcedStyleAlignWith: start_of_line
-  AutoCorrect: false
-
 # Supports --auto-correct
 Lint/DeprecatedClassMethods:
   Description: Check for deprecated class method calls.
@@ -81,27 +68,13 @@ Lint/EmptyInterpolation:
 Lint/EmptyWhen:
   Enabled: false
 
-# Supports --auto-correct
-Lint/EndAlignment:
-  Description: Align ends correctly.
-  # The value `keyword` means that `end` should be aligned with the matching
-  # keyword (if, while, etc.).
-  # The value `variable` means that in assignments, `end` should be aligned
-  # with the start of the variable on the left hand side of `=`. In all other
-  # situations, `end` should still be aligned with the keyword.
-  # The value `start_of_line` means that `end` should be aligned with the start
-  # of the line which the matching keyword appears on.
-  Enabled: true
-  EnforcedStyleAlignWith: keyword
-  AutoCorrect: false
-
 Lint/EndInMethod:
   Description: END blocks should not be placed inside method definitions.
   Enabled: false
 
 Lint/EnsureReturn:
   Description: Do not use return in an ensure block.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-return-ensure
+  StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#no-return-ensure
   Enabled: false
 
 Lint/FloatOutOfRange:
@@ -114,7 +87,7 @@ Lint/FormatParameterMismatch:
 
 Lint/HandleExceptions:
   Description: Don't suppress exception.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#dont-hide-exceptions
+  StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#dont-hide-exceptions
   Enabled: false
 
 Lint/ImplicitStringConcatenation:
@@ -148,7 +121,7 @@ Lint/LiteralInInterpolation:
 Lint/Loop:
   Description: Use Kernel#loop with break rather than begin/end/until or begin/end/while
     for post-loop tests.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#loop-with-break
+  StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#loop-with-break
   Enabled: false
 
 Lint/MissingCopEnableDirective:
@@ -168,7 +141,7 @@ Lint/MultipleCompare:
 
 Lint/NestedMethodDefinition:
   Description: Do not use nested method definitions.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-nested-methods
+  StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#no-nested-methods
   Enabled: false
 
 Lint/NextWithoutAccumulator:
@@ -178,9 +151,13 @@ Lint/NonLocalExitFromIterator:
   Description: Do not use return in iterator to cause non-local exit.
   Enabled: false
 
+Lint/OrderedMagicComments:
+  Description: 'Checks the proper ordering of magic comments and whether a magic comment is not placed before a shebang.'
+  Enabled: true
+
 Lint/ParenthesesAsGroupedExpression:
   Description: Checks for method calls with a space before the opening parenthesis.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#parens-no-spaces
+  StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#parens-no-spaces
   Enabled: true
 
 Lint/PercentStringArray:
@@ -211,7 +188,7 @@ Lint/RequireParentheses:
 
 Lint/RescueException:
   Description: Avoid rescuing the Exception class.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-blind-rescues
+  StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#no-blind-rescues
   Enabled: true
 
 Lint/RescueType:
@@ -244,7 +221,7 @@ Lint/ShadowingOuterLocalVariable:
 # Supports --auto-correct
 Lint/StringConversionInInterpolation:
   Description: Checks for Object#to_s usage in string interpolation.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#no-to-s
+  StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#no-to-s
   Enabled: true
 
 Lint/UnderscorePrefixedVariableName:
@@ -254,12 +231,16 @@ Lint/UnderscorePrefixedVariableName:
 Lint/UnifiedInteger:
   Enabled: false
 
-Lint/UnneededDisable:
+Lint/UnneededCopDisableDirective:
   Description: >-
     Checks for rubocop:disable comments that can be removed.
     Note: this cop is not disabled when disabling all cops. It must be explicitly disabled.
   Enabled: true
 
+Lint/UnneededCopEnableDirective:
+  Description: Checks for rubocop:enable comments that can be removed.
+  Enabled: true
+
 Lint/UnneededRequireStatement:
   Enabled: false
 
@@ -273,13 +254,13 @@ Lint/UnreachableCode:
 # Supports --auto-correct
 Lint/UnusedBlockArgument:
   Description: Checks for unused block arguments.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#underscore-unused-vars
+  StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#underscore-unused-vars
   Enabled: false
 
 # Supports --auto-correct
 Lint/UnusedMethodArgument:
   Description: Checks for unused method arguments.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#underscore-unused-vars
+  StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#underscore-unused-vars
   Enabled: false
 
 Lint/UriEscapeUnescape:
@@ -294,7 +275,7 @@ Lint/UselessAccessModifier:
 
 Lint/UselessAssignment:
   Description: Checks for useless assignment to a local variable.
-  StyleGuide: https://github.com/bbatsov/ruby-style-guide#underscore-unused-vars
+  StyleGuide: https://github.com/rubocop-hq/ruby-style-guide#underscore-unused-vars
   Enabled: true
 
 Lint/UselessComparison: