ruact 0.0.11 → 0.0.13

data/spec/ruact/layout_source_spec.rb

@@ -1,108 +0,0 @@
-# frozen_string_literal: true
-
-require "spec_helper"
-require "ruact"
-
-# The single definition of "is this layout migrated?", shared by the runtime and
-# by `ruact:install`. Every example here is a shape that fooled an earlier,
-# looser check — a NAME where only a CALL counts, or a substring where only an
-# attribute counts.
-RSpec.describe Ruact::LayoutSource do
-  describe ".wired?" do
-    it "accepts a plain output tag" do
-      expect(described_class.wired?("<%= ruact_js_assets %>")).to be true
-    end
-
-    it "accepts the raw-output form and tight whitespace" do
-      expect(described_class.wired?("<%==ruact_js_assets%>")).to be true
-    end
-
-    it "accepts a call with an argument" do
-      expect(described_class.wired?("<%= ruact_js_assets(payload) %>")).to be true
-    end
-
-    # Round-1 finding: a mention in prose read as wired.
-    it "rejects a mention inside an ERB comment" do
-      expect(described_class.wired?("<%# remember to add ruact_js_assets here %>")).to be false
-    end
-
-    # Round-2 finding, and the sharper version of the same mistake: a genuinely
-    # COMMENTED-OUT call. ERB comments do not nest, so this emits nothing — but
-    # a regex looking only for `<%=` sees a call and reports the layout ready,
-    # which sends the runtime off to render an unmigrated layout.
-    it "rejects a commented-out call" do
-      expect(described_class.wired?("<%# <%= ruact_js_assets %> %>")).to be false
-    end
-
-    it "rejects a multi-line comment that wraps a call" do
-      source = <<~ERB
-        <%#
-          disabled for now:
-          <%= ruact_js_assets %>
-        %>
-      ERB
-      expect(described_class.wired?(source)).to be false
-    end
-
-    it "still sees a real call that follows a comment mentioning it" do
-      expect(described_class.wired?("<%# ruact_js_assets %>\n<%= ruact_js_assets %>")).to be true
-    end
-
-    # Round-3 finding: ERB's trim-mode comment (`<%-# ... -%>`) is a comment in
-    # Erubi too — verified by compiling it — but the stripper only knew `<%#`,
-    # so a call disabled this way read as wired.
-    it "rejects a call disabled with a trim-mode comment" do
-      expect(described_class.wired?("<%-# <%= ruact_js_assets %> -%>")).to be false
-    end
-
-    # Round-3 finding, the other direction: forbidding `%` before the name to
-    # avoid crossing tag boundaries also rejected legitimate calls. A false
-    # "unwired" is safer than a false "wired", but it is still a wrong answer —
-    # the app would silently keep ruact's CSS-less shell.
-    it "accepts a call whose expression contains a percent sign" do
-      expect(described_class.wired?(%(<%= raw("100%") + ruact_js_assets %>))).to be true
-      expect(described_class.wired?("<%= ruact_js_assets if 50 % 2 == 0 %>")).to be true
-    end
-
-    it "still refuses to match across a tag boundary" do
-      expect(described_class.wired?("<%= something %> then a bare ruact_js_assets mention")).to be false
-    end
-
-    it "rejects a layout that never names it" do
-      expect(described_class.wired?("<html><body><%= yield %></body></html>")).to be false
-    end
-  end
-
-  describe ".root?" do
-    it "accepts the emitted form" do
-      expect(described_class.root?(%(<div id="root"></div>))).to be true
-    end
-
-    it "accepts single quotes, extra attributes and unquoted values" do
-      expect(described_class.root?(%(<div id='root'></div>))).to be true
-      expect(described_class.root?(%(<div class="a" id="root" data-x="1"></div>))).to be true
-      expect(described_class.root?(%(<div id=root></div>))).to be true
-    end
-
-    # Round-2 finding: `data-id="root"` is not a mount point, and a document
-    # carrying one but no real root gives React nothing to mount into.
-    it "rejects a look-alike attribute" do
-      expect(described_class.root?(%(<body data-id="root"></body>))).to be false
-    end
-
-    it "rejects a different id that merely starts with root" do
-      expect(described_class.root?(%(<div id="rootish"></div>))).to be false
-    end
-  end
-
-  # The anchor `ruact:install` injects after.
-  describe "::ROOT_ELEMENT" do
-    it "anchors on a whole empty root div" do
-      expect(described_class::ROOT_ELEMENT).to match(%(<div id="root"></div>))
-    end
-
-    it "does not anchor on a look-alike attribute" do
-      expect(described_class::ROOT_ELEMENT).not_to match(%(<div data-id="root"></div>))
-    end
-  end
-end

data/spec/ruact/manifest_resolver_spec.rb

@@ -1,174 +0,0 @@
-# frozen_string_literal: true
-
-require "spec_helper"
-require "net/http"
-require "tmpdir"
-
-module Ruact
-  RSpec.describe ManifestResolver do
-    # spec_helper pins resolve/resolve_soft to the boot manifest suite-wide for
-    # hermeticity; this spec is the one place that exercises the REAL paths.
-    before do
-      allow(described_class).to receive(:resolve).and_call_original
-      allow(described_class).to receive(:resolve_soft).and_call_original
-    end
-
-    let(:manifest_hash) do
-      {
-        "LikeButton" => {
-          "id" => "/LikeButton.jsx",
-          "name" => "LikeButton",
-          "chunks" => ["/LikeButton.jsx"]
-        }
-      }
-    end
-    let(:manifest_json) { JSON.generate(manifest_hash) }
-
-    # A real Net::HTTPSuccess (HTTPOK < HTTPSuccess) whose body we override, so
-    # the resolver's `response.is_a?(Net::HTTPSuccess)` branch is exercised for
-    # real without touching the network.
-    def http_ok(body)
-      response = Net::HTTPOK.new("1.1", "200", "OK")
-      response.define_singleton_method(:body) { body }
-      response
-    end
-
-    def in_dev
-      allow(Rails).to receive(:env).and_return(ActiveSupport::StringInquirer.new("development"))
-    end
-
-    describe ".resolve in development (the boot-race)" do
-      before do
-        in_dev
-        # Simulate the race: boot read the missing file, so the cached manifest is nil.
-        allow(Ruact).to receive(:manifest).and_return(nil)
-      end
-
-      it "resolves from the Vite dev server over HTTP (no 500, ref resolvable)" do
-        allow(Net::HTTP).to receive(:start).and_return(http_ok(manifest_json))
-
-        manifest = described_class.resolve
-
-        expect(manifest).to be_a(ClientManifest)
-        ref = manifest.reference_for("LikeButton")
-        expect(ref.module_id).to eq("/LikeButton.jsx")
-      end
-
-      it "fetches the manifest from the configured vite_dev_server URL" do
-        allow(Net::HTTP).to receive(:start).and_return(http_ok(manifest_json))
-
-        described_class.resolve
-
-        expect(Net::HTTP).to have_received(:start).with(
-          "localhost", 5173, hash_including(:open_timeout, :read_timeout)
-        )
-      end
-
-      it "does not double-slash the path when vite_dev_server has a trailing slash" do
-        allow(described_class).to receive(:base_url).and_return("http://localhost:5173/")
-        http = instance_double(Net::HTTP)
-        allow(http).to receive(:get).and_return(http_ok(manifest_json))
-        allow(Net::HTTP).to receive(:start).and_yield(http).and_return(http_ok(manifest_json))
-
-        described_class.resolve
-
-        expect(http).to have_received(:get).with("/__ruact/manifest")
-      end
-
-      it "speaks TLS when vite_dev_server is https" do
-        allow(described_class).to receive(:base_url).and_return("https://localhost:5173")
-        allow(Net::HTTP).to receive(:start).and_return(http_ok(manifest_json))
-
-        described_class.resolve
-
-        expect(Net::HTTP).to have_received(:start).with(
-          "localhost", 5173, hash_including(use_ssl: true)
-        )
-      end
-
-      it "falls back to the on-disk file when the dev server is unreachable" do
-        allow(Net::HTTP).to receive(:start).and_raise(Errno::ECONNREFUSED)
-
-        Dir.mktmpdir do |dir|
-          path = File.join(dir, "react-client-manifest.json")
-          File.write(path, manifest_json)
-          allow(described_class).to receive(:file_path).and_return(path)
-
-          manifest = described_class.resolve
-          expect(manifest).to be_a(ClientManifest)
-          expect(manifest.reference_for("LikeButton").module_id).to eq("/LikeButton.jsx")
-        end
-      end
-
-      it "raises a clear, actionable error (not NoMethodError) when neither HTTP nor file is available" do
-        allow(Net::HTTP).to receive(:start).and_raise(Errno::ECONNREFUSED)
-        allow(described_class).to receive(:file_path).and_return("/no/such/manifest.json")
-
-        expect { described_class.resolve }.to raise_error(ManifestError, %r{Vite dev server.*bin/dev}m)
-      end
-
-      # Story 15.0 (F8) — an error message is a prompt: agents (and humans)
-      # regex-match error text, so the ENGLISH wording and its stable tokens
-      # (`Vite dev server`, `react-client-manifest.json`, `bin/dev`) are pinned.
-      it "raises the ENGLISH message naming the dev-server URL, the manifest path and the bin/dev fix " \
-         "(Story 15.0)", :story_15_0 do
-        allow(Net::HTTP).to receive(:start).and_raise(Errno::ECONNREFUSED)
-        allow(described_class).to receive(:file_path).and_return("/no/such/manifest.json")
-
-        expect { described_class.resolve }.to raise_error(ManifestError) do |error|
-          expect(error.message).to include("[ruact] Vite dev server unreachable at http://localhost:5173")
-          expect(error.message).to include("no react-client-manifest.json found at /no/such/manifest.json")
-          expect(error.message).to include("run `bin/dev`")
-        end
-      end
-
-      it "ignores a non-2xx dev-server response and falls back" do
-        allow(Net::HTTP).to receive(:start).and_return(Net::HTTPNotFound.new("1.1", "404", "Not Found"))
-        allow(described_class).to receive(:file_path).and_return("/no/such/manifest.json")
-
-        expect { described_class.resolve }.to raise_error(ManifestError)
-      end
-    end
-
-    describe ".resolve_soft in development (fail-open for FR100)" do
-      before do
-        in_dev
-        allow(Ruact).to receive(:manifest).and_return(nil)
-      end
-
-      it "returns nil (no raise) when nothing is resolvable" do
-        allow(Net::HTTP).to receive(:start).and_raise(Errno::ECONNREFUSED)
-        allow(described_class).to receive(:file_path).and_return("/no/such/manifest.json")
-
-        expect(described_class.resolve_soft).to be_nil
-      end
-
-      it "returns the dev manifest when the server is up" do
-        allow(Net::HTTP).to receive(:start).and_return(http_ok(manifest_json))
-        expect(described_class.resolve_soft).to be_a(ClientManifest)
-      end
-    end
-
-    describe "production / non-development (untouched)" do
-      it "returns Ruact.manifest verbatim without any HTTP call" do
-        allow(Rails).to receive(:env).and_return(ActiveSupport::StringInquirer.new("production"))
-        allow(Net::HTTP).to receive(:start)
-        boot_manifest = ClientManifest.from_hash(manifest_hash)
-        allow(Ruact).to receive(:manifest).and_return(boot_manifest)
-
-        expect(described_class.resolve).to be(boot_manifest)
-        expect(Net::HTTP).not_to have_received(:start)
-      end
-
-      it "returns Ruact.manifest in the test environment too (no dev fetch)" do
-        allow(Rails).to receive(:env).and_return(ActiveSupport::StringInquirer.new("test"))
-        allow(Net::HTTP).to receive(:start)
-        boot_manifest = ClientManifest.from_hash(manifest_hash)
-        allow(Ruact).to receive(:manifest).and_return(boot_manifest)
-
-        expect(described_class.resolve).to be(boot_manifest)
-        expect(Net::HTTP).not_to have_received(:start)
-      end
-    end
-  end
-end