ruact 0.0.11 → 0.0.13

data/vendor/javascript/vite-plugin-ruact/runtime/ruact-router.js

@@ -275,6 +275,101 @@ function _buildFormData(form, submitter) {
   }
 }
 
+// ---------------------------------------------------------------------------
+// Story 17.0f — the navigation boundary
+// ---------------------------------------------------------------------------
+
+function _isNativeBoundary(response) {
+  return response.headers?.get("ruact-boundary") === "native";
+}
+
+function _isFlight(response) {
+  return (response.headers?.get("content-type") || "").includes("text/x-component");
+}
+
+// A full document load of the final URL (after any redirect the fetch
+// followed). `replace` for back/forward, so no entry is pushed mid-history.
+//
+// `response.url` never carries the #fragment (Fetch strips it), so the one
+// the link asked for is put back.
+function _fullLoad(response, targetUrl, { replace = false } = {}) {
+  const requested = new URL(targetUrl, location.href);
+  const destination = new URL(response.url || requested.href);
+  if (!destination.hash && requested.hash) destination.hash = requested.hash;
+  if (replace) location.replace(destination.href);
+  else location.assign(destination.href);
+}
+
+function _escapedFormMessage(method, targetUrl, response) {
+  const path = new URL(targetUrl, location.href).pathname;
+  const type = response.headers?.get("content-type") || "no content type";
+  return `[ruact] ${method} ${path} answered ${response.status} with ${type}, not a ruact page. ` +
+    "The action already ran, so ruact will not submit the form again. " +
+    'Add data-ruact="false" to this <form> to let the browser submit it, ' +
+    "or have the action answer through ruact.";
+}
+
+// Submits the form as the browser would, WITHOUT dispatching a `submit` event —
+// so neither this router nor Turbo intercepts it again. The browser only sends
+// the clicked button's `name=value` (and honours its `formaction` / `formmethod`
+// / `formtarget`) when that button is the submitter, which `submit()` has no way
+// to express: both are carried over onto the form first.
+//
+// Everything added to the form is taken back right after: `submit()` builds its
+// entry list synchronously, and a page that survives the submit (a download, a
+// 204, a return from the back-forward cache) must not keep the last button's
+// overrides and value for the next one.
+//
+// A form rendered by a React component has no `authenticity_token` field — the
+// router's own fetch sent the token as a header. A native submit cannot, so the
+// token from `<meta name="csrf-token">` goes in as a field, the way rails-ujs
+// does it.
+const _SUBMITTER_OVERRIDES = [
+  ["formaction", "action"], ["formmethod", "method"], ["formtarget", "target"], ["formenctype", "enctype"],
+];
+
+function _nativeSubmit(form, submitter) {
+  const restore = [];
+  const added = [];
+
+  if (submitter) {
+    for (const [override, attribute] of _SUBMITTER_OVERRIDES) {
+      if (!submitter.hasAttribute(override)) continue;
+      restore.push([attribute, form.hasAttribute(attribute) ? form.getAttribute(attribute) : null]);
+      form.setAttribute(attribute, submitter.getAttribute(override));
+    }
+    if (submitter.name) added.push(_hiddenField(submitter.name, submitter.value));
+  }
+
+  const csrfParam = document.querySelector('meta[name="csrf-param"]')?.content;
+  const csrfToken = document.querySelector('meta[name="csrf-token"]')?.content;
+  if (csrfParam && csrfToken && !_hasField(form, csrfParam)) added.push(_hiddenField(csrfParam, csrfToken));
+
+  added.forEach((field) => form.appendChild(field));
+  try {
+    HTMLFormElement.prototype.submit.call(form);
+  } finally {
+    added.forEach((field) => field.remove?.());
+    restore.forEach(([attribute, value]) => {
+      if (value === null) form.removeAttribute?.(attribute);
+      else form.setAttribute(attribute, value);
+    });
+  }
+}
+
+function _hiddenField(name, value) {
+  const field = document.createElement("input");
+  field.type = "hidden";
+  field.name = name;
+  field.value = value;
+  return field;
+}
+
+function _hasField(form, name) {
+  const quoted = name.replace(/["\\]/g, "\\$&");
+  return Boolean(form.elements?.namedItem?.(name) ?? form.querySelector?.(`[name="${quoted}"]`));
+}
+
 async function _submitForm(form, submitter = null) {
   clearPendingChunks();
 
@@ -317,7 +412,18 @@ async function _submitForm(form, submitter = null) {
       headers,
       signal:  controller.signal,
     });
-    await _processFlightResponse(response, { push: true, targetUrl: action });
+    // Story 17.0f — not a ruact page, and the action did NOT run: this native
+    // submit is its one and only run, and its real response (a 422 with the
+    // validation errors included) is what the user sees.
+    if (_isNativeBoundary(response)) {
+      // The boundary answer came at the END of a redirect the fetch followed:
+      // the form's action already ran (a real 3xx, e.g. to another scheme), and
+      // resubmitting would run it twice. Load where it redirected to instead.
+      if (response.redirected) _fullLoad(response, action);
+      else _nativeSubmit(form, submitter);
+      return;
+    }
+    await _processFlightResponse(response, { push: true, targetUrl: action, method: htmlMethod });
   } catch (err) {
     if (err.name === "AbortError") return;
     console.error("[ruact-router] Form submission error:", err);
@@ -330,7 +436,9 @@ async function _submitForm(form, submitter = null) {
 // ---------------------------------------------------------------------------
 
 function handlePopstate() {
-  navigate(location.pathname + location.search + location.hash, { push: false, scroll: false });
+  // Story 17.0f — `replace`: if this entry turns out not to be a ruact page, the
+  // full load must not push a NEW entry into the history being walked.
+  navigate(location.pathname + location.search + location.hash, { push: false, scroll: false, replace: true });
 }
 
 // ---------------------------------------------------------------------------
@@ -346,7 +454,7 @@ function handlePopstate() {
  * REJECTS on a failed Flight fetch — without this, callers cannot
  * branch on success vs. failure of a programmatic refetch.
  */
-async function navigate(url, { push = true, scroll = true, throwOnError = false } = {}) {
+async function navigate(url, { push = true, scroll = true, throwOnError = false, replace = false } = {}) {
   // Clear stale lazy refs from any previous streaming navigation
   clearPendingChunks();
 
@@ -359,11 +467,21 @@ async function navigate(url, { push = true, scroll = true, throwOnError = false
       headers: { Accept: "text/x-component", "Ruact-Request": "1" },
       signal:  controller.signal,
     });
+    // Story 17.0f — the server said the destination is not a ruact page, and
+    // ran nothing to say so. The browser takes it from here.
+    if (_isNativeBoundary(response)) {
+      // A caller that asked to be told (revalidate) refetches the page it is
+      // ON; "not a ruact page" there is a failure to report, not a reload.
+      if (throwOnError) throw new Error(`[ruact] ${url} is not a ruact page`);
+      _fullLoad(response, url, { replace });
+      return;
+    }
     await _processFlightResponse(response, {
       push,
       targetUrl: url,
       scroll,
       throwOnError,
+      replace,
     });
   } catch (err) {
     if (err.name === "AbortError") {
@@ -380,8 +498,47 @@ async function navigate(url, { push = true, scroll = true, throwOnError = false
 // Shared Flight response processor (used by navigate + _submitForm)
 // ---------------------------------------------------------------------------
 
-async function _processFlightResponse(response, { push, targetUrl, scroll = true, throwOnError = false }) {
-  if (!response.ok) {
+async function _processFlightResponse(response, {
+  push, targetUrl, scroll = true, throwOnError = false, replace = false, method = "GET",
+}) {
+  // Story 17.0f — a response that is not Flight escaped the server's boundary
+  // classifier. Feeding it to the line parser was the old dead click: every HTML
+  // line parses to null, nothing renders, nothing reports.
+  //
+  // A non-Flight GET — a page, or an error page (404, 500, a 401 from auth) —
+  // is loaded in full so the user SEES it: the default app passes no onError,
+  // and a console line is a dead click by another name. Repeating a GET is
+  // harmless. A caller that asked to be told (`throwOnError`: revalidate)
+  // gets the error instead of a reload.
+  if (!_isFlight(response)) {
+    if (method === "GET" && !throwOnError) {
+      _fullLoad(response, targetUrl, { replace });
+      return;
+    }
+    // A form whose action answered HTML — it ran, so it will not be resubmitted.
+    // Only a 2xx or a 422 is that; a 403 (CSRF) or a 500 is a failure, below.
+    if (method !== "GET" && (response.ok || response.status === 422)) {
+      const err = new Error(_escapedFormMessage(method, targetUrl, response));
+      console.error(err.message);
+      _onError?.(err);
+      if (throwOnError) throw err;
+      return;
+    }
+    if (response.ok) {
+      const err = new Error(`[ruact] ${targetUrl} did not answer with a ruact response`);
+      console.error(err.message);
+      _onError?.(err);
+      if (throwOnError) throw err;
+      return;
+    }
+  }
+
+  // Story 17.0i — a Flight 422 is a page: `render :new, status:
+  // :unprocessable_entity` re-rendering a form with its validation errors. The
+  // errors are the content, not a transport failure. Every other non-2xx stays
+  // a failure — an HTML 422 (Rails' own error page) included.
+  const unprocessable = response.status === 422 && _isFlight(response);
+  if (!response.ok && !unprocessable) {
     const msg = `[ruact] Request failed: ${response.status} ${response.statusText}`;
     console.error(msg);
     const err = new Error(msg);
@@ -392,6 +549,12 @@ async function _processFlightResponse(response, { push, targetUrl, scroll = true
     return;
   }
 
+  // Story 17.0i — a form's 422 re-render keeps the form's URL: the POST URL is
+  // not one a reload or Back can ask for again (a reload of `/posts` would be
+  // the index). Unless the fetch followed a redirect: it then ended on a GET,
+  // and that URL is the page being shown.
+  const pushEntry = push && !(unprocessable && method !== "GET" && !response.redirected);
+
   // Use final URL after any redirects (response.url is the resolved URL).
   const finalPath = response.url
     ? (() => { const u = new URL(response.url); return u.pathname + u.search + u.hash; })()
@@ -422,7 +585,7 @@ async function _processFlightResponse(response, { push, targetUrl, scroll = true
       }
       // Normal case: build tree and render immediately.
       const tree = buildTreeFromRows(rows, _moduleRegistry);
-      if (push) history.pushState(null, "", finalPath);
+      if (pushEntry) history.pushState(null, "", finalPath);
       _onNavigate(tree);
       if (scroll) window.scrollTo(0, 0);
       initialTreeSet = true;
@@ -466,7 +629,7 @@ async function _processFlightResponse(response, { push, targetUrl, scroll = true
   // Fallback: if row 0 never triggered (shouldn't happen with valid server)
   if (!initialTreeSet && !redirected && rows.has(0)) {
     const tree = buildTreeFromRows(rows, _moduleRegistry);
-    if (push) history.pushState(null, "", finalPath);
+    if (pushEntry) history.pushState(null, "", finalPath);
     _onNavigate(tree);
     if (scroll) window.scrollTo(0, 0);
   }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ruact
 version: !ruby/object:Gem::Version
-  version: 0.0.11
+  version: 0.0.13
 platform: ruby
 authors:
 - Luiz Garcia
 autorequire:
-bindir: exe
+bindir: bin
 cert_chain: []
-date: 2026-08-25 00:00:00.000000000 Z
+date: 2026-09-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -36,21 +36,12 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".codecov.yml"
-- ".github/workflows/ci.yml"
-- ".github/workflows/server-functions-bench.yml"
-- ".rubocop.yml"
-- ".rubocop_todo.yml"
 - CHANGELOG.md
+- CONTRIBUTING.md
 - LICENSE.txt
 - README.md
 - RELEASING.md
-- Rakefile
 - SECURITY.md
-- bench/server_functions_dispatch_bench.rb
-- bench/server_functions_dispatch_bench.results.md
-- docs/internal/README.md
-- docs/internal/decisions/server-functions-api.md
 - lib/generators/ruact/install/install_generator.rb
 - lib/generators/ruact/install/templates/AGENTS.md.tt
 - lib/generators/ruact/install/templates/Procfile.dev.tt
@@ -60,6 +51,7 @@ files:
 - lib/generators/ruact/install/templates/package.json.tt
 - lib/generators/ruact/install/templates/tsconfig.json.tt
 - lib/generators/ruact/install/templates/vite.config.js.tt
+- lib/generators/ruact/layout/layout_generator.rb
 - lib/generators/ruact/scaffold/scaffold_attribute.rb
 - lib/generators/ruact/scaffold/scaffold_form_helpers.rb
 - lib/generators/ruact/scaffold/scaffold_generator.rb
@@ -84,6 +76,8 @@ files:
 - lib/ruact/configuration.rb
 - lib/ruact/controller.rb
 - lib/ruact/controller/document_rendering.rb
+- lib/ruact/controller/page_rendering.rb
+- lib/ruact/controller/pages.rb
 - lib/ruact/doctor.rb
 - lib/ruact/erb_preprocessor.rb
 - lib/ruact/erb_preprocessor_hook.rb
@@ -97,6 +91,8 @@ files:
 - lib/ruact/html_converter.rb
 - lib/ruact/layout_source.rb
 - lib/ruact/manifest_resolver.rb
+- lib/ruact/navigation_boundary.rb
+- lib/ruact/packaging.rb
 - lib/ruact/query.rb
 - lib/ruact/railtie.rb
 - lib/ruact/render_context.rb
@@ -132,6 +128,7 @@ files:
 - lib/ruact/validation_errors_collector.rb
 - lib/ruact/version.rb
 - lib/ruact/view_helper.rb
+- lib/ruact/views/layouts/ruact.html.erb
 - lib/rubocop/cop/ruact.rb
 - lib/rubocop/cop/ruact/no_extend_self.rb
 - lib/rubocop/cop/ruact/no_io_in_flight.rb
@@ -139,112 +136,20 @@ files:
 - lib/tasks/benchmark.rake
 - lib/tasks/ruact.rake
 - sig/ruact.rbs
-- spec/benchmarks/baseline.json
-- spec/benchmarks/render_pipeline_benchmark_spec.rb
-- spec/fixtures/flight/README.md
-- spec/fixtures/flight/array.txt
-- spec/fixtures/flight/as_json_object.txt
-- spec/fixtures/flight/bigint.txt
-- spec/fixtures/flight/boolean_false.txt
-- spec/fixtures/flight/boolean_true.txt
-- spec/fixtures/flight/client_component_with_props.txt
-- spec/fixtures/flight/client_reference.txt
-- spec/fixtures/flight/hash.txt
-- spec/fixtures/flight/infinity.txt
-- spec/fixtures/flight/nan.txt
-- spec/fixtures/flight/negative_infinity.txt
-- spec/fixtures/flight/nil.txt
-- spec/fixtures/flight/number_float.txt
-- spec/fixtures/flight/number_integer.txt
-- spec/fixtures/flight/react_element_no_props.txt
-- spec/fixtures/flight/redirect_row.txt
-- spec/fixtures/flight/serializable_object.txt
-- spec/fixtures/flight/string_basic.txt
-- spec/fixtures/flight/string_dollar_escape.txt
-- spec/fixtures/flight/undefined.txt
-- spec/fixtures/readme/children-error.html.erb
-- spec/fixtures/readme/children-error.txt
-- spec/fixtures/story_7_9_views/controller_request_spec_support/demo/show.html.erb
-- spec/fixtures/story_7_9_views/controller_request_spec_support/errors_demo/new.html.erb
-- spec/fixtures/story_7_9_views/controller_request_spec_support/exploding_layout_demo/show.html.erb
-- spec/fixtures/story_7_9_views/controller_request_spec_support/ghost_layout_demo/show.html.erb
-- spec/fixtures/story_7_9_views/controller_request_spec_support/layout_demo/show.html.erb
-- spec/fixtures/story_7_9_views/controller_request_spec_support/rootless_layout_demo/show.html.erb
-- spec/fixtures/story_7_9_views/controller_request_spec_support/unwired_layout_demo/show.html.erb
-- spec/fixtures/story_7_9_views/layouts/bare_host.html.erb
-- spec/fixtures/story_7_9_views/layouts/exploding_host.html.erb
-- spec/fixtures/story_7_9_views/layouts/rootless_host.html.erb
-- spec/fixtures/story_7_9_views/layouts/ruact_host.html.erb
-- spec/readme_demo_message_spec.rb
-- spec/readme_spec.rb
-- spec/ruact/client_manifest_spec.rb
-- spec/ruact/component_contract_spec.rb
-- spec/ruact/configuration_spec.rb
-- spec/ruact/controller_request_spec.rb
-- spec/ruact/controller_spec.rb
-- spec/ruact/doctor_spec.rb
-- spec/ruact/erb_preprocessor_hook_spec.rb
-- spec/ruact/erb_preprocessor_spec.rb
-- spec/ruact/errors_spec.rb
-- spec/ruact/flight/renderer_spec.rb
-- spec/ruact/flight/serializer_spec.rb
-- spec/ruact/html_converter_spec.rb
-- spec/ruact/install_generator_spec.rb
-- spec/ruact/layout_source_spec.rb
-- spec/ruact/manifest_resolver_spec.rb
-- spec/ruact/query_request_spec.rb
-- spec/ruact/query_spec.rb
-- spec/ruact/railtie_spec.rb
-- spec/ruact/render_context_spec.rb
-- spec/ruact/render_pipeline_concurrency_spec.rb
-- spec/ruact/render_pipeline_spec.rb
-- spec/ruact/scaffold_generator_spec.rb
-- spec/ruact/serializable_spec.rb
-- spec/ruact/server_bucket_request_spec.rb
-- spec/ruact/server_function_name_spec.rb
-- spec/ruact/server_functions/backtrace_cleaner_spec.rb
-- spec/ruact/server_functions/bucket_two_payload_spec.rb
-- spec/ruact/server_functions/codegen_spec.rb
-- spec/ruact/server_functions/error_payload_spec.rb
-- spec/ruact/server_functions/error_suggestion_spec.rb
-- spec/ruact/server_functions/introspection_spec.rb
-- spec/ruact/server_functions/name_bridge_spec.rb
-- spec/ruact/server_functions/query_context_spec.rb
-- spec/ruact/server_functions/query_source_spec.rb
-- spec/ruact/server_functions/railtie_integration_spec.rb
-- spec/ruact/server_functions/rake_spec.rb
-- spec/ruact/server_functions/route_source_spec.rb
-- spec/ruact/server_functions/snapshot_spec.rb
-- spec/ruact/server_functions/snapshot_writer_spec.rb
-- spec/ruact/server_rescue_request_spec.rb
-- spec/ruact/server_spec.rb
-- spec/ruact/server_upload_request_spec.rb
-- spec/ruact/signed_references_spec.rb
-- spec/ruact/string_distance_spec.rb
-- spec/ruact/tasks_json_introspection_spec.rb
-- spec/ruact/testing/have_ruact_component_spec.rb
-- spec/ruact/testing/no_production_load_spec.rb
-- spec/ruact/validation_errors_spec.rb
-- spec/ruact/view_helper_spec.rb
-- spec/spec_helper.rb
-- spec/support/fixtures/pixel.png
-- spec/support/flight_wire_parser.rb
-- spec/support/flight_wire_parser_spec.rb
-- spec/support/matchers/flight_fixture_matcher.rb
-- spec/support/matchers/flight_fixture_matcher_spec.rb
-- spec/support/rails_stub.rb
 - vendor/javascript/ruact-server-functions-runtime/index.d.ts
 - vendor/javascript/ruact-server-functions-runtime/index.js
 - vendor/javascript/ruact-server-functions-runtime/index.test.mjs
 - vendor/javascript/ruact-server-functions-runtime/package.json
 - vendor/javascript/ruact-server-functions-runtime/usequery.test.mjs
 - vendor/javascript/vite-plugin-ruact/bootstrap.test.mjs
+- vendor/javascript/vite-plugin-ruact/flight-client.test.mjs
 - vendor/javascript/vite-plugin-ruact/index.js
 - vendor/javascript/vite-plugin-ruact/manifest-contract.test.mjs
 - vendor/javascript/vite-plugin-ruact/manifest-http.test.mjs
 - vendor/javascript/vite-plugin-ruact/package-lock.json
 - vendor/javascript/vite-plugin-ruact/package.json
 - vendor/javascript/vite-plugin-ruact/registry.test.mjs
+- vendor/javascript/vite-plugin-ruact/ruact-router.test.mjs
 - vendor/javascript/vite-plugin-ruact/runtime/bootstrap.jsx
 - vendor/javascript/vite-plugin-ruact/runtime/flight-client.js
 - vendor/javascript/vite-plugin-ruact/runtime/ruact-router.js

data/.codecov.yml

@@ -1,31 +0,0 @@
-# Codecov configuration for the ruact gem.
-# Story 6.7 — coverage is informativo (not a CI gate); Codecov reports status
-# but never fails a PR. Diff coverage targets (90% line / 80% branch) are
-# project DoD, surfaced via the per-PR comment for visibility.
-
-coverage:
-  status:
-    project:
-      default:
-        informational: true
-        target: auto
-        threshold: 1%
-    patch:
-      default:
-        informational: true
-        target: 90%
-        threshold: 0%
-
-comment:
-  layout: "diff, files"
-  behavior: default
-  require_changes: false
-
-flags:
-  gem:
-    # Paths are relative to the gem repo root (where this CI runs and uploads
-    # from). lcov.info emits source paths like `./lib/ruact.rb`; Codecov
-    # normalizes the leading `./` so a `lib/` prefix matches.
-    paths:
-      - lib/
-    carryforward: false