rspec-core 3.0.0.beta1 → 3.0.0.beta2

data/features/expectation_framework_integration/configure_expectation_framework.feature

@@ -23,7 +23,7 @@ Feature: configure expectation framework
       end
 
       describe 6 do
-        it { should be_a_multiple_of(3) }
+        it { is_expected.to be_a_multiple_of 3 }
       end
       """
     When I run `rspec example_spec.rb`

data/features/filtering/if_and_unless.feature

@@ -136,33 +136,3 @@ Feature: :if and :unless
       | included :if => false example     |
       | included :unless => true example  |
       | excluded                          |
-
-  Scenario: override implicit :if and :unless exclusion filters
-    Given a file named "override_implicit_filters_spec.rb" with:
-      """ruby
-      RSpec.configure do |c|
-        c.filter_run_excluding :if => :exclude_me, :unless => :exclude_me_for_unless
-      end
-
-      describe ":if filtering" do
-        it(":if => true example", :if => true) { }
-        it(":if => false example", :if => false) { }
-        it(":if => :exclude_me example", :if => :exclude_me) { }
-      end
-
-      describe ":unless filtering" do
-        it(":unless => true example", :unless => true) { }
-        it(":unless => false example", :unless => false) { }
-        it(":unless => :exclude_me_for_unless example", :unless => :exclude_me_for_unless) { }
-      end
-      """
-    When I run `rspec override_implicit_filters_spec.rb --format doc`
-    Then the output should contain all of these:
-      | :if => true example      |
-      | :if => false example     |
-      | :unless => true example  |
-      | :unless => false example |
-    And the output should not contain any of these:
-      | :if => :exclude_me example                |
-      | :unless => :exclude_me_for_unless example |
-

data/features/formatters/custom_formatter.feature

@@ -10,6 +10,37 @@ Feature: custom formatters
   and then override just the methods that you want to modify.
 
   Scenario: custom formatter
+    Given a file named "custom_formatter.rb" with:
+      """ruby
+      require "rspec/core/formatters/base_text_formatter"
+
+      class CustomFormatter < RSpec::Core::Formatters::BaseTextFormatter
+
+        # This registers the notifications this formatter supports, and tells
+        # us that this was written against the RSpec 3.x formatter API.
+        RSpec::Core::Formatters.register self, :example_started
+
+        def initialize(output)
+          super(output)
+        end
+
+        def example_started(notification)
+          output << "example: " << notification.example.description
+        end
+      end
+      """
+    And a file named "example_spec.rb" with:
+      """ruby
+      describe "my group" do
+        specify "my example" do
+        end
+      end
+      """
+    When I run `rspec example_spec.rb --require ./custom_formatter.rb --format CustomFormatter`
+    Then the output should contain "example: my example"
+    And  the exit status should be 0
+
+  Scenario: a legacy custom formatter
     Given a file named "custom_formatter.rb" with:
       """ruby
       require "rspec/core/formatters/base_text_formatter"
@@ -33,4 +64,5 @@ Feature: custom formatters
       """
     When I run `rspec example_spec.rb --require ./custom_formatter.rb --format CustomFormatter`
     Then the output should contain "example: my example"
+    And the output should contain "The CustomFormatter formatter uses the deprecated formatter interface."
     And  the exit status should be 0

data/features/formatters/regression_tests.feature

@@ -0,0 +1,95 @@
+Feature: Regression tests for legacy custom formatters
+
+  Background:
+    Given a file named ".rspec" with:
+      """
+      --require spec_helper
+      """
+      And a file named "spec/spec_helper.rb" with:
+      """
+      RSpec.configure do |rspec|
+        rspec.after(:suite) do
+          puts rspec.formatters.map(&:class).inspect
+        end
+      end
+      """
+      And a file named "spec/passing_and_failing_spec.rb" with:
+      """ruby
+      RSpec.describe "Some examples" do
+        it "passes" do
+          expect(1).to eq(1)
+        end
+
+        it "fails" do
+          expect(1).to eq(2)
+        end
+
+        context "nested" do
+          it "passes" do
+            expect(1).to eq(1)
+          end
+
+          it "fails" do
+            expect(1).to eq(2)
+          end
+        end
+      end
+      """
+      And a file named "spec/pending_spec.rb" with:
+      """ruby
+      RSpec.describe "Some pending examples" do
+        context "pending" do
+          it "is reported as pending" do
+            pending; expect(1).to eq(2)
+          end
+
+          it "is reported as failing" do
+            pending; expect(1).to eq(1)
+          end
+        end
+      end
+      """
+
+  Scenario: Use fuubar formatter
+    When I run `rspec --format Fuubar`
+    Then the output should contain "Progress: |============"
+     And the output should contain "6 examples, 3 failures, 1 pending"
+     And the output should contain "The Fuubar formatter uses the deprecated formatter interface"
+     But the output should not contain any error backtraces
+     And the output should not contain "ProgressFormatter"
+
+  Scenario: Use rspec-instafail formatter
+    When I run `rspec --format RSpec::Instafail`
+    Then the output should contain "6 examples, 3 failures, 1 pending"
+     And the output should contain "The RSpec::Instafail formatter uses the deprecated formatter interface"
+     But the output should not contain any error backtraces
+     And the output should not contain "ProgressFormatter"
+
+  Scenario: Use rspec-extra-formatters JUnit formatter
+    When I run `rspec --require rspec-extra-formatters --format JUnitFormatter`
+    Then the output should contain:
+      """
+      <testsuite errors="0" failures="3" skipped="1" tests="6"
+      """
+     And the output should contain "The JUnitFormatter formatter uses the deprecated formatter interface"
+     But the output should not contain any error backtraces
+     And the output should not contain "ProgressFormatter"
+
+  @wip @announce
+  Scenario: Use rspec-extra-formatters Tap formatter
+    When I run `rspec --require rspec-extra-formatters --format TapFormatter`
+    Then the output should contain "TAP version 13"
+     And the output should contain "The TapFormatter formatter uses the deprecated formatter interface"
+     But the output should not contain any error backtraces
+     And the output should not contain "ProgressFormatter"
+
+  @wip @announce
+  Scenario: Use rspec-spinner formatter
+    When I run `rspec --require rspec_spinner --format RspecSpinner::Spinner`
+    Then the output should contain "TBD"
+
+  @wip @announce
+  Scenario: Use nyancat formatter
+    When I run `rspec --format NyanCatFormatter`
+    Then the output should contain "TBD"
+

data/features/hooks/around_hooks.feature

@@ -230,6 +230,7 @@ Feature: around hooks
 
         it "should be detected as pending" do
           pending
+          fail
         end
       end
       """

data/features/hooks/before_and_after_hooks.feature

@@ -46,7 +46,7 @@ Feature: before and after hooks
             expect(@thing.widgets.count).to eq(0)
           end
 
-          it "can get accept new widgets" do
+          it "can accept new widgets" do
             @thing.widgets << Object.new
           end
 
@@ -80,7 +80,7 @@ Feature: before and after hooks
             expect(@thing.widgets.count).to eq(0)
           end
 
-          it "can get accept new widgets" do
+          it "can accept new widgets" do
             @thing.widgets << Object.new
           end
 

data/features/mock_framework_integration/use_flexmock.feature

@@ -37,19 +37,18 @@ Feature: mock with flexmock
     When I run `rspec example_spec.rb`
     Then the output should contain "1 example, 1 failure"
 
-  Scenario: failing message expectation in pending block (remains pending)
+  Scenario: failing message expectation in pending example (remains pending)
     Given a file named "example_spec.rb" with:
       """ruby
       RSpec.configure do |config|
         config.mock_framework = :flexmock
       end
 
-      describe "failed message expectation in a pending block" do
+      describe "failed message expectation in a pending example" do
         it "is listed as pending" do
-          pending do
-            receiver = flexmock('receiver')
-            receiver.should_receive(:message).once
-          end
+          pending
+          receiver = flexmock('receiver')
+          receiver.should_receive(:message).once
         end
       end
       """
@@ -57,20 +56,19 @@ Feature: mock with flexmock
     Then the output should contain "1 example, 0 failures, 1 pending"
     And the exit status should be 0
 
-  Scenario: passing message expectation in pending block (fails)
+  Scenario: passing message expectation in pending example (fails)
     Given a file named "example_spec.rb" with:
       """ruby
       RSpec.configure do |config|
         config.mock_framework = :flexmock
       end
 
-      describe "passing message expectation in a pending block" do
+      describe "passing message expectation in a pending example" do
         it "fails with FIXED" do
-          pending do
-            receiver = flexmock('receiver')
-            receiver.should_receive(:message).once
-            receiver.message
-          end
+          pending
+          receiver = flexmock('receiver')
+          receiver.should_receive(:message).once
+          receiver.message
         end
       end
       """

data/features/mock_framework_integration/use_mocha.feature

@@ -37,19 +37,18 @@ Feature: mock with mocha
     When I run `rspec example_spec.rb`
     Then the output should contain "1 example, 1 failure"
 
-  Scenario: failing message expectation in pending block (remains pending)
+  Scenario: failing message expectation in pending example (remains pending)
     Given a file named "example_spec.rb" with:
       """ruby
       RSpec.configure do |config|
         config.mock_framework = :mocha
       end
 
-      describe "failed message expectation in a pending block" do
+      describe "failed message expectation in a pending example" do
         it "is listed as pending" do
-          pending do
-            receiver = mock('receiver')
-            receiver.expects(:message).once
-          end
+          pending
+          receiver = mock('receiver')
+          receiver.expects(:message).once
         end
       end
       """
@@ -57,20 +56,19 @@ Feature: mock with mocha
     Then the output should contain "1 example, 0 failures, 1 pending"
     And the exit status should be 0
 
-  Scenario: passing message expectation in pending block (fails)
+  Scenario: passing message expectation in pending example (fails)
     Given a file named "example_spec.rb" with:
       """ruby
       RSpec.configure do |config|
         config.mock_framework = :mocha
       end
 
-      describe "passing message expectation in a pending block" do
+      describe "passing message expectation in a pending example" do
         it "fails with FIXED" do
-          pending do
-            receiver = mock('receiver')
-            receiver.expects(:message).once
-            receiver.message
-          end
+          pending
+          receiver = mock('receiver')
+          receiver.expects(:message).once
+          receiver.message
         end
       end
       """

data/features/mock_framework_integration/use_rr.feature

@@ -37,19 +37,18 @@ Feature: mock with rr
     When I run `rspec example_spec.rb`
     Then the output should contain "1 example, 1 failure"
 
-  Scenario: failing message expectation in pending block (remains pending)
+  Scenario: failing message expectation in pending example (remains pending)
     Given a file named "example_spec.rb" with:
       """ruby
       RSpec.configure do |config|
         config.mock_framework = :rr
       end
 
-      describe "failed message expectation in a pending block" do
+      describe "failed message expectation in a pending example" do
         it "is listed as pending" do
-          pending do
-            receiver = Object.new
-            mock(receiver).message
-          end
+          pending
+          receiver = Object.new
+          mock(receiver).message
         end
       end
       """
@@ -57,20 +56,19 @@ Feature: mock with rr
     Then the output should contain "1 example, 0 failures, 1 pending"
     And the exit status should be 0
 
-  Scenario: passing message expectation in pending block (fails)
+  Scenario: passing message expectation in pending example (fails)
     Given a file named "example_spec.rb" with:
       """ruby
       RSpec.configure do |config|
         config.mock_framework = :rr
       end
 
-      describe "passing message expectation in a pending block" do
+      describe "passing message expectation in a pending example" do
         it "fails with FIXED" do
-          pending do
-            receiver = Object.new
-            mock(receiver).message
-            receiver.message
-          end
+          pending
+          receiver = Object.new
+          mock(receiver).message
+          receiver.message
         end
       end
       """

data/features/mock_framework_integration/use_rspec.feature

@@ -38,19 +38,18 @@ Feature: mock with rspec
     When I run `rspec example_spec.rb`
     Then the output should contain "1 example, 1 failure"
 
-  Scenario: failing message expectation in pending block (remains pending)
+  Scenario: failing message expectation in pending example (remains pending)
     Given a file named "example_spec.rb" with:
       """ruby
       RSpec.configure do |config|
         config.mock_framework = :rspec
       end
 
-      describe "failed message expectation in a pending block" do
+      describe "failed message expectation in a pending example" do
         it "is listed as pending" do
-          pending do
-            receiver = double('receiver')
-            expect(receiver).to receive(:message)
-          end
+          pending
+          receiver = double('receiver')
+          expect(receiver).to receive(:message)
         end
       end
       """
@@ -58,20 +57,19 @@ Feature: mock with rspec
     Then the output should contain "1 example, 0 failures, 1 pending"
     And the exit status should be 0
 
-  Scenario: passing message expectation in pending block (fails)
+  Scenario: passing message expectation in pending example (fails)
     Given a file named "example_spec.rb" with:
       """ruby
       RSpec.configure do |config|
         config.mock_framework = :rspec
       end
 
-      describe "passing message expectation in a pending block" do
+      describe "passing message expectation in a pending example" do
         it "fails with FIXED" do
-          pending do
-            receiver = double('receiver')
-            expect(receiver).to receive(:message)
-            receiver.message
-          end
+          pending
+          receiver = double('receiver')
+          expect(receiver).to receive(:message)
+          receiver.message
         end
       end
       """

data/features/pending_and_skipped_examples/README.md

@@ -0,0 +1,3 @@
+Sometimes you will have a failing example that can not be fixed, but is useful to keep around. For instance, the fix could depend on an upstream patch being merged, or the example is not supported on JRuby. RSpec provides two features for dealing with this scenario.
+
+An example can either be marked as _skipped_, in which is it not executed, or _pending_ in which it is executed but failure will not cause a failure of the entire suite. When a pending example passes (i.e. the underlying reasons for it being marked pending is no longer present) it will fail to communicate to you that it should no longer be marked as pending.

data/features/pending_and_skipped_examples/pending_examples.feature

@@ -0,0 +1,118 @@
+Feature: pending examples
+
+  RSpec offers a number of different ways to indicate that an example is
+  disabled pending some action.
+
+  Scenario: pending any arbitrary reason with a failing example
+    Given a file named "pending_without_block_spec.rb" with:
+      """ruby
+      describe "an example" do
+        it "is implemented but waiting" do
+          pending("something else getting finished")
+          fail
+        end
+      end
+      """
+    When I run `rspec pending_without_block_spec.rb`
+    Then the exit status should be 0
+    And the output should contain "1 example, 0 failures, 1 pending"
+    And the output should contain:
+      """
+      Pending:
+        an example is implemented but waiting
+          # something else getting finished
+          # ./pending_without_block_spec.rb:2
+      """
+  Scenario: pending any arbitrary reason with a passing example
+    Given a file named "pending_with_passing_example_spec.rb" with:
+      """ruby
+      describe "an example" do
+        it "is implemented but waiting" do
+          pending("something else getting finished")
+          expect(1).to be(1)
+        end
+      end
+      """
+    When I run `rspec pending_with_passing_example_spec.rb`
+    Then the exit status should not be 0
+    And the output should contain "1 example, 1 failure"
+    And the output should contain "FIXED"
+    And the output should contain "Expected pending 'something else getting finished' to fail. No Error was raised."
+    And the output should contain "pending_with_passing_example_spec.rb:2"
+
+  Scenario: pending for an example that is currently passing
+    Given a file named "pending_with_passing_block_spec.rb" with:
+      """ruby
+      describe "an example" do
+        pending("something else getting finished") do
+          expect(1).to eq(1)
+        end
+      end
+      """
+    When I run `rspec pending_with_passing_block_spec.rb`
+    Then the exit status should not be 0
+    And the output should contain "1 example, 1 failure"
+    And the output should contain "FIXED"
+    And the output should contain "Expected pending 'No reason given' to fail. No Error was raised."
+    And the output should contain "pending_with_passing_block_spec.rb:2"
+
+  Scenario: pending for an example that is currently passing with a reason
+    Given a file named "pending_with_passing_block_spec.rb" with:
+      """ruby
+      describe "an example" do
+        example("something else getting finished", :pending => 'unimplemented') do
+          expect(1).to eq(1)
+        end
+      end
+      """
+    When I run `rspec pending_with_passing_block_spec.rb`
+    Then the exit status should not be 0
+    And the output should contain "1 example, 1 failure"
+    And the output should contain "FIXED"
+    And the output should contain "Expected pending 'unimplemented' to fail. No Error was raised."
+    And the output should contain "pending_with_passing_block_spec.rb:2"
+
+  Scenario: example with no docstring and pending method using documentation formatter
+    Given a file named "pending_with_no_docstring_spec.rb" with:
+      """ruby
+      describe "an example" do
+        it "checks something" do
+          expect(1).to eq(1)
+        end
+        specify do
+          pending
+          fail
+        end
+      end
+      """
+    When I run `rspec pending_with_no_docstring_spec.rb --format documentation`
+    Then the exit status should be 0
+    And the output should contain "2 examples, 0 failures, 1 pending"
+    And the output should contain:
+      """
+      an example
+        checks something
+        example at ./pending_with_no_docstring_spec.rb:5 (PENDING: No reason given)
+      """
+
+  Scenario: pending with no docstring using documentation formatter
+    Given a file named "pending_with_no_docstring_spec.rb" with:
+      """ruby
+      describe "an example" do
+        it "checks something" do
+          expect(1).to eq(1)
+        end
+        pending do
+          fail
+        end
+      end
+      """
+    When I run `rspec pending_with_no_docstring_spec.rb --format documentation`
+    Then the exit status should be 0
+    And the output should contain "2 examples, 0 failures, 1 pending"
+    And the output should contain:
+      """
+      an example
+        checks something
+        example at ./pending_with_no_docstring_spec.rb:5 (PENDING: No reason given)
+      """