rspec-core 3.0.0.beta1 → 3.0.0.beta2

data/spec/rspec/core/example_spec.rb

@@ -2,7 +2,7 @@ require 'spec_helper'
 require 'pp'
 require 'stringio'
 
-describe RSpec::Core::Example, :parent_metadata => 'sample' do
+RSpec.describe RSpec::Core::Example, :parent_metadata => 'sample' do
   let(:example_group) do
     RSpec::Core::ExampleGroup.describe('group description')
   end
@@ -62,7 +62,7 @@ describe RSpec::Core::Example, :parent_metadata => 'sample' do
 
   describe "when there is no explicit description" do
     def expect_with(*frameworks)
-      RSpec.configuration.stub(:expecting_with_rspec?).and_return(frameworks.include?(:rspec))
+      allow(RSpec.configuration).to receive(:expecting_with_rspec?).and_return(frameworks.include?(:rspec))
 
       if frameworks.include?(:stdlib)
         example_group.class_eval do
@@ -110,6 +110,20 @@ describe RSpec::Core::Example, :parent_metadata => 'sample' do
         example_group.run
         expect(example.description).to match(/example at #{relative_path(__FILE__)}:#{__LINE__ - 3}/)
       end
+
+      context "if the example is pending" do
+        it "still uses the matcher-generated description if a matcher ran" do
+          example = example_group.example { pending; expect(4).to eq(5) }
+          example_group.run
+          expect(example.description).to eq("should eq 5")
+        end
+
+        it "uses the file and line number of the example if no matcher ran" do
+          example = example_group.example { pending; fail }
+          example_group.run
+          expect(example.description).to match(/example at #{relative_path(__FILE__)}:#{__LINE__ - 2}/)
+        end
+      end
     end
 
     context "when `expect_with :rspec, :stdlib` is configured" do
@@ -139,7 +153,7 @@ describe RSpec::Core::Example, :parent_metadata => 'sample' do
       before(:each) { expect_with :stdlib }
 
       it "does not attempt to get the generated description from RSpec::Matchers" do
-        RSpec::Matchers.should_not_receive(:generated_description)
+        expect(RSpec::Matchers).not_to receive(:generated_description)
         example_group.example { assert 5 == 5 }
         example_group.run
       end
@@ -296,7 +310,7 @@ describe RSpec::Core::Example, :parent_metadata => 'sample' do
         # We can't use should_receive(:message).with(/.../) here,
         # because if that fails, it would fail within our example-under-test,
         # and since there's already two errors, it would just be reported again.
-        RSpec.configuration.reporter.stub(:message) { |msg| reported_msg = msg }
+        allow(RSpec.configuration.reporter).to receive(:message) { |msg| reported_msg = msg }
         group.run
         reported_msg
       end
@@ -325,7 +339,7 @@ describe RSpec::Core::Example, :parent_metadata => 'sample' do
         group = RSpec::Core::ExampleGroup.describe do
           example do
             foo = double
-            foo.should_receive(:bar)
+            expect(foo).to receive(:bar)
             raise "boom"
           end
         end
@@ -392,13 +406,19 @@ describe RSpec::Core::Example, :parent_metadata => 'sample' do
   end
 
   describe "#pending" do
+    def expect_pending_result(example)
+      expect(example).to be_pending
+      expect(example.metadata[:execution_result][:status]).to eq("pending")
+      expect(example.metadata[:execution_result][:pending_message]).to be
+    end
+
     context "in the example" do
       it "sets the example to pending" do
         group = RSpec::Core::ExampleGroup.describe do
-          example { pending }
+          example { pending; fail }
         end
         group.run
-        expect(group.examples.first).to be_pending
+        expect_pending_result(group.examples.first)
       end
 
       it "allows post-example processing in around hooks (see https://github.com/rspec/rspec-core/issues/322)" do
@@ -414,65 +434,161 @@ describe RSpec::Core::Example, :parent_metadata => 'sample' do
         expect(blah).to be(:success)
       end
 
-      context "with a block" do
-        it "sets the example to pending if block fails" do
-          group = RSpec::Core::ExampleGroup.describe do
-            example do
-              pending { expect(1).to eq(2) }
-            end
+      it 'sets the backtrace to the example definition so it can be located by the user' do
+        expected = [__FILE__, __LINE__ + 2].map(&:to_s)
+        group = RSpec::Core::ExampleGroup.describe do
+          example {
+            pending
+          }
+        end
+        group.run
+        # TODO: De-dup this logic in rspec-support
+        actual = group.examples.first.exception.backtrace.
+          find { |line| line !~ RSpec::CallerFilter::LIB_REGEX }.
+          split(':')[0..1]
+        expect(actual).to eq(expected)
+      end
+    end
+
+    context "in before(:each)" do
+      it "sets each example to pending" do
+        group = RSpec::Core::ExampleGroup.describe do
+          before(:each) { pending }
+          example { fail }
+          example { fail }
+        end
+        group.run
+        expect_pending_result(group.examples.first)
+        expect_pending_result(group.examples.last)
+      end
+
+      it 'sets example to pending when failure occurs in before(:each)' do
+        group = RSpec::Core::ExampleGroup.describe do
+          before(:each) { pending; fail }
+          example {}
+        end
+        group.run
+        expect_pending_result(group.examples.first)
+      end
+    end
+
+    context "in before(:all)" do
+      it "is forbidden" do
+        group = RSpec::Core::ExampleGroup.describe do
+          before(:all) { pending }
+          example { fail }
+          example { fail }
+        end
+        group.run
+        expect(group.examples.first.exception).to be
+        expect(group.examples.first.exception.message).to \
+          match(/may not be used outside of examples/)
+      end
+    end
+
+    context "in around(:each)" do
+      it "sets the example to pending" do
+        group = RSpec::Core::ExampleGroup.describe do
+          around(:each) { pending }
+          example { fail }
+        end
+        group.run
+        expect_pending_result(group.examples.first)
+      end
+
+      it 'sets example to pending when failure occurs in around(:each)' do
+        group = RSpec::Core::ExampleGroup.describe do
+          around(:each) { pending; fail }
+          example {}
+        end
+        group.run
+        expect_pending_result(group.examples.first)
+      end
+    end
+
+    context "in after(:each)" do
+      it "sets each example to pending" do
+        group = RSpec::Core::ExampleGroup.describe do
+          after(:each) { pending; fail }
+          example { }
+          example { }
+        end
+        group.run
+        expect_pending_result(group.examples.first)
+        expect_pending_result(group.examples.last)
+      end
+    end
+
+  end
+
+  describe "#skip" do
+    context "in the example" do
+      it "sets the example to skipped" do
+        group = RSpec::Core::ExampleGroup.describe do
+          example { skip }
+        end
+        group.run
+        expect(group.examples.first).to be_skipped
+      end
+
+      it "allows post-example processing in around hooks (see https://github.com/rspec/rspec-core/issues/322)" do
+        blah = nil
+        group = RSpec::Core::ExampleGroup.describe do
+          around do |example|
+            example.run
+            blah = :success
           end
-          group.run
-          expect(group.examples.first.metadata[:execution_result][:status]).to eq('pending')
-          expect(group.examples.first.metadata[:execution_result][:pending_fixed]).to eq(false)
+          example { skip }
         end
+        group.run
+        expect(blah).to be(:success)
+      end
 
-        it "fails if block is fixed, i.e. does not raise" do
+      context "with a message" do
+        it "sets the example to skipped with the provided message" do
           group = RSpec::Core::ExampleGroup.describe do
-            example do
-              pending {}
-            end
+            example { skip "lorem ipsum" }
           end
           group.run
-          expect(group.examples.first.metadata[:execution_result][:status]).to eq('failed')
-          expect(group.examples.first.metadata[:execution_result][:pending_fixed]).to eq(true)
+          expect(group.examples.first).to be_skipped_with("lorem ipsum")
         end
       end
     end
 
     context "in before(:each)" do
-      it "sets each example to pending" do
+      it "sets each example to skipped" do
         group = RSpec::Core::ExampleGroup.describe do
-          before(:each) { pending }
+          before(:each) { skip }
           example {}
           example {}
         end
         group.run
-        expect(group.examples.first).to be_pending
-        expect(group.examples.last).to be_pending
+        expect(group.examples.first).to be_skipped
+        expect(group.examples.last).to be_skipped
       end
     end
 
     context "in before(:all)" do
       it "sets each example to pending" do
         group = RSpec::Core::ExampleGroup.describe do
-          before(:all) { pending }
+          before(:all) { skip("not done"); fail }
           example {}
           example {}
         end
         group.run
-        expect(group.examples.first).to be_pending
-        expect(group.examples.last).to be_pending
+        expect(group.examples.first).to be_skipped_with("not done")
+        expect(group.examples.last).to be_skipped_with("not done")
       end
     end
 
     context "in around(:each)" do
-      it "sets the example to pending" do
+      it "sets the example to skipped" do
         group = RSpec::Core::ExampleGroup.describe do
-          around(:each) { pending }
+          around(:each) { skip }
           example {}
         end
         group.run
-        expect(group.examples.first).to be_pending
+        expect(group.examples.first).to be_skipped
       end
     end
   end
@@ -483,7 +599,7 @@ describe RSpec::Core::Example, :parent_metadata => 'sample' do
       group = RSpec::Core::ExampleGroup.describe
       example = group.example
       example.__send__ :start, reporter
-      Time.stub(:now => Time.utc(2012, 10, 1))
+      allow(Time).to receive_messages(:now => Time.utc(2012, 10, 1))
       example.__send__ :finish, reporter
       expect(example.metadata[:execution_result][:run_time]).to be < 0.2
     end

data/spec/rspec/core/filter_manager_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 module RSpec::Core
-  describe FilterManager do
+  RSpec.describe FilterManager do
     def opposite(name)
       name =~ /^in/ ? name.sub(/^(in)/,'ex') : name.sub(/^(ex)/,'in')
     end
@@ -43,6 +43,13 @@ module RSpec::Core
                 expect(filter_manager.inclusions).to eq({filter => "value"})
               end
 
+              it "clears previous exclusion" do
+                filter_manager = FilterManager.new
+                filter_manager.include :foo => :bar
+                filter_manager.include filter => "value"
+                expect(filter_manager.exclusions).to be_empty
+              end
+
               it "does nothing when :#{filter} previously set" do
                 filter_manager = FilterManager.new
                 filter_manager.include filter => "a_value"
@@ -105,7 +112,7 @@ module RSpec::Core
     describe "#prune" do
       def filterable_object_with(args = {})
         object = double('a filterable object')
-        object.stub(:any_apply?) { |f| Metadata.new(args).any_apply?(f) }
+        allow(object).to receive(:any_apply?) { |f| Metadata.new(args).any_apply?(f) }
         object
       end
 
@@ -204,30 +211,6 @@ module RSpec::Core
         expect(filter_manager.exclusions.description).to eq({ :foo => :bar }.inspect)
       end
 
-      it 'deprecates an overridden :if filter' do
-        expect(RSpec).to receive(:deprecate).with(/exclude\(:if/)
-        filter_manager = FilterManager.new
-        filter_manager.exclude :if => :custom_filter
-      end
-
-      it 'deprecates an :if filter overridden with low priority' do
-        expect(RSpec).to receive(:deprecate).with(/exclude\(:if/)
-        filter_manager = FilterManager.new
-        filter_manager.exclude_with_low_priority :if => :custom_filter
-      end
-
-      it 'deprecates an overridden :unless filter' do
-        expect(RSpec).to receive(:deprecate).with(/exclude\(:unless/)
-        filter_manager = FilterManager.new
-        filter_manager.exclude :unless => :custom_filter
-      end
-
-      it 'deprecates an :unless filter overridden with low priority' do
-        expect(RSpec).to receive(:deprecate).with(/exclude\(:unless/)
-        filter_manager = FilterManager.new
-        filter_manager.exclude_with_low_priority :unless => :custom_filter
-      end
-
       it 'includes an overriden :if filter' do
         allow(RSpec).to receive(:deprecate)
         filter_manager = FilterManager.new

data/spec/rspec/core/formatters/base_formatter_spec.rb

@@ -1,10 +1,8 @@
 require 'spec_helper'
 require 'rspec/core/formatters/base_formatter'
 
-describe RSpec::Core::Formatters::BaseFormatter do
-
-  let(:output)    { StringIO.new }
-  let(:formatter) { RSpec::Core::Formatters::BaseFormatter.new(output) }
+RSpec.describe RSpec::Core::Formatters::BaseFormatter do
+  include FormatterSupport
 
   describe "read_failed_line" do
     it "deals gracefully with a heterogeneous language stack trace" do
@@ -54,7 +52,6 @@ describe RSpec::Core::Formatters::BaseFormatter do
       end
 
       it "doesn't hang when file exists" do
-        pending("This issue still exists on JRuby, but should be resolved shortly: https://github.com/rspec/rspec-core/issues/295", :if => RUBY_PLATFORM == 'java')
         exception = double(:Exception, :backtrace => [ "#{__FILE__}:#{__LINE__}"])
 
         example = double(:Example, :file_path => __FILE__)

data/spec/rspec/core/formatters/base_text_formatter_spec.rb

@@ -1,21 +1,23 @@
 require 'spec_helper'
 require 'rspec/core/formatters/base_text_formatter'
 
-describe RSpec::Core::Formatters::BaseTextFormatter do
-  let(:output) { StringIO.new }
-  let(:formatter) { RSpec::Core::Formatters::BaseTextFormatter.new(output) }
+RSpec.describe RSpec::Core::Formatters::BaseTextFormatter do
+  include FormatterSupport
 
-  describe "#summary_line" do
+  describe "#dump_summary" do
     it "with 0s outputs pluralized (excluding pending)" do
-      expect(formatter.summary_line(0,0,0)).to eq("0 examples, 0 failures")
+      send_notification :dump_summary, summary_notification(0, 0, 0, 0)
+      expect(output.string).to match("0 examples, 0 failures")
     end
 
     it "with 1s outputs singular (including pending)" do
-      expect(formatter.summary_line(1,1,1)).to eq("1 example, 1 failure, 1 pending")
+      send_notification :dump_summary, summary_notification(1, 1, 1, 1)
+      expect(output.string).to match("1 example, 1 failure, 1 pending")
     end
 
     it "with 2s outputs pluralized (including pending)" do
-      expect(formatter.summary_line(2,2,2)).to eq("2 examples, 2 failures, 2 pending")
+      send_notification :dump_summary, summary_notification(2, 2, 2, 2)
+      expect(output.string).to match("2 examples, 2 failures, 2 pending")
     end
   end
 
@@ -25,7 +27,7 @@ describe RSpec::Core::Formatters::BaseTextFormatter do
         it("fails") { fail }
       end
       line = __LINE__ - 2
-      group.run(formatter)
+      group.run(reporter)
       formatter.dump_commands_to_rerun_failed_examples
       expect(output.string).to include("rspec #{RSpec::Core::Metadata::relative_path("#{__FILE__}:#{line}")} # example group fails")
     end
@@ -34,11 +36,11 @@ describe RSpec::Core::Formatters::BaseTextFormatter do
   describe "#dump_failures" do
     let(:group) { RSpec::Core::ExampleGroup.describe("group name") }
 
-    before { RSpec.configuration.stub(:color_enabled?) { false } }
+    before { allow(RSpec.configuration).to receive(:color_enabled?) { false } }
 
     def run_all_and_dump_failures
-      group.run(formatter)
-      formatter.dump_failures
+      group.run(reporter)
+      send_notification :dump_failures, null_notification
     end
 
     it "preserves formatting" do
@@ -53,7 +55,7 @@ describe RSpec::Core::Formatters::BaseTextFormatter do
     context "with an exception without a message" do
       it "does not throw NoMethodError" do
         exception_without_message = Exception.new()
-        exception_without_message.stub(:message) { nil }
+        allow(exception_without_message).to receive(:message) { nil }
         group.example("example name") { raise exception_without_message }
         expect { run_all_and_dump_failures }.not_to raise_error
       end
@@ -68,7 +70,7 @@ describe RSpec::Core::Formatters::BaseTextFormatter do
     context "with an exception that has an exception instance as its message" do
       it "does not raise NoMethodError" do
         gonzo_exception = RuntimeError.new
-        gonzo_exception.stub(:message) { gonzo_exception }
+        allow(gonzo_exception).to receive(:message) { gonzo_exception }
         group.example("example name") { raise gonzo_exception }
         expect { run_all_and_dump_failures }.not_to raise_error
       end
@@ -101,7 +103,7 @@ describe RSpec::Core::Formatters::BaseTextFormatter do
 
     context "with a failed message expectation (rspec-mocks)" do
       it "does not show the error class" do
-        group.example("example name") { "this".should_receive("that") }
+        group.example("example name") { expect("this").to receive("that") }
         run_all_and_dump_failures
         expect(output.string).not_to match(/RSpec/m)
       end
@@ -147,126 +149,21 @@ describe RSpec::Core::Formatters::BaseTextFormatter do
     end
   end
 
-  describe "#dump_pending" do
-    let(:group) { RSpec::Core::ExampleGroup.describe("group name") }
-
-    before { RSpec.configuration.stub(:color_enabled?) { false } }
-
-    def run_all_and_dump_pending
-      group.run(formatter)
-      formatter.dump_pending
-    end
-
-    context "with show_failures_in_pending_blocks setting enabled" do
-      before { RSpec.configuration.stub(:show_failures_in_pending_blocks?) { true } }
-
-      it "preserves formatting" do
-        group.example("example name") { pending { expect("this").to eq("that") } }
-
-        run_all_and_dump_pending
-
-        expect(output.string).to match(/group name example name/m)
-        expect(output.string).to match(/(\s+)expected: \"that\"\n\1     got: \"this\"/m)
-      end
-
-      context "with an exception without a message" do
-        it "does not throw NoMethodError" do
-          exception_without_message = Exception.new()
-          exception_without_message.stub(:message) { nil }
-          group.example("example name") { pending { raise exception_without_message } }
-          expect { run_all_and_dump_pending }.not_to raise_error
-        end
-      end
-
-      context "with an exception class other than RSpec" do
-        it "does not show the error class" do
-          group.example("example name") { pending { raise NameError.new('foo') } }
-          run_all_and_dump_pending
-          expect(output.string).to match(/NameError/m)
-        end
-      end
-
-      context "with a failed expectation (rspec-expectations)" do
-        it "does not show the error class" do
-          group.example("example name") { pending { expect("this").to eq("that") } }
-          run_all_and_dump_pending
-          expect(output.string).not_to match(/RSpec/m)
-        end
-      end
-
-      context "with a failed message expectation (rspec-mocks)" do
-        it "does not show the error class" do
-          group.example("example name") { pending { "this".should_receive("that") } }
-          run_all_and_dump_pending
-          expect(output.string).not_to match(/RSpec/m)
-        end
-      end
-
-      context 'for #share_examples_for' do
-        it 'outputs the name and location' do
-
-          group.share_examples_for 'foo bar' do
-            it("example name") { pending { expect("this").to eq("that") } }
-          end
-
-          line = __LINE__.next
-          group.it_should_behave_like('foo bar')
-
-          run_all_and_dump_pending
-
-          expect(output.string).to include(
-            'Shared Example Group: "foo bar" called from ' +
-            "./spec/rspec/core/formatters/base_text_formatter_spec.rb:#{line}"
-          )
-        end
-
-        context 'that contains nested example groups' do
-          it 'outputs the name and location' do
-            group.share_examples_for 'foo bar' do
-              describe 'nested group' do
-                it("example name") { pending { expect("this").to eq("that") } }
-              end
-            end
-
-            line = __LINE__.next
-            group.it_should_behave_like('foo bar')
-
-            run_all_and_dump_pending
-
-            expect(output.string).to include(
-              'Shared Example Group: "foo bar" called from ' +
-              "./spec/rspec/core/formatters/base_text_formatter_spec.rb:#{line}"
-            )
-          end
-        end
-      end
-    end
-
-    context "with show_failures_in_pending_blocks setting disabled" do
-      before { RSpec.configuration.stub(:show_failures_in_pending_blocks?) { false } }
-
-      it "does not output the failure information" do
-        group.example("example name") { pending { expect("this").to eq("that") } }
-        run_all_and_dump_pending
-        expect(output.string).not_to match(/(\s+)expected: \"that\"\n\1     got: \"this\"/m)
-      end
-    end
-  end
-
-  describe "#dump_profile_slowest_examples" do
+  describe "#dump_profile_slowest_examples", :slow do
     example_line_number = nil
 
     before do
       group = RSpec::Core::ExampleGroup.describe("group") do
-        # Use a sleep so there is some measurable time, to ensure
-        # the reported percent is 100%, not 0%.
-        example("example") { sleep 0.001 }
-        example_line_number = __LINE__ - 1
+        example("example") do |example|
+          # make it look slow without actually taking up precious time
+          example.clock = class_double(RSpec::Core::Time, :now => RSpec::Core::Time.now + 0.5)
+        end
+        example_line_number = __LINE__ - 4
       end
-      group.run(double('reporter').as_null_object)
+      group.run(reporter)
 
-      formatter.stub(:examples) { group.examples }
-      RSpec.configuration.stub(:profile_examples) { 10 }
+      allow(formatter).to receive(:examples) { group.examples }
+      allow(RSpec.configuration).to receive(:profile_examples) { 10 }
     end
 
     it "names the example" do
@@ -292,23 +189,23 @@ describe RSpec::Core::Formatters::BaseTextFormatter do
     end
   end
 
-  describe "#dump_profile_slowest_example_groups" do
-    let(:group) do 
+  describe "#dump_profile_slowest_example_groups", :slow do
+    let(:group) do
       RSpec::Core::ExampleGroup.describe("slow group") do
-        # Use a sleep so there is some measurable time, to ensure
-        # the reported percent is 100%, not 0%.
-        example("example") { sleep 0.01 }
-      end 
+        example("example") do |example|
+          # make it look slow without actually taking up precious time
+          example.clock = class_double(RSpec::Core::Time, :now => RSpec::Core::Time.now + 0.5)
+        end
+      end
     end
-    let(:rpt) { double('reporter').as_null_object }
 
     before do
-      group.run(rpt)
-      RSpec.configuration.stub(:profile_examples) { 10 }
+      group.run(reporter)
+      allow(RSpec.configuration).to receive(:profile_examples) { 10 }
     end
 
     context "with one example group" do
-      before { formatter.stub(:examples) { group.examples } }
+      before { allow(formatter).to receive(:examples) { group.examples } }
 
       it "doesn't profile a single example group" do
         formatter.dump_profile_slowest_example_groups
@@ -319,12 +216,12 @@ describe RSpec::Core::Formatters::BaseTextFormatter do
     context "with multiple example groups" do
       before do
         group2 = RSpec::Core::ExampleGroup.describe("fast group") do
-          example("example 1") { sleep 0.004 }
-          example("example 2") { sleep 0.007 }
+          example("example 1") { }
+          example("example 2") { }
         end
-        group2.run(rpt)
+        group2.run(reporter)
 
-        formatter.stub(:examples) { group.examples + group2.examples }
+        allow(formatter).to receive(:examples) { group.examples + group2.examples }
       end
 
       it "prints the slowest example groups" do
@@ -345,9 +242,9 @@ describe RSpec::Core::Formatters::BaseTextFormatter do
 
     it "depends on parent_groups to get the top level example group" do
       ex = ""
-      group.describe("group 2") do 
+      group.describe("group 2") do
         describe "group 3" do
-          ex = example("nested example 1") 
+          ex = example("nested example 1")
         end
       end
 
@@ -362,7 +259,7 @@ describe RSpec::Core::Formatters::BaseTextFormatter do
         config.tty = true
         config.success_color = :cyan
       end
-      formatter.dump_summary(0,1,0,0)
+      send_notification :dump_summary, summary_notification(0, 1, 0, 0)
       expect(output.string).to include("\e[36m")
     end
   end