rspec-core 2.13.1 → 2.14.0.rc1

data/spec/rspec/core/deprecation_spec.rb

@@ -0,0 +1,41 @@
+require "spec_helper"
+
+describe RSpec::Core::Deprecation do
+  describe "#deprecate" do
+    context "old API with individual args" do
+      it "includes the method to deprecate" do
+        expect(RSpec.configuration.reporter).to receive(:deprecation).with(hash_including :deprecated => "deprecated_method")
+        RSpec.deprecate("deprecated_method")
+      end
+
+      it "includes the replacement when provided" do
+        expect(RSpec.configuration.reporter).to receive(:deprecation).with(hash_including :deprecated => "deprecated_method", :replacement => "replacement")
+        RSpec.deprecate("deprecated_method", "replacement")
+      end
+
+      it "adds the call site" do
+        expect(RSpec.configuration.reporter).to receive(:deprecation).with(hash_including :call_site => caller(0)[1])
+        RSpec.deprecate("deprecated_method")
+      end
+    end
+
+    context "new API with a hash after the first arg" do
+      it "passes the hash to the reporter" do
+        expect(RSpec.configuration.reporter).to receive(:deprecation).with(hash_including :deprecated => "deprecated_method", :replacement => "replacement")
+        RSpec.deprecate("deprecated_method", :replacement => "replacement")
+      end
+
+      it "adds the call site" do
+        expect(RSpec.configuration.reporter).to receive(:deprecation).with(hash_including :call_site => caller(0)[1])
+        RSpec.deprecate("deprecated_method")
+      end
+    end
+  end
+
+  describe "#warn_deprecation" do
+    it "puts message in a hash" do
+      expect(RSpec.configuration.reporter).to receive(:deprecation).with(hash_including :message => "this is the message")
+      RSpec.warn_deprecation("this is the message")
+    end
+  end
+end

data/spec/rspec/core/deprecations_spec.rb

@@ -1,19 +1,19 @@
 require "spec_helper"
 
-describe "deprecations" do
+describe "deprecated methods" do
   describe "Spec" do
     it "is deprecated" do
-      RSpec.should_receive(:warn_deprecation).with(/Spec .* RSpec/i)
+      RSpec.should_receive(:deprecate)
       Spec
     end
 
     it "returns RSpec" do
-      RSpec.stub(:warn_deprecation)
+      RSpec.stub(:deprecate)
       expect(Spec).to eq(RSpec)
     end
 
     it "doesn't include backward compatibility in const_missing backtrace" do
-      RSpec.stub(:warn_deprecation)
+      RSpec.stub(:deprecate)
       exception = nil
       begin
         ConstantThatDoesNotExist
@@ -26,12 +26,12 @@ describe "deprecations" do
   describe RSpec::Core::ExampleGroup do
     describe 'running_example' do
       it 'is deprecated' do
-        RSpec.should_receive(:warn_deprecation)
+        RSpec.should_receive(:deprecate).at_least(:once)
         self.running_example
       end
 
       it "delegates to example" do
-        RSpec.stub(:warn_deprecation)
+        RSpec.stub(:deprecate)
         expect(running_example).to eq(example)
       end
     end
@@ -40,7 +40,7 @@ describe "deprecations" do
   describe RSpec::Core::SharedExampleGroup do
     describe 'share_as' do
       it 'is deprecated' do
-        RSpec.should_receive(:warn_deprecation)
+        RSpec.should_receive(:deprecate).at_least(:once)
         RSpec::Core::SharedExampleGroup.share_as(:DeprecatedSharedConst) {}
       end
     end
@@ -48,21 +48,19 @@ describe "deprecations" do
 
   describe "Spec::Runner.configure" do
     it "is deprecated" do
-      RSpec.stub(:warn_deprecation)
-      RSpec.should_receive(:deprecate)
+      RSpec.should_receive(:deprecate).at_least(:once)
       Spec::Runner.configure
     end
   end
 
   describe "Spec::Rake::SpecTask" do
     it "is deprecated" do
-      RSpec.stub(:warn_deprecation)
-      RSpec.should_receive(:deprecate)
+      RSpec.should_receive(:deprecate).at_least(:once)
       Spec::Rake::SpecTask
     end
 
     it "doesn't include backward compatibility in const_missing backtrace" do
-      RSpec.stub(:warn_deprecation)
+      RSpec.stub(:deprecate)
       exception = nil
       begin
         Spec::Rake::ConstantThatDoesNotExist

data/spec/rspec/core/drb_command_line_spec.rb

@@ -96,7 +96,7 @@ describe "::DRbCommandLine", :type => :drb, :unless => RUBY_PLATFORM == 'java' d
       pending "figure out a way to tell the output to say it's tty"
       command_line(failing_spec_filename, "--color", "--drb-port", @drb_port).run(err, out)
       out.rewind
-      expect(out.read).to match /\e\[31m/m
+      expect(out.read).to match(/\e\[31m/m)
     end
   end
 end

data/spec/rspec/core/example_group_spec.rb

@@ -906,7 +906,7 @@ module RSpec::Core
 
         it "sets RSpec.wants_to_quit flag if encountering an exception in before(:all)" do
           group.before(:all) { raise "error in before all" }
-          example = group.example("equality") { expect(1).to eq(2) }
+          group.example("equality") { expect(1).to eq(2) }
           expect(group.run).to be_false
           expect(RSpec.wants_to_quit).to be_true
         end
@@ -995,20 +995,19 @@ module RSpec::Core
 
     %w[include_examples include_context].each do |name|
       describe "##{name}" do
+        let(:group) { ExampleGroup.describe }
         before do
-          shared_examples "named this" do
+          group.shared_examples "named this" do
             example("does something") {}
           end
         end
 
         it "includes the named examples" do
-          group = ExampleGroup.describe
           group.send(name, "named this")
           expect(group.examples.first.description).to eq("does something")
         end
 
         it "raises a helpful error message when shared content is not found" do
-          group = ExampleGroup.describe
           expect do
             group.send(name, "shared stuff")
           end.to raise_error(ArgumentError, /Could not find .* "shared stuff"/)
@@ -1016,15 +1015,15 @@ module RSpec::Core
 
         it "passes parameters to the shared content" do
           passed_params = {}
+          group = ExampleGroup.describe
 
-          shared_examples "named this with params" do |param1, param2|
+          group.shared_examples "named this with params" do |param1, param2|
             it("has access to the given parameters") do
               passed_params[:param1] = param1
               passed_params[:param2] = param2
             end
           end
 
-          group = ExampleGroup.describe
           group.send(name, "named this with params", :value1, :value2)
           group.run
 
@@ -1032,30 +1031,31 @@ module RSpec::Core
         end
 
         it "adds shared instance methods to the group" do
-          shared_examples "named this with params" do |param1|
+          group = ExampleGroup.describe('fake group')
+          group.shared_examples "named this with params" do |param1|
             def foo; end
           end
-          group = ExampleGroup.describe('fake group')
           group.send(name, "named this with params", :a)
           expect(group.public_instance_methods.map{|m| m.to_s}).to include("foo")
         end
 
         it "evals the shared example group only once" do
           eval_count = 0
-          shared_examples("named this with params") { |p| eval_count += 1 }
           group = ExampleGroup.describe('fake group')
+          group.shared_examples("named this with params") { |p| eval_count += 1 }
           group.send(name, "named this with params", :a)
           expect(eval_count).to eq(1)
         end
 
         it "evals the block when given" do
           key = "#{__FILE__}:#{__LINE__}"
-          shared_examples(key) do
-            it("does something") do
-              expect(foo).to eq("bar")
-            end
-          end
           group = ExampleGroup.describe do
+            shared_examples(key) do
+              it("does something") do
+                expect(foo).to eq("bar")
+              end
+            end
+
             send name, key do
               def foo; "bar"; end
             end
@@ -1067,43 +1067,43 @@ module RSpec::Core
 
     describe "#it_should_behave_like" do
       it "creates a nested group" do
-        shared_examples_for("thing") {}
         group = ExampleGroup.describe('fake group')
+        group.shared_examples_for("thing") {}
         group.it_should_behave_like("thing")
         expect(group).to have(1).children
       end
 
       it "creates a nested group for a class" do
         klass = Class.new
-        shared_examples_for(klass) {}
         group = ExampleGroup.describe('fake group')
+        group.shared_examples_for(klass) {}
         group.it_should_behave_like(klass)
         expect(group).to have(1).children
       end
 
       it "adds shared examples to nested group" do
-        shared_examples_for("thing") do
+        group = ExampleGroup.describe('fake group')
+        group.shared_examples_for("thing") do
           it("does something")
         end
-        group = ExampleGroup.describe('fake group')
         shared_group = group.it_should_behave_like("thing")
         expect(shared_group).to have(1).examples
       end
 
       it "adds shared instance methods to nested group" do
-        shared_examples_for("thing") do
+        group = ExampleGroup.describe('fake group')
+        group.shared_examples_for("thing") do
           def foo; end
         end
-        group = ExampleGroup.describe('fake group')
         shared_group = group.it_should_behave_like("thing")
         expect(shared_group.public_instance_methods.map{|m| m.to_s}).to include("foo")
       end
 
       it "adds shared class methods to nested group" do
-        shared_examples_for("thing") do
+        group = ExampleGroup.describe('fake group')
+        group.shared_examples_for("thing") do
           def self.foo; end
         end
-        group = ExampleGroup.describe('fake group')
         shared_group = group.it_should_behave_like("thing")
         expect(shared_group.methods.map{|m| m.to_s}).to include("foo")
       end
@@ -1111,34 +1111,35 @@ module RSpec::Core
       it "passes parameters to the shared example group" do
         passed_params = {}
 
-        shared_examples_for("thing") do |param1, param2|
-          it("has access to the given parameters") do
-            passed_params[:param1] = param1
-            passed_params[:param2] = param2
+        group = ExampleGroup.describe("group") do
+          shared_examples_for("thing") do |param1, param2|
+            it("has access to the given parameters") do
+              passed_params[:param1] = param1
+              passed_params[:param2] = param2
+            end
           end
-        end
 
-        group = ExampleGroup.describe("group") do
           it_should_behave_like "thing", :value1, :value2
         end
+
         group.run
 
         expect(passed_params).to eq({ :param1 => :value1, :param2 => :value2 })
       end
 
       it "adds shared instance methods to nested group" do
-        shared_examples_for("thing") do |param1|
+        group = ExampleGroup.describe('fake group')
+        group.shared_examples_for("thing") do |param1|
           def foo; end
         end
-        group = ExampleGroup.describe('fake group')
         shared_group = group.it_should_behave_like("thing", :a)
         expect(shared_group.public_instance_methods.map{|m| m.to_s}).to include("foo")
       end
 
       it "evals the shared example group only once" do
         eval_count = 0
-        shared_examples_for("thing") { |p| eval_count += 1 }
         group = ExampleGroup.describe('fake group')
+        group.shared_examples_for("thing") { |p| eval_count += 1 }
         group.it_should_behave_like("thing", :a)
         expect(eval_count).to eq(1)
       end
@@ -1146,12 +1147,12 @@ module RSpec::Core
       context "given a block" do
         it "evaluates the block in nested group" do
           scopes = []
-          shared_examples_for("thing") do
-            it("gets run in the nested group") do
-              scopes << self.class
-            end
-          end
           group = ExampleGroup.describe("group") do
+            shared_examples_for("thing") do
+              it("gets run in the nested group") do
+                scopes << self.class
+              end
+            end
             it_should_behave_like "thing" do
               it("gets run in the same nested group") do
                 scopes << self.class

data/spec/rspec/core/example_spec.rb

@@ -8,7 +8,7 @@ describe RSpec::Core::Example, :parent_metadata => 'sample' do
   end
 
   let(:example_instance) do
-    example_group.example('example description')
+    example_group.example('example description') { }
   end
 
   it_behaves_like "metadata hash builder" do
@@ -28,7 +28,7 @@ describe RSpec::Core::Example, :parent_metadata => 'sample' do
   end
 
   it 'can be pretty printed' do
-    output = capture_stdout { pp example_instance }
+    output = ignoring_warnings { capture_stdout { pp example_instance } }
     expect(output).to include("RSpec::Core::Example")
   end
 
@@ -104,6 +104,12 @@ describe RSpec::Core::Example, :parent_metadata => 'sample' do
         expect(example_group.examples.first.description).to eq("should eq 5")
       end
 
+      it "uses the matcher-generated description in the full description" do
+        example_group.example { expect(5).to eq(5) }
+        example_group.run
+        expect(example_group.examples.first.full_description).to eq("group description should eq 5")
+      end
+
       it "uses the file and line number if there is no matcher-generated description" do
         example = example_group.example {}
         example_group.run
@@ -314,7 +320,7 @@ describe RSpec::Core::Example, :parent_metadata => 'sample' do
         end
 
         message = run_and_capture_reported_message(group)
-        expect(message).to match /An error occurred in an around.* hook/i
+        expect(message).to match(/An error occurred in an around.* hook/i)
       end
 
       it "prints any after hook errors rather than silencing them" do
@@ -324,7 +330,7 @@ describe RSpec::Core::Example, :parent_metadata => 'sample' do
         end
 
         message = run_and_capture_reported_message(group)
-        expect(message).to match /An error occurred in an after.* hook/i
+        expect(message).to match(/An error occurred in an after.* hook/i)
       end
 
       it 'does not print mock expectation errors' do
@@ -415,4 +421,19 @@ describe RSpec::Core::Example, :parent_metadata => 'sample' do
       expect(example.metadata[:execution_result][:run_time]).to be < 0.2
     end
   end
+
+  it 'does not interfere with per-example randomness when running examples in a random order' do
+    values = []
+
+    RSpec.configuration.order = :random
+
+    RSpec::Core::ExampleGroup.describe do
+      # The bug was only triggered when the examples
+      # were in nested contexts; see https://github.com/rspec/rspec-core/pull/837
+      context { example { values << rand } }
+      context { example { values << rand } }
+    end.run
+
+    expect(values.uniq).to have(2).values
+  end
 end

data/spec/rspec/core/filter_manager_spec.rb

@@ -205,38 +205,38 @@ module RSpec::Core
       end
 
       it 'deprecates an overridden :if filter' do
-        RSpec.should_receive(:warn_deprecation).with(/exclude\(:if.*is deprecated/)
+        expect(RSpec).to receive(:deprecate).with(/exclude\(:if/)
         filter_manager = FilterManager.new
         filter_manager.exclude :if => :custom_filter
       end
 
       it 'deprecates an :if filter overridden with low priority' do
-        RSpec.should_receive(:warn_deprecation).with(/exclude\(:if.*is deprecated/)
+        expect(RSpec).to receive(:deprecate).with(/exclude\(:if/)
         filter_manager = FilterManager.new
         filter_manager.exclude_with_low_priority :if => :custom_filter
       end
 
       it 'deprecates an overridden :unless filter' do
-        RSpec.should_receive(:warn_deprecation).with(/exclude\(:unless.*is deprecated/)
+        expect(RSpec).to receive(:deprecate).with(/exclude\(:unless/)
         filter_manager = FilterManager.new
         filter_manager.exclude :unless => :custom_filter
       end
 
       it 'deprecates an :unless filter overridden with low priority' do
-        RSpec.should_receive(:warn_deprecation).with(/exclude\(:unless.*is deprecated/)
+        expect(RSpec).to receive(:deprecate).with(/exclude\(:unless/)
         filter_manager = FilterManager.new
         filter_manager.exclude_with_low_priority :unless => :custom_filter
       end
 
       it 'includes an overriden :if filter' do
-        RSpec.stub(:warn_deprecation)
+        allow(RSpec).to receive(:deprecate)
         filter_manager = FilterManager.new
         filter_manager.exclude :if => :custom_filter
         expect(filter_manager.exclusions.description).to eq({ :if => :custom_filter }.inspect)
       end
 
       it 'includes an overriden :unless filter' do
-        RSpec.stub(:warn_deprecation)
+        allow(RSpec).to receive(:deprecate)
         filter_manager = FilterManager.new
         filter_manager.exclude :unless => :custom_filter
         expect(filter_manager.exclusions.description).to eq({ :unless => :custom_filter }.inspect)

data/spec/rspec/core/formatters/base_text_formatter_spec.rb

@@ -46,8 +46,8 @@ describe RSpec::Core::Formatters::BaseTextFormatter do
 
       run_all_and_dump_failures
 
-      expect(output.string).to match /group name example name/m
-      expect(output.string).to match /(\s+)expected: \"that\"\n\1     got: \"this\"/m
+      expect(output.string).to match(/group name example name/m)
+      expect(output.string).to match(/(\s+)expected: \"that\"\n\1     got: \"this\"/m)
     end
 
     context "with an exception without a message" do
@@ -55,7 +55,7 @@ describe RSpec::Core::Formatters::BaseTextFormatter do
         exception_without_message = Exception.new()
         exception_without_message.stub(:message) { nil }
         group.example("example name") { raise exception_without_message }
-        expect { run_all_and_dump_failures }.not_to raise_error(NoMethodError)
+        expect { run_all_and_dump_failures }.not_to raise_error
       end
 
       it "preserves ancestry" do
@@ -70,7 +70,7 @@ describe RSpec::Core::Formatters::BaseTextFormatter do
         gonzo_exception = RuntimeError.new
         gonzo_exception.stub(:message) { gonzo_exception }
         group.example("example name") { raise gonzo_exception }
-        expect { run_all_and_dump_failures }.not_to raise_error(NoMethodError)
+        expect { run_all_and_dump_failures }.not_to raise_error
       end
     end
 
@@ -87,7 +87,7 @@ describe RSpec::Core::Formatters::BaseTextFormatter do
       it "does not show the error class" do
         group.example("example name") { raise NameError.new('foo') }
         run_all_and_dump_failures
-        expect(output.string).to match /NameError/m
+        expect(output.string).to match(/NameError/m)
       end
     end
 
@@ -95,7 +95,7 @@ describe RSpec::Core::Formatters::BaseTextFormatter do
       it "does not show the error class" do
         group.example("example name") { expect("this").to eq("that") }
         run_all_and_dump_failures
-        expect(output.string).not_to match /RSpec/m
+        expect(output.string).not_to match(/RSpec/m)
       end
     end
 
@@ -103,14 +103,14 @@ describe RSpec::Core::Formatters::BaseTextFormatter do
       it "does not show the error class" do
         group.example("example name") { "this".should_receive("that") }
         run_all_and_dump_failures
-        expect(output.string).not_to match /RSpec/m
+        expect(output.string).not_to match(/RSpec/m)
       end
     end
 
     context 'for #share_examples_for' do
       it 'outputs the name and location' do
 
-        share_examples_for 'foo bar' do
+        group.share_examples_for 'foo bar' do
           it("example name") { expect("this").to eq("that") }
         end
 
@@ -127,7 +127,7 @@ describe RSpec::Core::Formatters::BaseTextFormatter do
 
       context 'that contains nested example groups' do
         it 'outputs the name and location' do
-          share_examples_for 'foo bar' do
+          group.share_examples_for 'foo bar' do
             describe 'nested group' do
               it("example name") { expect("this").to eq("that") }
             end
@@ -147,11 +147,11 @@ describe RSpec::Core::Formatters::BaseTextFormatter do
     end
 
     context 'for #share_as' do
-      before { RSpec.stub(:warn) }
+      before { allow(RSpec).to receive(:deprecate) }
 
       it 'outputs the name and location' do
 
-        share_as :FooBar do
+        group.share_as :FooBar do
           it("example name") { expect("this").to eq("that") }
         end
 
@@ -169,7 +169,7 @@ describe RSpec::Core::Formatters::BaseTextFormatter do
       context 'that contains nested example groups' do
         it 'outputs the name and location' do
 
-          share_as :NestedFoo do
+          group.share_as :NestedFoo do
             describe 'nested group' do
               describe 'hell' do
                 it("example name") { expect("this").to eq("that") }
@@ -209,8 +209,8 @@ describe RSpec::Core::Formatters::BaseTextFormatter do
 
         run_all_and_dump_pending
 
-        expect(output.string).to match /group name example name/m
-        expect(output.string).to match /(\s+)expected: \"that\"\n\1     got: \"this\"/m
+        expect(output.string).to match(/group name example name/m)
+        expect(output.string).to match(/(\s+)expected: \"that\"\n\1     got: \"this\"/m)
       end
 
       context "with an exception without a message" do
@@ -218,7 +218,7 @@ describe RSpec::Core::Formatters::BaseTextFormatter do
           exception_without_message = Exception.new()
           exception_without_message.stub(:message) { nil }
           group.example("example name") { pending { raise exception_without_message } }
-          expect { run_all_and_dump_pending }.not_to raise_error(NoMethodError)
+          expect { run_all_and_dump_pending }.not_to raise_error
         end
       end
 
@@ -226,7 +226,7 @@ describe RSpec::Core::Formatters::BaseTextFormatter do
         it "does not show the error class" do
           group.example("example name") { pending { raise NameError.new('foo') } }
           run_all_and_dump_pending
-          expect(output.string).to match /NameError/m
+          expect(output.string).to match(/NameError/m)
         end
       end
 
@@ -234,7 +234,7 @@ describe RSpec::Core::Formatters::BaseTextFormatter do
         it "does not show the error class" do
           group.example("example name") { pending { expect("this").to eq("that") } }
           run_all_and_dump_pending
-          expect(output.string).not_to match /RSpec/m
+          expect(output.string).not_to match(/RSpec/m)
         end
       end
 
@@ -242,14 +242,14 @@ describe RSpec::Core::Formatters::BaseTextFormatter do
         it "does not show the error class" do
           group.example("example name") { pending { "this".should_receive("that") } }
           run_all_and_dump_pending
-          expect(output.string).not_to match /RSpec/m
+          expect(output.string).not_to match(/RSpec/m)
         end
       end
 
       context 'for #share_examples_for' do
         it 'outputs the name and location' do
 
-          share_examples_for 'foo bar' do
+          group.share_examples_for 'foo bar' do
             it("example name") { pending { expect("this").to eq("that") } }
           end
 
@@ -266,7 +266,7 @@ describe RSpec::Core::Formatters::BaseTextFormatter do
 
         context 'that contains nested example groups' do
           it 'outputs the name and location' do
-            share_examples_for 'foo bar' do
+            group.share_examples_for 'foo bar' do
               describe 'nested group' do
                 it("example name") { pending { expect("this").to eq("that") } }
               end
@@ -286,11 +286,11 @@ describe RSpec::Core::Formatters::BaseTextFormatter do
       end
 
       context 'for #share_as' do
-        before { RSpec.stub(:warn) }
+        before { allow(RSpec).to receive(:deprecate) }
 
         it 'outputs the name and location' do
 
-          share_as :FooBar2 do
+          group.share_as :FooBar2 do
             it("example name") { pending { expect("this").to eq("that") } }
           end
 
@@ -308,7 +308,7 @@ describe RSpec::Core::Formatters::BaseTextFormatter do
         context 'that contains nested example groups' do
           it 'outputs the name and location' do
 
-            share_as :NestedFoo2 do
+            group.share_as :NestedFoo2 do
               describe 'nested group' do
                 describe 'hell' do
                   it("example name") { pending { expect("this").to eq("that") } }
@@ -336,12 +336,12 @@ describe RSpec::Core::Formatters::BaseTextFormatter do
       it "does not output the failure information" do
         group.example("example name") { pending { expect("this").to eq("that") } }
         run_all_and_dump_pending
-        expect(output.string).not_to match /(\s+)expected: \"that\"\n\1     got: \"this\"/m
+        expect(output.string).not_to match(/(\s+)expected: \"that\"\n\1     got: \"this\"/m)
       end
     end
   end
 
-  describe "#dump_profile" do
+  describe "#dump_profile_slowest_examples" do
     example_line_number = nil
 
     before do
@@ -358,25 +358,88 @@ describe RSpec::Core::Formatters::BaseTextFormatter do
     end
 
     it "names the example" do
-      formatter.dump_profile
-      expect(output.string).to match /group example/m
+      formatter.dump_profile_slowest_examples
+      expect(output.string).to match(/group example/m)
     end
 
     it "prints the time" do
-      formatter.dump_profile
-      expect(output.string).to match /0(\.\d+)? seconds/
+      formatter.dump_profile_slowest_examples
+      expect(output.string).to match(/0(\.\d+)? seconds/)
     end
 
     it "prints the path" do
-      formatter.dump_profile
+      formatter.dump_profile_slowest_examples
       filename = __FILE__.split(File::SEPARATOR).last
 
-      expect(output.string).to match /#{filename}\:#{example_line_number}/
+      expect(output.string).to match(/#{filename}\:#{example_line_number}/)
     end
 
     it "prints the percentage taken from the total runtime" do
-      formatter.dump_profile
-      expect(output.string).to match /, 100.0% of total time\):/
+      formatter.dump_profile_slowest_examples
+      expect(output.string).to match(/, 100.0% of total time\):/)
+    end
+  end
+
+  describe "#dump_profile_slowest_example_groups" do
+    let(:group) do 
+      RSpec::Core::ExampleGroup.describe("slow group") do
+        # Use a sleep so there is some measurable time, to ensure
+        # the reported percent is 100%, not 0%.
+        example("example") { sleep 0.01 }
+      end 
+    end
+    let(:rpt) { double('reporter').as_null_object }
+
+    before do
+      group.run(rpt)
+      RSpec.configuration.stub(:profile_examples) { 10 }
+    end
+
+    context "with one example group" do
+      before { formatter.stub(:examples) { group.examples } }
+
+      it "doesn't profile a single example group" do
+        formatter.dump_profile_slowest_example_groups
+        expect(output.string).not_to match(/slowest example groups/)
+      end
+    end
+
+    context "with multiple example groups" do
+      before do
+        group2 = RSpec::Core::ExampleGroup.describe("fast group") do
+          example("example 1") { sleep 0.004 }
+          example("example 2") { sleep 0.007 }
+        end
+        group2.run(rpt)
+
+        formatter.stub(:examples) { group.examples + group2.examples }
+      end
+
+      it "prints the slowest example groups" do
+        formatter.dump_profile_slowest_example_groups
+        expect(output.string).to match(/slowest example groups/)
+      end
+
+      it "prints the time" do
+        formatter.dump_profile_slowest_example_groups
+        expect(output.string).to match(/0(\.\d+)? seconds/)
+      end
+
+      it "ranks the example groups by average time" do
+        formatter.dump_profile_slowest_example_groups
+        expect(output.string).to match(/slow group(.*)fast group/m)
+      end
+    end
+
+    it "depends on parent_groups to get the top level example group" do
+      ex = ""
+      group.describe("group 2") do 
+        describe "group 3" do
+          ex = example("nested example 1") 
+        end
+      end
+
+      expect(ex.example_group.parent_groups.last).to eq(group)
     end
   end
 
@@ -411,8 +474,8 @@ describe RSpec::Core::Formatters::BaseTextFormatter do
 
     describe "##{name}" do
       before do
-        RSpec.configuration.stub(:color_enabled?) { true }
-        RSpec.stub(:warn)
+        allow(RSpec.configuration).to receive(:color_enabled?) { true }
+        allow(RSpec).to receive(:deprecate)
       end
 
       it "prints the text using the color code for #{name}" do
@@ -420,7 +483,9 @@ describe RSpec::Core::Formatters::BaseTextFormatter do
       end
 
       it "prints a deprecation warning" do
-        RSpec.should_receive(:warn).with(/#{name}/)
+        expect(RSpec).to receive(:deprecate) {|*args|
+          expect(args.first).to match(/#{name}/)
+        }
         formatter.send(name, "text")
       end
     end