RubyGems - rspec-core - Versions diffs - 2.13.1 → 2.14.0.rc1 - Mend

rspec-core 2.13.1 → 2.14.0.rc1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (112) hide show

data/Changelog.md +80 -0
data/exe/autospec +1 -1
data/features/README.md +2 -2
data/features/command_line/format_option.feature +8 -14
data/features/command_line/line_number_appended_to_path.feature +4 -4
data/features/command_line/line_number_option.feature +1 -1
data/features/command_line/rake_task.feature +2 -2
data/features/command_line/require_option.feature +43 -0
data/features/command_line/ruby.feature +2 -2
data/features/command_line/warnings_option.feature +27 -0
data/features/configuration/backtrace_clean_patterns.feature +2 -2
data/features/configuration/deprecation_stream.feature +58 -0
data/features/configuration/pattern.feature +8 -0
data/features/configuration/profile.feature +59 -2
data/features/configuration/read_options_from_file.feature +8 -5
data/features/configuration/run_all_when_everything_filtered.feature +20 -4
data/features/example_groups/basic_structure.feature +1 -1
data/features/example_groups/shared_context.feature +1 -1
data/features/example_groups/shared_examples.feature +72 -0
data/features/filtering/exclusion_filters.feature +10 -10
data/features/formatters/custom_formatter.feature +1 -1
data/features/hooks/before_and_after_hooks.feature +19 -19
data/features/mock_framework_integration/use_any_framework.feature +6 -6
data/features/mock_framework_integration/use_flexmock.feature +3 -3
data/features/mock_framework_integration/use_mocha.feature +3 -3
data/features/mock_framework_integration/use_rr.feature +3 -3
data/features/mock_framework_integration/use_rspec.feature +3 -3
data/features/subject/implicit_subject.feature +1 -1
data/lib/rspec/core.rb +20 -3
data/lib/rspec/core/backtrace_cleaner.rb +46 -0
data/lib/rspec/core/backward_compatibility.rb +3 -13
data/lib/rspec/core/configuration.rb +136 -49
data/lib/rspec/core/configuration_options.rb +19 -8
data/lib/rspec/core/deprecation.rb +18 -30
data/lib/rspec/core/example.rb +3 -3
data/lib/rspec/core/example_group.rb +4 -3
data/lib/rspec/core/extensions/kernel.rb +1 -1
data/lib/rspec/core/filter_manager.rb +1 -1
data/lib/rspec/core/formatters.rb +1 -1
data/lib/rspec/core/formatters/base_formatter.rb +10 -1
data/lib/rspec/core/formatters/base_text_formatter.rb +47 -10
data/lib/rspec/core/formatters/deprecation_formatter.rb +35 -0
data/lib/rspec/core/formatters/helpers.rb +12 -5
data/lib/rspec/core/formatters/html_formatter.rb +7 -6
data/lib/rspec/core/formatters/html_printer.rb +13 -12
data/lib/rspec/core/formatters/json_formatter.rb +1 -2
data/lib/rspec/core/formatters/text_mate_formatter.rb +1 -1
data/lib/rspec/core/hooks.rb +9 -0
data/lib/rspec/core/memoized_helpers.rb +19 -8
data/lib/rspec/core/metadata.rb +3 -1
data/lib/rspec/core/mocking/with_flexmock.rb +1 -1
data/lib/rspec/core/mocking/with_rr.rb +1 -1
data/lib/rspec/core/option_parser.rb +6 -2
data/lib/rspec/core/pending.rb +1 -0
data/lib/rspec/core/rake_task.rb +11 -19
data/lib/rspec/core/reporter.rb +33 -4
data/lib/rspec/core/shared_example_group.rb +56 -16
data/lib/rspec/core/shared_example_group/collection.rb +42 -0
data/lib/rspec/core/version.rb +1 -1
data/lib/rspec/core/world.rb +2 -3
data/spec/autotest/rspec_spec.rb +2 -2
data/spec/rspec/core/backtrace_cleaner_spec.rb +68 -0
data/spec/rspec/core/configuration_options_spec.rb +15 -4
data/spec/rspec/core/configuration_spec.rb +202 -19
data/spec/rspec/core/deprecation_spec.rb +41 -0
data/spec/rspec/core/deprecations_spec.rb +10 -12
data/spec/rspec/core/drb_command_line_spec.rb +1 -1
data/spec/rspec/core/example_group_spec.rb +37 -36
data/spec/rspec/core/example_spec.rb +25 -4
data/spec/rspec/core/filter_manager_spec.rb +6 -6
data/spec/rspec/core/formatters/base_text_formatter_spec.rb +101 -36
data/spec/rspec/core/formatters/deprecation_formatter_spec.rb +78 -0
data/spec/rspec/core/formatters/documentation_formatter_spec.rb +2 -2
data/spec/rspec/core/formatters/helpers_spec.rb +23 -7
data/spec/rspec/core/formatters/html_formatted-1.8.7-jruby.html +20 -14
data/spec/rspec/core/formatters/html_formatted-1.8.7-rbx.html +69 -169
data/spec/rspec/core/formatters/html_formatted-1.8.7.html +28 -23
data/spec/rspec/core/formatters/html_formatted-1.9.2.html +42 -33
data/spec/rspec/core/formatters/html_formatted-1.9.3-jruby.html +17 -23
data/spec/rspec/core/formatters/html_formatted-1.9.3-rbx.html +57 -157
data/spec/rspec/core/formatters/html_formatted-1.9.3.html +42 -33
data/spec/rspec/core/formatters/html_formatted-2.0.0.html +42 -33
data/spec/rspec/core/formatters/html_formatter_spec.rb +1 -0
data/spec/rspec/core/formatters/progress_formatter_spec.rb +3 -3
data/spec/rspec/core/formatters/text_mate_formatted-1.8.7-jruby.html +11 -14
data/spec/rspec/core/formatters/text_mate_formatted-1.8.7-rbx.html +103 -203
data/spec/rspec/core/formatters/text_mate_formatted-1.8.7.html +30 -25
data/spec/rspec/core/formatters/text_mate_formatted-1.9.2.html +42 -33
data/spec/rspec/core/formatters/text_mate_formatted-1.9.3-jruby.html +20 -14
data/spec/rspec/core/formatters/text_mate_formatted-1.9.3-rbx.html +103 -203
data/spec/rspec/core/formatters/text_mate_formatted-1.9.3.html +42 -33
data/spec/rspec/core/formatters/text_mate_formatted-2.0.0.html +42 -33
data/spec/rspec/core/formatters/text_mate_formatter_spec.rb +1 -0
data/spec/rspec/core/memoized_helpers_spec.rb +28 -0
data/spec/rspec/core/metadata_spec.rb +8 -3
data/spec/rspec/core/option_parser_spec.rb +8 -0
data/spec/rspec/core/project_initializer_spec.rb +2 -2
data/spec/rspec/core/rake_task_spec.rb +8 -8
data/spec/rspec/core/reporter_spec.rb +26 -6
data/spec/rspec/core/resources/formatter_specs.rb +3 -3
data/spec/rspec/core/shared_context_spec.rb +20 -0
data/spec/rspec/core/shared_example_group/collection_spec.rb +70 -0
data/spec/rspec/core/shared_example_group_spec.rb +4 -4
data/spec/rspec/core/world_spec.rb +1 -3
data/spec/rspec/core_spec.rb +20 -0
data/spec/spec_helper.rb +29 -29
data/spec/support/helper_methods.rb +9 -1
data/spec/support/isolate_load_path_mutation.rb +6 -0
data/spec/support/sandboxed_mock_space.rb +100 -0
metadata +28 -13
data/features/filtering/run_all_when_everything_filtered.feature +0 -46
data/lib/rspec/core/load_path.rb +0 -3

data/lib/rspec/core/formatters/html_printer.rb CHANGED

@@ -30,7 +30,7 @@ module RSpec
           @output.puts "    <dd class=\"example passed\"><span class=\"passed_spec_name\">#{h(description)}</span><span class='duration'>#{formatted_run_time}s</span></dd>"
         end
-        def print_example_failed( pending_fixed, description, run_time, failure_id, exception, extra_content )
+        def print_example_failed( pending_fixed, description, run_time, failure_id, exception, extra_content, escape_backtrace = false )
           formatted_run_time = sprintf("%.5f", run_time)
           @output.puts "    <dd class=\"example #{pending_fixed ? 'pending_fixed' : 'failed'}\">"
@@ -39,7 +39,11 @@ module RSpec
           @output.puts "      <div class=\"failure\" id=\"failure_#{failure_id}\">"
           if exception
             @output.puts "        <div class=\"message\"><pre>#{h(exception[:message])}</pre></div>"
-            @output.puts "        <div class=\"backtrace\"><pre>#{exception[:backtrace]}</pre></div>"
+            if escape_backtrace
+              @output.puts "        <div class=\"backtrace\"><pre>#{h exception[:backtrace]}</pre></div>"
+            else
+              @output.puts "        <div class=\"backtrace\"><pre>#{exception[:backtrace]}</pre></div>"
+            end
           end
           @output.puts extra_content if extra_content
           @output.puts "      </div>"
@@ -114,14 +118,14 @@ module RSpec
   </div>
   <div id="display-filters">
-    <input id="passed_checkbox" name="passed_checkbox" type="checkbox" checked onchange="apply_filters()" value="1"> <label for="passed_checkbox">Passed</label>
-    <input id="failed_checkbox" name="failed_checkbox" type="checkbox" checked onchange="apply_filters()" value="2"> <label for="failed_checkbox">Failed</label>
-    <input id="pending_checkbox" name="pending_checkbox" type="checkbox" checked onchange="apply_filters()" value="3"> <label for="pending_checkbox">Pending</label>
+    <input id="passed_checkbox"  name="passed_checkbox"  type="checkbox" checked="checked" onchange="apply_filters()" value="1" /> <label for="passed_checkbox">Passed</label>
+    <input id="failed_checkbox"  name="failed_checkbox"  type="checkbox" checked="checked" onchange="apply_filters()" value="2" /> <label for="failed_checkbox">Failed</label>
+    <input id="pending_checkbox" name="pending_checkbox" type="checkbox" checked="checked" onchange="apply_filters()" value="3" /> <label for="pending_checkbox">Pending</label>
   </div>
   <div id="summary">
-    <p id="totals">&nbsp;</p>
-    <p id="duration">&nbsp;</p>
+    <p id="totals">&#160;</p>
+    <p id="duration">&#160;</p>
   </div>
 </div>
@@ -371,11 +375,8 @@ a {
 EOF
         HTML_HEADER = <<-EOF
-<?xml version="1.0" encoding="UTF-8"?>
-<!DOCTYPE html
-  PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
-  "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
-<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
+<!DOCTYPE html>
+<html lang='en'>
 <head>
   <title>RSpec results</title>
   <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />

data/lib/rspec/core/formatters/json_formatter.rb CHANGED

@@ -28,8 +28,7 @@ module RSpec
           }
           @output_hash[:summary_line] = summary_line(example_count, failure_count, pending_count)
-          # Don't print out profiled info if there are failures, it just clutters the output
-          dump_profile if profile_examples? && failure_count == 0
+          dump_profile unless mute_profile_output?(failure_count)
         end
         def summary_line(example_count, failure_count, pending_count)

data/lib/rspec/core/formatters/text_mate_formatter.rb CHANGED

@@ -17,7 +17,7 @@ module RSpec
         def format_backtrace_line_for_textmate(line)
           return nil unless line
           CGI.escapeHTML(line).sub(/([^:]*\.e?rb):(\d*)/) do
-            "<a href=\"txmt://open?url=file://#{File.expand_path($1)}&line=#{$2}\">#{$1}:#{$2}</a> "
+            "<a href=\"txmt://open?url=file://#{File.expand_path($1)}&amp;line=#{$2}\">#{$1}:#{$2}</a> "
           end
         end

data/lib/rspec/core/hooks.rb CHANGED

@@ -242,6 +242,15 @@ module RSpec
       # state of a shared object, resulting in an ordering dependency that can
       # make it difficult to reason about failures.
       #
+      # #### unsupported rspec constructs
+      #
+      # RSpec has several constructs that reset state between each example
+      # automatically. These are not intended for use from within `before(:all)`:
+      #
+      #   * `let` declarations
+      #   * `subject` declarations
+      #   * Any mocking, stubbing or test double declaration
+      #
       # ### other frameworks
       #
       # Mock object frameworks and database transaction managers (like

data/lib/rspec/core/memoized_helpers.rb CHANGED

@@ -36,6 +36,13 @@ module RSpec
       #     it { should be_eligible_to_vote }
       #   end
       #
+      # @note Because `subject` is designed to create state that is reset between
+      #   each example, and `before(:all)` is designed to setup state that is
+      #   shared across _all_ examples in an example group, `subject` is _not_
+      #   intended to be used in a `before(:all)` hook. RSpec 2.13.1 prints
+      #   a warning when you reference a `subject` from `before(:all)` and we plan
+      #   to have it raise an error in RSpec 3.
+      #
       # @see #should
       def subject
         raise NotImplementedError, 'This definition is here for documentation purposes only'
@@ -132,6 +139,7 @@ EOS
           @example_group_instance.class.class_eval do
             hash.each do |key, value|
+              undef_method(key) if method_defined?(key)
               define_method(key) { value }
             end
           end
@@ -161,6 +169,13 @@ EOS
         #   behave in surprising ways in examples that spawn separate threads,
         #   though we have yet to see this in practice. You've been warned.
         #
+        # @note Because `let` is designed to create state that is reset between
+        #   each example, and `before(:all)` is designed to setup state that is
+        #   shared across _all_ examples in an example group, `let` is _not_
+        #   intended to be used in a `before(:all)` hook. RSpec 2.13.1 prints
+        #   a warning when you reference a `let` from `before(:all)` and we plan
+        #   to have it raise an error in RSpec 3.
+        #
         # @example
         #
         #   describe Thing do
@@ -177,7 +192,8 @@ EOS
         def let(name, &block)
           # We have to pass the block directly to `define_method` to
           # allow it to use method constructs like `super` and `return`.
-          MemoizedHelpers.module_for(self).define_method(name, &block)
+          raise "#let or #subject called without a block" if block.nil?
+          MemoizedHelpers.module_for(self).send(:define_method, name, &block)
           # Apply the memoization. The method has been defined in an ancestor
           # module so we can use `super` here to get the value.
@@ -276,9 +292,9 @@ EOS
         def subject(name=nil, &block)
           if name
             let(name, &block)
-            subject { __send__ name }
+            alias_method :subject, name
-            self::NamedSubjectPreventSuper.define_method(name) do
+            self::NamedSubjectPreventSuper.send(:define_method, name) do
               raise NotImplementedError, "`super` in named subjects is not supported"
             end
           else
@@ -451,13 +467,8 @@ EOS
         get_constant_or_yield(example_group, :LetDefinitions) do
           mod = Module.new do
             include Module.new {
-              public_class_method :define_method
               example_group.const_set(:NamedSubjectPreventSuper, self)
             }
-            # Expose `define_method` as a public method, so we can
-            # easily use it below.
-            public_class_method :define_method
           end
           example_group.__send__(:include, mod)

data/lib/rspec/core/metadata.rb CHANGED

@@ -73,6 +73,8 @@ module RSpec
             store(:full_description, full_description)
           when :description
             store(:description, build_description_from(*self[:description_args]))
+          when :description_args
+            store(:description_args, [])
           end
         end
@@ -244,7 +246,7 @@ module RSpec
       protected
       def configure_for_example(description, user_metadata)
-        store(:description_args, [description])
+        store(:description_args, [description]) if description
         store(:caller, user_metadata.delete(:caller) || caller)
         update(user_metadata)
       end

data/lib/rspec/core/mocking/with_flexmock.rb CHANGED

@@ -8,7 +8,7 @@ require 'flexmock/rspec'
 module RSpec
   module Core
     module MockFrameworkAdapter
       def self.framework_name; :flexmock end
       include FlexMock::MockContainer

data/lib/rspec/core/mocking/with_rr.rb CHANGED

@@ -5,7 +5,7 @@ RSpec.configuration.backtrace_clean_patterns.push(RR::Errors::BACKTRACE_IDENTIFI
 module RSpec
   module Core
     module MockFrameworkAdapter
       def self.framework_name; :rr end
       include RR::Extensions::InstanceMethods

data/lib/rspec/core/option_parser.rb CHANGED

@@ -30,7 +30,7 @@ module RSpec::Core
       args.map! { |arg|
         case arg
         when "--formatter"
-          RSpec.deprecate("the --formatter option", "-f or --format")
+          RSpec.deprecate("the --formatter option", :replacement => "-f or --format")
           "--format"
         when "--default_path"
           "--default-path"
@@ -119,7 +119,7 @@ module RSpec::Core
         end
         parser.on('-o', '--out FILE',
-                  'Write output to a file instead of STDOUT. This option applies',
+                  'Write output to a file instead of $stdout. This option applies',
                   '  to the previously specified --format, or the default format',
                   '  if no format is specified.'
                  ) do |o|
@@ -145,6 +145,10 @@ module RSpec::Core
                                        end
         end
+        parser.on('-w', '--warnings', 'Enable ruby warnings') do
+          options[:warnings] = true
+        end
         parser.separator <<-FILTERING
   **** Filtering/tags ****

data/lib/rspec/core/pending.rb CHANGED

@@ -92,6 +92,7 @@ module RSpec
             result = begin
                        yield
                        example.example_group_instance.instance_eval { verify_mocks_for_rspec }
+                       true
                      end
             example.metadata[:pending] = false
           rescue Exception => e

data/lib/rspec/core/rake_task.rb CHANGED

@@ -30,7 +30,7 @@ module RSpec
       # @deprecated
       # Has no effect. The rake task now checks ENV['BUNDLE_GEMFILE'] instead.
       def gemfile=(*)
-        RSpec.deprecate("RSpec::Core::RakeTask#gemfile=", 'ENV["BUNDLE_GEMFILE"]')
+        RSpec.deprecate("RSpec::Core::RakeTask#gemfile=", :replacement => 'ENV["BUNDLE_GEMFILE"]')
       end
       # @deprecated
@@ -42,7 +42,7 @@ module RSpec
       # default:
       #   false
       def warning=(true_or_false)
-        RSpec.deprecate("RSpec::Core::RakeTask#warning=", 'ruby_opts="-w"')
+        RSpec.deprecate("RSpec::Core::RakeTask#warning=", :replacement => 'ruby_opts="-w"')
         @warning = true_or_false
       end
@@ -109,7 +109,7 @@ module RSpec
       # default:
       #   nil
       def spec_opts=(opts)
-        RSpec.deprecate('RSpec::Core::RakeTask#spec_opts=', 'rspec_opts=')
+        RSpec.deprecate('RSpec::Core::RakeTask#spec_opts=', :replacement => 'rspec_opts=')
         @rspec_opts = opts
       end
@@ -137,24 +137,16 @@ module RSpec
         @pattern    = './spec{,/*/**}/*_spec.rb'
       end
-      def has_files?
-        empty = files_to_run.empty?
-        puts "No examples matching #{pattern} could be found" if empty
-        not empty
-      end
       def run_task(verbose)
-        files = has_files?
-        if files
-          command = spec_command
-          begin
-            puts command if verbose
-            success = system(command)
-          rescue
-            puts failure_message if failure_message
-          end
-          raise("#{command} failed") if fail_on_error unless success
+        command = spec_command
+        begin
+          puts command if verbose
+          success = system(command)
+        rescue
+          puts failure_message if failure_message
         end
+        abort("#{command} failed") if fail_on_error unless success
       end
     private

data/lib/rspec/core/reporter.rb CHANGED

@@ -1,11 +1,35 @@
 module RSpec::Core
   class Reporter
+    NOTIFICATIONS = %W[start message example_group_started example_group_finished example_started
+                       example_passed example_failed example_pending start_dump dump_pending
+                       dump_failures dump_summary seed close stop deprecation deprecation_summary].map(&:to_sym)
     def initialize(*formatters)
-      @formatters = formatters
+      @listeners = Hash.new { |h,k| h[k] = [] }
+      formatters.each do |formatter|
+        register_listener(formatter, *NOTIFICATIONS)
+      end
       @example_count = @failure_count = @pending_count = 0
       @duration = @start = nil
     end
+    # @api
+    # @param [Object] An obect that wishes to be notified of reporter events
+    # @param [Array] Array of symbols represents the events a listener wishes to subscribe too
+    #
+    # Registers a listener to a list of notifications. The reporter will send notification of
+    # events to all registered listeners
+    def register_listener(listener, *notifications)
+      notifications.each do |notification|
+        @listeners[notification.to_sym] << listener if listener.respond_to?(notification)
+      end
+      true
+    end
+    def registered_listeners(notification)
+      @listeners[notification]
+    end
     # @api
     # @overload report(count, &block)
     # @overload report(count, seed, &block)
@@ -73,6 +97,10 @@ module RSpec::Core
       notify :example_pending, example
     end
+    def deprecation(message)
+      notify :deprecation, message
+    end
     def finish(seed)
       begin
         stop
@@ -80,6 +108,7 @@ module RSpec::Core
         notify :dump_pending
         notify :dump_failures
         notify :dump_summary, @duration, @example_count, @failure_count, @pending_count
+        notify :deprecation_summary
         notify :seed, seed if seed
       ensure
         notify :close
@@ -93,9 +122,9 @@ module RSpec::Core
       notify :stop
     end
-    def notify(method, *args, &block)
-      @formatters.each do |formatter|
-        formatter.send method, *args, &block
+    def notify(event, *args, &block)
+      registered_listeners(event).each do |formatter|
+        formatter.send(event, *args, &block)
       end
     end
   end

data/lib/rspec/core/shared_example_group.rb CHANGED

@@ -28,8 +28,8 @@ module RSpec
       # @see ExampleGroup.it_behaves_like
       # @see ExampleGroup.include_examples
       # @see ExampleGroup.include_context
-      def shared_examples *args, &block
-        Registry.add_group(*args, &block)
+      def shared_examples(*args, &block)
+        Registry.add_group(self, *args, &block)
       end
       alias_method :shared_context,      :shared_examples
@@ -39,8 +39,32 @@ module RSpec
       # @deprecated
       def share_as(name, &block)
         RSpec.deprecate("Rspec::Core::SharedExampleGroup#share_as",
-                        "RSpec::SharedContext or shared_examples")
-        Registry.add_const(name, &block)
+                        :replacement => "RSpec::SharedContext or shared_examples")
+        Registry.add_const(self, name, &block)
+      end
+      def shared_example_groups
+        Registry.shared_example_groups_for('main', *ancestors[0..-1])
+      end
+      module TopLevelDSL
+        def shared_examples(*args, &block)
+          Registry.add_group('main', *args, &block)
+        end
+        alias_method :shared_context,      :shared_examples
+        alias_method :share_examples_for,  :shared_examples
+        alias_method :shared_examples_for, :shared_examples
+        def share_as(name, &block)
+          RSpec.deprecate("Rspec::Core::SharedExampleGroup#share_as",
+                          :replacement => "RSpec::SharedContext or shared_examples")
+          Registry.add_const('main', name, &block)
+        end
+        def shared_example_groups
+          Registry.shared_example_groups_for('main')
+        end
       end
       # @private
@@ -53,13 +77,13 @@ module RSpec
       module Registry
         extend self
-        def add_group(*args, &block)
+        def add_group(source, *args, &block)
           ensure_block_has_source_location(block, caller[1])
           if key? args.first
             key = args.shift
-            warn_if_key_taken key, block
-            RSpec.world.shared_example_groups[key] = block
+            warn_if_key_taken source, key, block
+            add_shared_example_group source, key, block
           end
           unless args.empty?
@@ -71,7 +95,7 @@ module RSpec
           end
         end
-        def add_const(name, &block)
+        def add_const(source, name, &block)
           if Object.const_defined?(name)
             mod = Object.const_get(name)
             raise_name_error unless mod.created_from_caller(caller)
@@ -92,12 +116,28 @@ module RSpec
           end
           shared_const = Object.const_set(name, mod)
-          RSpec.world.shared_example_groups[shared_const] = block
+          add_shared_example_group source, shared_const, block
+        end
+        def shared_example_groups_for(*sources)
+          Collection.new(sources, shared_example_groups)
+        end
+        def shared_example_groups
+          @shared_example_groups ||= Hash.new { |hash,key| hash[key] = Hash.new }
+        end
+        def clear
+          @shared_example_groups.clear
         end
       private
-        def key? candidate
+        def add_shared_example_group(source, key, block)
+          shared_example_groups[source][key] = block
+        end
+        def key?(candidate)
           [String, Symbol, Module].any? { |cls| cls === candidate }
         end
@@ -105,8 +145,8 @@ module RSpec
           raise NameError, "The first argument (#{name}) to share_as must be a legal name for a constant not already in use."
         end
-        def warn_if_key_taken key, new_block
-          return unless existing_block = example_block_for(key)
+        def warn_if_key_taken(source, key, new_block)
+          return unless existing_block = example_block_for(source, key)
           Kernel.warn <<-WARNING.gsub(/^ +\|/, '')
             |WARNING: Shared example group '#{key}' has been previously defined at:
@@ -117,12 +157,12 @@ module RSpec
           WARNING
         end
-        def formatted_location block
+        def formatted_location(block)
           block.source_location.join ":"
         end
-        def example_block_for key
-          RSpec.world.shared_example_groups[key]
+        def example_block_for(source, key)
+          shared_example_groups[source][key]
         end
         def ensure_block_has_source_location(block, caller_line)
@@ -139,6 +179,6 @@ module RSpec
   end
 end
-extend RSpec::Core::SharedExampleGroup
+extend RSpec::Core::SharedExampleGroup::TopLevelDSL
 Module.send(:include, RSpec::Core::SharedExampleGroup)