roo 2.7.0 → 2.8.3

data/test/helpers/test_styles.rb

@@ -0,0 +1,62 @@
+module TestStyles
+  def test_cell_styles
+    # styles only valid in excel spreadsheets?
+    # TODO: what todo with other spreadsheet types
+    with_each_spreadsheet(name: "style", format: [:excelx]) do |oo|
+      # bold
+      assert_equal true, oo.font(1, 1).bold?
+      assert_equal false, oo.font(1, 1).italic?
+      assert_equal false, oo.font(1, 1).underline?
+
+      # italic
+      assert_equal false, oo.font(2, 1).bold?
+      assert_equal true, oo.font(2, 1).italic?
+      assert_equal false, oo.font(2, 1).underline?
+
+      # normal
+      assert_equal false, oo.font(3, 1).bold?
+      assert_equal false, oo.font(3, 1).italic?
+      assert_equal false, oo.font(3, 1).underline?
+
+      # underline
+      assert_equal false, oo.font(4, 1).bold?
+      assert_equal false, oo.font(4, 1).italic?
+      assert_equal true, oo.font(4, 1).underline?
+
+      # bold italic
+      assert_equal true, oo.font(5, 1).bold?
+      assert_equal true, oo.font(5, 1).italic?
+      assert_equal false, oo.font(5, 1).underline?
+
+      # bold underline
+      assert_equal true, oo.font(6, 1).bold?
+      assert_equal false, oo.font(6, 1).italic?
+      assert_equal true, oo.font(6, 1).underline?
+
+      # italic underline
+      assert_equal false, oo.font(7, 1).bold?
+      assert_equal true, oo.font(7, 1).italic?
+      assert_equal true, oo.font(7, 1).underline?
+
+      # bolded row
+      assert_equal true, oo.font(8, 1).bold?
+      assert_equal false, oo.font(8, 1).italic?
+      assert_equal false, oo.font(8, 1).underline?
+
+      # bolded col
+      assert_equal true, oo.font(9, 2).bold?
+      assert_equal false, oo.font(9, 2).italic?
+      assert_equal false, oo.font(9, 2).underline?
+
+      # bolded row, italic col
+      assert_equal true, oo.font(10, 3).bold?
+      assert_equal true, oo.font(10, 3).italic?
+      assert_equal false, oo.font(10, 3).underline?
+
+      # normal
+      assert_equal false, oo.font(11, 4).bold?
+      assert_equal false, oo.font(11, 4).italic?
+      assert_equal false, oo.font(11, 4).underline?
+    end
+  end
+end

data/test/roo/test_base.rb

@@ -0,0 +1,182 @@
+require "test_helper"
+
+class TestRooBase < Minitest::Test
+  def test_info
+    # NOTE: unfortunately, the ods and xlsx versions of numbers1 are not
+    #       identical, so this test fails for Open Office.
+    expected_templ = File.read("#{TESTDIR}/expected_results/numbers_info.yml")
+    with_each_spreadsheet(name: "numbers1", format: [:excelx]) do |workbook|
+      ext = get_extension(workbook)
+      expected = Kernel.format(expected_templ, ext)
+      assert_equal expected.strip, workbook.info.strip
+    end
+  end
+
+  def test_column
+    with_each_spreadsheet(name: "numbers1") do |workbook|
+      expected = [1.0, 5.0, nil, 10.0, Date.new(1961, 11, 21), "tata", nil, nil, nil, nil, "thisisa11", 41.0, nil, nil, 41.0, "einundvierzig", nil, Date.new(2007, 5, 31)]
+      assert_equal expected, workbook.column(1)
+      assert_equal expected, workbook.column("a")
+    end
+  end
+
+  def test_column_huge_document
+    skip_long_test
+    with_each_spreadsheet(name: "Bibelbund", format: [:openoffice, :excelx]) do |workbook|
+      workbook.default_sheet = workbook.sheets.first
+      assert_equal 3735, workbook.column("a").size
+    end
+  end
+
+  def test_simple_spreadsheet_find_by_condition
+    with_each_spreadsheet(name: "simple_spreadsheet") do |workbook|
+      workbook.header_line = 3
+      results = workbook.find(:all, conditions: { "Comment" => "Task 1" })
+      assert_equal Date.new(2007, 05, 07), results[1]["Date"]
+      assert_equal 10.75, results[1]["Start time"]
+      assert_equal 12.50, results[1]["End time"]
+      assert_equal 0, results[1]["Pause"]
+      assert_equal 1.75, results[1]["Sum"]
+      assert_equal "Task 1", results[1]["Comment"]
+    end
+  end
+
+  def test_bug_bbu
+    expected_templ = File.read("#{TESTDIR}/expected_results/bbu_info.txt")
+    with_each_spreadsheet(name: "bbu", format: [:openoffice, :excelx]) do |workbook|
+      ext = get_extension(workbook)
+      expected_result = Kernel.format(expected_templ, ext)
+      assert_equal expected_result.strip, workbook.info.strip
+
+      workbook.default_sheet = workbook.sheets[1] # empty sheet
+      assert_nil workbook.first_row
+      assert_nil workbook.last_row
+      assert_nil workbook.first_column
+      assert_nil workbook.last_column
+    end
+  end
+
+  def test_find_by_row_huge_document
+    skip_long_test
+    options = { name: "Bibelbund", format: [:openoffice, :excelx] }
+    with_each_spreadsheet(options) do |workbook|
+      workbook.default_sheet = workbook.sheets.first
+      result = workbook.find 20
+      assert result
+      assert_equal "Brief aus dem Sekretariat", result[0]
+
+      result = workbook.find 22
+      assert result
+      assert_equal "Brief aus dem Skretariat. Tagung in Amberg/Opf.", result[0]
+    end
+  end
+
+  def test_find_by_row
+    with_each_spreadsheet(name: "numbers1") do |workbook|
+      workbook.header_line = nil
+      result = workbook.find 16
+      assert result
+      assert_nil workbook.header_line
+      # keine Headerlines in diesem Beispiel definiert
+      assert_equal "einundvierzig", result[0]
+      # assert_equal false, results
+      result = workbook.find 15
+      assert result
+      assert_equal 41, result[0]
+    end
+  end
+
+  def test_find_by_row_if_header_line_is_not_nil
+    with_each_spreadsheet(name: "numbers1") do |workbook|
+      workbook.header_line = 2
+      refute_nil workbook.header_line
+      results = workbook.find 1
+      assert results
+      assert_equal 5, results[0]
+      assert_equal 6, results[1]
+      results = workbook.find 15
+      assert results
+      assert_equal "einundvierzig", results[0]
+    end
+  end
+
+  def test_find_by_conditions
+    skip_long_test
+    expected_results = [
+      {
+        "VERFASSER" => "Almassy, Annelene von",
+        "INTERNET" => nil,
+        "SEITE" => 316.0,
+        "KENNUNG" => "Aus dem Bibelbund",
+        "OBJEKT" => "Bibel+Gem",
+        "PC" => "#C:\\Bibelbund\\reprint\\BuG1982-3.pdf#",
+        "NUMMER" => "1982-3",
+        "TITEL" => "Brief aus dem Sekretariat"
+      },
+      {
+        "VERFASSER" => "Almassy, Annelene von",
+        "INTERNET" => nil,
+        "SEITE" => 222.0,
+        "KENNUNG" => "Aus dem Bibelbund",
+        "OBJEKT" => "Bibel+Gem",
+        "PC" => "#C:\\Bibelbund\\reprint\\BuG1983-2.pdf#",
+        "NUMMER" => "1983-2",
+        "TITEL" => "Brief aus dem Sekretariat"
+      }
+    ]
+
+    expected_results_size = 2
+    options = { name: "Bibelbund", format: [:openoffice, :excelx] }
+    with_each_spreadsheet(options) do |workbook|
+      results = workbook.find(:all, conditions: { "TITEL" => "Brief aus dem Sekretariat" })
+      assert_equal expected_results_size, results.size
+      assert_equal expected_results, results
+
+      conditions = {
+        "TITEL" => "Brief aus dem Sekretariat",
+        "VERFASSER" => "Almassy, Annelene von"
+      }
+      results = workbook.find(:all, conditions: conditions)
+      assert_equal expected_results, results
+      assert_equal expected_results_size, results.size
+
+      results = workbook.find(:all, conditions: { "VERFASSER" => "Almassy, Annelene von" })
+      assert_equal 13, results.size
+    end
+  end
+
+  def test_find_by_conditions_with_array_option
+    expected_results = [
+      [
+        "Brief aus dem Sekretariat",
+        "Almassy, Annelene von",
+        "Bibel+Gem",
+        "1982-3",
+        316.0,
+        nil,
+        "#C:\\Bibelbund\\reprint\\BuG1982-3.pdf#",
+        "Aus dem Bibelbund",
+      ],
+      [
+        "Brief aus dem Sekretariat",
+        "Almassy, Annelene von",
+        "Bibel+Gem",
+        "1983-2",
+        222.0,
+        nil,
+        "#C:\\Bibelbund\\reprint\\BuG1983-2.pdf#",
+        "Aus dem Bibelbund",
+      ]
+    ]
+    options = { name: "Bibelbund", format: [:openoffice, :excelx] }
+    with_each_spreadsheet(options) do |workbook|
+      conditions = {
+        "TITEL" => "Brief aus dem Sekretariat",
+        "VERFASSER" => "Almassy, Annelene von"
+      }
+      results = workbook.find(:all, conditions: conditions, array: true)
+      assert_equal 2, results.size
+      assert_equal expected_results, results
+    end
+  end
+end

data/test/roo/test_csv.rb

@@ -1,4 +1,4 @@
-require 'test_helper'
+require "test_helper"
 
 class TestRooCSV < Minitest::Test
   def test_sheets
@@ -13,6 +13,34 @@ class TestRooCSV < Minitest::Test
     end
   end
 
+  def test_download_uri_with_query_string
+    file = filename("simple_spreadsheet")
+    port = 12_347
+    url = "#{local_server(port)}/#{file}?query-param=value"
+
+    start_local_server(file, port) do
+      csv = roo_class.new(url)
+      assert_equal "Task 1", csv.cell("f", 4)
+      assert_equal 1, csv.first_row
+      assert_equal 13, csv.last_row
+      assert_equal 1, csv.first_column
+      assert_equal 6, csv.last_column
+    end
+  end
+
+  def test_open_stream
+    file = filename("Bibelbund")
+    file_contents = File.read File.join(TESTDIR, file)
+    stream = StringIO.new(file_contents)
+    csv = roo_class.new(stream)
+
+    assert_equal "Aktuelle Seite", csv.cell("h", 12)
+    assert_equal 1, csv.first_row
+    assert_equal 3735, csv.last_row
+    assert_equal 1, csv.first_column
+    assert_equal 8, csv.last_column
+  end
+
   def test_nil_rows_and_lines_csv
     # x_123
     oo = Roo::CSV.new(File.join(TESTDIR,'Bibelbund.csv'))
@@ -42,6 +70,14 @@ class TestRooCSV < Minitest::Test
     assert_equal headers, parsed[1].keys
   end
 
+  def test_iso_8859_1
+    file = File.open(File.join(TESTDIR, "iso_8859_1.csv"))
+    options = { csv_options: { col_sep: ";", encoding: Encoding::ISO_8859_1 } }
+    workbook = Roo::CSV.new(file.path, options)
+    result = workbook.last_column
+    assert_equal(19, result)
+  end
+
   def roo_class
     Roo::CSV
   end

data/test/roo/test_excelx.rb

@@ -1,9 +1,9 @@
 require "test_helper"
 
-class TestRooExcelx < Minitest::Test
+class TestRworkbookExcelx < Minitest::Test
   def test_download_uri_with_invalid_host
     assert_raises(RuntimeError) do
-      Roo::Excelx.new("http://example.com/file.xlsx")
+      Roo::Excelx.new("http://examples.com/file.xlsx")
     end
   end
 
@@ -20,20 +20,20 @@ class TestRooExcelx < Minitest::Test
 
   def test_should_raise_file_not_found_error
     assert_raises(IOError) do
-      Roo::Excelx.new(File.join("testnichtvorhanden", "Bibelbund.xlsx"))
+      roo_class.new(File.join("testnichtvorhanden", "Bibelbund.xlsx"))
     end
   end
 
   def test_file_warning_default
-    assert_raises(TypeError) { Roo::Excelx.new(File.join(TESTDIR, "numbers1.ods")) }
-    assert_raises(TypeError) { Roo::Excelx.new(File.join(TESTDIR, "numbers1.xls")) }
+    assert_raises(TypeError) { roo_class.new(File.join(TESTDIR, "numbers1.ods")) }
+    assert_raises(TypeError) { roo_class.new(File.join(TESTDIR, "numbers1.xls")) }
   end
 
   def test_file_warning_error
     %w(ods xls).each do |extension|
       assert_raises(TypeError) do
         options = { packed: false, file_warning: :error }
-        Roo::Excelx.new(File.join(TESTDIR, "numbers1. #{extension}"), options)
+        roo_class.new(File.join(TESTDIR, "numbers1. #{extension}"), options)
       end
     end
   end
@@ -41,13 +41,13 @@ class TestRooExcelx < Minitest::Test
   def test_file_warning_warning
     options = { packed: false, file_warning: :warning }
     assert_raises(ArgumentError) do
-      Roo::Excelx.new(File.join(TESTDIR, "numbers1.ods"), options)
+      roo_class.new(File.join(TESTDIR, "numbers1.ods"), options)
     end
   end
 
   def test_file_warning_ignore
     options = { packed: false, file_warning: :ignore }
-    sheet = Roo::Excelx.new(File.join(TESTDIR, "type_excelx.ods"), options)
+    sheet = roo_class.new(File.join(TESTDIR, "type_excelx.ods"), options)
     assert sheet, "Should not throw an error"
   end
 
@@ -66,13 +66,13 @@ class TestRooExcelx < Minitest::Test
     # where the expected result is
     # "A: TestString"
     # "B: TestString"
-    xlsx = Roo::Excelx.new(File.join(TESTDIR, "formula_string_error.xlsx"))
+    xlsx = roo_class.new(File.join(TESTDIR, "formula_string_error.xlsx"))
     assert_equal "Teststring", xlsx.cell("a", 1)
     assert_equal "Teststring", xlsx.cell("a", 2)
   end
 
   def test_parsing_xslx_from_numbers
-    xlsx = Roo::Excelx.new(File.join(TESTDIR, "numbers-export.xlsx"))
+    xlsx = roo_class.new(File.join(TESTDIR, "numbers-export.xlsx"))
 
     xlsx.default_sheet = xlsx.sheets.first
     assert_equal "Sheet 1", xlsx.cell("a", 1)
@@ -100,7 +100,7 @@ class TestRooExcelx < Minitest::Test
 
   def test_expand_merged_range
     options = { expand_merged_ranges: true }
-    xlsx = Roo::Excelx.new(File.join(TESTDIR, "merged_ranges.xlsx"), options)
+    xlsx = roo_class.new(File.join(TESTDIR, "merged_ranges.xlsx"), options)
 
     [
       {
@@ -134,7 +134,7 @@ class TestRooExcelx < Minitest::Test
   end
 
   def test_noexpand_merged_range
-    xlsx = Roo::Excelx.new(File.join(TESTDIR, "merged_ranges.xlsx"))
+    xlsx = roo_class.new(File.join(TESTDIR, "merged_ranges.xlsx"))
 
     [
       {
@@ -171,11 +171,155 @@ class TestRooExcelx < Minitest::Test
     file = filename(:numbers1)
     file_contents = File.read File.join(TESTDIR, file), encoding: "BINARY"
     stream = StringIO.new(file_contents)
-    xlsx = Roo::Excelx.new(stream)
+    xlsx = roo_class.new(stream)
     expected_sheet_names = ["Tabelle1", "Name of Sheet 2", "Sheet3", "Sheet4", "Sheet5"]
     assert_equal expected_sheet_names, xlsx.sheets
   end
 
+  def test_header_offset
+    xlsx = roo_class.new(File.join(TESTDIR, "header_offset.xlsx"))
+    data = xlsx.parse(column_1: "Header A1", column_2: "Header B1")
+    assert_equal "Data A2", data[0][:column_1]
+    assert_equal "Data B2", data[0][:column_2]
+  end
+
+  def test_formula_excelx
+    with_each_spreadsheet(name: "formula", format: :excelx) do |workbook|
+      assert_equal 1, workbook.cell("A", 1)
+      assert_equal 2, workbook.cell("A", 2)
+      assert_equal 3, workbook.cell("A", 3)
+      assert_equal 4, workbook.cell("A", 4)
+      assert_equal 5, workbook.cell("A", 5)
+      assert_equal 6, workbook.cell("A", 6)
+      assert_equal 21, workbook.cell("A", 7)
+      assert_equal :formula, workbook.celltype("A", 7)
+      assert_nil workbook.formula("A", 6)
+
+      expected_result = [
+        [7, 1, "SUM(A1:A6)"],
+        [7, 2, "SUM($A$1:B6)"],
+      ]
+      assert_equal expected_result, workbook.formulas(workbook.sheets.first)
+
+      # setting a cell
+      workbook.set("A", 15, 41)
+      assert_equal 41, workbook.cell("A", 15)
+      workbook.set("A", 16, "41")
+      assert_equal "41", workbook.cell("A", 16)
+      workbook.set("A", 17, 42.5)
+      assert_equal 42.5, workbook.cell("A", 17)
+    end
+  end
+
+  # TODO: temporaerer Test
+  def test_seiten_als_date
+    skip_long_test
+
+    with_each_spreadsheet(name: "Bibelbund", format: :excelx) do |workbook|
+      assert_equal "Bericht aus dem Sekretariat", workbook.cell(13, 1)
+      assert_equal "1981-4", workbook.cell(13, "D")
+      assert_equal String, workbook.excelx_type(13, "E")[1].class
+      assert_equal [:numeric_or_formula, "General"], workbook.excelx_type(13, "E")
+      assert_equal "428", workbook.excelx_value(13, "E")
+      assert_equal 428.0, workbook.cell(13, "E")
+    end
+  end
+
+  def test_bug_simple_spreadsheet_time_bug
+    # really a bug? are cells really of type time?
+    # No! :float must be the correct type
+    with_each_spreadsheet(name: "simple_spreadsheet", format: :excelx) do |workbook|
+      # puts workbook.cell("B", 5).to_s
+      # assert_equal :time, workbook.celltype("B", 5)
+      assert_equal :float, workbook.celltype("B", 5)
+      assert_equal 10.75, workbook.cell("B", 5)
+      assert_equal 12.50, workbook.cell("C", 5)
+      assert_equal 0, workbook.cell("D", 5)
+      assert_equal 1.75, workbook.cell("E", 5)
+      assert_equal "Task 1", workbook.cell("F", 5)
+      assert_equal Date.new(2007, 5, 7), workbook.cell("A", 5)
+    end
+  end
+
+  def test_simple2_excelx
+    with_each_spreadsheet(name: "simple_spreadsheet", format: :excelx) do |workbook|
+      assert_equal [:numeric_or_formula, "yyyy\\-mm\\-dd"], workbook.excelx_type("A", 4)
+      assert_equal [:numeric_or_formula, "#,##0.00"], workbook.excelx_type("B", 4)
+      assert_equal [:numeric_or_formula, "#,##0.00"], workbook.excelx_type("c", 4)
+      assert_equal [:numeric_or_formula, "General"], workbook.excelx_type("d", 4)
+      assert_equal [:numeric_or_formula, "General"], workbook.excelx_type("e", 4)
+      assert_equal :string, workbook.excelx_type("f", 4)
+
+      assert_equal "39209", workbook.excelx_value("a", 4)
+      assert_equal "yyyy\\-mm\\-dd", workbook.excelx_format("a", 4)
+      assert_equal "9.25", workbook.excelx_value("b", 4)
+      assert_equal "10.25", workbook.excelx_value("c", 4)
+      assert_equal "0", workbook.excelx_value("d", 4)
+      # ... Sum-Spalte
+      # assert_equal "Task 1", workbook.excelx_value("f", 4)
+      assert_equal "Task 1", workbook.cell("f", 4)
+      assert_equal Date.new(2007, 05, 07), workbook.cell("a", 4)
+      assert_equal "9.25", workbook.excelx_value("b", 4)
+      assert_equal "#,##0.00", workbook.excelx_format("b", 4)
+      assert_equal 9.25, workbook.cell("b", 4)
+      assert_equal :float, workbook.celltype("b", 4)
+      assert_equal :float, workbook.celltype("d", 4)
+      assert_equal 0, workbook.cell("d", 4)
+      assert_equal :formula, workbook.celltype("e", 4)
+      assert_equal 1, workbook.cell("e", 4)
+      assert_equal "C4-B4-D4", workbook.formula("e", 4)
+      assert_equal :string, workbook.celltype("f", 4)
+      assert_equal "Task 1", workbook.cell("f", 4)
+    end
+  end
+
+  def test_bug_pfand_from_windows_phone_xlsx
+    # skip_jruby_incompatible_test
+    # TODO: Does JRUBY need to skip this test
+    return if defined? JRUBY_VERSION
+
+    options = { name: "Pfand_from_windows_phone", format: :excelx }
+    with_each_spreadsheet(options) do |workbook|
+      workbook.default_sheet = workbook.sheets.first
+      assert_equal ["Blatt1", "Blatt2", "Blatt3"], workbook.sheets
+      assert_equal "Summe", workbook.cell("b", 1)
+
+      assert_equal Date.new(2011, 9, 14), workbook.cell("a", 2)
+      assert_equal :date, workbook.celltype("a", 2)
+      assert_equal Date.new(2011, 9, 15), workbook.cell("a", 3)
+      assert_equal :date, workbook.celltype("a", 3)
+
+      assert_equal 3.81, workbook.cell("b", 2)
+      assert_equal "SUM(C2:L2)", workbook.formula("b", 2)
+      assert_equal 0.7, workbook.cell("c", 2)
+    end # each
+  end
+
+  def test_excelx_links
+    with_each_spreadsheet(name: "link", format: :excelx) do |workbook|
+      assert_equal "Google", workbook.cell(1, 1)
+      assert_equal "http://www.google.com", workbook.cell(1, 1).href
+    end
+  end
+
+  def test_handles_link_without_hyperlink
+    workbook = Roo::Spreadsheet.open(File.join(TESTDIR, "bad_link.xlsx"))
+    assert_equal "Test", workbook.cell(1, 1)
+  end
+
+  # Excel has two base date formats one from 1900 and the other from 1904.
+  # see #test_base_dates_in_excel
+  def test_base_dates_in_excelx
+    with_each_spreadsheet(name: "1900_base", format: :excelx) do |workbook|
+      assert_equal Date.new(2009, 06, 15), workbook.cell(1, 1)
+      assert_equal :date, workbook.celltype(1, 1)
+    end
+    with_each_spreadsheet(name: "1904_base", format: :excelx) do |workbook|
+      assert_equal Date.new(2009, 06, 15), workbook.cell(1, 1)
+      assert_equal :date, workbook.celltype(1, 1)
+    end
+  end
+
   def roo_class
     Roo::Excelx
   end