roo 2.7.0 → 2.8.3

data/lib/roo/excelx/cell/number.rb

@@ -1,16 +1,19 @@
+# frozen_string_literal: true
+
 module Roo
   class Excelx
     class Cell
       class Number < Cell::Base
-        attr_reader :value, :formula, :format, :cell_value, :link, :coordinate
+        attr_reader :value, :formula, :format, :cell_value, :coordinate
+
+        # FIXME: change default_type to number. This will break brittle tests.
+        attr_reader_with_default default_type: :float
 
         def initialize(value, formula, excelx_type, style, link, coordinate)
           super
-          # FIXME: change @type to number. This will break brittle tests.
           # FIXME: Excelx_type is an array, but the first value isn't used.
-          @type = :float
           @format = excelx_type.last
-          @value = link? ? Roo::Link.new(link, value) : create_numeric(value)
+          @value = link ? Roo::Link.new(link, value) : create_numeric(value)
         end
 
         def create_numeric(number)
@@ -21,48 +24,50 @@ module Roo
           when /\.0/
             Float(number)
           else
-            (number.include?('.') || (/\A[-+]?\d+E[-+]\d+\z/i =~ number)) ? Float(number) : Integer(number)
+            (number.include?('.') || (/\A[-+]?\d+E[-+]?\d+\z/i =~ number)) ? Float(number) : Integer(number, 10)
           end
         end
 
         def formatted_value
           return @cell_value if Excelx::ERROR_VALUES.include?(@cell_value)
 
-          formatter = formats[@format]
+          formatter = generate_formatter(@format)
           if formatter.is_a? Proc
             formatter.call(@cell_value)
-          elsif zero_padded_number?
-            "%0#{@format.size}d" % @cell_value
           else
             Kernel.format(formatter, @cell_value)
           end
         end
 
-        def formats
+        def generate_formatter(format)
           # FIXME: numbers can be other colors besides red:
           # [BLACK], [BLUE], [CYAN], [GREEN], [MAGENTA], [RED], [WHITE], [YELLOW], [COLOR n]
-          {
-            'General' => '%.0f',
-            '0' => '%.0f',
-            '0.00' => '%.2f',
-            '0.000000' => '%.6f',
-            '#,##0' => number_format('%.0f'),
-            '#,##0.00' => number_format('%.2f'),
-            '0%' =>  proc do |number|
-              Kernel.format('%d%', number.to_f * 100)
-            end,
-            '0.00%' => proc do |number|
-              Kernel.format('%.2f%', number.to_f * 100)
-            end,
-            '0.00E+00' => '%.2E',
-            '#,##0 ;(#,##0)' => number_format('%.0f', '(%.0f)'),
-            '#,##0 ;[Red](#,##0)' => number_format('%.0f', '[Red](%.0f)'),
-            '#,##0.00;(#,##0.00)' => number_format('%.2f', '(%.2f)'),
-            '#,##0.00;[Red](#,##0.00)' => number_format('%.2f', '[Red](%.2f)'),
+          case format
+          when /^General$/i then '%.0f'
+          when '0' then '%.0f'
+          when /^(0+)$/ then "%0#{$1.size}d"
+          when /^0\.(0+)$/ then "%.#{$1.size}f"
+          when '#,##0' then number_format('%.0f')
+          when '#,##0.00' then number_format('%.2f')
+          when '0%'
+            proc do |number|
+              Kernel.format('%d%%', number.to_f * 100)
+            end
+          when '0.00%'
+            proc do |number|
+              Kernel.format('%.2f%%', number.to_f * 100)
+            end
+          when '0.00E+00' then '%.2E'
+          when '#,##0 ;(#,##0)' then number_format('%.0f', '(%.0f)')
+          when '#,##0 ;[Red](#,##0)' then number_format('%.0f', '[Red](%.0f)')
+          when '#,##0.00;(#,##0.00)' then number_format('%.2f', '(%.2f)')
+          when '#,##0.00;[Red](#,##0.00)' then number_format('%.2f', '[Red](%.2f)')
             # FIXME: not quite sure what the format should look like in this case.
-            '##0.0E+0' => '%.1E',
-            '@' => proc { |number| number }
-          }
+          when '##0.0E+0' then '%.1E'
+          when '@' then proc { |number| number }
+          else
+            raise "Unknown format: #{format.inspect}"
+          end
         end
 
         private
@@ -77,10 +82,6 @@ module Roo
             Kernel.format(formatter, number).reverse.gsub(/(\d{3})(?=\d)/, '\\1,').reverse
           end
         end
-
-        def zero_padded_number?
-          @format[/0+/] == @format
-        end
       end
     end
   end

data/lib/roo/excelx/cell/string.rb

@@ -2,12 +2,12 @@ module Roo
   class Excelx
     class Cell
       class String < Cell::Base
-        attr_reader :value, :formula, :format, :cell_type, :cell_value, :link, :coordinate
+        attr_reader :value, :formula, :format, :cell_value, :coordinate
+
+        attr_reader_with_default default_type: :string, cell_type: :string
 
         def initialize(value, formula, style, link, coordinate)
           super(value, formula, nil, style, link, coordinate)
-          @type = @cell_type = :string
-          @value = link? ? Roo::Link.new(link, value) : value
         end
 
         def empty?

data/lib/roo/excelx/cell/time.rb

@@ -4,15 +4,16 @@ module Roo
   class Excelx
     class Cell
       class Time < Roo::Excelx::Cell::DateTime
-        attr_reader :value, :formula, :format, :cell_value, :link, :coordinate
+        attr_reader :value, :formula, :format, :cell_value, :coordinate
+
+        attr_reader_with_default default_type: :time
 
         def initialize(value, formula, excelx_type, style, link, base_date, coordinate)
           # NOTE: Pass all arguments to DateTime super class.
           super
-          @type = :time
           @format = excelx_type.last
           @datetime = create_datetime(base_date, value)
-          @value = link? ? Roo::Link.new(link, value) : (value.to_f * 86_400).to_i
+          @value = link ? Roo::Link.new(link, value) : (value.to_f * 86_400).to_i
         end
 
         def formatted_value

data/lib/roo/excelx/cell.rb

@@ -40,19 +40,23 @@ module Roo
       end
 
       def self.create_cell(type, *values)
+        cell_class(type)&.new(*values)
+      end
+
+      def self.cell_class(type)
         case type
         when :string
-          Cell::String.new(*values)
+          Cell::String
         when :boolean
-          Cell::Boolean.new(*values)
+          Cell::Boolean
         when :number
-          Cell::Number.new(*values)
+          Cell::Number
         when :date
-          Cell::Date.new(*values)
+          Cell::Date
         when :datetime
-          Cell::DateTime.new(*values)
+          Cell::DateTime
         when :time
-          Cell::Time.new(*values)
+          Cell::Time
         end
       end
 

data/lib/roo/excelx/comments.rb

@@ -12,10 +12,10 @@ module Roo
       def extract_comments
         return {} unless doc_exists?
 
-        Hash[doc.xpath('//comments/commentList/comment').map do |comment|
+        doc.xpath('//comments/commentList/comment').each_with_object({}) do |comment, hash|
           value = (comment.at_xpath('./text/r/t') || comment.at_xpath('./text/t')).text
-          [::Roo::Utils.ref_to_key(comment.attributes['ref'].to_s), value]
-        end]
+          hash[::Roo::Utils.ref_to_key(comment['ref'].to_s)] = value
+        end
       end
     end
   end

data/lib/roo/excelx/coordinate.rb

@@ -1,11 +1,18 @@
 module Roo
   class Excelx
-    class Coordinate
-      attr_accessor :row, :column
+    class Coordinate < ::Array
 
       def initialize(row, column)
-        @row = row
-        @column = column
+        super() << row << column
+        freeze
+      end
+
+      def row
+        self[0]
+      end
+
+      def column
+        self[1]
       end
     end
   end

data/lib/roo/excelx/extractor.rb

@@ -1,16 +1,34 @@
+# frozen_string_literal: true
+
+require "roo/helpers/weak_instance_cache"
+
 module Roo
   class Excelx
     class Extractor
-      def initialize(path)
+      include Roo::Helpers::WeakInstanceCache
+
+      COMMON_STRINGS = {
+        t: "t",
+        r: "r",
+        s: "s",
+        ref: "ref",
+        html_tag_open: "<html>",
+        html_tag_closed: "</html>"
+      }
+
+      def initialize(path, options = {})
         @path = path
+        @options = options
       end
 
       private
 
       def doc
-        raise FileNotFound, "#{@path} file not found" unless doc_exists?
+        instance_cache(:@doc) do
+          raise FileNotFound, "#{@path} file not found" unless doc_exists?
 
-        ::Roo::Utils.load_xml(@path).remove_namespaces!
+          ::Roo::Utils.load_xml(@path).remove_namespaces!
+        end
       end
 
       def doc_exists?

data/lib/roo/excelx/format.rb

@@ -1,49 +1,57 @@
+# frozen_string_literal: true
+
 module Roo
   class Excelx
     module Format
+      extend self
       EXCEPTIONAL_FORMATS = {
         'h:mm am/pm' => :date,
         'h:mm:ss am/pm' => :date
       }
 
       STANDARD_FORMATS = {
-        0 => 'General'.freeze,
-        1 => '0'.freeze,
-        2 => '0.00'.freeze,
-        3 => '#,##0'.freeze,
-        4 => '#,##0.00'.freeze,
-        9 => '0%'.freeze,
-        10 => '0.00%'.freeze,
-        11 => '0.00E+00'.freeze,
-        12 => '# ?/?'.freeze,
-        13 => '# ??/??'.freeze,
-        14 => 'mm-dd-yy'.freeze,
-        15 => 'd-mmm-yy'.freeze,
-        16 => 'd-mmm'.freeze,
-        17 => 'mmm-yy'.freeze,
-        18 => 'h:mm AM/PM'.freeze,
-        19 => 'h:mm:ss AM/PM'.freeze,
-        20 => 'h:mm'.freeze,
-        21 => 'h:mm:ss'.freeze,
-        22 => 'm/d/yy h:mm'.freeze,
-        37 => '#,##0 ;(#,##0)'.freeze,
-        38 => '#,##0 ;[Red](#,##0)'.freeze,
-        39 => '#,##0.00;(#,##0.00)'.freeze,
-        40 => '#,##0.00;[Red](#,##0.00)'.freeze,
-        45 => 'mm:ss'.freeze,
-        46 => '[h]:mm:ss'.freeze,
-        47 => 'mmss.0'.freeze,
-        48 => '##0.0E+0'.freeze,
-        49 => '@'.freeze
+        0 => 'General',
+        1 => '0',
+        2 => '0.00',
+        3 => '#,##0',
+        4 => '#,##0.00',
+        9 => '0%',
+        10 => '0.00%',
+        11 => '0.00E+00',
+        12 => '# ?/?',
+        13 => '# ??/??',
+        14 => 'mm-dd-yy',
+        15 => 'd-mmm-yy',
+        16 => 'd-mmm',
+        17 => 'mmm-yy',
+        18 => 'h:mm AM/PM',
+        19 => 'h:mm:ss AM/PM',
+        20 => 'h:mm',
+        21 => 'h:mm:ss',
+        22 => 'm/d/yy h:mm',
+        37 => '#,##0 ;(#,##0)',
+        38 => '#,##0 ;[Red](#,##0)',
+        39 => '#,##0.00;(#,##0.00)',
+        40 => '#,##0.00;[Red](#,##0.00)',
+        45 => 'mm:ss',
+        46 => '[h]:mm:ss',
+        47 => 'mmss.0',
+        48 => '##0.0E+0',
+        49 => '@'
       }
 
       def to_type(format)
+        @to_type ||= {}
+        @to_type[format] ||= _to_type(format)
+      end
+
+      def _to_type(format)
         format = format.to_s.downcase
         if (type = EXCEPTIONAL_FORMATS[format])
           type
         elsif format.include?('#')
           :float
-        elsif !format.match(/d+(?![\]])/).nil? || format.include?('y')
+        elsif format.include?('y') || !format.match(/d+(?![\]])/).nil?
           if format.include?('h') || format.include?('s')
             :datetime
           else
@@ -58,7 +66,6 @@ module Roo
         end
       end
 
-      module_function :to_type
     end
-  end 
+  end
 end

data/lib/roo/excelx/images.rb

@@ -0,0 +1,26 @@
+require 'roo/excelx/extractor'
+
+module Roo
+  class Excelx
+    class Images < Excelx::Extractor
+
+      # Returns: Hash { id1: extracted_file_name1 },
+      # Example: { "rId1"=>"roo_media_image1.png",
+      #            "rId2"=>"roo_media_image2.png",
+      #            "rId3"=>"roo_media_image3.png" }
+      def list
+        @images ||= extract_images_names
+      end
+
+      private
+
+      def extract_images_names
+        return {} unless doc_exists?
+
+        doc.xpath('/Relationships/Relationship').each_with_object({}) do |rel, hash|
+          hash[rel['Id']] = "roo" + rel['Target'].gsub(/\.\.\/|\//, '_')
+        end
+      end
+    end
+  end
+end

data/lib/roo/excelx/relationships.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'roo/excelx/extractor'
 
 module Roo
@@ -11,14 +13,20 @@ module Roo
         @relationships ||= extract_relationships
       end
 
+      def include_type?(type)
+        to_a.any? do |_, rel|
+          rel["Type"]&.include? type
+        end
+      end
+
       private
 
       def extract_relationships
-        return [] unless doc_exists?
+        return {} unless doc_exists?
 
-        Hash[doc.xpath('/Relationships/Relationship').map do |rel|
-          [rel.attribute('Id').text, rel]
-        end]
+        doc.xpath('/Relationships/Relationship').each_with_object({}) do |rel, hash|
+          hash[rel['Id']] = rel
+        end
       end
     end
   end

data/lib/roo/excelx/shared.rb

@@ -4,12 +4,15 @@ module Roo
     #          reduce memory usage and reduce the number of objects being passed
     #          to various inititializers.
     class Shared
-      attr_accessor :comments_files, :sheet_files, :rels_files
-      def initialize(dir)
+      attr_accessor :comments_files, :sheet_files, :rels_files, :image_rels, :image_files
+      def initialize(dir, options = {})
         @dir = dir
         @comments_files = []
         @sheet_files = []
         @rels_files = []
+        @options = options
+        @image_rels = []
+        @image_files = []
       end
 
       def styles
@@ -17,7 +20,7 @@ module Roo
       end
 
       def shared_strings
-        @shared_strings ||= SharedStrings.new(File.join(@dir, 'roo_sharedStrings.xml'))
+        @shared_strings ||= SharedStrings.new(File.join(@dir, 'roo_sharedStrings.xml'), @options)
       end
 
       def workbook
@@ -27,6 +30,10 @@ module Roo
       def base_date
         workbook.base_date
       end
+
+      def base_timestamp
+        workbook.base_timestamp
+      end
     end
   end
 end

data/lib/roo/excelx/shared_strings.rb

@@ -1,16 +1,10 @@
+# frozen_string_literal: true
+
 require 'roo/excelx/extractor'
 
 module Roo
   class Excelx
     class SharedStrings < Excelx::Extractor
-
-      COMMON_STRINGS = {
-        t: "t",
-        r: "r",
-        html_tag_open: "<html>",
-        html_tag_closed: "</html>"
-      }
-
       def [](index)
         to_a[index]
       end
@@ -26,6 +20,7 @@ module Roo
       # Use to_html or to_a for html returns
       # See what is happening with commit???
       def use_html?(index)
+        return false if @options[:disable_html_wrapper]
         to_html[index][/<([biu]|sup|sub)>/]
       end
 
@@ -45,7 +40,7 @@ module Roo
         document = fix_invalid_shared_strings(doc)
         # read the shared strings xml document
         document.xpath('/sst/si').map do |si|
-          shared_string = ''
+          shared_string = +""
           si.children.each do |elem|
             case elem.name
             when 'r'
@@ -65,7 +60,7 @@ module Roo
         fix_invalid_shared_strings(doc)
         # read the shared strings xml document
         doc.xpath('/sst/si').map do |si|
-          html_string = '<html>'
+          html_string = '<html>'.dup
           si.children.each do |elem|
             case elem.name
             when 'r'
@@ -95,7 +90,7 @@ module Roo
       #
       # Expected Output ::: "<html><sub|sup><b><i><u>TEXT</u></i></b></sub|/sup></html>"
       def extract_html_r(r_elem)
-        str = ''
+        str = +""
         xml_elems = {
           sub: false,
           sup: false,
@@ -103,7 +98,6 @@ module Roo
           i:   false,
           u:   false
         }
-        b, i, u, sub, sup = false, false, false, false, false
         r_elem.children.each do |elem|
           case elem.name
           when 'rPr'
@@ -141,13 +135,13 @@ module Roo
 
       # This will return an html string
       def create_html(text, formatting)
-        tmp_str = ''
+        tmp_str = +""
         formatting.each do |elem, val|
           tmp_str << "<#{elem}>" if val
         end
         tmp_str << text
-        reverse_format = Hash[formatting.to_a.reverse]
-        reverse_format.each do |elem, val|
+
+        formatting.reverse_each do |elem, val|
           tmp_str << "</#{elem}>" if val
         end
         tmp_str

data/lib/roo/excelx/sheet.rb

@@ -4,11 +4,15 @@ module Roo
     class Sheet
       extend Forwardable
 
-      delegate [:styles, :workbook, :shared_strings, :rels_files, :sheet_files, :comments_files] => :@shared
+      delegate [:styles, :workbook, :shared_strings, :rels_files, :sheet_files, :comments_files, :image_rels] => :@shared
+
+      attr_reader :images
 
       def initialize(name, shared, sheet_index, options = {})
         @name = name
         @shared = shared
+        @sheet_index = sheet_index
+        @images = Images.new(image_rels[sheet_index]).list
         @rels = Relationships.new(rels_files[sheet_index])
         @comments = Comments.new(comments_files[sheet_index])
         @sheet = SheetDoc.new(sheet_files[sheet_index], @rels, shared, options)
@@ -19,7 +23,14 @@ module Roo
       end
 
       def present_cells
-        @present_cells ||= cells.select { |_, cell| cell && !cell.empty? }
+        @present_cells ||= begin
+          warn %{
+[DEPRECATION] present_cells is deprecated. Alternate:
+  with activesupport    => cells[key].presence
+  without activesupport => cells[key]&.presence
+          }
+          cells.select { |_, cell| cell&.presence }
+        end
       end
 
       # Yield each row as array of Excelx::Cell objects
@@ -39,33 +50,33 @@ module Roo
 
       def row(row_number)
         first_column.upto(last_column).map do |col|
-          cells[[row_number, col]]
-        end.map { |cell| cell && cell.value }
+          cells[[row_number, col]]&.value
+        end
       end
 
       def column(col_number)
         first_row.upto(last_row).map do |row|
-          cells[[row, col_number]]
-        end.map { |cell| cell && cell.value }
+          cells[[row, col_number]]&.value
+        end
       end
 
       # returns the number of the first non-empty row
       def first_row
-        @first_row ||= present_cells.keys.map { |row, _| row }.min
+        @first_row ||= first_last_row_col[:first_row]
       end
 
       def last_row
-        @last_row ||= present_cells.keys.map { |row, _| row }.max
+        @last_row ||= first_last_row_col[:last_row]
       end
 
       # returns the number of the first non-empty column
       def first_column
-        @first_column ||= present_cells.keys.map { |_, col| col }.min
+        @first_column ||= first_last_row_col[:first_column]
       end
 
       # returns the number of the last non-empty column
       def last_column
-        @last_column ||= present_cells.keys.map { |_, col| col }.max
+        @last_column ||= first_last_row_col[:last_column]
       end
 
       def excelx_format(key)
@@ -107,6 +118,34 @@ module Roo
         (cell.coordinate.column - 1 - last_column).times { pad << nil }
         pad
       end
+
+      def first_last_row_col
+        @first_last_row_col ||= begin
+          first_row = last_row = first_col = last_col = nil
+
+          cells.each do |(row, col), cell|
+            next unless cell&.presence
+            first_row ||= row
+            last_row ||= row
+            first_col ||= col
+            last_col ||= col
+
+            if row > last_row
+              last_row = row
+            elsif row < first_row
+              first_row = row
+            end
+
+            if col > last_col
+              last_col = col
+            elsif col < first_col
+              first_col = col
+            end
+          end
+
+          {first_row: first_row, last_row: last_row, first_column: first_col, last_column: last_col}
+        end
+      end
     end
   end
 end