rocketjob_mission_control 4.3.0 → 5.0.0.beta1

data/test/controllers/rocket_job_mission_control/servers_controller_test.rb

@@ -1,10 +1,9 @@
-require_relative '../../test_helper'
-require_relative '../../compare_hashes'
+require_relative "../../test_helper"
+require_relative "../../compare_hashes"
 
 module RocketJobMissionControl
   class ServersControllerTest < ActionController::TestCase
     describe ServersController do
-
       before do
         set_role(:admin)
         RocketJob::Job.delete_all
@@ -27,137 +26,106 @@ module RocketJobMissionControl
         end
       end
 
-      [:stop, :pause, :resume].each do |server_action|
+      %i[stop pause resume].each do |server_action|
         describe "PATCH ##{server_action}" do
-          describe 'with a valid server id' do
+          describe "with a valid server id" do
             before do
               server.pause! if server_action == :resume
-              params = {id: server.id}
-              params = {params: params} if Rails.version.to_i >= 5
-              patch server_action, params
             end
 
-            it 'redirects to servers' do
+            it "redirects to servers" do
+              patch server_action, params: {id: server.id}
               assert_redirected_to servers_path
             end
 
             it "#{server_action} the server" do
-              results = {stop: :stopping?, pause: :paused?, resume: :running?}
-              assert server.reload.send(results[server_action])
-            end
-          end
-
-          describe "when the server fails to #{server_action}" do
-            before do
-              server.pause! if server_action == :pause
-              server.stop! if server_action == :stop
-              params = {id: server.id}
-              params = {params: params} if Rails.version.to_i >= 5
-              patch server_action, params
-            end
-
-            it 'redirects to servers' do
-              assert_redirected_to servers_path
-            end
-
-            it 'displays a flash message' do
-              assert_equal I18n.t(:failure, scope: [:server, server_action]), flash[:alert]
+              action = server_id = nil
+              RocketJob::Subscribers::Server.stub(:publish, lambda { |_action, args|
+                                                              action = _action
+                                                              server_id = args[:server_id]
+                                                            }) do
+                patch server_action, params: {id: server.id}
+              end
+              assert_equal server_action, action
+              assert_equal server.id, server_id
             end
           end
         end
       end
 
-      describe 'PATCH #update_all' do
-        RocketJobMissionControl::ServersController::VALID_ACTIONS.each do |server_action, action_message|
+      describe "PATCH #update_all" do
+        RocketJobMissionControl::ServersController::VALID_ACTIONS.each do |server_action, _action_message|
           describe "with '#{server_action}' as the server_action param" do
             before do
-              params = {server_action: server_action}
-              params = {params: params} if Rails.version.to_i >= 5
-              patch :update_all, params
+              patch :update_all, params: {server_action: server_action}
             end
 
-            it 'redirects to servers' do
+            it "redirects to servers" do
               assert_redirected_to servers_path
             end
 
-            it 'does not display an error message' do
+            it "does not display an error message" do
               assert_nil flash[:alert]
             end
           end
         end
 
-        describe 'with an invalid server_action param' do
-          before do
-            params = {server_action: :bad_server_action}
-            params = {params: params} if Rails.version.to_i >= 5
-            patch :update_all, params
-          end
-
-          it 'redirects to servers' do
-            assert_redirected_to servers_path
-          end
-
-          it "does not display a success message" do
-            assert_nil flash[:notice]
-          end
-
-          it 'displays an error message' do
-            assert_equal I18n.t(:invalid, scope: [:server, :update_all]), flash[:alert]
+        describe "with an invalid server_action param" do
+          it "gets access denied" do
+            assert_raises(AccessGranted::AccessDenied) do
+              patch :update_all, params: {server_action: :bad_server_action}
+            end
           end
         end
       end
 
-      describe 'DELETE #destroy' do
-        describe 'with a valid server id' do
+      describe "DELETE #destroy" do
+        describe "with a valid server id" do
           before do
-            params = {id: server.id}
-            params = {params: params} if Rails.version.to_i >= 5
-            delete :destroy, params
+            delete :destroy, params: {id: server.id}
           end
 
-          it 'redirects to servers' do
+          it "redirects to servers" do
             assert_redirected_to servers_path
           end
 
-          it 'displays a flash message' do
-            assert_equal I18n.t(:success, scope: [:server, :destroy]), flash[:notice]
+          it "displays a flash message" do
+            assert_equal I18n.t(:success, scope: %i[server destroy]), flash[:notice]
           end
 
-          it 'destroys the server' do
+          it "destroys the server" do
             refute RocketJob::Server.where(id: server.id).exists?
           end
         end
 
-        describe 'when the server is not found' do
+        describe "when the server is not found" do
           before do
-            params = {id: 999999}
-            params = {params: params} if Rails.version.to_i >= 5
-            delete :destroy, params
+            delete :destroy, params: {id: 999_999}
           end
 
-          it 'redirects to servers' do
+          it "redirects to servers" do
             assert_redirected_to servers_path
           end
 
-          it 'displays a flash message' do
-            assert_equal I18n.t(:failure, scope: [:server, :find], id: 999999), flash[:alert]
+          it "displays a flash message" do
+            assert_equal I18n.t(:failure, scope: %i[server find], id: 999_999), flash[:alert]
           end
         end
       end
 
       ([:index] + server_states).each do |state|
         describe "GET ##{state}" do
-          describe 'html' do
+          describe "html" do
             describe "with no #{state} servers" do
               before do
                 get state
               end
 
-              it 'succeeds' do
+              it "succeeds" do
                 assert_response :success
               end
 
-              it 'renders template' do
+              it "renders template" do
                 assert_template :index
               end
             end
@@ -168,23 +136,23 @@ module RocketJobMissionControl
                 get state
               end
 
-              it 'succeeds' do
+              it "succeeds" do
                 assert_response :success
               end
 
-              it 'renders template' do
+              it "renders template" do
                 assert_template :index
               end
             end
           end
 
-          describe 'json' do
+          describe "json" do
             describe "with no #{state} server" do
               before do
                 get state, format: :json
               end
 
-              it 'succeeds' do
+              it "succeeds" do
                 assert_response :success
                 json     = JSON.parse(response.body)
                 expected = {
@@ -203,7 +171,7 @@ module RocketJobMissionControl
                 get state, format: :json
               end
 
-              it 'succeeds' do
+              it "succeeds" do
                 assert_response :success
                 json          = JSON.parse(response.body)
                 expected_data = {
@@ -212,7 +180,7 @@ module RocketJobMissionControl
                     "1"           => "0/10",
                     "2"           => /s ago/,
                     "3"           => /s ago/,
-                    "4"           => /\/servers\/#{RocketJob::Server.starting.first.id}\/stop/,
+                    "4"           => %r{/servers/#{RocketJob::Server.starting.first.id}/stop},
                     "DT_RowClass" => "card callout callout-info"
                   },
                   running:  {
@@ -220,7 +188,7 @@ module RocketJobMissionControl
                     "1"           => "0/10",
                     "2"           => /s ago/,
                     "3"           => /s ago/,
-                    "4"           => /\/servers\/#{RocketJob::Server.running.first.id}\/stop/,
+                    "4"           => %r{/servers/#{RocketJob::Server.running.first.id}/stop},
                     "DT_RowClass" => "card callout callout-success"
                   },
                   paused:   {
@@ -228,7 +196,7 @@ module RocketJobMissionControl
                     "1"           => "0/10",
                     "2"           => /s ago/,
                     "3"           => /s ago/,
-                    "4"           => /\/servers\/#{RocketJob::Server.paused.first.id}\/stop/,
+                    "4"           => %r{/servers/#{RocketJob::Server.paused.first.id}/stop},
                     "DT_RowClass" => "card callout callout-warning"
                   },
                   stopping: {
@@ -236,30 +204,29 @@ module RocketJobMissionControl
                     "1"           => "0/10",
                     "2"           => /s ago/,
                     "3"           => /s ago/,
-                    "4"           => /\/servers\/#{RocketJob::Server.stopping.first.id}/,
+                    "4"           => %r{/servers/#{RocketJob::Server.stopping.first.id}},
                     "DT_RowClass" => "card callout callout-alert"
                   }
                 }
 
                 if state == :index
-                  assert_equal 0, json['draw']
-                  assert_equal 4, json['recordsTotal']
-                  assert_equal 4, json['recordsFiltered']
-                  compare_array_of_hashes [expected_data[:starting], expected_data[:running], expected_data[:paused], expected_data[:stopping]], json['data']
+                  assert_equal 0, json["draw"]
+                  assert_equal 4, json["recordsTotal"]
+                  assert_equal 4, json["recordsFiltered"]
+                  compare_array_of_hashes [expected_data[:starting], expected_data[:running], expected_data[:paused], expected_data[:stopping]], json["data"]
                 else
-                  assert_equal 0, json['draw']
-                  assert_equal 1, json['recordsTotal']
-                  assert_equal 1, json['recordsFiltered']
-                  compare_hash expected_data[state], json['data'].first
+                  assert_equal 0, json["draw"]
+                  assert_equal 1, json["recordsTotal"]
+                  assert_equal 1, json["recordsFiltered"]
+                  compare_hash expected_data[state], json["data"].first
                 end
               end
             end
           end
-
         end
       end
 
-      describe 'role base authentication control' do
+      describe "role base authentication control" do
         %i[index starting running paused stopping zombie].each do |method|
           it "#{method} has read access as default" do
             get method, format: :json
@@ -268,17 +235,15 @@ module RocketJobMissionControl
         end
 
         %i[stop pause resume destroy].each do |method|
-          describe "#{method}" do
+          describe method.to_s do
             before do
               server.pause! if method == :resume
-              @params = {id: server.id}
-              @params = {params: @params} if Rails.version.to_i >= 5
             end
 
             %i[admin editor operator].each do |role|
               it "redirects with #{method} method and role #{role}" do
                 set_role(role)
-                patch method, @params
+                patch method, params: {id: server.id}
                 assert_response(:redirect)
               end
             end
@@ -287,7 +252,7 @@ module RocketJobMissionControl
               it "raises authentication error for #{role}" do
                 set_role(role)
                 assert_raises AccessGranted::AccessDenied do
-                  patch method, @params
+                  patch method, params: {id: server.id}
                 end
               end
             end
@@ -297,11 +262,9 @@ module RocketJobMissionControl
         RocketJobMissionControl::ServersController::VALID_ACTIONS.each do |server_action|
           describe "with '#{server_action}' as the server_action param" do
             %i[admin editor operator].each do |role|
-              it 'redirects to servers' do
+              it "redirects to servers" do
                 set_role(role)
-                params = {server_action: server_action}
-                params = {params: params} if Rails.version.to_i >= 5
-                patch :update_all, params
+                patch :update_all, params: {server_action: server_action}
 
                 assert_response(:redirect)
               end
@@ -312,9 +275,9 @@ module RocketJobMissionControl
     end
 
     def set_role(r)
-      Config.authorization_callback = -> do
+      Config.authorization_callback = lambda {
         {roles: [r]}
-      end
+      }
     end
   end
-end
+end

data/test/helpers/rocket_job_mission_control/application_helper_test.rb

@@ -1,41 +1,40 @@
-require_relative '../../test_helper'
+require_relative "../../test_helper"
 
 module RocketJobMissionControl
   class ApplicationHelperTest < ActionView::TestCase
     describe ApplicationHelper do
-
-      describe '#state_icon' do
+      describe "#state_icon" do
         RocketJobMissionControl::ApplicationHelper::STATE_ICON_MAP.each do |state, expected_class|
           describe "when the job state is #{state}" do
-            it 'returns the correct class' do
+            it "returns the correct class" do
               assert_equal "#{expected_class} #{state}", state_icon(state)
             end
           end
         end
       end
 
-      describe '#pretty_print_array_or_hash' do
+      describe "#pretty_print_array_or_hash" do
         let(:arguments) { [42, "muad'dib"] }
         let(:helper_output) { pretty_print_array_or_hash(arguments) }
 
-        describe 'when arguments is a simple array' do
-          it 'returns a string with spacing and line breaks' do
+        describe "when arguments is a simple array" do
+          it "returns a string with spacing and line breaks" do
             assert_equal "[<br />  42,<br />  \"muad'dib\"<br />]", helper_output
           end
         end
 
-        describe 'when arguments is an array with complex data' do
-          let(:arguments) {
+        describe "when arguments is an array with complex data" do
+          let(:arguments) do
             [
               42,
               {
-                crew:       ['leela', 'fry', 'bender'],
-                created_at: '1999-03-28',
+                crew:       %w[leela fry bender],
+                created_at: "1999-03-28"
               }
             ]
-          }
+          end
 
-          it 'returns a string with spacing and line breaks' do
+          it "returns a string with spacing and line breaks" do
             expected_output = "[<br />  42,<br />  {<br />    \"crew\": [<br />      \"leela\",<br />      \"fry\",<br />      \"bender\"<br />    ],<br />    \"created_at\": \"1999-03-28\"<br />  }<br />]"
             assert_equal expected_output, helper_output
           end
@@ -44,7 +43,7 @@ module RocketJobMissionControl
         describe "when arguments isn't an array or hash" do
           let(:arguments) { 42 }
 
-          it 'returns the arguments' do
+          it "returns the arguments" do
             assert_equal arguments, helper_output
           end
         end

data/test/helpers/rocket_job_mission_control/jobs_helper_test.rb

@@ -1,62 +1,62 @@
-require_relative '../../test_helper'
+require_relative "../../test_helper"
 
 module RocketJobMissionControl
   JobsHelper.include(RocketJobMissionControl::ApplicationHelper)
 
   class JobsHelperTest < ActionView::TestCase
     describe JobsHelper do
-      describe '#jobs_icon' do
+      describe "#jobs_icon" do
         let :job do
           RocketJob::Jobs::SimpleJob.new
         end
 
-        it 'shows queued' do
-          assert_equal 'fas fa-inbox queued', job_icon(job)
+        it "shows queued" do
+          assert_equal "fas fa-inbox queued", job_icon(job)
         end
 
-        it 'shows running' do
+        it "shows running" do
           job.start
-          job.worker_name = 'test_worker'
-          assert_equal 'fas fa-play running', job_icon(job)
+          job.worker_name = "test_worker"
+          assert_equal "fas fa-play running", job_icon(job)
         end
 
-        it 'shows sleeping' do
+        it "shows sleeping" do
           job.start
-          assert_equal 'fas fa-hourglass sleeping', job_icon(job)
+          assert_equal "fas fa-hourglass sleeping", job_icon(job)
         end
 
-        it 'shows failed' do
+        it "shows failed" do
           job.start
           job.fail
-          assert_equal 'fas fa-exclamation-triangle failed', job_icon(job)
+          assert_equal "fas fa-exclamation-triangle failed", job_icon(job)
         end
 
-        it 'shows aborted' do
+        it "shows aborted" do
           job.start
           job.abort
-          assert_equal 'fas fa-stop aborted', job_icon(job)
+          assert_equal "fas fa-stop aborted", job_icon(job)
         end
 
-        it 'handles scheduled special case' do
+        it "handles scheduled special case" do
           job.run_at = 1.day.from_now
-          assert_equal 'fas fa-clock scheduled', job_icon(job)
+          assert_equal "fas fa-clock scheduled", job_icon(job)
         end
       end
 
-      describe '#jobs_states' do
-        it 'returns the states' do
-          assert_equal %w(queued running completed paused failed aborted), job_states
+      describe "#jobs_states" do
+        it "returns the states" do
+          assert_equal %w[queued running completed paused failed aborted], job_states
         end
       end
 
-      describe '#job_states_with_scheduled' do
-        it 'returns the states with scheduled' do
-          assert_equal %w(scheduled queued running completed paused failed aborted), job_states_with_scheduled
+      describe "#job_states_with_scheduled" do
+        it "returns the states with scheduled" do
+          assert_equal %w[scheduled queued running completed paused failed aborted], job_states_with_scheduled
         end
       end
 
-      describe '#job_counts_by_state' do
-        it 'returns job counts for a state' do
+      describe "#job_counts_by_state" do
+        it "returns job counts for a state" do
           RocketJob::Job.delete_all
           RocketJob::Jobs::SimpleJob.create!
           assert_equal 1, job_counts_by_state(:queued), RocketJob::Job.counts_by_state
@@ -64,25 +64,25 @@ module RocketJobMissionControl
         end
       end
 
-      describe '#job_action_link' do
-        let(:action) { 'abort' }
+      describe "#job_action_link" do
+        let(:action) { "abort" }
         let(:http_method) { :patch }
         let(:path) { "/jobs/42/#{action}" }
         let(:action_link) { job_action_link(action, path, http_method) }
 
-        it 'uses the action as the label' do
-          assert_match />abort<\/a>/, action_link
+        it "uses the action as the label" do
+          assert_match %r{>abort</a>}, action_link
         end
 
-        it 'links to the correct url' do
-          assert_match /href="\/jobs\/42\/abort\"/, action_link
+        it "links to the correct url" do
+          assert_match %r{href="/jobs/42/abort\"}, action_link
         end
 
-        it 'adds prompt for confirmation' do
+        it "adds prompt for confirmation" do
           assert_match /data-confirm="Are you sure you want to abort this job\?"/, action_link
         end
 
-        it 'uses correct http method' do
+        it "uses correct http method" do
           assert_match /data-method="patch"/, action_link
         end
       end