rocketjob_mission_control 4.3.0 → 5.0.0.beta1

data/app/helpers/rocket_job_mission_control/pagination_helper.rb

@@ -1,7 +1,7 @@
 module RocketJobMissionControl
   module PaginationHelper
     def page_nav_disabled_class(current_position, boundary)
-      current_position.to_i == boundary.to_i ? 'disabled' : ''
+      current_position.to_i == boundary.to_i ? "disabled" : ""
     end
   end
 end

data/app/helpers/rocket_job_mission_control/servers_helper.rb

@@ -7,7 +7,7 @@ module RocketJobMissionControl
     def server_icon(server)
       state =
         if server.zombie?
-          'zombie'
+          "zombie"
         else
           server.state
         end
@@ -16,14 +16,14 @@ module RocketJobMissionControl
 
     def server_card_class(server)
       if server.zombie?
-        'callout-zombie'
+        "callout-zombie"
       else
         map = {
-          running:  'callout-success',
-          paused:   'callout-warning',
-          stopping: 'callout-alert',
+          running:  "callout-success",
+          paused:   "callout-warning",
+          stopping: "callout-alert"
         }
-        map[server.state] || 'callout-info'
+        map[server.state] || "callout-info"
       end
     end
   end

data/app/helpers/rocket_job_mission_control/slices_helper.rb

@@ -1,9 +1,7 @@
 module RocketJobMissionControl
   module SlicesHelper
-
-    def display_slice_info(slice, encrypted=false)
-      encrypted ? 'encrypted' : pretty_print_array_or_hash(slice.to_a)
+    def display_slice_info(slice, encrypted = false)
+      encrypted ? "encrypted" : pretty_print_array_or_hash(slice.to_a)
     end
-
   end
 end

data/app/models/rocket_job_mission_control/access_policy.rb

@@ -17,7 +17,7 @@ module RocketJobMissionControl
 
       # Stop, Pause, Resume, Destroy (force stop) Rocket Job Servers
       role :operator, {operator: true} do
-        can %i[stop kill pause resume destroy update_all], RocketJob::Server
+        can %i[stop kill pause resume destroy destroy_zombies thread_dump], RocketJob::Server
       end
 
       # Pause, Resume, Retry, Abort, Edit Jobs
@@ -47,4 +47,3 @@ module RocketJobMissionControl
     end
   end
 end
-

data/app/models/rocket_job_mission_control/authorization.rb

@@ -1,12 +1,13 @@
 module RocketJobMissionControl
   class Authorization
-    ROLES = %i[admin editor operator manager dirmon user view]
+    ROLES = %i[admin editor operator manager dirmon user view].freeze
     attr_accessor *ROLES
     attr_accessor :login
 
     def initialize(roles: [], login: nil)
       @login = login
       return if roles.blank?
+
       invalid_roles = roles - ROLES
       raise(ArgumentError, "Invalid Roles Supplied: #{invalid_roles.inspect}") unless invalid_roles.empty?
 
@@ -19,4 +20,4 @@ module RocketJobMissionControl
       roles.each { |role| public_send("#{role}=", true) }
     end
   end
-end
+end

data/app/models/rocket_job_mission_control/job_sanitizer.rb

@@ -1,6 +1,5 @@
 module RocketJobMissionControl
   module JobSanitizer
-
     # Returns [Hash] the permissible params for the specified job class, after sanitizing.
     # Parameters
     #   properties [Hash]
@@ -19,29 +18,27 @@ module RocketJobMissionControl
     def self.sanitize(properties, job_class, target, nil_blank = true)
       permissible_params = {}
       job_class.user_editable_fields.each do |field_name|
-        if value = properties[field_name]
-          field = job_class.fields[field_name.to_s]
-          next unless field && field.type
+        next unless value = properties[field_name]
 
-          case field.type.name
-          when 'Hash'
-            begin
-              value = value.blank? ? nil : JSON.parse(value)
-            rescue JSON::ParserError => e
-              target.errors.add(:properties, e.message)
-            end
-          end
+        field = job_class.fields[field_name.to_s]
+        next unless field&.type
 
-          if value.blank? && !value.is_a?(Hash)
-            permissible_params[field_name] = nil if nil_blank
-          else
-            permissible_params[field_name] = value
+        case field.type.name
+        when "Hash"
+          begin
+            value = value.blank? ? nil : JSON.parse(value)
+          rescue JSON::ParserError => e
+            target.errors.add(:properties, e.message)
           end
+        end
 
+        if value.blank? && !value.is_a?(Hash)
+          permissible_params[field_name] = nil if nil_blank
+        else
+          permissible_params[field_name] = value
         end
       end
       permissible_params
     end
-
   end
 end

data/app/models/rocket_job_mission_control/query.rb

@@ -42,16 +42,13 @@ module RocketJobMissionControl
           records = records.where(search_columns.first => regexp)
         else
           cols    = search_columns.collect { |col| {col => regexp} }
-          records = records.where('$or' => cols)
+          records = records.where("$or" => cols)
         end
       end
 
       # Pagination
-      if start && page_size
-        records = records.skip(start).limit(page_size)
-      end
+      records = records.skip(start).limit(page_size) if start && page_size
       records
     end
-
   end
 end

data/app/views/rocket_job_mission_control/jobs/_exceptions.html.erb

@@ -22,7 +22,7 @@
       <% if can?(:view_slice, @job) %>
       <th>
         <div>
-          <%= link_to 'View Slice', view_slice_job_path(@job, error_type: exception.class_name, record_number: @job.input.failed.first["exception"]["record_number"] ), class: 'btn btn-primary' %>
+          <%= link_to 'View Slice', view_slice_job_path(@job, error_type: exception.class_name, record_number: @job.input.failed.first.processing_record_number), class: 'btn btn-primary' %>
         </div>
       </th>
       <% end %>

data/app/views/rocket_job_mission_control/jobs/edit_slice.html.erb

@@ -15,7 +15,7 @@
       <div id='submit'>
         <%= f.submit 'Save', class: 'btn btn-primary' %>
         <%= link_to 'Delete', delete_line_job_path(@job, offset: @offset, error_type: @failure_exception.class_name, line_index: @line_index), :data => {:confirm => 'Are you sure?'}, method: :patch, class: 'btn btn-danger' %>
-        <%= link_to 'Cancel', view_slice_job_path(@job, error_type: @failure_exception.class_name, record_number: @job.input.failed.first["exception"]["record_number"]), class: 'btn btn-default' %>
+        <%= link_to 'Cancel', view_slice_job_path(@job, error_type: @failure_exception.class_name, record_number: @job.input.failed.first.processing_record_number), class: 'btn btn-default' %>
     <% end %>
 
     </div>

data/app/views/rocket_job_mission_control/servers/index.html.erb

@@ -11,8 +11,8 @@
             <div class='server-collection-actions'>
               <ol>
                 <div class='btn-group'>
-                  <% if can?(:update_all, RocketJob::Server) %>
-                    <% Array(@actions).each do |action| %>
+                  <% Array(@actions).each do |action| %>
+                    <% if can?(action, RocketJob::Server) %>
                       <%= link_to(
                               "#{action.to_s.humanize.capitalize}",
                               rocket_job_mission_control.update_all_servers_path(server_action: action),

data/config/initializers/assets.rb

@@ -1,13 +1,11 @@
-Rails.application.config.assets.precompile << Proc.new { |path|
-  if path =~ /\.(eot|svg|ttf|woff)\z/
-    true
-  end
-}
+Rails.application.config.assets.precompile << proc do |path|
+  true if path =~ /\.(eot|svg|ttf|woff)\z/
+end
 
-Rails.application.config.assets.precompile += %w(
+Rails.application.config.assets.precompile += %w[
   rocket_job_mission_control/favicon.png
   rocket_job_mission_control/safari-pinned-tab.svg
   rocket_job_mission_control/favicon-16x16.png
   rocket_job_mission_control/favicon-32x32.png
   rocket_job_mission_control/apple-touch-icon.png
-)
+]

data/config/locales/en.yml

@@ -50,7 +50,10 @@ en:
       failure: "Error attempting to resume server."
     update_all:
       invalid: "Action not allowed."
+      success: "Submitted %{action} request to all active Rocket Job servers."
       confirm: "Are you sure you want to %{action} ALL Rocket Job servers?"
+    update_one:
+      success: "Submitted %{action} request to Rocket Job server: %{name}."
   job:
     find:
       failure: "Could not find job with id: %{id}!"

data/config/routes.rb

@@ -1,15 +1,14 @@
-#@formatter:off
+# @formatter:off
 RocketJobMissionControl::Engine.routes.draw do
-
-  resources :jobs, only: [:index, :show, :update, :destroy, :edit] do
+  resources :jobs, only: %i[index show update destroy edit] do
     collection do
-      get :running,   to: 'jobs#running'
-      get :scheduled, to: 'jobs#scheduled'
-      get :completed, to: 'jobs#completed'
-      get :queued,    to: 'jobs#queued'
-      get :paused,    to: 'jobs#paused'
-      get :failed,    to: 'jobs#failed'
-      get :aborted,   to: 'jobs#aborted'
+      get :running,   to: "jobs#running"
+      get :scheduled, to: "jobs#scheduled"
+      get :completed, to: "jobs#completed"
+      get :queued,    to: "jobs#queued"
+      get :paused,    to: "jobs#paused"
+      get :failed,    to: "jobs#failed"
+      get :aborted,   to: "jobs#aborted"
     end
 
     member do
@@ -30,13 +29,13 @@ RocketJobMissionControl::Engine.routes.draw do
 
   resources :active_workers, only: :index
 
-  resources :servers, only: [:index, :destroy] do
+  resources :servers, only: %i[index destroy] do
     collection do
-      get :starting, to: 'servers#starting'
-      get :running,  to: 'servers#running'
-      get :paused,   to: 'servers#paused'
-      get :stopping, to: 'servers#stopping'
-      get :zombie,   to: 'servers#zombie'
+      get :starting, to: "servers#starting"
+      get :running,  to: "servers#running"
+      get :paused,   to: "servers#paused"
+      get :stopping, to: "servers#stopping"
+      get :zombie,   to: "servers#zombie"
     end
 
     member do
@@ -51,10 +50,10 @@ RocketJobMissionControl::Engine.routes.draw do
 
   resources :dirmon_entries do
     collection do
-      get :pending,  to: 'dirmon_entries#pending'
-      get :enabled,  to: 'dirmon_entries#enabled'
-      get :failed,   to: 'dirmon_entries#failed'
-      get :disabled, to: 'dirmon_entries#disabled'
+      get :pending,  to: "dirmon_entries#pending"
+      get :enabled,  to: "dirmon_entries#enabled"
+      get :failed,   to: "dirmon_entries#failed"
+      get :disabled, to: "dirmon_entries#disabled"
     end
 
     member do
@@ -63,7 +62,7 @@ RocketJobMissionControl::Engine.routes.draw do
     end
   end
 
-  get 'rocket_job_mission_control/test' => 'test#index' if Rails.env.test?
+  get "rocket_job_mission_control/test" => "test#index" if Rails.env.test?
 
   root to: "jobs#running"
 end

data/lib/rocket_job_mission_control/engine.rb

@@ -1,5 +1,4 @@
 module RocketJobMissionControl
-
   # The authorization callback
   module Config
     mattr_accessor :authorization_callback
@@ -8,22 +7,22 @@ module RocketJobMissionControl
   class Engine < ::Rails::Engine
     isolate_namespace RocketJobMissionControl
 
-    require 'rocketjob'
-    require 'jquery-rails'
-    require 'sass-rails'
-    require 'jquery-datatables-rails'
-    require 'access-granted'
+    require "rocketjob"
+    require "jquery-rails"
+    require "sass-rails"
+    require "jquery-datatables-rails"
+    require "access-granted"
     begin
-      require 'rocketjob_enterprise'
+      require "rocketjob_enterprise"
     rescue LoadError
     end
 
     config.rocket_job_mission_control = ::RocketJobMissionControl::Config
 
     config.to_prepare do
-      Rails.application.config.assets.precompile += %w(
+      Rails.application.config.assets.precompile += %w[
         rocket_job_mission_control/rocket-icon-64x64.png
-      )
+      ]
     end
   end
 end

data/lib/rocket_job_mission_control/version.rb

@@ -1,3 +1,3 @@
 module RocketJobMissionControl
-  VERSION = '4.3.0'.freeze
+  VERSION = "5.0.0.beta1".freeze
 end

data/lib/rocketjob_mission_control.rb

@@ -1,4 +1,4 @@
-require 'rocket_job_mission_control/engine'
+require "rocket_job_mission_control/engine"
 
 module RocketJobMissionControl
 end

data/test/compare_hashes.rb

@@ -6,7 +6,7 @@ end
 
 def compare_hash(expected_hash, actual_hash)
   expected_hash.each_pair do |key, expected|
-    actual = actual_hash[key]
+    actual = actual_hash[key].to_s
     if expected.is_a?(Regexp)
       assert_match expected, actual, "#{key} does not match. Expected #{expected.inspect}. Actual #{actual.inspect}"
     else
@@ -14,4 +14,3 @@ def compare_hash(expected_hash, actual_hash)
     end
   end
 end
-

data/test/controllers/rocket_job_mission_control/application_controller_test.rb

@@ -1,40 +1,40 @@
-require_relative '../../test_helper'
+require_relative "../../test_helper"
 
 module RocketJobMissionControl
   class TestController < ApplicationController
     def index
       @time_zone = Time.zone
 
-      render plain: 'Time Zoned'
+      render plain: "Time Zoned"
     end
   end
 
   class ApplicationControllerTest < ActionController::TestCase
     describe TestController do
-      describe '#with_time_zone' do
-        it 'uses correct timezone with session and time_zone set' do
+      describe "#with_time_zone" do
+        it "uses correct timezone with session and time_zone set" do
           if Rails.version.to_i >= 5
-            session['time_zone'] = 'America/Los_Angeles'
+            session["time_zone"] = "America/Los_Angeles"
             get :index
           else
-            get :index, {}, {'time_zone' => 'America/Los_Angeles'}
+            get :index, {}, {"time_zone" => "America/Los_Angeles"}
           end
-          assert_equal 'America/Los_Angeles', assigns(:time_zone).name
+          assert_equal "America/Los_Angeles", assigns(:time_zone).name
         end
 
-        it 'uses correct timezone with session, but no time_zone set' do
+        it "uses correct timezone with session, but no time_zone set" do
           if Rails.version.to_i >= 5
-            session['user_id'] = '42'
+            session["user_id"] = "42"
             get :index
           else
-            get :index, {}, {'user_id' => '42'}
+            get :index, {}, {"user_id" => "42"}
           end
-          assert_equal 'UTC', assigns(:time_zone).name
+          assert_equal "UTC", assigns(:time_zone).name
         end
 
-        it 'uses correct timezone without a session' do
+        it "uses correct timezone without a session" do
           get :index
-          assert_equal 'UTC', assigns(:time_zone).name
+          assert_equal "UTC", assigns(:time_zone).name
         end
       end
     end

data/test/controllers/rocket_job_mission_control/dirmon_entries_controller_test.rb

@@ -1,5 +1,5 @@
-require_relative '../../test_helper'
-require_relative '../../compare_hashes'
+require_relative "../../test_helper"
+require_relative "../../compare_hashes"
 
 module RocketJobMissionControl
   class DirmonEntriesControllerTest < ActionController::TestCase
@@ -10,14 +10,14 @@ module RocketJobMissionControl
       end
 
       let :job_class_name do
-        'RocketJob::Jobs::SimpleJob'
+        "RocketJob::Jobs::SimpleJob"
       end
 
       let :existing_dirmon_entry do
         RocketJob::DirmonEntry.create!(
-          name:           'Test',
+          name:           "Test",
           job_class_name: job_class_name,
-          pattern:        'the_path'
+          pattern:        "the_path"
         )
       end
 
@@ -26,16 +26,16 @@ module RocketJobMissionControl
       let :one_dirmon_entry_for_every_state do
         dirmon_entry_states.collect do |state|
           RocketJob::DirmonEntry.create!(
-            name:           'Test',
+            name:           "Test",
             job_class_name: job_class_name,
-            pattern:        'the_path',
+            pattern:        "the_path",
             state:          state
           )
         end
       end
 
-      describe 'PATCH #enable' do
-        describe 'when transition is allowed' do
+      describe "PATCH #enable" do
+        describe "when transition is allowed" do
           before do
             params = {id: existing_dirmon_entry.id}
             params = {params: params} if Rails.version.to_i >= 5
@@ -46,12 +46,12 @@ module RocketJobMissionControl
             assert_redirected_to dirmon_entry_path(existing_dirmon_entry)
           end
 
-          it 'changes the state to enabled' do
+          it "changes the state to enabled" do
             assert existing_dirmon_entry.reload.enabled?
           end
         end
 
-        describe 'when transition is not allowed' do
+        describe "when transition is not allowed" do
           before do
             existing_dirmon_entry.enable!
             params = {id: existing_dirmon_entry.id}
@@ -59,18 +59,18 @@ module RocketJobMissionControl
             patch :enable, params
           end
 
-          it 'succeeds' do
+          it "succeeds" do
             assert_response :success
           end
 
-          it 'alerts the user' do
-            assert_equal I18n.t(:failure, scope: [:dirmon_entry, :enable]), flash[:alert]
+          it "alerts the user" do
+            assert_equal I18n.t(:failure, scope: %i[dirmon_entry enable]), flash[:alert]
           end
         end
       end
 
-      describe 'PATCH #disable' do
-        describe 'when transition is allowed' do
+      describe "PATCH #disable" do
+        describe "when transition is allowed" do
           before do
             existing_dirmon_entry.enable!
             params = {id: existing_dirmon_entry.id}
@@ -82,29 +82,29 @@ module RocketJobMissionControl
             assert_redirected_to dirmon_entry_path(existing_dirmon_entry)
           end
 
-          it 'changes the state to disabled' do
+          it "changes the state to disabled" do
             assert existing_dirmon_entry.reload.disabled?
           end
         end
 
-        describe 'when transition is not allowed' do
+        describe "when transition is not allowed" do
           before do
             params = {id: existing_dirmon_entry.id}
             params = {params: params} if Rails.version.to_i >= 5
             patch :disable, params
           end
 
-          it 'succeeds' do
+          it "succeeds" do
             assert_response :success
           end
 
-          it 'alerts the user' do
-            assert_equal I18n.t(:failure, scope: [:dirmon_entry, :disable]), flash[:alert]
+          it "alerts the user" do
+            assert_equal I18n.t(:failure, scope: %i[dirmon_entry disable]), flash[:alert]
           end
         end
       end
 
-      describe 'GET #new' do
+      describe "GET #new" do
         let(:entry_params) { {} }
 
         before do
@@ -113,99 +113,98 @@ module RocketJobMissionControl
           get :new, params
         end
 
-        it 'succeeds' do
+        it "succeeds" do
           assert_response :success
         end
 
-        it 'assigns a new entry' do
+        it "assigns a new entry" do
           assert assigns(:dirmon_entry).present?
           refute assigns(:dirmon_entry).persisted?
         end
 
-        describe 'with form params' do
-          let(:entry_params) { {rocket_job_dirmon_entry: {name: 'new entry'}} }
+        describe "with form params" do
+          let(:entry_params) { {rocket_job_dirmon_entry: {name: "new entry"}} }
 
-          it 'succeeds' do
+          it "succeeds" do
             assert_response :success
           end
 
-          it 'assigns the params to new entry' do
-            assert_equal 'new entry', assigns(:dirmon_entry).name
+          it "assigns the params to new entry" do
+            assert_equal "new entry", assigns(:dirmon_entry).name
           end
 
-          describe 'with a valid job_class_name' do
-            let(:entry_params) { {rocket_job_dirmon_entry: {job_class_name: 'NoParamsJob'}} }
+          describe "with a valid job_class_name" do
+            let(:entry_params) { {rocket_job_dirmon_entry: {job_class_name: "NoParamsJob"}} }
 
-            it 'succeeds' do
+            it "succeeds" do
               assert_response :success
             end
 
-            it 'assigns the job class' do
-              assert_equal 'NoParamsJob', assigns(:dirmon_entry).job_class_name
+            it "assigns the job class" do
+              assert_equal "NoParamsJob", assigns(:dirmon_entry).job_class_name
             end
           end
 
-          describe 'with an invalid job_class_name' do
-            let(:entry_params) { {rocket_job_dirmon_entry: {job_class_name: 'BadJob'}} }
+          describe "with an invalid job_class_name" do
+            let(:entry_params) { {rocket_job_dirmon_entry: {job_class_name: "BadJob"}} }
 
-            it 'succeeds' do
+            it "succeeds" do
               assert_response :success
             end
 
-            it 'adds an error' do
+            it "adds an error" do
               assert assigns(:dirmon_entry).errors[:job_class_name].present?
             end
           end
         end
-
       end
 
-      describe 'PATCH #update' do
-        describe 'with valid parameters' do
+      describe "PATCH #update" do
+        describe "with valid parameters" do
           before do
-            params = {id: existing_dirmon_entry.id, rocket_job_dirmon_entry: {pattern: 'the_path2', job_class_name: job_class_name}}
+            params = {id: existing_dirmon_entry.id, rocket_job_dirmon_entry: {pattern: "the_path2", job_class_name: job_class_name}}
             params = {params: params} if Rails.version.to_i >= 5
             patch :update, params
           end
 
-          it 'redirects to the updated entry' do
+          it "redirects to the updated entry" do
             assert_redirected_to dirmon_entry_path(existing_dirmon_entry)
           end
 
-          it 'updates the entry' do
-            assert_equal 'the_path2', existing_dirmon_entry.reload.pattern
+          it "updates the entry" do
+            assert_equal "the_path2", existing_dirmon_entry.reload.pattern
           end
         end
 
-        describe 'with invalid parameters' do
+        describe "with invalid parameters" do
           before do
-            params = {id: existing_dirmon_entry.id, rocket_job_dirmon_entry: {job_class_name: 'FakeAndBadJob'}}
+            params = {id: existing_dirmon_entry.id, rocket_job_dirmon_entry: {job_class_name: "FakeAndBadJob"}}
             params = {params: params} if Rails.version.to_i >= 5
             patch :update, params
           end
 
-          it 'renders the edit template' do
+          it "renders the edit template" do
             assert_response :success
           end
 
-          it 'alerts the user' do
+          it "alerts the user" do
             if RocketJob::VERSION.to_f >= 3.5
-              assert_select 'div.message', "job_class_name: [\"Job FakeAndBadJob must be defined and inherit from RocketJob::Job\"]"
+              assert_select "div.message", "job_class_name: [\"Job FakeAndBadJob must be defined and inherit from RocketJob::Job\"]"
             else
-              assert_select 'div.message', "job_class_name: [\"job_class_name must be defined and must be derived from RocketJob::Job\"]"
+              assert_select "div.message", "job_class_name: [\"job_class_name must be defined and must be derived from RocketJob::Job\"]"
             end
           end
         end
       end
 
-      describe 'POST #create' do
-        describe 'with valid parameters' do
+      describe "POST #create" do
+        describe "with valid parameters" do
           let(:dirmon_params) do
             {
-              name:           'Test',
-              pattern:        '/files/*',
+              name:           "Test",
+              pattern:        "/files/*",
               job_class_name: job_class_name,
-              properties:     {description: '', priority: '42'}
+              properties:     {description: "", priority: "42"}
             }
           end
 
@@ -215,38 +214,38 @@ module RocketJobMissionControl
             post :create, params
           end
 
-          it 'creates the entry' do
+          it "creates the entry" do
             assert assigns(:dirmon_entry).persisted?
           end
 
-          it 'has no errors' do
+          it "has no errors" do
             assert assigns(:dirmon_entry).errors.messages.empty?
           end
 
-          it 'redirects to created entry' do
+          it "redirects to created entry" do
             assert_redirected_to dirmon_entry_path(assigns(:dirmon_entry))
           end
 
-          it 'does not save blank properties' do
+          it "does not save blank properties" do
             assert_nil assigns(:dirmon_entry).properties[:description]
           end
 
-          it 'saves properties' do
-            assert_equal '42', assigns(:dirmon_entry).properties[:priority]
+          it "saves properties" do
+            assert_equal "42", assigns(:dirmon_entry).properties[:priority]
           end
 
-          [:name, :pattern, :job_class_name].each do |attribute|
+          %i[name pattern job_class_name].each do |attribute|
             it "assigns the correct value for #{attribute}" do
               assert_equal dirmon_params[attribute], assigns(:dirmon_entry)[attribute]
             end
           end
         end
 
-        describe 'with invalid parameters' do
+        describe "with invalid parameters" do
           let(:dirmon_params) do
             {
-              name:           'Test',
-              job_class_name: 'FakeAndBadJob'
+              name:           "Test",
+              job_class_name: "FakeAndBadJob"
             }
           end
 
@@ -256,82 +255,82 @@ module RocketJobMissionControl
             post :create, params
           end
 
-          describe 'on model attributes' do
-            it 'renders the new template' do
+          describe "on model attributes" do
+            it "renders the new template" do
               assert_response :success
               assert_template :new
             end
 
-            it 'has errors on the entry' do
+            it "has errors on the entry" do
               refute assigns(:dirmon_entry).valid?
             end
           end
         end
       end
 
-      describe 'GET #edit' do
+      describe "GET #edit" do
         before do
           params = {id: existing_dirmon_entry.id}
           params = {params: params} if Rails.version.to_i >= 5
           get :edit, params
         end
 
-        it 'succeeds' do
+        it "succeeds" do
           assert_response :success
         end
 
-        it 'assigns the entry' do
+        it "assigns the entry" do
           assert_equal existing_dirmon_entry, assigns(:dirmon_entry)
         end
       end
 
-      describe 'GET #show' do
-        describe 'with an invalid id' do
+      describe "GET #show" do
+        describe "with an invalid id" do
           before do
             params = {id: 42}
             params = {params: params} if Rails.version.to_i >= 5
             get :show, params
           end
 
-          it 'redirects' do
+          it "redirects" do
             assert_redirected_to dirmon_entries_path
           end
 
-          it 'adds a flash alert message' do
-            assert_equal I18n.t(:failure, scope: [:dirmon_entry, :find], id: 42), flash[:alert]
+          it "adds a flash alert message" do
+            assert_equal I18n.t(:failure, scope: %i[dirmon_entry find], id: 42), flash[:alert]
           end
         end
 
-        describe 'with a valid id' do
+        describe "with a valid id" do
           before do
             params = {id: existing_dirmon_entry.id}
             params = {params: params} if Rails.version.to_i >= 5
             get :show, params
           end
 
-          it 'succeeds' do
+          it "succeeds" do
             assert_response :success
           end
 
-          it 'assigns the entry' do
+          it "assigns the entry" do
             assert assigns(:dirmon_entry).present?
           end
         end
       end
 
-      describe 'DELETE #destroy' do
-        describe 'with a valid id' do
+      describe "DELETE #destroy" do
+        describe "with a valid id" do
           before do
             params = {id: existing_dirmon_entry.id}
             params = {params: params} if Rails.version.to_i >= 5
             delete :destroy, params
           end
 
-          it 'redirects to index' do
+          it "redirects to index" do
             assert_redirected_to dirmon_entries_path
           end
 
-          it 'deletes the entry' do
+          it "deletes the entry" do
             refute RocketJob::DirmonEntry.where(id: existing_dirmon_entry.id).exists?
           end
         end
@@ -339,17 +338,17 @@ module RocketJobMissionControl
 
       ([:index] + dirmon_entry_states).each do |state|
         describe "GET ##{state}" do
-          describe 'html' do
+          describe "html" do
             describe "with no #{state} entries" do
               before do
                 get state
               end
 
-              it 'succeeds' do
+              it "succeeds" do
                 assert_response :success
               end
 
-              it 'renders template' do
+              it "renders template" do
                 assert_template :index
               end
             end
@@ -360,23 +359,23 @@ module RocketJobMissionControl
                 get state
               end
 
-              it 'succeeds' do
+              it "succeeds" do
                 assert_response :success
               end
 
-              it 'renders template' do
+              it "renders template" do
                 assert_template :index
               end
             end
           end
 
-          describe 'json' do
+          describe "json" do
             describe "with #{state} entries" do
               before do
                 get state, format: :json
               end
 
-              it 'succeeds' do
+              it "succeeds" do
                 assert_response :success
                 json     = JSON.parse(response.body)
                 expected = {
@@ -395,7 +394,7 @@ module RocketJobMissionControl
                 get state, format: :json
               end
 
-              it 'succeeds' do
+              it "succeeds" do
                 assert_response :success
                 json          = JSON.parse(response.body)
                 expected_data = {
@@ -426,15 +425,15 @@ module RocketJobMissionControl
                 }
 
                 if state == :index
-                  assert_equal 0, json['draw']
-                  assert_equal 4, json['recordsTotal']
-                  assert_equal 4, json['recordsFiltered']
-                  assert_equal [expected_data[:pending], expected_data[:enabled], expected_data[:failed], expected_data[:disabled]], json['data']
+                  assert_equal 0, json["draw"]
+                  assert_equal 4, json["recordsTotal"]
+                  assert_equal 4, json["recordsFiltered"]
+                  assert_equal [expected_data[:pending], expected_data[:enabled], expected_data[:failed], expected_data[:disabled]], json["data"]
                 else
-                  assert_equal 0, json['draw']
-                  assert_equal 1, json['recordsTotal']
-                  assert_equal 1, json['recordsFiltered']
-                  assert_equal [expected_data[state]], json['data']
+                  assert_equal 0, json["draw"]
+                  assert_equal 1, json["recordsTotal"]
+                  assert_equal 1, json["recordsFiltered"]
+                  assert_equal [expected_data[state]], json["data"]
                 end
               end
             end
@@ -442,13 +441,13 @@ module RocketJobMissionControl
         end
       end
 
-      describe 'role base authentication control' do
+      describe "role base authentication control" do
         let(:dirmon_params) do
           {
-            name:           'Test',
-            pattern:        '/files/*',
+            name:           "Test",
+            pattern:        "/files/*",
             job_class_name: job_class_name,
-            properties:     {description: '', priority: '42'}
+            properties:     {description: "", priority: "42"}
           }
         end
 
@@ -477,7 +476,7 @@ module RocketJobMissionControl
 
         # POST
         %i[admin editor operator manager dirmon].each do |role|
-          it 'creates dirmon entry' do
+          it "creates dirmon entry" do
             set_role(role)
             params = {rocket_job_dirmon_entry: dirmon_params}
             params = {params: params} if Rails.version.to_i >= 5
@@ -487,7 +486,7 @@ module RocketJobMissionControl
           end
         end
 
-        it 'deletes dirmon entry' do
+        it "deletes dirmon entry" do
           set_role(:admin)
           params = {id: existing_dirmon_entry.id}
           params = {params: params} if Rails.version.to_i >= 5
@@ -510,9 +509,9 @@ module RocketJobMissionControl
     end
 
     def set_role(r)
-      Config.authorization_callback = -> do
+      Config.authorization_callback = lambda {
         {roles: [r]}
-      end
+      }
     end
   end
 end