robust_excel_ole 1.16 → 1.17

data/spec/general_spec.rb

@@ -60,9 +60,23 @@ module RobustExcelOle
       end
 
       it "should type-lift a range" do
-        range = @book1.sheet(1).range([1,1]).ole_range.to_reo
+        range = @book1.sheet(1).range([1..2,1]).ole_range.to_reo
         range.should be_kind_of Range
-        range.Value.should == "foo"
+        range.Value.should == [["foo"],["foo"]]
+      end
+
+      it "should type-lift a cell" do
+        cell = @book1.sheet(1).range([1,1]).ole_range.to_reo
+        #cell = @book1.sheet(1)[1,1].ole_cell.to_reo
+        cell.should be_kind_of Cell
+        cell.Value.should == "foo"
+      end
+
+      it "should not do anything with a REO object" do
+        @book1.to_reo.should == @book1 
+        @book1.sheet(1).to_reo.should == @book1.sheet(1)
+        @book1.excel.to_reo.should == @book1.excel
+        @book1.sheet(1).range([1,1]).to_reo.should == @book1.sheet(1).range([1,1])
       end
 
     end
@@ -222,22 +236,5 @@ module RobustExcelOle
       end
     end
 
-    describe "Object methods" do
-
-      before do
-        @book = Workbook.open(@simple_file)
-        @sheet = @book.sheet(1)
-      end
-
-      before do
-        @book.close
-      end
-
-      it "should raise an error when asking excel of a sheet" do
-        expect{
-          @sheet.excel
-          }.to raise_error(TypeREOError, "receiver instance is neither an Excel nor a Workbook")
-      end
-    end
   end
 end

data/spec/range_spec.rb

@@ -335,7 +335,7 @@ describe RobustExcelOle::Range do
     #end
 
     context "unknown method" do
-      it { expect { @range.hogehogefoo}.to raise_error }
+      it { expect { @range.hogehogefoo}.to raise_error(NoMethodError) }
     end
   end
 end

data/spec/workbook_spec.rb

@@ -625,16 +625,16 @@ describe Workbook do
         old_cell_value = sheet[1,1].Value
         sheet[1,1] = sheet[1,1].Value == "foo" ? "bar" : "foo"
         book.Saved.should be false
-        new_book = Workbook.open(@simple_file1, :read_only => false, :if_unsaved => :accept)
+        new_book = Workbook.open(@simple_file1, :read_only => false, :if_unsaved => :forget)
         new_book.ReadOnly.should be false 
         new_book.should be_alive
-        book.should be_alive   
-        new_book.should == book 
+        book.should_not be_alive   
         new_sheet = new_book.sheet(1)
         new_cell_value = new_sheet[1,1].Value
         new_cell_value.should == old_cell_value
       end
 
+
     context "with block" do
       it 'block parameter should be instance of Workbook' do
         Workbook.open(@simple_file) do |book|
@@ -927,31 +927,6 @@ describe Workbook do
       after do
         @book.close
       end
-
-      it "should open unobtrusively the book in a new Excel such that the book is writable" do
-        book2 = Workbook.open(@simple_file1, :force => {:excel => :new}, :read_only => true)
-        @book.ReadOnly.should be true
-        book2.Readonly.should be true
-        sheet = @book.sheet(1)
-        cell_value = sheet[1,1].Value
-        Workbook.unobtrusively(@simple_file1, :rw_change_excel => :new, :if_closed => :current, :writable => true) do |book|
-          book.should be_a Workbook
-          book.excel.should_not == book2.excel
-          book.excel.should_not == @book.excel
-          sheet = book.sheet(1)
-          sheet[1,1] = sheet[1,1].Value == "foo" ? "bar" : "foo"
-          book.should be_alive
-          book.Saved.should be false          
-        end  
-        @book.Saved.should be true
-        @book.ReadOnly.should be true
-        @book.close
-        book2.close
-        book3 = Workbook.open(@simple_file1)
-        new_sheet = book3.sheet(1)
-        new_sheet[1,1].Value.should_not == cell_value
-        book3.close
-      end
     end
 
     context "with a virgin Workbook class" do
@@ -1001,7 +976,7 @@ describe Workbook do
 
       before do
         @book1 = Workbook.open(@simple_file1)
-        @book2 = Workbook.open(@simple_file1, :force => {:excel => :new})
+        @book2 = Workbook.open(@simple_file1, :force_excel => :new)
         @book1.Readonly.should == false
         @book2.Readonly.should == true
         old_sheet = @book1.sheet(1)
@@ -1013,9 +988,9 @@ describe Workbook do
       end
 
       it "should open unobtrusively the closed book in the most recent Excel where it was open before" do      
-        Workbook.unobtrusively(@simple_file) do |book| 
-          book.excel.should_not == @book2.excel
-          book.excel.should == @book1.excel
+        Workbook.unobtrusively(@simple_file1, :if_closed => :current) do |book| 
+          book.excel.should == @book2.excel
+          book.excel.should_not == @book1.excel
           book.ReadOnly.should == false
           sheet = book.sheet(1)
           cell = sheet[1,1]
@@ -1027,52 +1002,9 @@ describe Workbook do
         sheet[1,1].Value.should_not == @old_cell_value
       end
 
-      it "should open unobtrusively the closed book in the new hidden Excel" do
-        Workbook.unobtrusively(@simple_file, :if_closed => :current) do |book| 
-          book.excel.should_not == @book2.excel
-          book.excel.should == @book1.excel
-          book.ReadOnly.should == false
-          sheet = book.sheet(1)
-          cell = sheet[1,1]
-          sheet[1,1] = cell.Value == "foo" ? "bar" : "foo"
-          book.Saved.should be false
-        end
-        new_book = Workbook.open(@simple_file1)
-        sheet = new_book.sheet(1)
-        sheet[1,1].Value.should_not == @old_cell_value
-      end
     end
   end
-
-=begin
-    context "with :hidden" do
-
-      before do
-        @book1 = Workbook.open(@simple_file1)
-        @book1.close
-      end
     
-      it "should create a new hidden Excel instance and use this afterwards" do
-        hidden_excel = nil
-        Workbook.unobtrusively(@simple_file1, :hidden) do |book| 
-          book.should be_a Workbook
-          book.should be_alive
-          book.excel.Visible.should be false
-          book.excel.DisplayAlerts.should be false
-          hidden_excel = book.excel
-        end
-        Workbook.unobtrusively(@different_file, :hidden) do |book| 
-          book.should be_a Workbook
-          book.should be_alive
-          book.excel.Visible.should be false
-          book.excel.DisplayAlerts.should be false
-          book.excel.should == hidden_excel
-        end
-      end
-    end
-  end
-=end
-  
   describe "for_reading, for_modifying" do
 
     context "open unobtrusively for reading and modifying" do

data/spec/workbook_specs/workbook_misc_spec.rb

@@ -59,25 +59,25 @@ describe Workbook do
       @book.Windows(@book.Name).Visible.should be true
       @book.visible.should be true
       @book.ReadOnly.should be false
-      @book.CheckCompatibility.should be false
+      @book.CheckCompatibility.should be true
       @book.for_this_workbook(:visible => false)
       @book.excel.Visible.should be true
       @book.Windows(@book.Name).Visible.should be false
       @book.visible.should be false
       @book.ReadOnly.should be false
-      @book.CheckCompatibility.should be false
+      @book.CheckCompatibility.should be true
       @book.for_this_workbook(:read_only => true)
       @book.excel.Visible.should be true
-      @book.Windows(@book.Name).Visible.should be false
-      @book.visible.should be false
+      @book.Windows(@book.Name).Visible.should be true
+      @book.visible.should be true
       @book.ReadOnly.should be true
-      @book.CheckCompatibility.should be false
+      @book.CheckCompatibility.should be true
       @book.for_this_workbook(:visible => true)
       @book.excel.Visible.should be true
       @book.Windows(@book.Name).Visible.should be true
       @book.visible.should be true
       @book.ReadOnly.should be true
-      @book.CheckCompatibility.should be false
+      @book.CheckCompatibility.should be true
       @book.for_this_workbook(:check_compatibility => true)
       @book.excel.Visible.should be true
       @book.Windows(@book.Name).Visible.should be true
@@ -106,7 +106,7 @@ describe Workbook do
 
   end
 
-  describe "excel_of" do
+  describe "to_reo.excel" do
 
     before do
       @book = Workbook.open(@simple_file)
@@ -118,19 +118,19 @@ describe Workbook do
 
     it "should access the excel" do
       workbook = @book.ole_workbook
-      excel = Workbook.excel_of(workbook)
+      excel = workbook.to_reo.excel
       excel.should be_a Excel
       excel.should == @book.excel
     end
 
     it "should access the Excel of the ole_excel" do
-      excel = Workbook.excel_of(@book.excel.ole_excel)
+      excel = @book.excel.ole_excel.to_reo.excel
       excel.should be_a Excel
       excel.should == @book.excel
     end
 
     it "should access the Excel of a Workbook" do
-      excel = Workbook.excel_of(@book)
+      excel = @book.to_reo.excel
       excel.should be_a Excel
       excel.should == @book.excel
     end

data/spec/workbook_specs/workbook_open_spec.rb

@@ -41,6 +41,9 @@ describe Workbook do
     @simple_file_hostname_share_path1 = @simple_file_hostname_share_path
     @simple_file_network_path_other_path1 = @simple_file_network_path_other_path
     @simple_file_hostname_share_path_other_path1 = @simple_file_hostname_share_path_other_path
+    @simple_file_xlsm1 = @simple_file_xlsm
+    @simple_file_xlsx1 = @simple_file_xlsx
+    @error_message_excel = "provided Excel option value is neither an Excel object nor a valid option"
   end
 
   after do
@@ -48,6 +51,198 @@ describe Workbook do
     rm_tmp(@dir)
   end
 
+  describe "basic tests with xlsx-workbooks" do
+
+    context "with simple file" do
+
+      it "should simply create a new workbook given a file" do
+        book = Workbook.new(@simple_file_xlsx1)
+        book.should be_alive
+        book.should be_a Workbook
+        book.filename.should == @simple_file_xlsx1
+      end
+
+    end
+
+    context "with transparency identity" do
+
+      before do
+        @book = Workbook.open(@simple_file_xlsx1)        
+      end
+
+      after do
+        @book.close
+      end
+
+      it "should yield identical Workbook objects referring to identical WIN32OLE objects" do
+        book2 = Workbook.new(@book.ole_workbook)
+        book2.equal?(@book).should be true
+      end
+
+    end
+
+    context "with connecting to one unknown workbook" do
+
+      before do
+        ole_e1 = WIN32OLE.new('Excel.Application')
+        ws = ole_e1.Workbooks
+        abs_filename = General.absolute_path(@simple_file_xlsx1)
+        @ole_wb = ws.Open(abs_filename)
+      end
+
+      it "should connect to an unknown workbook" do
+        Workbook.open(@simple_file_xlsx1) do |book|
+          book.filename.should == @simple_file_xlsx1
+          book.should be_alive
+          book.should be_a Workbook
+          book.excel.ole_excel.Hwnd.should == @ole_wb.Application.Hwnd
+          Excel.excels_number.should == 1
+        end
+      end
+    end
+
+    context "with :force => excel" do
+
+      before do
+        @book = Workbook.open(@simple_file_xlsx1)
+      end
+
+      it "should open in a new Excel" do
+        book2 = Workbook.open(@simple_file_xlsx1, :force => {:excel => :new})
+        book2.should be_alive
+        book2.should be_a Workbook
+        book2.excel.should_not == @book.excel 
+        book2.should_not == @book
+        @book.Readonly.should be false
+        book2.Readonly.should be true
+        book2.close
+      end
+
+    end
+
+    context "with :if_unsaved" do
+
+      before do
+        @book = Workbook.open(@simple_file_xlsx1)
+        @sheet = @book.sheet(1)
+        @book.add_sheet(@sheet, :as => 'a_name')
+        @book.visible = true
+      end
+
+      after do
+        @book.close(:if_unsaved => :forget)
+        @new_book.close rescue nil
+      end
+
+      it "should let the book open, if :if_unsaved is :accept" do
+        expect {
+          @new_book = Workbook.open(@simple_file_xlsx1, :if_unsaved => :accept)
+          }.to_not raise_error
+        @book.should be_alive
+        @new_book.should be_alive
+        @new_book.should == @book
+      end
+    
+    end
+  
+  end
+
+  describe "basic tests with xlsm-workbooks" do
+
+    context "with simple file" do
+
+      it "should simply create a new workbook given a file" do
+        book = Workbook.new(@simple_file_xlsm1)
+        book.should be_alive
+        book.should be_a Workbook
+        book.filename.should == @simple_file_xlsm1
+      end
+
+    end
+
+    context "with transparency identity" do
+
+      before do
+        @book = Workbook.open(@simple_file_xlsm1)        
+      end
+
+      after do
+        @book.close
+      end
+
+      it "should yield identical Workbook objects referring to identical WIN32OLE objects" do
+        book2 = Workbook.new(@book.ole_workbook)
+        book2.equal?(@book).should be true
+      end
+
+    end
+
+    context "connecting to one unknown workbook" do
+
+      before do
+        ole_e1 = WIN32OLE.new('Excel.Application')
+        ws = ole_e1.Workbooks
+        abs_filename = General.absolute_path(@simple_file_xlsm1)
+        @ole_wb = ws.Open(abs_filename)
+      end
+
+      it "should connect to an unknown workbook" do
+        Workbook.open(@simple_file_xlsm1) do |book|
+          book.filename.should == @simple_file_xlsm1
+          book.should be_alive
+          book.should be_a Workbook
+          book.excel.ole_excel.Hwnd.should == @ole_wb.Application.Hwnd
+          Excel.excels_number.should == 1
+        end
+      end
+    end
+
+    context "with :force => excel" do
+
+      before do
+        @book = Workbook.open(@simple_file_xlsm1)
+      end
+
+      it "should open in a new Excel" do
+        book2 = Workbook.open(@simple_file_xlsm1, :force => {:excel => :new})
+        book2.should be_alive
+        book2.should be_a Workbook
+        book2.excel.should_not == @book.excel 
+        book2.should_not == @book
+        @book.Readonly.should be false
+        book2.Readonly.should be true
+        book2.close
+      end
+
+    end
+
+    context "with :if_unsaved" do
+
+      before do
+        @book = Workbook.open(@simple_file_xlsm1)
+        @sheet = @book.sheet(1)
+        @book.add_sheet(@sheet, :as => 'a_name')
+        @book.visible = true
+      end
+
+      after do
+        @book.close(:if_unsaved => :forget)
+        @new_book.close rescue nil
+      end
+
+      it "should let the book open, if :if_unsaved is :accept" do
+        expect {
+          @new_book = Workbook.open(@simple_file_xlsm1, :if_unsaved => :accept)
+          }.to_not raise_error
+        @book.should be_alive
+        @new_book.should be_alive
+        @new_book.should == @book
+      end
+
+    end
+
+  end
+
   describe "open and new" do
 
     context "with standard" do
@@ -415,7 +610,7 @@ describe Workbook do
         Excel.excels_number.should == 1
         book1.ReadOnly.should be false
         book1.excel.Visible.should be false
-        book1.CheckCompatibility.should be false
+        book1.CheckCompatibility.should be true
         book1.Saved.should be true
       end
 
@@ -717,7 +912,7 @@ describe Workbook do
         excel1.close
         expect{
           book1 = Workbook.open(@simple_file1, :force => {:excel => excel1})
-          }.to raise_error(ExcelREOError, "excel is not alive")
+          }.to raise_error(ExcelREOError, "Excel is not alive")
       end
 
       it "should open in a provided Excel" do
@@ -836,7 +1031,26 @@ describe Workbook do
       book2.excel.should_not == book.excel
     end
 
-    it "should type-lift an open known workbook" do
+    it "should type-lift an workbook" do
+      book = Workbook.open(@simple_file)
+      new_book = Workbook.new(book)
+      new_book.should == book
+      new_book.equal?(book).should be true
+      new_book.Fullname.should == book.Fullname
+      new_book.excel.should == book.excel
+    end
+
+    it "should type-lift an workbook and supply option" do
+      book = Workbook.open(@simple_file)
+      new_book = Workbook.new(book, :visible => true)
+      new_book.should == book
+      new_book.equal?(book).should be true
+      new_book.Fullname.should == book.Fullname
+      new_book.excel.should == book.excel
+      new_book.visible.should be true
+    end
+
+    it "should type-lift an open known win32ole workbook" do
       book = Workbook.open(@simple_file)
       ole_workbook = book.ole_workbook
       new_book = Workbook.new(ole_workbook)
@@ -846,7 +1060,7 @@ describe Workbook do
       new_book.excel.should == book.excel
     end
 
-    it "should type-lift an open known workbook and let it be visible" do
+    it "should type-lift an open known win32ole workbook and let it be visible" do
       book = Workbook.open(@simple_file, :visible => true)
       ole_workbook = book.ole_workbook
       new_book = Workbook.new(ole_workbook)
@@ -858,7 +1072,7 @@ describe Workbook do
       new_book.Windows(new_book.ole_workbook.Name).Visible.should == true
     end
 
-    it "should type-lift an open known workbook and let it be visible and readonly" do
+    it "should type-lift an open known win32ole workbook and let it be visible and readonly" do
       book = Workbook.open(@simple_file, :visible => true, :read_only => true)
       ole_workbook = book.ole_workbook
       new_book = Workbook.new(ole_workbook)
@@ -871,7 +1085,7 @@ describe Workbook do
       new_book.ReadOnly.should == true
     end
 
-    it "should type-lift an open known workbook and make it visible" do
+    it "should type-lift an open known win32ole workbook and make it visible" do
       book = Workbook.open(@simple_file)
       ole_workbook = book.ole_workbook
       new_book = Workbook.new(ole_workbook, :visible => true)
@@ -883,7 +1097,7 @@ describe Workbook do
       new_book.Windows(new_book.ole_workbook.Name).Visible.should == true
     end
 
-    it "should type-lift an open unknown workbook" do
+    it "should type-lift an open unknown win32ole workbook" do
       ole_excel = WIN32OLE.new('Excel.Application')
       ws = ole_excel.Workbooks
       abs_filename = General.absolute_path(@simple_file1)
@@ -893,7 +1107,7 @@ describe Workbook do
       new_book.excel.Hwnd.should == ole_excel.Hwnd
     end
 
-    it "should type-lift an open unknown workbook and make it visible" do
+    it "should type-lift an open unknown win32ole workbook and make it visible" do
       ole_excel = WIN32OLE.new('Excel.Application')
       ws = ole_excel.Workbooks
       abs_filename = General.absolute_path(@simple_file1)
@@ -905,7 +1119,7 @@ describe Workbook do
       new_book.Windows(new_book.ole_workbook.Name).Visible.should == true
     end
 
-    it "should type-lift an open unknown workbook and make it visible and readonly" do
+    it "should type-lift an open unknown win32ole workbook and make it visible and readonly" do
       ole_excel = WIN32OLE.new('Excel.Application')
       ws = ole_excel.Workbooks
       abs_filename = General.absolute_path(@simple_file1)
@@ -1366,7 +1580,7 @@ describe Workbook do
       it "should raise an error if no Excel or Workbook is given" do
         expect{
           Workbook.open(@simple_file1, :force => {:excel => :b})
-          }.to raise_error(TypeREOError, "given object is neither an Excel, a Workbook, nor a Win32ole")
+          }.to raise_error(TypeREOError, @error_message_excel)
       end
 
       it "should do force_excel even if both force_ and default_excel is given" do
@@ -1522,7 +1736,7 @@ describe Workbook do
       it "should raise an error if no Excel or Workbook is given" do
         expect{
           Workbook.open(@simple_file1, :excel => :b)
-          }.to raise_error(TypeREOError, "given object is neither an Excel, a Workbook, nor a Win32ole")
+          }.to raise_error(TypeREOError, @error_message_excel)
       end
 
       it "should do force_excel even if both force_ and default_excel is given" do
@@ -1680,7 +1894,7 @@ describe Workbook do
       it "should raise an error if no Excel or Workbook is given" do
         expect{
           Workbook.open(@simple_file1, :force_excel => :b)
-          }.to raise_error(TypeREOError, "given object is neither an Excel, a Workbook, nor a Win32ole")
+          }.to raise_error(TypeREOError, @error_message_excel)
       end
 
       it "should do force_excel even if both force_ and default_excel is given" do
@@ -1921,7 +2135,7 @@ describe Workbook do
       it "should raise an error if no Excel or Workbook is given" do
         expect{
           Workbook.open(@different_file, :default => {:excel => :a})
-          }.to raise_error(TypeREOError, "given object is neither an Excel, a Workbook, nor a Win32ole")
+          }.to raise_error(TypeREOError, @error_message_excel)
       end
       
     end
@@ -2103,7 +2317,7 @@ describe Workbook do
       it "should raise an error if no Excel or Workbook is given" do
         expect{
           Workbook.open(@different_file, :default_excel => :a)
-          }.to raise_error(TypeREOError, "given object is neither an Excel, a Workbook, nor a Win32ole")
+          }.to raise_error(TypeREOError, @error_message_excel)
       end
       
     end