robust_excel_ole 1.16 → 1.17

data/lib/robust_excel_ole/worksheet.rb

@@ -12,7 +12,7 @@ module RobustExcelOle
   class Worksheet < RangeOwners
 
     attr_reader :ole_worksheet
-    #attr_reader :workbook
+    attr_reader :workbook
 
     def initialize(win32_worksheet)
       @ole_worksheet = win32_worksheet
@@ -28,17 +28,18 @@ module RobustExcelOle
     end
 
     def workbook
-      return @workbook unless @workbook.nil?
-      begin
+      @workbook ||= begin
         ole_workbook = self.Parent
         saved_status = ole_workbook.Saved
         ole_workbook.Saved = true unless saved_status
         @workbook = workbook_class.new(ole_workbook)
         ole_workbook.Saved = saved_status
-      rescue
-        nil
+        @workbook
       end
-      @workbook
+    end
+
+    def excel
+      workbook.excel
     end
 
     # sheet name
@@ -218,7 +219,6 @@ module RobustExcelOle
 
   private
 
-    # @private
     def method_missing(name, *args)
       if name.to_s[0,1] =~ /[A-Z]/
         if ::ERRORMESSAGE_JRUBY_BUG 

data/spec/address_tool_spec.rb

@@ -0,0 +1,175 @@
+# -*- coding: utf-8 -*-
+
+require File.join(File.dirname(__FILE__), './spec_helper')
+require File.expand_path( '../../lib/robust_excel_ole/base', __FILE__)
+
+$VERBOSE = nil
+
+include General
+include RobustExcelOle
+
+module RobustExcelOle
+
+  describe AddressTool do
+
+    before(:all) do
+      excel = Excel.new(:reuse => true)
+      open_books = excel == nil ? 0 : excel.Workbooks.Count
+      puts "*** open books *** : #{open_books}" if open_books > 0
+      Excel.kill_all
+      @dir = create_tmpdir
+      @simple_file = @dir + '/workbook.xls'
+      @workbook = Workbook.open(@simple_file)
+      @address_tool = @workbook.excel.address_tool
+    end
+
+    after(:all) do
+      @workbook.close
+    end
+
+    it "should transform relative r1c1-reference into r1c1-format" do
+      @address_tool.as_r1c1("Z1S[2]:Z[-1]S4").should == "Z1S(2):Z(-1)S4"
+      @address_tool.as_r1c1("Z[1]S2:Z3S[4]").should == "Z(1)S2:Z3S(4)"
+      @address_tool.as_r1c1("Z1S[2]").should == "Z1S(2)"
+      @address_tool.as_r1c1("Z[-1]S4").should == "Z(-1)S4"
+      @address_tool.as_r1c1("Z[3]").should == "Z(3)"
+      @address_tool.as_r1c1("S[-2]").should == "S(-2)"
+    end
+
+    # test for 1.8.6
+    it "should transform relative integer_ranges-format into r1c1-format" do
+      @address_tool.as_r1c1([1..2,[3]..4]).should == "Z1S(3):Z2S4"
+      @address_tool.as_r1c1([[1]..2,3..4]).should == "Z(1)S3:Z2S4"
+      @address_tool.as_r1c1([[1]..2,nil]).should == "Z(1):Z2"
+      @address_tool.as_r1c1([nil,[1]..2]).should == "S(1):S2"
+      @address_tool.as_r1c1([nil,[1]]).should == "S(1):S(1)"
+    end
+
+    it "should transform relative integer_ranges-format into r1c1-format" do
+      @address_tool.as_r1c1([1..[-2],[3]..4]).should == "Z1S(3):Z(-2)S4"
+      @address_tool.as_r1c1([[1]..2,3..[4]]).should == "Z(1)S3:Z2S(4)"
+      @address_tool.as_r1c1([1..[-2],nil]).should == "Z1:Z(-2)"
+      @address_tool.as_r1c1([nil,[-1]..2]).should == "S(-1):S2"
+      @address_tool.as_r1c1([[3]..[3],nil]).should == "Z(3):Z(3)"
+      @address_tool.as_r1c1([nil,[-2]..[-2]]).should == "S(-2):S(-2)"
+      @address_tool.as_r1c1([[3],nil]).should == "Z(3):Z(3)"
+    end
+
+    it "should transform relative r1c1-format into r1c1-format" do
+      @address_tool.as_integer_ranges("Z1S[2]:Z[3]S4").should == [1..[3],[2]..4]
+      @address_tool.as_integer_ranges("Z[1]S2:Z3S[4]").should == [[1]..3,2..[4]]
+      @address_tool.as_integer_ranges("Z1S[2]").should == [1..1,[2]..[2]]
+      @address_tool.as_integer_ranges("Z[3]S4").should == [[3]..[3],4..4]
+    end
+
+    it "should transform a1-format" do
+      @address_tool.as_a1("A2").should == "A2"
+      @address_tool.as_r1c1("A2").should == "Z2S1:Z2S1"
+      @address_tool.as_integer_ranges("A2").should == [2..2,1..1]
+    end
+
+    it "should transform several-letter-a1-format" do
+      @address_tool.as_a1("ABO15").should == "ABO15"
+      @address_tool.as_r1c1("ABO15").should == "Z15S743:Z15S743"
+      @address_tool.as_integer_ranges("ABO15").should == [15..15,743..743]
+    end
+
+    it "should transform complex a1-format" do
+      @address_tool.as_a1("A2:B3").should == "A2:B3"
+      @address_tool.as_r1c1("A2:B3").should == "Z2S1:Z3S2"
+      @address_tool.as_integer_ranges("A2:B3").should == [2..3,1..2]
+      @address_tool.as_a1("S1:DP2").should == "S1:DP2"
+      @address_tool.as_r1c1("S1:DP2").should == "Z1S19:Z2S120"
+      @address_tool.as_integer_ranges("S1:DP2").should == [1..2,19..120]
+    end
+
+    it "should transform infinite a1-format" do
+      @address_tool.as_a1("A:B").should == "A:B"
+      @address_tool.as_r1c1("A:B").should == "S1:S2"
+      @address_tool.as_integer_ranges("A:B").should == [nil,1..2]
+      @address_tool.as_a1("1:3").should == "1:3"
+      @address_tool.as_r1c1("1:3").should == "Z1:Z3"
+      @address_tool.as_integer_ranges("1:3").should == [1..3,nil]
+      @address_tool.as_a1("B").should == "B"
+      @address_tool.as_r1c1("B").should == "S2:S2"
+      @address_tool.as_integer_ranges("B").should == [nil,2..2]
+      @address_tool.as_a1("3").should == "3"
+      @address_tool.as_r1c1("3").should == "Z3:Z3"
+      @address_tool.as_integer_ranges("3").should == [3..3,nil]
+    end
+
+    it "should transform r1c1-format" do
+      @address_tool.as_r1c1("Z2S1").should == "Z2S1"
+      @address_tool.as_integer_ranges("Z2S1").should == [2..2,1..1]
+      expect{
+        @address_tool.as_a1("Z2S1")
+      }.to raise_error(NotImplementedREOError)
+    end
+
+    it "should transform complex r1c1-format" do
+      @address_tool.as_r1c1("Z2S1:Z3S2").should == "Z2S1:Z3S2"
+      @address_tool.as_integer_ranges("Z2S1:Z3S2").should == [2..3,1..2]
+    end
+
+    it "should transform as_integer_ranges format" do
+      @address_tool.as_integer_ranges([2..2,1..1]).should == [2..2,1..1]
+      @address_tool.as_r1c1([2..2,1..1]).should == "Z2S1:Z2S1"
+      expect{
+        @address_tool.as_a1([2..2,1..1])
+      }.to raise_error(NotImplementedREOError)
+    end
+
+    it "should transform simple as_integer_ranges format" do
+      @address_tool.as_integer_ranges([2,1]).should == [2..2,1..1]
+      @address_tool.as_r1c1([2,1]).should == "Z2S1:Z2S1"
+    end
+
+    it "should transform complex as_integer_ranges format" do
+      @address_tool.as_integer_ranges([2,"A"]).should == [2..2,1..1]
+      @address_tool.as_r1c1([2,"A"]).should == "Z2S1:Z2S1"
+      @address_tool.as_integer_ranges([2,"A".."B"]).should == [2..2,1..2]
+      @address_tool.as_r1c1([2,"A".."B"]).should == "Z2S1:Z2S2"
+      @address_tool.as_integer_ranges([1..2,"C"]).should == [1..2,3..3]
+      @address_tool.as_r1c1([1..2,"C"]).should == "Z1S3:Z2S3"
+      @address_tool.as_integer_ranges([1..2,"C".."E"]).should == [1..2,3..5]
+      @address_tool.as_r1c1([1..2,"C".."E"]).should == "Z1S3:Z2S5"
+      @address_tool.as_integer_ranges([2,3..5]).should == [2..2,3..5]
+      @address_tool.as_r1c1([2,3..5]).should == "Z2S3:Z2S5"
+      @address_tool.as_integer_ranges([1..2,3..5]).should == [1..2,3..5]
+      @address_tool.as_r1c1([1..2,3..5]).should == "Z1S3:Z2S5"
+    end
+
+    it "should transform infinite as_integer_ranges format" do
+      @address_tool.as_integer_ranges([nil,1..2]).should == [nil,1..2]
+      @address_tool.as_r1c1([nil,1..2]).should == "S1:S2"
+      @address_tool.as_integer_ranges([1..3,nil]).should == [1..3,nil]
+      @address_tool.as_r1c1([1..3,nil]).should == "Z1:Z3"
+      @address_tool.as_integer_ranges([nil,2]).should == [nil,2..2]
+      @address_tool.as_r1c1([nil,2]).should == "S2:S2"
+      @address_tool.as_integer_ranges([3,nil]).should == [3..3,nil]
+      @address_tool.as_r1c1([3,nil]).should == "Z3:Z3"
+    end
+  
+    it "should raise an error" do
+      expect{
+        @address_tool.as_a1("1A")
+      }.to raise_error(AddressInvalid, /format not correct/)
+      expect{
+        @address_tool.as_r1c1("A1B")
+      }.to raise_error(AddressInvalid, /format not correct/)
+      #expect{
+      #  @address_tool.as_integer_ranges(["A".."B","C".."D"])
+      #}.to raise_error(AddressInvalid, /format not correct/)
+      #expect{
+      #  @address_tool.as_integer_ranges(["A".."B",1..2])
+      #}.to raise_error(AddressInvalid, /format not correct/)
+      #expect{
+      #  @address_tool.as_integer_ranges(["A".."B",nil])
+      #}.to raise_error(AddressInvalid, /format not correct/)
+      expect{
+        @address_tool.as_integer_ranges(["A",1,2])
+      }.to raise_error(AddressInvalid, /more than two components/)
+    end
+
+  end
+end

data/spec/{reo_common_spec.rb → base_spec.rb}

@@ -1,7 +1,7 @@
 # -*- coding: utf-8 -*-
 
 require File.join(File.dirname(__FILE__), './spec_helper')
-require File.expand_path( '../../lib/robust_excel_ole/reo_common', __FILE__)
+require File.expand_path( '../../lib/robust_excel_ole/base', __FILE__)
 
 $VERBOSE = nil
 
@@ -10,7 +10,7 @@ include RobustExcelOle
 
 module RobustExcelOle
 
-  describe REOCommon do
+  describe Base do
 
     before(:all) do
       excel = Excel.new(:reuse => true)
@@ -40,12 +40,12 @@ module RobustExcelOle
 
       it "should put some number" do
         a = 4
-        REOCommon::trace "some text #{a}"
+        Base::trace "some text #{a}"
       end
 
       it "should put another text" do
         b = Workbook.open(@simple_file)
-        REOCommon::trace "book: #{b}"
+        Base::trace "book: #{b}"
       end
     end
 
@@ -82,45 +82,26 @@ module RobustExcelOle
 
     end
 
-    describe "Object methods" do
-
-      before do
-        @book = Workbook.open(@simple_file)
-        @sheet = @book.sheet(1)
-      end
-
-      before do
-        @book.close
-      end
-
-      it "should raise an error when asking excel of a sheet" do
-        expect{
-          @sheet.excel
-          }.to raise_error(TypeREOError, "receiver instance is neither an Excel nor a Workbook")
-      end
-
-    end
-
     describe "misc" do
 
       it "should" do
 
         LOG_TO_STDOUT = true
-        REOCommon::trace "foo"
+        Base::trace "foo"
 
         LOG_TO_STDOUT = false
-        REOCommon::trace "foo"
+        Base::trace "foo"
 
         REO_LOG_DIR = ""
-        REOCommon::trace "foo"
+        Base::trace "foo"
 
         #REO_LOG_DIR = "C:"
-        #REOCommon::trace "foo"
+        #Base::trace "foo"
 
-        REOCommon::tr1 "foo"
+        Base::tr1 "foo"
 
         h = {:a => {:c => 4}, :b => 2}
-        REOCommon::puts_hash(h)
+        Base::puts_hash(h)
 
       end
  

data/spec/cell_spec.rb

@@ -15,54 +15,66 @@ describe Cell do
 
   before do
     @dir = create_tmpdir
+    @simple_file = @dir + '/workbook.xls'
+    @merge_cells_file = @dir + '/merge_cells.xls'
+    @book = Workbook.open(@simple_file)
+    @sheet = @book.sheet(1)
+    @cell = @sheet[1, 1]
   end
 
   after do
+    Excel.kill_all
     rm_tmp(@dir)
   end
 
-  context "open simple.xls" do
-    before do
-      @book = Workbook.open(@dir + '/workbook.xls', :read_only => true)
-      @sheet = @book.sheet(2)
-      @cell = @sheet[1, 1]
+
+  describe "values" do
+
+    it "should yield one element values" do
+      @cell.values.should == ["foo"]
     end
 
-    after do
-      @book.close
+  end
+
+  describe "#[]" do
+
+    it "should access to the cell itself" do
+      @cell[0].should be_kind_of RobustExcelOle::Cell
+      @cell[0].v.should == "foo"
     end
 
-    describe "#value" do
-      it "get cell's value" do
-        @cell.Value.should eq 'simple'
-      end
+    it "should access to the cell itself" do
+      @cell[1].should be_kind_of RobustExcelOle::Cell
+      @cell[1].v.should == 'foo'
     end
+    
+  end
 
-    describe "#value=" do
-      it "change cell data to 'fooooo'" do
-        @cell.Value = 'fooooo'
-        @cell.Value.should eq 'fooooo'
-      end
+  describe "#copy" do
+  
+    before do
+      @book1 = Workbook.open(@dir + '/workbook.xls')
+      @sheet1 = @book1.sheet(1)
+      @cell1 = @sheet1[1,1]
     end
 
-    describe "#method_missing" do
-      context "unknown method" do
-        it { expect { @cell.hogehogefoo }.to raise_error }
-      end
+    after do
+      @book1.close(:if_unsaved => :forget)
     end
 
+    it "should copy range" do
+      @cell1.copy([2,3])
+      @sheet1.range([1..2,1..3]).v.should == [["foo", "workbook", "sheet1"],["foo", nil, "foo"]]
+    end
   end
 
   context "open merge_cells.xls" do
+ 
     before do
-      @book = Workbook.open(@dir + '/merge_cells.xls', :read_only => true)
+      @book = Workbook.open(@merge_cells_file, :read_only => true)
       @sheet = @book.sheet(1)
     end
 
-    after do
-      @book.close
-    end
-
     it "merged cell get same value" do
       @sheet[1, 1].Value.should be_nil
       @sheet[2, 1].Value.should eq 'first merged'
@@ -74,4 +86,34 @@ describe Cell do
       @sheet[2, 2].Value.should eq "set merge cell"
     end
   end
+
+  describe "==" do
+
+    it "should check equality of cells" do
+      @cell.should == @sheet[1,1]
+      @cell.should_not == @sheet[1,2]
+    end
+
+  end
+
+  describe "#Value" do
+    it "get cell's value" do
+      @cell.Value.should eq 'foo'
+    end
+  end
+
+  describe "#Value=" do
+    it "change cell data to 'fooooo'" do
+      @cell.Value = 'fooooo'
+      @cell.Value.should eq 'fooooo'
+    end
+  end
+
+  describe "#method_missing" do
+    context "unknown method" do
+      it { expect { @cell.hogehogefoo }.to raise_error(NoMethodError) }
+    end
+  end
+
 end
+

data/spec/excel_spec.rb

@@ -23,6 +23,11 @@ module RobustExcelOle
       @invalid_name_file = 'b/workbook.xls'
       @simple_file1 = @simple_file
       @different_file1 = @different_file
+      @error_unsaved_workbooks = "Excel contains unsaved workbooks" +
+              "\nHint: Use option :if_unsaved with values :forget and :save to close the 
+           Excel instance without or with saving the unsaved workbooks before, respectively"
+      @error_invalid_option = ":if_unsaved: invalid option: :invalid_option" +
+              "\nHint: Valid values are :raise, :forget, :save and :alert"
     end
 
     after do
@@ -627,15 +632,13 @@ module RobustExcelOle
             @excel2 = book2.excel
             sheet2 = book2.sheet(1)
             @old_cell_value2 = sheet2[1,1].Value
-            sheet2[1,1] = sheet2[1,1].Value == "foo" ? "bar" : "foo"
+            sheet2[1,1] = sheet2[1,1].Value == "foo" ? "bar" : "foo"            
           end
 
           it "should close the first Excel without unsaved workbooks and then raise an error" do
             expect{
               Excel.close_all(:if_unsaved => :raise)
-            }.to raise_error(UnsavedWorkbooks, "Excel contains unsaved workbooks" +
-              "\nHint: Use option :if_unsaved with values :forget and :save to close the 
-           Excel instance without or with saving the unsaved workbooks before, respectively")
+            }.to raise_error(UnsavedWorkbooks, @error_unsaved_workbooks)
             sleep 0.2
             @excel1.should_not be_alive
             @excel2.should be_alive
@@ -648,9 +651,7 @@ module RobustExcelOle
           it "should close the first Excel without unsaved workbooks and then raise an error" do
             expect{
               Excel.close_all
-            }.to raise_error(UnsavedWorkbooks, "Excel contains unsaved workbooks" +
-              "\nHint: Use option :if_unsaved with values :forget and :save to close the 
-           Excel instance without or with saving the unsaved workbooks before, respectively")
+            }.to raise_error(UnsavedWorkbooks, @error_unsaved_workbooks)
             sleep 0.2
             @excel1.should_not be_alive
             @excel2.should be_alive
@@ -687,8 +688,7 @@ module RobustExcelOle
           it "should raise an error for invalid option" do
             expect {
               Excel.close_all(:if_unsaved => :invalid_option)
-            }.to raise_error(OptionInvalid, ":if_unsaved: invalid option: :invalid_option" +
-              "\nHint: Valid values are :raise, :forget, :save and :alert") 
+            }.to raise_error(OptionInvalid, @error_invalid_option) 
           end
         end
 
@@ -705,9 +705,7 @@ module RobustExcelOle
           it "should close the 1st and 3rd Excel instances that have saved workbooks" do  
             expect{
               Excel.close_all(:if_unsaved => :raise)
-            }.to raise_error(UnsavedWorkbooks, "Excel contains unsaved workbooks" +
-              "\nHint: Use option :if_unsaved with values :forget and :save to close the 
-           Excel instance without or with saving the unsaved workbooks before, respectively")
+            }.to raise_error(UnsavedWorkbooks, @error_unsaved_workbooks)
             sleep 0.2
             @book1.excel.should_not be_alive
             @book2.excel.should be_alive
@@ -732,9 +730,7 @@ module RobustExcelOle
           it "should close three Excel instances that have saved workbooks" do  
             expect{
               Excel.close_all(:if_unsaved => :raise)
-            }.to raise_error(UnsavedWorkbooks, "Excel contains unsaved workbooks" +
-              "\nHint: Use option :if_unsaved with values :forget and :save to close the 
-           Excel instance without or with saving the unsaved workbooks before, respectively")
+            }.to raise_error(UnsavedWorkbooks, @error_unsaved_workbooks)
             sleep 0.2
             expect{
               @ole_xl.Name
@@ -812,17 +808,13 @@ module RobustExcelOle
         it "should raise an error" do
           expect{
             @excel.close(:if_unsaved => :raise)
-          }.to raise_error(UnsavedWorkbooks, "Excel contains unsaved workbooks" +
-            "\nHint: Use option :if_unsaved with values :forget and :save to close the 
-           Excel instance without or with saving the unsaved workbooks before, respectively")
+          }.to raise_error(UnsavedWorkbooks, @error_unsaved_workbooks)
         end        
 
         it "should raise an error per default" do
           expect{
             @excel.close(:if_unsaved => :raise)
-          }.to raise_error(UnsavedWorkbooks, "Excel contains unsaved workbooks" +
-            "\nHint: Use option :if_unsaved with values :forget and :save to close the 
-           Excel instance without or with saving the unsaved workbooks before, respectively")
+          }.to raise_error(UnsavedWorkbooks, @error_unsaved_workbooks)
         end        
 
         it "should close the Excel without saving the workbook" do
@@ -865,8 +857,7 @@ module RobustExcelOle
         it "should raise an error for invalid option" do
           expect {
             @excel.close(:if_unsaved => :invalid_option)
-          }.to raise_error(OptionInvalid, ":if_unsaved: invalid option: :invalid_option" +
-            "\nHint: Valid values are :raise, :forget, :save and :alert") 
+          }.to raise_error(OptionInvalid, @error_invalid_option) 
         end
       end
 
@@ -955,18 +946,13 @@ module RobustExcelOle
         it "should raise error" do
           expect{
             @excel.close_workbooks(:if_unsaved => :raise)
-          }.to raise_error(UnsavedWorkbooks, "Excel contains unsaved workbooks" +
-          "\nHint: Use option :if_unsaved with values :forget and :save to close the 
-           Excel instance without or with saving the unsaved workbooks before, respectively" )
-
+          }.to raise_error(UnsavedWorkbooks, @error_unsaved_workbooks)
         end
 
         it "should raise error per default" do
           expect{
             @excel.close_workbooks
-          }.to raise_error(UnsavedWorkbooks, "Excel contains unsaved workbooks" +
-            "\nHint: Use option :if_unsaved with values :forget and :save to close the 
-           Excel instance without or with saving the unsaved workbooks before, respectively")
+          }.to raise_error(UnsavedWorkbooks, @error_unsaved_workbooks)
         end
 
         it "should close the workbook with forgetting the workbook" do
@@ -994,8 +980,7 @@ module RobustExcelOle
         it "should raise an error for invalid option" do
           expect {
             @excel.close_workbooks(:if_unsaved => :invalid_option)
-          }.to raise_error(OptionInvalid, ":if_unsaved: invalid option: :invalid_option" +
-            "\nHint: Valid values are :raise, :forget, :save and :alert") 
+          }.to raise_error(OptionInvalid, @error_invalid_option) 
         end
       end
     end
@@ -1925,14 +1910,14 @@ module RobustExcelOle
         @excel2.Hwnd.should == @excel2.hwnd
       end
 
-      it "should provide the same excel instances" do
-        @excel1.should_not == @excel2
-        excel3 = Excel.hwnd2excel(@excel1.hwnd)
-        excel4 = Excel.hwnd2excel(@excel2.hwnd)
-        @excel1.should == excel3
-        @excel2.should == excel4
-        excel3.should_not == excel4
-      end
+   #   it "should provide the same excel instances" do
+   #     @excel1.should_not == @excel2
+   #     excel3 = Excel.hwnd2excel(@excel1.hwnd)
+   #     excel4 = Excel.hwnd2excel(@excel2.hwnd)
+   #     @excel1.should == excel3
+   #     @excel2.should == excel4
+   #     excel3.should_not == excel4
+   #   end
 
 =begin
       # does not work yet
@@ -2018,239 +2003,6 @@ module RobustExcelOle
 
       end
     end
-
-    context "setting the name of a range" do
-
-       before do
-        @book1 = Workbook.open(@dir + '/another_workbook.xls', :read_only => true, :visible => true)
-        @book1.excel.displayalerts = false
-        @excel1 = @book1.excel
-      end
-
-      after do
-        @book1.close
-      end   
-
-      it "should name an unnamed range with a giving address" do
-        @excel1.add_name("foo",[1,2])
-        @excel1.Names.Item("foo").Name.should == "foo"
-        @excel1.Names.Item("foo").Value.should == "=Sheet1!$B$1:$B$1"
-      end
-
-      it "should rename an already named range with a giving address" do
-        @excel1.add_name("foo",[1,1])
-        @excel1.Names.Item("foo").Name.should == "foo"
-        @excel1.Names.Item("foo").Value.should == "=Sheet1!$A$1:$A$1"
-      end
-
-      it "should raise an error" do
-        expect{
-          @excel1.add_name("foo", [-2, 1])
-        }.to raise_error(RangeNotEvaluatable, /cannot add name "foo" to range/)
-      end
-
-      it "should rename a range" do
-        @excel1.add_name("foo",[1,1])
-        @excel1.rename_range("foo","bar")
-        @excel1.namevalue_glob("bar").should == "foo"
-      end
-
-      it "should delete a name of a range" do
-        @excel1.add_name("foo",[1,1])
-        @excel1.delete_name("foo")
-        expect{
-          @excel1.namevalue_glob("foo")
-        }.to raise_error(NameNotFound, /name "foo"/)
-      end
-
-      it "should add a name of a rectangular range" do
-        @excel1.add_name("foo",[1..3,1..4])
-        @excel1["foo"].should == [["foo", "workbook", "sheet1", nil], ["foo", 1.0, 2.0, 4.0], ["matz", 3.0, 4.0, 4.0]] 
-      end
-
-      it "should accept the old interface" do
-        @excel1.add_name("foo",1..3,1..4)
-        @excel1["foo"].should == [["foo", "workbook", "sheet1", nil], ["foo", 1.0, 2.0, 4.0], ["matz", 3.0, 4.0, 4.0]] 
-      end
-
-      it "should add a name of an infinite row range" do
-        @excel1.add_name("foo",[1..3, nil])
-        @excel1.Names.Item("foo").Value.should == "=Sheet1!$1:$3"
-      end
-
-      it "should add a name of an infinite column range" do
-        @excel1.add_name("foo",[nil, "A".."C"])
-        @excel1.Names.Item("foo").Value.should == "=Sheet1!$A:$C"
-      end
-
-      it "should add a name of an infinite row range" do
-        @excel1.add_name("foo",[nil, 1..3])
-        @excel1.Names.Item("foo").Value.should == "=Sheet1!$A:$C"
-      end
-
-      it "should add a name of an infinite column range" do
-        @excel1.add_name("foo",["A:C"])
-        @excel1.Names.Item("foo").Value.should == "=Sheet1!$A:$C"
-      end
-
-      it "should add a name of an infinite column range" do
-        @excel1.add_name("foo",["1:2"])
-        @excel1.Names.Item("foo").Value.should == "=Sheet1!$1:$2"
-      end
-
-    end
-
-    describe "namevalue_glob, set_namevalue_glob" do
-
-      before do
-        @book1 = Workbook.open(@dir + '/another_workbook.xls')
-        @book1.Windows(@book1.Name).Visible = true
-        @excel1 = @book1.excel
-      end
-
-      after do
-        @book1.close(:if_unsaved => :forget)
-      end   
-
-      it "should return value of a defined name" do
-        @excel1.namevalue_glob("firstcell").should == "foo"
-        @excel1["firstcell"].should == "foo"
-      end        
-
-      #it "should evaluate a formula" do
-      #  @excel1.namevalue_glob("named_formula").should == 4
-      #  @excel1["named_formula"].should == 4
-      #end
-
-      it "should raise an error if name not defined" do
-        expect {
-          @excel1.namevalue_glob("foo")
-        }.to raise_error(NameNotFound, /name "foo"/)
-        expect {
-        @excel1["foo"]
-        }.to raise_error(NameNotFound, /name "foo"/)
-        expect {
-          excel2 = Excel.create
-          excel2.namevalue_glob("one")
-        }.to raise_error(NameNotFound, /name "one"/)
-        expect {
-          excel3 = Excel.create(:visible => true)
-          excel3["one"]
-        }.to raise_error(NameNotFound, /name "one"/)
-      end
-
-      it "should set a range to a value" do
-        @excel1.namevalue_glob("firstcell").should == "foo"
-        @excel1.set_namevalue_glob("firstcell","bar")
-        @excel1.namevalue_glob("firstcell").should == "bar"
-        @excel1["firstcell"] = "foo"
-        @excel1.namevalue_glob("firstcell").should == "foo"
-      end
-
-      it "should raise an error if name cannot be evaluated" do
-        expect{
-          @excel1.set_namevalue_glob("foo", 1)
-          }.to raise_error(RangeNotEvaluatable, /cannot assign value to range named "foo"/)
-        expect{
-          @excel1["foo"] = 1
-          }.to raise_error(RangeNotEvaluatable, /cannot assign value to range named "foo"/)
-      end
-
-      it "should color the cell (deprecated)" do
-        @excel1.set_namevalue_glob("firstcell", "foo")
-        @book1.Names.Item("firstcell").RefersToRange.Interior.ColorIndex.should == -4142 
-        @excel1.set_namevalue_glob("firstcell", "foo", :color => 4)
-        @book1.Names.Item("firstcell").RefersToRange.Interior.ColorIndex.should == 4
-        @excel1["firstcell"].should == "foo"
-        @excel1["firstcell"] = "foo"
-        @excel1.Names.Item("firstcell").RefersToRange.Interior.ColorIndex.should == 42
-        @book1.save
-      end
-
-      it "should color the cell" do
-        @excel1.set_namevalue_glob("firstcell", "foo")
-        @book1.Names.Item("firstcell").RefersToRange.Interior.ColorIndex.should == -4142 
-        @excel1.set_namevalue_glob("firstcell", "foo", :color => 4)
-        @book1.Names.Item("firstcell").RefersToRange.Interior.ColorIndex.should == 4
-        @excel1["firstcell"].should == "foo"
-        @excel1["firstcell"] = "foo"
-        @excel1.Names.Item("firstcell").RefersToRange.Interior.ColorIndex.should == 42
-        @book1.save
-      end
-
-
-    end
-
-    describe "namevalue, set_namevalue" do
-      
-      before do
-        @book1 = Workbook.open(@another_simple_file)
-        @excel1 = @book1.excel
-        # for some reason the workbook must be visible
-        @book1.visible = true
-      end
-
-      after do
-        @book1.close(:if_unsaved => :forget)
-      end   
-
-      it "should return value of a locally defined name" do
-        @excel1.namevalue("firstcell").should == "foo"          
-      end        
-
-      it "should return value of a defined name" do
-        @excel1.namevalue("new").should == "foo"         
-        @excel1.namevalue("one").should == 1.0    
-        @excel1.namevalue("four").should == [[1,2],[3,4]]
-        @excel1.namevalue("firstrow").should == [[1,2]]
-      end    
-
-      it "should return default value if name not defined and default value is given" do
-        @excel1.namevalue("foo", :default => 2).should == 2
-      end
-
-      it "should raise an error if name not defined for the sheet" do
-        expect {
-          @excel1.namevalue("foo")
-          }.to raise_error(NameNotFound, /name "foo" not in/)
-        expect {
-          @excel1.namevalue("named_formula")
-          }.to raise_error(NameNotFound, /name "named_formula" not in/)
-        expect {
-          excel2 = Excel.create
-          excel2.namevalue("one")
-        }.to raise_error(NameNotFound, /name "one" not in/)
-      end
-    
-      it "should set a range to a value" do
-        @excel1.namevalue("firstcell").should == "foo"
-        @excel1.set_namevalue("firstcell","bar")
-        @excel1.namevalue("firstcell").should == "bar"
-      end
-
-      it "should raise an error if name cannot be evaluated" do
-        expect{
-          @excel1.set_namevalue_glob("foo", 1)
-        }.to raise_error(RangeNotEvaluatable, /cannot assign value to range named "foo" in/)
-      end
-
-      it "should color the cell (depracated)" do
-        @excel1.set_namevalue("firstcell", "foo")
-        @book1.Names.Item("firstcell").RefersToRange.Interior.ColorIndex.should == -4142 
-        @excel1.set_namevalue("firstcell", "foo", :color => 4)
-        @book1.Names.Item("firstcell").RefersToRange.Interior.ColorIndex.should == 4
-      end
-
-      it "should color the cell" do
-        @excel1.set_namevalue("firstcell", "foo")
-        @book1.Names.Item("firstcell").RefersToRange.Interior.ColorIndex.should == -4142 
-        @excel1.set_namevalue("firstcell", "foo", :color => 4)
-        @book1.Names.Item("firstcell").RefersToRange.Interior.ColorIndex.should == 4
-      end
-
-
-    end
-
   end
 end