right_amqp 0.2.0

data/lib/right_amqp/mq/rpc.rb

@@ -0,0 +1,100 @@
+class MQ
+  # Basic RPC (remote procedure call) facility.
+  #
+  # Needs more detail and explanation.
+  #
+  #  EM.run do
+  #    server = MQ.rpc('hash table node', Hash)
+  #
+  #    client = MQ.rpc('hash table node')
+  #    client[:now] = Time.now
+  #    client[:one] = 1
+  #
+  #    client.values do |res|
+  #      p 'client', :values => res
+  #    end
+  #
+  #    client.keys do |res|
+  #      p 'client', :keys => res
+  #      EM.stop_event_loop
+  #    end
+  #  end
+  #
+  class RPC < BlankSlate
+    # Takes a channel, queue and optional object.
+    #
+    # The optional object may be a class name, module name or object
+    # instance. When given a class or module name, the object is instantiated
+    # during this setup. The passed queue is automatically subscribed to so
+    # it passes all messages (and their arguments) to the object.
+    #
+    # Marshalling and unmarshalling the objects is handled internally. This
+    # marshalling is subject to the same restrictions as defined in the
+    # Marshal[http://ruby-doc.org/core/classes/Marshal.html] standard
+    # library. See that documentation for further reference.
+    #
+    # When the optional object is not passed, the returned rpc reference is
+    # used to send messages and arguments to the queue. See #method_missing
+    # which does all of the heavy lifting with the proxy. Some client
+    # elsewhere must call this method *with* the optional block so that
+    # there is a valid destination. Failure to do so will just enqueue
+    # marshalled messages that are never consumed.
+    #
+    def initialize mq, queue, obj = nil
+      @mq = mq
+      @mq.rpcs[queue] ||= self
+
+      if obj
+        @obj = case obj
+               when ::Class
+                 obj.new
+               when ::Module
+                 (::Class.new do include(obj) end).new
+               else
+                 obj
+               end
+
+        @mq.queue(queue).subscribe(:ack=>true){ |info, request|
+          method, *args = ::Marshal.load(request)
+          ret = @obj.__send__(method, *args)
+
+          info.ack
+
+          if info.reply_to
+            @mq.queue(info.reply_to).publish(::Marshal.dump(ret), :key => info.reply_to, :message_id => info.message_id)
+          end
+        }
+      else
+        @callbacks ||= {}
+        # XXX implement and use queue(nil)
+        @queue = @mq.queue(@name = "random identifier #{::Kernel.rand(999_999_999_999)}", :auto_delete => true).subscribe{|info, msg|
+          if blk = @callbacks.delete(info.message_id)
+            blk.call ::Marshal.load(msg)
+          end
+        }
+        @remote = @mq.queue(queue)
+      end
+    end
+
+    # Calling MQ.rpc(*args) returns a proxy object without any methods beyond
+    # those in Object. All calls to the proxy are handled by #method_missing which
+    # works to marshal and unmarshal all method calls and their arguments.
+    #
+    #  EM.run do
+    #    server = MQ.rpc('hash table node', Hash)
+    #    client = MQ.rpc('hash table node')
+    #
+    #    # calls #method_missing on #[] which marshals the method name and
+    #    # arguments to publish them to the remote
+    #    client[:now] = Time.now
+    #    ....
+    #  end
+    #
+    def method_missing meth, *args, &blk
+      # XXX use uuids instead
+      message_id = "random message id #{::Kernel.rand(999_999_999_999)}"
+      @callbacks[message_id] = blk if blk
+      @remote.publish(::Marshal.dump([meth, *args]), :reply_to => blk ? @name : nil, :message_id => message_id)
+    end
+  end
+end

data/right_amqp.gemspec

@@ -0,0 +1,57 @@
+# -*-ruby-*-
+# Copyright: Copyright (c) 2012 RightScale, Inc.
+#
+# Permission is hereby granted, free of charge, to any person obtaining
+# a copy of this software and associated documentation files (the
+# 'Software'), to deal in the Software without restriction, including
+# without limitation the rights to use, copy, modify, merge, publish,
+# distribute, sublicense, and/or sell copies of the Software, and to
+# permit persons to whom the Software is furnished to do so, subject to
+# the following conditions:
+#
+# The above copyright notice and this permission notice shall be
+# included in all copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED 'AS IS', WITHOUT WARRANTY OF ANY KIND,
+# EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+# MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
+# IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
+# CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
+# TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
+# SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+
+require 'rubygems'
+
+Gem::Specification.new do |spec|
+  spec.name      = 'right_amqp'
+  spec.version   = '0.2.0'
+  spec.authors   = ['Lee Kirchhoff']
+  spec.email     = 'lee@rightscale.com'
+  spec.homepage  = 'https://github.com/rightscale/right_amqp'
+  spec.platform  = Gem::Platform::RUBY
+  spec.summary   = 'Client for interfacing to RightScale RabbitMQ broker using AMQP'
+  spec.has_rdoc  = true
+  spec.rdoc_options = ["--main", "README.rdoc", "--title", "RightAMQP"]
+  spec.extra_rdoc_files = ["README.rdoc"]
+  spec.required_ruby_version = '>= 1.8.7'
+  spec.require_path = 'lib'
+
+  spec.add_dependency('right_support', '~> 1.2')
+  spec.add_dependency('eventmachine', '~> 0.12.10')
+
+  spec.description = <<-EOF
+RightAMQP provides a high availability client for interfacing with the
+RightScale RabbitMQ broker using the AMQP protocol. The AMQP version on which
+this gem is based is 0.6.7 but beyond that it contains a number of bug fixes and
+enhancements including reconnect, message return, heartbeat, and UTF-8 support.
+The high availability is achieved by maintaining multiple broker connections
+such that failed connections automatically reconnect and only connected
+brokers are used when routing a message. Although the HABrokerClient class
+is the intended primary means for accessing RabbitMQ services with this gem,
+alternatively the underlying AMQP services may be used directly.
+EOF
+
+  candidates = Dir.glob("{lib,spec}/**/*") +
+               ["LICENSE", "README.rdoc", "Rakefile", "right_amqp.gemspec"]
+  spec.files = candidates.sort
+end

data/spec/amqp/client_reconnect_spec.rb

@@ -0,0 +1,105 @@
+#
+# Copyright (c) 2009-2012 RightScale Inc
+#
+# Permission is hereby granted, free of charge, to any person obtaining
+# a copy of this software and associated documentation files (the
+# "Software"), to deal in the Software without restriction, including
+# without limitation the rights to use, copy, modify, merge, publish,
+# distribute, sublicense, and/or sell copies of the Software, and to
+# permit persons to whom the Software is furnished to do so, subject to
+# the following conditions:
+#
+# The above copyright notice and this permission notice shall be
+# included in all copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+# EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+# MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+# NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
+# LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
+# OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
+# WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+
+require File.expand_path(File.join(File.dirname(__FILE__), '..', 'spec_helper'))
+require File.expand_path(File.join(File.dirname(__FILE__), '..', '..', 'lib', 'right_amqp'))
+
+describe AMQP::Client do
+
+  context 'with an incorrect AMQP password' do
+
+    include RightAMQP::SpecHelper
+
+    class SUT
+      include AMQP::Client
+
+      attr_accessor :reconnecting, :settings, :channels
+    end
+
+    before(:each) do
+      setup_logger
+      @sut = flexmock(SUT.new)
+      @sut.reconnecting = false
+      @sut.settings = {:host => 'testhost', :port=>'12345'}
+      @sut.channels = {}
+
+      @sut.should_receive(:initialize)
+    end
+
+    context 'and no :reconnect_delay' do
+      it 'should reconnect immediately' do
+        flexmock(EM).should_receive(:reconnect).once
+        flexmock(EM).should_receive(:add_timer).never
+
+        @sut.reconnect()
+      end
+    end
+
+    context 'and a :reconnect_delay of true' do
+      it 'should reconnect immediately' do
+        @sut.settings[:reconnect_delay] = true
+
+        flexmock(EM).should_receive(:reconnect).once
+        flexmock(EM).should_receive(:add_timer).never
+
+        @sut.reconnect()
+      end
+    end
+
+    context 'and a :reconnect_delay of 15 seconds' do
+      it 'should schedule a reconnect attempt in 15s' do
+        @sut.settings[:reconnect_delay] = 15
+
+        flexmock(EM).should_receive(:reconnect).never
+        flexmock(EM).should_receive(:add_timer).with(15, Proc).once
+
+        @sut.reconnect()
+      end
+    end
+
+    context 'and a :reconnect_delay containing a Proc that returns 30' do
+      it 'should schedule a reconnect attempt in 30s' do
+        @sut.settings[:reconnect_delay] = Proc.new {30}
+
+        flexmock(EM).should_receive(:reconnect).never
+        flexmock(EM).should_receive(:add_timer).with(30, Proc).once
+
+        @sut.reconnect()
+      end
+    end
+
+    context 'and a :reconnect_interval of 5 seconds'  do
+      it 'should schedule reconnect attempts on a 5s interval' do
+        @sut.reconnecting = true
+        @sut.settings[:reconnect_delay] = 15
+        @sut.settings[:reconnect_interval] = 5
+
+        flexmock(EM).should_receive(:reconnect).never
+        flexmock(EM).should_receive(:add_timer).with(5, Proc).once
+
+        @sut.reconnect()
+      end
+    end
+
+  end
+
+end

data/spec/ha_client/broker_client_spec.rb

@@ -0,0 +1,936 @@
+#
+# Copyright (c) 2009-2012 RightScale Inc
+#
+# Permission is hereby granted, free of charge, to any person obtaining
+# a copy of this software and associated documentation files (the
+# "Software"), to deal in the Software without restriction, including
+# without limitation the rights to use, copy, modify, merge, publish,
+# distribute, sublicense, and/or sell copies of the Software, and to
+# permit persons to whom the Software is furnished to do so, subject to
+# the following conditions:
+#
+# The above copyright notice and this permission notice shall be
+# included in all copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+# EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+# MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+# NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
+# LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
+# OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
+# WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+
+require File.expand_path(File.join(File.dirname(__FILE__), '..', 'spec_helper'))
+require File.expand_path(File.join(File.dirname(__FILE__), '..', '..', 'lib', 'right_amqp'))
+
+class RequestMock; end
+class ResultMock; end
+
+describe RightAMQP::BrokerClient do
+
+  include FlexMock::ArgumentTypes
+  include RightAMQP::SpecHelper
+
+  before(:each) do
+    setup_logger
+    @message = "message"
+    @packet = flexmock("packet", :class => RequestMock, :to_s => true, :version => [12, 12]).by_default
+    @serializer = flexmock("serializer")
+    @serializer.should_receive(:dump).and_return(@message).by_default
+    @serializer.should_receive(:load).with(@message).and_return(@packet).by_default
+    @exceptions = flexmock("exceptions")
+    @exceptions.should_receive(:track).never.by_default
+    @connection = flexmock("connection")
+    @connection.should_receive(:connection_status).by_default
+    flexmock(AMQP).should_receive(:connect).and_return(@connection).by_default
+    @channel = flexmock("AMQP connection channel")
+    @channel.should_receive(:connection).and_return(@connection).by_default
+    @identity = "rs-broker-localhost-5672"
+    @address = {:host => "localhost", :port => 5672, :index => 0}
+    @options = {}
+  end
+
+  context "when initializing connection" do
+
+    before(:each) do
+      @amqp = flexmock(AMQP)
+      @amqp.should_receive(:connect).and_return(@connection).by_default
+      @channel.should_receive(:prefetch).never.by_default
+      flexmock(MQ).should_receive(:new).with(@connection).and_return(@channel).by_default
+    end
+
+    it "should create a broker with AMQP connection for specified address" do
+      @amqp.should_receive(:connect).with(hsh(:user => "user", :pass => "pass", :vhost => "vhost", :host => "localhost",
+                                              :port => 5672, :insist => true, :reconnect_interval => 10)).and_return(@connection).once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, {:user => "user",
+                                           :pass => "pass", :vhost => "vhost", :insist => true,
+                                           :reconnect_interval => 10})
+      broker.host.should == "localhost"
+      broker.port.should == 5672
+      broker.index.should == 0
+      broker.queues.should == []
+      broker.summary.should == {:alias => "b0", :identity => @identity, :status => :connecting,
+                                :disconnects => 0, :failures => 0, :retries => 0}
+      broker.usable?.should be_true
+      broker.connected?.should be_false
+      broker.failed?.should be_false
+    end
+
+    it "should update state from existing client for given broker" do
+      existing = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      existing.__send__(:update_status, :disconnected)
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options, existing)
+      broker.summary.should == {:alias => "b0", :identity => @identity, :status => :connecting,
+                                :disconnects => 1, :failures => 0, :retries => 0}
+    end
+
+    it "should log an info message when it creates an AMQP connection" do
+      @logger.should_receive(:info).with(/Connecting to broker/).once
+      RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+    end
+
+    it "should log an error and set status to :failed if it fails to create an AMQP connection" do
+      @exceptions.should_receive(:track).once
+      @connection.should_receive(:close).once
+      @logger.should_receive(:info).once
+      @logger.should_receive(:error).with(/Failed connecting/).once
+      flexmock(MQ).should_receive(:new).with(@connection).and_raise(Exception)
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.summary.should == {:alias => "b0", :identity => @identity, :status => :failed,
+                                :disconnects => 0, :failures => 1, :retries => 0}
+    end
+
+    it "should set initialize connection status callback" do
+      @connection.should_receive(:connection_status).once
+      RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+    end
+
+    it "should set broker prefetch value if specified" do
+      @channel.should_receive(:prefetch).with(1).once
+      RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, {:prefetch => 1})
+    end
+
+  end # when initializing connection
+
+  context "when subscribing" do
+
+    before(:each) do
+      @info = flexmock("info", :ack => true).by_default
+      @serializer.should_receive(:load).with(@message).and_return(@packet).by_default
+      @direct = flexmock("direct")
+      @fanout = flexmock("fanout")
+      @bind = flexmock("bind")
+      @queue = flexmock("queue")
+      @queue.should_receive(:bind).and_return(@bind).by_default
+      @channel.should_receive(:queue).and_return(@queue).by_default
+      @channel.should_receive(:direct).and_return(@direct).by_default
+      @channel.should_receive(:fanout).and_return(@fanout).by_default
+      flexmock(MQ).should_receive(:new).with(@connection).and_return(@channel).by_default
+    end
+
+    it "should subscribe queue to exchange" do
+      @queue.should_receive(:bind).and_return(@bind).once
+      @bind.should_receive(:subscribe).once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.__send__(:update_status, :ready)
+      broker.subscribe({:name => "queue"}, {:type => :direct, :name => "exchange"}) {|_, _|}
+    end
+
+    it "should subscribe queue to second exchange if specified" do
+      @queue.should_receive(:bind).and_return(@bind).twice
+      @bind.should_receive(:subscribe).once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.__send__(:update_status, :ready)
+      options = {:exchange2 => {:type => :fanout, :name => "exchange2", :options => {:durable => true}}}
+      broker.subscribe({:name => "queue"}, {:type => :direct, :name => "exchange"}, options) {|_, _|}
+    end
+
+    it "should subscribe queue to exchange when still connecting" do
+      @bind.should_receive(:subscribe).once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.subscribe({:name => "queue"}, {:type => :direct, :name => "exchange"}) {|_, _|}
+    end
+
+    it "should subscribe queue to empty exchange if no exchange specified" do
+      @queue.should_receive(:subscribe).once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.__send__(:update_status, :ready)
+      broker.subscribe({:name => "queue"}) {|b, p| p.should == nil}
+    end
+
+    it "should store queues for future reference" do
+      @bind.should_receive(:subscribe).once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.subscribe({:name => "queue"}, {:type => :direct, :name => "exchange"})
+      broker.queues.should == [@queue]
+    end
+
+    it "should return true if subscribed successfully" do
+      @bind.should_receive(:subscribe).and_yield(@info, @message).once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      result = broker.subscribe({:name => "queue"}, {:type => :direct, :name => "exchange"},
+                                 RequestMock => true) {|b, p| p.should == @packet}
+      result.should be_true
+    end
+
+    it "should return true if already subscribed and not try to resubscribe" do
+      @queue.should_receive(:name).and_return("queue").once
+      @bind.should_receive(:subscribe).and_yield(@info, @message).once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      result = broker.subscribe({:name => "queue"}, {:type => :direct, :name => "exchange"},
+                                 RequestMock => true) {|b, p| p.should == @packet}
+      result.should be_true
+      result = broker.subscribe({:name => "queue"}, {:type => :direct, :name => "exchange"}) {|_, _|}
+      result.should be_true
+    end
+
+    it "should ack received message if requested" do
+      @info.should_receive(:ack).once
+      @bind.should_receive(:subscribe).and_yield(@info, @message).once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.__send__(:update_status, :ready)
+      result = broker.subscribe({:name => "queue"}, {:type => :direct, :name => "exchange"},
+                                :ack => true, RequestMock => true) {|b, p| p.should == @packet}
+      result.should be_true
+    end
+
+    it "should return false if client not usable" do
+      @queue.should_receive(:bind).and_return(@bind).never
+      @bind.should_receive(:subscribe).never
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.__send__(:update_status, :disconnected)
+      broker.subscribe({:name => "queue"}).should be_false
+    end
+ 
+    it "should receive message causing it to be unserialized and logged" do
+      @logger.should_receive(:info).with(/Connecting/).once
+      @logger.should_receive(:info).with(/Subscribing/).once
+      @logger.should_receive(:info).with(/RECV/).once
+      @serializer.should_receive(:load).with(@message).and_return(@packet).once
+      @bind.should_receive(:subscribe).and_yield(@info, @message).once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.__send__(:update_status, :ready)
+      broker.subscribe({:name => "queue"}, {:type => :direct, :name => "exchange"},
+                       RequestMock => nil) {|b, p| p.class.should == RequestMock}
+    end
+
+    it "should receive message and log exception if subscribe block fails" do
+      @logger.should_receive(:info).with(/Connecting/).once
+      @logger.should_receive(:info).with(/Subscribing/).once
+      @logger.should_receive(:error).with(/Failed executing block/).once
+      @exceptions.should_receive(:track).once
+      @serializer.should_receive(:load).with(@message).and_return(@packet).once
+      @bind.should_receive(:subscribe).and_yield(@info, @message).once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.__send__(:update_status, :ready)
+      result = broker.subscribe({:name => "queue"}, {:type => :direct, :name => "exchange"},
+                                RequestMock => nil) {|b, p| raise Exception}
+      result.should be_false
+    end
+
+    it "should ignore 'nil' message when using ack" do
+      @logger.should_receive(:level).and_return(:debug)
+      @logger.should_receive(:info).with(/Connecting/).once
+      @logger.should_receive(:info).with(/Subscribing/).once
+      @logger.should_receive(:debug).with(/nil message ignored/).once
+      @bind.should_receive(:subscribe).and_yield(@info, "nil").once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.__send__(:update_status, :ready)
+      called = 0
+      broker.subscribe({:name => "queue"}, {:type => :direct, :name => "exchange"}, :ack => true) { |b, m| called += 1 }
+      called.should == 0
+    end
+
+    it "should ignore 'nil' message when not using ack" do
+      @logger.should_receive(:level).and_return(:debug)
+      @logger.should_receive(:info).with(/Connecting/).once
+      @logger.should_receive(:info).with(/Subscribing/).once
+      @logger.should_receive(:debug).with(/nil message ignored/).once
+      @bind.should_receive(:subscribe).and_yield(@info, "nil").once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.__send__(:update_status, :ready)
+      called = 0
+      broker.subscribe({:name => "queue"}, {:type => :direct, :name => "exchange"}) { |b, m| called += 1 }
+      called.should == 0
+    end
+
+    it "should not unserialize the message if requested" do
+      @logger.should_receive(:info).with(/Connecting/).once
+      @logger.should_receive(:info).with(/Subscribing/).once
+      @logger.should_receive(:info).with(/^RECV/).never
+      @bind.should_receive(:subscribe).and_yield(@info, @message).once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.__send__(:update_status, :ready)
+      broker.subscribe({:name => "queue"}, {:type => :direct, :name => "exchange"}, :no_unserialize => true) do |b, m|
+        b.should == "rs-broker-localhost-5672"
+        m.should == @message
+      end
+    end
+
+    it "should pass header with message if callback requires it" do
+      @logger.should_receive(:info).with(/Connecting/).once
+      @logger.should_receive(:info).with(/Subscribing/).once
+      @logger.should_receive(:info).with(/^RECV/).never
+      @bind.should_receive(:subscribe).and_yield(@info, @message).once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.__send__(:update_status, :ready)
+      broker.subscribe({:name => "queue"}, {:type => :direct, :name => "exchange"}, :no_unserialize => true) do |b, m, h|
+        b.should == "rs-broker-localhost-5672"
+        m.should == @message
+        h.should == @info
+      end
+    end
+
+    it "should log an error if a subscribe fails" do
+      @logger.should_receive(:info).with(/Connecting/).once
+      @logger.should_receive(:info).with(/RECV/).never
+      @logger.should_receive(:error).with(/Failed subscribing/).once
+      @exceptions.should_receive(:track).once
+      @bind.should_receive(:subscribe).and_raise(Exception)
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.__send__(:update_status, :ready)
+      result = broker.subscribe({:name => "queue"}, {:type => :direct, :name => "exchange"}) {|b, p|}
+      result.should be_false
+    end
+
+  end # when subscribing
+
+  context "when receiving" do
+
+    it "should unserialize the message, log it, and return it" do
+      @logger.should_receive(:info).with(/Connecting/).once
+      @logger.should_receive(:info).with(/^RECV/).once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.__send__(:receive, "queue", @message, RequestMock => nil).should == @packet
+    end
+
+    it "should log a warning if the message is not of the right type and return nil" do
+      @logger.should_receive(:warning).with(/Received invalid.*packet type/).once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.__send__(:receive, "queue", @message).should be_nil
+    end
+
+    it "should show the category in the warning message if specified" do
+      @logger.should_receive(:warning).with(/Received invalid xxxx packet type/).once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.__send__(:receive, "queue", @message, ResultMock => nil, :category => "xxxx")
+    end
+
+    it "should display broker alias in the log" do
+      @logger.should_receive(:info).with(/Connecting/).once
+      @logger.should_receive(:info).with(/^RECV b0 /).once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.__send__(:receive, "queue", @message, RequestMock => nil)
+    end
+
+    it "should filter the packet display for :info level" do
+      @logger.should_receive(:info).with(/Connecting/).once
+      @logger.should_receive(:info).with(/^RECV.*TO YOU/).once
+      @logger.should_receive(:debug).with(/^RECV.*TO YOU/).never
+      @packet.should_receive(:to_s).with([:to], :recv_version).and_return("TO YOU").once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.__send__(:receive, "queue", @message, RequestMock => [:to])
+    end
+
+    it "should not filter the packet display for :debug level" do
+      @logger.should_receive(:level).and_return(:debug)
+      @logger.should_receive(:info).with(/Connecting/).once
+      @logger.should_receive(:info).with(/^RECV.*ALL/).never
+      @logger.should_receive(:info).with(/^RECV.*ALL/).once
+      @packet.should_receive(:to_s).with(nil, :recv_version).and_return("ALL").once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.__send__(:receive, "queue", @message, RequestMock => [:to])
+    end
+
+    it "should display additional data in log" do
+      @logger.should_receive(:info).with(/Connecting/).once
+      @logger.should_receive(:info).with(/^RECV.*More data/).once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.__send__(:receive, "queue", @message, RequestMock => nil, :log_data => "More data")
+    end
+
+    it "should not log a message if requested not to" do
+      @logger.should_receive(:info).with(/Connecting/).once
+      @logger.should_receive(:info).with(/^RECV/).never
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.__send__(:receive, "queue", @message, RequestMock => nil, :no_log => true)
+    end
+
+    it "should not log a message if requested not to unless debug level" do
+      @logger.should_receive(:level).and_return(:debug)
+      @logger.should_receive(:info).with(/Connecting/).once
+      @logger.should_receive(:info).with(/^RECV/).once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.__send__(:receive, "queue", @message, RequestMock => nil, :no_log => true)
+    end
+
+    it "should log an error if exception prevents normal logging and should then return nil" do
+      @logger.should_receive(:error).with(/Failed receiving from queue/).once
+      @serializer.should_receive(:load).with(@message).and_raise(Exception).once
+      @exceptions.should_receive(:track).once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.__send__(:receive, "queue", @message).should be_nil
+    end
+
+    it "should make callback when there is a receive failure" do
+      @logger.should_receive(:error).with(/Failed receiving from queue/).once
+      @serializer.should_receive(:load).with(@message).and_raise(Exception).once
+      @exceptions.should_receive(:track).once
+      called = 0
+      callback = lambda { |msg, e| called += 1 }
+      options = {:exception_on_receive_callback => callback}
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, options)
+      broker.__send__(:receive, "queue", @message).should be_nil
+      called.should == 1
+    end
+
+    it "should display RE-RECV if the message being received is a retry" do
+      @logger.should_receive(:info).with(/Connecting/).once
+      @logger.should_receive(:info).with(/^RE-RECV/).once
+      @packet.should_receive(:tries).and_return(["try1"]).once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.__send__(:receive, "queue", @message, RequestMock => nil).should == @packet
+    end
+
+  end # when receiving
+
+  context "when unsubscribing" do
+
+    before(:each) do
+      @direct = flexmock("direct")
+      @bind = flexmock("bind", :subscribe => true)
+      @queue = flexmock("queue", :bind => @bind, :name => "queue1")
+      @channel.should_receive(:queue).and_return(@queue).by_default
+      @channel.should_receive(:direct).and_return(@direct).by_default
+      flexmock(MQ).should_receive(:new).with(@connection).and_return(@channel).by_default
+    end
+
+    it "should unsubscribe a queue by name" do
+      @queue.should_receive(:unsubscribe).once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.subscribe({:name => "queue1"}, {:type => :direct, :name => "exchange"})
+      broker.unsubscribe(["queue1"])
+    end
+
+    it "should ignore unsubscribe if queue unknown" do
+      @queue.should_receive(:unsubscribe).never
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.subscribe({:name => "queue1"}, {:type => :direct, :name => "exchange"})
+      broker.unsubscribe(["queue2"])
+    end
+
+    it "should activate block after unsubscribing if provided" do
+      @queue.should_receive(:unsubscribe).and_yield.once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.subscribe({:name => "queue1"}, {:type => :direct, :name => "exchange"})
+      called = 0
+      broker.unsubscribe(["queue1"]) { called += 1 }
+      called.should == 1
+    end
+
+    it "should ignore the request if client not usable" do
+      @queue.should_receive(:unsubscribe).and_yield.never
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.subscribe({:name => "queue1"}, {:type => :direct, :name => "exchange"})
+      broker.__send__(:update_status, :disconnected)
+      broker.unsubscribe(["queue1"])
+    end
+
+    it "should log an error if unsubscribe raises an exception and activate block if provided" do
+      @logger.should_receive(:error).with(/Failed unsubscribing/).once
+      @queue.should_receive(:unsubscribe).and_raise(Exception).once
+      @exceptions.should_receive(:track).once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.subscribe({:name => "queue1"}, {:type => :direct, :name => "exchange"})
+      called = 0
+      broker.unsubscribe(["queue1"]) { called += 1 }
+      called.should == 1
+    end
+
+  end # when unsubscribing
+
+  context "when declaring" do
+
+    before(:each) do
+      flexmock(MQ).should_receive(:new).with(@connection).and_return(@channel).by_default
+      @channel.should_receive(:queues).and_return({}).by_default
+      @channel.should_receive(:exchanges).and_return({}).by_default
+    end
+
+    it "should declare exchange and return true" do
+      @channel.should_receive(:exchange).once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.declare(:exchange, "x", :durable => true).should be_true
+    end
+
+    it "should delete the exchange or queue from the AMQP cache before declaring" do
+      @channel.should_receive(:queue).once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      flexmock(broker).should_receive(:delete_amqp_resources).with(:queue, "queue").once
+      broker.declare(:queue, "queue", :durable => true).should be_true
+    end
+
+    it "should log declaration" do
+      @logger.should_receive(:info).with(/Connecting/).once
+      @logger.should_receive(:info).with(/Declaring/).once
+      @channel.should_receive(:queue).once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.declare(:queue, "q").should be_true
+    end
+
+    it "should return false if client not usable" do
+      @channel.should_receive(:exchange).never
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.__send__(:update_status, :disconnected)
+      broker.declare(:exchange, "x", :durable => true).should be_false
+
+    end
+
+    it "should log an error if the declare fails and return false" do
+      @logger.should_receive(:info).with(/Connecting/).once
+      @logger.should_receive(:info).with(/Declaring/).once
+      @logger.should_receive(:error).with(/Failed declaring/).once
+      @exceptions.should_receive(:track).once
+      @channel.should_receive(:queue).and_raise(Exception).once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.declare(:queue, "q").should be_false
+    end
+
+  end # when declaring
+
+  context "when publishing" do
+
+    before(:each) do
+      @direct = flexmock("direct")
+      flexmock(MQ).should_receive(:new).with(@connection).and_return(@channel).by_default
+    end
+
+    it "should serialize message, publish it, and return true" do
+      @channel.should_receive(:direct).with("exchange", :durable => true).and_return(@direct).once
+      @direct.should_receive(:publish).with(@message, :persistent => true).once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.__send__(:update_status, :ready)
+      broker.publish({:type => :direct, :name => "exchange", :options => {:durable => true}},
+                     @packet, @message, :persistent => true).should be_true
+    end
+
+    it "should delete the exchange or queue from the AMQP cache if :declare specified" do
+      @channel.should_receive(:direct).with("exchange", {:declare => true}).and_return(@direct)
+      @direct.should_receive(:publish).with(@message, {})
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.__send__(:update_status, :ready)
+      exchange = {:type => :direct, :name => "exchange", :options => {:declare => true}}
+      flexmock(broker).should_receive(:delete_amqp_resources).with(:direct, "exchange").once
+      broker.publish(exchange, @packet, @message).should be_true
+    end
+
+    it "should return false if client not connected" do
+      @channel.should_receive(:direct).never
+      @direct.should_receive(:publish).with(@message, :persistent => true).never
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.publish({:type => :direct, :name => "exchange", :options => {:durable => true}},
+                     @packet, @message, :persistent => true).should be_false
+    end
+
+    it "should log an error if the publish fails" do
+      @logger.should_receive(:error).with(/Failed publishing/).once
+      @exceptions.should_receive(:track).once
+      @channel.should_receive(:direct).and_raise(Exception)
+      @direct.should_receive(:publish).with(@message, {}).never
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.__send__(:update_status, :ready)
+      broker.publish({:type => :direct, :name => "exchange"}, @packet, @message).should be_false
+    end
+
+    it "should log that message is being sent with info about which broker used" do
+      @logger.should_receive(:info).with(/Connecting/).once
+      @logger.should_receive(:info).with(/^SEND b0/).once
+      @channel.should_receive(:direct).with("exchange", {}).and_return(@direct).once
+      @direct.should_receive(:publish).with(@message, {}).once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.__send__(:update_status, :ready)
+      broker.publish({:type => :direct, :name => "exchange"}, @packet, @message).should be_true
+    end
+
+    it "should log broker choices for :debug level" do
+      @logger.should_receive(:level).and_return(:debug)
+      @logger.should_receive(:info).with(/Connecting/).once
+      @logger.should_receive(:info).with(/^SEND b0.*publish options/).once
+      @channel.should_receive(:direct).with("exchange", {}).and_return(@direct).once
+      @direct.should_receive(:publish).with(@message, {}).once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.__send__(:update_status, :ready)
+      broker.publish({:type => :direct, :name => "exchange"}, @packet, @message).should be_true
+    end
+
+    it "should not log a message if requested not to" do
+      @logger.should_receive(:info).with(/Connecting/).once
+      @logger.should_receive(:info).with(/^SEND/).never
+      @channel.should_receive(:direct).with("exchange", {}).and_return(@direct).once
+      @direct.should_receive(:publish).with(@message, :no_log => true).once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.__send__(:update_status, :ready)
+      broker.publish({:type => :direct, :name => "exchange"}, @packet, @message, :no_log => true).should be_true
+    end
+
+    it "should not log a message if requested not to unless debug level" do
+      @logger.should_receive(:level).and_return(:debug)
+      @logger.should_receive(:info).with(/Connecting/).once
+      @logger.should_receive(:info).with(/^SEND/).once
+      @channel.should_receive(:direct).with("exchange", {}).and_return(@direct).once
+      @direct.should_receive(:publish).with(@message, :no_log => true).once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.__send__(:update_status, :ready)
+      broker.publish({:type => :direct, :name => "exchange"}, @packet, @message, :no_log => true).should be_true
+    end
+
+    it "should display broker alias in the log" do
+      @logger.should_receive(:info).with(/Connecting/).once
+      @logger.should_receive(:info).with(/^SEND b0 /).once
+      @channel.should_receive(:direct).with("exchange", {}).and_return(@direct).once
+      @direct.should_receive(:publish).with(@message, {}).once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.__send__(:update_status, :ready)
+      broker.publish({:type => :direct, :name => "exchange"}, @packet, @message).should be_true
+    end
+
+    it "should filter the packet display for :info level" do
+      @logger.should_receive(:info).with(/Connecting/).once
+      @logger.should_receive(:info).with(/^SEND.*TO YOU/).once
+      @logger.should_receive(:info).with(/^SEND.*TO YOU/).never
+      @packet.should_receive(:to_s).with([:to], :send_version).and_return("TO YOU").once
+      @channel.should_receive(:direct).with("exchange", {}).and_return(@direct).once
+      @direct.should_receive(:publish).with(@message, :log_filter => [:to]).once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.__send__(:update_status, :ready)
+      broker.publish({:type => :direct, :name => "exchange"}, @packet, @message, :log_filter => [:to]).should be_true
+    end
+
+    it "should not filter the packet display for :debug level" do
+      @logger.should_receive(:level).and_return(:debug)
+      @logger.should_receive(:info).with(/Connecting/).once
+      @logger.should_receive(:info).with(/^SEND.*ALL/).never
+      @logger.should_receive(:info).with(/^SEND.*ALL/).once
+      @packet.should_receive(:to_s).with(nil, :send_version).and_return("ALL").once
+      @channel.should_receive(:direct).with("exchange", {}).and_return(@direct).once
+      @direct.should_receive(:publish).with(@message, :log_filter => [:to]).once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.__send__(:update_status, :ready)
+      broker.publish({:type => :direct, :name => "exchange"}, @packet, @message, :log_filter => [:to]).should be_true
+    end
+    
+    it "should display additional data in log" do
+      @logger.should_receive(:info).with(/Connecting/).once
+      @logger.should_receive(:info).with(/^SEND.*More data/).once
+      @channel.should_receive(:direct).with("exchange", {}).and_return(@direct).once
+      @direct.should_receive(:publish).with(@message, :log_data => "More data").once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.__send__(:update_status, :ready)
+      broker.publish({:type => :direct, :name => "exchange"}, @packet, @message, :log_data => "More data").should be_true
+    end
+
+    it "should display RE-SEND if the message being sent is a retry" do
+      @logger.should_receive(:info).with(/Connecting/).once
+      @logger.should_receive(:info).with(/^RE-SEND/).once
+      @packet.should_receive(:tries).and_return(["try1"]).once
+      @channel.should_receive(:direct).with("exchange", {}).and_return(@direct).once
+      @direct.should_receive(:publish).with(@message, {}).once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.__send__(:update_status, :ready)
+      broker.publish({:type => :direct, :name => "exchange"}, @packet, @message).should be_true
+    end
+
+  end # when publishing
+
+  context "when returning" do
+
+    class MQ
+      attr_accessor :connection, :on_return_message
+
+      def initialize(connection)
+        @connection = connection
+      end
+
+      def return_message(&blk)
+        @on_return_message = blk
+      end
+    end
+
+    before(:each) do
+      @info = flexmock("info", :reply_text => "NO_CONSUMERS", :exchange => "exchange", :routing_key => "routing_key").by_default
+    end
+
+    it "should invoke block and log the return" do
+      @logger.should_receive(:info).with(/Connecting to broker/).once
+      @logger.should_receive(:debug).with(/RETURN b0/).once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      called = 0
+      broker.return_message do |to, reason, message|
+        called += 1
+        to.should == "exchange"
+        reason.should == "NO_CONSUMERS"
+        message.should == @message
+      end
+      broker.instance_variable_get(:@channel).on_return_message.call(@info, @message)
+      called.should == 1
+    end
+
+    it "should invoke block with routing key if exchange is empty" do
+      @logger.should_receive(:debug)
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      called = 0
+      broker.return_message do |to, reason, message|
+        called += 1
+        to.should == "routing_key"
+        reason.should == "NO_CONSUMERS"
+        message.should == @message
+      end
+      @info.should_receive(:exchange).and_return("")
+      broker.instance_variable_get(:@channel).on_return_message.call(@info, @message)
+      called.should == 1
+    end
+
+    it "should log an error if there is a failure while processing the return" do
+      @logger.should_receive(:error).with(/Failed return/).once
+      @logger.should_receive(:debug)
+      @exceptions.should_receive(:track).once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      called = 0
+      broker.return_message do |to, reason, message|
+        called += 1
+        raise Exception
+      end
+      broker.instance_variable_get(:@channel).on_return_message.call(@info, @message)
+      called.should == 1
+    end
+
+  end # when returning
+
+  context "when deleting" do
+
+    before(:each) do
+      @direct = flexmock("direct")
+      @bind = flexmock("bind", :subscribe => true)
+      @queue = flexmock("queue", :bind => @bind, :name => "queue1")
+      @channel.should_receive(:queue).and_return(@queue).by_default
+      @channel.should_receive(:direct).and_return(@direct).by_default
+      flexmock(MQ).should_receive(:new).with(@connection).and_return(@channel).by_default
+    end
+
+    it "should delete the named queue and return true" do
+      @queue.should_receive(:delete).once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.subscribe({:name => "queue1"}, {:type => :direct, :name => "exchange"})
+      broker.queues.should == [@queue]
+      broker.delete("queue1").should be_true
+      broker.queues.should == []
+    end
+
+    it "should return false if the client is not usable" do
+      @queue.should_receive(:delete).never
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.subscribe({:name => "queue1"}, {:type => :direct, :name => "exchange"})
+      broker.queues.should == [@queue]
+      broker.__send__(:update_status, :disconnected)
+      broker.delete("queue1").should be_false
+      broker.queues.should == [@queue]
+    end
+
+    it "should log an error and return false if the delete fails" do
+      @logger.should_receive(:error).with(/Failed deleting queue/).once
+      @exceptions.should_receive(:track).once
+      @queue.should_receive(:delete).and_raise(Exception)
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.subscribe({:name => "queue1"}, {:type => :direct, :name => "exchange"})
+      broker.queues.should == [@queue]
+      broker.delete("queue1").should be_false
+    end
+
+  end # when deleteing
+
+  context "when monitoring" do
+
+    before(:each) do
+      flexmock(MQ).should_receive(:new).with(@connection).and_return(@channel).by_default
+    end
+
+    it "should distinguish whether the client is usable based on whether connecting or connected" do
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.usable?.should be_true
+      broker.__send__(:update_status, :ready)
+      broker.usable?.should be_true
+      broker.__send__(:update_status, :disconnected)
+      broker.usable?.should be_false
+      @logger.should_receive(:error).with(/Failed to connect to broker b0/).once
+      broker.__send__(:update_status, :failed)
+      broker.usable?.should be_false
+    end
+
+    it "should distinguish whether the client is connected" do
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.connected?.should be_false
+      broker.__send__(:update_status, :ready)
+      broker.connected?.should be_true
+      broker.__send__(:update_status, :disconnected)
+      broker.connected?.should be_false
+      @logger.should_receive(:error).with(/Failed to connect to broker b0/).once
+      broker.__send__(:update_status, :failed)
+      broker.connected?.should be_false
+    end
+
+    it "should distinguish whether the client has failed" do
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.failed?.should be_false
+      broker.__send__(:update_status, :ready)
+      broker.failed?.should be_false
+      broker.__send__(:update_status, :disconnected)
+      broker.failed?.should be_false
+      @logger.should_receive(:error).with(/Failed to connect to broker b0/).once
+      broker.__send__(:update_status, :failed)
+      broker.failed?.should be_true
+    end
+ 
+    it "should give broker summary" do
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.summary.should == {:alias => "b0", :identity => @identity, :status => :connecting,
+                                :disconnects => 0, :failures => 0, :retries => 0}
+      broker.__send__(:update_status, :ready)
+      broker.summary.should == {:alias => "b0", :identity => @identity, :status => :connected,
+                                :disconnects => 0, :failures => 0, :retries => 0}
+      @logger.should_receive(:error).with(/Failed to connect to broker/).once
+      broker.__send__(:update_status, :failed)
+      broker.summary.should == {:alias => "b0", :identity => @identity, :status => :failed,
+                                :disconnects => 0, :failures => 1, :retries => 0}
+    end
+
+    it "should give broker statistics" do
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.stats.should == {"alias" => "b0", "identity" => "rs-broker-localhost-5672",
+                              "status" => "connecting", "disconnects" => nil, "disconnect last" => nil,
+                              "failures" => nil, "failure last" => nil, "retries" => nil}
+      broker.__send__(:update_status, :ready)
+      broker.stats.should == {"alias" => "b0", "identity" => "rs-broker-localhost-5672",
+                              "status" => "connected", "disconnects" => nil, "disconnect last" => nil,
+                              "failures" => nil, "failure last" => nil, "retries" => nil}
+      @logger.should_receive(:error).with(/Failed to connect to broker/).once
+      broker.__send__(:update_status, :failed)
+      broker.stats.should == {"alias" => "b0", "identity" => "rs-broker-localhost-5672",
+                              "status" => "failed", "disconnects" => nil, "disconnect last" => nil,
+                              "failures" => 1, "failure last" => {"elapsed" => 0}, "retries" => nil}
+    end
+
+    it "should make update status callback when status changes" do
+      broker = nil
+      called = 0
+      connected_before = false
+      callback = lambda { |b, c| called += 1; b.should == broker; c.should == connected_before }
+      options = {:update_status_callback => callback}
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, options)
+      broker.__send__(:update_status, :ready)
+      broker.last_failed.should be_false
+      called.should == 1
+      connected_before = true
+      broker.__send__(:update_status, :disconnected)
+      broker.last_failed.should be_false
+      broker.disconnects.total.should == 1
+      called.should == 2
+      broker.__send__(:update_status, :disconnected)
+      broker.disconnects.total.should == 1
+      called.should == 2
+      @logger.should_receive(:error).with(/Failed to connect to broker b0/).once
+      connected_before = false
+      broker.__send__(:update_status, :failed)
+      broker.last_failed.should be_true
+      called.should == 3
+    end
+
+  end # when monitoring
+
+  context "when closing" do
+
+    before(:each) do
+      flexmock(MQ).should_receive(:new).with(@connection).and_return(@channel).by_default
+    end
+
+    it "should close broker connection and send status update" do
+      @connection.should_receive(:close).and_yield.once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      flexmock(broker).should_receive(:update_status).once
+      broker.close
+      broker.status.should == :closed
+    end
+
+    it "should not propagate status update if requested not to" do
+      @connection.should_receive(:close).and_yield.once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      flexmock(broker).should_receive(:update_status).never
+      broker.close(propagate = false)
+    end
+
+    it "should set status to :failed if not a normal close" do
+      @connection.should_receive(:close).and_yield.once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.close(propagate = false, normal = false)
+      broker.status.should == :failed
+    end
+
+    it "should log that closing connection" do
+      @logger.should_receive(:info).with(/Connecting/).once
+      @logger.should_receive(:info).with(/Closed connection to broker b0/).once
+      @connection.should_receive(:close).and_yield.once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.close
+    end
+
+    it "should not log if requested not to" do
+      @logger.should_receive(:info).with(/Connecting/).once
+      @logger.should_receive(:info).with(/Closed connection to broker b0/).never
+      @connection.should_receive(:close).and_yield.once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.close(propagate = true, normal = true, log = false)
+    end
+
+    it "should close broker connection and execute block if supplied" do
+      @connection.should_receive(:close).and_yield.once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      called = 0
+      broker.close { called += 1; broker.status.should == :closed }
+      called.should == 1
+    end
+
+    it "should close broker connection when no block supplied" do
+      @connection.should_receive(:close).and_yield.once
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.close
+    end
+
+    it "should not propagate status update if already closed" do
+      @connection.should_receive(:close).never
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.__send__(:update_status, :closed)
+      flexmock(broker).should_receive(:update_status).never
+      broker.close
+    end
+
+    it "should change failed status to closed" do
+      @logger.should_receive(:error).with(/Failed to connect to broker/).once
+      @connection.should_receive(:close).never
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.__send__(:update_status, :failed)
+      flexmock(broker).should_receive(:update_status).never
+      broker.close
+      broker.status.should == :closed
+    end
+
+    it "should log an error if closing connection fails but still set status to :closed" do
+      @logger.should_receive(:error).with(/Failed to close broker b0/).once
+      @exceptions.should_receive(:track).once
+      @connection.should_receive(:close).and_raise(Exception)
+      broker = RightAMQP::BrokerClient.new(@identity, @address, @serializer, @exceptions, @options)
+      broker.close
+      broker.status.should == :closed
+    end
+
+  end # when closing
+
+end # RightAMQP::BrokerClient