ridley 0.10.2 → 0.11.0.rc1

data/spec/unit/ridley/resources/role_resource_spec.rb

@@ -1,61 +1,7 @@
 require 'spec_helper'
 
 describe Ridley::RoleResource do
-  it_behaves_like "a Ridley Resource", Ridley::RoleResource
+  subject { described_class.new(double) }
 
-  let(:connection) { double("connection") }
-
-  subject { Ridley::RoleResource.new(connection) }
-
-  describe "#set_override_attribute" do
-    it "sets an override node attribute at the nested path" do
-       subject.set_override_attribute('deep.nested.item', true)
-
-       subject.override_attributes.should have_key("deep")
-       subject.override_attributes["deep"].should have_key("nested")
-       subject.override_attributes["deep"]["nested"].should have_key("item")
-       subject.override_attributes["deep"]["nested"]["item"].should be_true
-    end
-
-    context "when the override attribute is already set" do
-      it "test" do
-        subject.override_attributes = {
-          deep: {
-            nested: {
-              item: false
-            }
-          }
-        }
-        subject.set_override_attribute('deep.nested.item', true)
-        
-        subject.override_attributes["deep"]["nested"]["item"].should be_true
-      end
-    end
-  end
-
-  describe "#set_default_attribute" do
-    it "sets an override node attribute at the nested path" do
-       subject.set_default_attribute('deep.nested.item', true)
-
-       subject.default_attributes.should have_key("deep")
-       subject.default_attributes["deep"].should have_key("nested")
-       subject.default_attributes["deep"]["nested"].should have_key("item")
-       subject.default_attributes["deep"]["nested"]["item"].should be_true
-    end
-
-    context "when the override attribute is already set" do
-      it "test" do
-        subject.default_attributes = {
-          deep: {
-            nested: {
-              item: false
-            }
-          }
-        }
-        subject.set_default_attribute('deep.nested.item', true)
-        
-        subject.default_attributes["deep"]["nested"]["item"].should be_true
-      end
-    end
-  end
+  pending
 end

data/spec/unit/ridley/resources/sandbox_resource_spec.rb

@@ -1,172 +1,175 @@
 require 'spec_helper'
 
 describe Ridley::SandboxResource do
-  let(:server_url) { "https://api.opscode.com/organizations/vialstudios" }
   let(:client_name) { "reset" }
-  let(:client_key) { fixtures_path.join("reset.pem") }
-
-  let(:sandbox) do
-    Ridley.new(
-      server_url: server_url,
-      client_name: client_name,
-      client_key: client_key
-    ).sandbox
-  end
+  let(:client_key) { fixtures_path.join('reset.pem') }
+  let(:connection) { double('chef-connection') }
+  subject { described_class.new(double, client_name, client_key) }
+  before  { subject.stub(connection: connection) }
+
+  describe "#create" do
+    let(:sandbox_id) { "bd091b150b0a4578b97771af6abf3e05" }
+    let(:sandbox_uri) { "https://api.opscode.com/organizations/vialstudios/sandboxes/bd091b150b0a4578b97771af6abf3e05" }
+    let(:checksums) { Hash.new }
+    let(:response) do
+      double(body: { uri: sandbox_uri, checksums: checksums, sandbox_id: sandbox_id })
+    end
 
-  describe "ClassMethods" do
-    describe "::create" do
-      let(:checksums) { Hash.new }
-
-      before(:each) do
-        stub_request(:post, File.join(server_url, "sandboxes")).
-          with(body: MultiJson.encode(checksums: checksums)).
-          to_return(status: 200, body: {
-            uri: "https://api.opscode.com/organizations/vialstudios/sandboxes/bd091b150b0a4578b97771af6abf3e05",
-            checksums: {},
-            sandbox_id: "bd091b150b0a4578b97771af6abf3e05"
-          })
-      end
+    before(:each) do
+      connection.stub(:post).
+        with(subject.class.resource_path, MultiJson.encode(checksums: checksums)).
+        and_return(response)
+    end
+
+    it "returns a Ridley::SandboxObject" do
+      subject.create.should be_a(Ridley::SandboxObject)
+    end
 
-      subject { sandbox.create }
+    it "has a value of 'false' for :is_completed" do
+      subject.create.is_completed.should be_false
+    end
 
-      it "returns a SandboxResource" do
-        subject.should be_a(Ridley::SandboxResource)
+    it "has an empty Hash of checksums" do
+      subject.create.checksums.should be_a(Hash)
+      subject.create.checksums.should be_empty
+    end
+
+    it "has a value for :uri" do
+      subject.create.uri.should eql(sandbox_uri)
+    end
+
+    it "has a value for :sandbox_id" do
+      subject.create.sandbox_id.should eql(sandbox_id)
+    end
+
+    context "when given an array of checksums" do
+      let(:checksums) do
+        {
+          "385ea5490c86570c7de71070bce9384a" => nil,
+          "f6f73175e979bd90af6184ec277f760c" => nil,
+          "2e03dd7e5b2e6c8eab1cf41ac61396d5" => nil
+        }
       end
 
-      it "has an 'is_completed' value of false" do
-        subject.is_completed.should be_false
+      let(:checksum_array) { checksums.keys }
+
+      it "has a Hash of checksums with each of the given checksum ids" do
+        subject.create(checksum_array).checksums.should have(checksum_array.length).checksums
       end
+    end
+  end
+
+  describe "#commit" do
+    let(:sandbox_id) { "bd091b150b0a4578b97771af6abf3e05" }
+    let(:sandbox_path) { "#{described_class.resource_path}/#{sandbox_id}" }
+
+    let(:response) do
+      double(body: {
+        is_completed: true,
+        _rev: "1-bbc8a96f7486aeba2b562d382142fd68",
+        create_time: "2013-01-16T01:43:43+00:00",
+        guid: "bd091b150b0a4578b97771af6abf3e05",
+        json_class: "Chef::Sandbox",
+        name: "bd091b150b0a4578b97771af6abf3e05",
+        checksums: [],
+        chef_type: "sandbox"
+      })
+    end
 
-      it "has an empty Hash of checksums" do
-        subject.checksums.should be_a(Hash)
-        subject.checksums.should be_empty
+    it "sends a /PUT to the sandbox resource with is_complete set to true" do
+      connection.should_receive(:put).with(sandbox_path, MultiJson.encode(is_completed: true)).and_return(response)
+
+      subject.commit(sandbox_id)
+    end
+
+    context "when a sandbox of the given ID is not found" do
+      before do
+        connection.should_receive(:put).and_raise(Ridley::Errors::HTTPNotFound.new({}))
       end
 
-      it "has a value for 'uri'" do
-        subject.uri.should eql("https://api.opscode.com/organizations/vialstudios/sandboxes/bd091b150b0a4578b97771af6abf3e05")
+      it "raises a ResourceNotFound error" do
+        expect {
+          subject.commit(sandbox_id)
+        }.to raise_error(Ridley::Errors::ResourceNotFound)
       end
+    end
 
-      it "has a sandbox_id" do
-        subject.sandbox_id.should eql("bd091b150b0a4578b97771af6abf3e05")
+    context "when the given sandbox contents are malformed" do
+      before do
+        connection.should_receive(:put).and_raise(Ridley::Errors::HTTPBadRequest.new({}))
       end
 
-      context "when given an array of checksums" do
-        let(:checksums) do
-          {
-            "385ea5490c86570c7de71070bce9384a" => nil,
-            "f6f73175e979bd90af6184ec277f760c" => nil,
-            "2e03dd7e5b2e6c8eab1cf41ac61396d5" => nil
-          }
-        end
-        let(:checksum_array) { checksums.keys }
-
-        before(:each) do
-          stub_request(:post, File.join(server_url, "sandboxes")).
-            with(body: MultiJson.encode(checksums: checksums)).
-            to_return(status: 200, body: {
-              "uri" => "https://api.opscode.com/organizations/vialstudios/sandboxes/bd091b150b0a4578b97771af6abf3e05",
-              "checksums" => {
-                "385ea5490c86570c7de71070bce9384a" => {
-                  "url" => "https://s3.amazonaws.com/opscode-platform-production-data/organization",
-                  "needs_upload" => true
-                },
-                "f6f73175e979bd90af6184ec277f760c" => {
-                  "url" => "https://s3.amazonaws.com/opscode-platform-production-data/organization",
-                  "needs_upload" => true
-                },
-                "2e03dd7e5b2e6c8eab1cf41ac61396d5" => {
-                  "url" => "https://s3.amazonaws.com/opscode-platform-production-data/organization",
-                  "needs_upload" => true
-                },
-              },
-              "sandbox_id" => "bd091b150b0a4578b97771af6abf3e05"
-            })
-        end
-
-        subject { sandbox.create(checksum_array) }
-
-        it "has a Hash of checksums with each of the given checksum ids" do
-          subject.checksums.should have(checksum_array.length).checksums
-        end
+      it "raises a SandboxCommitError error" do
+        expect {
+          subject.commit(sandbox_id)
+        }.to raise_error(Ridley::Errors::SandboxCommitError)
       end
     end
-  end
 
-  subject do
-    sandbox.new(
-      "uri" => "https://api.opscode.com/organizations/vialstudios/sandboxes/bd091b150b0a4578b97771af6abf3e05",
-      "checksums" => {
-        "385ea5490c86570c7de71070bce9384a" => {
-          "url" => "https://s3.amazonaws.com/opscode-platform-production-data/organization",
-          "needs_upload" => true
-        },
-        "f6f73175e979bd90af6184ec277f760c" => {
-          "url" => "https://s3.amazonaws.com/opscode-platform-production-data/organization",
-          "needs_upload" => true
-        },
-        "2e03dd7e5b2e6c8eab1cf41ac61396d5" => {
-          "url" => "https://s3.amazonaws.com/opscode-platform-production-data/organization",
-          "needs_upload" => true
-        },
-      },
-      "sandbox_id" => "bd091b150b0a4578b97771af6abf3e05"
-    )
-  end
+    context "when the user who made the request is not authorized" do
+      it "raises a PermissionDenied error on unauthorized" do
+        connection.should_receive(:put).and_raise(Ridley::Errors::HTTPUnauthorized.new({}))
 
-  describe "#commit" do
-    context "on successful commit" do
-      before(:each) do
-        stub_request(:put, File.join(server_url, "sandboxes", "bd091b150b0a4578b97771af6abf3e05")).
-          with(body: MultiJson.encode(is_completed: true)).
-          to_return(status: 200, body: {
-            is_completed: true,
-            _rev: "1-bbc8a96f7486aeba2b562d382142fd68",
-            create_time: "2013-01-16T01:43:43+00:00",
-            guid: "bd091b150b0a4578b97771af6abf3e05",
-            json_class: "Chef::Sandbox",
-            name: "bd091b150b0a4578b97771af6abf3e05",
-            checksums: [],
-            chef_type: "sandbox"
-          })
+        expect {
+          subject.commit(sandbox_id)
+        }.to raise_error(Ridley::Errors::PermissionDenied)
       end
 
-      it "has an 'is_completed' value of true" do
-        subject.commit
+      it "raises a PermissionDenied error on forbidden" do
+        connection.should_receive(:put).and_raise(Ridley::Errors::HTTPForbidden.new({}))
 
-        subject.is_completed.should be_true
+        expect {
+          subject.commit(sandbox_id)
+        }.to raise_error(Ridley::Errors::PermissionDenied)
       end
     end
+  end
 
-    context "on commit failure" do
-      before(:each) do
-        stub_request(:put, File.join(server_url, "sandboxes", "bd091b150b0a4578b97771af6abf3e05")).
-          with(body: MultiJson.encode(is_completed: true)).
-          to_return(status: 200, body: {
-            is_completed: false,
-            _rev: "1-bbc8a96f7486aeba2b562d382142fd68",
-            create_time: "2013-01-16T01:43:43+00:00",
-            guid: "bd091b150b0a4578b97771af6abf3e05",
-            json_class: "Chef::Sandbox",
-            name: "bd091b150b0a4578b97771af6abf3e05",
-            checksums: [],
-            chef_type: "sandbox"
-          })
-      end
+  describe "#update" do
+    it "is not a supported action" do
+      expect {
+        subject.update(anything)
+      }.to raise_error(RuntimeError, "action not supported")
+    end
+  end
 
-      it "has an 'is_completed' value of false" do
-        subject.commit
+  describe "#update" do
+    it "is not a supported action" do
+      expect {
+        subject.update
+      }.to raise_error(RuntimeError, "action not supported")
+    end
+  end
 
-        subject.is_completed.should be_false
-      end
+  describe "#all" do
+    it "is not a supported action" do
+      expect {
+        subject.all
+      }.to raise_error(RuntimeError, "action not supported")
     end
   end
 
-  describe "#upload" do
-    it "delegates self to SandboxUploader.upload" do
-      checksums = double('checksums')
-      Ridley::SandboxUploader.should_receive(:upload).with(subject, checksums)
+  describe "#find" do
+    it "is not a supported action" do
+      expect {
+        subject.find
+      }.to raise_error(RuntimeError, "action not supported")
+    end
+  end
+
+  describe "#delete" do
+    it "is not a supported action" do
+      expect {
+        subject.delete
+      }.to raise_error(RuntimeError, "action not supported")
+    end
+  end
 
-      subject.upload(checksums)
+  describe "#delete_all" do
+    it "is not a supported action" do
+      expect {
+        subject.delete_all
+      }.to raise_error(RuntimeError, "action not supported")
     end
   end
 end

data/spec/unit/ridley/resources/search_resource_spec.rb

@@ -0,0 +1,234 @@
+require 'spec_helper'
+
+describe Ridley::SearchResource do
+  describe "ClassMethods" do
+    subject { described_class }
+
+    describe "::build_query" do
+      let(:query_string) { "*:*" }
+      let(:options) { Hash.new }
+
+      it "contains a 'q' key/value" do
+        result = subject.build_query(query_string, options)
+
+        result.should have_key(:q)
+        result[:q].should eql(query_string)
+      end
+
+      context "when :sort option is set" do
+        before { options[:sort] = "DESC" }
+
+        it "contains a 'sort' key/value" do
+          result = subject.build_query(query_string, options)
+
+          result.should have_key(:sort)
+          result[:sort].should eql("DESC")
+        end
+      end
+
+      context "when :start option is set" do
+        before { options[:start] = 1 }
+
+        it "contains a 'start' key/value" do
+          result = subject.build_query(query_string, options)
+
+          result.should have_key(:start)
+          result[:start].should eql(1)
+        end
+      end
+
+      context "when :rows option is set" do
+        before { options[:rows] = 1 }
+
+        it "contains a 'rows' key/value" do
+          result = subject.build_query(query_string, options)
+
+          result.should have_key(:rows)
+          result[:rows].should eql(1)
+        end
+      end
+    end
+
+    describe "::query_uri" do
+      it "returns a URI path containing the search resource path and index" do
+        subject.query_uri(:nodes).should eql("search/nodes")
+      end
+    end
+  end
+
+  let(:connection) { double('chef-connection') }
+  subject { described_class.new(double('registry')) }
+  before  { subject.stub(connection: connection) }
+
+  describe "#indexes" do
+    let(:response) do
+      double(body: {
+        node: "http://localhost:4000/search/node",
+        role: "http://localhost:4000/search/role",
+        client: "http://localhost:4000/search/client",
+        users: "http://localhost:4000/search/users"
+      })
+    end
+
+    before do
+      connection.stub(:get).with(described_class.resource_path).and_return(response)
+    end
+
+    it "performs a GET to the search resource_path" do
+      connection.should_receive(:get).with(described_class.resource_path).and_return(response)
+      subject.indexes
+    end
+
+    it "contains a key for each index" do
+      subject.indexes.should have(4).items
+    end
+  end
+
+  describe "#run" do
+    let(:index) { :role }
+    let(:query_string) { "*:*" }
+    let(:options) { Hash.new }
+    let(:response) do
+      double(body: {
+        rows: Array.new,
+        total: 0,
+        start: 0
+      })
+    end
+
+    let(:run) { subject.run(index, query_string) }
+
+    before do
+      connection.stub(:get).and_return(response)
+    end
+
+    it "builds a query and runs it against the index's resource path" do
+      query     = double('query')
+      query_uri = double('query-uri')
+      described_class.should_receive(:build_query).with(query_string, options).and_return(query)
+      described_class.should_receive(:query_uri).with(index).and_return(query_uri)
+      connection.should_receive(:get).with(query_uri, query).and_return(response)
+
+      subject.run(index, query_string, options)
+    end
+
+    context "when :node is the given index" do
+      let(:index) { :node }
+      let(:response) do
+        double(body: {
+          rows: [
+            {
+              chef_type: "node",
+              json_class: "Chef::Node",
+              name: "ridley-one",
+              chef_environment: "_default",
+              automatic: {},
+              normal: {},
+              default: {},
+              override: {},
+              run_list: [
+                "recipe[one]",
+                "recipe[two]"
+              ]
+            }
+          ],
+          total: 1,
+          start: 0
+        })
+      end
+
+      it "returns an array of Ridley::NodeObject" do
+        result = run
+
+        result.should be_a(Array)
+        result.should each be_a(Ridley::NodeObject)
+      end
+    end
+
+    context "when :role is the given index" do
+      let(:index) { :role }
+      let(:response) do
+        double(body: {
+          rows: [
+            {
+              chef_type: "role",
+              json_class: "Chef::Role",
+              name: "ridley-role-one",
+              description: "",
+              default_attributes: {},
+              override_attributes: {},
+              run_list: [],
+              env_run_lists: {}
+            }
+          ],
+          total: 1,
+          start: 0
+        })
+      end
+
+      it "returns an array of Ridley::RoleObject" do
+        result = run
+
+        result.should be_a(Array)
+        result.should each be_a(Ridley::RoleObject)
+      end
+    end
+
+    context "when :environment is the given index" do
+      let(:index) { :environment }
+      let(:response) do
+        double(body: {
+          rows: [
+            {
+              chef_type: "environment",
+              json_class: "Chef::Environment",
+              name: "ridley-env-test",
+              description: "ridley testing environment",
+              default_attributes: {},
+              override_attributes: {},
+              cookbook_versions: {}
+            }
+          ],
+          total: 1,
+          start: 0
+        })
+      end
+
+      it "returns an array of Ridley::EnvironmentObject" do
+        result = run
+
+        result.should be_a(Array)
+        result.should each be_a(Ridley::EnvironmentObject)
+      end
+    end
+
+    context "when :client is the given index" do
+      let(:index) { :client }
+      let(:response) do
+        double(body: {
+          rows: [
+            {
+              chef_type: "client",
+              name: nil,
+              admin: false,
+              validator: false,
+              certificate: "-----BEGIN CERTIFICATE-----\nMIIDOjCCAqOgAwIBAgIE47eOmDANBgkqhkiG9w0BAQUFADCBnjELMAkGA1UEBhMC\nVVMxEzARBgNVBAgMCldhc2hpbmd0b24xEDAOBgNVBAcMB1NlYXR0bGUxFjAUBgNV\nBAoMDU9wc2NvZGUsIEluYy4xHDAaBgNVBAsME0NlcnRpZmljYXRlIFNlcnZpY2Ux\nMjAwBgNVBAMMKW9wc2NvZGUuY29tL2VtYWlsQWRkcmVzcz1hdXRoQG9wc2NvZGUu\nY29tMCAXDTEyMTAwOTAwMTUxNVoYDzIxMDExMTA0MDAxNTE1WjCBnTEQMA4GA1UE\nBxMHU2VhdHRsZTETMBEGA1UECBMKV2FzaGluZ3RvbjELMAkGA1UEBhMCVVMxHDAa\nBgNVBAsTE0NlcnRpZmljYXRlIFNlcnZpY2UxFjAUBgNVBAoTDU9wc2NvZGUsIElu\nYy4xMTAvBgNVBAMUKFVSSTpodHRwOi8vb3BzY29kZS5jb20vR1VJRFMvY2xpZW50\nX2d1aWQwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQCqB9KEGzl7Wcm/\nwz/x8HByZANCn6WQC+R12qQso5I6nLbTNkRP668jXG3j0R5/F5i/KearAB9ePzL/\nQe3iHtwW6u1qLI1hVNFNB+I1fGu1p6fZyIOjnLn3bqsbOkBplHOIqHsp4GVSsHKb\nD32UXZDa9S9ZFXnR4iT6hUGm5895ReZG9TDiHvBpi9NJFDZXz+AQ6JuQY8UgYMMA\nm80KbO8/NJlXbRW+siRuvr+LIsi9Mx4i63pBWAN46my291rQU31PF3IB+btfGtR/\nyDWDgMSB37bTzZeOf1Dg9fpl2vIXyu3PoHER0oYmrMQbrdwAt7qCHZNuNWn51WPb\n1PHxXL1rAgMBAAEwDQYJKoZIhvcNAQEFBQADgYEAGnJUVAv951fUhGyPOrl+LbQG\nqgchMwIn7oDLE863e66BYTDj7koK3jjhx3EBkrT2vt/xS4yW0ZRV1BNqfnNKWbBq\nMNQiKkYdTr+oq2O3plOg/q/M1eG1B5pxGXqvH0O76DVWQcV/svO+HQEi1n8y5UQd\n+pBJCygpuv78wPCM+c4=\n-----END CERTIFICATE-----\n",
+              public_key: nil,
+              private_key: nil,
+              orgname: "ridley"
+            }
+          ],
+          total: 1,
+          start: 0
+        })
+      end
+
+      it "returns an array of Ridley::ClientObject" do
+        result = run
+
+        result.should be_a(Array)
+        result.should each be_a(Ridley::ClientObject)
+      end
+    end
+  end
+end