ridley 0.10.2 → 0.11.0.rc1

data/spec/support/shared_examples/ridley_resource.rb

@@ -11,27 +11,12 @@ shared_examples_for "a Ridley Resource" do |resource_klass|
       it "sends a get request for the class' resource_path using the given client" do
         response.stub(:body) { Hash.new }
         client.connection.should_receive(:get).with(subject.resource_path).and_return(response)
-        
+
         subject.all(client)
       end
     end
 
     describe "::find" do
-      it "delegates to find!" do
-        id = double('id')
-        subject.should_receive(:find!).with(client, id)
-
-        subject.find(client, id)
-      end
-
-      context "when the resource is not found" do
-        it "returns nil" do
-          pending
-        end
-      end
-    end
-
-    describe "::find!" do
       it "sends a get request to the given client to the resource_path of the class for the given chef_id" do
         chef_id = "ridley_test"
         response.stub(:body) { Hash.new }
@@ -39,12 +24,6 @@ shared_examples_for "a Ridley Resource" do |resource_klass|
 
         subject.find(client, chef_id)
       end
-
-      context "when the resource is not found" do
-        it "raises a Ridley::Errors::HTTPNotFound error" do
-          pending
-        end
-      end
     end
 
     describe "::create" do
@@ -137,7 +116,7 @@ shared_examples_for "a Ridley Resource" do |resource_klass|
   end
 
   describe "#update" do
-    context "when the object is valid" do   
+    context "when the object is valid" do
       let(:updated) do
         updated = double('updated')
         updated.stub(:[]).and_return(Hash.new)

data/spec/unit/ridley/bootstrap_bindings/unix_template_binding_spec.rb

@@ -1,19 +1,18 @@
 require 'spec_helper'
 
 describe Ridley::UnixTemplateBinding do
-
   let(:options) do
     {
       server_url: "https://api.opscode.com/organizations/vialstudios",
       validator_client: "chef-validator",
       validator_path: fixtures_path.join("reset.pem").to_s,
-      encrypted_data_bag_secret_path: fixtures_path.join("reset.pem").to_s
+      encrypted_data_bag_secret: File.read(fixtures_path.join("reset.pem"))
     }
   end
-  
+
   describe "ClassMethods" do
     subject { described_class }
-    
+
     describe "::new" do
       context "when no sudo option is passed through" do
         it "sets a default value of 'true' to 'sudo'" do

data/spec/unit/ridley/bootstrap_bindings/windows_template_binding_spec.rb

@@ -6,14 +6,14 @@ describe Ridley::WindowsTemplateBinding do
       server_url: "https://api.opscode.com/organizations/vialstudios",
       validator_client: "chef-validator",
       validator_path: fixtures_path.join("reset.pem").to_s,
-      encrypted_data_bag_secret_path: fixtures_path.join("reset.pem").to_s,
+      encrypted_data_bag_secret: File.read(fixtures_path.join("reset.pem")),
       chef_version: "11.4.0"
     }
   end
-  
+
   describe "ClassMethods" do
     subject { described_class }
-    
+
     describe "::new" do
       context "when a chef_version is passed through" do
         it "sets the chef_version attribute to the same value" do
@@ -33,7 +33,6 @@ describe Ridley::WindowsTemplateBinding do
   subject { Ridley::WindowsTemplateBinding.new(options) }
 
   describe "MixinMethods" do
-
     describe "#templates_path" do
       it "returns a pathname" do
         subject.templates_path.should be_a(Pathname)
@@ -65,7 +64,6 @@ describe Ridley::WindowsTemplateBinding do
     end
   end
 
-
   describe "#boot_command" do
     it "returns a string" do
       subject.boot_command.should be_a(String)

data/spec/unit/ridley/bootstrapper/context_spec.rb

@@ -8,7 +8,7 @@ describe Ridley::Bootstrapper::Context do
       server_url: "https://api.opscode.com/organizations/vialstudios",
       validator_client: "chef-validator",
       validator_path: fixtures_path.join("reset.pem").to_s,
-      encrypted_data_bag_secret_path: fixtures_path.join("reset.pem").to_s
+      encrypted_data_bag_secret: File.read(fixtures_path.join("reset.pem"))
     }
   end
 
@@ -16,7 +16,6 @@ describe Ridley::Bootstrapper::Context do
     subject { Ridley::Bootstrapper::Context }
 
     describe "::create" do
-      
       context "when the best connection is SSH" do
         it "sets template_binding to a Ridley::UnixTemplateBinding" do
           Ridley::HostConnector.stub(:best_connector_for).and_return(Ridley::HostConnector::SSH)
@@ -29,7 +28,7 @@ describe Ridley::Bootstrapper::Context do
         it "sets template_binding to a Ridley::WindowsTemplateBinding" do
           Ridley::HostConnector.stub(:best_connector_for).and_return(Ridley::HostConnector::WinRM)
           context = subject.create(host, options)
-          context.template_binding.should be_a(Ridley::WindowsTemplateBinding)          
+          context.template_binding.should be_a(Ridley::WindowsTemplateBinding)
         end
       end
 

data/spec/unit/ridley/bootstrapper_spec.rb

@@ -14,7 +14,7 @@ describe Ridley::Bootstrapper do
       server_url: "https://api.opscode.com/organizations/vialstudios",
       validator_client: "vialstudios-validator",
       validator_path: fixtures_path.join("reset.pem").to_s,
-      encrypted_data_bag_secret_path: fixtures_path.join("reset.pem").to_s
+      encrypted_data_bag_secret: File.read(fixtures_path.join("reset.pem"))
     }
   end
 

data/spec/unit/ridley/chef_object_spec.rb

@@ -0,0 +1,240 @@
+describe Ridley::ChefObject do
+  let(:resource) { double('chef-resource') }
+
+  describe "ClassMethods" do
+    subject { Class.new(described_class) }
+
+    describe "::new" do
+      it "mass assigns the given attributes" do
+        new_attrs = {
+          name: "a name"
+        }
+
+        subject.any_instance.should_receive(:mass_assign).with(new_attrs)
+        subject.new(resource, new_attrs)
+      end
+    end
+
+    describe "::set_chef_type" do
+      it "sets the chef_type attr on the class" do
+        subject.set_chef_type("environment")
+
+        subject.chef_type.should eql("environment")
+      end
+    end
+
+    describe "::set_chef_json_class" do
+      it "sets the chef_json_class attr on the class" do
+        subject.set_chef_json_class("Chef::Environment")
+
+        subject.chef_json_class.should eql("Chef::Environment")
+      end
+    end
+
+    describe "::set_chef_id" do
+      it "sets the chef_id attribute on the class" do
+        subject.set_chef_id(:environment)
+
+        subject.chef_id.should eql(:environment)
+      end
+    end
+
+    describe "::chef_type" do
+      it "returns the underscored name of the including class if nothing is set" do
+        subject.chef_type.should eql(subject.class.name.underscore)
+      end
+    end
+
+    describe "::chef_json_class" do
+      it "returns the chef_json if nothing has been set" do
+        subject.chef_json_class.should be_nil
+      end
+    end
+
+    describe "::chef_id" do
+      it "returns nil if nothing is set" do
+        subject.chef_id.should be_nil
+      end
+    end
+  end
+
+  subject do
+    Class.new(described_class).new(resource)
+  end
+
+  describe "#save" do
+    context "when the object is valid" do
+      before(:each) { subject.stub(:valid?).and_return(true) }
+
+      it "sends a create message to the implementing class" do
+        updated = double('updated')
+        updated.stub(:_attributes_).and_return(Hash.new)
+        resource.should_receive(:create).with(subject).and_return(updated)
+
+        subject.save
+      end
+
+      context "when there is an HTTPConflict" do
+        it "sends the update message to self" do
+          updated = double('updated')
+          updated.stub(:[]).and_return(Hash.new)
+          updated.stub(:_attributes_).and_return(Hash.new)
+          resource.should_receive(:create).and_raise(Ridley::Errors::HTTPConflict.new(updated))
+          subject.should_receive(:update).and_return(updated)
+
+          subject.save
+        end
+      end
+    end
+
+    context "when the object is invalid" do
+      before(:each) { subject.stub(:valid?).and_return(false) }
+
+      it "raises an InvalidResource error" do
+        lambda {
+          subject.save
+        }.should raise_error(Ridley::Errors::InvalidResource)
+      end
+    end
+  end
+
+  describe "#update" do
+    context "when the object is valid" do
+      let(:updated) do
+        updated = double('updated')
+        updated.stub(:[]).and_return(Hash.new)
+        updated.stub(:_attributes_).and_return(Hash.new)
+        updated
+      end
+
+      before(:each) { subject.stub(:valid?).and_return(true) }
+
+      it "sends an update message to the implementing class" do
+        resource.should_receive(:update).with(subject).and_return(updated)
+        subject.update
+      end
+
+      it "returns true" do
+        resource.should_receive(:update).with(subject).and_return(updated)
+        subject.update.should eql(true)
+      end
+    end
+
+    context "when the object is invalid" do
+      before(:each) { subject.stub(:valid?).and_return(false) }
+
+      it "raises an InvalidResource error" do
+        lambda {
+          subject.update
+        }.should raise_error(Ridley::Errors::InvalidResource)
+      end
+    end
+  end
+
+  describe "#chef_id" do
+    it "returns the value of the chef_id attribute" do
+      subject.class.attribute(:name)
+      subject.class.stub(:chef_id) { :name }
+      subject.mass_assign(name: "reset")
+
+      subject.chef_id.should eql("reset")
+    end
+  end
+
+  describe "#reload" do
+    let(:updated_subject) { double('updated_subject', _attributes_: { fake_attribute: "some_value" }) }
+
+    before(:each) do
+      subject.class.attribute(:fake_attribute)
+      resource.should_receive(:find).with(subject).and_return(updated_subject)
+    end
+
+    it "returns itself" do
+      subject.reload.should eql(subject)
+    end
+
+    it "sets the attributes of self to include those of the reloaded object" do
+      subject.reload
+
+      subject.get_attribute(:fake_attribute).should eql("some_value")
+    end
+  end
+
+  describe "comparable" do
+    subject do
+      Class.new(described_class) do
+        set_chef_id "name"
+
+        attribute "name"
+        attribute "other_extra"
+        attribute "extra"
+      end
+    end
+
+    let(:one) { subject.new(resource) }
+    let(:two) { subject.new(resource) }
+
+    context "given two objects with the same value for their 'chef_id'" do
+      before(:each) do
+        one.mass_assign(name: "reset", other_extra: "stuff")
+        two.mass_assign(name: "reset", extra: "stuff")
+      end
+
+      it "is equal" do
+        one.should be_eql(two)
+      end
+    end
+
+    context "given two objects with different values for their 'chef_id'" do
+      before(:each) do
+        one.mass_assign(name: "jamie", other_extra: "stuff")
+        two.mass_assign(name: "winsor", extra: "stuff")
+      end
+
+      it "is not equal" do
+        one.should_not be_eql(two)
+      end
+    end
+  end
+
+  describe "uniqueness" do
+    subject do
+      Class.new(described_class) do
+        set_chef_id "name"
+
+        attribute "name"
+        attribute "other_extra"
+        attribute "extra"
+      end
+    end
+
+    let(:one) { subject.new(resource) }
+    let(:two) { subject.new(resource) }
+
+    context "given an array of objects with the same value for their 'chef_id'" do
+      let(:nodes) do
+        one.mass_assign(name: "reset", other_extra: "stuff")
+        two.mass_assign(name: "reset", extra: "stuff")
+
+        [ one, two ]
+      end
+
+      it "returns only one unique element" do
+        nodes.uniq.should have(1).item
+      end
+    end
+
+    context "given an array of objects with different values for their 'chef_id'" do
+      let(:nodes) do
+        one.mass_assign(name: "jamie", other_extra: "stuff")
+        two.mass_assign(name: "winsor", extra: "stuff")
+
+        [ one, two ]
+      end
+
+      it "returns all of the elements" do
+        nodes.uniq.should have(2).item
+      end
+    end
+  end
+end

data/spec/unit/ridley/chef_objects/client_object_spec.rb

@@ -0,0 +1,11 @@
+require 'spec_helper'
+
+describe Ridley::ClientObject do
+  describe "#to_json" do
+    pending
+  end
+
+  describe "#regenerate_key" do
+    pending
+  end
+end

data/spec/unit/ridley/chef_objects/cookbook_object_spec.rb

@@ -0,0 +1,93 @@
+require 'spec_helper'
+
+describe Ridley::CookbookObject do
+  let(:connection) { double('chef-connection') }
+  subject { described_class.new(double('registry')) }
+  before  { subject.stub(connection: connection) }
+
+  describe "#download" do
+    it "downloads each file" do
+      subject.stub(:manifest) do
+        {
+          resources: [],
+          providers: [],
+          recipes: [
+            {
+              checksum: "aa3505d3eb8ce328ea84a4333df05b07",
+              name: "default.rb",
+              path: "recipes/default.rb",
+              specificity: "default",
+              url: "https://chef.lax1.riotgames.com/organizations/reset/cookbooks/ohai/1.0.2/files/aa3505d3eb8ce328ea84a4333df05b07"
+            }
+          ],
+          definitions: [],
+          libraries: [],
+          attributes: [],
+          files: [
+            {
+              checksum: "85bc3bb921efade3f2566a668ab4b639",
+              name: "README",
+              path: "files/default/plugins/README",
+              specificity: "plugins",
+              url: "https://chef.lax1.riotgames.com/organizations/reset/cookbooks/ohai/1.0.2/files/85bc3bb921efade3f2566a668ab4b639"
+            }
+          ],
+          templates: [],
+          root_files: []
+        }
+      end
+
+      subject.should_receive(:download_file).with(:recipes, "recipes/default.rb", anything)
+      subject.should_receive(:download_file).with(:files, "files/default/plugins/README", anything)
+
+      subject.download
+    end
+  end
+
+  describe "#download_file" do
+    let(:destination) { tmp_path.join('fake.file').to_s }
+
+    before(:each) do
+      subject.stub(:root_files) { [ { path: 'metadata.rb', url: "http://test.it/file" } ] }
+    end
+
+    it "downloads the file from the file's url" do
+      connection.should_receive(:stream).with("http://test.it/file", destination)
+
+      subject.download_file(:root_file, "metadata.rb", destination)
+    end
+
+    context "when given an unknown filetype" do
+      it "raises an UnknownCookbookFileType error" do
+        expect {
+          subject.download_file(:not_existant, "default.rb", destination)
+        }.to raise_error(Ridley::Errors::UnknownCookbookFileType)
+      end
+    end
+
+    context "when the cookbook doesn't have the specified file" do
+      before(:each) do
+        subject.stub(:root_files) { Array.new }
+      end
+
+      it "returns nil" do
+        subject.download_file(:root_file, "metadata.rb", destination).should be_nil
+      end
+    end
+  end
+
+  describe "#manifest" do
+    it "returns a Hash" do
+      subject.manifest.should be_a(Hash)
+    end
+
+    it "has a key for each item in FILE_TYPES" do
+      subject.manifest.keys.should =~ described_class::FILE_TYPES
+    end
+
+    it "contains an empty array for each key" do
+      subject.manifest.should each be_a(Array)
+      subject.manifest.values.should each be_empty
+    end
+  end
+end