restful_resource 2.3.0 → 2.4.0

data/spec/restful_resource/http_client_spec.rb

@@ -16,40 +16,40 @@ RSpec.describe RestfulResource::HttpClient do
   end
 
   describe 'Basic HTTP' do
-    it 'should execute get' do
+    it 'executes get' do
       connection = faraday_connection do |stubs|
-        stubs.get('http://httpbin.org/get') { |env| [200, {}, nil] }
+        stubs.get('http://httpbin.org/get') { |_env| [200, {}, nil] }
       end
 
       response = http_client(connection).get('http://httpbin.org/get')
       expect(response.status).to eq 200
     end
 
-    it 'should execute put' do
+    it 'executes put' do
       connection = faraday_connection do |stubs|
         # Note: request body is serialized as url-encoded so the stub body must be in the same format to match
-        stubs.put('http://httpbin.org/put', 'name=Alfred') { |env| [200, {}, nil] }
+        stubs.put('http://httpbin.org/put', 'name=Alfred') { |_env| [200, {}, nil] }
       end
 
       response = http_client(connection).put('http://httpbin.org/put', data: { name: 'Alfred' })
       expect(response.status).to eq 200
     end
 
-    it 'should execute post' do
+    it 'executes post' do
       connection = faraday_connection do |stubs|
         # Note: request body is serialized as url-encoded so the stub body must be in the same format to match
-        stubs.post('http://httpbin.org/post', 'name=Alfred') { |env| [200, {}, %{"name": "Alfred"}] }
+        stubs.post('http://httpbin.org/post', 'name=Alfred') { |_env| [200, {}, %("name": "Alfred")] }
       end
 
       response = http_client(connection).post('http://httpbin.org/post', data: { name: 'Alfred' })
 
-      expect(response.body).to include "name\": \"Alfred"
+      expect(response.body).to include 'name": "Alfred'
       expect(response.status).to eq 200
     end
 
-    it 'should execute delete' do
+    it 'executes delete' do
       connection = faraday_connection do |stubs|
-        stubs.delete('http://httpbin.org/delete') { |env| [200, {}, nil] }
+        stubs.delete('http://httpbin.org/delete') { |_env| [200, {}, nil] }
       end
 
       response = http_client(connection).delete('http://httpbin.org/delete')
@@ -59,7 +59,7 @@ RSpec.describe RestfulResource::HttpClient do
 
     it 'put should raise error 409' do
       connection = faraday_connection do |stubs|
-        stubs.put('http://httpbin.org/status/409') { |env| [409, {}, nil] }
+        stubs.put('http://httpbin.org/status/409') { |_env| [409, {}, nil] }
       end
 
       expect { http_client(connection).put('http://httpbin.org/status/409') }.to raise_error(RestfulResource::HttpClient::Conflict)
@@ -67,7 +67,7 @@ RSpec.describe RestfulResource::HttpClient do
 
     it 'put should raise error 422' do
       connection = faraday_connection do |stubs|
-        stubs.put('http://httpbin.org/status/422') { |env| [422, {}, nil] }
+        stubs.put('http://httpbin.org/status/422') { |_env| [422, {}, nil] }
       end
 
       expect { http_client(connection).put('http://httpbin.org/status/422') }.to raise_error(RestfulResource::HttpClient::UnprocessableEntity)
@@ -75,7 +75,7 @@ RSpec.describe RestfulResource::HttpClient do
 
     it 'post should raise error 422' do
       connection = faraday_connection do |stubs|
-        stubs.post('http://httpbin.org/status/422') { |env| [422, {}, nil] }
+        stubs.post('http://httpbin.org/status/422') { |_env| [422, {}, nil] }
       end
 
       expect { http_client(connection).post('http://httpbin.org/status/422') }.to raise_error(RestfulResource::HttpClient::UnprocessableEntity)
@@ -83,7 +83,7 @@ RSpec.describe RestfulResource::HttpClient do
 
     it 'post should raise error 429' do
       connection = faraday_connection do |stubs|
-        stubs.post('http://httpbin.org/status/429') { |env| [429, {}, nil] }
+        stubs.post('http://httpbin.org/status/429') { |_env| [429, {}, nil] }
       end
 
       expect { http_client(connection).post('http://httpbin.org/status/429') }.to raise_error(RestfulResource::HttpClient::TooManyRequests)
@@ -91,7 +91,7 @@ RSpec.describe RestfulResource::HttpClient do
 
     it 'put should raise error 502' do
       connection = faraday_connection do |stubs|
-        stubs.put('http://httpbin.org/status/502') { |env| [502, {}, nil] }
+        stubs.put('http://httpbin.org/status/502') { |_env| [502, {}, nil] }
       end
 
       expect { http_client(connection).put('http://httpbin.org/status/502') }.to raise_error(RestfulResource::HttpClient::BadGateway)
@@ -99,7 +99,7 @@ RSpec.describe RestfulResource::HttpClient do
 
     it 'post should raise error 502' do
       connection = faraday_connection do |stubs|
-        stubs.post('http://httpbin.org/status/502') { |env| [502, {}, nil] }
+        stubs.post('http://httpbin.org/status/502') { |_env| [502, {}, nil] }
       end
 
       expect { http_client(connection).post('http://httpbin.org/status/502') }.to raise_error(RestfulResource::HttpClient::BadGateway)
@@ -107,7 +107,7 @@ RSpec.describe RestfulResource::HttpClient do
 
     it 'put should raise error 503' do
       connection = faraday_connection do |stubs|
-        stubs.put('http://httpbin.org/status/503') { |env| [503, {}, nil] }
+        stubs.put('http://httpbin.org/status/503') { |_env| [503, {}, nil] }
       end
 
       expect { http_client(connection).put('http://httpbin.org/status/503') }.to raise_error(RestfulResource::HttpClient::ServiceUnavailable)
@@ -115,18 +115,18 @@ RSpec.describe RestfulResource::HttpClient do
 
     it 'post should raise error 503' do
       connection = faraday_connection do |stubs|
-        stubs.post('http://httpbin.org/status/503') { |env| [503, {}, nil] }
+        stubs.post('http://httpbin.org/status/503') { |_env| [503, {}, nil] }
       end
 
       expect { http_client(connection).post('http://httpbin.org/status/503') }.to raise_error(RestfulResource::HttpClient::ServiceUnavailable)
     end
 
-    it 'should raise error on 404' do
+    it 'raises error on 404' do
       connection = faraday_connection do |stubs|
-        stubs.get('http://httpbin.org/status/404') { |env| [404, {}, nil] }
-        stubs.post('http://httpbin.org/status/404') { |env| [404, {}, nil] }
-        stubs.put('http://httpbin.org/status/404') { |env| [404, {}, nil] }
-        stubs.delete('http://httpbin.org/status/404') { |env| [404, {}, nil] }
+        stubs.get('http://httpbin.org/status/404') { |_env| [404, {}, nil] }
+        stubs.post('http://httpbin.org/status/404') { |_env| [404, {}, nil] }
+        stubs.put('http://httpbin.org/status/404') { |_env| [404, {}, nil] }
+        stubs.delete('http://httpbin.org/status/404') { |_env| [404, {}, nil] }
       end
 
       expect { http_client(connection).get('http://httpbin.org/status/404') }.to raise_error(RestfulResource::HttpClient::ResourceNotFound)
@@ -135,17 +135,17 @@ RSpec.describe RestfulResource::HttpClient do
       expect { http_client(connection).post('http://httpbin.org/status/404', data: { name: 'Mad cow' }) }.to raise_error(RestfulResource::HttpClient::ResourceNotFound)
     end
 
-    it 'should raise Faraday::ConnectionFailed errors' do
+    it 'raises Faraday::ConnectionFailed errors' do
       connection = faraday_connection do |stubs|
-        stubs.get('https://localhost:3005') {|env| raise Faraday::ConnectionFailed.new(nil) }
+        stubs.get('https://localhost:3005') { |_env| raise Faraday::ConnectionFailed, nil }
       end
 
       expect { http_client(connection).get('https://localhost:3005') }.to raise_error(Faraday::ConnectionFailed)
     end
 
-    it 'should raise Timeout error' do
+    it 'raises Timeout error' do
       connection = faraday_connection do |stubs|
-        stubs.get('https://localhost:3005') {|env| raise Faraday::TimeoutError.new(nil) }
+        stubs.get('https://localhost:3005') { |_env| raise Faraday::TimeoutError, nil }
       end
 
       expect { http_client(connection).get('https://localhost:3005') }.to raise_error(RestfulResource::HttpClient::Timeout)
@@ -153,7 +153,7 @@ RSpec.describe RestfulResource::HttpClient do
 
     it 'raises ClientError when a client errors with no response' do
       connection = faraday_connection do |stubs|
-        stubs.get('https://localhost:3005') {|env| raise Faraday::ClientError.new(nil) }
+        stubs.get('https://localhost:3005') { |_env| raise Faraday::ClientError, nil }
       end
 
       expect { http_client(connection).get('https://localhost:3005') }.to raise_error(RestfulResource::HttpClient::ClientError)
@@ -161,7 +161,7 @@ RSpec.describe RestfulResource::HttpClient do
 
     it 'raises OtherHttpError for other status response codes' do
       connection = faraday_connection do |stubs|
-        stubs.get('http://httpbin.org/status/418') { |env| [418, {}, nil] }
+        stubs.get('http://httpbin.org/status/418') { |_env| [418, {}, nil] }
       end
 
       expect { http_client(connection).get('http://httpbin.org/status/418') }.to raise_error(RestfulResource::HttpClient::OtherHttpError)
@@ -174,12 +174,12 @@ RSpec.describe RestfulResource::HttpClient do
         described_class.new(connection: connection, username: 'user', password: 'passwd')
       end
 
-      it 'should execute authenticated get' do
+      it 'executes authenticated get' do
         connection = faraday_connection do |stubs|
-          stubs.get('http://httpbin.org/basic-auth/user/passwd') { |env| [200, {}, nil] }
+          stubs.get('http://httpbin.org/basic-auth/user/passwd') { |_env| [200, {}, nil] }
         end
 
-        response = http_client(connection).get('http://httpbin.org/basic-auth/user/passwd', headers: {"Authorization"=>"Basic dXNlcjpwYXNzd2Q="})
+        response = http_client(connection).get('http://httpbin.org/basic-auth/user/passwd', headers: { 'Authorization' => 'Basic dXNlcjpwYXNzd2Q=' })
 
         expect(response.status).to eq 200
       end
@@ -190,12 +190,12 @@ RSpec.describe RestfulResource::HttpClient do
         described_class.new(connection: connection, auth_token: 'abc123')
       end
 
-      it 'should execute authenticated get' do
+      it 'executes authenticated get' do
         connection = faraday_connection do |stubs|
-          stubs.get('http://httpbin.org/bearer', { 'Authorization' => 'Bearer abc123'} ) { |env| [200, {}, nil] }
+          stubs.get('http://httpbin.org/bearer', 'Authorization' => 'Bearer abc123') { |_env| [200, {}, nil] }
         end
 
-        response = http_client(connection).get('http://httpbin.org/bearer', headers: { 'Authorization' => 'Bearer abc123'})
+        response = http_client(connection).get('http://httpbin.org/bearer', headers: { 'Authorization' => 'Bearer abc123' })
 
         expect(response.status).to eq 200
       end
@@ -205,7 +205,7 @@ RSpec.describe RestfulResource::HttpClient do
   describe 'Headers' do
     it 'uses custom headers' do
       connection = faraday_connection do |stubs|
-        stubs.get('http://httpbin.org/get', { 'Cache-Control' => 'no-cache' }) { |env| [200, {}, nil] }
+        stubs.get('http://httpbin.org/get', 'Cache-Control' => 'no-cache') { |_env| [200, {}, nil] }
       end
 
       response = http_client(connection).get('http://httpbin.org/get', headers: { cache_control: 'no-cache' })
@@ -221,7 +221,7 @@ RSpec.describe RestfulResource::HttpClient do
     it 'sets a default user-agent header' do
       connection = faraday_connection do |stubs|
         user_agent = "carwow/internal RestfulResource/#{RestfulResource::VERSION} Faraday/#{Faraday::VERSION}"
-        stubs.get('http://httpbin.org/get', { 'User-Agent' => user_agent }) { |env| [200, {}, nil] }
+        stubs.get('http://httpbin.org/get', 'User-Agent' => user_agent) { |_env| [200, {}, nil] }
       end
 
       response = http_client(connection).get('http://httpbin.org/get')
@@ -232,10 +232,10 @@ RSpec.describe RestfulResource::HttpClient do
     it 'sets a default user-agent header including app name' do
       connection = faraday_connection do |stubs|
         user_agent = "carwow/internal RestfulResource/#{RestfulResource::VERSION} (my-app) Faraday/#{Faraday::VERSION}"
-        stubs.get('http://httpbin.org/get', { 'User-Agent' => user_agent }) { |env| [200, {}, nil] }
+        stubs.get('http://httpbin.org/get', 'User-Agent' => user_agent) { |_env| [200, {}, nil] }
       end
 
-      response = http_client(connection, app_name: "my-app").get('http://httpbin.org/get')
+      response = http_client(connection, app_name: 'my-app').get('http://httpbin.org/get')
 
       expect(response.status).to eq 200
     end

data/spec/restful_resource/open_object_spec.rb

@@ -1,23 +1,23 @@
 require_relative '../spec_helper'
 
 describe RestfulResource::OpenObject do
-  it "should act as an openstruct" do
-    object = RestfulResource::OpenObject.new(name: 'David', surname: 'Santoro')
+  it 'acts as an openstruct' do
+    object = described_class.new(name: 'David', surname: 'Santoro')
 
     expect(object.name).to eq 'David'
     expect(object.surname).to eq 'Santoro'
   end
 
-  it "should raise an error when accessing a field that doesn't exist" do
-    object = RestfulResource::OpenObject.new({name: 'David', surname: 'Santoro'})
+  it "raises an error when accessing a field that doesn't exist" do
+    object = described_class.new(name: 'David', surname: 'Santoro')
 
     expect { object.age }.to raise_error(NoMethodError)
   end
 
-  it "should implement equality operators correctly" do
-    a = RestfulResource::OpenObject.new({name: 'Joe', age: 13})
-    b = RestfulResource::OpenObject.new({name: 'Joe', age: 13})
-    c = RestfulResource::OpenObject.new({name: 'Mike', age: 13})
+  it 'implements equality operators correctly' do
+    a = described_class.new(name: 'Joe', age: 13)
+    b = described_class.new(name: 'Joe', age: 13)
+    c = described_class.new(name: 'Mike', age: 13)
 
     list = [a, b, c]
 

data/spec/restful_resource/rails_validations_spec.rb

@@ -1,176 +1,176 @@
 require_relative '../spec_helper'
 
 RSpec.describe RestfulResource::RailsValidations do
-  before :each do
-    @mock_http = double("mock_http")
-    RestfulResource::Base.configure(base_url: "http://api.carwow.co.uk/")
+  before do
+    @mock_http = double('mock_http')
+    RestfulResource::Base.configure(base_url: 'http://api.carwow.co.uk/')
     allow(RestfulResource::Base).to receive(:http).and_return(@mock_http)
   end
 
-  context "#put without errors" do
-    before :each do
-      data = {name: 'Barak'}
-      expected_response = RestfulResource::Response.new(body: {name: 'Barak'}.to_json)
-      expect_put("http://api.carwow.co.uk/dealers/1", expected_response, data: data)
+  context '#put without errors' do
+    before do
+      data = { name: 'Barak' }
+      expected_response = RestfulResource::Response.new(body: { name: 'Barak' }.to_json)
+      expect_put('http://api.carwow.co.uk/dealers/1', expected_response, data: data)
 
       @object = Dealer.put(1, data: data)
     end
 
-    it 'should return object' do
+    it 'returns object' do
       expect(@object.name).to eq 'Barak'
     end
 
-    it 'should return valid object' do
-      expect(@object.valid?).to be_truthy
+    it 'returns valid object' do
+      expect(@object).to be_valid
     end
   end
 
-  context "#put with errors" do
+  context '#put with errors' do
     before do
-      data = {name: 'Leonardo'}
+      data = { name: 'Leonardo' }
       @error = 'Cannot use Ninja Turtles names'
-      expected_response = RestfulResource::Response.new(body: {errors: [@error]}.to_json)
-      expect_put_with_unprocessable_entity("http://api.carwow.co.uk/dealers/1", expected_response, data: data)
+      expected_response = RestfulResource::Response.new(body: { errors: [@error] }.to_json)
+      expect_put_with_unprocessable_entity('http://api.carwow.co.uk/dealers/1', expected_response, data: data)
 
       @object = Dealer.put(1, data: data)
     end
 
-    it "should have an error" do
+    it 'has an error' do
       expect(@object.errors.count).to eq 1
     end
 
-    it 'should have correct error' do
+    it 'has correct error' do
       expect(@object.errors.first).to eq @error
     end
 
-    it 'should return properly built object' do
+    it 'returns properly built object' do
       expect(@object.name).to eq 'Leonardo'
     end
 
-    it 'should return not valid object' do
-      expect(@object.valid?).to be_falsey
+    it 'returns not valid object' do
+      expect(@object).not_to be_valid
     end
 
-    it 'should handle errors returned as root object' do
-      data = {name: 'Michelangelo'}
+    it 'handles errors returned as root object' do
+      data = { name: 'Michelangelo' }
       expected_response = RestfulResource::Response.new(body: @error.to_json)
-      expect_put_with_unprocessable_entity("http://api.carwow.co.uk/dealers/1", expected_response, data: data)
+      expect_put_with_unprocessable_entity('http://api.carwow.co.uk/dealers/1', expected_response, data: data)
 
       @object = Dealer.put(1, data: data)
-      expect(@object.valid?).to be_falsey
+      expect(@object).not_to be_valid
       expect(@object.errors).to eq @error
     end
 
-    it 'should return the resource id as part of the response' do
-      data = {name: 'Michelangelo'}
+    it 'returns the resource id as part of the response' do
+      data = { name: 'Michelangelo' }
       expected_response = RestfulResource::Response.new(body: @error.to_json)
-      expect_put_with_unprocessable_entity("http://api.carwow.co.uk/dealers/1", expected_response, data: data)
+      expect_put_with_unprocessable_entity('http://api.carwow.co.uk/dealers/1', expected_response, data: data)
 
       @object = Dealer.put(1, data: data)
-      expect(@object.valid?).to be_falsey
+      expect(@object).not_to be_valid
       expect(@object.id).to be(1)
     end
   end
 
-  context "#post without errors" do
-    before :each do
-      data = {name: 'Barak'}
-      expected_response = RestfulResource::Response.new(body: {name: 'Barak'}.to_json)
-      expect_post("http://api.carwow.co.uk/dealers", expected_response, data: data)
+  context '#post without errors' do
+    before do
+      data = { name: 'Barak' }
+      expected_response = RestfulResource::Response.new(body: { name: 'Barak' }.to_json)
+      expect_post('http://api.carwow.co.uk/dealers', expected_response, data: data)
 
       @object = Dealer.post(data: data)
     end
 
-    it 'should return object' do
+    it 'returns object' do
       expect(@object.name).to eq 'Barak'
     end
 
-    it 'should return valid object' do
-      expect(@object.valid?).to be_truthy
+    it 'returns valid object' do
+      expect(@object).to be_valid
     end
   end
 
-  context "#post with errors" do
-    before :each do
-      data = {name: 'Leonardo'}
+  context '#post with errors' do
+    before do
+      data = { name: 'Leonardo' }
       @error = 'Cannot use Ninja Turtles names'
-      expected_response = RestfulResource::Response.new(body: {errors: [@error]}.to_json)
-      expect_post_with_unprocessable_entity("http://api.carwow.co.uk/dealers", expected_response, data: data)
+      expected_response = RestfulResource::Response.new(body: { errors: [@error] }.to_json)
+      expect_post_with_unprocessable_entity('http://api.carwow.co.uk/dealers', expected_response, data: data)
 
       @object = Dealer.post(data: data)
     end
 
-    it "should have an error" do
+    it 'has an error' do
       expect(@object.errors.count).to eq 1
     end
 
-    it 'should have correct error' do
+    it 'has correct error' do
       expect(@object.errors.first).to eq @error
     end
 
-    it 'should return properly built object' do
+    it 'returns properly built object' do
       expect(@object.name).to eq 'Leonardo'
     end
 
-    it 'should return not valid object' do
-      expect(@object.valid?).to be_falsey
+    it 'returns not valid object' do
+      expect(@object).not_to be_valid
     end
 
-    it 'should handle errors returned as root object' do
-      data = {name: 'Michelangelo'}
+    it 'handles errors returned as root object' do
+      data = { name: 'Michelangelo' }
       expected_response = RestfulResource::Response.new(body: @error.to_json)
-      expect_post_with_unprocessable_entity("http://api.carwow.co.uk/dealers", expected_response, data: data)
+      expect_post_with_unprocessable_entity('http://api.carwow.co.uk/dealers', expected_response, data: data)
 
       @object = Dealer.post(data: data)
-      expect(@object.valid?).to be_falsey
+      expect(@object).not_to be_valid
       expect(@object.errors).to eq @error
     end
   end
 
-  context "#get without errors" do
-    before :each do
-      expected_response = RestfulResource::Response.new(body: {name: 'Barak'}.to_json)
-      expect_get("http://api.carwow.co.uk/dealers", expected_response)
+  context '#get without errors' do
+    before do
+      expected_response = RestfulResource::Response.new(body: { name: 'Barak' }.to_json)
+      expect_get('http://api.carwow.co.uk/dealers', expected_response)
 
       @object = Dealer.get
     end
 
-    it 'should return object' do
+    it 'returns object' do
       expect(@object.name).to eq 'Barak'
     end
 
-    it 'should return valid object' do
-      expect(@object.valid?).to be_truthy
+    it 'returns valid object' do
+      expect(@object).to be_valid
     end
   end
 
-  context "#get with errors" do
-    before :each do
+  context '#get with errors' do
+    before do
       @error = 'Missing parameter'
-      expected_response = RestfulResource::Response.new(body: {errors: [@error]}.to_json)
-      expect_get_with_unprocessable_entity("http://api.carwow.co.uk/dealers", expected_response)
+      expected_response = RestfulResource::Response.new(body: { errors: [@error] }.to_json)
+      expect_get_with_unprocessable_entity('http://api.carwow.co.uk/dealers', expected_response)
 
       @object = Dealer.get
     end
 
-    it "should have an error" do
+    it 'has an error' do
       expect(@object.errors.count).to eq 1
     end
 
-    it 'should have correct error' do
+    it 'has correct error' do
       expect(@object.errors.first).to eq @error
     end
 
-    it 'should return not valid object' do
-      expect(@object.valid?).to be_falsey
+    it 'returns not valid object' do
+      expect(@object).not_to be_valid
     end
 
-    it 'should handle errors returned as root object' do
+    it 'handles errors returned as root object' do
       expected_response = RestfulResource::Response.new(body: @error.to_json)
-      expect_get_with_unprocessable_entity("http://api.carwow.co.uk/dealers", expected_response)
+      expect_get_with_unprocessable_entity('http://api.carwow.co.uk/dealers', expected_response)
 
       @object = Dealer.get
-      expect(@object.valid?).to be_falsey
+      expect(@object).not_to be_valid
       expect(@object.errors).to eq @error
     end
   end

data/spec/restful_resource/redirections_spec.rb

@@ -2,20 +2,20 @@ require_relative '../spec_helper'
 
 RSpec.describe RestfulResource::Redirections do
   before do
-    @mock_http = double("mock_http")
+    @mock_http = double('mock_http')
     allow(RestfulResource::Base).to receive(:http).and_return(@mock_http)
     RestfulResource::Base.configure(base_url: 'http://api.carwow.co.uk/')
   end
 
-  describe "#post" do
-    let(:data) { {data: 123} }
-
+  describe '#post' do
     subject { ModelWithRedirections.post(data: data) }
 
+    let(:data) { { data: 123 } }
+
     context 'with a 200 response' do
-      it 'should behave as usual' do
-        expected_response = RestfulResource::Response.new(body: {test_data: 42}.to_json)
-        expect_post("http://api.carwow.co.uk/model_with_redirections", expected_response, data: data)
+      it 'behaves as usual' do
+        expected_response = RestfulResource::Response.new(body: { test_data: 42 }.to_json)
+        expect_post('http://api.carwow.co.uk/model_with_redirections', expected_response, data: data)
 
         expect(subject.test_data).to eq 42
       end
@@ -25,48 +25,48 @@ RSpec.describe RestfulResource::Redirections do
       let(:redirect_target) { 'http://api.carwow.co.uk/model_with_redirections/123' }
 
       before do
-        allow(RestfulResource::Redirections).to receive(:wait)
-        expected_redirect_response = RestfulResource::Response.new(body: 'You are being redirected', status: 303, headers: { location: redirect_target})
-        expect_post("http://api.carwow.co.uk/model_with_redirections", expected_redirect_response, data: data)
+        allow(described_class).to receive(:wait)
+        expected_redirect_response = RestfulResource::Response.new(body: 'You are being redirected', status: 303, headers: { location: redirect_target })
+        expect_post('http://api.carwow.co.uk/model_with_redirections', expected_redirect_response, data: data)
       end
 
-      it 'should get the resource from the new location' do
-        expected_get_response = RestfulResource::Response.new(body: {test_data: 42}.to_json, status: 200)
+      it 'gets the resource from the new location' do
+        expected_get_response = RestfulResource::Response.new(body: { test_data: 42 }.to_json, status: 200)
         expect_get(redirect_target, expected_get_response)
 
         expect(subject.test_data).to eq 42
       end
 
-      it 'should wait 1.0 seconds after first redirect' do
-        expected_get_response = RestfulResource::Response.new(body: {test_data: 42}.to_json, status: 200)
+      it 'waits 1.0 seconds after first redirect' do
+        expected_get_response = RestfulResource::Response.new(body: { test_data: 42 }.to_json, status: 200)
 
-        expect(RestfulResource::Redirections).to receive(:wait).with(1.0).ordered
+        expect(described_class).to receive(:wait).with(1.0).ordered
         expect_get(redirect_target, expected_get_response).ordered
 
         expect(subject.test_data).to eq 42
       end
 
-      it 'should wait 1.0 seconds between retries' do
+      it 'waits 1.0 seconds between retries' do
         resource_not_ready_get_response = RestfulResource::Response.new(body: 'pending', status: 202)
-        resource_ready_get_response = RestfulResource::Response.new(body: {test_data: 42}.to_json, status: 200)
+        resource_ready_get_response = RestfulResource::Response.new(body: { test_data: 42 }.to_json, status: 200)
 
-        expect(RestfulResource::Redirections).to receive(:wait).with(1.0).ordered
+        expect(described_class).to receive(:wait).with(1.0).ordered
         expect_get(redirect_target, resource_not_ready_get_response).ordered
-        expect(RestfulResource::Redirections).to receive(:wait).with(1.0).ordered
+        expect(described_class).to receive(:wait).with(1.0).ordered
         expect_get(redirect_target, resource_ready_get_response).ordered
 
         expect(subject.test_data).to eq 42
       end
 
-      it 'should retry 10 times by default' do
+      it 'retries 10 times by default' do
         resource_not_ready_get_response = RestfulResource::Response.new(body: 'pending', status: 202)
-        resource_ready_get_response = RestfulResource::Response.new(body: {test_data: 42}.to_json, status: 200)
+        resource_ready_get_response = RestfulResource::Response.new(body: { test_data: 42 }.to_json, status: 200)
 
         9.times do
-          expect(RestfulResource::Redirections).to receive(:wait).with(1.0).ordered
+          expect(described_class).to receive(:wait).with(1.0).ordered
           expect_get(redirect_target, resource_not_ready_get_response).ordered
         end
-        expect(RestfulResource::Redirections).to receive(:wait).with(1.0).ordered
+        expect(described_class).to receive(:wait).with(1.0).ordered
         expect_get(redirect_target, resource_ready_get_response).ordered
 
         expect(subject.test_data).to eq 42
@@ -74,14 +74,14 @@ RSpec.describe RestfulResource::Redirections do
 
       it 'raise after max_retries value is reached' do
         resource_not_ready_get_response = RestfulResource::Response.new(body: 'pending', status: 202)
-        resource_ready_get_response = RestfulResource::Response.new(body: {test_data: 42}.to_json, status: 200)
+        resource_ready_get_response = RestfulResource::Response.new(body: { test_data: 42 }.to_json, status: 200)
 
         11.times do
-          expect(RestfulResource::Redirections).to receive(:wait).with(1.0).ordered
+          expect(described_class).to receive(:wait).with(1.0).ordered
           expect_get(redirect_target, resource_not_ready_get_response).ordered
         end
 
-        expect{subject}.to raise_error(RestfulResource::MaximumAttemptsReached)
+        expect { subject }.to raise_error(RestfulResource::MaximumAttemptsReached)
       end
     end
   end