restful_resource 2.3.0 → 2.4.0

data/spec/restful_resource/base_spec.rb

@@ -2,13 +2,13 @@ require_relative '../spec_helper'
 
 RSpec.describe RestfulResource::Base do
   before do
-    @mock_http = double("mock_http")
-    allow(RestfulResource::Base).to receive(:http).and_return(@mock_http)
-    RestfulResource::Base.configure(base_url: 'http://api.carwow.co.uk/')
+    @mock_http = double('mock_http')
+    allow(described_class).to receive(:http).and_return(@mock_http)
+    described_class.configure(base_url: 'http://api.carwow.co.uk/')
   end
 
-  it "should act as an openobject" do
-    object = RestfulResource::Base.new(name: 'David', surname: 'Santoro')
+  it 'acts as an openobject' do
+    object = described_class.new(name: 'David', surname: 'Santoro')
 
     expect(object.name).to eq 'David'
     expect(object.surname).to eq 'Santoro'
@@ -16,15 +16,15 @@ RSpec.describe RestfulResource::Base do
   end
 
   describe '#parse_json' do
-    it 'should not fail on empty string' do
-      expect {RestfulResource::Base.send(:parse_json, ' ')}.not_to raise_error
+    it 'does not fail on empty string' do
+      expect { described_class.send(:parse_json, ' ') }.not_to raise_error
     end
   end
 
-  describe "#find" do
-    it "should return an object instance for the correct id" do
-      expected_response = RestfulResource::Response.new(body: {id: 12}.to_json)
-      expect_get("http://api.carwow.co.uk/makes/12", expected_response)
+  describe '#find' do
+    it 'returns an object instance for the correct id' do
+      expected_response = RestfulResource::Response.new(body: { id: 12 }.to_json)
+      expect_get('http://api.carwow.co.uk/makes/12', expected_response)
 
       object = Make.find(12)
 
@@ -32,56 +32,58 @@ RSpec.describe RestfulResource::Base do
       expect(object.id).to be 12
     end
 
-    it "should return an object instance for nested routes" do
-      expected_response = RestfulResource::Response.new(body: {name: 'Golf', price: 15000}.to_json)
-      expect_get("http://api.carwow.co.uk/groups/15/makes/Volkswagen/models/Golf", expected_response)
+    it 'returns an object instance for nested routes' do
+      expected_response = RestfulResource::Response.new(body: { name: 'Golf', price: 15_000 }.to_json)
+      expect_get('http://api.carwow.co.uk/groups/15/makes/Volkswagen/models/Golf', expected_response)
 
       object = Model.find('Golf', make_slug: 'Volkswagen', group_id: 15)
 
       expect(object).not_to be_nil
       expect(object.name).to eq 'Golf'
-      expect(object.price).to eq 15000
+      expect(object.price).to eq 15_000
     end
 
-    it "should encode parameters correctly in the url" do
-      expected_response = RestfulResource::Response.new(body: {name: 'Golf', price: 15000}.to_json)
-      expect_get("http://api.carwow.co.uk/groups/xxx+yyy%3Fl%3D7/makes/Land+Rover%3Fx%3D0.123/models/Golf+Cabriolet%3Ftest", expected_response)
+    it 'encodes parameters correctly in the url' do
+      expected_response = RestfulResource::Response.new(body: { name: 'Golf', price: 15_000 }.to_json)
+      expect_get('http://api.carwow.co.uk/groups/xxx+yyy%3Fl%3D7/makes/Land+Rover%3Fx%3D0.123/models/Golf+Cabriolet%3Ftest', expected_response)
 
       object = Model.find('Golf Cabriolet?test', make_slug: 'Land Rover?x=0.123', group_id: 'xxx yyy?l=7')
     end
 
     it 'accepts custom headers' do
-      expect_get("http://api.carwow.co.uk/makes/12",
+      expect_get('http://api.carwow.co.uk/makes/12',
         RestfulResource::Response.new,
-        headers: { cache_control: 'no-cache' })
+        headers: { cache_control: 'no-cache' }
+      )
 
       Make.find(12, headers: { cache_control: 'no-cache' })
     end
 
     it 'accepts no_cache option' do
-      expect_get("http://api.carwow.co.uk/makes/12",
+      expect_get('http://api.carwow.co.uk/makes/12',
         RestfulResource::Response.new,
-        headers: { cache_control: 'no-cache' })
+        headers: { cache_control: 'no-cache' }
+      )
 
       Make.find(12, no_cache: true)
     end
   end
 
-  describe "#where" do
-    it "should return an array of objects" do
-      expected_response = RestfulResource::Response.new(body: [{name: 'Golf', price: 15000}, {name: 'Polo', price: 11000}].to_json)
-      expect_get("http://api.carwow.co.uk/groups/15/makes/Volkswagen/models?on_sale=true", expected_response)
+  describe '#where' do
+    it 'returns an array of objects' do
+      expected_response = RestfulResource::Response.new(body: [{ name: 'Golf', price: 15_000 }, { name: 'Polo', price: 11_000 }].to_json)
+      expect_get('http://api.carwow.co.uk/groups/15/makes/Volkswagen/models?on_sale=true', expected_response)
       object = Model.where(make_slug: 'Volkswagen', on_sale: true, group_id: 15)
 
       expect(object).not_to be_nil
       expect(object.length).to eq 2
       expect(object.first.name).to eq 'Golf'
-      expect(object.first.price).to eq 15000
+      expect(object.first.price).to eq 15_000
     end
 
-    it "should provide a paginated result if response contains rest pagination headers" do
-      expected_response = response_with_page_information()
-      expect_get("http://api.carwow.co.uk/groups/15/makes/Volkswagen/models", expected_response)
+    it 'provides a paginated result if response contains rest pagination headers' do
+      expected_response = response_with_page_information
+      expect_get('http://api.carwow.co.uk/groups/15/makes/Volkswagen/models', expected_response)
 
       models = Model.where(group_id: 15, make_slug: 'Volkswagen')
 
@@ -92,26 +94,28 @@ RSpec.describe RestfulResource::Base do
     end
 
     it 'accepts custom headers' do
-      expect_get("http://api.carwow.co.uk/groups/15/makes/Volkswagen/models?on_sale=true",
+      expect_get('http://api.carwow.co.uk/groups/15/makes/Volkswagen/models?on_sale=true',
         RestfulResource::Response.new,
-        headers: { cache_control: 'no-cache' })
+        headers: { cache_control: 'no-cache' }
+      )
 
       Model.where(make_slug: 'Volkswagen', on_sale: true, group_id: 15, headers: { cache_control: 'no-cache' })
     end
 
     it 'accepts no_cache option' do
-      expect_get("http://api.carwow.co.uk/groups/15/makes/Volkswagen/models?on_sale=true",
+      expect_get('http://api.carwow.co.uk/groups/15/makes/Volkswagen/models?on_sale=true',
         RestfulResource::Response.new,
-        headers: { cache_control: 'no-cache' })
+        headers: { cache_control: 'no-cache' }
+      )
 
       Model.where(make_slug: 'Volkswagen', on_sale: true, group_id: 15, no_cache: true)
     end
   end
 
-  describe "#all" do
-    it "should return all items" do
-      expected_response = RestfulResource::Response.new(body: [{name: 'Volkswagen'}, {name: 'Audi'}].to_json)
-      expect_get("http://api.carwow.co.uk/makes", expected_response)
+  describe '#all' do
+    it 'returns all items' do
+      expected_response = RestfulResource::Response.new(body: [{ name: 'Volkswagen' }, { name: 'Audi' }].to_json)
+      expect_get('http://api.carwow.co.uk/makes', expected_response)
       makes = Make.all
 
       expect(makes).not_to be_nil
@@ -120,47 +124,49 @@ RSpec.describe RestfulResource::Base do
     end
 
     it 'accepts custom headers' do
-      expect_get("http://api.carwow.co.uk/makes",
+      expect_get('http://api.carwow.co.uk/makes',
         RestfulResource::Response.new,
-        headers: { cache_control: 'no-cache' })
+        headers: { cache_control: 'no-cache' }
+      )
 
       Make.all(headers: { cache_control: 'no-cache' })
     end
 
     it 'accepts no_cache option' do
-      expect_get("http://api.carwow.co.uk/makes",
+      expect_get('http://api.carwow.co.uk/makes',
         RestfulResource::Response.new,
-        headers: { cache_control: 'no-cache' })
+        headers: { cache_control: 'no-cache' }
+      )
 
       Make.all(no_cache: true)
     end
   end
 
-  describe "#base_url" do
-    it "should be different for each subclass of Base" do
-      BaseA.configure(base_url: "http://a.carwow.co.uk")
+  describe '#base_url' do
+    it 'is different for each subclass of Base' do
+      BaseA.configure(base_url: 'http://a.carwow.co.uk')
 
-      BaseB.configure(base_url: "http://b.carwow.co.uk")
+      BaseB.configure(base_url: 'http://b.carwow.co.uk')
 
-      expect_get('http://a.carwow.co.uk/testa/1', RestfulResource::Response.new())
-      expect_get('http://b.carwow.co.uk/testb/2', RestfulResource::Response.new())
+      expect_get('http://a.carwow.co.uk/testa/1', RestfulResource::Response.new)
+      expect_get('http://b.carwow.co.uk/testb/2', RestfulResource::Response.new)
 
       TestA.find(1)
       TestB.find(2)
     end
   end
 
-  describe "#action" do
-    it "should retrieve a resource using a custom action" do
-      expect_get('http://api.carwow.co.uk/makes/15/lazy', RestfulResource::Response.new(body: {name: 'Volk.'}.to_json))
+  describe '#action' do
+    it 'retrieves a resource using a custom action' do
+      expect_get('http://api.carwow.co.uk/makes/15/lazy', RestfulResource::Response.new(body: { name: 'Volk.' }.to_json))
 
       make = Make.action(:lazy).find(15)
 
       expect(make.name).to eq 'Volk.'
     end
 
-    it 'should retrieve many resources using a custom action' do
-      expect_get('http://api.carwow.co.uk/makes/available', RestfulResource::Response.new(body: [{name: 'Audi'}, {name: 'Fiat'}].to_json))
+    it 'retrieves many resources using a custom action' do
+      expect_get('http://api.carwow.co.uk/makes/available', RestfulResource::Response.new(body: [{ name: 'Audi' }, { name: 'Fiat' }].to_json))
 
       make = Make.action(:available).all
 
@@ -169,36 +175,38 @@ RSpec.describe RestfulResource::Base do
     end
   end
 
-  describe "#get" do
-    it "should return an open_object" do
-      expected_response = RestfulResource::Response.new(body: {average_score: 4.3}.to_json, status: 200)
+  describe '#get' do
+    it 'returns an open_object' do
+      expected_response = RestfulResource::Response.new(body: { average_score: 4.3 }.to_json, status: 200)
       expect_get('http://api.carwow.co.uk/makes/average_score?make_slug%5B%5D=Volkswagen&make_slug%5B%5D=Audi', expected_response)
 
-      object = Make.action(:average_score).get(make_slug: ['Volkswagen', 'Audi'])
+      object = Make.action(:average_score).get(make_slug: %w[Volkswagen Audi])
 
       expect(object.average_score).to eq 4.3
     end
 
     it 'accepts custom headers' do
-      expect_get("http://api.carwow.co.uk/makes/average_score",
+      expect_get('http://api.carwow.co.uk/makes/average_score',
         RestfulResource::Response.new,
-        headers: { cache_control: 'no-cache' })
+        headers: { cache_control: 'no-cache' }
+      )
 
       Make.action(:average_score).get(headers: { cache_control: 'no-cache' })
     end
 
     it 'accepts no_cache option' do
-      expect_get("http://api.carwow.co.uk/makes/average_score",
+      expect_get('http://api.carwow.co.uk/makes/average_score',
         RestfulResource::Response.new,
-        headers: { cache_control: 'no-cache' })
+        headers: { cache_control: 'no-cache' }
+      )
 
       Make.action(:average_score).get(no_cache: true)
     end
   end
 
-  describe "#put" do
-    it 'should put no data with no params' do
-      expected_response = RestfulResource::Response.new(body: {name: 'Audi'}.to_json, status: 200)
+  describe '#put' do
+    it 'puts no data with no params' do
+      expected_response = RestfulResource::Response.new(body: { name: 'Audi' }.to_json, status: 200)
       expect_put('http://api.carwow.co.uk/makes/1', expected_response)
 
       object = Make.put(1)
@@ -206,8 +214,8 @@ RSpec.describe RestfulResource::Base do
       expect(object.name).to eq 'Audi'
     end
 
-    it 'should put no data with no params passed' do
-      expected_response = RestfulResource::Response.new(body: {name: 'Audi'}.to_json, status: 200)
+    it 'puts no data with no params passed' do
+      expected_response = RestfulResource::Response.new(body: { name: 'Audi' }.to_json, status: 200)
       expect_put('http://api.carwow.co.uk/makes/1?make_slug=Volkswagen', expected_response)
 
       object = Make.put(1, make_slug: 'Volkswagen')
@@ -215,21 +223,21 @@ RSpec.describe RestfulResource::Base do
       expect(object.name).to eq 'Audi'
     end
 
-    it 'should put data with params passed' do
-      data = {make_slug: 'Audi'}
+    it 'puts data with params passed' do
+      data = { make_slug: 'Audi' }
 
-      expected_response = RestfulResource::Response.new(body: {name: 'Audi'}.to_json, status: 200)
+      expected_response = RestfulResource::Response.new(body: { name: 'Audi' }.to_json, status: 200)
       expect_put('http://api.carwow.co.uk/makes/1', expected_response, data: data)
 
-      object = Make.put(1, data: {make_slug: 'Audi'})
+      object = Make.put(1, data: { make_slug: 'Audi' })
 
       expect(object.name).to eq 'Audi'
     end
 
-    it 'should put data with params passed' do
-      data = {make_slug: 'Audi'}
+    it 'puts data with params passed' do
+      data = { make_slug: 'Audi' }
 
-      expected_response = RestfulResource::Response.new(body: {name: 'Audi'}.to_json, status: 200)
+      expected_response = RestfulResource::Response.new(body: { name: 'Audi' }.to_json, status: 200)
       expect_put('http://api.carwow.co.uk/makes/1?make_slug=Volkswagen', expected_response, data: data)
 
       object = Make.put(1, data: data, make_slug: 'Volkswagen')
@@ -238,17 +246,18 @@ RSpec.describe RestfulResource::Base do
     end
 
     it 'accepts custom headers' do
-      expect_put("http://api.carwow.co.uk/makes/1",
+      expect_put('http://api.carwow.co.uk/makes/1',
         RestfulResource::Response.new,
-        headers: { accept: 'application/json' })
+        headers: { accept: 'application/json' }
+      )
 
       Make.put(1, data: {}, headers: { accept: 'application/json' })
     end
   end
 
-  describe "#post" do
-    it "should post parameters to the collection url" do
-      data = {slug: 'audi-make', name: 'Audi', num_of_cars: 3}
+  describe '#post' do
+    it 'posts parameters to the collection url' do
+      data = { slug: 'audi-make', name: 'Audi', num_of_cars: 3 }
 
       expected_response = RestfulResource::Response.new(body: data.to_json, status: 200)
       expect_post('http://api.carwow.co.uk/makes', expected_response, data: data)
@@ -260,17 +269,18 @@ RSpec.describe RestfulResource::Base do
     end
 
     it 'accepts custom headers' do
-      expect_post("http://api.carwow.co.uk/makes",
+      expect_post('http://api.carwow.co.uk/makes',
         RestfulResource::Response.new,
-        headers: { accept: 'application/json' })
+        headers: { accept: 'application/json' }
+      )
 
       Make.post(data: {}, headers: { accept: 'application/json' })
     end
   end
 
-  describe "#delete" do
-    it "should delete to the member url" do
-      expected_response = RestfulResource::Response.new(body: {deleted: true}.to_json, status: 200)
+  describe '#delete' do
+    it 'deletes to the member url' do
+      expected_response = RestfulResource::Response.new(body: { deleted: true }.to_json, status: 200)
       expect_delete('http://api.carwow.co.uk/makes/1', expected_response)
 
       object = Make.delete(1)
@@ -279,68 +289,75 @@ RSpec.describe RestfulResource::Base do
     end
 
     it 'accepts custom headers' do
-      expect_delete("http://api.carwow.co.uk/makes/1",
+      expect_delete('http://api.carwow.co.uk/makes/1',
         RestfulResource::Response.new,
-        headers: { accept: 'application/json' })
+        headers: { accept: 'application/json' }
+      )
 
       Make.delete(1, headers: { accept: 'application/json' })
     end
   end
 
-  describe ".as_json" do
-    before :each do
-      expected_response = RestfulResource::Response.new(body: [{name: 'Audi', slug: 'Audi-Slug'}, {name: 'Fiat', slug: 'Fiat-Slug'}].to_json)
+  describe '.as_json' do
+    before do
+      expected_response = RestfulResource::Response.new(body: [{ name: 'Audi', slug: 'Audi-Slug' }, { name: 'Fiat', slug: 'Fiat-Slug' }].to_json)
       expect_get('http://api.carwow.co.uk/makes', expected_response)
 
       @makes = Make.all
     end
 
-    it 'should not return inner object table' do
-      expect(@makes.first.as_json).to eq ({'name' => 'Audi', 'slug' => 'Audi-Slug'})
+    it 'does not return inner object table' do
+      expect(@makes.first.as_json).to eq ({ 'name' => 'Audi', 'slug' => 'Audi-Slug' })
     end
 
-    it 'should return inner object table on selected fields' do
-      expect(@makes.last.as_json(only: [:name])).to eq ({'name' => 'Fiat'})
+    it 'returns inner object table on selected fields' do
+      expect(@makes.last.as_json(only: [:name])).to eq ({ 'name' => 'Fiat' })
     end
   end
 
-  describe ".member_url" do
-    it "requires a member ID" do
-      expect{ RestfulResource::Base.member_url('', {}) }.to raise_error(RestfulResource::ResourceIdMissingError)
+  describe '.member_url' do
+    it 'requires a member ID' do
+      expect { described_class.member_url('', {}) }.to raise_error(RestfulResource::ResourceIdMissingError)
     end
   end
 
-  describe ".configure" do
-     let(:username) { double }
-     let(:password) { double }
-     let(:auth_token) { double }
-     let(:logger) { double }
-     let(:cache_store) { double }
-     let(:instrumentation) { double }
-     let(:faraday_config) { double }
-
-    it "passes arguments to HttpClient" do
+  describe '.configure' do
+    let(:username) { double }
+    let(:password) { double }
+    let(:auth_token) { double }
+    let(:logger) { double }
+    let(:cache_store) { double }
+    let(:instrumentation) { double }
+    let(:faraday_config) { double }
+    let(:faraday_options) { double }
+
+    it 'passes arguments to HttpClient' do
       expect(RestfulResource::HttpClient).to receive(:new).with(username: username,
                                                                 password: password,
                                                                 auth_token: auth_token,
                                                                 logger: logger,
                                                                 cache_store: cache_store,
                                                                 instrumentation: instrumentation,
-                                                                faraday_config: faraday_config)
-
-      RestfulResource::Base.configure(base_url: 'http://foo.bar',
-                                      username: username,
-                                      password: password,
-                                      auth_token: auth_token,
-                                      logger: logger,
-                                      cache_store: cache_store,
-                                      instrumentation: instrumentation,
-                                      faraday_config: faraday_config)
+                                                                faraday_config: faraday_config,
+                                                                faraday_options: faraday_options
+                                                               )
+
+      described_class.configure(base_url: 'http://foo.bar',
+                                username: username,
+                                password: password,
+                                auth_token: auth_token,
+                                logger: logger,
+                                cache_store: cache_store,
+                                instrumentation: instrumentation,
+                                faraday_config: faraday_config,
+                                faraday_options: faraday_options
+                               )
     end
   end
 
   def response_with_page_information
-    RestfulResource::Response.new(body: [{ id: 1, name: 'Golf'}, { id: 2, name: 'Polo' }].to_json,
-                                 headers: { links: '<http://api.carwow.co.uk/makes/Volkswagen/models.json?page=6>;rel="last",<http://api.carwow.co.uk/makes/Volkswagen/models.json?page=2>;rel="next"'})
+    RestfulResource::Response.new(body: [{ id: 1, name: 'Golf' }, { id: 2, name: 'Polo' }].to_json,
+                                  headers: { links: '<http://api.carwow.co.uk/makes/Volkswagen/models.json?page=6>;rel="last",<http://api.carwow.co.uk/makes/Volkswagen/models.json?page=2>;rel="next"' }
+                                 )
   end
 end

data/spec/restful_resource/http_client_configuration_spec.rb

@@ -2,21 +2,19 @@ require_relative '../spec_helper'
 
 describe RestfulResource::HttpClient do
   def find_middleware(adapter, name)
-    adapter.builder.handlers.find {|m| m.name == name }
-
-    rescue
-      raise "Could not find Faraday middleware: #{name}"
+    adapter.builder.handlers.find { |m| m.name == name }
+  rescue StandardError
+    raise "Could not find Faraday middleware: #{name}"
   end
 
   def find_middleware_args(adapter, name)
-    find_middleware(adapter, name).instance_variable_get("@args").first
-
-    rescue
-      raise "Could not find args for Faraday middleware: #{name}"
+    find_middleware(adapter, name).instance_variable_get('@args').first
+  rescue StandardError
+    raise "Could not find args for Faraday middleware: #{name}"
   end
 
   describe 'Configuration' do
-    let(:connection) { described_class.new.instance_variable_get("@connection") }
+    let(:connection) { described_class.new.instance_variable_get('@connection') }
     let(:middleware) { connection.builder.handlers }
 
     describe 'Builder configuration' do
@@ -48,7 +46,7 @@ describe RestfulResource::HttpClient do
         end
 
         context 'with an api_name' do
-          let(:connection) { described_class.new(instrumentation: { api_name: 'my_api_name'}).instance_variable_get("@connection") }
+          let(:connection) { described_class.new(instrumentation: { api_name: 'my_api_name' }).instance_variable_get('@connection') }
 
           it 'uses default instrumenter with the api_name' do
             expect(find_middleware_args(connection, 'FaradayMiddleware::Instrumentation')).to include(name: 'http.my_api_name')
@@ -56,7 +54,7 @@ describe RestfulResource::HttpClient do
         end
 
         context 'with a custom instrumentation key' do
-          let(:connection) { described_class.new(instrumentation: { request_instrument_name: 'foo.bar'}).instance_variable_get("@connection") }
+          let(:connection) { described_class.new(instrumentation: { request_instrument_name: 'foo.bar' }).instance_variable_get('@connection') }
 
           it 'uses default instrumenter with the custom key' do
             expect(find_middleware_args(connection, 'FaradayMiddleware::Instrumentation')).to include(name: 'foo.bar')
@@ -66,7 +64,9 @@ describe RestfulResource::HttpClient do
         context 'with a given Metrics class' do
           class FakeMetrics
             def count(name, value); end
+
             def sample(name, value); end
+
             def measure(name, value); end
           end
 
@@ -78,7 +78,7 @@ describe RestfulResource::HttpClient do
           end
 
           it 'initializes the Instrumentation' do
-            described_class.new(instrumentation: { app_name: 'rails', api_name: 'api', metric_class: FakeMetrics})
+            described_class.new(instrumentation: { app_name: 'rails', api_name: 'api', metric_class: FakeMetrics })
 
             expect(RestfulResource::Instrumentation).to have_received(:new)
                                                .with(app_name: 'rails',
@@ -86,11 +86,12 @@ describe RestfulResource::HttpClient do
                                                      request_instrument_name: 'http.api',
                                                      cache_instrument_name: 'http_cache.api',
                                                      server_cache_instrument_name: 'cdn_metrics.api',
-                                                     metric_class: FakeMetrics)
+                                                     metric_class: FakeMetrics
+                                                    )
           end
 
           it 'subscribes to the notifications' do
-            described_class.new(instrumentation: { app_name: 'rails', api_name: 'api', metric_class: FakeMetrics})
+            described_class.new(instrumentation: { app_name: 'rails', api_name: 'api', metric_class: FakeMetrics })
 
             expect(mock_instrumention).to have_received(:subscribe_to_notifications)
           end
@@ -98,7 +99,7 @@ describe RestfulResource::HttpClient do
       end
 
       describe 'when provided a logger' do
-        let(:connection) { described_class.new(logger: logger).instance_variable_get("@connection") }
+        let(:connection) { described_class.new(logger: logger).instance_variable_get('@connection') }
         let(:logger) { Logger.new('/dev/null') }
 
         it 'uses the logger middleware' do
@@ -111,7 +112,7 @@ describe RestfulResource::HttpClient do
       end
 
       describe 'when provided a cache store' do
-        let(:connection) { described_class.new(cache_store: 'redis').instance_variable_get("@connection") }
+        let(:connection) { described_class.new(cache_store: 'redis').instance_variable_get('@connection') }
 
         it 'uses the cache_store middleware' do
           expect(middleware).to include Faraday::HttpCache
@@ -122,7 +123,7 @@ describe RestfulResource::HttpClient do
         end
 
         context 'and an api_name is provided' do
-          let(:connection) { described_class.new(cache_store: 'redis', instrumentation: { api_name: 'my_api_name'}).instance_variable_get("@connection") }
+          let(:connection) { described_class.new(cache_store: 'redis', instrumentation: { api_name: 'my_api_name' }).instance_variable_get('@connection') }
 
           it 'passes the instrumenter and the api_name' do
             expect(find_middleware_args(connection, 'Faraday::HttpCache')).to include(instrumenter: ActiveSupport::Notifications, instrument_name: 'http_cache.my_api_name')
@@ -130,7 +131,7 @@ describe RestfulResource::HttpClient do
         end
 
         context 'and a custom instrument name is provided' do
-          let(:connection) { described_class.new(cache_store: 'redis', instrumentation: { cache_instrument_name: 'foo.bar'}).instance_variable_get("@connection") }
+          let(:connection) { described_class.new(cache_store: 'redis', instrumentation: { cache_instrument_name: 'foo.bar' }).instance_variable_get('@connection') }
 
           it 'passes the instrumenter to the http cache middleware' do
             expect(find_middleware_args(connection, 'Faraday::HttpCache')).to include(instrumenter: ActiveSupport::Notifications, instrument_name: 'foo.bar')
@@ -142,7 +143,7 @@ describe RestfulResource::HttpClient do
         let(:faraday_config_block) do
           proc { |conn| @block_arg = conn }
         end
-        let(:connection) { described_class.new(faraday_config: faraday_config_block).instance_variable_get("@connection") }
+        let(:connection) { described_class.new(faraday_config: faraday_config_block).instance_variable_get('@connection') }
 
         it 'passes faraday connection instance and calls it' do
           connection