reform 2.2.4 → 2.3.3

data/test/skip_if_test.rb

@@ -1,74 +0,0 @@
-require 'test_helper'
-
-class SkipIfTest < BaseTest
-
-  class AlbumForm < Reform::Form
-    property :title
-
-    property :hit, skip_if: lambda { |options| options[:fragment]["title"]=="" } do
-      property :title
-      validation do
-        key(:title).required
-      end
-    end
-
-    collection :songs, skip_if: :skip_song?, populate_if_empty: BaseTest::Song do
-      property :title
-    end
-
-    def skip_song?(options)
-      options[:fragment]["title"].nil?
-    end
-  end
-
-
-  let (:hit) { Song.new }
-  let (:album) { Album.new(nil, hit, [], nil) }
-
-  # deserializes when present.
-  it do
-    form = AlbumForm.new(album)
-    form.validate("hit" => {"title" => "Altar Of Sacrifice"}).must_equal true
-    form.hit.title.must_equal "Altar Of Sacrifice"
-  end
-
-  # skips deserialization when not present.
-  it do
-    form = AlbumForm.new(Album.new)
-    form.validate("hit" => {"title" => ""}).must_equal true
-    form.hit.must_equal nil # hit hasn't been deserialised.
-  end
-
-  # skips deserialization when not present.
-  it do
-    form = AlbumForm.new(Album.new(nil, nil, []))
-    form.validate("songs" => [{"title" => "Waste Of Breath"}, {"title" => nil}]).must_equal true
-    form.songs.size.must_equal 1
-    form.songs[0].title.must_equal "Waste Of Breath"
-  end
-end
-
-class SkipIfAllBlankTest < BaseTest
-  # skip_if: :all_blank"
-  class AlbumForm < Reform::Form
-    collection :songs, skip_if: :all_blank, populate_if_empty: BaseTest::Song do
-      property :title
-      property :length
-    end
-  end
-
-  # create only one object.
-  it do
-    form = AlbumForm.new(OpenStruct.new(songs: []))
-    form.validate("songs" => [{"title"=>"Apathy"}, {"title"=>"", "length" => ""}]).must_equal true
-    form.songs.size.must_equal 1
-    form.songs[0].title.must_equal "Apathy"
-  end
-
-  it do
-    form = AlbumForm.new(OpenStruct.new(songs: []))
-    form.validate("songs" => [{"title"=>"", "length" => ""}, {"title"=>"Apathy"}]).must_equal true
-    form.songs.size.must_equal 1
-    form.songs[0].title.must_equal "Apathy"
-  end
-end

data/test/validation/dry_test.rb

@@ -1,60 +0,0 @@
-# require "test_helper"
-# require "reform/form/dry"
-
-# class BlaTest < MiniTest::Spec
-#   class CartForm < Reform::Form
-#     include Reform::Form::Dry::Validations
-
-#     property :user_id
-
-#     collection :variants do
-#       property :id
-#     end
-
-
-#     validation :default do
-#       key(:user_id).required
-
-#       key(:variants).schema do
-#         each do
-#           key(:id).required
-#         end
-#       end
-
-#       configure do
-#         config.messages_file = 'test/validation/errors.yml'
-
-#         option :form
-#         # message need to be defined on fixtures/dry_error_messages
-#         # d-v expects you to define your custome messages on the .yml file
-
-
-#         def form_access_validation?(value)
-#           raise value.inspect
-#           form.title == 'Reform'
-#         end
-#       end
-
-#       rule(form_present: [:form]) do |form|
-#         form.user_id == "hallo"
-#       end
-#     end
-#   end
-
-#   it do
-#     cart = Struct.new(:user_id, :variants).new(1, [Struct.new(:id).new])
-
-#     form = CartForm.new(cart)
-#     form.validate(user_id: 2, variants: [{id: 3}])
-#     puts form.errors.inspect
-#   end
-# end
-
-
-# # current_id: BlaTest
-# # cart: {
-# #   carts: {
-# #     products: [{current_id}]
-# #   }
-
-# # }

data/test/validation/dry_validation_test.rb

@@ -1,352 +0,0 @@
-require "test_helper"
-require "reform/form/dry"
-
-class DryValidationDefaultGroupTest < Minitest::Spec
-  Session = Struct.new(:username, :email, :password, :confirm_password)
-
-  class SessionForm < Reform::Form
-    include Reform::Form::Dry
-
-    property :username
-    property :email
-    property :password
-    property :confirm_password
-
-    validation do
-      key(:username).required
-      key(:email).required
-    end
-  end
-
-  let (:form) { SessionForm.new(Session.new) }
-
-  # valid.
-  it do
-    form.validate(username: "Helloween",
-                  email:    "yep").must_equal true
-    form.errors.messages.inspect.must_equal "{}"
-  end
-end
-
-class ValidationGroupsTest < MiniTest::Spec
-  describe "basic validations" do
-    Session = Struct.new(:username, :email, :password, :confirm_password)
-
-    class SessionForm < Reform::Form
-      include Reform::Form::Dry::Validations
-
-      property :username
-      property :email
-      property :password
-      property :confirm_password
-
-      validation :default do
-        key(:username).required
-        key(:email).required
-      end
-
-      validation :email, if: :default do
-        key(:email).required(min_size?: 3)
-      end
-
-      validation :nested, if: :default do
-        key(:password).required(min_size?: 2)
-      end
-
-      validation :confirm, if: :default, after: :email do
-        key(:confirm_password).required(min_size?: 2)
-      end
-    end
-
-    let (:form) { SessionForm.new(Session.new) }
-
-    # valid.
-    it do
-      form.validate({ username: "Helloween",
-                      email: "yep",
-                      password: "99",
-                      confirm_password: "99" }).must_equal true
-      form.errors.messages.inspect.must_equal "{}"
-    end
-
-    # invalid.
-    it do
-      form.validate({}).must_equal false
-      form.errors.messages.inspect.must_equal "{:username=>[\"is missing\"], :email=>[\"is missing\"]}"
-    end
-
-    # partially invalid.
-    # 2nd group fails.
-    it do
-      form.validate(username: "Helloween", email: "yo", confirm_password:"9").must_equal false
-      form.errors.messages.inspect.must_equal "{:email=>[\"size cannot be less than 3\"], :confirm_password=>[\"size cannot be less than 2\"], :password=>[\"is missing\", \"size cannot be less than 2\"]}"
-    end
-    # 3rd group fails.
-    it do
-      form.validate(username: "Helloween", email: "yo!", confirm_password:"9").must_equal false
-      form.errors.messages.inspect
-      .must_equal "{:confirm_password=>[\"size cannot be less than 2\"], :password=>[\"is missing\", \"size cannot be less than 2\"]}"
-    end
-    # 4th group with after: fails.
-    it do
-      form.validate(username: "Helloween", email: "yo!", password: "", confirm_password: "9").must_equal false
-      form.errors.messages.inspect.must_equal "{:confirm_password=>[\"size cannot be less than 2\"], :password=>[\"must be filled\", \"size cannot be less than 2\"]}"
-    end
-  end
-
-  describe "Nested validations" do
-    class AlbumForm < Reform::Form
-      include Reform::Form::Dry::Validations
-
-      property :title
-
-      property :hit do
-        property :title
-
-        # FIX ME: this doesn't work now, @apotonick said he knows why
-        #  The error is that this validation block act as an AM:V instead of the Dry one.
-        # validation :default do
-        #   key(:title, &:filled?)
-        # end
-      end
-
-      collection :songs do
-        property :title
-      end
-
-      property :band do
-        property :name
-        property :label do
-          property :name
-        end
-      end
-
-      validation :default do
-
-        key(:title).required
-
-        key(:band).schema do
-          key(:name).required
-          key(:label).schema do
-            key(:name).required
-          end
-        end
-
-        configure do
-          option :form
-          # message need to be defined on fixtures/dry_error_messages
-          # d-v expects you to define your custome messages on the .yml file
-          def good_musical_taste?(value)
-            value != 'Nickelback'
-          end
-
-          def form_access_validation?(value)
-            form.title == 'Reform'
-          end
-        end
-
-        key(:title).required(:good_musical_taste?)
-        key(:title).required(:form_access_validation?)
-      end
-    end
-
-    let (:album) do
-      OpenStruct.new(
-        :title  => "Blackhawks Over Los Angeles",
-        :hit    => song,
-        :songs  => songs,
-        :band => Struct.new(:name, :label).new("Epitaph", OpenStruct.new),
-      )
-    end
-    let (:song)  { OpenStruct.new(:title => "Downtown") }
-    let (:songs) { [ song = OpenStruct.new(:title => "Calling"), song ] }
-    let (:form)  { AlbumForm.new(album) }
-
-    # correct #validate.
-    it do
-      result = form.validate(
-        "title"  => "Reform",
-        "songs"  => [
-          {"title" => "Fallout"},
-          {"title" => "Roxanne", "composer" => {"name" => "Sting"}}
-        ],
-        "band"   => {"label" => {"name" => "Epitaph"}},
-      )
-
-      result.must_equal true
-      form.errors.messages.inspect.must_equal "{}"
-    end
-  end
-
-
-  describe "fails with :validate, :validates and :validates_with" do
-
-    it "throws a goddamn error" do
-      e = proc do
-        class FailingForm < Reform::Form
-          include Reform::Form::Dry::Validations
-
-          property :username
-
-          validation :email do
-            validates(:email, &:filled?)
-          end
-        end
-      end.must_raise(NoMethodError)
-      # e.message.must_equal 'validates() is not supported by Dry Validation backend.'
-
-      e = proc do
-        class FailingForm < Reform::Form
-          include Reform::Form::Dry::Validations
-
-          property :username
-
-          validation :email do
-            validate(:email, &:filled?)
-          end
-        end
-      end.must_raise(NoMethodError)
-      # e.message.must_equal 'validate() is not supported by Dry Validation backend.'
-
-      e = proc do
-        class FailingForm < Reform::Form
-          include Reform::Form::Dry::Validations
-
-          property :username
-
-          validation :email do
-            validates_with(:email, &:filled?)
-          end
-        end
-      end.must_raise(NoMethodError)
-      # e.message.must_equal (NoMethodError)'validates_with() is not supported by Dry Validation backend.'
-    end
-  end
-
-
-  # describe "same-named group" do
-  #   class OverwritingForm < Reform::Form
-  #     include Reform::Form::Dry::Validations
-
-  #     property :username
-  #     property :email
-
-  #     validation :email do # FIX ME: is this working for other validator or just bugging here?
-  #       key(:email, &:filled?) # it's not considered, overitten
-  #     end
-
-  #     validation :email do # just another group.
-  #       key(:username, &:filled?)
-  #     end
-  #   end
-
-  #   let (:form) { OverwritingForm.new(Session.new) }
-
-  #   # valid.
-  #   it do
-  #     form.validate({username: "Helloween"}).must_equal true
-  #   end
-
-  #   # invalid.
-  #   it "whoo" do
-  #     form.validate({}).must_equal false
-  #     form.errors.messages.inspect.must_equal "{:username=>[\"username can't be blank\"]}"
-  #   end
-  # end
-
-
-  describe "inherit: true in same group" do
-    class InheritSameGroupForm < Reform::Form
-      include Reform::Form::Dry::Validations
-
-      property :username
-      property :email
-
-      validation :email do
-        key(:email).required
-      end
-
-      validation :email, inherit: true do # extends the above.
-        key(:username).required
-      end
-    end
-
-    let (:form) { InheritSameGroupForm.new(Session.new) }
-
-    # valid.
-    it do
-      form.validate({username: "Helloween", email: 9}).must_equal true
-    end
-
-    # invalid.
-    it do
-      form.validate({}).must_equal false
-      form.errors.messages.inspect.must_equal "{:email=>[\"is missing\"], :username=>[\"is missing\"]}"
-    end
-  end
-
-
-  describe "if: with lambda" do
-    class IfWithLambdaForm < Reform::Form
-      include Reform::Form::Dry::Validations # ::build_errors.
-
-      property :username
-      property :email
-      property :password
-
-      validation :email do
-        key(:email).required
-      end
-
-      # run this is :email group is true.
-      validation :after_email, if: lambda { |results| results[:email]==true } do # extends the above.
-        key(:username).required
-      end
-
-      # block gets evaled in form instance context.
-      validation :password, if: lambda { |results| email == "john@trb.org" } do
-        key(:password).required
-      end
-    end
-
-    let (:form) { IfWithLambdaForm.new(Session.new) }
-
-    # valid.
-    it do
-      form.validate({username: "Strung Out", email: 9}).must_equal true
-    end
-
-    # invalid.
-    it do
-      form.validate({email: 9}).must_equal false
-      form.errors.messages.inspect.must_equal "{:username=>[\"is missing\"]}"
-    end
-  end
-
-
-  # Currenty dry-v don't support that option, it doesn't make sense
-  #   I've talked to @solnic and he plans to add a "hint" feature to show
-  #   more errors messages than only those that have failed.
-  #
-  # describe "multiple errors for property" do
-  #   class MultipleErrorsForPropertyForm < Reform::Form
-  #     include Reform::Form::Dry::Validations
-
-  #     property :username
-
-  #     validation :default do
-  #       key(:username) do |username|
-  #         username.filled? | (username.min_size?(2) & username.max_size?(3))
-  #       end
-  #     end
-  #   end
-
-  #   let (:form) { MultipleErrorsForPropertyForm.new(Session.new) }
-
-  #   # valid.
-  #   it do
-  #     form.validate({username: ""}).must_equal false
-  #     form.errors.messages.inspect.must_equal "{:username=>[\"username must be filled\", \"username is not proper size\"]}"
-  #   end
-  # end
-end