reform 2.2.4 → 2.3.3

data/test/inherit_test.rb

@@ -1,119 +0,0 @@
-require 'test_helper'
-require 'representable/json'
-
-class InheritTest < BaseTest
-  Populator = Reform::Form::Populator
-
-  class AlbumForm < Reform::Form
-    property :title, deserializer: {instance: "Instance"}, skip_if: "skip_if in AlbumForm" # allow direct configuration of :deserializer.
-
-    property :hit, populator: "Populator" do
-      property :title
-    end
-
-    collection :songs, populate_if_empty: lambda {}, skip_if: :all_blank do
-      property :title
-    end
-
-    property :artist, populate_if_empty: lambda {} do
-
-      def artist_id
-        1
-      end
-    end
-  end
-
-  puts
-  puts "inherit"
-
-  class CompilationForm < AlbumForm
-    property :title, inherit: true, skip_if: "skip_if from CompilationForm"
-    puts "[#{options_for(:title)[:deserializer].object_id}] COM@@@@@ #{options_for(:title)[:deserializer].inspect}"
-    # property :hit, :inherit => true do
-    #   property :rating
-    #   validates :title, :rating, :presence => true
-    # end
-
-    # puts representer_class.representable_attrs.
-    #   get(:hit)[:extend].evaluate(nil).new(OpenStruct.new).rating
-
-    # NO collection here, this is entirely inherited.
-    # collection :songs, ..
-
-    property :artist, inherit: true do # inherit everything, but explicitely.
-    end
-
-    # completely override.
-    property :hit, skip_if: "SkipParse" do
-    end
-
-    # override partly.
-  end
-
-  let (:album) { Album.new(nil, OpenStruct.new(:hit => OpenStruct.new()) ) }
-  subject { CompilationForm.new(album) }
-
-
-  # valid.
-  # it {
-  #   subject.validate("hit" => {"title" => "LA Drone", "rating" => 10})
-  #   subject.hit.title.must_equal "LA Drone"
-  #   subject.hit.rating.must_equal 10
-  #   subject.errors.messages.must_equal({})
-  # }
-
-  # it do
-  #   subject.validate({})
-  #   subject.hit.title.must_equal nil
-  #   subject.hit.rating.must_equal nil
-  #   subject.errors.messages.must_equal({:"hit.title"=>["can't be blank"], :"hit.rating"=>["can't be blank"]})
-  # end
-
-require "pp"
-
-  it "xxx" do
-    # sub hashes like :deserializer must be properly cloned when inheriting.
-    AlbumForm.options_for(:title)[:deserializer].object_id.wont_equal CompilationForm.options_for(:title)[:deserializer].object_id
-
-    # don't overwrite direct deserializer: {} configuration.
-    AlbumForm.options_for(:title)[:internal_populator].must_be_instance_of Reform::Form::Populator::Sync
-    AlbumForm.options_for(:title)[:deserializer][:skip_parse].must_equal "skip_if in AlbumForm"
-
-    AlbumForm.options_for(:hit)[:internal_populator].inspect.must_match /Reform::Form::Populator:.+ @user_proc="Populator"/
-    # AlbumForm.options_for(:hit)[:deserializer][:instance].inspect.must_be_instance_with Reform::Form::Populator, user_proc: "Populator"
-
-
-    AlbumForm.options_for(:songs)[:internal_populator].must_be_instance_of Reform::Form::Populator::IfEmpty
-    AlbumForm.options_for(:songs)[:deserializer][:skip_parse].must_be_instance_of Reform::Form::Validate::Skip::AllBlank
-
-    AlbumForm.options_for(:artist)[:internal_populator].must_be_instance_of Reform::Form::Populator::IfEmpty
-
-
-
-    CompilationForm.options_for(:title)[:deserializer][:skip_parse].must_equal "skip_if from CompilationForm"
-    # pp CompilationForm.options_for(:songs)
-    CompilationForm.options_for(:songs)[:internal_populator].must_be_instance_of Reform::Form::Populator::IfEmpty
-
-
-    CompilationForm.options_for(:artist)[:internal_populator].must_be_instance_of Reform::Form::Populator::IfEmpty
-
-    # completely overwrite inherited.
-    CompilationForm.options_for(:hit)[:internal_populator].must_be_instance_of Reform::Form::Populator::Sync # reset to default.
-    CompilationForm.options_for(:hit)[:deserializer][:skip_parse].must_equal "SkipParse"
-
-
-    # inherit: true with block will still inherit the original class.
-    AlbumForm.new(OpenStruct.new(artist: OpenStruct.new)).artist.artist_id.must_equal 1
-    CompilationForm.new(OpenStruct.new(artist: OpenStruct.new)).artist.artist_id.must_equal 1
-  end
-
-
-  class CDForm < AlbumForm
-    # override :artist's original populate_if_empty but with :inherit.
-    property :artist, inherit: true, populator: "CD Populator" do
-
-    end
-  end
-
-  it { CDForm.options_for(:artist)[:internal_populator].instance_variable_get(:@user_proc).must_equal "CD Populator" }
-end

data/test/populate_test.rb

@@ -1,270 +0,0 @@
-require "test_helper"
-
-class PopulatorTest < MiniTest::Spec
-  Song  = Struct.new(:title, :album, :composer)
-  Album = Struct.new(:name, :songs, :artist)
-  Artist = Struct.new(:name)
-
-  class AlbumForm < Reform::Form
-    property :name, populator: ->(options) { self.name = options[:fragment].reverse }
-    validation do
-      key(:name).required
-    end
-
-    collection :songs,
-      populator: ->(options) {
-        fragment, collection, index = options[:fragment], options[:model], options[:index]
-
-        (item = collection[index]) ? item : collection.insert(index, Song.new) } do
-
-      property :title
-      validation do
-        key(:title).required
-      end
-
-      property :composer, populator: ->(options) { options[:model] || self.composer= Artist.new } do
-        property :name
-        validation do
-          key(:name).required
-        end
-      end
-    end
-
-    # property :artist, populator: lambda { |fragment, options| (item = options.binding.get) ? item : Artist.new } do
-    # NOTE: we have to document that model here is the twin!
-    property :artist, populator: ->(options) { options[:model] || self.artist = Artist.new } do
-      property :name
-    end
-  end
-
-  let (:song)               { Song.new("Broken") }
-  let (:song_with_composer) { Song.new("Resist Stance", nil, composer) }
-  let (:composer)           { Artist.new("Greg Graffin") }
-  let (:artist)             { Artist.new("Bad Religion") }
-  let (:album)              { Album.new("The Dissent Of Man", [song, song_with_composer], artist) }
-
-  let (:form) { AlbumForm.new(album) }
-
-  it "runs populator on scalar" do
-    form.validate(
-      "name" => "override me!"
-    )
-
-    form.name.must_equal "!em edirrevo"
-  end
-
-  # changing existing property :artist.
-  # TODO: check with artist==nil
-  it do
-    old_id = artist.object_id
-
-    form.validate(
-      "artist" => {"name" => "Marcus Miller"}
-    )
-
-    form.artist.model.object_id.must_equal old_id
-  end
-
-  # use populator for default value on scalars?
-
-  # adding to collection via :populator.
-  # valid.
-  it "yyy" do
-    form.validate(
-      "songs"  => [{"title" => "Fallout"}, {"title" => "Roxanne"},
-        {"title" => "Rime Of The Ancient Mariner"}, # new song.
-        {"title" => "Re-Education", "composer" => {"name" => "Rise Against"}}], # new song with new composer.
-    ).must_equal true
-
-    form.errors.messages.inspect.must_equal "{}"
-
-    # form has updated.
-    form.name.must_equal "The Dissent Of Man"
-    form.songs[0].title.must_equal "Fallout"
-    form.songs[1].title.must_equal "Roxanne"
-    form.songs[1].composer.name.must_equal "Greg Graffin"
-
-    form.songs[1].composer.model.must_be_instance_of Artist
-
-    form.songs[1].title.must_equal "Roxanne"
-    form.songs[2].title.must_equal "Rime Of The Ancient Mariner" # new song added.
-    form.songs[3].title.must_equal "Re-Education"
-    form.songs[3].composer.name.must_equal "Rise Against"
-    form.songs.size.must_equal 4
-    form.artist.name.must_equal "Bad Religion"
-
-
-    # model has not changed, yet.
-    album.name.must_equal "The Dissent Of Man"
-    album.songs[0].title.must_equal "Broken"
-    album.songs[1].title.must_equal "Resist Stance"
-    album.songs[1].composer.name.must_equal "Greg Graffin"
-    album.songs.size.must_equal 2
-    album.artist.name.must_equal "Bad Religion"
-  end
-end
-
-class PopulateWithMethodTest < Minitest::Spec
-  Album = Struct.new(:title)
-
-  class AlbumForm < Reform::Form
-    property :title, populator: :title!
-
-    def title!(options)
-      self.title = options[:fragment].reverse
-    end
-  end
-
-  let (:form) { AlbumForm.new(Album.new) }
-
-  it "runs populator method" do
-    form.validate(
-      "title" => "override me!"
-    )
-
-    form.title.must_equal "!em edirrevo"
-  end
-end
-
-class PopulateIfEmptyTest < MiniTest::Spec
-  Song  = Struct.new(:title, :album, :composer)
-  Album = Struct.new(:name, :songs, :artist)
-  Artist = Struct.new(:name)
-
-  let (:song)               { Song.new("Broken") }
-  let (:song_with_composer) { Song.new("Resist Stance", nil, composer) }
-  let (:composer)           { Artist.new("Greg Graffin") }
-  let (:artist)             { Artist.new("Bad Religion") }
-  let (:album)              { Album.new("The Dissent Of Man", [song, song_with_composer], artist) }
-
-
-
-  class AlbumForm < Reform::Form
-    property :name
-
-    collection :songs,
-      populate_if_empty: Song do                                                # class name works.
-
-      property :title
-      validation do
-        key(:title).required
-      end
-
-      property :composer, populate_if_empty: :populate_composer! do # lambda works, too. in form context.
-        property :name
-        validation do
-          key(:name).required
-        end
-      end
-
-    private
-      def populate_composer!(fragment, options)
-        Artist.new
-      end
-    end
-
-    property :artist, populate_if_empty: lambda { |args| create_artist(args[:fragment], args[:user_options]) } do # methods work, too.
-      property :name
-    end
-
-  private
-    class Sting < Artist
-      attr_accessor :args
-    end
-    def create_artist(input, user_options)
-      Sting.new.tap { |artist| artist.args=([input, user_options].to_s) }
-    end
-  end
-
-  let (:form) { AlbumForm.new(album) }
-
-  it do
-    form.songs.size.must_equal 2
-
-    form.validate(
-      "songs"  => [{"title" => "Fallout"}, {"title" => "Roxanne"},
-        {"title" => "Rime Of The Ancient Mariner"}, # new song.
-        {"title" => "Re-Education", "composer" => {"name" => "Rise Against"}}], # new song with new composer.
-    ).must_equal true
-
-    form.errors.messages.inspect.must_equal "{}"
-
-    # form has updated.
-    form.name.must_equal "The Dissent Of Man"
-    form.songs[0].title.must_equal "Fallout"
-    form.songs[1].title.must_equal "Roxanne"
-    form.songs[1].composer.name.must_equal "Greg Graffin"
-    form.songs[1].title.must_equal "Roxanne"
-    form.songs[2].title.must_equal "Rime Of The Ancient Mariner" # new song added.
-    form.songs[3].title.must_equal "Re-Education"
-    form.songs[3].composer.name.must_equal "Rise Against"
-    form.songs.size.must_equal 4
-    form.artist.name.must_equal "Bad Religion"
-
-
-    # model has not changed, yet.
-    album.name.must_equal "The Dissent Of Man"
-    album.songs[0].title.must_equal "Broken"
-    album.songs[1].title.must_equal "Resist Stance"
-    album.songs[1].composer.name.must_equal "Greg Graffin"
-    album.songs.size.must_equal 2
-    album.artist.name.must_equal "Bad Religion"
-  end
-
-  # trigger artist populator. lambda calling form instance method.
-  it "xxxx" do
-    form = AlbumForm.new(album = Album.new)
-    form.validate("artist" => {"name" => "From Autumn To Ashes"})
-
-    form.artist.name.must_equal "From Autumn To Ashes"
-    # test lambda was executed in form context.
-    form.artist.model.must_be_instance_of AlbumForm::Sting
-    # test lambda block arguments.
-    form.artist.model.args.to_s.must_equal "[{\"name\"=>\"From Autumn To Ashes\"}, nil]"
-
-    album.artist.must_equal nil
-  end
-end
-
-
-# delete songs while deserializing.
-class PopulateIfEmptyWithDeletionTest < MiniTest::Spec
-  Song  = Struct.new(:title, :album, :composer)
-  Album = Struct.new(:name, :songs, :artist)
-
-  let (:song)  { Song.new("Broken") }
-  let (:song2) { Song.new("Resist Stance") }
-  let (:album) { Album.new("The Dissent Of Man", [song, song2]) }
-
-
-  class AlbumForm < Reform::Form
-    property :name
-
-    collection :songs,
-      populate_if_empty: Song, skip_if: :delete_song! do
-
-      property :title
-      validation do
-        key(:title).required
-      end
-    end
-
-    def delete_song!(options)
-      songs.delete(songs[0]) and return true if options[:fragment]["title"] == "Broken, delete me!"
-      false
-    end
-  end
-
-  let (:form) { AlbumForm.new(album) }
-
-  it do
-    form.validate(
-      "songs"  => [{"title" => "Broken, delete me!"}, {"title" => "Roxanne"}]
-    ).must_equal true
-
-    form.errors.messages.inspect.must_equal "{}"
-
-    form.songs.size.must_equal 1
-    form.songs[0].title.must_equal "Roxanne"
-  end
-end

data/test/readonly_test.rb

@@ -1,14 +0,0 @@
-require "test_helper"
-
-class ReadonlyTest < MiniTest::Spec
-  class SongForm < Reform::Form
-    property :artist
-    property :title, writeable: false
-    # TODO: what to do with virtual values?
-  end
-
-  let (:form) { SongForm.new(OpenStruct.new) }
-
-  it { form.readonly?(:artist).must_equal false }
-  it { form.readonly?(:title).must_equal true }
-end

data/test/save_test.rb

@@ -1,89 +0,0 @@
-require 'test_helper'
-
-class SaveTest < BaseTest
-  Song  = Struct.new(:title, :album, :composer)
-  Album = Struct.new(:name, :songs, :artist)
-  Artist = Struct.new(:name)
-
-  class AlbumForm < Reform::Form
-    property :name
-    validation do
-      key(:name).required
-    end
-
-    collection :songs do
-      property :title
-      validation do
-        key(:title).required
-      end
-
-      property :composer do
-        property :name
-        validation do
-          key(:name).required
-        end
-      end
-    end
-
-    property :artist, save: false do
-      property :name
-    end
-  end
-
-  module Saveable
-    def save
-      @saved = true
-    end
-
-    def saved?
-      @saved
-    end
-  end
-
-
-  let (:song)               { Song.new("Broken").extend(Saveable) }
-  # let (:song_with_composer) { Song.new("Resist Stance", nil, composer).extend(Saveable) }
-  let (:composer)           { Artist.new("Greg Graffin").extend(Saveable) }
-  let (:artist)             { Artist.new("Bad Religion").extend(Saveable).extend(Saveable) }
-  let (:album)              { Album.new("The Dissent Of Man", [song], artist).extend(Saveable) }
-
-  let (:form) { AlbumForm.new(album) }
-
-
-  it do
-    form.validate("songs" => [{"title" => "Fixed"}])
-
-    form.save
-
-    album.saved?.must_equal true
-    album.songs[0].title.must_equal "Fixed"
-    album.songs[0].saved?.must_equal true
-    album.artist.saved?.must_equal nil
-  end
-end
-
-
-# class SaveWithDynamicOptionsTest < MiniTest::Spec
-#   Song = Struct.new(:id, :title, :length) do
-#     include Saveable
-#   end
-
-#   class SongForm < Reform::Form
-#     property :title#, save: false
-#     property :length, virtual: true
-#   end
-
-#   let (:song) { Song.new }
-#   let (:form) { SongForm.new(song) }
-
-#   # we have access to original input value and outside parameters.
-#   it "xxx" do
-#     form.validate("title" => "A Poor Man's Memory", "length" => 10)
-#     length_seconds = 120
-#     form.save(length: lambda { |value, options| form.model.id = "#{value}: #{length_seconds}" })
-
-#     song.title.must_equal "A Poor Man's Memory"
-#     song.length.must_equal nil
-#     song.id.must_equal "10: 120"
-#   end
-# end