reek 6.0.0 → 6.0.3

data/spec/reek/spec/should_reek_only_of_spec.rb

@@ -40,7 +40,7 @@ RSpec.describe Reek::Spec::ShouldReekOnlyOf do
   end
 
   context 'with 1 non-matching smell' do
-    let(:smells) { [build(:smell_warning, smell_type: 'ControlParameter')] }
+    let(:smells) { [build_smell_warning(smell_type: 'ControlParameter')] }
 
     it_behaves_like 'no match'
   end
@@ -48,8 +48,8 @@ RSpec.describe Reek::Spec::ShouldReekOnlyOf do
   context 'with 2 non-matching smells' do
     let(:smells) do
       [
-        build(:smell_warning, smell_type: 'ControlParameter'),
-        build(:smell_warning, smell_type: 'FeatureEnvy')
+        build_smell_warning(smell_type: 'ControlParameter'),
+        build_smell_warning(smell_type: 'FeatureEnvy')
       ]
     end
 
@@ -59,8 +59,8 @@ RSpec.describe Reek::Spec::ShouldReekOnlyOf do
   context 'with 1 non-matching and 1 matching smell' do
     let(:smells) do
       [
-        build(:smell_warning, smell_type: 'ControlParameter'),
-        build(:smell_warning, smell_type: expected_smell_type.to_s,
+        build_smell_warning(smell_type: 'ControlParameter'),
+        build_smell_warning(smell_type: expected_smell_type.to_s,
                               message: "message mentioning #{expected_context_name}")
       ]
     end
@@ -70,7 +70,7 @@ RSpec.describe Reek::Spec::ShouldReekOnlyOf do
 
   context 'with 1 matching smell' do
     let(:smells) do
-      [build(:smell_warning, smell_type: expected_smell_type.to_s,
+      [build_smell_warning(smell_type: expected_smell_type.to_s,
                              message: "message mentioning #{expected_context_name}")]
     end
 

data/spec/reek/spec/smell_matcher_spec.rb

@@ -3,7 +3,7 @@ require_lib 'reek/spec/smell_matcher'
 
 RSpec.describe Reek::Spec::SmellMatcher do
   let(:smell_warning) do
-    build(:smell_warning, smell_type: 'UncommunicativeVariableName',
+    build_smell_warning(smell_type: 'UncommunicativeVariableName',
                           message: "has the variable name '@s'",
                           parameters: { test: 'something' })
   end

data/spec/spec_helper.rb

@@ -1,6 +1,5 @@
 require 'pathname'
 require 'timeout'
-require 'active_support/core_ext/string/strip'
 require 'rspec-benchmark'
 require_relative '../lib/reek'
 require_relative '../lib/reek/spec'
@@ -14,9 +13,6 @@ begin
 rescue LoadError # rubocop:disable Lint/SuppressedException
 end
 
-require 'factory_bot'
-FactoryBot.find_definitions
-
 # Simple helpers for our specs.
 module Helpers
   def test_configuration_for(config)
@@ -70,12 +66,29 @@ module Helpers
     @klass_map ||= Reek::AST::ASTNodeClassMap.new
     @klass_map.klass_for(type).new(type, children)
   end
+
+  def build_smell_warning(smell_type: 'FeatureEnvy',
+                          context: 'self',
+                          lines: [42],
+                          message: 'smell warning message',
+                          source: 'dummy_file',
+                          parameters: {})
+    Reek::SmellWarning.new(smell_type,
+                           context: context,
+                           lines: lines,
+                           message: message,
+                           source: source,
+                           parameters: parameters)
+  end
+
+  def build_code_comment(comment: '', line: 1, source: 'string')
+    Reek::CodeComment.new(comment: comment, line: line, source: source)
+  end
 end
 
 RSpec.configure do |config|
   config.filter_run :focus
   config.run_all_when_everything_filtered = true
-  config.include FactoryBot::Syntax::Methods
   config.include Helpers
   config.include RSpec::Benchmark::Matchers
   config.example_status_persistence_file_path = 'spec/examples.txt'

data/tasks/configuration.rake

@@ -8,11 +8,10 @@ require 'yaml'
 namespace :configuration do
   desc 'Updates the default configuration file when smell defaults change'
   task :update_default_configuration do
-    DEFAULT_SMELL_CONFIGURATION = 'docs/defaults.reek.yml'.freeze
     content = Reek::DetectorRepository.smell_types.each_with_object({}) do |klass, hash|
       hash[klass.smell_type] = Reek::Configuration::RakeTaskConverter.convert klass.default_config
     end
-    File.open(DEFAULT_SMELL_CONFIGURATION, 'w') do |file|
+    File.open(Reek::DEFAULT_SMELL_CONFIGURATION, 'w') do |file|
       YAML.dump({ Reek::DETECTORS_KEY => content }, file)
     end
   end

metadata

@@ -1,17 +1,17 @@
 --- !ruby/object:Gem::Specification
 name: reek
 version: !ruby/object:Gem::Version
-  version: 6.0.0
+  version: 6.0.3
 platform: ruby
 authors:
 - Kevin Rutherford
 - Timo Roessner
 - Matijs van Zuijlen
 - Piotr Szotkowski
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-03-30 00:00:00.000000000 Z
+date: 2021-01-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: kwalify
@@ -31,42 +31,30 @@ dependencies:
   name: parser
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '2.8'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 2.5.0.0
-    - - "!="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.5.1.1
+        version: 3.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '2.8'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 2.5.0.0
-    - - "!="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.5.1.1
+        version: 3.0.0
 - !ruby/object:Gem::Dependency
   name: psych
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: '3.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: '3.1'
 - !ruby/object:Gem::Dependency
   name: rainbow
   requirement: !ruby/object:Gem::Requirement
@@ -100,12 +88,13 @@ extra_rdoc_files:
 - License.txt
 files:
 - ".dockerignore"
+- ".github/dependabot.yml"
+- ".github/workflows/ruby.yml"
 - ".gitignore"
 - ".reek.yml"
 - ".rubocop.yml"
 - ".rubocop_todo.yml"
 - ".simplecov"
-- ".travis.yml"
 - ".yardopts"
 - CHANGELOG.md
 - CONTRIBUTING.md
@@ -251,6 +240,7 @@ files:
 - lib/reek/context/ghost_context.rb
 - lib/reek/context/method_context.rb
 - lib/reek/context/module_context.rb
+- lib/reek/context/refinement_context.rb
 - lib/reek/context/root_context.rb
 - lib/reek/context/send_context.rb
 - lib/reek/context/singleton_attribute_context.rb
@@ -372,7 +362,6 @@ files:
 - samples/source_with_non_ruby_files/gibberish
 - samples/source_with_non_ruby_files/python_source.py
 - samples/source_with_non_ruby_files/ruby.rb
-- spec/factories/factories.rb
 - spec/performance/reek/smell_detectors/runtime_speed_spec.rb
 - spec/quality/documentation_spec.rb
 - spec/quality/reek_source_spec.rb
@@ -466,8 +455,13 @@ files:
 homepage: https://github.com/troessner/reek
 licenses:
 - MIT
-metadata: {}
-post_install_message: 
+metadata:
+  homepage_uri: https://github.com/troessner/reek
+  source_code_uri: https://github.com/troessner/reek
+  bug_tracker_uri: https://github.com/troessner/reek/issues
+  changelog_uri: https://github.com/troessner/reek/CHANGELOG.md
+  documentation_uri: https://www.rubydoc.info/gems/reek
+post_install_message:
 rdoc_options:
 - "--main"
 - README.md
@@ -486,9 +480,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
+rubyforge_project:
 rubygems_version: 2.7.7
-signing_key: 
+signing_key:
 specification_version: 4
 summary: Code smell detector for Ruby
 test_files: []

data/.travis.yml

@@ -1,36 +0,0 @@
-language: ruby
-
-dist: xenial
-
-cache:
-  bundler: true
-
-bundler_args: --without debugging
-
-script: bundle exec rake ci
-
-rvm:
-  - 2.4
-  - 2.5
-  - 2.6
-  - 2.7
-  - jruby-9.2
-  - jruby-head
-  - ruby-head
-
-matrix:
-  allow_failures:
-    - rvm: jruby-head
-    - rvm: ruby-head
-  fast_finish: true
-
-notifications:
-  email:
-    - timo.roessner@googlemail.com
-    - matijs@matijs.net
-    - chastell@chastell.net
-  irc: irc.freenode.org#reek
-
-branches:
-  only:
-    - master

data/spec/factories/factories.rb

@@ -1,37 +0,0 @@
-require_relative '../../lib/reek/smell_detectors'
-require_relative '../../lib/reek/smell_detectors/base_detector'
-require_relative '../../lib/reek/smell_warning'
-require_relative '../../lib/reek/cli/options'
-
-FactoryBot.define do
-  factory :smell_warning, class: 'Reek::SmellWarning' do
-    skip_create
-
-    smell_type { 'FeatureEnvy' }
-    source { 'dummy_file' }
-    lines { [42] }
-    message { 'smell warning message' }
-    parameters { {} }
-    context { 'self' }
-
-    initialize_with do
-      new(smell_type,
-          source: source,
-          context: context,
-          lines: lines,
-          message: message,
-          parameters: parameters)
-    end
-  end
-
-  factory :code_comment, class: 'Reek::CodeComment' do
-    comment { '' }
-    line { 1 }
-    source { 'string' }
-    initialize_with do
-      new comment: comment,
-          line: line,
-          source: source
-    end
-  end
-end