reek 6.0.0 → 6.0.3

data/lib/reek/smell_detectors/boolean_parameter.rb

@@ -14,6 +14,8 @@ module Reek
     #
     # See {file:docs/Boolean-Parameter.md} for details.
     class BooleanParameter < BaseDetector
+      BOOLEAN_VALUES = [:true, :false].freeze
+
       #
       # Checks whether the given method has any Boolean parameters.
       #
@@ -21,7 +23,7 @@ module Reek
       #
       def sniff
         context.default_assignments.select do |_parameter, value|
-          [:true, :false].include?(value.type)
+          BOOLEAN_VALUES.include?(value.type)
         end.map do |parameter, _value|
           smell_warning(
             lines: [source_line],

data/lib/reek/smell_detectors/uncommunicative_variable_name.rb

@@ -74,7 +74,7 @@ module Reek
       end
 
       def uncommunicative_variable_name?(name)
-        sanitized_name = name.to_s.gsub(/^[@\*\&]*/, '')
+        sanitized_name = name.to_s.gsub(/^[@*&]*/, '')
         !acceptable_name?(sanitized_name)
       end
 

data/lib/reek/smell_warning.rb

@@ -31,8 +31,7 @@ module Reek
     #   public API.
     #
     # @quality :reek:LongParameterList { max_params: 6 }
-    def initialize(smell_type, context: '', lines:, message:,
-                   source:, parameters: {})
+    def initialize(smell_type, lines:, message:, source:, context: '', parameters: {})
       @smell_type = smell_type
       @source     = source
       @context    = context.to_s

data/lib/reek/source/source_locator.rb

@@ -33,23 +33,26 @@ module Reek
 
       attr_reader :configuration, :paths, :options
 
-      # @quality :reek:TooManyStatements { max_statements: 7 }
-      # @quality :reek:NestedIterators { max_allowed_nesting: 2 }
       def source_paths
         paths.each_with_object([]) do |given_path, relevant_paths|
-          unless given_path.exist?
+          if given_path.exist?
+            relevant_paths.concat source_files_from_path(given_path)
+          else
             print_no_such_file_error(given_path)
-            next
           end
+        end
+      end
 
-          given_path.find do |path|
-            if path.directory?
-              ignore_path?(path) ? Find.prune : next
-            elsif ruby_file?(path)
-              relevant_paths << path unless ignore_file?(path)
-            end
+      def source_files_from_path(given_path)
+        relevant_paths = []
+        given_path.find do |path|
+          if path.directory?
+            Find.prune if ignore_path?(path)
+          elsif ruby_file?(path)
+            relevant_paths << path unless ignore_file?(path)
           end
         end
+        relevant_paths
       end
 
       def ignore_file?(path)

data/lib/reek/spec/smell_matcher.rb

@@ -43,8 +43,9 @@ module Reek
         raise ArgumentError, "The attribute '#{extra_keys.first}' is not available for comparison"
       end
 
+      # :reek:FeatureEnvy
       def common_parameters_equal?(other_parameters)
-        smell_warning.parameters.slice(*other_parameters.keys) == other_parameters
+        smell_warning.parameters.values_at(*other_parameters.keys) == other_parameters.values
       end
 
       def common_attributes_equal?(attributes)

data/lib/reek/version.rb

@@ -8,6 +8,6 @@ module Reek
   # @public
   module Version
     # @public
-    STRING = '6.0.0'
+    STRING = '6.0.3'
   end
 end

data/lib/reek.rb

@@ -8,6 +8,7 @@ require_relative 'reek/examiner'
 require_relative 'reek/report'
 
 module Reek
+  DEFAULT_SMELL_CONFIGURATION = File.join(__dir__, '../docs/defaults.reek.yml').freeze
   DEFAULT_CONFIGURATION_FILE_NAME = '.reek.yml'
   DETECTORS_KEY = 'detectors'
   EXCLUDE_PATHS_KEY = 'exclude_paths'

data/reek.gemspec

@@ -19,8 +19,16 @@ Gem::Specification.new do |s|
   s.required_ruby_version = '>= 2.4.0'
   s.summary = 'Code smell detector for Ruby'
 
+  s.metadata = {
+    'homepage_uri'      => 'https://github.com/troessner/reek',
+    'source_code_uri'   => 'https://github.com/troessner/reek',
+    'bug_tracker_uri'   => 'https://github.com/troessner/reek/issues',
+    'changelog_uri'     => 'https://github.com/troessner/reek/CHANGELOG.md',
+    'documentation_uri' => 'https://www.rubydoc.info/gems/reek'
+  }
+
   s.add_runtime_dependency 'kwalify', '~> 0.7.0'
-  s.add_runtime_dependency 'parser',  '< 2.8', '>= 2.5.0.0', '!= 2.5.1.1'
-  s.add_runtime_dependency 'psych',   '~> 3.1.0'
+  s.add_runtime_dependency 'parser',  '~> 3.0.0'
+  s.add_runtime_dependency 'psych',   '~> 3.1'
   s.add_runtime_dependency 'rainbow', '>= 2.0', '< 4.0'
 end

data/spec/performance/reek/smell_detectors/runtime_speed_spec.rb

@@ -6,10 +6,8 @@ RSpec.describe 'Runtime speed' do
 
   it 'runs on our smelly sources in less than 5 seconds' do
     expect do
-      source_directory.each_entry do |entry|
-        next if %w(. ..).include?(entry.to_s)
-
-        examiner = Reek::Examiner.new entry.to_path
+      Dir[source_directory.join('**/*.rb')].each do |entry|
+        examiner = Reek::Examiner.new Pathname.new(entry)
         examiner.smells.size
       end
     end.to perform_under(5).sec

data/spec/quality/documentation_spec.rb

@@ -4,6 +4,7 @@ require 'kramdown'
 RSpec.describe 'Documentation' do
   root = File.expand_path('../..', __dir__)
   files = Dir.glob(File.join(root, '*.md')) + Dir.glob(File.join(root, 'docs', '*.md'))
+  code_types = [:codeblock, :codespan]
 
   files.each do |file|
     describe "from #{file}" do
@@ -13,7 +14,7 @@ RSpec.describe 'Documentation' do
 
       blocks.each do |block|
         # Only consider code blocks with language 'ruby'.
-        next unless [:codeblock, :codespan].include?(block.type)
+        next unless code_types.include?(block.type)
         next unless block.attr['class'] == 'language-ruby'
 
         it "has a valid sample at #{block.options[:location] + 1}" do

data/spec/reek/code_comment_spec.rb

@@ -3,7 +3,7 @@ require_lib 'reek/code_comment'
 
 RSpec.describe Reek::CodeComment do
   context 'with an empty comment' do
-    let(:comment) { build(:code_comment, comment: '') }
+    let(:comment) { build_code_comment(comment: '') }
 
     it 'is not descriptive' do
       expect(comment).not_to be_descriptive
@@ -16,22 +16,22 @@ RSpec.describe Reek::CodeComment do
 
   describe '#descriptive' do
     it 'rejects an empty comment' do
-      comment = build(:code_comment, comment: '#')
+      comment = build_code_comment(comment: '#')
       expect(comment).not_to be_descriptive
     end
 
     it 'rejects a 1-word comment' do
-      comment = build(:code_comment, comment: "# alpha\n#  ")
+      comment = build_code_comment(comment: "# alpha\n#  ")
       expect(comment).not_to be_descriptive
     end
 
     it 'accepts a 2-word comment' do
-      comment = build(:code_comment, comment: '# alpha bravo  ')
+      comment = build_code_comment(comment: '# alpha bravo  ')
       expect(comment).to be_descriptive
     end
 
     it 'accepts a multi-word comment' do
-      comment = build(:code_comment, comment: "# alpha bravo \n# charlie \n   # delta ")
+      comment = build_code_comment(comment: "# alpha bravo \n# charlie \n   # delta ")
       expect(comment).to be_descriptive
     end
   end
@@ -39,8 +39,7 @@ RSpec.describe Reek::CodeComment do
   describe 'good comment config' do
     it 'parses hashed options' do
       comment = '# :reek:DuplicateMethodCall { max_calls: 3 }'
-      config = build(:code_comment,
-                     comment: comment).config
+      config = build_code_comment(comment: comment).config
 
       expect(config).to include('DuplicateMethodCall')
       expect(config['DuplicateMethodCall']).to have_key 'max_calls'
@@ -52,7 +51,7 @@ RSpec.describe Reek::CodeComment do
         # :reek:DuplicateMethodCall { max_calls: 3 }
         # :reek:NestedIterators { enabled: true }
       RUBY
-      config = build(:code_comment, comment: comment).config
+      config = build_code_comment(comment: comment).config
 
       expect(config).to include('DuplicateMethodCall', 'NestedIterators')
       expect(config['DuplicateMethodCall']['max_calls']).to eq 3
@@ -63,7 +62,7 @@ RSpec.describe Reek::CodeComment do
       comment = <<-RUBY
         #:reek:DuplicateMethodCall { max_calls: 3 } and :reek:NestedIterators { enabled: true }
       RUBY
-      config = build(:code_comment, comment: comment).config
+      config = build_code_comment(comment: comment).config
 
       expect(config).to include('DuplicateMethodCall', 'NestedIterators')
       expect(config['DuplicateMethodCall']['max_calls']).to eq 3
@@ -73,7 +72,7 @@ RSpec.describe Reek::CodeComment do
 
     it 'parses multiple unhashed options on the same line' do
       comment = '# :reek:DuplicateMethodCall and :reek:NestedIterators'
-      config = build(:code_comment, comment: comment).config
+      config = build_code_comment(comment: comment).config
 
       expect(config).to include('DuplicateMethodCall', 'NestedIterators')
       expect(config['DuplicateMethodCall']).to include('enabled')
@@ -84,7 +83,7 @@ RSpec.describe Reek::CodeComment do
 
     it 'disables the smell if no options are specifed' do
       comment = '# :reek:DuplicateMethodCall'
-      config = build(:code_comment, comment: comment).config
+      config = build_code_comment(comment: comment).config
 
       expect(config).to include('DuplicateMethodCall')
       expect(config['DuplicateMethodCall']).to include('enabled')
@@ -93,14 +92,13 @@ RSpec.describe Reek::CodeComment do
 
     it 'does not disable the smell if options are specifed' do
       comment = '# :reek:DuplicateMethodCall { max_calls: 3 }'
-      config = build(:code_comment, comment: comment).config
+      config = build_code_comment(comment: comment).config
 
       expect(config['DuplicateMethodCall']).not_to include('enabled')
     end
 
     it 'ignores smells after a space' do
-      config = build(:code_comment,
-                     comment: '# :reek: DuplicateMethodCall').config
+      config = build_code_comment(comment: '# :reek: DuplicateMethodCall').config
       expect(config).not_to include('DuplicateMethodCall')
     end
 
@@ -111,7 +109,7 @@ RSpec.describe Reek::CodeComment do
         # :reek:NestedIterators { enabled: true }
         # comment
       RUBY
-      comment = build(:code_comment, comment: original_comment)
+      comment = build_code_comment(comment: original_comment)
 
       expect(comment.send(:sanitized_comment)).to eq('Actual comment')
     end
@@ -122,8 +120,7 @@ RSpec.describe Reek::CodeComment::CodeCommentValidator do
   context 'when the comment contains an unknown detector name' do
     it 'raises BadDetectorInCommentError' do
       expect do
-        build(:code_comment,
-              comment: '# :reek:DoesNotExist')
+        build_code_comment(comment: '# :reek:DoesNotExist')
       end.to raise_error(Reek::Errors::BadDetectorInCommentError)
     end
   end
@@ -132,7 +129,7 @@ RSpec.describe Reek::CodeComment::CodeCommentValidator do
     it 'raises GarbageDetectorConfigurationInCommentError' do
       expect do
         comment = '# :reek:UncommunicativeMethodName { thats: a: bad: config }'
-        build(:code_comment, comment: comment)
+        build_code_comment(comment: comment)
       end.to raise_error(Reek::Errors::GarbageDetectorConfigurationInCommentError)
     end
   end
@@ -140,7 +137,7 @@ RSpec.describe Reek::CodeComment::CodeCommentValidator do
   context 'when the legacy comment format was used' do
     it 'raises LegacyCommentSeparatorError' do
       comment = '# :reek:DuplicateMethodCall:'
-      expect { build(:code_comment, comment: comment) }.
+      expect { build_code_comment(comment: comment) }.
         to raise_error Reek::Errors::LegacyCommentSeparatorError
     end
   end
@@ -151,7 +148,7 @@ RSpec.describe Reek::CodeComment::CodeCommentValidator do
         expect do
           # exclude -> exlude and enabled -> nabled
           comment = '# :reek:UncommunicativeMethodName { exlude: alfa, nabled: true }'
-          build(:code_comment, comment: comment)
+          build_code_comment(comment: comment)
         end.to raise_error(Reek::Errors::BadDetectorConfigurationKeyInCommentError)
       end
     end
@@ -160,7 +157,7 @@ RSpec.describe Reek::CodeComment::CodeCommentValidator do
       it 'does not raise' do
         expect do
           comment = '# :reek:UncommunicativeMethodName { exclude: alfa, enabled: true }'
-          build(:code_comment, comment: comment)
+          build_code_comment(comment: comment)
         end.not_to raise_error
       end
     end
@@ -170,7 +167,7 @@ RSpec.describe Reek::CodeComment::CodeCommentValidator do
         expect do
           # max_copies -> mx_copies and min_clump_size -> mn_clump_size
           comment = '# :reek:DataClump { mx_copies: 4, mn_clump_size: 3 }'
-          build(:code_comment, comment: comment)
+          build_code_comment(comment: comment)
         end.to raise_error(Reek::Errors::BadDetectorConfigurationKeyInCommentError)
       end
     end
@@ -179,7 +176,7 @@ RSpec.describe Reek::CodeComment::CodeCommentValidator do
       it 'does not raise' do
         expect do
           comment = '# :reek:DataClump { max_copies: 4, min_clump_size: 3 }'
-          build(:code_comment, comment: comment)
+          build_code_comment(comment: comment)
         end.not_to raise_error
       end
     end

data/spec/reek/configuration/directory_directives_spec.rb

@@ -89,6 +89,12 @@ RSpec.describe Reek::Configuration::DirectoryDirectives do
       expect(hit.to_s).to eq('bar/**/.spec/*')
     end
 
+    it 'returns the corresponding directory when source_base_dir is an absolute_path' do
+      source_base_dir = Pathname.new('foo/bar').expand_path
+      hit = directives.send :best_match_for, source_base_dir
+      expect(hit.to_s).to eq('foo/bar')
+    end
+
     it 'does not match an arbitrary directory when source_base_dir contains a character that could match the .' do
       source_base_dir = 'bar/something/aspec/direct'
       hit = directives.send :best_match_for, source_base_dir

data/spec/reek/configuration/excluded_paths_spec.rb

@@ -5,12 +5,21 @@ require_lib 'reek/configuration/excluded_paths'
 RSpec.describe Reek::Configuration::ExcludedPaths do
   describe '#add' do
     let(:exclusions) { [].extend(described_class) }
-    let(:paths) { ['smelly/sources'] }
-    let(:expected_exclude_paths) { [Pathname('smelly/sources')] }
+    let(:paths) do
+      %w(samples/directory_does_not_exist/
+         samples/source_with_non_ruby_files/
+         samples/**/ignore_me*)
+    end
+
+    let(:expected_exclude_paths) do
+      [Pathname('samples/source_with_non_ruby_files/'),
+       Pathname('samples/source_with_exclude_paths/ignore_me'),
+       Pathname('samples/source_with_exclude_paths/nested/ignore_me_as_well')]
+    end
 
     it 'adds the given paths as Pathname' do
       exclusions.add(paths)
-      expect(exclusions).to eq expected_exclude_paths
+      expect(exclusions).to match_array expected_exclude_paths
     end
   end
 end

data/spec/reek/report/code_climate/code_climate_configuration_spec.rb

@@ -3,9 +3,7 @@ require_lib 'reek/report/code_climate/code_climate_configuration'
 
 RSpec.describe Reek::Report::CodeClimateConfiguration do
   yml = described_class.load
-  smell_types = Reek::SmellDetectors::BaseDetector.descendants.map do |descendant|
-    descendant.name.demodulize
-  end
+  smell_types = Reek::SmellDetectors::BaseDetector.descendants.map(&:smell_type)
 
   smell_types.each do |name|
     config = yml.fetch(name)

data/spec/reek/report/code_climate/code_climate_fingerprint_spec.rb

@@ -8,12 +8,12 @@ RSpec.describe Reek::Report::CodeClimateFingerprint do
     context 'when fingerprinting a warning with no parameters' do
       let(:expected_fingerprint) { 'e68badd29db51c92363a7c6a2438d722' }
       let(:warning) do
-        build(:smell_warning,
-              smell_type: 'UtilityFunction',
-              context:    'alfa',
-              message:    "doesn't depend on instance state (maybe move it to another class?)",
-              lines:      lines,
-              source:     'a/ruby/source/file.rb')
+        Reek::SmellWarning.new(
+          'UtilityFunction',
+          context:    'alfa',
+          message:    "doesn't depend on instance state (maybe move it to another class?)",
+          lines:      lines,
+          source:     'a/ruby/source/file.rb')
       end
 
       context 'with code at a specific location' do
@@ -35,12 +35,12 @@ RSpec.describe Reek::Report::CodeClimateFingerprint do
 
     context 'when the fingerprint should not be computed' do
       let(:warning) do
-        build(:smell_warning,
-              smell_type: 'ManualDispatch',
-              context:    'Alfa#bravo',
-              message:    'manually dispatches method call',
-              lines:      [4],
-              source:     'a/ruby/source/file.rb')
+        Reek::SmellWarning.new(
+          'ManualDispatch',
+          context:    'Alfa#bravo',
+          message:    'manually dispatches method call',
+          lines:      [4],
+          source:     'a/ruby/source/file.rb')
       end
 
       it 'returns nil' do
@@ -50,13 +50,13 @@ RSpec.describe Reek::Report::CodeClimateFingerprint do
 
     context 'when the smell warning has only identifying parameters' do
       let(:warning) do
-        build(:smell_warning,
-              smell_type: 'ClassVariable',
-              context:    'Alfa',
-              message:    "declares the class variable '@@#{name}'",
-              lines:      [4],
-              parameters: { name: "@@#{name}" },
-              source:     'a/ruby/source/file.rb')
+        Reek::SmellWarning.new(
+          'ClassVariable',
+          context:    'Alfa',
+          message:    "declares the class variable '@@#{name}'",
+          lines:      [4],
+          parameters: { name: "@@#{name}" },
+          source:     'a/ruby/source/file.rb')
       end
 
       context 'when the name is one thing' do
@@ -80,13 +80,13 @@ RSpec.describe Reek::Report::CodeClimateFingerprint do
 
     context 'when the smell warning has identifying and non-identifying parameters' do
       let(:warning) do
-        build(:smell_warning,
-              smell_type: 'DuplicateMethodCall',
-              context:    "Alfa##{name}",
-              message:    "calls '#{name}' #{count} times",
-              lines:      lines,
-              parameters: { name: "@@#{name}", count: count },
-              source:     'a/ruby/source/file.rb')
+        Reek::SmellWarning.new(
+          'DuplicateMethodCall',
+          context:    "Alfa##{name}",
+          message:    "calls '#{name}' #{count} times",
+          lines:      lines,
+          parameters: { name: "@@#{name}", count: count },
+          source:     'a/ruby/source/file.rb')
       end
 
       context 'when the parameters are provided' do

data/spec/reek/report/code_climate/code_climate_formatter_spec.rb

@@ -4,12 +4,12 @@ require_lib 'reek/report/code_climate/code_climate_formatter'
 RSpec.describe Reek::Report::CodeClimateFormatter do
   describe '#render' do
     let(:warning) do
-      build(:smell_warning,
-            smell_type: 'UtilityFunction',
-            context:    'context foo',
-            message:    'message bar',
-            lines:      [1, 2],
-            source:     'a/ruby/source/file.rb')
+      Reek::SmellWarning.new(
+        'UtilityFunction',
+        context:    'context foo',
+          message:    'message bar',
+          lines:      [1, 2],
+          source:     'a/ruby/source/file.rb')
     end
     let(:rendered) { described_class.new(warning).render }
     let(:json) { JSON.parse rendered.chop }

data/spec/reek/report/location_formatter_spec.rb

@@ -2,7 +2,7 @@ require_relative '../../spec_helper'
 require_lib 'reek/report/location_formatter'
 
 RSpec.describe Reek::Report::BlankLocationFormatter do
-  let(:warning) { build(:smell_warning, lines: [11, 9, 250, 100]) }
+  let(:warning) { build_smell_warning(lines: [11, 9, 250, 100]) }
 
   describe '.format' do
     it 'returns a blank String regardless of the warning' do
@@ -12,7 +12,7 @@ RSpec.describe Reek::Report::BlankLocationFormatter do
 end
 
 RSpec.describe Reek::Report::DefaultLocationFormatter do
-  let(:warning) { build(:smell_warning, lines: [11, 9, 250, 100]) }
+  let(:warning) { build_smell_warning(lines: [11, 9, 250, 100]) }
 
   describe '.format' do
     it 'returns a prefix with sorted line numbers' do
@@ -22,7 +22,7 @@ RSpec.describe Reek::Report::DefaultLocationFormatter do
 end
 
 RSpec.describe Reek::Report::SingleLineLocationFormatter do
-  let(:warning) { build(:smell_warning, lines: [11, 9, 250, 100]) }
+  let(:warning) { build_smell_warning(lines: [11, 9, 250, 100]) }
 
   describe '.format' do
     it 'returns the first line where the smell was found' do

data/spec/reek/smell_detectors/base_detector_spec.rb

@@ -5,13 +5,13 @@ require_lib 'reek/smell_detectors/duplicate_method_call'
 RSpec.describe Reek::SmellDetectors::BaseDetector do
   describe '.todo_configuration_for' do
     it 'returns exclusion configuration for the given smells' do
-      smell = create(:smell_warning, smell_type: 'Foo', context: 'Foo#bar')
+      smell = build_smell_warning(smell_type: 'Foo', context: 'Foo#bar')
       result = described_class.todo_configuration_for([smell])
       expect(result).to eq('BaseDetector' => { 'exclude' => ['Foo#bar'] })
     end
 
     it 'merges identical contexts' do
-      smell = create(:smell_warning, smell_type: 'Foo', context: 'Foo#bar')
+      smell = build_smell_warning(smell_type: 'Foo', context: 'Foo#bar')
       result = described_class.todo_configuration_for([smell, smell])
       expect(result).to eq('BaseDetector' => { 'exclude' => ['Foo#bar'] })
     end
@@ -20,7 +20,7 @@ RSpec.describe Reek::SmellDetectors::BaseDetector do
       let(:subclass) { Reek::SmellDetectors::TooManyStatements }
 
       it 'includes default exclusions' do
-        smell = create(:smell_warning, smell_type: 'TooManyStatements', context: 'Foo#bar')
+        smell = build_smell_warning(smell_type: 'TooManyStatements', context: 'Foo#bar')
         result = subclass.todo_configuration_for([smell])
 
         aggregate_failures do

data/spec/reek/smell_detectors/utility_function_spec.rb

@@ -161,6 +161,22 @@ RSpec.describe Reek::SmellDetectors::UtilityFunction do
     end
   end
 
+  context 'when examining refinements' do
+    it 'reports on the refined class' do
+      src = <<-RUBY
+        module Alfa
+          refine Bravo do
+            def bravo(charlie)
+              charlie.delta.echo
+            end
+          end
+        end
+      RUBY
+
+      expect(src).to reek_of(:UtilityFunction, context: 'Bravo#bravo')
+    end
+  end
+
   describe 'method visibility' do
     it 'reports private methods' do
       src = <<-RUBY

data/spec/reek/smell_warning_spec.rb

@@ -24,23 +24,23 @@ RSpec.describe Reek::SmellWarning do
     end
 
     context 'when smells differ only by detector' do
-      let(:first) { build(:smell_warning, smell_type: 'DuplicateMethodCall') }
-      let(:second) { build(:smell_warning, smell_type: 'FeatureEnvy') }
+      let(:first) { build_smell_warning(smell_type: 'DuplicateMethodCall') }
+      let(:second) { build_smell_warning(smell_type: 'FeatureEnvy') }
 
       it_behaves_like 'first sorts ahead of second'
     end
 
     context 'when smells differ only by lines' do
-      let(:first) { build(:smell_warning, smell_type: 'FeatureEnvy', lines: [2]) }
-      let(:second) { build(:smell_warning, smell_type: 'FeatureEnvy', lines: [3]) }
+      let(:first) { build_smell_warning(smell_type: 'FeatureEnvy', lines: [2]) }
+      let(:second) { build_smell_warning(smell_type: 'FeatureEnvy', lines: [3]) }
 
       it_behaves_like 'first sorts ahead of second'
     end
 
     context 'when smells differ only by context' do
-      let(:first) { build(:smell_warning, smell_type: 'DuplicateMethodCall', context: 'first') }
+      let(:first) { build_smell_warning(smell_type: 'DuplicateMethodCall', context: 'first') }
       let(:second) do
-        build(:smell_warning, smell_type: 'DuplicateMethodCall', context: 'second')
+        build_smell_warning(smell_type: 'DuplicateMethodCall', context: 'second')
       end
 
       it_behaves_like 'first sorts ahead of second'
@@ -48,11 +48,11 @@ RSpec.describe Reek::SmellWarning do
 
     context 'when smells differ only by message' do
       let(:first) do
-        build(:smell_warning, smell_type: 'DuplicateMethodCall',
+        build_smell_warning(smell_type: 'DuplicateMethodCall',
                               context: 'ctx', message: 'first message')
       end
       let(:second) do
-        build(:smell_warning, smell_type: 'DuplicateMethodCall',
+        build_smell_warning(smell_type: 'DuplicateMethodCall',
                               context: 'ctx', message: 'second message')
       end
 
@@ -61,10 +61,10 @@ RSpec.describe Reek::SmellWarning do
 
     context 'when smells differ by name and message' do
       let(:first) do
-        build(:smell_warning, smell_type: 'FeatureEnvy', message: 'second message')
+        build_smell_warning(smell_type: 'FeatureEnvy', message: 'second message')
       end
       let(:second) do
-        build(:smell_warning, smell_type: 'UtilityFunction', message: 'first message')
+        build_smell_warning(smell_type: 'UtilityFunction', message: 'first message')
       end
 
       it_behaves_like 'first sorts ahead of second'
@@ -72,13 +72,13 @@ RSpec.describe Reek::SmellWarning do
 
     context 'when smells differ everywhere' do
       let(:first) do
-        build(:smell_warning, smell_type: 'DuplicateMethodCall',
+        build_smell_warning(smell_type: 'DuplicateMethodCall',
                               context: 'Dirty#a',
                               message: 'calls @s.title twice')
       end
 
       let(:second) do
-        build(:smell_warning, smell_type: 'UncommunicativeVariableName',
+        build_smell_warning(smell_type: 'UncommunicativeVariableName',
                               context: 'Dirty',
                               message: "has the variable name '@s'")
       end

data/spec/reek/spec/should_reek_of_spec.rb

@@ -1,7 +1,6 @@
 require 'pathname'
 require_relative '../../spec_helper'
 require_lib 'reek/spec'
-require 'active_support/core_ext/hash/except'
 
 RSpec.describe Reek::Spec::ShouldReekOf do
   describe 'smell type selection' do