reek 4.5.0 → 4.6.0

data/spec/reek/report/code_climate/code_climate_fingerprint_spec.rb

@@ -16,19 +16,19 @@ RSpec.describe Reek::Report::CodeClimateFingerprint do
                           source:         'a/ruby/source/file.rb')
       end
 
-      it 'it computes the fingerprint' do
+      it 'computes the fingerprint' do
         expect(computed).to eq expected_fingerprint
       end
     end
 
     context 'with code at a specific location' do
       let(:lines) { [1] }
-      it_should_behave_like 'computes a fingerprint with no parameters'
+      it_behaves_like 'computes a fingerprint with no parameters'
     end
 
     context 'with code at a different location' do
       let(:lines) { [5] }
-      it_should_behave_like 'computes a fingerprint with no parameters'
+      it_behaves_like 'computes a fingerprint with no parameters'
     end
 
     context 'when the fingerprint should not be computed' do
@@ -41,7 +41,7 @@ RSpec.describe Reek::Report::CodeClimateFingerprint do
                           source:         'a/ruby/source/file.rb')
       end
 
-      it 'it returns nil' do
+      it 'returns nil' do
         expect(computed).to be_nil
       end
     end
@@ -66,14 +66,14 @@ RSpec.describe Reek::Report::CodeClimateFingerprint do
       let(:name) { 'bravo' }
       let(:expected_fingerprint) { '9c3fd378178118a67e9509f87cae24f9' }
 
-      it_should_behave_like 'computes a fingerprint with identifying parameters'
+      it_behaves_like 'computes a fingerprint with identifying parameters'
     end
 
     context 'when the name is another thing it has another fingerprint' do
       let(:name) { 'echo' }
       let(:expected_fingerprint) { 'd2a6d2703ce04cca65e7300b7de4b89f' }
 
-      it_should_behave_like 'computes a fingerprint with identifying parameters'
+      it_behaves_like 'computes a fingerprint with identifying parameters'
     end
 
     shared_examples_for 'computes a fingerprint with identifying and non-identifying parameters' do
@@ -98,7 +98,7 @@ RSpec.describe Reek::Report::CodeClimateFingerprint do
       let(:lines) { [1, 7, 10, 13, 15] }
       let(:expected_fingerprint) { '238733f4f51ba5473dcbe94a43ec5400' }
 
-      it_should_behave_like 'computes a fingerprint with identifying and non-identifying parameters'
+      it_behaves_like 'computes a fingerprint with identifying and non-identifying parameters'
     end
 
     context 'when the non-identifying parameters change, it computes the same fingerprint' do
@@ -107,7 +107,7 @@ RSpec.describe Reek::Report::CodeClimateFingerprint do
       let(:lines) { [1, 7, 10, 13, 15, 17, 19, 20, 25] }
       let(:expected_fingerprint) { '238733f4f51ba5473dcbe94a43ec5400' }
 
-      it_should_behave_like 'computes a fingerprint with identifying and non-identifying parameters'
+      it_behaves_like 'computes a fingerprint with identifying and non-identifying parameters'
     end
 
     context 'but when the identifying parameters change, it computes a different fingerprint' do
@@ -116,7 +116,7 @@ RSpec.describe Reek::Report::CodeClimateFingerprint do
       let(:lines) { [1, 7, 10, 13, 15] }
       let(:expected_fingerprint) { 'e0c35e9223cc19bdb9a04fb3e60573e1' }
 
-      it_should_behave_like 'computes a fingerprint with identifying and non-identifying parameters'
+      it_behaves_like 'computes a fingerprint with identifying and non-identifying parameters'
     end
   end
 end

data/spec/reek/report/yaml_report_spec.rb

@@ -30,8 +30,8 @@ RSpec.describe Reek::Report::YAMLReport do
       out = StringIO.new
       instance.show(out)
       out.rewind
-      result = YAML.load(out.read)
-      expected = YAML.load <<-EOS
+      result = YAML.safe_load(out.read)
+      expected = YAML.safe_load <<-EOS
 ---
 - context:        "simple"
   lines:
@@ -57,8 +57,8 @@ RSpec.describe Reek::Report::YAMLReport do
         out = StringIO.new
         instance.show(out)
         out.rewind
-        result = YAML.load(out.read)
-        expected = YAML.load <<-EOS
+        result = YAML.safe_load(out.read)
+        expected = YAML.safe_load <<-EOS
 ---
 - context:        "simple"
   lines:

data/spec/reek/{smell_detectors/smell_configuration_spec.rb → smell_configuration_spec.rb}

@@ -1,7 +1,7 @@
-require_relative '../../spec_helper'
-require_lib 'reek/smell_detectors/smell_configuration'
+require_relative '../spec_helper'
+require_lib 'reek/smell_configuration'
 
-RSpec.describe Reek::SmellDetectors::SmellConfiguration do
+RSpec.describe Reek::SmellConfiguration do
   context 'when overriding default configs' do
     let(:base_config) do
       {

data/spec/reek/smell_detectors/base_detector_spec.rb

@@ -1,5 +1,6 @@
 require_relative '../../spec_helper'
 require_lib 'reek/smell_detectors/base_detector'
+require_lib 'reek/smell_detectors/duplicate_method_call'
 
 RSpec.describe Reek::SmellDetectors::BaseDetector do
   describe '.todo_configuration_for' do
@@ -43,4 +44,21 @@ RSpec.describe Reek::SmellDetectors::BaseDetector do
       expect(described_class.valid_detector?('Unknown')).to be false
     end
   end
+
+  describe '.to_detector' do
+    it 'returns the right detector' do
+      expect(described_class.to_detector('DuplicateMethodCall')).to eq(Reek::SmellDetectors::DuplicateMethodCall)
+    end
+
+    it 'raise NameError for an invalid detector name' do
+      expect { described_class.to_detector('Unknown') }.to raise_error(NameError)
+    end
+  end
+
+  describe '.configuration_keys' do
+    it 'returns the right keys' do
+      expected_keys = Reek::SmellDetectors::DuplicateMethodCall.configuration_keys.to_a
+      expect(expected_keys).to eq([:enabled, :exclude, :max_calls, :allow_calls])
+    end
+  end
 end

data/spec/reek/smell_detectors/duplicate_method_call_spec.rb

@@ -37,8 +37,8 @@ RSpec.describe Reek::SmellDetectors::DuplicateMethodCall do
     EOS
 
     expect(src).
-      to reek_of(:DuplicateMethodCall, lines: [3, 4], name:  'charlie.delta', count: 2).
-      and reek_of(:DuplicateMethodCall, lines: [8, 9], name:  'foxtrot.golf', count: 2)
+      to reek_of(:DuplicateMethodCall, lines: [3, 4], name: 'charlie.delta', count: 2).
+      and reek_of(:DuplicateMethodCall, lines: [8, 9], name: 'foxtrot.golf', count: 2)
   end
 
   context 'with repeated method calls' do

data/spec/reek/smell_detectors/feature_envy_spec.rb

@@ -33,8 +33,8 @@ RSpec.describe Reek::SmellDetectors::FeatureEnvy do
     EOS
 
     expect(src).
-      to reek_of(:FeatureEnvy, lines: [3, 3], name:  'charlie').
-      and reek_of(:FeatureEnvy, lines: [7, 7], name:  'hotel')
+      to reek_of(:FeatureEnvy, lines: [3, 3], name: 'charlie').
+      and reek_of(:FeatureEnvy, lines: [7, 7], name: 'hotel')
   end
 
   it 'does not report use of self' do
@@ -97,6 +97,16 @@ RSpec.describe Reek::SmellDetectors::FeatureEnvy do
     expect(src).not_to reek_of(:FeatureEnvy)
   end
 
+  it 'does not report parameter method called with super' do
+    src = 'def alfa(bravo) super(bravo.to_s); end'
+    expect(src).not_to reek_of(:FeatureEnvy)
+  end
+
+  it 'reports parameter method called with super and elsewhere' do
+    src = 'def alfa(bravo) bravo.charley; super(bravo.to_s); end'
+    expect(src).to reek_of(:FeatureEnvy)
+  end
+
   it 'ignores multiple ivars' do
     src = <<-EOS
       def func
@@ -142,7 +152,7 @@ RSpec.describe Reek::SmellDetectors::FeatureEnvy do
       and reek_of(:FeatureEnvy, name: 'bravo')
   end
 
-  it 'is not be fooled by duplication' do
+  it 'is not fooled by duplication' do
     src = <<-EOS
       def alfa(bravo)
         @charlie.delta(bravo.echo)
@@ -150,18 +160,18 @@ RSpec.describe Reek::SmellDetectors::FeatureEnvy do
       end
     EOS
 
-    expect(src).to reek_only_of(:DuplicateMethodCall)
+    expect(src).to reek_only_of(:DuplicateMethodCall, name: 'bravo.echo')
   end
 
-  it 'does not count local calls' do
+  it 'counts local calls' do
     src = <<-EOS
       def alfa(bravo)
-        @charlie.delta(bravo.echo)
-        @foxtrot.delta(bravo.echo)
+        charlie.delta(bravo.echo)
+        foxtrot.delta(bravo.echo)
       end
     EOS
 
-    expect(src).to reek_only_of(:DuplicateMethodCall)
+    expect(src).to reek_only_of(:DuplicateMethodCall, name: 'bravo.echo')
   end
 
   it 'reports many calls to lvar' do

data/spec/reek/smell_detectors/manual_dispatch_spec.rb

@@ -59,4 +59,17 @@ RSpec.describe Reek::SmellDetectors::ManualDispatch do
 
     expect(src).to reek_of(:ManualDispatch)
   end
+
+  it 'reports occurences in a single method as one smell warning' do
+    src = <<-EOS
+      class Alfa
+        def bravo(charlie, delta)
+          return true if charlie.respond_to?(:to_a)
+          true if delta.respond_to?(:to_a)
+        end
+      end
+    EOS
+
+    expect(src).to reek_of(:ManualDispatch, lines: [3, 4], context: 'Alfa#bravo')
+  end
 end

data/spec/reek/smell_detectors/module_initialize_spec.rb

@@ -16,7 +16,17 @@ RSpec.describe Reek::SmellDetectors::ModuleInitialize do
                            source:  'string')
   end
 
-  it 'does not report with method named initialize in a nested class' do
+  it 'reports nothing for a method with a different name' do
+    src = <<-EOF
+      module Alfa
+        def bravo; end
+      end
+    EOF
+
+    expect(src).not_to reek_of(:ModuleInitialize)
+  end
+
+  it 'reports nothing for a method named initialize in a nested class' do
     src = <<-EOF
       module Alfa
         class Bravo
@@ -28,7 +38,7 @@ RSpec.describe Reek::SmellDetectors::ModuleInitialize do
     expect(src).not_to reek_of(:ModuleInitialize)
   end
 
-  it 'does not smell with method named initialize in a nested struct' do
+  it 'reports nothing for a method named initialize in a nested struct' do
     src = <<-EOF
       module Alfa
         Bravo = Struct.new(:charlie) do
@@ -39,4 +49,15 @@ RSpec.describe Reek::SmellDetectors::ModuleInitialize do
 
     expect(src).not_to reek_of(:ModuleInitialize)
   end
+
+  it 'can be disabled via comment' do
+    src = <<-EOS
+      # :reek:ModuleInitialize
+      module Alfa
+        def initialize; end
+      end
+    EOS
+
+    expect(src).not_to reek_of(:ModuleInitialize)
+  end
 end

data/spec/reek/smell_detectors/nested_iterators_spec.rb

@@ -155,7 +155,7 @@ RSpec.describe Reek::SmellDetectors::NestedIterators do
   it 'handles the case where super receives a block and arguments' do
     src = <<-EOS
       def alfa
-        super do |bravo|
+        super(delta) do |bravo|
           bravo.each { |charlie| charlie }
         end
       end

data/spec/reek/smell_detectors/prima_donna_method_spec.rb

@@ -47,4 +47,16 @@ RSpec.describe Reek::SmellDetectors::PrimaDonnaMethod do
 
     expect(src).not_to reek_of(:PrimaDonnaMethod)
   end
+
+  it 'does not report methods we excluded via comment' do
+    source = <<-EOF
+      # :reek:PrimaDonnaMethod: { exclude: [ bravo! ] }
+      class Alfa
+        def bravo!
+        end
+      end
+    EOF
+
+    expect(source).not_to reek_of(:PrimaDonnaMethod)
+  end
 end

data/spec/reek/smell_detectors/subclassed_from_core_class_spec.rb

@@ -45,11 +45,6 @@ RSpec.describe Reek::SmellDetectors::SubclassedFromCoreClass do
     expect(src).not_to reek_of(:SubclassedFromCoreClass)
   end
 
-  it 'reports if we inherit from a core class using Class#new' do
-    src = 'Alfa = Class.new(Array)'
-    expect(src).to reek_of(:SubclassedFromCoreClass)
-  end
-
   it 'reports if inner class inherit from a core class' do
     src = <<-EOS
       class Alfa

data/spec/reek/smell_detectors/uncommunicative_variable_name_spec.rb

@@ -25,8 +25,8 @@ RSpec.describe Reek::SmellDetectors::UncommunicativeVariableName do
       end
     EOS
 
-    expect(src).to reek_of(:UncommunicativeVariableName, lines: [2], name:  'x').
-      and reek_of(:UncommunicativeVariableName, lines: [3], name:  'y')
+    expect(src).to reek_of(:UncommunicativeVariableName, lines: [2], name: 'x').
+      and reek_of(:UncommunicativeVariableName, lines: [3], name: 'y')
   end
 
   context 'instance variables' do

data/spec/reek/smell_detectors/unused_parameters_spec.rb

@@ -24,7 +24,7 @@ RSpec.describe Reek::SmellDetectors::UnusedParameters do
 
     expect(src).
       to reek_of(:UnusedParameters, lines: [1], name: 'bravo').
-      and reek_of(:UnusedParameters, lines: [1], name:  'charlie')
+      and reek_of(:UnusedParameters, lines: [1], name: 'charlie')
   end
 
   it 'reports nothing for no parameters' do

data/spec/reek/{smell_detectors/smell_warning_spec.rb → smell_warning_spec.rb}

@@ -1,7 +1,7 @@
-require_relative '../../spec_helper'
-require_lib 'reek/smell_detectors/smell_warning'
+require_relative '../spec_helper'
+require_lib 'reek/smell_warning'
 
-RSpec.describe Reek::SmellDetectors::SmellWarning do
+RSpec.describe Reek::SmellWarning do
   let(:duplication_detector)  { build(:smell_detector, smell_type: 'DuplicateMethodCall') }
   let(:feature_envy_detector) { build(:smell_detector, smell_type: 'FeatureEnvy') }
   let(:utility_function_detector) { build(:smell_detector, smell_type: 'UtilityFunction') }
@@ -30,14 +30,14 @@ RSpec.describe Reek::SmellDetectors::SmellWarning do
       let(:first) { build(:smell_warning, smell_detector: duplication_detector) }
       let(:second) { build(:smell_warning, smell_detector: feature_envy_detector) }
 
-      it_should_behave_like 'first sorts ahead of second'
+      it_behaves_like 'first sorts ahead of second'
     end
 
     context 'smells differing only by lines' do
       let(:first) { build(:smell_warning, smell_detector: feature_envy_detector, lines: [2]) }
       let(:second) { build(:smell_warning, smell_detector: feature_envy_detector, lines: [3]) }
 
-      it_should_behave_like 'first sorts ahead of second'
+      it_behaves_like 'first sorts ahead of second'
     end
 
     context 'smells differing only by context' do
@@ -46,7 +46,7 @@ RSpec.describe Reek::SmellDetectors::SmellWarning do
         build(:smell_warning, smell_detector: duplication_detector, context: 'second')
       end
 
-      it_should_behave_like 'first sorts ahead of second'
+      it_behaves_like 'first sorts ahead of second'
     end
 
     context 'smells differing only by message' do
@@ -59,7 +59,7 @@ RSpec.describe Reek::SmellDetectors::SmellWarning do
                               context: 'ctx', message: 'second message')
       end
 
-      it_should_behave_like 'first sorts ahead of second'
+      it_behaves_like 'first sorts ahead of second'
     end
 
     context 'smell name takes precedence over message' do
@@ -70,7 +70,7 @@ RSpec.describe Reek::SmellDetectors::SmellWarning do
         build(:smell_warning, smell_detector: utility_function_detector, message: 'first message')
       end
 
-      it_should_behave_like 'first sorts ahead of second'
+      it_behaves_like 'first sorts ahead of second'
     end
 
     context 'smells differing everywhere' do
@@ -86,7 +86,7 @@ RSpec.describe Reek::SmellDetectors::SmellWarning do
                               message: "has the variable name '@s'")
       end
 
-      it_should_behave_like 'first sorts ahead of second'
+      it_behaves_like 'first sorts ahead of second'
     end
   end
 

data/spec/reek/source/source_code_spec.rb

@@ -26,36 +26,15 @@ RSpec.describe Reek::Source::SourceCode do
   end
 
   context 'when the parser fails' do
-    let(:catcher) { StringIO.new }
     let(:source_name) { 'Test source' }
     let(:error_message) { 'Error message' }
     let(:parser) { class_double(Parser::Ruby23) }
     let(:src) { described_class.new(code: '', origin: source_name, parser: parser) }
 
-    before { $stderr = catcher }
-
     shared_examples_for 'handling and recording the error' do
-      it 'does not raise an error' do
-        src.syntax_tree
-      end
-
-      it 'returns an empty syntax tree' do
-        expect(src.syntax_tree).to be_nil
-      end
-
-      it 'records the syntax error' do
-        src.syntax_tree
-        expect(catcher.string).to match(error_class.name)
-      end
-
-      it 'records the source name' do
-        src.syntax_tree
-        expect(catcher.string).to match(source_name)
-      end
-
-      it 'records the error message' do
-        src.syntax_tree
-        expect(catcher.string).to match(error_message)
+      it 'raises an informative error' do
+        expect { src.syntax_tree }.
+          to raise_error(/#{source_name}: #{error_class.name}: #{error_message}/)
       end
     end
 
@@ -68,7 +47,7 @@ RSpec.describe Reek::Source::SourceCode do
           and_raise error_class.new(diagnostic)
       end
 
-      it_should_behave_like 'handling and recording the error'
+      it_behaves_like 'handling and recording the error'
     end
 
     context 'with a Racc::ParseError' do
@@ -79,7 +58,7 @@ RSpec.describe Reek::Source::SourceCode do
           and_raise(error_class.new(error_message))
       end
 
-      it_should_behave_like 'handling and recording the error'
+      it_behaves_like 'handling and recording the error'
     end
 
     context 'with a generic error' do
@@ -91,10 +70,8 @@ RSpec.describe Reek::Source::SourceCode do
       end
 
       it 'raises the error' do
-        expect { src.syntax_tree }.to raise_error
+        expect { src.syntax_tree }.to raise_error error_class
       end
     end
-
-    after { $stderr = STDERR }
   end
 end

data/spec/reek/source/source_locator_spec.rb

@@ -29,34 +29,66 @@ RSpec.describe Reek::Source::SourceLocator do
       end
     end
 
+    # rubocop:disable RSpec/NestedGroups
     context 'exclude paths' do
       let(:configuration) do
         test_configuration_for(CONFIG_PATH.join('with_excluded_paths.reek'))
       end
 
-      let(:path) { SAMPLES_PATH.join('source_with_exclude_paths') }
+      let(:options) { instance_double('Reek::CLI::Options', force_exclusion?: false) }
 
-      let(:expected_paths) do
-        [path.join('nested/uncommunicative_parameter_name.rb')]
-      end
+      context 'when the path is a file name in an excluded directory' do
+        let(:path) { SAMPLES_PATH.join('source_with_exclude_paths', 'ignore_me', 'uncommunicative_method_name.rb') }
 
-      let(:paths_that_are_expected_to_be_ignored) do
-        [
-          path.join('ignore_me/uncommunicative_method_name.rb'),
-          path.join('nested/ignore_me_as_well/irresponsible_module.rb')
-        ]
-      end
+        context 'when options.force_exclusion? is true' do
+          before do
+            allow(options).to receive(:force_exclusion?).and_return(true)
+          end
 
-      it 'does not use excluded paths' do
-        sources = described_class.new([path], configuration: configuration).sources
-        expect(sources).not_to include(*paths_that_are_expected_to_be_ignored)
+          it 'excludes this file' do
+            sources = described_class.new([path], configuration: configuration, options: options).sources
+            expect(sources).not_to include(path)
+          end
+        end
+
+        context 'when options.force_exclusion? is false' do
+          before do
+            allow(options).to receive(:force_exclusion?).and_return(false)
+          end
+
+          it 'includes this file' do
+            sources = described_class.new([path], configuration: configuration, options: options).sources
+            expect(sources).to include(path)
+          end
+        end
       end
 
-      it 'scans directories that are not excluded' do
-        sources = described_class.new([path], configuration: configuration).sources
-        expect(sources).to eq expected_paths
+      context 'when path is a directory' do
+        let(:path) { SAMPLES_PATH.join('source_with_exclude_paths') }
+
+        let(:expected_paths) do
+          [path.join('nested/uncommunicative_parameter_name.rb')]
+        end
+
+        let(:paths_that_are_expected_to_be_ignored) do
+          [
+            path.join('ignore_me/uncommunicative_method_name.rb'),
+            path.join('nested/ignore_me_as_well/irresponsible_module.rb')
+          ]
+        end
+
+        it 'does not use excluded paths' do
+          sources = described_class.new([path], configuration: configuration, options: options).sources
+          expect(sources).not_to include(*paths_that_are_expected_to_be_ignored)
+        end
+
+        it 'scans directories that are not excluded' do
+          sources = described_class.new([path], configuration: configuration).sources
+          expect(sources).to eq expected_paths
+        end
       end
     end
+    # rubocop:enable RSpec/NestedGroups
 
     context 'non-Ruby paths' do
       let(:path) { SAMPLES_PATH.join('source_with_non_ruby_files') }

data/spec/reek/spec/should_reek_of_spec.rb

@@ -133,7 +133,7 @@ RSpec.describe Reek::Spec::ShouldReekOf do
   context 'for a smell that is disabled by default' do
     before do
       default_config = Reek::SmellDetectors::UnusedPrivateMethod.default_config
-      expect(default_config[Reek::SmellDetectors::SmellConfiguration::ENABLED_KEY]).to be_falsy
+      expect(default_config[Reek::SmellConfiguration::ENABLED_KEY]).to be_falsy
     end
 
     it 'enables the smell detector to match automatically' do

data/spec/reek/spec/should_reek_only_of_spec.rb

@@ -36,14 +36,14 @@ RSpec.describe Reek::Spec::ShouldReekOnlyOf do
   context 'with no smells' do
     let(:smells) { [] }
 
-    it_should_behave_like 'no match'
+    it_behaves_like 'no match'
   end
 
   context 'with 1 non-matching smell' do
     let(:control_couple_detector) { build(:smell_detector, smell_type: 'ControlParameter') }
     let(:smells) { [build(:smell_warning, smell_detector: control_couple_detector)] }
 
-    it_should_behave_like 'no match'
+    it_behaves_like 'no match'
   end
 
   context 'with 2 non-matching smells' do
@@ -56,7 +56,7 @@ RSpec.describe Reek::Spec::ShouldReekOnlyOf do
       ]
     end
 
-    it_should_behave_like 'no match'
+    it_behaves_like 'no match'
   end
 
   context 'with 1 non-matching and 1 matching smell' do
@@ -70,7 +70,7 @@ RSpec.describe Reek::Spec::ShouldReekOnlyOf do
       ]
     end
 
-    it_should_behave_like 'no match'
+    it_behaves_like 'no match'
   end
 
   context 'with 1 matching smell' do

data/spec/spec_helper.rb

@@ -1,4 +1,5 @@
 require 'pathname'
+require 'timeout'
 require_relative '../lib/reek'
 require_relative '../lib/reek/spec'
 require_relative '../lib/reek/ast/ast_node_class_map'
@@ -84,9 +85,9 @@ RSpec.configure do |config|
     mocks.verify_doubled_constant_names = true
   end
 
-  # Avoid infinitely running tests. This is mainly useful when running mutant.
-  # Set the DEBUG environment variable to something truthy like '1' to disable
-  # this and allow using pry without specs failing.
+  # Avoid infinitely running tests. This is mainly useful when running a
+  # mutation tester. Set the DEBUG environment variable to something truthy
+  # like '1' to disable this and allow using pry without specs failing.
   unless ENV['DEBUG']
     config.around(:each) do |example|
       Timeout.timeout(5, &example)

data/tasks/configuration.rake

@@ -1,11 +1,11 @@
-require_relative '../lib/reek/smell_detectors/detector_repository'
+require_relative '../lib/reek/detector_repository'
 require 'yaml'
 
 namespace :configuration do
   desc 'Updates the default configuration file when smell defaults change'
   task :update_default_configuration do
     DEFAULT_SMELL_CONFIGURATION = 'defaults.reek'.freeze
-    content = Reek::SmellDetectors::DetectorRepository.smell_types.each_with_object({}) do |klass, hash|
+    content = Reek::DetectorRepository.smell_types.each_with_object({}) do |klass, hash|
       hash[klass.smell_type] = klass.default_config
     end
     File.open(DEFAULT_SMELL_CONFIGURATION, 'w') { |file| YAML.dump(content, file) }