reek 4.5.0 → 4.6.0

data/features/samples.feature

@@ -63,7 +63,7 @@ Feature: Basic smell detection
       UncommunicativeVariableName: Inline::C#module_name has the variable name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
       UncommunicativeVariableName: Inline::C#parse_signature has the variable name 'x' [https://github.com/troessner/reek/blob/master/docs/Uncommunicative-Variable-Name.md]
       UtilityFunction: Inline::C#strip_comments doesn't depend on instance state (maybe move it to another class?) [https://github.com/troessner/reek/blob/master/docs/Utility-Function.md]
-    optparse.rb -- 130 warnings:
+    optparse.rb -- 126 warnings:
       Attribute: OptionParser#banner is a writable attribute [https://github.com/troessner/reek/blob/master/docs/Attribute.md]
       Attribute: OptionParser#default_argv is a writable attribute [https://github.com/troessner/reek/blob/master/docs/Attribute.md]
       Attribute: OptionParser#program_name is a writable attribute [https://github.com/troessner/reek/blob/master/docs/Attribute.md]
@@ -127,10 +127,6 @@ Feature: Basic smell detection
       LongParameterList: OptionParser::Switch#initialize has 7 parameters [https://github.com/troessner/reek/blob/master/docs/Long-Parameter-List.md]
       LongParameterList: OptionParser::Switch#summarize has 5 parameters [https://github.com/troessner/reek/blob/master/docs/Long-Parameter-List.md]
       ManualDispatch: OptionParser#make_switch manually dispatches method call [https://github.com/troessner/reek/blob/master/docs/Manual-Dispatch.md]
-      ManualDispatch: OptionParser#make_switch manually dispatches method call [https://github.com/troessner/reek/blob/master/docs/Manual-Dispatch.md]
-      ManualDispatch: OptionParser#make_switch manually dispatches method call [https://github.com/troessner/reek/blob/master/docs/Manual-Dispatch.md]
-      ManualDispatch: OptionParser::List#accept manually dispatches method call [https://github.com/troessner/reek/blob/master/docs/Manual-Dispatch.md]
-      ManualDispatch: OptionParser::List#accept manually dispatches method call [https://github.com/troessner/reek/blob/master/docs/Manual-Dispatch.md]
       ManualDispatch: OptionParser::List#accept manually dispatches method call [https://github.com/troessner/reek/blob/master/docs/Manual-Dispatch.md]
       ManualDispatch: OptionParser::List#add_banner manually dispatches method call [https://github.com/troessner/reek/blob/master/docs/Manual-Dispatch.md]
       ManualDispatch: OptionParser::List#summarize manually dispatches method call [https://github.com/troessner/reek/blob/master/docs/Manual-Dispatch.md]
@@ -194,7 +190,7 @@ Feature: Basic smell detection
       UnusedParameters: OptionParser::Completion#convert has unused parameter 'opt' [https://github.com/troessner/reek/blob/master/docs/Unused-Parameters.md]
       UnusedParameters: OptionParser::Switch::NoArgument#parse has unused parameter 'argv' [https://github.com/troessner/reek/blob/master/docs/Unused-Parameters.md]
       UnusedParameters: OptionParser::Switch::OptionalArgument#parse has unused parameter 'argv' [https://github.com/troessner/reek/blob/master/docs/Unused-Parameters.md]
-    redcloth.rb -- 111 warnings:
+    redcloth.rb -- 110 warnings:
       Attribute: RedCloth#filter_html is a writable attribute [https://github.com/troessner/reek/blob/master/docs/Attribute.md]
       Attribute: RedCloth#filter_styles is a writable attribute [https://github.com/troessner/reek/blob/master/docs/Attribute.md]
       Attribute: RedCloth#hard_breaks is a writable attribute [https://github.com/troessner/reek/blob/master/docs/Attribute.md]
@@ -238,7 +234,6 @@ Feature: Basic smell detection
       LongParameterList: RedCloth#textile_fn_ has 5 parameters [https://github.com/troessner/reek/blob/master/docs/Long-Parameter-List.md]
       LongParameterList: RedCloth#textile_p has 4 parameters [https://github.com/troessner/reek/blob/master/docs/Long-Parameter-List.md]
       ManualDispatch: RedCloth#block_textile_prefix manually dispatches method call [https://github.com/troessner/reek/blob/master/docs/Manual-Dispatch.md]
-      ManualDispatch: RedCloth#block_textile_prefix manually dispatches method call [https://github.com/troessner/reek/blob/master/docs/Manual-Dispatch.md]
       NestedIterators: RedCloth#block_textile_lists contains iterators nested 3 deep [https://github.com/troessner/reek/blob/master/docs/Nested-Iterators.md]
       NestedIterators: RedCloth#block_textile_table contains iterators nested 2 deep [https://github.com/troessner/reek/blob/master/docs/Nested-Iterators.md]
       NestedIterators: RedCloth#block_textile_table contains iterators nested 3 deep [https://github.com/troessner/reek/blob/master/docs/Nested-Iterators.md]
@@ -306,5 +301,5 @@ Feature: Basic smell detection
       UtilityFunction: RedCloth#lT doesn't depend on instance state (maybe move it to another class?) [https://github.com/troessner/reek/blob/master/docs/Utility-Function.md]
       UtilityFunction: RedCloth#no_textile doesn't depend on instance state (maybe move it to another class?) [https://github.com/troessner/reek/blob/master/docs/Utility-Function.md]
       UtilityFunction: RedCloth#v_align doesn't depend on instance state (maybe move it to another class?) [https://github.com/troessner/reek/blob/master/docs/Utility-Function.md]
-    292 total warnings
+    287 total warnings
     """

data/features/step_definitions/reek_steps.rb

@@ -23,17 +23,17 @@ Then /^stdout includes "(.*)"$/ do |text|
 end
 
 Then /^it succeeds$/ do
-  success = Reek::CLI::Options::DEFAULT_SUCCESS_EXIT_CODE
+  success = Reek::CLI::Status::DEFAULT_SUCCESS_EXIT_CODE
   expect(last_command_started).to have_exit_status(success)
 end
 
 Then /^the exit status indicates an error$/ do
-  error = Reek::CLI::Options::DEFAULT_ERROR_EXIT_CODE
+  error = Reek::CLI::Status::DEFAULT_ERROR_EXIT_CODE
   expect(last_command_started).to have_exit_status(error)
 end
 
 Then /^the exit status indicates smells$/ do
-  smells = Reek::CLI::Options::DEFAULT_FAILURE_EXIT_CODE
+  smells = Reek::CLI::Status::DEFAULT_FAILURE_EXIT_CODE
   expect(last_command_started).to have_exit_status(smells)
 end
 
@@ -46,8 +46,8 @@ Then /^it reports:$/ do |report|
 end
 
 Then /^it reports this yaml:$/ do |expected_yaml|
-  expected_warnings = YAML.load(expected_yaml.chomp)
-  actual_warnings = YAML.load(last_command_started.stdout)
+  expected_warnings = YAML.safe_load(expected_yaml.chomp)
+  actual_warnings = YAML.safe_load(last_command_started.stdout)
   expect(actual_warnings).to eq expected_warnings
 end
 

data/features/todo_list.feature

@@ -1,5 +1,4 @@
-Feature:
-
+Feature: Auto-generate a todo file
   Write a Reek configuration as a kind of todo list that will prevent Reek
   from reporting smells on the current code.
   This can then be worked on later on.

data/lib/reek/ast/reference_collector.rb

@@ -6,8 +6,6 @@ module Reek
     # of an abstract syntax tree.
     #
     class ReferenceCollector
-      STOP_NODES = [:class, :module, :def, :defs].freeze
-
       def initialize(ast)
         @ast = ast
       end
@@ -22,12 +20,12 @@ module Reek
 
       def explicit_self_calls
         [:self, :super, :zsuper, :ivar, :ivasgn].flat_map do |node_type|
-          ast.each_node(node_type, STOP_NODES)
+          ast.each_node(node_type)
         end
       end
 
       def implicit_self_calls
-        ast.each_node(:send, STOP_NODES).reject(&:receiver)
+        ast.each_node(:send).reject(&:receiver)
       end
     end
   end

data/lib/reek/ast/sexp_extensions/arguments.rb

@@ -8,11 +8,6 @@ module Reek
           children.first
         end
 
-        # Other is a symbol?
-        def ==(other)
-          name == other
-        end
-
         def marked_unused?
           plain_name.start_with?('_')
         end

data/lib/reek/ast/sexp_extensions/constant.rb

@@ -4,6 +4,7 @@ module Reek
     module SexpExtensions
       # Utility methods for :const nodes.
       module ConstNode
+        # TODO: name -> full_name, simple_name -> name
         def name
           if namespace
             "#{namespace.format_to_ruby}::#{simple_name}"

data/lib/reek/cli/application.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 require_relative 'options'
+require_relative 'status'
 require_relative '../configuration/app_configuration'
 require_relative '../source/source_locator'
 require_relative 'command/report_command'
@@ -17,7 +18,6 @@ module Reek
 
       def initialize(argv)
         @options = configure_options(argv)
-        @status = options.success_exit_code
         @configuration = configure_app_configuration(options.config_file)
         @command = command_class.new(options: options,
                                      sources: sources,
@@ -30,21 +30,20 @@ module Reek
 
       private
 
-      attr_accessor :status
       attr_reader :command, :options
 
       def configure_options(argv)
         Options.new(argv).parse
       rescue OptionParser::InvalidOption => error
-        $stderr.puts "Error: #{error}"
-        exit Options::DEFAULT_ERROR_EXIT_CODE
+        warn "Error: #{error}"
+        exit Status::DEFAULT_ERROR_EXIT_CODE
       end
 
       def configure_app_configuration(config_file)
         Configuration::AppConfiguration.from_path(config_file)
       rescue Reek::Configuration::ConfigFileException => error
-        $stderr.puts "Error: #{error}"
-        exit Options::DEFAULT_ERROR_EXIT_CODE
+        warn "Error: #{error}"
+        exit Status::DEFAULT_ERROR_EXIT_CODE
       end
 
       def command_class
@@ -80,11 +79,11 @@ module Reek
       end
 
       def working_directory_as_source
-        Source::SourceLocator.new(['.'], configuration: configuration).sources
+        Source::SourceLocator.new(['.'], configuration: configuration, options: options).sources
       end
 
       def sources_from_argv
-        Source::SourceLocator.new(argv).sources
+        Source::SourceLocator.new(argv, configuration: configuration, options: options).sources
       end
 
       def source_from_pipe

data/lib/reek/cli/command/report_command.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 require_relative 'base_command'
 require_relative '../../examiner'
+require_relative '../../logging_error_handler'
 require_relative '../../report'
 
 module Reek
@@ -23,7 +24,8 @@ module Reek
           sources.each do |source|
             reporter.add_examiner Examiner.new(source,
                                                filter_by_smells: smell_names,
-                                               configuration: configuration)
+                                               configuration: configuration,
+                                               error_handler: LoggingErrorHandler.new)
           end
         end
 

data/lib/reek/cli/options.rb

@@ -2,6 +2,7 @@
 require 'optparse'
 require 'rainbow'
 require_relative '../version'
+require_relative 'status'
 
 module Reek
   module CLI
@@ -10,15 +11,11 @@ module Reek
     #
     # See {file:docs/Command-Line-Options.md} for details.
     #
-    # :reek:TooManyInstanceVariables: { max_instance_variables: 11 }
-    # :reek:TooManyMethods: { max_methods: 17 }
+    # :reek:TooManyInstanceVariables: { max_instance_variables: 12 }
+    # :reek:TooManyMethods: { max_methods: 18 }
     # :reek:Attribute: { enabled: false }
     #
     class Options
-      DEFAULT_SUCCESS_EXIT_CODE  = 0
-      DEFAULT_ERROR_EXIT_CODE    = 1
-      DEFAULT_FAILURE_EXIT_CODE  = 2
-
       attr_reader :argv, :parser, :smells_to_detect
       attr_accessor :colored,
                     :config_file,
@@ -30,7 +27,8 @@ module Reek
                     :sorting,
                     :success_exit_code,
                     :failure_exit_code,
-                    :generate_todo_list
+                    :generate_todo_list,
+                    :force_exclusion
 
       def initialize(argv = [])
         @argv               = argv
@@ -41,9 +39,10 @@ module Reek
         @show_links         = true
         @smells_to_detect   = []
         @colored            = tty_output?
-        @success_exit_code  = DEFAULT_SUCCESS_EXIT_CODE
-        @failure_exit_code  = DEFAULT_FAILURE_EXIT_CODE
+        @success_exit_code  = Status::DEFAULT_SUCCESS_EXIT_CODE
+        @failure_exit_code  = Status::DEFAULT_FAILURE_EXIT_CODE
         @generate_todo_list = false
+        @force_exclusion    = false
 
         set_up_parser
       end
@@ -54,6 +53,10 @@ module Reek
         self
       end
 
+      def force_exclusion?
+        @force_exclusion
+      end
+
       private
 
       # TTY output generally means the output will not undergo further
@@ -98,7 +101,11 @@ module Reek
         parser.on('-c', '--config FILE', 'Read configuration options from FILE') do |file|
           self.config_file = Pathname.new(file)
         end
-        parser.on('--smell SMELL', 'Detect smell SMELL (default: all enabled smells)') do |smell|
+        parser.on('--smell SMELL',
+                  'Only look for a specific smell.',
+                  'Call it like this: reek --smell PrimaDonnaMethod source.rb',
+                  'Check out https://github.com/troessner/reek/blob/master/docs/Code-Smells.md '\
+                  'for a list of smells') do |smell|
           smells_to_detect << smell
         end
       end
@@ -120,7 +127,7 @@ module Reek
         end
       end
 
-      # :reek:TooManyStatements: { max_statements: 6 }
+      # :reek:TooManyStatements: { max_statements: 7 }
       def set_report_formatting_options
         parser.separator "\nText format options:"
         set_up_color_option
@@ -128,6 +135,7 @@ module Reek
         set_up_location_formatting_options
         set_up_progress_formatting_options
         set_up_sorting_option
+        set_up_force_exclusion_option
       end
 
       def set_up_color_option
@@ -174,17 +182,25 @@ module Reek
         end
       end
 
+      def set_up_force_exclusion_option
+        parser.on('--force-exclusion',
+                  'Force excluding files specified in the configuration `exclude_paths`',
+                  '  even if they are explicitly passed as arguments') do |force_exclusion|
+          self.force_exclusion = force_exclusion
+        end
+      end
+
       # :reek:DuplicateMethodCall: { max_calls: 2 }
       def set_exit_codes
         parser.separator "\nExit codes:"
         parser.on('--success-exit-code CODE',
                   'The exit code when no smells are found '\
-                  "(default: #{DEFAULT_SUCCESS_EXIT_CODE})") do |option|
+                  "(default: #{Status::DEFAULT_SUCCESS_EXIT_CODE})") do |option|
           self.success_exit_code = Integer(option)
         end
         parser.on('--failure-exit-code CODE',
                   'The exit code when smells are found '\
-                  "(default: #{DEFAULT_FAILURE_EXIT_CODE})") do |option|
+                  "(default: #{Status::DEFAULT_FAILURE_EXIT_CODE})") do |option|
           self.failure_exit_code = Integer(option)
         end
       end

data/lib/reek/cli/status.rb

@@ -0,0 +1,10 @@
+# frozen_string_literal: true
+module Reek
+  module CLI
+    module Status
+      DEFAULT_SUCCESS_EXIT_CODE  = 0
+      DEFAULT_ERROR_EXIT_CODE    = 1
+      DEFAULT_FAILURE_EXIT_CODE  = 2
+    end
+  end
+end

data/lib/reek/code_comment.rb

@@ -4,6 +4,7 @@ require 'yaml'
 
 require_relative 'smell_detectors/base_detector'
 require_relative 'errors/bad_detector_in_comment_error'
+require_relative 'errors/bad_detector_configuration_key_in_comment_error'
 require_relative 'errors/garbage_detector_configuration_in_comment_error'
 
 module Reek
@@ -45,7 +46,8 @@ module Reek
                                  line:             line,
                                  source:           source,
                                  options:          options).validate
-        @config.merge! detector_name => YAML.load(options || DISABLE_DETECTOR_CONFIGURATION)
+        @config.merge! detector_name => YAML.safe_load(options || DISABLE_DETECTOR_CONFIGURATION,
+                                                       [Regexp])
       end
     end
 
@@ -75,10 +77,10 @@ module Reek
     # 2.) Garbage in the detector configuration like { thats: a: bad: config }
     # 3.) Unknown configuration keys (e.g. by doing a simple typo: "exclude" vs. "exlude" )
     # 4.) Bad data types given as values for those keys
-    # This class validates [1] and [2] at the moment but will also validate [3]
-    # and [4] in the future.
+    # This class validates [1], [2] and [3] at the moment but will also validate
+    # [4] in the future.
     #
-    # :reek:TooManyInstanceVariables: { max_instance_variables: 5 }
+    # :reek:TooManyInstanceVariables: { max_instance_variables: 7 }
     class CodeCommentValidator
       #
       # @param detector_name [String] - the detector class that was parsed out of the original
@@ -94,16 +96,20 @@ module Reek
         @line             = line
         @source           = source
         @options          = options
+        @detector_class   = nil # We only know this one after our first initial checks
+        @parsed_options   = nil # We only know this one after our first initial checks
       end
 
       #
       # Method can raise the following errors:
       #   * Errors::BadDetectorInCommentError
       #   * Errors::GarbageDetectorConfigurationInCommentError
+      #   * Errors::BadDetectorConfigurationKeyInCommentError
       # @return [undefined]
       def validate
         escalate_bad_detector
         escalate_bad_detector_configuration
+        escalate_unknown_configuration_key
       end
 
       private
@@ -112,7 +118,9 @@ module Reek
                   :original_comment,
                   :line,
                   :source,
-                  :options
+                  :options,
+                  :detector_class,
+                  :parsed_options
 
       def escalate_bad_detector
         return if SmellDetectors::BaseDetector.valid_detector?(detector_name)
@@ -123,13 +131,47 @@ module Reek
       end
 
       def escalate_bad_detector_configuration
-        YAML.load(options || CodeComment::DISABLE_DETECTOR_CONFIGURATION)
+        @parsed_options = YAML.safe_load(options || CodeComment::DISABLE_DETECTOR_CONFIGURATION,
+                                         [Regexp])
       rescue Psych::SyntaxError
         raise Errors::GarbageDetectorConfigurationInCommentError, detector_name: detector_name,
                                                                   original_comment: original_comment,
                                                                   source: source,
                                                                   line: line
       end
+
+      def escalate_unknown_configuration_key
+        @detector_class = SmellDetectors::BaseDetector.to_detector(detector_name)
+
+        return if given_keys_legit?
+        raise Errors::BadDetectorConfigurationKeyInCommentError, detector_name: detector_name,
+                                                                 offensive_keys: configuration_keys_difference,
+                                                                 original_comment: original_comment,
+                                                                 source: source,
+                                                                 line: line
+      end
+
+      # @return [Boolean] - all keys in code comment are applicable to the detector in question
+      def given_keys_legit?
+        given_configuration_keys.subset? valid_detector_keys
+      end
+
+      # @return [Set] - the configuration keys that are found in the code comment
+      def given_configuration_keys
+        parsed_options.keys.map(&:to_sym).to_set
+      end
+
+      # @return [String] - all keys from the code comment that look bad
+      def configuration_keys_difference
+        given_configuration_keys.difference(valid_detector_keys).
+          to_a.map { |key| "'#{key}'" }.
+          join(', ')
+      end
+
+      # @return [Set] - all keys that are legit for the given detector
+      def valid_detector_keys
+        detector_class.configuration_keys
+      end
     end
   end
 end

data/lib/reek/configuration/configuration_file_finder.rb

@@ -17,42 +17,102 @@ module Reek
     # The order in which ConfigurationFileFinder tries to find such a
     # configuration file is exactly like above.
     module ConfigurationFileFinder
-      module_function
+      TOO_MANY_CONFIGURATION_FILES_MESSAGE = <<-EOS.freeze
 
-      def find_and_load(path: nil)
-        load_from_file(find(path: path))
-      end
+        Error: Found multiple configuration files %s
+        while scanning directory %s.
 
-      # :reek:ControlParameter
-      def find(path: nil, current: Pathname.pwd, home: Pathname.new(Dir.home))
-        path || find_by_dir(current) || find_in_dir(home)
-      end
+        Reek supports only one configuration file. You have 2 options now:
+        1) Remove all offending files.
+        2) Be specific about which one you want to load via the -c switch.
+
+      EOS
 
-      def find_by_dir(start)
-        start.ascend do |dir|
-          found = find_in_dir(dir)
-          return found if found
+      class << self
+        #
+        # Finds and loads a configuration file from a given path.
+        #
+        # @return [Hash]
+        #
+        def find_and_load(path: nil)
+          load_from_file(find(path: path))
         end
-      end
 
-      def find_in_dir(dir)
-        files = dir.children.select(&:file?).sort
-        files.find { |file| file.to_s.end_with?('.reek') }
-      end
+        #
+        # Tries to find a configuration file via:
+        #   * given path (e.g. via cli switch)
+        #   * ascending down from the current directory
+        #   * looking into the home directory
+        #
+        # @return [File|nil]
+        #
+        # :reek:ControlParameter
+        def find(path: nil, current: Pathname.pwd, home: Pathname.new(Dir.home))
+          path || find_by_dir(current) || find_in_dir(home)
+        end
+
+        #
+        # Loads a configuration file from a given path.
+        # Raises on invalid data.
+        #
+        # @param path [String]
+        # @return [Hash]
+        #
+        # :reek:TooManyStatements: { max_statements: 6 }
+        def load_from_file(path)
+          return {} unless path
+          begin
+            configuration = YAML.load_file(path) || {}
+          rescue => error
+            raise ConfigFileException, "Invalid configuration file #{path}, error is #{error}"
+          end
+
+          unless configuration.is_a? Hash
+            raise ConfigFileException, "Invalid configuration file \"#{path}\" -- Not a hash"
+          end
+          configuration
+        end
+
+        private
+
+        #
+        # Recursively traverse directories down to find a configuration file.
+        #
+        # @return [File|nil]
+        #
+        def find_by_dir(start)
+          start.ascend do |dir|
+            file = find_in_dir(dir)
+            return file if file
+          end
+        end
 
-      # :reek:TooManyStatements: { max_statements: 6 }
-      def load_from_file(path)
-        return {} unless path
-        begin
-          configuration = YAML.load_file(path) || {}
-        rescue => error
-          raise ConfigFileException, "Invalid configuration file #{path}, error is #{error}"
+        #
+        # Checks a given directory for a configuration file and returns it.
+        # Raises an exception if we find more than one.
+        #
+        # @return [File|nil]
+        #
+        # :reek:FeatureEnvy
+        def find_in_dir(dir)
+          found = dir.children.select { |item| item.file? && item.to_s.end_with?('.reek') }.sort
+          if found.size > 1
+            escalate_too_many_configuration_files found, dir
+          else
+            found.first
+          end
         end
 
-        unless configuration.is_a? Hash
-          raise ConfigFileException, "Invalid configuration file \"#{path}\" -- Not a hash"
+        #
+        # Writes a proper warning message to STDERR and then exits the program.
+        #
+        # @return [undefined]
+        #
+        def escalate_too_many_configuration_files(found, directory)
+          offensive_files = found.map { |file| "'#{file.basename}'" }.join(', ')
+          warn format(TOO_MANY_CONFIGURATION_FILES_MESSAGE, offensive_files, directory)
+          exit 1
         end
-        configuration
       end
     end
   end

data/lib/reek/context/ghost_context.rb

@@ -40,8 +40,7 @@ module Reek
                                             names: names
       end
 
-      def track_singleton_visibility(_visibility, _names)
-      end
+      def track_singleton_visibility(_visibility, _names); end
 
       def record_use_of_self
         parent.record_use_of_self

data/lib/reek/context_builder.rb

@@ -19,7 +19,7 @@ module Reek
   # counting. Ideally `ContextBuilder` would only build up the context tree and leave the
   # statement and reference counting to the contexts.
   #
-  # :reek:TooManyMethods: { max_methods: 30 }
+  # :reek:TooManyMethods: { max_methods: 31 }
   # :reek:UnusedPrivateMethod: { exclude: [ !ruby/regexp /process_/ ] }
   class ContextBuilder
     attr_reader :context_tree
@@ -228,6 +228,31 @@ module Reek
       current_context.record_use_of_self
     end
 
+    # Handles `super` nodes a.k.a. calls to `super` with arguments
+    #
+    # An input example that would trigger this method would be:
+    #
+    #   def call_me; super(); end
+    #
+    # or
+    #
+    #   def call_me; super(bar); end
+    #
+    # but not
+    #
+    #   def call_me; super; end
+    #
+    # and not
+    #
+    #   def call_me; super do end; end
+    #
+    # We record one reference to `self`.
+    #
+    def process_super(exp)
+      current_context.record_use_of_self
+      process(exp)
+    end
+
     # Handles `block` nodes.
     #
     # An input example that would trigger this method would be: