reek 1.3.1 → 1.3.2

data/spec/reek/smells/uncommunicative_method_name_spec.rb

@@ -1,8 +1,8 @@
-require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'smells', 'uncommunicative_method_name')
-require File.join(File.dirname(File.expand_path(__FILE__)), 'smell_detector_shared')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'core', 'code_parser')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'core', 'sniffer')
+require 'spec_helper'
+require 'reek/smells/uncommunicative_method_name'
+require 'reek/smells/smell_detector_shared'
+require 'reek/core/code_parser'
+require 'reek/core/sniffer'
 
 include Reek
 include Reek::Smells

data/spec/reek/smells/uncommunicative_module_name_spec.rb

@@ -1,8 +1,8 @@
-require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'smells', 'uncommunicative_module_name')
-require File.join(File.dirname(File.expand_path(__FILE__)), 'smell_detector_shared')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'core', 'code_parser')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'core', 'sniffer')
+require 'spec_helper'
+require 'reek/smells/uncommunicative_module_name'
+require 'reek/smells/smell_detector_shared'
+require 'reek/core/code_parser'
+require 'reek/core/sniffer'
 
 include Reek
 include Reek::Smells

data/spec/reek/smells/uncommunicative_parameter_name_spec.rb

@@ -1,7 +1,7 @@
-require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'smells', 'uncommunicative_parameter_name')
-require File.join(File.dirname(File.expand_path(__FILE__)), 'smell_detector_shared')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'core', 'method_context')
+require 'spec_helper'
+require 'reek/smells/uncommunicative_parameter_name'
+require 'reek/smells/smell_detector_shared'
+require 'reek/core/method_context'
 
 include Reek::Core
 include Reek::Smells

data/spec/reek/smells/uncommunicative_variable_name_spec.rb

@@ -1,8 +1,8 @@
-require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'smells', 'uncommunicative_variable_name')
-require File.join(File.dirname(File.expand_path(__FILE__)), 'smell_detector_shared')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'core', 'code_parser')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'core', 'sniffer')
+require 'spec_helper'
+require 'reek/smells/uncommunicative_variable_name'
+require 'reek/smells/smell_detector_shared'
+require 'reek/core/code_parser'
+require 'reek/core/sniffer'
 
 include Reek
 include Reek::Smells

data/spec/reek/smells/unused_parameters_spec.rb

@@ -1,7 +1,6 @@
-
-require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'smells', 'unused_parameters')
-require File.join(File.dirname(File.expand_path(__FILE__)), 'smell_detector_shared')
+require 'spec_helper'
+require 'reek/smells/unused_parameters'
+require 'reek/smells/smell_detector_shared'
 
 include Reek
 include Reek::Smells
@@ -39,9 +38,25 @@ describe UnusedParameters do
       'def simple(_); end'.should_not smell_of(UnusedParameters)
     end
 
+    it 'should report nothing for named parameters prefixed with _' do
+      'def simple(_name); end'.should_not smell_of(UnusedParameters)
+    end
+
     it 'should report nothing for unused anonymous splatted parameter' do
       'def simple(*); end'.should_not smell_of(UnusedParameters)
     end
 
+    it 'should report nothing when using super with implicit arguments' do
+      'def simple(*args); super; end'.should_not smell_of(UnusedParameters)
+    end
+
+    it 'should report something when using super explicitely passing no arguments' do
+      'def simple(*args); super(); end'.should smell_of(UnusedParameters)
+    end
+
+    it 'should report nothing when using super explicitely passing all arguments' do
+      'def simple(*args); super(*args); end'.should_not smell_of(UnusedParameters)
+    end
+
   end
 end

data/spec/reek/smells/utility_function_spec.rb

@@ -1,6 +1,6 @@
-require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'smells', 'utility_function')
-require File.join(File.dirname(File.expand_path(__FILE__)), 'smell_detector_shared')
+require 'spec_helper'
+require 'reek/smells/utility_function'
+require 'reek/smells/smell_detector_shared'
 
 include Reek
 include Reek::Smells

data/spec/reek/source/code_comment_spec.rb

@@ -1,5 +1,5 @@
-require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'source', 'code_comment')
+require 'spec_helper'
+require 'reek/source/code_comment'
 
 include Reek::Source
 

data/spec/reek/source/object_source_spec.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
+require 'spec_helper'
 
 include Reek
 

data/spec/reek/source/reference_collector_spec.rb

@@ -1,5 +1,5 @@
-require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'source', 'reference_collector')
+require 'spec_helper'
+require 'reek/source/reference_collector'
 
 include Reek::Source
 

data/spec/reek/source/sexp_formatter_spec.rb

@@ -1,5 +1,5 @@
-require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'source', 'sexp_formatter')
+require 'spec_helper'
+require 'reek/source/sexp_formatter'
 
 include Reek::Source
 

data/spec/reek/source/source_code_spec.rb

@@ -1,6 +1,6 @@
-require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
+require 'spec_helper'
 require 'stringio'
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'source', 'source_code')
+require 'reek/source/source_code'
 
 include Reek::Source
 

data/spec/reek/source/tree_dresser_spec.rb

@@ -1,5 +1,5 @@
-require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'source', 'tree_dresser')
+require 'spec_helper'
+require 'reek/source/tree_dresser'
 
 include Reek::Source
 

data/spec/reek/spec/should_reek_of_spec.rb

@@ -1,5 +1,5 @@
-require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'spec')
+require 'spec_helper'
+require 'reek/spec'
 
 include Reek
 include Reek::Spec

data/spec/reek/spec/should_reek_only_of_spec.rb

@@ -1,5 +1,5 @@
-require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'spec')
+require 'spec_helper'
+require 'reek/spec'
 
 include Reek
 include Reek::Spec

data/spec/reek/spec/should_reek_spec.rb

@@ -1,5 +1,5 @@
-require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'spec')
+require 'spec_helper'
+require 'reek/spec'
 
 include Reek
 include Reek::Spec

data/spec/samples/all_but_one_masked/masked.reek

@@ -1,5 +1,5 @@
 ---
-Duplication:
+DuplicateMethodCall:
   enabled: false
 UncommunicativeVariableName:
   enabled: false

data/spec/samples/clean_due_to_masking/masked.reek

@@ -1,5 +1,5 @@
 ---
-Duplication:
+DuplicateMethodCall:
   enabled: false
 IrresponsibleModule:
   enabled: false

data/spec/samples/config/allow_duplication.reek

@@ -1,3 +1,3 @@
 ---
-Duplication:
-  enabled: false
+DuplicateMethodCall:
+  enabled: false

data/spec/samples/inline_config/dirty.rb

@@ -1,4 +1,4 @@
-# :reek:Duplication: { allow_calls: [ puts ] }
+# :reek:DuplicateMethodCall: { allow_calls: [ puts ] }
 # smells of :reek:NestedIterators but ignores them
 class Dirty
   def a
@@ -7,7 +7,7 @@ class Dirty
     puts @s.title
   end
 
-  # :reek:Duplication: { max_calls: 2 }
+  # :reek:DuplicateMethodCall: { max_calls: 2 }
   def b
     puts @s.title
     @s = fred.map {|x| x.each {|key| key += 3}}

data/spec/samples/mask_some/some.reek

@@ -1,5 +1,5 @@
 ---
-Duplication:
+DuplicateMethodCall:
   allow_calls:
     - puts\(@s.title\)
 UncommunicativeVariableName:

data/spec/samples/masked_by_dotfile/dirty.rb

@@ -0,0 +1,8 @@
+# smelly class for testing purposes
+class Dirty
+  def a
+    puts @s.title
+    @s.map {|x| x.each {|key| key += 3}}
+    puts @s.title
+  end
+end

data/spec/samples/not_quite_masked/smelly.rb

@@ -0,0 +1,3 @@
+def f(x)
+  12.nil?
+end

data/spec/samples/overrides/masked/lower.reek

@@ -1,5 +1,5 @@
 ---
-Duplication:
+DuplicateMethodCall:
   enabled: true
 UncommunicativeVariableName:
   enabled: false

data/spec/samples/overrides/upper.reek

@@ -1,5 +1,5 @@
 ---
-Duplication:
+DuplicateMethodCall:
   enabled: false
 NestedIterators:
   enabled: false

data/spec/spec_helper.rb

@@ -1,14 +1,9 @@
-require 'rubygems'
-require 'bundler'
-Bundler.require :development, :default # Explicitly necessary here.
+require 'reek/spec'
+require 'reek/source/tree_dresser'
 
-# TODO Clean me up big time please?
-require File.join((File.dirname(File.dirname(File.expand_path(__FILE__)))), 'lib', 'reek', 'spec')
-require File.join((File.dirname(File.dirname(File.expand_path(__FILE__)))), 'lib', 'reek', 'source', 'tree_dresser')
+require 'matchers/smell_of_matcher'
 
-require File.join(File.dirname(File.expand_path(__FILE__)), 'matchers', 'smell_of_matcher')
-
-SAMPLES_DIR = 'spec/samples' unless Object.const_defined?('SAMPLES_DIR')
+SAMPLES_DIR = 'spec/samples'
 
 def ast(*args)
   result = Reek::Source::TreeDresser.new.dress(s(*args))

data/tasks/test.rake

@@ -9,7 +9,6 @@ namespace 'test' do
 
   RSpec::Core::RakeTask.new('spec') do |t|
     t.pattern = UNIT_TESTS
-    t.rspec_opts = ['--color']
     t.ruby_opts = ['-Ilib']
     t.rcov = false
   end
@@ -23,7 +22,6 @@ namespace 'test' do
   desc 'Tests code quality'
   RSpec::Core::RakeTask.new('quality') do |t|
     t.pattern = FileList['quality/**/*_spec.rb']
-    t.rspec_opts = ['--color']
     t.ruby_opts = ['-Ilib']
     t.rcov = false
   end

metadata

@@ -1,156 +1,155 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: reek
-version: !ruby/object:Gem::Version 
-  hash: 25
-  prerelease: 
-  segments: 
-  - 1
-  - 3
-  - 1
-  version: 1.3.1
+version: !ruby/object:Gem::Version
+  version: 1.3.2
 platform: ruby
-authors: 
+authors:
 - Kevin Rutherford
 - Timo Roessner
 - Matijs van Zuijlen
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2013-02-02 00:00:00 Z
-dependencies: 
-- !ruby/object:Gem::Dependency 
-  prerelease: false
+date: 2013-08-09 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
   name: ruby_parser
-  version_requirements: &id001 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
-        hash: 1
-        segments: 
-        - 3
-        - 1
-        - 1
+      - !ruby/object:Gem::Version
         version: 3.1.1
-  requirement: *id001
   type: :runtime
-- !ruby/object:Gem::Dependency 
   prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 3.1.1
+- !ruby/object:Gem::Dependency
   name: sexp_processor
-  version_requirements: &id002 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
-  requirement: *id002
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :runtime
-- !ruby/object:Gem::Dependency 
   prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
   name: ruby2ruby
-  version_requirements: &id003 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
-        hash: 11
-        segments: 
-        - 2
-        - 0
-        - 2
+      - !ruby/object:Gem::Version
         version: 2.0.2
-  requirement: *id003
   type: :runtime
-- !ruby/object:Gem::Dependency 
   prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 2.0.2
+- !ruby/object:Gem::Dependency
   name: bundler
-  version_requirements: &id004 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
-        hash: 13
-        segments: 
-        - 1
-        - 1
-        version: "1.1"
-  requirement: *id004
+      - !ruby/object:Gem::Version
+        version: '1.1'
   type: :development
-- !ruby/object:Gem::Dependency 
   prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.1'
+- !ruby/object:Gem::Dependency
   name: rake
-  version_requirements: &id005 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
-  requirement: *id005
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-- !ruby/object:Gem::Dependency 
   prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
   name: cucumber
-  version_requirements: &id006 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
-  requirement: *id006
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-- !ruby/object:Gem::Dependency 
   prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
   name: rspec
-  version_requirements: &id007 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '2.12'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
     - - ~>
-      - !ruby/object:Gem::Version 
-        hash: 27
-        segments: 
-        - 2
-        - 12
-        version: "2.12"
-  requirement: *id007
+      - !ruby/object:Gem::Version
+        version: '2.12'
+- !ruby/object:Gem::Dependency
+  name: flay
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-- !ruby/object:Gem::Dependency 
   prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
   name: yard
-  version_requirements: &id008 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
-  requirement: *id008
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: |
   Reek is a tool that examines Ruby classes, modules and methods
   and reports any code smells it finds.
-
-email: 
+email:
 - timo.roessner@googlemail.com
-executables: 
+executables:
 - reek
 extensions: []
-
-extra_rdoc_files: 
+extra_rdoc_files:
 - CHANGELOG
 - License.txt
-files: 
+files:
 - .yardopts
 - CHANGELOG
 - License.txt
@@ -158,213 +157,204 @@ files:
 - Rakefile
 - bin/reek
 - config/defaults.reek
-- features/ruby_api/api.feature
-- features/command_line_interface/stdin.feature
-- features/command_line_interface/options.feature
-- features/step_definitions/reek_steps.rb
 - features/support/env.rb
+- features/configuration_files/masking_smells.feature
 - features/samples.feature
-- features/reports/reports.feature
 - features/reports/yaml.feature
-- features/configuration_files/masking_smells.feature
+- features/reports/reports.feature
+- features/command_line_interface/options.feature
+- features/command_line_interface/stdin.feature
+- features/step_definitions/reek_steps.rb
 - features/rake_task/rake_task.feature
-- lib/xp.reek
-- lib/reek.rb
-- lib/reek/spec.rb
+- features/ruby_api/api.feature
 - lib/reek/spec/should_reek_of.rb
 - lib/reek/spec/should_reek_only_of.rb
 - lib/reek/spec/should_reek.rb
+- lib/reek/source/source_code.rb
+- lib/reek/source/code_comment.rb
+- lib/reek/source/source_file.rb
+- lib/reek/source/config_file.rb
+- lib/reek/source/tree_dresser.rb
+- lib/reek/source/source_locator.rb
+- lib/reek/source/reference_collector.rb
+- lib/reek/source/sexp_formatter.rb
+- lib/reek/source/core_extras.rb
+- lib/reek/source/source_repository.rb
+- lib/reek/core/object_refs.rb
+- lib/reek/core/module_context.rb
+- lib/reek/core/smell_repository.rb
+- lib/reek/core/warning_collector.rb
+- lib/reek/core/method_context.rb
+- lib/reek/core/code_parser.rb
+- lib/reek/core/hash_extensions.rb
+- lib/reek/core/stop_context.rb
+- lib/reek/core/singleton_method_context.rb
+- lib/reek/core/code_context.rb
+- lib/reek/core/sniffer.rb
+- lib/reek/core/smell_configuration.rb
+- lib/reek/spec.rb
+- lib/reek/source.rb
+- lib/reek/examiner.rb
+- lib/reek/rake/task.rb
+- lib/reek/smells.rb
+- lib/reek/version.rb
 - lib/reek/cli/version_command.rb
 - lib/reek/cli/application.rb
-- lib/reek/cli/command_line.rb
-- lib/reek/cli/yaml_command.rb
-- lib/reek/cli/help_command.rb
 - lib/reek/cli/report.rb
 - lib/reek/cli/reek_command.rb
-- lib/reek/examiner.rb
-- lib/reek/rake/task.rb
-- lib/reek/smell_warning.rb
-- lib/reek/version.rb
-- lib/reek/smells/duplication.rb
-- lib/reek/smells/boolean_parameter.rb
-- lib/reek/smells/uncommunicative_parameter_name.rb
-- lib/reek/smells/unused_parameters.rb
-- lib/reek/smells/long_method.rb
-- lib/reek/smells/control_couple.rb
+- lib/reek/cli/yaml_command.rb
+- lib/reek/cli/command_line.rb
+- lib/reek/cli/help_command.rb
+- lib/reek/smells/irresponsible_module.rb
 - lib/reek/smells/long_yield_list.rb
-- lib/reek/smells/attribute.rb
-- lib/reek/smells/simulated_polymorphism.rb
+- lib/reek/smells/nested_iterators.rb
 - lib/reek/smells/uncommunicative_method_name.rb
-- lib/reek/smells/nil_check.rb
+- lib/reek/smells/boolean_parameter.rb
 - lib/reek/smells/class_variable.rb
-- lib/reek/smells/long_parameter_list.rb
-- lib/reek/smells/feature_envy.rb
-- lib/reek/smells/irresponsible_module.rb
+- lib/reek/smells/control_parameter.rb
 - lib/reek/smells/utility_function.rb
-- lib/reek/smells/data_clump.rb
-- lib/reek/smells/uncommunicative_variable_name.rb
+- lib/reek/smells/too_many_instance_variables.rb
+- lib/reek/smells/too_many_methods.rb
+- lib/reek/smells/long_parameter_list.rb
+- lib/reek/smells/nil_check.rb
+- lib/reek/smells/attribute.rb
 - lib/reek/smells/uncommunicative_module_name.rb
-- lib/reek/smells/nested_iterators.rb
+- lib/reek/smells/repeated_conditional.rb
+- lib/reek/smells/uncommunicative_parameter_name.rb
 - lib/reek/smells/smell_detector.rb
-- lib/reek/smells/large_class.rb
-- lib/reek/smells.rb
-- lib/reek/source/config_file.rb
-- lib/reek/source/source_code.rb
-- lib/reek/source/sexp_formatter.rb
-- lib/reek/source/source_repository.rb
-- lib/reek/source/reference_collector.rb
-- lib/reek/source/core_extras.rb
-- lib/reek/source/source_file.rb
-- lib/reek/source/code_comment.rb
-- lib/reek/source/source_locator.rb
-- lib/reek/source/tree_dresser.rb
-- lib/reek/source.rb
-- lib/reek/core/smell_configuration.rb
-- lib/reek/core/method_context.rb
-- lib/reek/core/code_parser.rb
-- lib/reek/core/module_context.rb
-- lib/reek/core/stop_context.rb
-- lib/reek/core/code_context.rb
-- lib/reek/core/sniffer.rb
-- lib/reek/core/hash_extensions.rb
-- lib/reek/core/smell_repository.rb
-- lib/reek/core/object_refs.rb
-- lib/reek/core/singleton_method_context.rb
-- lib/reek/core/warning_collector.rb
-- spec/matchers/smell_of_matcher.rb
-- spec/spec_helper.rb
-- spec/spec.opts
+- lib/reek/smells/feature_envy.rb
+- lib/reek/smells/too_many_statements.rb
+- lib/reek/smells/uncommunicative_variable_name.rb
+- lib/reek/smells/unused_parameters.rb
+- lib/reek/smells/duplicate_method_call.rb
+- lib/reek/smells/data_clump.rb
+- lib/reek/smell_warning.rb
+- lib/reek.rb
+- spec/gem/yard_spec.rb
+- spec/gem/updates_spec.rb
 - spec/reek/spec/should_reek_of_spec.rb
-- spec/reek/spec/should_reek_spec.rb
 - spec/reek/spec/should_reek_only_of_spec.rb
+- spec/reek/spec/should_reek_spec.rb
+- spec/reek/source/object_source_spec.rb
+- spec/reek/source/reference_collector_spec.rb
+- spec/reek/source/code_comment_spec.rb
+- spec/reek/source/source_code_spec.rb
+- spec/reek/source/sexp_formatter_spec.rb
+- spec/reek/source/tree_dresser_spec.rb
+- spec/reek/core/module_context_spec.rb
+- spec/reek/core/singleton_method_context_spec.rb
+- spec/reek/core/code_parser_spec.rb
+- spec/reek/core/code_context_spec.rb
+- spec/reek/core/warning_collector_spec.rb
+- spec/reek/core/object_refs_spec.rb
+- spec/reek/core/smell_configuration_spec.rb
+- spec/reek/core/stop_context_spec.rb
+- spec/reek/core/config_spec.rb
+- spec/reek/core/method_context_spec.rb
+- spec/reek/smell_warning_spec.rb
 - spec/reek/examiner_spec.rb
-- spec/reek/cli/help_command_spec.rb
-- spec/reek/cli/reek_command_spec.rb
 - spec/reek/cli/yaml_command_spec.rb
+- spec/reek/cli/reek_command_spec.rb
+- spec/reek/cli/help_command_spec.rb
 - spec/reek/cli/report_spec.rb
 - spec/reek/cli/version_command_spec.rb
-- spec/reek/smells/boolean_parameter_spec.rb
-- spec/reek/smells/long_method_spec.rb
-- spec/reek/smells/uncommunicative_method_name_spec.rb
-- spec/reek/smells/duplication_spec.rb
-- spec/reek/smells/uncommunicative_module_name_spec.rb
-- spec/reek/smells/class_variable_spec.rb
-- spec/reek/smells/long_yield_list_spec.rb
-- spec/reek/smells/control_couple_spec.rb
 - spec/reek/smells/unused_parameters_spec.rb
-- spec/reek/smells/uncommunicative_parameter_name_spec.rb
+- spec/reek/smells/irresponsible_module_spec.rb
+- spec/reek/smells/too_many_methods_spec.rb
+- spec/reek/smells/too_many_statements_spec.rb
+- spec/reek/smells/uncommunicative_module_name_spec.rb
+- spec/reek/smells/utility_function_spec.rb
 - spec/reek/smells/long_parameter_list_spec.rb
+- spec/reek/smells/control_parameter_spec.rb
+- spec/reek/smells/behaves_like_variable_detector.rb
+- spec/reek/smells/class_variable_spec.rb
 - spec/reek/smells/attribute_spec.rb
-- spec/reek/smells/simulated_polymorphism_spec.rb
+- spec/reek/smells/uncommunicative_variable_name_spec.rb
 - spec/reek/smells/data_clump_spec.rb
+- spec/reek/smells/uncommunicative_parameter_name_spec.rb
 - spec/reek/smells/feature_envy_spec.rb
 - spec/reek/smells/smell_detector_shared.rb
-- spec/reek/smells/utility_function_spec.rb
-- spec/reek/smells/nested_iterators_spec.rb
-- spec/reek/smells/behaves_like_variable_detector.rb
-- spec/reek/smells/large_class_spec.rb
 - spec/reek/smells/nil_check_spec.rb
-- spec/reek/smells/irresponsible_module_spec.rb
-- spec/reek/smells/uncommunicative_variable_name_spec.rb
-- spec/reek/smell_warning_spec.rb
-- spec/reek/source/reference_collector_spec.rb
-- spec/reek/source/tree_dresser_spec.rb
-- spec/reek/source/sexp_formatter_spec.rb
-- spec/reek/source/code_comment_spec.rb
-- spec/reek/source/object_source_spec.rb
-- spec/reek/source/source_code_spec.rb
-- spec/reek/core/object_refs_spec.rb
-- spec/reek/core/warning_collector_spec.rb
-- spec/reek/core/stop_context_spec.rb
-- spec/reek/core/config_spec.rb
-- spec/reek/core/code_parser_spec.rb
-- spec/reek/core/smell_configuration_spec.rb
-- spec/reek/core/module_context_spec.rb
-- spec/reek/core/method_context_spec.rb
-- spec/reek/core/code_context_spec.rb
-- spec/reek/core/singleton_method_context_spec.rb
-- spec/gem/updates_spec.rb
-- spec/gem/yard_spec.rb
-- spec/gem/manifest_spec.rb
-- spec/samples/three_clean_files/clean_one.rb
+- spec/reek/smells/repeated_conditional_spec.rb
+- spec/reek/smells/uncommunicative_method_name_spec.rb
+- spec/reek/smells/nested_iterators_spec.rb
+- spec/reek/smells/long_yield_list_spec.rb
+- spec/reek/smells/duplicate_method_call_spec.rb
+- spec/reek/smells/boolean_parameter_spec.rb
+- spec/reek/smells/too_many_instance_variables_spec.rb
+- spec/spec_helper.rb
+- spec/samples/inline_config/dirty.rb
+- spec/samples/inline_config/masked.reek
 - spec/samples/three_clean_files/clean_two.rb
 - spec/samples/three_clean_files/clean_three.rb
-- spec/samples/config/allow_duplication.reek
-- spec/samples/config/deeper_nested_iterators.reek
-- spec/samples/overrides/upper.reek
-- spec/samples/overrides/masked/dirty.rb
-- spec/samples/overrides/masked/lower.reek
+- spec/samples/three_clean_files/clean_one.rb
+- spec/samples/clean_due_to_masking/dirty_one.rb
+- spec/samples/clean_due_to_masking/masked.reek
+- spec/samples/clean_due_to_masking/clean_two.rb
+- spec/samples/clean_due_to_masking/dirty_two.rb
+- spec/samples/clean_due_to_masking/clean_three.rb
+- spec/samples/clean_due_to_masking/clean_one.rb
+- spec/samples/not_quite_masked/dirty.rb
+- spec/samples/not_quite_masked/masked.reek
+- spec/samples/not_quite_masked/smelly.rb
+- spec/samples/optparse.rb
+- spec/samples/all_but_one_masked/dirty.rb
+- spec/samples/all_but_one_masked/masked.reek
+- spec/samples/all_but_one_masked/clean_one.rb
 - spec/samples/demo/demo.rb
+- spec/samples/exceptions.reek
+- spec/samples/masked_by_dotfile/dirty.rb
+- spec/samples/inline.rb
 - spec/samples/redcloth.rb
-- spec/samples/inline_config/masked.reek
-- spec/samples/inline_config/dirty.rb
-- spec/samples/corrupt_config_file/corrupt.reek
+- spec/samples/overrides/masked/dirty.rb
+- spec/samples/overrides/masked/lower.reek
+- spec/samples/overrides/upper.reek
+- spec/samples/two_smelly_files/dirty_one.rb
+- spec/samples/two_smelly_files/dirty_two.rb
+- spec/samples/masked/dirty.rb
+- spec/samples/masked/masked.reek
+- spec/samples/config/deeper_nested_iterators.reek
+- spec/samples/config/allow_duplication.reek
 - spec/samples/corrupt_config_file/dirty.rb
+- spec/samples/corrupt_config_file/corrupt.reek
 - spec/samples/empty_config_file/dirty.rb
 - spec/samples/empty_config_file/empty.reek
-- spec/samples/masked/masked.reek
-- spec/samples/masked/dirty.rb
-- spec/samples/all_but_one_masked/masked.reek
-- spec/samples/all_but_one_masked/clean_one.rb
-- spec/samples/all_but_one_masked/dirty.rb
-- spec/samples/inline.rb
-- spec/samples/mask_some/dirty.rb
-- spec/samples/mask_some/some.reek
-- spec/samples/not_quite_masked/masked.reek
-- spec/samples/not_quite_masked/dirty.rb
-- spec/samples/exceptions.reek
-- spec/samples/mixed_results/dirty_two.rb
 - spec/samples/mixed_results/dirty_one.rb
-- spec/samples/mixed_results/clean_one.rb
 - spec/samples/mixed_results/clean_two.rb
+- spec/samples/mixed_results/dirty_two.rb
 - spec/samples/mixed_results/clean_three.rb
-- spec/samples/clean_due_to_masking/dirty_two.rb
-- spec/samples/clean_due_to_masking/masked.reek
-- spec/samples/clean_due_to_masking/dirty_one.rb
-- spec/samples/clean_due_to_masking/clean_one.rb
-- spec/samples/clean_due_to_masking/clean_two.rb
-- spec/samples/clean_due_to_masking/clean_three.rb
-- spec/samples/optparse.rb
-- spec/samples/two_smelly_files/dirty_two.rb
-- spec/samples/two_smelly_files/dirty_one.rb
+- spec/samples/mixed_results/clean_one.rb
+- spec/samples/mask_some/dirty.rb
+- spec/samples/mask_some/some.reek
+- spec/matchers/smell_of_matcher.rb
 - tasks/test.rake
-- tasks/reek.rake
 - tasks/develop.rake
+- tasks/reek.rake
 - reek.gemspec
 homepage: http://wiki.github.com/troessner/reek
 licenses: []
-
+metadata: {}
 post_install_message: Thank you for downloading Reek. For info see the reek wiki http://wiki.github.com/troessner/reek
-rdoc_options: 
+rdoc_options:
 - --main
 - README.md
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
-  none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
-  none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - '>='
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: reek
-rubygems_version: 1.8.24
+rubygems_version: 2.0.6
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Code smell detector for Ruby
 test_files: []
-
 has_rdoc: