reek 1.3.1 → 1.3.2

data/spec/reek/cli/help_command_spec.rb

@@ -1,5 +1,5 @@
-require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'cli', 'help_command')
+require 'spec_helper'
+require 'reek/cli/help_command'
 
 include Reek::Cli
 

data/spec/reek/cli/reek_command_spec.rb

@@ -1,7 +1,7 @@
-require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'cli', 'reek_command')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'cli', 'report')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'examiner')
+require 'spec_helper'
+require 'reek/cli/reek_command'
+require 'reek/cli/report'
+require 'reek/examiner'
 
 include Reek
 include Reek::Cli
@@ -14,7 +14,7 @@ describe ReekCommand do
   context 'with smells' do
     before :each do
       examiner = Examiner.new('def x(); end')
-      @cmd = ReekCommand.new(QuietReport, ['def x(); end'])
+      @cmd = ReekCommand.new(QuietReport.new, ['def x(); end'])
     end
 
     it 'displays the correct text on the view' do
@@ -30,7 +30,7 @@ describe ReekCommand do
 
   context 'with no smells' do
     before :each do
-      @cmd = ReekCommand.new(QuietReport, ['def clean(); end'])
+      @cmd = ReekCommand.new(QuietReport.new, ['def clean(); end'])
     end
 
     it 'displays nothing on the view' do

data/spec/reek/cli/report_spec.rb

@@ -1,6 +1,6 @@
-require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'examiner')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'cli', 'report')
+require 'spec_helper'
+require 'reek/examiner'
+require 'reek/cli/report'
 
 include Reek
 include Reek::Cli
@@ -9,15 +9,15 @@ describe QuietReport, " when empty" do
   context 'empty source' do
     it 'has an empty quiet_report' do
       examiner = Examiner.new('')
-      QuietReport.new(examiner).report.should == ''
+      QuietReport.new.report(examiner).should == ''
     end
   end
 
   context 'with a couple of smells' do
     before :each do
       examiner = Examiner.new('def simple(a) a[3] end')
-      rpt = QuietReport.new(examiner)
-      @lines = rpt.report.split("\n")
+      rpt = QuietReport.new
+      @lines = rpt.report(examiner).split("\n")
     end
     it 'has a header and a list of smells' do
       @lines.should have_at_least(3).lines

data/spec/reek/cli/version_command_spec.rb

@@ -1,5 +1,5 @@
-require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'cli', 'version_command')
+require 'spec_helper'
+require 'reek/cli/version_command'
 
 include Reek
 include Reek::Cli

data/spec/reek/cli/yaml_command_spec.rb

@@ -1,5 +1,5 @@
-require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'cli', 'yaml_command')
+require 'spec_helper'
+require 'reek/cli/yaml_command'
 
 include Reek
 include Reek::Cli

data/spec/reek/core/code_context_spec.rb

@@ -1,7 +1,7 @@
-require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'core', 'method_context')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'core', 'module_context')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'core', 'stop_context')
+require 'spec_helper'
+require 'reek/core/method_context'
+require 'reek/core/module_context'
+require 'reek/core/stop_context'
 
 include Reek::Core
 

data/spec/reek/core/code_parser_spec.rb

@@ -1,5 +1,5 @@
-require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'core', 'code_parser')
+require 'spec_helper'
+require 'reek/core/code_parser'
 
 include Reek::Core
 

data/spec/reek/core/config_spec.rb

@@ -1,5 +1,5 @@
-require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'core', 'sniffer')
+require 'spec_helper'
+require 'reek/core/sniffer'
 
 describe Hash do
   before :each do
@@ -17,12 +17,12 @@ describe Hash do
     @first['two']['four'].should == false
     @first['one'].keys.length.should == 3
   end
-  
+
   it 'should deep copy Hashes' do
     second = @first.deep_copy
     second['two'].object_id.should_not be_eql(@first['two'].object_id)
   end
-  
+
   it 'should merge array values' do
     @first['three'] = [1,2,3]
   end

data/spec/reek/core/method_context_spec.rb

@@ -1,6 +1,6 @@
-require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'core', 'method_context')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'core', 'stop_context')
+require 'spec_helper'
+require 'reek/core/method_context'
+require 'reek/core/stop_context'
 
 include Reek::Core
 

data/spec/reek/core/module_context_spec.rb

@@ -1,6 +1,6 @@
-require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'core', 'module_context')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'core', 'stop_context')
+require 'spec_helper'
+require 'reek/core/module_context'
+require 'reek/core/stop_context'
 
 include Reek::Core
 

data/spec/reek/core/object_refs_spec.rb

@@ -1,5 +1,5 @@
-require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'core', 'object_refs')
+require 'spec_helper'
+require 'reek/core/object_refs'
 
 include Reek::Core
 
@@ -33,7 +33,7 @@ describe ObjectRefs do
       it 'should not report self as the max' do
         @refs.self_is_max?.should == false
       end
-      
+
       context "with one reference to self" do
         before(:each) do
           @refs.record_reference_to(:self)

data/spec/reek/core/singleton_method_context_spec.rb

@@ -1,7 +1,7 @@
-require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'core', 'module_context')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'core', 'singleton_method_context')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'core', 'stop_context')
+require 'spec_helper'
+require 'reek/core/module_context'
+require 'reek/core/singleton_method_context'
+require 'reek/core/stop_context'
 
 include Reek::Core
 

data/spec/reek/core/smell_configuration_spec.rb

@@ -1,5 +1,5 @@
-require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'core', 'smell_configuration')
+require 'spec_helper'
+require 'reek/core/smell_configuration'
 
 include Reek::Core
 

data/spec/reek/core/stop_context_spec.rb

@@ -1,5 +1,5 @@
-require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'core', 'stop_context')
+require 'spec_helper'
+require 'reek/core/stop_context'
 
 include Reek
 include Reek::Core

data/spec/reek/core/warning_collector_spec.rb

@@ -1,6 +1,6 @@
-require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'core', 'warning_collector')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'smell_warning')
+require 'spec_helper'
+require 'reek/core/warning_collector'
+require 'reek/smell_warning'
 
 include Reek::Core
 

data/spec/reek/examiner_spec.rb

@@ -1,5 +1,5 @@
-require File.join(File.dirname(File.dirname(File.expand_path(__FILE__))), 'spec_helper')
-require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'lib', 'reek', 'examiner')
+require 'spec_helper'
+require 'reek/examiner'
 
 include Reek
 
@@ -65,7 +65,7 @@ describe Examiner do
     it_should_behave_like 'one smell found'
   end
 
-  context 'with a smelly Dir' do
+  context 'with a partially masked smelly Dir' do
     before :each do
       smelly_dir = Dir['spec/samples/all_but_one_masked/*.rb']
       @examiner = Examiner.new(smelly_dir)
@@ -83,7 +83,16 @@ describe Examiner do
     it_should_behave_like 'no smells found'
   end
 
-  context 'with a smelly File' do
+  context 'with a smelly Dir masked by a dotfile' do
+    before :each do
+      smelly_dir = Dir['spec/samples/masked_by_dotfile/*.rb']
+      @examiner = Examiner.new(smelly_dir)
+    end
+
+    it_should_behave_like 'one smell found'
+  end
+
+  context 'with a partially masked smelly File' do
     before :each do
       smelly_file = File.new(Dir['spec/samples/all_but_one_masked/d*.rb'][0])
       @examiner = Examiner.new(smelly_file)

data/spec/reek/smell_warning_spec.rb

@@ -1,5 +1,5 @@
-require File.join(File.dirname(File.dirname(File.expand_path(__FILE__))), 'spec_helper')
-require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'lib', 'reek', 'smell_warning')
+require 'spec_helper'
+require 'reek/smell_warning'
 
 include Reek
 

data/spec/reek/smells/attribute_spec.rb

@@ -1,7 +1,7 @@
-require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'smells', 'attribute')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'core', 'module_context')
-require File.join(File.dirname(File.expand_path(__FILE__)), 'smell_detector_shared')
+require 'spec_helper'
+require 'reek/smells/attribute'
+require 'reek/core/module_context'
+require 'reek/smells/smell_detector_shared'
 
 include Reek::Core
 include Reek::Smells

data/spec/reek/smells/boolean_parameter_spec.rb

@@ -1,6 +1,6 @@
-require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'smells', 'boolean_parameter')
-require File.join(File.dirname(File.expand_path(__FILE__)), 'smell_detector_shared')
+require 'spec_helper'
+require 'reek/smells/boolean_parameter'
+require 'reek/smells/smell_detector_shared'
 
 include Reek::Smells
 

data/spec/reek/smells/class_variable_spec.rb

@@ -1,7 +1,7 @@
-require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'smells', 'class_variable')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'core', 'module_context')
-require File.join(File.dirname(File.expand_path(__FILE__)), 'smell_detector_shared')
+require 'spec_helper'
+require 'reek/smells/class_variable'
+require 'reek/core/module_context'
+require 'reek/smells/smell_detector_shared'
 
 include Reek::Core
 include Reek::Smells

data/spec/reek/smells/{control_couple_spec.rb → control_parameter_spec.rb}

@@ -1,13 +1,13 @@
-require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'smells', 'control_couple')
-require File.join(File.dirname(File.expand_path(__FILE__)), 'smell_detector_shared')
+require 'spec_helper'
+require 'reek/smells/control_parameter'
+require 'reek/smells/smell_detector_shared'
 
 include Reek::Smells
 
-describe ControlCouple do
+describe ControlParameter do
   before(:each) do
     @source_name = 'lets get married'
-    @detector = ControlCouple.new(@source_name)
+    @detector = ControlParameter.new(@source_name)
   end
 
   it_should_behave_like 'SmellDetector'
@@ -15,19 +15,19 @@ describe ControlCouple do
   context 'conditional on a parameter' do
     it 'should report a ternary check on a parameter' do
       src = 'def simple(arga) arga ? @ivar : 3 end'
-      src.should smell_of(ControlCouple, ControlCouple::PARAMETER_KEY => 'arga')
+      src.should smell_of(ControlParameter, ControlParameter::PARAMETER_KEY => 'arga')
     end
     it 'should not report a ternary check on an ivar' do
       src = 'def simple(arga) @ivar ? arga : 3 end'
-      src.should_not smell_of(ControlCouple)
+      src.should_not smell_of(ControlParameter)
     end
     it 'should not report a ternary check on a lvar' do
       src = 'def simple(arga) lvar = 27; lvar ? arga : @ivar end'
-      src.should_not smell_of(ControlCouple)
+      src.should_not smell_of(ControlParameter)
     end
     it 'should spot a couple inside a block' do
       src = 'def blocks(arg) @text.map { |blk| arg ? blk : "#{blk}" } end'
-      src.should smell_of(ControlCouple, ControlCouple::PARAMETER_KEY => 'arg')
+      src.should smell_of(ControlParameter, ControlParameter::PARAMETER_KEY => 'arg')
     end
   end
 
@@ -50,7 +50,7 @@ EOS
     it_should_behave_like 'common fields set correctly'
 
     it 'has the correct fields' do
-      @warning.smell[ControlCouple::PARAMETER_KEY].should == 'arg'
+      @warning.smell[ControlParameter::PARAMETER_KEY].should == 'arg'
       @warning.lines.should == [3, 5]
     end
   end

data/spec/reek/smells/data_clump_spec.rb

@@ -1,6 +1,6 @@
-require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'smells', 'data_clump')
-require File.join(File.dirname(File.expand_path(__FILE__)), 'smell_detector_shared')
+require 'spec_helper'
+require 'reek/smells/data_clump'
+require 'reek/smells/smell_detector_shared'
 
 include Reek::Smells
 

data/spec/reek/smells/{duplication_spec.rb → duplicate_method_call_spec.rb}

@@ -1,18 +1,18 @@
-require File.join(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__)))), 'spec_helper')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'smells', 'duplication')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'core', 'code_parser')
-require File.join(File.dirname(File.dirname(File.dirname(File.dirname(File.expand_path(__FILE__))))), 'lib', 'reek', 'core', 'sniffer')
-require File.join(File.dirname(File.expand_path(__FILE__)), 'smell_detector_shared')
+require 'spec_helper'
+require 'reek/smells/duplicate_method_call'
+require 'reek/core/code_parser'
+require 'reek/core/sniffer'
+require 'reek/smells/smell_detector_shared'
 
 include Reek
 include Reek::Smells
 
-describe Duplication do
+describe DuplicateMethodCall do
 
   context 'when a smell is reported' do
     before :each do
       @source_name = 'copy-cat'
-      @detector = Duplication.new(@source_name)
+      @detector = DuplicateMethodCall.new(@source_name)
       src = <<EOS
 def double_thing(other)
   other[@thing]
@@ -30,7 +30,7 @@ EOS
     it_should_behave_like 'common fields set correctly'
 
     it 'reports the call' do
-      @warning.smell[Duplication::CALL_KEY].should == 'other[@thing]'
+      @warning.smell[DuplicateMethodCall::CALL_KEY].should == 'other[@thing]'
     end
     it 'reports the correct lines' do
       @warning.lines.should == [2,4]
@@ -40,31 +40,47 @@ EOS
   context "with repeated method calls" do
     it 'reports repeated call' do
       src = 'def double_thing() @other.thing + @other.thing end'
-      src.should smell_of(Duplication, Duplication::CALL_KEY => '@other.thing')
+      src.should smell_of(DuplicateMethodCall, DuplicateMethodCall::CALL_KEY => '@other.thing')
     end
     it 'reports repeated call to lvar' do
       src = 'def double_thing(other) other[@thing] + other[@thing] end'
-      src.should smell_of(Duplication, Duplication::CALL_KEY => 'other[@thing]')
+      src.should smell_of(DuplicateMethodCall, DuplicateMethodCall::CALL_KEY => 'other[@thing]')
     end
     it 'reports call parameters' do
       src = 'def double_thing() @other.thing(2,3) + @other.thing(2,3) end'
-      src.should smell_of(Duplication, Duplication::CALL_KEY => '@other.thing(2, 3)')
+      src.should smell_of(DuplicateMethodCall, DuplicateMethodCall::CALL_KEY => '@other.thing(2, 3)')
     end
     it 'should report nested calls' do
       src = 'def double_thing() @other.thing.foo + @other.thing.foo end'
-      src.should smell_of(Duplication, {Duplication::CALL_KEY => '@other.thing'},
-                                       {Duplication::CALL_KEY => '@other.thing.foo'})
+      src.should smell_of(DuplicateMethodCall, {DuplicateMethodCall::CALL_KEY => '@other.thing'},
+                                       {DuplicateMethodCall::CALL_KEY => '@other.thing.foo'})
     end
     it 'should ignore calls to new' do
       src = 'def double_thing() @other.new + @other.new end'
-      src.should_not smell_of(Duplication)
+      src.should_not smell_of(DuplicateMethodCall)
+    end
+  end
+
+  context "with repeated simple method calls" do
+    it 'reports no smell' do
+      src = <<-EOS
+        def foo
+          case bar
+          when :baz
+            :qux
+          else
+            bar
+          end
+        end
+      EOS
+      src.should_not smell_of(DuplicateMethodCall)
     end
   end
 
   context 'with repeated attribute assignment' do
     it 'reports repeated assignment' do
       src = 'def double_thing(thing) @other[thing] = true; @other[thing] = true; end'
-      src.should smell_of(Duplication, Duplication::CALL_KEY => '@other[thing] = true')
+      src.should smell_of(DuplicateMethodCall, DuplicateMethodCall::CALL_KEY => '@other[thing] = true')
     end
     it 'does not report multi-assignments' do
       src = <<EOS
@@ -73,54 +89,54 @@ def _parse ctxt
   error, ctxt.index = @err, @err_ind
 end
 EOS
-      src.should_not smell_of(Duplication)
+      src.should_not smell_of(DuplicateMethodCall)
     end
   end
 
   context "non-repeated method calls" do
     it 'should not report similar calls' do
       src = 'def equals(other) other.thing == self.thing end'
-      src.should_not smell_of(Duplication)
+      src.should_not smell_of(DuplicateMethodCall)
     end
     it 'should respect call parameters' do
       src = 'def double_thing() @other.thing(3) + @other.thing(2) end'
-      src.should_not smell_of(Duplication)
+      src.should_not smell_of(DuplicateMethodCall)
     end
   end
 
   context "allowing up to 3 calls" do
     before :each do
-      @config = {Duplication::MAX_ALLOWED_CALLS_KEY => 3}
+      @config = {DuplicateMethodCall::MAX_ALLOWED_CALLS_KEY => 3}
     end
     it 'does not report double calls' do
       src = 'def double_thing() @other.thing + @other.thing end'
-      src.should_not smell_of(Duplication).with_config(@config)
+      src.should_not smell_of(DuplicateMethodCall).with_config(@config)
     end
     it 'does not report triple calls' do
       src = 'def double_thing() @other.thing + @other.thing + @other.thing end'
-      src.should_not smell_of(Duplication).with_config(@config)
+      src.should_not smell_of(DuplicateMethodCall).with_config(@config)
     end
     it 'reports quadruple calls' do
       src = 'def double_thing() @other.thing + @other.thing + @other.thing + @other.thing end'
-      src.should smell_of(Duplication, {Duplication::CALL_KEY => '@other.thing', Duplication::OCCURRENCES_KEY => 4}).with_config(@config)
+      src.should smell_of(DuplicateMethodCall, {DuplicateMethodCall::CALL_KEY => '@other.thing', DuplicateMethodCall::OCCURRENCES_KEY => 4}).with_config(@config)
     end
   end
 
   context "allowing calls to some methods" do
     before :each do
-      @config = {Duplication::ALLOW_CALLS_KEY => ['@some.thing',/puts/]}
+      @config = {DuplicateMethodCall::ALLOW_CALLS_KEY => ['@some.thing',/puts/]}
     end
     it 'does not report calls to some methods' do
       src = 'def double_some_thing() @some.thing + @some.thing end'
-      src.should_not smell_of(Duplication).with_config(@config)
+      src.should_not smell_of(DuplicateMethodCall).with_config(@config)
     end
     it 'reports calls to other methods' do
       src = 'def double_other_thing() @other.thing + @other.thing end'
-      src.should smell_of(Duplication, {Duplication::CALL_KEY => '@other.thing'}).with_config(@config)
+      src.should smell_of(DuplicateMethodCall, {DuplicateMethodCall::CALL_KEY => '@other.thing'}).with_config(@config)
     end
     it 'does not report calls to methods specifed with a regular expression' do
       src = 'def double_puts() puts @other.thing; puts @other.thing end'
-      src.should smell_of(Duplication, {Duplication::CALL_KEY => '@other.thing'}).with_config(@config)
+      src.should smell_of(DuplicateMethodCall, {DuplicateMethodCall::CALL_KEY => '@other.thing'}).with_config(@config)
     end
   end
 end