reek 0.3.1 → 1.0.0

data/spec/reek/smells/utility_function_spec.rb

@@ -1,30 +1,15 @@
 require File.dirname(__FILE__) + '/../../spec_helper.rb'
 
-require 'reek/method_checker'
-require 'reek/report'
+require 'reek/smells/utility_function'
 
 include Reek
+include Reek::Smells
 
-describe MethodChecker, "(Utility Function)" do
+describe UtilityFunction do
 
   before(:each) do
     @rpt = Report.new
-    @cchk = MethodChecker.new(@rpt, 'Thing')
-  end
-
-  it 'should not report empty method' do
-    @cchk.check_source('def simple(arga) end')
-    @rpt.should be_empty
-  end
-
-  it 'should not report instance variable reference' do
-    @cchk.check_source('def simple(arga) @yellow end')
-    @rpt.should be_empty
-  end
-
-  it 'should not report vcall' do
-    @cchk.check_source('def simple(arga) y end')
-    @rpt.should be_empty
+    @cchk = CodeParser.new(@rpt, SmellConfig.new.smell_listeners)
   end
 
   it 'should not report attrset' do
@@ -35,36 +20,20 @@ describe MethodChecker, "(Utility Function)" do
     @rpt.should be_empty
   end
 
-  it 'should not report references to self' do
-    @cchk.check_source('def into; self; end')
-    @rpt.should be_empty
-  end
-  
-  it 'should count usages of self' do
-    @cchk.check_source('def <=>(other) Options[:sort_order].compare(self, other) end')
-    @rpt.should be_empty
+  it 'should count usages of self'do
+    'def <=>(other) Options[:sort_order].compare(self, other) end'.should_not reek
   end
-
   it 'should count self reference within a dstr' do
-    @cchk.check_source('def as(alias_name); "#{self} as #{alias_name}".to_sym; end')
-    @rpt.should be_empty
+    'def as(alias_name); "#{self} as #{alias_name}".to_sym; end'.should_not reek
   end
-
   it 'should count calls to self within a dstr' do
-    source = 'def to_sql; "\'#{self.gsub(/\'/, "\'\'")}\'"; end'
-    @cchk.check_source(source)
-    @rpt.should be_empty
+    'def to_sql; "\'#{self.gsub(/\'/, "\'\'")}\'"; end'.should_not reek
   end
-
   it 'should report simple parameter call' do
-    @cchk.check_source('def simple(arga) arga.to_s end')
-    @rpt.length.should == 1
-    @rpt[0].should == UtilityFunction.new(@cchk, 1)
+    'def simple(arga) arga.to_s end'.should reek_of(:UtilityFunction, /simple/)
   end
-
   it 'should report message chain' do
-    @cchk.check_source('def simple(arga) arga.b.c end')
-    @rpt.length.should == 1
+    'def simple(arga) arga.b.c end'.should reek_of(:UtilityFunction, /simple/)
   end
   
   it 'should not report overriding methods' do
@@ -74,7 +43,7 @@ describe MethodChecker, "(Utility Function)" do
     class Son < Father
       def thing(ff); ff; end
     end
-    ClassChecker.new(@rpt).check_object(Son)
+    @cchk.check_object(Son)
     @rpt.should be_empty
   end
 
@@ -89,7 +58,39 @@ class Cache
   end
 end
 EOS
-    @cchk.check_source(source)
-    @rpt.should be_empty
+    source.should_not reek
+  end
+  
+  it 'should recognise a deep call' do
+    src = <<EOS
+class Red
+  def deep(text)
+    text.each { |mod| atts = shelve(mod) }
+  end
+
+  def shelve(val)
+    @shelf << val
+  end
+end
+EOS
+    src.should_not reek
+  end
+end
+
+describe UtilityFunction, 'should only report a method containing a call' do
+  it 'should not report empty method' do
+    'def simple(arga) end'.should_not reek
+  end
+  it 'should not report literal' do
+    'def simple(arga) 3; end'.should_not reek
+  end
+  it 'should not report instance variable reference' do
+    'def simple(arga) @yellow end'.should_not reek
+  end
+  it 'should not report vcall' do
+    'def simple(arga) y end'.should_not reek
+  end
+  it 'should not report references to self' do
+    'def into; self; end'.should_not reek
   end
 end

data/spec/samples/inline_spec.rb

@@ -0,0 +1,40 @@
+require File.dirname(__FILE__) + '/../spec_helper.rb'
+
+describe 'sample gem source code' do
+  it "reports the correct smells in inline.rb" do
+    ruby = File.new('spec/samples/inline.rb').to_source
+    ruby.should reek_of(:ControlCouple, /Inline::C#parse_signature/, /raw/)
+    ruby.should reek_of(:ControlCouple, /Module#inline/, /options/)
+    ruby.should reek_of(:Duplication, /Inline::C#build/, /\$\?\.==\(0\)/)
+    ruby.should reek_of(:Duplication, /Inline::C#build/, /Inline.directory/)
+    ruby.should reek_of(:Duplication, /Inline::C#build/, /io.puts/)
+    ruby.should reek_of(:Duplication, /Inline::C#build/, /io.puts\(#endif\)/)
+    ruby.should reek_of(:Duplication, /Inline::C#build/, /io.puts\(#ifdef __cplusplus\)/)
+    ruby.should reek_of(:Duplication, /Inline::C#crap_for_windoze/, /Config::CONFIG\[libdir\]/)
+    ruby.should reek_of(:Duplication, /Inline::C#generate/, /result.sub!\(\(\?-mix:\\A\\n\), \)/)
+    ruby.should reek_of(:Duplication, /Inline::C#generate/, /signature\[args\]/)
+    ruby.should reek_of(:Duplication, /Inline::C#generate/, /signature\[args\].map/)
+    ruby.should reek_of(:Duplication, /Inline::C#initialize/, /stack.empty?/)
+    ruby.should reek_of(:Duplication, /Inline::self.rootdir/, /env.nil?/)
+    ruby.should reek_of(:Duplication, /Module#inline/, /Inline.const_get\(lang\)/)
+    ruby.should reek_of(:FeatureEnvy, /Inline::C#strip_comments/, /src/)
+    ruby.should reek_of(:LargeClass, /Inline::C/)
+    ruby.should reek_of(:LongMethod, /File#self.write_with_backup/)
+    ruby.should reek_of(:LongMethod, /Inline::C#build/)
+    ruby.should reek_of(:LongMethod, /Inline::C#generate/)
+    ruby.should reek_of(:LongMethod, /Inline::C#load_cache/)
+    ruby.should reek_of(:LongMethod, /Inline::C#module_name/)
+    ruby.should reek_of(:LongMethod, /Inline::C#parse_signature/)
+    ruby.should reek_of(:LongMethod, /Inline::self.rootdir/)
+    ruby.should reek_of(:LongMethod, /Module#inline/)
+    ruby.should reek_of(:NestedIterators, /Inline::C#build/)
+    ruby.should reek_of(:UncommunicativeName, /Inline::C#build/, /'t'/)
+    ruby.should reek_of(:UncommunicativeName, /Inline::C#build/, /'n'/)
+    ruby.should reek_of(:UncommunicativeName, /Inline::C#c/, /'c'/)
+    ruby.should reek_of(:UncommunicativeName, /Inline::C#module_name/, /'m'/)
+    ruby.should reek_of(:UncommunicativeName, /Inline::C#module_name/, /'x'/)
+    ruby.should reek_of(:UncommunicativeName, /Inline::C#parse_signature/, /'x'/)
+    ruby.should reek_of(:UtilityFunction, /Inline::C#strip_comments/)
+    ruby.report.should have_at_most(32).smells
+  end
+end

data/spec/samples/optparse_spec.rb

@@ -0,0 +1,100 @@
+require File.dirname(__FILE__) + '/../spec_helper.rb'
+
+describe 'sample gem source code' do
+  it "reports the correct smells in optparse.rb" do
+    ruby = File.new('spec/samples/optparse.rb').to_source
+    ruby.should reek_of(:ControlCouple, /OptionParser#List#accept/, /pat/)
+    ruby.should reek_of(:ControlCouple, /OptionParser#List#update/, /lopts/)
+    ruby.should reek_of(:ControlCouple, /OptionParser#List#update/, /sopts/)
+    ruby.should reek_of(:ControlCouple, /OptionParser#ParseError#set_option/, /eq/)
+    ruby.should reek_of(:ControlCouple, /OptionParser#Switch#NoArgument#parse/, /arg/)
+    ruby.should reek_of(:ControlCouple, /OptionParser#Switch#OptionalArgument#parse/, /arg/)
+    ruby.should reek_of(:ControlCouple, /OptionParser#Switch#RequiredArgument#parse/, /arg/)
+    ruby.should reek_of(:ControlCouple, /OptionParser#parse_in_order/, /setter/)
+    ruby.should reek_of(:Duplication, /OptionParser#Completion::complete/, /candidates.size/)
+    ruby.should reek_of(:Duplication, /OptionParser#Completion::complete/, /k.id2name/)
+    ruby.should reek_of(:Duplication, /OptionParser#Switch#parse_arg/, /s.length/)
+    ruby.should reek_of(:Duplication, /OptionParser#Switch#summarize/, /block.max/)
+    ruby.should reek_of(:Duplication, /OptionParser#Switch#summarize/, /block.max.to_i/)
+    ruby.should reek_of(:Duplication, /OptionParser#Switch#summarize/, /indent.+\(l\)/)
+    ruby.should reek_of(:Duplication, /OptionParser#Switch#summarize/, /left.collect/)
+    ruby.should reek_of(:Duplication, /OptionParser#Switch#summarize/, /left.shift/)
+    ruby.should reek_of(:Duplication, /OptionParser#Switch#summarize/, /left\[-1\]/)
+    ruby.should reek_of(:Duplication, /OptionParser#Switch#summarize/, /s.length/)
+    ruby.should reek_of(:Duplication, /OptionParser#make_switch/, /default_style.guess\(arg=a\)/)
+    ruby.should reek_of(:Duplication, /OptionParser#make_switch/, /long.<<\(o=q.downcase\)/)
+    ruby.should reek_of(:Duplication, /OptionParser#make_switch/, /pattern.method\(convert\)/)
+    ruby.should reek_of(:Duplication, /OptionParser#make_switch/, /pattern.method\(convert\).to_proc/)
+    ruby.should reek_of(:Duplication, /OptionParser#make_switch/, /pattern.respond_to\?\(convert\)/)
+    ruby.should reek_of(:Duplication, /OptionParser#make_switch/, /q.downcase/)
+    ruby.should reek_of(:Duplication, /OptionParser#make_switch/, /sdesc.<<\("-\#\{q\}"\)/)
+    ruby.should reek_of(:Duplication, /OptionParser#order/, /argv\[0\]/)
+    ruby.should reek_of(:Duplication, /OptionParser#parse/, /argv\[0\]/)
+    ruby.should reek_of(:Duplication, /OptionParser#parse_in_order/, /\$\!.set_option\(arg, true\)/)
+    ruby.should reek_of(:Duplication, /OptionParser#parse_in_order/, /cb.call\(val\)/)
+    ruby.should reek_of(:Duplication, /OptionParser#parse_in_order/, /setter.call\(sw.switch_name, val\)/)
+    ruby.should reek_of(:Duplication, /OptionParser#parse_in_order/, /sw.block/)
+    ruby.should reek_of(:Duplication, /OptionParser#parse_in_order/, /sw.switch_name/)
+    ruby.should reek_of(:Duplication, /OptionParser#permute/, /argv\[0\]/)
+    ruby.should reek_of(:FeatureEnvy, /OptionParser#Completion::complete/, /candidates/)
+    ruby.should reek_of(:FeatureEnvy, /OptionParser#List#accept/, /pat/)
+    ruby.should reek_of(:FeatureEnvy, /OptionParser#Switch#summarize/, /left/)
+    ruby.should reek_of(:FeatureEnvy, /OptionParser#order/, /argv/)
+    ruby.should reek_of(:FeatureEnvy, /OptionParser#parse/, /argv/)
+    ruby.should reek_of(:FeatureEnvy, /OptionParser#permute/, /argv/)
+    ruby.should reek_of(:LargeClass, /OptionParser/)
+    ruby.should reek_of(:LongMethod, /OptionParser#Completion::complete/)
+    ruby.should reek_of(:LongMethod, /OptionParser#List#update/)
+    ruby.should reek_of(:LongMethod, /OptionParser#Switch#PlacedArgument#parse/)
+    ruby.should reek_of(:LongMethod, /OptionParser#Switch#parse_arg/)
+    ruby.should reek_of(:LongMethod, /OptionParser#Switch#summarize/)
+    ruby.should reek_of(:LongMethod, /OptionParser#getopts/)
+    ruby.should reek_of(:LongMethod, /OptionParser#make_switch/)
+    ruby.should reek_of(:LongMethod, /OptionParser#parse_in_order/)
+    ruby.should reek_of(:LongParameterList, /OptionParser#List#complete/)
+    ruby.should reek_of(:LongParameterList, /OptionParser#List#update/)
+    ruby.should reek_of(:LongParameterList, /OptionParser#Switch#initialize/)
+    ruby.should reek_of(:LongParameterList, /OptionParser#Switch#summarize/)
+    ruby.should reek_of(:LongParameterList, /OptionParser#complete/)
+    ruby.should reek_of(:LongParameterList, /OptionParser#summarize/)
+    ruby.should reek_of(:NestedIterators, /OptionParser#CompletingHash#match/)
+    ruby.should reek_of(:NestedIterators, /OptionParser#Switch#summarize/)
+    ruby.should reek_of(:NestedIterators, /OptionParser#block/)
+    ruby.should reek_of(:NestedIterators, /OptionParser#complete/)
+    ruby.should reek_of(:NestedIterators, /OptionParser#make_switch/)
+    ruby.should reek_of(:NestedIterators, /OptionParser#make_switch/)
+    ruby.should reek_of(:NestedIterators, /OptionParser#parse_in_order/)
+    ruby.should reek_of(:NestedIterators, /OptionParser#parse_in_order/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#Completion::complete/, /'k'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#Completion::complete/, /'v'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#List#accept/, /'t'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#List#reject/, /'t'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#List#update/, /'o'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#Switch#add_banner/, /'s'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#Switch#parse_arg/, /'m'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#Switch#parse_arg/, /'s'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#Switch#self.guess/, /'t'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#Switch#self.incompatible_argument_styles/, /'t'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#Switch#summarize/, /'l'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#Switch#summarize/, /'r'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#Switch#summarize/, /'s'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#block/, /'f'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#block/, /'k'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#block/, /'o'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#block/, /'s'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#block/, /'v'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#load/, /'s'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#make_switch/, /'a'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#make_switch/, /'n'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#make_switch/, /'o'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#make_switch/, /'q'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#make_switch/, /'s'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#make_switch/, /'c'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#make_switch/, /'v'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#search/, /'k'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#summarize/, /'l'/)
+    ruby.should reek_of(:UncommunicativeName, /OptionParser#ver/, /'v'/)
+    ruby.should reek_of(:UncommunicativeName, /block/, /'q'/)
+    ruby.report.should have_at_most(92).smells
+  end
+end

data/spec/samples/redcloth_spec.rb

@@ -0,0 +1,93 @@
+require File.dirname(__FILE__) + '/../spec_helper.rb'
+
+describe 'sample gem source code' do
+  it "reports the correct smells in redcloth.rb" do
+    ruby = File.new('spec/samples/redcloth.rb').to_source
+    ruby.should reek_of(:ControlCouple, /RedCloth#blocks\/block/, /deep_code/)
+    ruby.should reek_of(:ControlCouple, /RedCloth#check_refs/, /text/)
+    ruby.should reek_of(:ControlCouple, /RedCloth#pba/, /text_in/)
+    ruby.should reek_of(:ControlCouple, /RedCloth#textile_bq/, /atts/)
+    ruby.should reek_of(:ControlCouple, /RedCloth#textile_bq/, /cite/)
+    ruby.should reek_of(:ControlCouple, /RedCloth#textile_fn_/, /atts/)
+    ruby.should reek_of(:ControlCouple, /RedCloth#textile_p/, /atts/)
+    ruby.should reek_of(:Duplication, /RedCloth#block_textile_lists/, /depth.last/)
+    ruby.should reek_of(:Duplication, /RedCloth#block_textile_lists/, /depth.last.length/)
+    ruby.should reek_of(:Duplication, /RedCloth#block_textile_lists/, /depth\[i\]/)
+    ruby.should reek_of(:Duplication, /RedCloth#block_textile_lists/, /line_id.-\(1\)/)
+    ruby.should reek_of(:Duplication, /RedCloth#block_textile_lists/, /lines\[line_id.-\(1\)\]/)
+    ruby.should reek_of(:Duplication, /RedCloth#block_textile_lists/, /tl.length/)
+    ruby.should reek_of(:Duplication, /RedCloth#clean_html/, /tags\[tag\]/)
+    ruby.should reek_of(:Duplication, /RedCloth#pba/, /\$1.length/)
+    ruby.should reek_of(:Duplication, /RedCloth#rip_offtags/, /@pre_list.last/)
+    ruby.should reek_of(:Duplication, /RedCloth#rip_offtags/, /@pre_list.last.<<\(line\)/)
+    ruby.should reek_of(:Duplication, /RedCloth#rip_offtags/, /codepre.-\(used_offtags.length\)/)
+    ruby.should reek_of(:Duplication, /RedCloth#rip_offtags/, /codepre.-\(used_offtags.length\).>\(0\)/)
+    ruby.should reek_of(:Duplication, /RedCloth#rip_offtags/, /codepre.zero?/)
+    ruby.should reek_of(:Duplication, /RedCloth#rip_offtags/, /used_offtags.length/)
+    ruby.should reek_of(:Duplication, /RedCloth#rip_offtags/, /used_offtags\[notextile\]/)
+    ruby.should reek_of(:FeatureEnvy, /RedCloth#clean_html/, /tags/)
+    ruby.should reek_of(:FeatureEnvy, /RedCloth#clean_white_space/, /text/)
+    ruby.should reek_of(:FeatureEnvy, /RedCloth#flush_left/, /indt/)
+    ruby.should reek_of(:FeatureEnvy, /RedCloth#flush_left/, /text/)
+    ruby.should reek_of(:FeatureEnvy, /RedCloth#htmlesc/, /str/)
+    ruby.should reek_of(:FeatureEnvy, /RedCloth#no_textile/, /text/)
+    ruby.should reek_of(:FeatureEnvy, /RedCloth#pba/, /style/)
+    ruby.should reek_of(:FeatureEnvy, /RedCloth#pba/, /text/)
+    ruby.should reek_of(:LargeClass, /RedCloth/)
+    ruby.should reek_of(:LongMethod, /RedCloth#block_markdown_bq/)
+    ruby.should reek_of(:LongMethod, /RedCloth#block_textile_lists/)
+    ruby.should reek_of(:LongMethod, /RedCloth#block_textile_table/)
+    ruby.should reek_of(:LongMethod, /RedCloth#blocks/)
+    ruby.should reek_of(:LongMethod, /RedCloth#clean_html/)
+    ruby.should reek_of(:LongMethod, /RedCloth#clean_white_space/)
+    ruby.should reek_of(:LongMethod, /RedCloth#glyphs_textile/)
+    ruby.should reek_of(:LongMethod, /RedCloth#inline_markdown_link/)
+    ruby.should reek_of(:LongMethod, /RedCloth#inline_markdown_reflink/)
+    ruby.should reek_of(:LongMethod, /RedCloth#inline_textile_image/)
+    ruby.should reek_of(:LongMethod, /RedCloth#inline_textile_link/)
+    ruby.should reek_of(:LongMethod, /RedCloth#inline_textile_span/)
+    ruby.should reek_of(:LongMethod, /RedCloth#pba/)
+    ruby.should reek_of(:LongMethod, /RedCloth#rip_offtags/)
+    ruby.should reek_of(:LongMethod, /RedCloth#to_html/)
+    ruby.should reek_of(:LongParameterList, /RedCloth#textile_bq/)
+    ruby.should reek_of(:LongParameterList, /RedCloth#textile_fn_/)
+    ruby.should reek_of(:LongParameterList, /RedCloth#textile_p/)
+    ruby.should reek_of(:NestedIterators, /RedCloth#block_textile_lists/)
+    ruby.should reek_of(:NestedIterators, /RedCloth#block_textile_lists/)
+    ruby.should reek_of(:NestedIterators, /RedCloth#block_textile_table/)
+    ruby.should reek_of(:NestedIterators, /RedCloth#block_textile_table/)
+    ruby.should reek_of(:NestedIterators, /RedCloth#blocks/)
+    ruby.should reek_of(:NestedIterators, /RedCloth#clean_html/)
+    ruby.should reek_of(:NestedIterators, /RedCloth#clean_html/)
+    ruby.should reek_of(:NestedIterators, /RedCloth#inline/)
+    ruby.should reek_of(:NestedIterators, /RedCloth#inline_textile_span/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#block/, /'a'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#block/, /'b'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#block_textile_lists/, /'i'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#block_textile_lists/, /'v'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#block_textile_table/, /'x'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#clean_html/, /'q'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#clean_html/, /'q2'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#initialize/, /'r'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#inline_markdown_link/, /'m'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#inline_markdown_reflink/, /'m'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#inline_textile_code/, /'m'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#inline_textile_image/, /'m'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#inline_textile_link/, /'m'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#inline_textile_span/, /'m'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#refs_markdown/, /'m'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#refs_textile/, /'m'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#retrieve/, /'i'/)
+    ruby.should reek_of(:UncommunicativeName, /RedCloth#retrieve/, /'r'/)
+    ruby.should reek_of(:UtilityFunction, /RedCloth#block_markdown_rule/)
+    ruby.should reek_of(:UtilityFunction, /RedCloth#clean_html/)
+    ruby.should reek_of(:UtilityFunction, /RedCloth#flush_left/)
+    ruby.should reek_of(:UtilityFunction, /RedCloth#footnote_ref/)
+    ruby.should reek_of(:UtilityFunction, /RedCloth#h_align/)
+    ruby.should reek_of(:UtilityFunction, /RedCloth#htmlesc/)
+    ruby.should reek_of(:UtilityFunction, /RedCloth#incoming_entities/)
+    ruby.should reek_of(:UtilityFunction, /RedCloth#no_textile/)
+    ruby.should reek_of(:UtilityFunction, /RedCloth#v_align/)
+    ruby.report.should have_at_most(85).smells
+  end
+end

data/spec/spec_helper.rb

@@ -1,3 +1,5 @@
+$:.unshift File.dirname(__FILE__) + '/../lib'
+
 begin
   require 'spec'
 rescue LoadError
@@ -6,4 +8,4 @@ rescue LoadError
   require 'spec'
 end
 
-$:.unshift File.dirname(__FILE__) + '/../lib'
+require 'reek/spec'

data/tasks/reek.rake

@@ -1,16 +1,7 @@
 require 'reek/rake_task'
-require 'flay'
 
 Reek::RakeTask.new do |t|
   t.fail_on_error = true
   t.verbose = false
-#  t.sort = 'smell'
-end
-
-desc 'Check for code duplication'
-task 'flay' do
-  files = FileList['lib/**/*.rb']
-  flayer = Flay.new(16)
-  flayer.process(*files)
-  flayer.report
+#  t.reek_opts = '-f "Smell: %s: %c %w"'
 end

data/tasks/rspec.rake

@@ -1,40 +1,21 @@
-require 'rake/clean'
+require 'spec'
+require 'spec/rake/spectask'
 
-begin
-  require 'spec'
-rescue LoadError
-  require 'rubygems'
-  require 'spec'
-end
-begin
-  require 'spec/rake/spectask'
-  require 'spec/rake/verify_rcov'
-rescue LoadError
-  puts <<-EOS
-To use rspec for testing you must install rspec gem:
-    gem install rspec
-EOS
-  exit(0)
-end
+namespace 'rspec' do
+  FAST = FileList['spec/reek/**/*_spec.rb']
+  SLOW = FileList['spec/integration/**/*_spec.rb', 'spec/samples/**/*_spec.rb']
 
-REPORT_DIR = 'spec/output/coverage'
-CLEAN.include(REPORT_DIR)
+  Spec::Rake::SpecTask.new('fast') do |t|
+    t.spec_files = FAST
+    t.ruby_opts = ['-Ilib']
+    t.rcov = false
+  end
 
-desc "runs the specs"
-Spec::Rake::SpecTask.new(:spec) do |t|
-  t.spec_files = FileList['spec/**/*_spec.rb']
+  Spec::Rake::SpecTask.new('all') do |t|
+    t.spec_files = FAST + SLOW
+    t.rcov = false
+  end
 end
 
-desc "runs the specs and reports coverage in #{REPORT_DIR}"
-Spec::Rake::SpecTask.new(:spec_rcov) do |t|
-  t.spec_files = FileList['spec/**/*_spec.rb']
-  t.rcov = true
-  t.rcov_dir = REPORT_DIR
-  t.rcov_opts = ['--exclude', 'spec,\.autotest']
-end
-
-desc "runs the specs and checks for 100% coverage"
-RCov::VerifyTask.new(:rcov => :spec_rcov) do |t|
-  t.index_html = "#{REPORT_DIR}/index.html"
-  t.threshold = 100
-end
+desc 'runs the unit tests'
+task 'spec' => 'rspec:fast'