reek 0.3.1 → 1.0.0

data/spec/integration_spec.rb

@@ -1,30 +0,0 @@
-require File.dirname(__FILE__) + '/spec_helper.rb'
-
-describe 'Integration test:' do
-  Dir['spec/samples/*.rb'].each do |source|
-    describe source do
-      before :each do
-        @expected = IO.readlines(source.sub(/\.rb/, '.reek'))
-        @expected.each {|line| line.chomp!}
-      end
-
-      it 'should report the correct smells' do
-        actual = `ruby -Ilib bin/reek #{source} 2>/dev/null`.split(/\n/)
-        @expected.zip(actual).each do |p|
-          actual_line = p[1] ? p[1].chomp : p[1]
-          actual_line.should == p[0]
-        end
-        actual.length.should == @expected.length
-      end
-
-      it 'should report the correct smells in smell order' do
-        actual = `ruby -Ilib bin/reek --sort smell #{source} 2>/dev/null`.split(/\n/)
-        @expected.sort.zip(actual).each do |p|
-          actual_line = p[1] ? p[1].chomp : p[1]
-          actual_line.should == p[0]
-        end
-        actual.length.should == @expected.length
-      end
-    end
-  end
-end

data/spec/reek/class_checker_spec.rb

@@ -1,48 +0,0 @@
-require File.dirname(__FILE__) + '/../spec_helper.rb'
-
-require 'reek/class_checker'
-
-include Reek
-
-describe ClassChecker do
-
-  before(:each) do
-    @rpt = []
-    @cchk = ClassChecker.new(@rpt)
-  end
-
-  it 'should report Long Parameter List' do
-    @cchk.check_source('class Inner; def simple(arga, argb, argc, argd) f(3);true end end')
-    @rpt.length.should == 1
-    @rpt[0].report.should match(/Inner#simple/)
-  end
-
-  it 'should report two different methods' do
-    src = <<EOEX
-class Fred
-  def simple(arga, argb, argc, argd) f(3);true end
-  def simply(arga, argb, argc, argd) f(3);false end
-end
-EOEX
-    @cchk.check_source(src)
-    @rpt.length.should == 2
-    @rpt[0].report.should match(/Fred#simple/)
-    @rpt[1].report.should match(/Fred#simply/)
-  end
-
-  it 'should report many different methods' do
-    src = <<EOEX
-class Fred
-    def textile_bq(tag, atts, cite, content) f(3);end
-    def textile_p(tag, atts, cite, content) f(3);end
-    def textile_fn_(tag, num, atts, cite, content) f(3);end
-    def textile_popup_help(name, windowW, windowH) f(3);end
-end
-EOEX
-    @cchk.check_source(src)
-    @rpt.length.should == 3
-    @rpt[0].report.should match(/Fred#textile_bq/)
-    @rpt[1].report.should match(/Fred#textile_p/)
-  end
-
-end

data/spec/reek/method_checker_spec.rb

@@ -1,67 +0,0 @@
-require File.dirname(__FILE__) + '/../spec_helper.rb'
-
-require 'reek/method_checker'
-require 'reek/report'
-
-include Reek
-
-describe MethodChecker, "with no method definitions" do  
-  before(:each) do
-    @rpt = Report.new
-    @cchk = MethodChecker.new(@rpt, 'Thing')
-  end
-
-  it 'should report no problems for empty source code' do
-    @cchk.check_source('')
-    @rpt.should be_empty
-  end
-
-  it 'should report no problems for empty class' do
-    @cchk.check_source('class Fred; end')
-    @rpt.should be_empty
-  end
-end
-
-describe MethodChecker, 'when given a C extension' do
-  before(:each) do
-    @cchk = MethodChecker.new(Report.new, 'Thing')
-  end
-
-  it 'should ignore :cfunc' do
-    @cchk.check_object(Enumerable)
-  end
-end
-
-describe MethodChecker, 'when a yield is the receiver' do
-  it 'should report no problems' do
-    source = 'def values(*args)
-  @to_sql += case
-    when block_given? then " #{yield.to_sql}"
-    else " values (#{args.to_sql})"
-  end
-  self
-end'
-    rpt = Report.new
-    chk = MethodChecker.new(rpt, 'Thing')
-    chk.check_source(source)
-    rpt.should be_empty
-  end
-end
-
-describe MethodChecker, '#is_override?' do
-  it 'should be false for non-override method' do
-    MethodChecker.is_override?('String', 'gsub').should == false
-  end
-
-  it 'should be true for overriding method' do
-    MethodChecker.is_override?('MethodChecker', 'to_s').should == true
-  end
-
-  it 'should be false for non-existent class' do
-    MethodChecker.is_override?('Flibble', 'to_s').should == false
-  end
-
-  it 'should be true for smells' do
-    MethodChecker.is_override?('UtilityFunction', 'recognise?').should == true
-  end
-end

data/spec/reek/printer_spec.rb

@@ -1,30 +0,0 @@
-require File.dirname(__FILE__) + '/../spec_helper.rb'
-
-require 'reek/checker'
-require 'reek/printer'
-
-include Reek
-
-def check(examples)
-  examples.each do |actual|
-    it "should format #{actual} correctly" do
-      sexp = Checker.parse_tree_for(actual)[0]
-      Printer.print(sexp).should == actual
-    end
-  end
-end
-
-describe Printer do
-  check 'Alpha'
-  check 'Alpha::Beta'
-  check '@@fred'
-  check '`ls`'
-  check 'array[0]'
-  check 'array[0, 1, 2]'
-  check 'obj.method(arg1, arg2)'
-  check 'obj.method'
-  check '$1'
-  check 'o=q.downcase'
-  check 'true'
-  check '"-#{q}xxx#{z.size}"'
-end

data/spec/reek_source_spec.rb

@@ -1,12 +0,0 @@
-require File.dirname(__FILE__) + '/spec_helper.rb'
-
-describe 'Reek source code:' do
-  Dir['lib/**/*.rb'].each do |source|
-    describe source do
-      it 'should report no smells' do
-        `ruby -Ilib bin/reek #{source}`.should == ''
-        $?.exitstatus.should == 0
-      end
-    end
-  end
-end

data/spec/samples/inline.reek

@@ -1,27 +0,0 @@
-[Duplication] C#build calls $?.==(0) more than once
-[Duplication] C#build calls Inline.directory more than once
-[Duplication] C#build calls io.puts more than once
-[Duplication] C#build calls io.puts(#endif) more than once
-[Duplication] C#build calls io.puts(#ifdef __cplusplus) more than once
-[Long Method] C#build has approx 61 statements
-[Nested Iterators] C#build has nested iterators
-[Uncommunicative Name] C#build uses the local variable name 't'
-[Uncommunicative Name] C#c uses the method name 'c'
-[Duplication] C#crap_for_windoze calls Config::CONFIG[libdir] more than once
-[Duplication] C#generate calls result.sub!((?-mix:\A\n), ) more than once
-[Duplication] C#generate calls signature[args] more than once
-[Duplication] C#generate calls signature[args].map more than once
-[Long Method] C#generate has approx 33 statements
-[Duplication] C#initialize calls stack.empty? more than once
-[Long Method] C#load_cache has approx 7 statements
-[Long Method] C#module_name has approx 6 statements
-[Feature Envy] C#module_name refers to md5 more than self
-[Long Method] C#parse_signature has approx 15 statements
-[Control Couple] C#parse_signature is controlled by argument raw
-[Utility Function] C#strip_comments doesn't depend on instance state
-[Feature Envy] C#strip_comments refers to src more than self
-[Large Class] Dir has 31 methods
-[Large Class] Module has 34 methods
-[Duplication] Module#inline calls Inline.const_get(lang) more than once
-[Long Method] Module#inline has approx 12 statements
-[Control Couple] Module#inline is controlled by argument options

data/spec/samples/optparse.reek

@@ -1,79 +0,0 @@
-[Large Class] AmbiguousArgument has 52 methods
-[Long Parameter List] CompletingHash#complete has 4 parameters
-[Nested Iterators] CompletingHash#complete has nested iterators
-[Long Method] CompletingHash#getopts has approx 17 statements
-[Duplication] CompletingHash#make_switch calls default_style.guess(arg=a) more than once
-[Duplication] CompletingHash#make_switch calls long.<<(o=q.downcase) more than once
-[Duplication] CompletingHash#make_switch calls pattern.method(convert) more than once
-[Duplication] CompletingHash#make_switch calls pattern.method(convert).to_proc more than once
-[Duplication] CompletingHash#make_switch calls pattern.respond_to?(convert) more than once
-[Duplication] CompletingHash#make_switch calls q.downcase more than once
-[Duplication] CompletingHash#make_switch calls sdesc.<<("-#{q}") more than once
-[Long Method] CompletingHash#make_switch has approx 69 statements
-[Nested Iterators] CompletingHash#make_switch has nested iterators
-[Uncommunicative Name] CompletingHash#make_switch uses the local variable name 'a'
-[Uncommunicative Name] CompletingHash#make_switch uses the local variable name 'n'
-[Uncommunicative Name] CompletingHash#make_switch uses the local variable name 'o'
-[Uncommunicative Name] CompletingHash#make_switch uses the local variable name 'q'
-[Uncommunicative Name] CompletingHash#make_switch uses the local variable name 's'
-[Nested Iterators] CompletingHash#match has nested iterators
-[Duplication] CompletingHash#order calls argv[0] more than once
-[Feature Envy] CompletingHash#order refers to argv more than self
-[Duplication] CompletingHash#parse calls argv[0] more than once
-[Feature Envy] CompletingHash#parse refers to argv more than self
-[Duplication] CompletingHash#parse_in_order calls $!.set_option(arg, true) more than once
-[Duplication] CompletingHash#parse_in_order calls cb.call(val) more than once
-[Duplication] CompletingHash#parse_in_order calls setter.call(sw.switch_name, val) more than once
-[Duplication] CompletingHash#parse_in_order calls sw.block more than once
-[Duplication] CompletingHash#parse_in_order calls sw.switch_name more than once
-[Long Method] CompletingHash#parse_in_order has approx 30 statements
-[Nested Iterators] CompletingHash#parse_in_order has nested iterators
-[Control Couple] CompletingHash#parse_in_order is controlled by argument setter
-[Duplication] CompletingHash#permute calls argv[0] more than once
-[Feature Envy] CompletingHash#permute refers to argv more than self
-[Long Parameter List] CompletingHash#summarize has 4 parameters
-[Uncommunicative Name] CompletingHash#ver uses the local variable name 'v'
-[Control Couple] List#accept is controlled by argument pat
-[Feature Envy] List#accept refers to pat more than self
-[Uncommunicative Name] List#accept uses the parameter name 't'
-[Long Parameter List] List#complete has 4 parameters
-[Uncommunicative Name] List#reject uses the parameter name 't'
-[Long Parameter List] List#update has 5 parameters
-[Long Method] List#update has approx 6 statements
-[Control Couple] List#update is controlled by argument lopts
-[Control Couple] List#update is controlled by argument sopts
-[Uncommunicative Name] List#update uses the local variable name 'o'
-[Control Couple] NoArgument#parse is controlled by argument arg
-[Duplication] OptionParser#complete calls candidates.size more than once
-[Duplication] OptionParser#complete calls k.id2name more than once
-[Long Method] OptionParser#complete has approx 23 statements
-[Feature Envy] OptionParser#complete refers to candidates more than self
-[Uncommunicative Name] OptionParser#complete uses the local variable name 'k'
-[Uncommunicative Name] OptionParser#complete uses the local variable name 'v'
-[Utility Function] OptionParser#convert doesn't depend on instance state
-[Control Couple] OptionalArgument#parse is controlled by argument arg
-[Control Couple] ParseError#set_option is controlled by argument eq
-[Long Method] PlacedArgument#parse has approx 6 statements
-[Control Couple] RequiredArgument#parse is controlled by argument arg
-[Uncommunicative Name] Switch#add_banner uses the local variable name 's'
-[Long Parameter List] Switch#initialize has 7 parameters
-[Duplication] Switch#parse_arg calls s.length more than once
-[Long Method] Switch#parse_arg has approx 12 statements
-[Feature Envy] Switch#parse_arg refers to arg more than self
-[Uncommunicative Name] Switch#parse_arg uses the local variable name 'm'
-[Uncommunicative Name] Switch#parse_arg uses the local variable name 's'
-[Duplication] Switch#summarize calls block.max more than once
-[Duplication] Switch#summarize calls block.max.to_i more than once
-[Duplication] Switch#summarize calls indent.+(l) more than once
-[Duplication] Switch#summarize calls left.collect more than once
-[Duplication] Switch#summarize calls left.shift more than once
-[Duplication] Switch#summarize calls left[-1] more than once
-[Duplication] Switch#summarize calls s.length more than once
-[Long Parameter List] Switch#summarize has 5 parameters
-[Long Method] Switch#summarize has approx 27 statements
-[Nested Iterators] Switch#summarize has nested iterators
-[Feature Envy] Switch#summarize refers to left more than self
-[Uncommunicative Name] Switch#summarize uses the local variable name 'l'
-[Uncommunicative Name] Switch#summarize uses the local variable name 'r'
-[Uncommunicative Name] Switch#summarize uses the local variable name 's'
-[Long Yield List] Switch#summarize yields 4 parameters

data/spec/samples/optparse/date.rb

@@ -1,17 +0,0 @@
-require 'optparse'
-require 'date'
-
-OptionParser.accept(DateTime) do |s,|
-  begin
-    DateTime.parse(s) if s
-  rescue ArgumentError
-    raise OptionParser::InvalidArgument, s
-  end
-end
-OptionParser.accept(Date) do |s,|
-  begin
-    Date.parse(s) if s
-  rescue ArgumentError
-    raise OptionParser::InvalidArgument, s
-  end
-end

data/spec/samples/optparse/shellwords.rb

@@ -1,6 +0,0 @@
-# -*- ruby -*-
-
-require 'shellwords'
-require 'optparse'
-
-OptionParser.accept(Shellwords) {|s,| Shellwords.shellwords(s)}

data/spec/samples/optparse/time.rb

@@ -1,10 +0,0 @@
-require 'optparse'
-require 'time'
-
-OptionParser.accept(Time) do |s,|
-  begin
-    (Time.httpdate(s) rescue Time.parse(s)) if s
-  rescue
-    raise OptionParser::InvalidArgument, s
-  end
-end

data/spec/samples/optparse/uri.rb

@@ -1,6 +0,0 @@
-# -*- ruby -*-
-
-require 'optparse'
-require 'uri'
-
-OptionParser.accept(URI) {|s,| URI.parse(s) if s}

data/spec/samples/optparse/version.rb

@@ -1,70 +0,0 @@
-# OptionParser internal utility
-
-class << OptionParser
-  def show_version(*pkg)
-    progname = ARGV.options.program_name
-    result = false
-    show = proc do |klass, cname, version|
-      str = "#{progname}"
-      unless klass == ::Object and cname == :VERSION
-        version = version.join(".") if Array === version
-        str << ": #{klass}" unless klass == Object
-        str << " version #{version}"
-      end
-      [:Release, :RELEASE].find do |rel|
-        if klass.const_defined?(rel)
-          str << " (#{klass.const_get(rel)})"
-        end
-      end
-      puts str
-      result = true
-    end
-    if pkg.size == 1 and pkg[0] == "all"
-      self.search_const(::Object, /\AV(?:ERSION|ersion)\z/) do |klass, cname, version|
-        unless cname[1] == ?e and klass.const_defined?(:Version)
-          show.call(klass, cname.intern, version)
-        end
-      end
-    else
-      pkg.each do |pkg|
-        begin
-          pkg = pkg.split(/::|\//).inject(::Object) {|m, c| m.const_get(c)}
-          v = case
-              when pkg.const_defined?(:Version)
-                pkg.const_get(n = :Version)
-              when pkg.const_defined?(:VERSION)
-                pkg.const_get(n = :VERSION)
-              else
-                n = nil
-                "unknown"
-              end
-          show.call(pkg, n, v)
-        rescue NameError
-        end
-      end
-    end
-    result
-  end
-
-  def each_const(path, klass = ::Object)
-    path.split(/::|\//).inject(klass) do |klass, name|
-      raise NameError, path unless Module === klass
-      klass.constants.grep(/#{name}/i) do |c|
-        klass.const_defined?(c) or next
-        c = klass.const_get(c)
-      end
-    end
-  end
-
-  def search_const(klass, name)
-    klasses = [klass]
-    while klass = klasses.shift
-      klass.constants.each do |cname|
-        klass.const_defined?(cname) or next
-        const = klass.const_get(cname)
-        yield klass, cname, const if name === cname
-        klasses << const if Module === const and const != ::Object
-      end
-    end
-  end
-end

data/spec/samples/redcloth.reek

@@ -1,65 +0,0 @@
-[Long Method] RedCloth#block_markdown_bq has approx 6 statements
-[Utility Function] RedCloth#block_markdown_rule doesn't depend on instance state
-[Duplication] RedCloth#block_textile_lists calls depth.last more than once
-[Duplication] RedCloth#block_textile_lists calls depth.last.length more than once
-[Duplication] RedCloth#block_textile_lists calls depth[i] more than once
-[Duplication] RedCloth#block_textile_lists calls line_id.-(1) more than once
-[Duplication] RedCloth#block_textile_lists calls lines[line_id.-(1)] more than once
-[Duplication] RedCloth#block_textile_lists calls tl.length more than once
-[Long Method] RedCloth#block_textile_lists has approx 21 statements
-[Nested Iterators] RedCloth#block_textile_lists has nested iterators
-[Long Method] RedCloth#block_textile_table has approx 19 statements
-[Nested Iterators] RedCloth#block_textile_table has nested iterators
-[Long Method] RedCloth#blocks has approx 17 statements
-[Nested Iterators] RedCloth#blocks has nested iterators
-[Control Couple] RedCloth#blocks is controlled by argument deep_code
-[Control Couple] RedCloth#check_refs is controlled by argument text
-[Duplication] RedCloth#clean_html calls tags[tag] more than once
-[Utility Function] RedCloth#clean_html doesn't depend on instance state
-[Long Method] RedCloth#clean_html has approx 14 statements
-[Nested Iterators] RedCloth#clean_html has nested iterators
-[Feature Envy] RedCloth#clean_html refers to tags more than self
-[Long Method] RedCloth#clean_white_space has approx 7 statements
-[Feature Envy] RedCloth#clean_white_space refers to text more than self
-[Utility Function] RedCloth#flush_left doesn't depend on instance state
-[Feature Envy] RedCloth#flush_left refers to indt more than self
-[Feature Envy] RedCloth#flush_left refers to text more than self
-[Utility Function] RedCloth#footnote_ref doesn't depend on instance state
-[Long Method] RedCloth#glyphs_textile has approx 9 statements
-[Utility Function] RedCloth#h_align doesn't depend on instance state
-[Utility Function] RedCloth#htmlesc doesn't depend on instance state
-[Feature Envy] RedCloth#htmlesc refers to str more than self
-[Utility Function] RedCloth#incoming_entities doesn't depend on instance state
-[Nested Iterators] RedCloth#inline has nested iterators
-[Long Method] RedCloth#inline_markdown_link has approx 6 statements
-[Long Method] RedCloth#inline_markdown_reflink has approx 7 statements
-[Long Method] RedCloth#inline_textile_image has approx 16 statements
-[Long Method] RedCloth#inline_textile_link has approx 9 statements
-[Long Method] RedCloth#inline_textile_span has approx 8 statements
-[Nested Iterators] RedCloth#inline_textile_span has nested iterators
-[Utility Function] RedCloth#lT doesn't depend on instance state
-[Utility Function] RedCloth#no_textile doesn't depend on instance state
-[Feature Envy] RedCloth#no_textile refers to text more than self
-[Duplication] RedCloth#pba calls $1.length more than once
-[Long Method] RedCloth#pba has approx 22 statements
-[Control Couple] RedCloth#pba is controlled by argument text_in
-[Feature Envy] RedCloth#pba refers to style more than self
-[Feature Envy] RedCloth#pba refers to text more than self
-[Duplication] RedCloth#rip_offtags calls @pre_list.last more than once
-[Duplication] RedCloth#rip_offtags calls @pre_list.last.<<(line) more than once
-[Duplication] RedCloth#rip_offtags calls codepre.-(used_offtags.length) more than once
-[Duplication] RedCloth#rip_offtags calls codepre.-(used_offtags.length).>(0) more than once
-[Duplication] RedCloth#rip_offtags calls codepre.zero? more than once
-[Duplication] RedCloth#rip_offtags calls used_offtags.length more than once
-[Duplication] RedCloth#rip_offtags calls used_offtags[notextile] more than once
-[Long Method] RedCloth#rip_offtags has approx 22 statements
-[Feature Envy] RedCloth#rip_offtags refers to codepre more than self
-[Long Parameter List] RedCloth#textile_bq has 4 parameters
-[Control Couple] RedCloth#textile_bq is controlled by argument atts
-[Control Couple] RedCloth#textile_bq is controlled by argument cite
-[Long Parameter List] RedCloth#textile_fn_ has 5 parameters
-[Control Couple] RedCloth#textile_fn_ is controlled by argument atts
-[Long Parameter List] RedCloth#textile_p has 4 parameters
-[Control Couple] RedCloth#textile_p is controlled by argument atts
-[Long Method] RedCloth#to_html has approx 24 statements
-[Utility Function] RedCloth#v_align doesn't depend on instance state