rearview 1.1.2-jruby → 1.2.0-jruby

data/lib/rearview/cron_expression_validator.rb

@@ -0,0 +1,11 @@
+module Rearview
+  class CronExpressionValidator < ActiveModel::EachValidator
+    def validate_each(record, attribute, value)
+      if value.present?
+        unless Rearview::CronHelper.valid_expression?(value)
+          record.errors.add(attribute,(options[:message] || "is not a valid cron expression"))
+        end
+      end
+    end
+  end
+end

data/lib/rearview/metrics_validator.rb

@@ -0,0 +1,52 @@
+module Rearview
+  class MetricsValidator < ActiveModel::EachValidator
+    attr_accessor :message
+    def validate_each(record, attribute, value)
+      if value.present? && value.respond_to?(:each)
+        value.each do |metric|
+          unless metric_valid?(metric)
+            record.errors.add(attribute,(message || "contains an invalid metric: #{metric}"))
+            message = nil
+          end
+        end
+      end
+    end
+    def metric_valid?(metric)
+      valid = false
+      metric_key = nil
+      target_parser.parse(metric)
+      if target_parser.error?
+        message = "contains an unparseable metric: #{metric} (#{target_parser.error})"  
+      else
+        if target_parser.tree.comment? 
+          valid = true
+        else
+          metric_key = target_parser.tree.metric
+          if metric_key.present?
+            if cache?
+              unless cache.has_key?(metric_key)
+                cache[metric_key] = client.metric_exists?(metric_key)
+              end
+              valid = cache[metric_key]
+            else
+              valid = client.metric_exists?(metric_key)
+            end
+          end
+        end
+      end
+      valid
+    end
+    def cache?
+      options[:cache]
+    end
+    def cache
+      @cache ||= {}
+    end
+    def client
+      @client ||= Graphite::Client.new(Rearview.config.graphite_connection)
+    end
+    def target_parser
+      @target_parser ||= Graphite::TargetParser.new
+    end
+  end
+end

data/lib/rearview/metrics_validator_service.rb

@@ -0,0 +1,24 @@
+
+module Rearview
+  class MetricsValidatorService
+    class MetricsValidatorServiceError < StandardError; end;
+    include Celluloid
+    include Rearview::Logger
+    def started?
+      @started
+    end
+    def startup
+      logger.info "#{self} starting up service..."
+      raise MetricsValidatorServiceError.new("service already started") if started?
+      @task = Rearview::MetricsValidatorTask.supervise(Rearview.config.metrics_validator_schedule)
+      @started = true
+    end
+    def shutdown
+      logger.info "#{self} shutting down service..."
+      raise MetricsValidatorServiceError.new("service not started") unless started?
+      @task.actors.first.terminate
+      @started = false
+    end
+  end
+end
+

data/lib/rearview/metrics_validator_task.rb

@@ -0,0 +1,56 @@
+require 'json'
+
+module Rearview
+  class MetricsValidatorTask
+    class StatsTaskError < StandardError; end;
+    include Celluloid
+    include Rearview::Logger
+    attr_reader :cron_expression
+
+    def initialize(cron_expression,start=true)
+      @cron_expression = cron_expression
+      schedule if start
+    end
+
+    def schedule
+      logger.debug "#{self} schedule"
+      if ActiveRecord::Base.connection_pool.active_connection?
+        ActiveRecord::Base.connection_pool.release_connection
+      end
+      delay = if cron_expression == '0 * * * * ?'
+                60.0
+              else
+                Rearview::CronHelper.next_valid_time_after(cron_expression)
+              end
+      logger.info "#{self} scheduled to run next in #{delay}s"
+      if(@timer)
+        @timer.cancel
+      end
+      @timer = after(delay) { self.run }
+    end
+
+    def run
+      logger.debug "#{self} run"
+      validator = Rearview::MetricsValidator.new({ attributes: [:metrics], cache: true })
+      ActiveRecord::Base.connection_pool.with_connection do
+        Rearview::Job.schedulable.load.each do |job|
+          validator.validate_each(job,:metrics,job.metrics)
+          unless job.errors[:metrics].empty?
+            alert_validation_failed(job)
+          end
+        end
+      end
+    rescue
+      logger.error "#{self} run failed: #{$!}\n#{$@.join("\n")}"
+    ensure
+      schedule
+    end
+
+    def alert_validation_failed(job)
+      logger.debug "#{self} alerting on invalid metrics for #{job.id}"
+      Rearview::MetricsValidationMailer.validation_failed_email(job.user.email,job).deliver
+    end
+
+  end
+end
+

data/lib/rearview/monitor_runner.rb

@@ -62,16 +62,18 @@ module Rearview
         logger.debug "#{self} fetch_data"
         encMetrics = metrics.delete_if { |m| m.empty? }.map { |m| URI.escape(m) }
         from, to   = create_from_to_dates(minutes, to_date)
-        uri        = "#{Rearview.config.graphite_url}/render?from=#{from}&until=#{to}&format=raw&target=" + encMetrics.join("&target=")
-
-        logger.debug("#{self} fetch_data #{uri}")
+        params = {}.tap do |h|
+          h["from"] = from
+          h["until"] = to
+          h["format"] = "raw"
+          h["target"] = metrics.delete_if { |m| m.empty? }
+        end
 
         begin
-          response = HTTParty.get(uri)
-
-          case response.code
+          response = Graphite::Client.new(Rearview.config.graphite_connection).render(params)
+          case response.status
           when 200
-            Rearview::GraphiteParser.parse(response.body)
+            Graphite::RawParser.parse(response.body)
           else
             message = response.body
             logger.error("Graphite request failure: #{message}")

data/lib/rearview/monitor_service.rb

@@ -18,6 +18,7 @@ module Rearview
       @started
     end
     def startup
+      logger.info "#{self} starting up service..."
       raise MonitorServiceError.new("service already started") if started?
       # TODO actor could die, need to reference by name in registry and/or create link
       @supervisor = Rearview::MonitorSupervisor.run!
@@ -25,6 +26,7 @@ module Rearview
       @started = true
     end
     def shutdown
+      logger.info "#{self} shutting down service..."
       raise MonitorServiceError.new("service not started") unless started?
       @supervisor.remove_all_tasks
       @supervisor.terminate

data/lib/rearview/stats_service.rb

@@ -14,13 +14,15 @@ module Rearview
       @started
     end
     def startup
+      logger.info "#{self} starting up service..."
       raise StatsServiceError.new("service already started") if started?
       @started = true
-      @stats_task = Rearview::StatsTask.supervise
+      @task = Rearview::StatsTask.supervise
     end
     def shutdown
+      logger.info "#{self} shutting down service..."
       raise StatsServiceError.new("service not started") unless started?
-      @stats_task.actors.first.terminate
+      @task.actors.first.terminate
     end
   end
 end

data/lib/rearview/version.rb

@@ -1,3 +1,3 @@
 module Rearview
-  VERSION = "1.1.2"
+  VERSION = "1.2.0"
 end

data/lib/tasks/rearview_tasks.rake

@@ -1,8 +1,8 @@
 # Tasks made available to engine host..
 
 namespace :rearview do
-  namespace :config do
 
+  namespace :config do
     desc "Verify configuration"
     task :verify => [:environment] do
       puts "using \"#{Rails.env}\" configuration:\n#{Rearview.config.dump}"
@@ -14,6 +14,12 @@ namespace :rearview do
         puts Rearview.config.errors.full_messages.join("\n")
       end
     end
+  end
 
+  desc "Setup Rearview"
+  task :setup => [:environment,"db:create","db:migrate","db:seed"] do
+    Kernel.system("bin/rails generate rearview:install")
+    puts "setup done"
   end
+
 end

data/public/rearview-src/js/app.js

@@ -13,6 +13,7 @@ define([
     'view/addcategory',
     'view/ecosystem',
     'view/secondarynav',
+    'view/settings',
     'model/user',
     'model/dashboard',
     'collection/monitor',
@@ -35,6 +36,7 @@ define([
     AddCategoryView,
     EcosystemView,
     SecondaryNavView,
+    SettingsView,
     UserModel,
     DashboardModel,
     MonitorCollection,
@@ -105,6 +107,11 @@ define([
                 'user'       : this.user,
                 'templar'    : this.templar
             }).render();
+            new SettingsView({
+                'el'         : $('.settings-wrap'),
+                'user'       : this.user,
+                'templar'    : this.templar
+            }).render();
         },
 
         secondaryNav : function() {
@@ -282,8 +289,10 @@ define([
                                'schedulemonitor',
                                'secondarynav',
                                'setmetrics',
+                               'settings',
                                'smallmonitor'
                            ], {
+                             url     : rearview.path + '/templates/',
                              version : ( _.isUndefined(rearview.version) ? '0.0.1' : rearview.version ),
                                cache : ( _.isUndefined(rearview.cache) ? true : false )
                            })

data/public/rearview-src/js/model/user.js

@@ -57,9 +57,13 @@ function(
             }
         },
 
-        updatePrefs : function(preferences) {
+        applyPrefs : function(preferences) {
             var existingPreferences = this.get('preferences');
             this.set('preferences', _.extend(existingPreferences, preferences));
+        },
+
+        updatePrefs : function(preferences) {
+            this.applyPrefs(preferences);
             this.save();
         },
 
@@ -78,4 +82,4 @@ function(
     });
 
     return UserModel;
-});
+});

data/public/rearview-src/js/view/addmonitor.js

@@ -19,7 +19,8 @@ define([
         el : '.add-monitor-wrap',
 
         subscriptions : {
-            'view:dashboard:category' : 'updateDashboardId'
+            'view:dashboard:category' : 'updateDashboardId',
+            'view:settings:save'      : 'render'
         },
 
         events : {
@@ -42,9 +43,9 @@ define([
             // use debounce to throttle resize events and set the height when
             // the viewport changes.
             var resize = _.debounce(this.adjustModalLayout, 500);
+
             // Add the event listener
             $(window).resize(resize);
-            //
             this.render();
         },
 
@@ -60,7 +61,9 @@ define([
             this.templar.render({
                 path : 'schedulemonitor',
                 el   : this.$el.find('.content-wrap'),
-                data : {}
+                data : {
+                  'user' : this.user.toJSON()
+                }
             });
 
             this.scheduleViewInitialized = true;
@@ -297,7 +300,8 @@ define([
                 if(result.status === 'error') {
                     Backbone.Mediator.pub('view:addmonitor:test', {
                         'model'     : this.model,
-                        'message'   : "The monitor '" + this.model.get('name') + "' produced an error after testing.",
+                        'errors'    : result.errors,
+                        'raw'       : result.output,
                         'attention' : 'Monitor Test Error!',
                         'status'    : 'error'
                     });
@@ -306,7 +310,8 @@ define([
             .error(function(result) {
                 Backbone.Mediator.pub('view:addmonitor:test', {
                     'model'     : this.model,
-                    'message'   : "The monitor '" + this.model.get('name') + "' produced an error after testing.",
+                    'errors'    : result.errors,
+                    'raw'       : result.output,
                     'attention' : 'Monitor Test Error!',
                     'status'    : 'error'
                 });
@@ -373,7 +378,7 @@ define([
             var $content = '';
 
             $.ajax({
-                url     : '/help/quick.html',
+                url     : rearview.path + '/help/quick.html',
                 async   : false,
                 success : function( response ) {
                     $content = response;
@@ -445,7 +450,7 @@ define([
          **/
         _getTemplateMetaData : function(cb) {
             $.ajax({
-                url     : '/monitors/index.json',
+                url     : rearview.path + '/monitors/index.json',
                 success : function( response ) {
                     if ( typeof cb === 'function' ) {
                         cb(response);
@@ -666,7 +671,7 @@ define([
                 error : function(model, xhr, options) {
                     Backbone.Mediator.pub('view:addmonitor:save', {
                         'model'     : model,
-                        'message'   : xhr.responseText,
+                        'tryJSON'   : xhr.responseText,
                         'attention' : 'Monitor Save Error!',
                         'status'    : 'error'
                     });

data/public/rearview-src/js/view/alert.js

@@ -2,7 +2,7 @@ define([
     'view/base'
 ], function(
     BaseView
-){  
+){
 
     var AlertView = BaseView.extend({
 
@@ -13,6 +13,7 @@ define([
             'view:addmonitor:test'        : 'render',
             'view:expandedmonitor:delete' : 'render',
             'view:expandedmonitor:save'   : 'render',
+            'view:expandedmonitor:test'   : 'render',
             'view:smallmonitor:save'      : 'render',
             'view:dashboard:save'         : 'render',
             'view:resetmonitor:reset'     : 'render'
@@ -24,18 +25,24 @@ define([
         },
 
         render : function(data) {
+            if( data.tryJSON ) {
+              try {
+                data.errors = JSON.parse(data.tryJSON).errors;
+              } catch(e) {
+                data.raw = data.tryJSON;
+              }
+            }
             this.templar.render({
                 path   : 'alert',
                 el     : this.$el,
                 data   : data
             });
-
             this.activate();
         },
 
         activate : function() {
             this.$el.addClass('active');
-            _.delay(this.deactivate, 8000);
+            _.delay(this.deactivate, 20000);
         },
 
         deactivate : function() {
@@ -44,4 +51,4 @@ define([
     });
 
     return AlertView;
-});
+});

data/public/rearview-src/js/view/dashboard.js

@@ -102,7 +102,9 @@ define([
          **/
         initMonitors : function() {
             this.getCategories();
-
+            if(this.categories.length && this.categoryId==null) {
+              Backbone.Mediator.pub('view:dashboard:category', this.setCategoryId(this.categories[this.carouselIndex].id));
+            }
             // publish dashboard information for the header view
             this.getDashboardInfo(this.dashboardId, function(title) {
                 Backbone.Mediator.pub('view:dashboard:render', {
@@ -490,4 +492,4 @@ define([
     });
 
     return DashboardView;
-});
+});

data/public/rearview-src/js/view/expandedmonitor.js

@@ -22,7 +22,7 @@ define([
 
         initialize : function(options) {
             _.bindAll(this);
-            
+
             var self = this;
             this.user    = options.user;
             this.router  = options.router;
@@ -47,7 +47,7 @@ define([
             this.categories  = categories;
             this.categoryId  = categoryId;
             this.dashboardId = dashboardId;
-            
+
             this.initMonitor();
         },
         /**
@@ -194,17 +194,18 @@ define([
             var self     = this,
             $content = '';
             $alertContent = '';
-
+            //TODO fix this path
             $.ajax({
-                url     : '/help/quick.html',
+                url     : rearview.path + '/help/quick.html',
                 async   : false,
                 success : function( response ) {
                     $content = response;
                 }
             });
 
+            //TODO fix this path
             $.ajax({
-                url     : '/help/alert.html',
+                url     : rearview.path + '/help/alert.html',
                 async   : false,
                 success : function( response ) {
                     $alertContent = response;
@@ -291,9 +292,21 @@ define([
                             self.$el.find('textarea.output-view').val(result.output);
                         }
 
+                        if(result.status === 'error') {
+                            Backbone.Mediator.pub('view:expandedmonitor:test', {
+                                'model'     : this.model,
+                                'errors'    : result.errors,
+                                'raw'       : result.output,
+                                'attention' : 'Monitor Test Error!',
+                                'status'    : 'error'
+                            });
+                        }
+
                         if(typeof cb === 'function') {
                             cb(result.output);
                         }
+                    },
+                    failure : function(result) {
                     }
                 });
             }
@@ -377,9 +390,9 @@ define([
                     self.updateGraph(monitor);
                 },
                 error : function(model, xhr, options) {
-                    Backbone.Mediator.pub('view:expandedmonitor:save', { 
+                    Backbone.Mediator.pub('view:expandedmonitor:save', {
                         'model'     : self.model,
-                        'message'   : "The monitor '" + model.get('name') + "' caused an error on saving, please try again.",
+                        'tryJSON'   : xhr.responseText,
                         'attention' : 'Monitor Saved Error!',
                         'status'    : 'error'
                     });
@@ -464,8 +477,8 @@ define([
             var windowOffSet = 580,
                 alertsOffset = 6,
                 outputOffset = 4,
-                tabHeight    = ( this.$el.find('#viewMetrics') ) 
-                             ? this.$el.find('#viewMetrics').height() 
+                tabHeight    = ( this.$el.find('#viewMetrics') )
+                             ? this.$el.find('#viewMetrics').height()
                              : null;
 
             // tab height fixing