rearview 1.1.2-jruby → 1.2.0-jruby

data/spec/spec_helper.rb

@@ -1,5 +1,15 @@
+require 'simplecov'
+require 'coveralls'
+Coveralls.wear!
+
+SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
+  SimpleCov::Formatter::HTMLFormatter,
+  Coveralls::SimpleCov::Formatter
+]
+SimpleCov.start
+
 ENV['RAILS_ENV'] ||= 'test'
-require File.expand_path("../dummy/config/environment.rb", __FILE__)
+require File.expand_path('../dummy/config/environment.rb', __FILE__)
 require 'rspec/rails'
 require 'rspec/autorun'
 require 'mocha/setup'
@@ -13,13 +23,14 @@ Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
 
 Rearview.configure do |config|
   config.logger = Rails.logger
-  config.sandbox_dir = Rails.root + "sandbox"
-  config.sandbox_exec = ["rvm-exec","ruby-1.9.3-p448@rearview-sandbox","ruby"]
+  config.sandbox_dir = Rails.root + 'sandbox'
+  config.sandbox_exec = ['rvm-exec','ruby-1.9.3-p448@rearview-sandbox','ruby']
   config.sandbox_timeout = 10
   config.preload_jobs = false
   config.enable_monitor = false
   config.default_url_options = { host: 'localhost', port: '3000' }
   config.statsd_connection = { host: '127.0.0.1', port: 8125, namespace: 'rearview' }
+  config.enable_metrics_validator = false
 end
 
 Rearview.boot!
@@ -28,7 +39,7 @@ RSpec.configure do |config|
   config.mock_with :mocha
   config.use_transactional_fixtures = true
   config.infer_base_class_for_anonymous_controllers = false
-  config.order = "random"
+  config.order = 'random'
   config.include FactoryGirl::Syntax::Methods
 end
 

data/spec/support/json_factory.rb

@@ -31,7 +31,7 @@ module JsonFactory
     class << self
       def create
         {}.tap do |json|
-          json["metrics"] = "blah.blah.blah"
+          json["metrics"] = ["blah.blah.blah"]
           json["format"] = :json
           json["monitorExpr"] = "abc"
           json["minutes"] = 1

data/spec/views/dashboards/show.json.jbuilder_spec.rb

@@ -2,7 +2,9 @@ require 'spec_helper'
 
 describe "rearview/dashboards/show" do
   let(:dashboard) {
-    create(:dashboard)
+    parent = create(:dashboard)
+    child = FactoryGirl.create(:dashboard,parent: parent)
+    parent
   }
   let(:dashboard_keys) {
     ["id",

data/spec/views/jobs/show.json.jbuilder_spec.rb

@@ -21,7 +21,8 @@ describe "rearview/jobs/show" do
      "alertKeys",
      "errorTimeout",
      "createdAt",
-     "modifiedAt"]
+     "modifiedAt",
+     "errors"]
   }
   it "renders job json" do
     assign(:job,job)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rearview
 version: !ruby/object:Gem::Version
-  version: 1.1.2
+  version: 1.2.0
 platform: jruby
 authors:
 - Trent Albright
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2014-01-24 00:00:00.000000000 Z
+date: 2014-02-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -150,6 +150,34 @@ dependencies:
         version: 1.2.1
   prerelease: false
   type: :runtime
+- !ruby/object:Gem::Dependency
+  name: treetop
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.4.15
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.4.15
+  prerelease: false
+  type: :runtime
+- !ruby/object:Gem::Dependency
+  name: faraday
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 0.9.0
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 0.9.0
+  prerelease: false
+  type: :runtime
 - !ruby/object:Gem::Dependency
   name: activerecord-jdbcmysql-adapter
   version_requirements: !ruby/object:Gem::Requirement
@@ -262,6 +290,20 @@ dependencies:
         version: '0'
   prerelease: false
   type: :development
+- !ruby/object:Gem::Dependency
+  name: coveralls
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  prerelease: false
+  type: :development
 description: Timeseries data monitoring framework running as a rails engine
 email:
 - trent.albright@gmail.com
@@ -280,6 +322,7 @@ files:
 - app/controllers/rearview/user_controller.rb
 - app/helpers/rearview/application_helper.rb
 - app/mailers/rearview/alert_mailer.rb
+- app/mailers/rearview/metrics_validation_mailer.rb
 - app/models/rearview/dashboard.rb
 - app/models/rearview/job.rb
 - app/models/rearview/job_data.rb
@@ -305,6 +348,7 @@ files:
 - app/views/rearview/jobs/index.json.jbuilder
 - app/views/rearview/jobs/show.json.jbuilder
 - app/views/rearview/layouts/application.html.erb
+- app/views/rearview/metrics_validation_mailer/validation_failed_email.text.erb
 - app/views/rearview/monitor/create.json.jbuilder
 - app/views/rearview/user/_user.json.jbuilder
 - app/views/rearview/user/show.json.jbuilder
@@ -313,10 +357,20 @@ files:
 - config/locales/devise.en.yml
 - db/migrate/20131106162900_base_schema.rb
 - db/migrate/20140106161202_add_indexes.rb
+- lib/graphite.rb
 - lib/rearview.rb
 - lib/generators/rearview/install_generator.rb
 - lib/generators/templates/README.md
 - lib/generators/templates/rearview.rb
+- lib/graphite/cacerts.pem
+- lib/graphite/client.rb
+- lib/graphite/graph.rb
+- lib/graphite/raw_parser.rb
+- lib/graphite/target.rb
+- lib/graphite/target_grammer.rb
+- lib/graphite/target_grammer.treetop
+- lib/graphite/target_parser.rb
+- lib/graphite/treetop_ext.rb
 - lib/jar/commons-validator-1.4.0.jar
 - lib/jar/quartz-2.1.7.jar
 - lib/rearview/alerts.rb
@@ -324,12 +378,15 @@ files:
 - lib/rearview/concerns.rb
 - lib/rearview/configuration.rb
 - lib/rearview/constants_module_maker.rb
+- lib/rearview/cron_expression_validator.rb
 - lib/rearview/cron_helper.rb
 - lib/rearview/distribute.rb
 - lib/rearview/engine.rb
-- lib/rearview/graphite_parser.rb
 - lib/rearview/log_formatter.rb
 - lib/rearview/logger.rb
+- lib/rearview/metrics_validator.rb
+- lib/rearview/metrics_validator_service.rb
+- lib/rearview/metrics_validator_task.rb
 - lib/rearview/monitor_runner.rb
 - lib/rearview/monitor_service.rb
 - lib/rearview/monitor_supervisor.rb
@@ -353,10 +410,6 @@ files:
 - lib/rearview/templates/utilities.rb
 - lib/tasks/rearview_tasks.rake
 - public/favicon.ico
-- public/help/alert.html
-- public/help/quick.html
-- public/monitors/index.json
-- public/monitors/outage.rb
 - public/rearview/build.txt
 - public/rearview/css/rearview.css
 - public/rearview/fonts/ProximaNovaSoft-Bold/ProximaNovaSoft-Bold-webfont.eot
@@ -369,6 +422,8 @@ files:
 - public/rearview/fonts/ProximaNovaSoft-Regular/ProximaNovaSoft-Regular-webfont.ttf
 - public/rearview/fonts/ProximaNovaSoft-Regular/ProximaNovaSoft-Regular-webfont.woff
 - public/rearview/fonts/ProximaNovaSoft-Regular/ProximaNovaSoft-Regular.otf
+- public/rearview/help/alert.html
+- public/rearview/help/quick.html
 - public/rearview/img/livingsocial-logo-white.svg
 - public/rearview/img/noise-light.png
 - public/rearview/img/noise.png
@@ -404,6 +459,7 @@ files:
 - public/rearview/js/view/primarynav.js
 - public/rearview/js/view/resetmonitor.js
 - public/rearview/js/view/secondarynav.js
+- public/rearview/js/view/settings.js
 - public/rearview/js/view/smallmonitor.js
 - public/rearview/less/alert.less
 - public/rearview/less/dashboard.less
@@ -415,6 +471,8 @@ files:
 - public/rearview/less/primarynav.less
 - public/rearview/less/rearview.less
 - public/rearview/login/icons/rearview.svg
+- public/rearview/monitors/index.json
+- public/rearview/monitors/outage.rb
 - public/rearview/templates/addcategory.hbs
 - public/rearview/templates/adddashboard.hbs
 - public/rearview/templates/addmonitor.hbs
@@ -430,8 +488,8 @@ files:
 - public/rearview/templates/schedulemonitor.hbs
 - public/rearview/templates/secondarynav.hbs
 - public/rearview/templates/setmetrics.hbs
+- public/rearview/templates/settings.hbs
 - public/rearview/templates/smallmonitor.hbs
-- public/rearview/templates/test.txt
 - public/rearview/test/spec/model/application.js
 - public/rearview/test/spec/model/job.js
 - public/rearview/test/spec/model/user.js
@@ -1270,6 +1328,8 @@ files:
 - public/rearview-src/fonts/ProximaNovaSoft-Regular/ProximaNovaSoft-Regular-webfont.ttf
 - public/rearview-src/fonts/ProximaNovaSoft-Regular/ProximaNovaSoft-Regular-webfont.woff
 - public/rearview-src/fonts/ProximaNovaSoft-Regular/ProximaNovaSoft-Regular.otf
+- public/rearview-src/help/alert.html
+- public/rearview-src/help/quick.html
 - public/rearview-src/img/livingsocial-logo-white.svg
 - public/rearview-src/img/noise-light.png
 - public/rearview-src/img/noise.png
@@ -1305,6 +1365,7 @@ files:
 - public/rearview-src/js/view/primarynav.js
 - public/rearview-src/js/view/resetmonitor.js
 - public/rearview-src/js/view/secondarynav.js
+- public/rearview-src/js/view/settings.js
 - public/rearview-src/js/view/smallmonitor.js
 - public/rearview-src/less/alert.less
 - public/rearview-src/less/dashboard.less
@@ -1316,6 +1377,8 @@ files:
 - public/rearview-src/less/primarynav.less
 - public/rearview-src/less/rearview.less
 - public/rearview-src/login/icons/rearview.svg
+- public/rearview-src/monitors/index.json
+- public/rearview-src/monitors/outage.rb
 - public/rearview-src/templates/addcategory.hbs
 - public/rearview-src/templates/adddashboard.hbs
 - public/rearview-src/templates/addmonitor.hbs
@@ -1331,8 +1394,8 @@ files:
 - public/rearview-src/templates/schedulemonitor.hbs
 - public/rearview-src/templates/secondarynav.hbs
 - public/rearview-src/templates/setmetrics.hbs
+- public/rearview-src/templates/settings.hbs
 - public/rearview-src/templates/smallmonitor.hbs
-- public/rearview-src/templates/test.txt
 - public/rearview-src/test/spec/model/application.js
 - public/rearview-src/test/spec/model/job.js
 - public/rearview-src/test/spec/model/user.js
@@ -2173,6 +2236,7 @@ files:
 - spec/data/large_set.dat
 - spec/data/metric_a.dat
 - spec/data/metric_b.dat
+- spec/data/metrics.yml
 - spec/data/monitor.dat
 - spec/data/nan.dat
 - spec/data/test.dat
@@ -2221,11 +2285,21 @@ files:
 - spec/factories/job_errors.rb
 - spec/factories/jobs.rb
 - spec/factories/users.rb
+- spec/helpers/application_helper_spec.rb
+- spec/lib/graphite/client_spec.rb
+- spec/lib/graphite/graph_spec.rb
+- spec/lib/graphite/graphite_spec.rb
+- spec/lib/graphite/raw_parser.rb
+- spec/lib/graphite/target_grammer_spec.rb
+- spec/lib/graphite/target_parser_spec.rb
+- spec/lib/graphite/target_spec.rb
 - spec/lib/rearview/alerts_handler_spec.rb
 - spec/lib/rearview/configuration_spec.rb
 - spec/lib/rearview/cron_helper_spec.rb
-- spec/lib/rearview/graphite_parser_spec.rb
 - spec/lib/rearview/log_formatter_spec.rb
+- spec/lib/rearview/metrics_validator_service_spec.rb
+- spec/lib/rearview/metrics_validator_spec.rb
+- spec/lib/rearview/metrics_validator_task_spec.rb
 - spec/lib/rearview/monitor_runner_spec.rb
 - spec/lib/rearview/monitor_service_spec.rb
 - spec/lib/rearview/monitor_supervisor_spec.rb
@@ -2243,6 +2317,7 @@ files:
 - spec/lib/rearview/ext/numeric_spec.rb
 - spec/lib/rearview/templates/utilities_spec.rb
 - spec/mailers/alert_mailer_spec.rb
+- spec/mailers/metrics_validation_mailer_spec.rb
 - spec/models/dashboard_spec.rb
 - spec/models/job_data_spec.rb
 - spec/models/job_error_spec.rb
@@ -2298,6 +2373,7 @@ test_files:
 - spec/data/large_set.dat
 - spec/data/metric_a.dat
 - spec/data/metric_b.dat
+- spec/data/metrics.yml
 - spec/data/monitor.dat
 - spec/data/nan.dat
 - spec/data/test.dat
@@ -2346,11 +2422,21 @@ test_files:
 - spec/factories/job_errors.rb
 - spec/factories/jobs.rb
 - spec/factories/users.rb
+- spec/helpers/application_helper_spec.rb
+- spec/lib/graphite/client_spec.rb
+- spec/lib/graphite/graph_spec.rb
+- spec/lib/graphite/graphite_spec.rb
+- spec/lib/graphite/raw_parser.rb
+- spec/lib/graphite/target_grammer_spec.rb
+- spec/lib/graphite/target_parser_spec.rb
+- spec/lib/graphite/target_spec.rb
 - spec/lib/rearview/alerts_handler_spec.rb
 - spec/lib/rearview/configuration_spec.rb
 - spec/lib/rearview/cron_helper_spec.rb
-- spec/lib/rearview/graphite_parser_spec.rb
 - spec/lib/rearview/log_formatter_spec.rb
+- spec/lib/rearview/metrics_validator_service_spec.rb
+- spec/lib/rearview/metrics_validator_spec.rb
+- spec/lib/rearview/metrics_validator_task_spec.rb
 - spec/lib/rearview/monitor_runner_spec.rb
 - spec/lib/rearview/monitor_service_spec.rb
 - spec/lib/rearview/monitor_supervisor_spec.rb
@@ -2368,6 +2454,7 @@ test_files:
 - spec/lib/rearview/ext/numeric_spec.rb
 - spec/lib/rearview/templates/utilities_spec.rb
 - spec/mailers/alert_mailer_spec.rb
+- spec/mailers/metrics_validation_mailer_spec.rb
 - spec/models/dashboard_spec.rb
 - spec/models/job_data_spec.rb
 - spec/models/job_error_spec.rb

data/public/rearview-src/templates/test.txt

@@ -1 +0,0 @@
-hi

data/public/rearview/templates/test.txt

@@ -1 +0,0 @@
-hi