react_on_rails 11.0.3 → 12.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 5616765e73089b791e60e49c47a99c4217ae4e47
-  data.tar.gz: d6895eb29b7b04697c80f07a28ea47b716a6b1ea
+SHA256:
+  metadata.gz: 2c578e181f0adc62b6f89f1e258bf21dd515bf2f86b57034467f6026ba2bf63c
+  data.tar.gz: e3a8a7076f7c73871178114a077ec29850e6639340e8ff331d046fb491ac10e8
 SHA512:
-  metadata.gz: 7a03e79ec545f01d2cf7568f9cf403b1e53f88d9a3d6697d47b84005235f5c3d374c122264d7b8572d2b4da8c9a73a1f0955bdd4dae61adf6b7133b1861a5c5e
-  data.tar.gz: 0f210aa98d8eef9c46f31d406006f959925eb5ce0ceb09a5853088137db99d9eaa5a2dfa7d82e7fcbdab31d66d09f5c697981b0b719a5a586ca1abb9ed9521c3
+  metadata.gz: 19cebcb75b776a5f08936cc39aef164089a6ccc3ea36d792cc6fb7f0e53805e535eeb71f295826e371f74b75312d326172d26e1dc97cc640651914c5b222cfa1
+  data.tar.gz: 67dec37920284002de78660438c0f38f463a5317bbd7c7a17d2896fa4d4d7ff0044e11705ad247a7f1d3f2eb2abf90f8fd3115dc0ac496926701beb74236043c

data/.circleci/config.yml

@@ -0,0 +1,320 @@
+version: 2
+
+aliases:
+  - &docker-image
+    - image: circleci/ruby:2.6-node-browsers
+
+  # Print critical data and executables versions.
+  - &print-system-info
+    name: Print system information
+    command: |
+      echo "Linux release: "; cat /etc/issue
+      echo "Current user: "; whoami
+      echo "Current directory: "; pwd
+      echo "Ruby version: "; ruby -v
+      echo "Node version: "; node -v
+      echo "Yarn version: "; yarn --version
+      echo "Bundler version: "; bundle --version
+  - &lint-js
+    name: Linting of JS
+    command: yarn start lint
+
+  - &lint-ruby
+    name: Linting of Ruby
+    command: bundle exec rubocop
+
+  - &format
+    name: Check formatting
+    command: yarn start format.listDifferent
+
+  # Install/update Node modules for renderer package unless existing set of modules is satisfying Yarn.
+  - &install-package-node-modules
+    name: Install Node modules with Yarn for renderer package
+    command: |
+      yarn install --no-progress --no-emoji
+      yarn run eslint -v
+      sudo yarn global add yalc
+
+  # Install/update Node modules for dummy app unless existing set of modules is satisfying Yarn.
+  - &install-dummy-app-node-modules
+    name: Install Node modules with Yarn for dummy app
+    command: cd spec/dummy && yarn install --no-progress --no-emoji
+
+  # Setup yarn links for react-on-rails
+  - &install-yalc-publish
+    name: yalc publish for react-on-rails
+    command: yalc publish
+
+  - &install-yalc-add-react-on-rails
+    name: yalc add react-on-rails
+    command: cd spec/dummy && yalc add react-on-rails
+
+  # Install ruby gems unless existing set of gems is satisfying bundler.
+  - &install-dummy-app-ruby-gems
+    name: Install Ruby Gems for dummy app
+    command: |
+      gem install bundler
+      echo "Bundler version: "; bundle --version
+      cd spec/dummy && bundle check --path=vendor/bundle || bundle install --path=vendor/bundle --jobs=4 --retry=3
+
+  # Install ruby gems unless existing set of gems is satisfying bundler.
+  - &install-package-ruby-gems
+    name: Install Ruby Gems for package
+    command: |
+      gem install bundler
+      echo "Bundler version: "; bundle --version
+      bundle check --path=vendor/bundle || bundle install --path=vendor/bundle --jobs=4 --retry=3
+
+  # Restore node_modules dir from cache using yarn.lock checksum as a key.
+  - &restore-package-node-modules-cache
+    name: Restore cached node_modules directory
+    keys:
+      - v4-package-node-modules-cache-{{ checksum "yarn.lock" }}
+
+  # Restore spec/dummy/node_modules dir from cache using yarn.lock checksum as a key.
+  - &restore-dummy-app-node-modules-cache
+    name: Restore cached spec/dummy/node_modules directory
+    keys:
+      - v4-dummy-app-node-modules-cache-{{ checksum "spec/dummy/yarn.lock" }}
+
+  # Restore vendor/bundle dir from cache using Gemfile.lock checksum as a key.
+  - &restore-dummy-app-gem-cache
+    name: Restore cached Ruby Gems for dummy app
+    keys:
+      - v4-dummy-app-gem-cache-{{ checksum "spec/dummy/Gemfile.lock" }}
+
+  # Restore vendor/bundle dir from cache using react_on_rails.gemspec checksum as a key.
+  - &restore-package-gem-cache
+    name: Restore cached Ruby Gems for package
+    keys:
+      - v4-package-app-gem-cache-{{ checksum "react_on_rails.gemspec" }}
+
+    # NOTE: Sometimes CI generated docker images are not updated in time to keep up with the minimum required
+    # by chromedriver versions of Chrome. Just bump here Chrome version if chromedriver raises errors
+  - &install-latest-chrome
+    name: Ensure minimum required Chrome version
+    command: |
+      echo -e "Installed $(google-chrome --version)\n"
+      MINIMUM_REQUIRED_CHROME_VERSION=75
+      INSTALLED_CHROME_MAJOR_VERSION="$(google-chrome --version | tr ' .' '\t' | cut -f3)"
+      if [[ $INSTALLED_CHROME_MAJOR_VERSION < $MINIMUM_REQUIRED_CHROME_VERSION ]]; then
+        wget -q -O - https://dl.google.com/linux/linux_signing_key.pub | sudo apt-key add -
+        sudo sh -c 'echo "deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable main" >> /etc/apt/sources.list.d/google.list'
+        sudo apt-get update
+        sudo apt-get install google-chrome-stable
+        echo -e "\nInstalled $(google-chrome --version)"
+      fi
+
+jobs:
+  # Lint all
+  lint-js-and-ruby:
+    docker: *docker-image
+    steps:
+      - checkout
+      - run: *print-system-info
+      - restore_cache: *restore-package-node-modules-cache
+      - restore_cache: *restore-package-gem-cache
+      - run: *install-package-ruby-gems
+      - run: *lint-ruby
+      - run: *lint-js
+      - run: *format
+
+  prettier:
+    docker: *docker-image
+    parallelism: 1
+    steps:
+      - checkout
+      - restore_cache: *restore-package-node-modules-cache
+      - run:
+          name: prettier
+          command: yarn start format.listDifferent
+
+  # Install Node modules for Renderer package with Yarn and save them to chache.
+  install-package-node-packages:
+    docker: *docker-image
+    steps:
+      - checkout
+      - run: *print-system-info
+      - restore_cache: *restore-package-node-modules-cache
+      - run: *install-package-node-modules
+      - save_cache:
+          name: Save root node_modules to cache
+          key: v4-package-node-modules-cache-{{ checksum "yarn.lock" }}
+          paths:
+            - node_modules
+
+
+  # Install Node modules for dummy app with Yarn and save them to cache.
+  install-dummy-app-node-packages:
+    docker: *docker-image
+    steps:
+      - checkout
+      - run: *print-system-info
+      - restore_cache: *restore-dummy-app-node-modules-cache
+      - run: *install-package-node-modules
+      - run: *install-yalc-publish
+      - run: *install-yalc-add-react-on-rails
+      - run: *install-dummy-app-node-modules
+      - save_cache:
+          name: Save spec/dummy/node_modules to cache
+          key: v4-dummy-app-node-modules-cache-{{ checksum "spec/dummy/yarn.lock" }}
+          paths:
+            - spec/dummy/node_modules
+            - spec/dummy/node_modules
+
+  # Install Ruby gems for package with Bundler and save them to cache.
+  install-package-ruby-gems:
+    docker: *docker-image
+    steps:
+      - checkout
+      - run: *print-system-info
+      - restore_cache: *restore-package-gem-cache
+      - run: *install-package-ruby-gems
+      - save_cache:
+          name: Save dummy app ruby gems to cache
+          key: v4-package-app-gem-cache-{{ checksum "react_on_rails.gemspec" }}
+          paths:
+            - vendor/bundle
+
+  # Install Ruby gems for dummy app with Bundler and save them to cache.
+  install-dummy-app-ruby-gems:
+    docker: *docker-image
+    steps:
+      - checkout
+      - run: *print-system-info
+      - restore_cache: *restore-dummy-app-gem-cache
+      - run: *install-dummy-app-ruby-gems
+      - save_cache:
+          name: Save dummy app ruby gems to cache
+          key: v4-dummy-app-gem-cache-{{ checksum "spec/dummy/Gemfile.lock" }}
+          paths:
+            - spec/dummy/vendor/bundle
+
+  # Build client and server bundles for dummy app with Webpack and save them to cache.
+  # NOTE: keeping around this cache in case we have multiple rspec suites in the future to tests
+  # different node renderers.
+  build-dummy-app-webpack-test-bundles:
+    docker: *docker-image
+    steps:
+      - checkout
+      - run: *print-system-info
+      - run: *install-package-node-modules
+      - run: *install-yalc-publish
+      - restore_cache: *restore-dummy-app-node-modules-cache
+      - run: *install-yalc-add-react-on-rails
+      - run: *install-dummy-app-node-modules
+      - run: *install-dummy-app-ruby-gems
+      - run:
+          name: Build test bundles for dummy app
+          command: cd spec/dummy && yarn run build:test
+      - save_cache:
+          name: Save test webpack bundles to cache (for build number checksum used by rspec job)
+          key: v4-dummy-app-webpack-bundle-{{ .Revision }}
+          paths:
+            - spec/dummy/public/webpack
+  # Run JS unit tests for Renderer package.
+  package-js-tests:
+    docker: *docker-image
+    steps:
+      - checkout
+      - run: *print-system-info
+      - restore_cache: *restore-package-node-modules-cache
+      - run: *install-package-node-modules
+      - run:
+          name: Run JS unit tests for Renderer package
+          command: yarn test
+
+  rspec-package-specs:
+    docker: *docker-image
+    steps:
+      - checkout
+      - run: *print-system-info
+      - restore_cache: *restore-package-gem-cache
+      - run: *install-package-ruby-gems
+      - run:
+          name: Run rspec tests
+          command: |
+            bundle exec rspec spec/react_on_rails
+      - store_test_results:
+          path: ~/rspec
+      - store_artifacts:
+          path: log/test.log
+
+  main:
+    docker: *docker-image
+    steps:
+      - checkout
+      - run: *print-system-info
+      - restore_cache: *restore-package-gem-cache
+      - restore_cache: *restore-dummy-app-gem-cache
+      - restore_cache:
+          name: Restore cached webpack bundles for dummy app
+          key: v4-dummy-app-webpack-bundle-{{ .Revision }}
+      - restore_cache: *restore-dummy-app-node-modules-cache
+      - restore_cache: *restore-package-node-modules-cache
+      - run: *install-package-node-modules
+      - run: *install-yalc-publish
+      - run: *install-yalc-add-react-on-rails
+      - run: *install-package-ruby-gems
+      - run: *install-dummy-app-ruby-gems
+      - run: *install-latest-chrome
+      - run:
+          name: Touch webpack bundles
+          command: touch spec/dummy/public/webpack/test/*
+      - run:
+          name: Install yalc globally
+          command: sudo yarn global add yalc
+      - run:
+          name: Prep for CI
+          # TODO -- need to leverage Circle CI containers
+          command: |
+            bundle exec rake prepare_for_ci
+      - run:
+          name: Main CI
+          # TODO -- need to leverage Circle CI containers
+          command: |
+            bundle exec rake run_rspec:all_dummy
+      - store_test_results:
+          path: ~/rspec
+      - store_artifacts:
+          path: spec/dummy/tmp/capybara
+      - store_artifacts:
+          path: spec/dummy/log/test.log
+      - store_artifacts:
+          path: spec/dummy/yarn-error.log
+
+workflows:
+  version: 2
+  build-and-test:
+    jobs:
+      - install-package-node-packages
+      - install-package-ruby-gems
+      - install-dummy-app-node-packages
+      - install-dummy-app-ruby-gems
+      - lint-js-and-ruby:
+          requires:
+            - install-package-node-packages
+            - install-package-ruby-gems
+      - prettier:
+          filters:
+            branches:
+              ignore: master
+          requires:
+            - install-package-node-packages
+      - build-dummy-app-webpack-test-bundles:
+          requires:
+            - install-dummy-app-node-packages
+      - package-js-tests:
+          requires:
+            - install-package-node-packages
+      - rspec-package-specs:
+          requires:
+            - install-package-ruby-gems
+            - build-dummy-app-webpack-test-bundles
+            - install-dummy-app-ruby-gems
+      - main:
+          requires:
+            - install-package-ruby-gems
+            - install-dummy-app-ruby-gems
+            - install-package-node-packages
+            - build-dummy-app-webpack-test-bundles

data/.eslintignore

@@ -2,7 +2,6 @@ node_modules
 coverage
 spec/react_on_rails/dummy-for-generators
 spec/dummy
-spec/dummy_no_webpacker
 node_package/lib/
 node_package/tests/node_modules
 node_package/webpack.config.js
@@ -14,3 +13,5 @@ node_package/webpack.config.js
 **/coverage/**
 **/cable.js
 **/public/packs*/*
+gen-examples
+bundle/

data/.eslintrc

@@ -1,8 +1,11 @@
 ---
-extends: eslint-config-shakacode
+extends:
+  - eslint-config-shakacode
+  - prettier
+  - prettier/react
 
 plugins:
-  - react
+  - prettier
 
 globals:
   __DEBUG_SERVER_ERRORS__: true
@@ -12,9 +15,31 @@ env:
   browser: true
   node: true
   mocha: true
+  jest: true
+
+overrides:
+  - files: ["**/*.ts", "**/*.tsx"]
+    parser: "@typescript-eslint/parser"
+    parserOptions:
+      ecmaVersion: 2018
+      sourceType: module
+      project: "./tsconfig.json"
+    extends:
+      - eslint:recommended
+      - plugin:@typescript-eslint/eslint-recommended
+      - plugin:@typescript-eslint/recommended
+    plugins:
+      - "@typescript-eslint"
+    rules:
+      "@typescript-eslint/no-namespace": 0
 
 rules:
   no-console: 0
+  function-paren-newline: 0
+  object-curly-newline: 0
+  no-restricted-syntax: ["error", "SequenceExpression"]
+  # https://stackoverflow.com/a/59268871/5241481
+  import/extensions: ['error', 'ignorePackages', {"js": 'never',"ts": "never"}]
 
   # https://github.com/benmosher/eslint-plugin-import/issues/340
   import/no-extraneous-dependencies: 0
@@ -22,3 +47,6 @@ rules:
 settings:
   import/core-modules:
     - react-redux
+  import/resolver:
+    node:
+      extensions: [".js", ".ts", ".d.ts"]

data/.github/FUNDING.yml

@@ -0,0 +1 @@
+github: [shakacode]

data/.gitignore

@@ -1,7 +1,6 @@
 /.bundle/
 /.yardoc
 /Gemfile.lock
-/Gemfile.rails32.lock
 /_yardoc/
 /coverage/
 /doc/
@@ -32,3 +31,6 @@ npm-debug.*
 /gen-examples
 
 .DS_Store
+
+.yalc
+yalc.lock

data/.prettierignore

@@ -0,0 +1,10 @@
+node_modules/
+package.json
+tmp/
+coverage/
+**/app/assets/webpack/
+spec/dummy/public
+gen-examples/examples/*
+node_package/lib/*
+spec/react_on_rails/dummy-for-generators/app/javascript/bundles/HelloWorld/*
+bundle/

data/.prettierrc

@@ -0,0 +1,23 @@
+printWidth: 110
+tabWidth: 2
+useTabs: false
+semi: true
+singleQuote: true
+trailingComma: all
+bracketSpacing: true
+jsxBracketSameLine: false
+parser: flow
+
+extends:
+- tslint-config-prettier
+
+overrides:
+- files: "*.@(css|scss)"
+  options:
+    parser: css
+    singleQuote: false
+    printWidth: 120
+- files: "*.@(json)"
+  options:
+    parser: json
+    printWidth: 100

data/.release-it.json

@@ -0,0 +1,3 @@
+{
+  "requireCleanWorkingDir": false
+}

data/.rubocop.yml

@@ -3,11 +3,13 @@
 
 AllCops:
   DisplayCopNames: true
-  TargetRubyVersion: 2.1
+  TargetRubyVersion: 2.5
 
   Include:
     - '**/Rakefile'
     - '**/config.ru'
+    - 'Gemfile'
+    - '**/*.rb'
 
   Exclude:
     - 'vendor/**/*'
@@ -25,12 +27,8 @@ AllCops:
     - 'spec/react_on_rails/dummy-for-generators/**/*'
     - 'spec/dummy/Procfile.*'
     - 'spec/dummy/bin/**/*'
-    - 'spec/dummy/client/node_modules/**/*'
-    - 'spec/dummy/client/node_modules/**/.*'
-    - 'spec/dummy_no_webpacker/Procfile.*'
-    - 'spec/dummy_no_webpacker/bin/**/*'
-    - 'spec/dummy_no_webpacker/client/node_modules/**/*'
-    - 'spec/dummy_no_webpacker/client/node_modules/**/.*'
+    - 'spec/dummy/node_modules/**/*'
+    - 'spec/dummy/node_modules/**/.*'
     - 'gen-examples/examples/**/.*'
     - 'gen-examples/examples/**/*'
 
@@ -38,13 +36,12 @@ Naming/FileName:
   Exclude:
     - 'Gemfile'
     - 'spec/dummy/Gemfile'
-    - 'spec/dummy_no_webpacker/Gemfile'
 
 # Turn off until we require 2.3 ruby
 Style/SafeNavigation:
   Enabled: false
 
-Metrics/LineLength:
+Layout/LineLength:
   Max: 120
 
 Style/StringLiterals:
@@ -53,11 +50,20 @@ Style/StringLiterals:
 Style/Documentation:
   Enabled: false
 
+Style/HashEachMethods:
+  Enabled: true
+
+Style/HashTransformKeys:
+  Enabled: true
+
+Style/HashTransformValues:
+  Enabled: true
+
 Lint/AssignmentInCondition:
   Exclude:
     - 'spec/dummy/bin/spring'
 
-Lint/HandleExceptions:
+Lint/SuppressedException:
   Exclude:
     - 'spec/dummy/bin/rails'
     - 'spec/dummy/bin/rake'
@@ -84,9 +90,31 @@ Metrics/MethodLength:
 Metrics/ModuleLength:
   Max: 180
 
+Naming/RescuedExceptionsVariableName:
+  Enabled: false
+
 Style/GlobalVars:
   Exclude:
     - 'spec/dummy/config/environments/development.rb'
 
 Style/FrozenStringLiteralComment:
-  EnforcedStyle: when_needed
+  EnforcedStyle: always
+
+Layout/EmptyLinesAroundAttributeAccessor:
+  Enabled: true
+
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: true
+
+Lint/RaiseException:
+  Enabled: true
+
+Lint/StructNewOverride:
+  Enabled: true
+
+Style/ExponentialNotation:
+  Enabled: true
+
+Style/SlicingWithRange:
+  Enabled: true
+

data/.travis.yml

@@ -3,11 +3,10 @@ sudo: required
 language: ruby
 
 rvm:
-  # Rails 5 requires 2.2
-  - 2.3.1
-  - 2.4.1
-  - 2.5.0
-  - 2.2.6
+  - 2.5.3
+  - 2.6.5
+  - 2.7.0
+
 services:
   - docker
 
@@ -19,7 +18,6 @@ cache:
 
 gemfile:
   - spec/dummy/Gemfile
-  - spec/dummy_no_webpacker/Gemfile.rails32
 
 env:
   global:
@@ -36,14 +34,16 @@ before_install:
   - "/sbin/start-stop-daemon --start --quiet --pidfile /tmp/custom_xvfb_99.pid --make-pidfile --background --exec /usr/bin/Xvfb -- :99 -ac -screen scn 1600x1200x16"
 
 install:
-  - travis_retry gem install bundler
-  - travis_retry nvm install node 8.0.0
+  - travis_retry gem install bundler -v '>2'
+  - travis_retry nvm install 13.9.0
   - node -v
-  - travis_retry npm i -g yarn@0.27.5
-  - travis_retry yarn global add babel-cli
+  - travis_retry npm i -g yarn
   - travis_retry bundle install
+  - travis_retry yarn global add yalc
+  - travis_retry yalc publish
+  - travis_retry cd spec/dummy && yalc add react-on-rails
   - travis_retry yarn
-  - travis_retry yarn run build
+  - travis_retry cd ../.. && yarn run build
   - bundle exec rake prepare_for_ci
 
 before_script:
@@ -52,17 +52,6 @@ before_script:
 script:
   - bundle exec rake
 
-matrix:
-  exclude:
-    - gemfile: spec/dummy_no_webpacker/Gemfile.rails32
-      rvm: 2.3.1
-    - gemfile: spec/dummy_no_webpacker/Gemfile.rails32
-      rvm: 2.4.1
-    - gemfile: spec/dummy_no_webpacker/Gemfile.rails32
-      rvm: 2.5.0
-    - gemfile: spec/dummy/Gemfile
-      rvm: 2.2.6
-
 notifications:
   slack:
     secure: LfcUk4AJ4vAxWwRIyw4tFh8QNbYefMwfG/oLfsN3CdRMWMOtCOHR1GGsRhAOlfVVJ/FvHqVqWj5gK7z7CaO5Uvl7rD3/zJ8QzExKx/iH9yWj55iIPuKLzwFNnBwRpFW/cqyU2lFPPRxGD50BUn3c+qybkuSqtKZ6qtTowwqlxLa5iyM3N95aZp7MEIKCP7cPcnHfLbJyP8wBpotp/rtw62eXM2HIRJJwgjcp+n+My7VFR9DnBXNFf6R91aZHM4U4cHHDbu15HFtH8honVrzK1JQdyqMNHga+j04dFuaS7z9Q369/hsELMOBp/227+Pz7ZRfWZFK4UASguOvyeX7RmGTRpTuWLm1XJeUzfsPZVROecaSVQBve+U7F12yKqilt97QlvRXn2EGyBILqvxtFNNR4S9kgAf72/6EFgiM1TKq7i9zy6lVOnagU2+7amq7UeopX1uoFsUfNKMR7YbgV1WjF0IK95UP0b0/7ZOJlPYgi5zzkQi129qAFWSMmxGk+ZpsttHh/tjJtvAh0A3mHq/zb5w4ub/MbSyZqeDUNgGj72QArOWUFSAStQT1ybsVLeDoKPgOvVq7OV1D64rpcHjBXcqOCit8tDZ+TqkFhcYJo2cITSaqE4zJXn+4F5s7So5O8CyfKYQq+kFJCooYGmfgTUckJpGl7eIvKmL4TN9Q=