react_on_rails 10.0.0 → 11.0.0

data/docs/additional-reading/server-rendering-tips.md

@@ -17,15 +17,15 @@ The point is that you have separate files for top level client or server side, a
 ## Troubleshooting Server Rendering
 
 1. First be sure your code works with server rendering disabled (`prerender: false`)
-2. `export TRACE_REACT_ON_RAILS=TRUE` Turn this on to get both the invocation code for you component, as well as the whole file used to setup the JavaScript context.
+2. Be sure that `config.trace` is true. You will get the server invocation code that renders your component. If you're not using Webpacker, you will also get the whole file used to setup the JavaScript context.
 
-## setTimeout and setInterval
+## setTimeout, setInterval, and clearTimeout
 
-These methods are polyfilled for server rendering to be no-ops. We don't log calls to these by default as some libraries, namely babel-polyfill, will call setTimout. If you wish to log calls to setTimeout and setInterval, set the ENV value: `export TRACE_REACT_ON_RAILS=TRUE`.
+These methods are polyfilled for server rendering to be no-ops. We log calls to these when in `trace` mode. In the past, some libraries, namely babel-polyfill, did call setTimout. 
 
 Here's an example of this which shows the line numbers that end up calling setTimeout:
 ```
-➜  ~/shakacode/react_on_rails/gen-examples/examples/basic-server-rendering (add-rails-helper-to-generator u=) ✗ export TRACE_REACT_ON_RAILS=TRUE
+➜  ~/shakacode/react_on_rails/gen-examples/examples/basic-server-rendering (add-rails-helper-to-generator u=) ✗ export SERVER_TRACE_REACT_ON_RAILS=TRUE
 ➜  ~/shakacode/react_on_rails/gen-examples/examples/basic-server-rendering (add-rails-helper-to-generator u=) ✗ rspec 
 Hello World
 Building Webpack client-rendering assets...

data/docs/additional-reading/troubleshooting-when-using-webpacker.md

@@ -0,0 +1,90 @@
+## Context
+
+Rails: 5.0.2
+react_on_rails: upgraded from 6.6.0 to 9.0.3
+
+## The failure
+
+Rspec failing with
+```
+Failure/Error: raise Webpacker::Manifest::MissingEntryError, missing_file_from_manifest_error(name)
+     
+     Webpacker::Manifest::MissingEntryError:
+       Webpacker can't find webpack-bundle.js in /home/user/ws/pp/code/pp-core-checkout_spa_update_npm/public/webpack-test/manifest.json. Possible causes:
+       1. You want to set webpacker.yml value of compile to true for your environment
+          unless you are using the `webpack -w` or the webpack-dev-server.
+       2. Webpack has not yet re-run to reflect updates.
+       3. You have misconfigured Webpacker's config/webpacker.yml file.
+       4. Your Webpack configuration is not creating a manifest.
+       Your manifest contains:
+       {
+         "main.css": "/webpack-test/main-bundle.css",
+         "main.js": "/webpack-test/main-dde0e05a2817931424c3.js"
+       }
+     # /home/user/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/webpacker-3.0.1/lib/webpacker/manifest.rb:44:in `handle_missing_entry'
+     # /home/user/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/webpacker-3.0.1/lib/webpacker/manifest.rb:40:in `find'
+     # /home/user/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/webpacker-3.0.1/lib/webpacker/manifest.rb:27:in `lookup'
+     # /home/user/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/react_on_rails-9.0.3/lib/react_on_rails/utils.rb:145:in `bundle_js_file_path_from_webpacker'
+     # /home/user/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/react_on_rails-9.0.3/lib/react_on_rails/utils.rb:90:in `bundle_js_file_path'
+     # /home/user/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/react_on_rails-9.0.3/lib/react_on_rails/test_helper/webpack_assets_status_checker.rb:56:in `block in all_compiled_assets'
+     # /home/user/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/react_on_rails-9.0.3/lib/react_on_rails/test_helper/webpack_assets_status_checker.rb:55:in `map'
+     # /home/user/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/react_on_rails-9.0.3/lib/react_on_rails/test_helper/webpack_assets_status_checker.rb:55:in `all_compiled_assets'
+     # /home/user/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/react_on_rails-9.0.3/lib/react_on_rails/test_helper/webpack_assets_status_checker.rb:35:in `stale_generated_webpack_files'
+     # /home/user/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/react_on_rails-9.0.3/lib/react_on_rails/test_helper/ensure_assets_compiled.rb:34:in `call'
+     # /home/user/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/react_on_rails-9.0.3/lib/react_on_rails/test_helper.rb:85:in `ensure_assets_compiled'
+     # /home/user/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/react_on_rails-9.0.3/lib/react_on_rails/test_helper.rb:39:in `block (2 levels) in configure_rspec_to_compile_assets'
+     # /home/user/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/rspec-core-3.5.4/lib/rspec/core/example.rb:443:in `instance_exec'
+...
+```
+
+At the same time dev/prod environments works fine (with extra webpack calling step outside rails).
+
+## Configs
+
+### webpack.config.js
+
+```js
+...
+const ManifestPlugin = require('webpack-manifest-plugin');
+...
+const { output } = webpackConfigLoader(configPath);
+...
+  output: {
+    filename: '[name]-[hash].js',
+
+    // Leading and trailing slashes ARE necessary.
+    publicPath: output.publicPath,
+    path: output.path,
+  },
+...
+  plugins: [
+    ...
+    new ManifestPlugin({
+      publicPath: output.publicPath,
+      writeToFileEmit: true
+    }),
+   ...
+  ]
+...
+```
+
+### config/webpacker.yml
+
+is default from sample appliction v9.x
+
+### config/initializers/react_on_rails.rb
+
+```ruby
+  ...
+  # Define the files we need to check for webpack compilation when running tests.
+  config.webpack_generated_files = %w( webpack-bundle.js main-bundle.css )
+  ...
+```
+
+## The problem
+
+When `ReactOnRails.configuration.webpack_generated_files` is specified, it prevents usage of `manifest.json`
+
+## Solution
+
+Removing of `config.webpack_generated_files` from `config/initializers/react_on_rails.rb` resolving issue.

data/docs/api/ruby-api.md

@@ -1,3 +1,8 @@
-PENDING:
+# View Helpers
+See the [app/helpers/react_on_rails_helper.rb](../../app/helpers/react_on_rails_helper.rb) source.
 
-Should we document the view helpers here concisely?
+# Controller Helpers
+See the [lib/react_on_rails/controller.rb](../../lib/react_on_rails/controller.rb) source.
+
+# Utility Methods
+See the [lib/react_on_rails/utils.rb](../../lib/react_on_rails/utils.rb) source.

data/docs/basics/configuration.md

@@ -1,4 +1,4 @@
-Here is the full set of config options.
+Here is the full set of config options. This file is `/config/initializers/react_on_rails.rb`
 
 ```ruby
 # frozen_string_literal: true
@@ -7,6 +7,13 @@ Here is the full set of config options.
 # Thus, you only need to pay careful attention to the non-commented settings in this file.
 
 ReactOnRails.configure do |config|
+  # `trace`: General debugging flag.
+  # The default is true for development, off otherwise.
+  # With true, you get detailed logs of rendering and stack traces if you call setTimout, 
+  # setInterval, clearTimout when server rendering.
+  config.trace = Rails.env.development?
+
+
   # defaults to "" (top level)
   #
   config.node_modules_location = ""
@@ -66,6 +73,7 @@ ReactOnRails.configure do |config|
   #
   # While you may configure this to be the same as your client bundle file, this file is typically
   # different.
+  #
   config.server_bundle_js_file = "server-bundle.js"
 
   # If set to true, this forces Rails to reload the server bundle if it is modified
@@ -73,13 +81,15 @@ ReactOnRails.configure do |config|
   #
   config.development_mode = Rails.env.development?
 
-  # For server rendering. This can be set to false so that server side messages are discarded.
+  # For server rendering so that it replays in the browser console.
+  # This can be set to false so that server side messages are not displayed in the browser.
   # Default is true. Be cautious about turning this off.
   # Default value is true
-  #
+  # 
   config.replay_console = true
 
-  # Default is true. Logs server rendering messages to Rails.logger.info
+  # Default is true. Logs server rendering messages to Rails.logger.info. If false, you'll only
+  # see the server rendering messages in the browser console.
   #
   config.logging_on_server = true
 
@@ -88,7 +98,14 @@ ReactOnRails.configure do |config|
   # 
   config.raise_on_prerender_error = false
 
-  # Server rendering only (not for render_component helper)
+  ################################################################################
+  # Server Renderer Configuration for ExecJS
+  ################################################################################
+  # The default server rendering is ExecJS, probably using the mini_racer gem
+  # If you wish to use an alternative Node server rendering for higher performance, 
+  # contact justin@shakacode.com for details.
+  # 
+  # For ExecJS:
   # You can configure your pool of JS virtual machines and specify where it should load code:
   # On MRI, use `mini_racer` for the best performance
   # (see [discussion](https://github.com/reactjs/react-rails/pull/290))
@@ -111,7 +128,7 @@ ReactOnRails.configure do |config|
   # By default(without this option) all yaml files from Rails.root.join("config", "locales")
   # and installed gems are loaded
   config.i18n_yml_dir = Rails.root.join("config", "locales", "client")
-
+  
   ################################################################################
   ################################################################################
   # CLIENT RENDERING OPTIONS
@@ -120,9 +137,6 @@ ReactOnRails.configure do |config|
   ################################################################################
   # default is false
   config.prerender = false
-
-  # default is true for development, off otherwise
-  config.trace = Rails.env.development?
 end
 
 ```

data/docs/basics/i18n.md

@@ -71,3 +71,7 @@ You can refer to [react-webpack-rails-tutorial](https://github.com/shakacode/rea
     { formatMessage(defaultMessages.yourLocaleKeyInCamelCase) }
   )
   ```
+  
+  # Notes
+  
+  * See [Support for Rails' i18n pluralization #1000](https://github.com/shakacode/react_on_rails/issues/1000) for a discussion of issues around pluralization.

data/docs/basics/upgrading-react-on-rails.md

@@ -0,0 +1,181 @@
+# Upgrading React on Rails
+
+## Upgrading to version 11
+* Remove `server_render_method` from config/initializers/react_on_rails.rb. Alternate server rendering methods are part of React on Rails Pro. If you want to use a custom renderer, contact justin@shakacode.com. We have a custom node rendering solution in production for egghead.io.
+* Remove your usage of ENV["TRACE_REACT_ON_RAILS"] usage. You can get all tracing with either specifying trace at your component or in your config/initializers/react_on_rails.rb file.
+* ReactOnRails::Utils.server_bundle_file_name and ReactOnRails::Utils.bundle_file_name were removed. React on Rails Pro contains upgrades to enable component and other types caching with React on Rails.
+
+
+## Upgrading to version 10
+
+Pretty simple:
+* Follow the steps to migrate to version 9 (except installing 10.x instead of 9.x)
+* If you have `react_component` returning hashes, then switch to `react_component_hash` instead
+
+## Upgrading to version 9
+
+### Why Webpacker?
+Webpacker provides areas of value:
+* View helpers that support bypassing the asset pipeline, which allows you to avoid double minification and enable source maps in production. This is 100% a best practice as source maps in production greatly increases the value of services such as HoneyBadger or Sentry.
+* A default Webpack config so that you only need to do minimal modifications and customizations. However, if you're doing server rendering, you may not want to give up control. Since Webpacker's default webpack config is changing often, we at Shakacode can give you definitive advice on webpack configuration best practices. In general, if you're happy with doing your own Webpack configuration, then we suggest using the `client` strategy discussed below. Most corporate projects will prefer having more control than direct dependence on webpacker easily allows.
+
+### Integrating Webpacker
+Reason for doing this: This enables your webpack bundles to bypass the Rails asset pipeline and it's extra minification, enabling you to use source-maps in production, while still maintaining total control over everything in the client directory
+
+#### From version 7 or lower
+
+##### ...while keeping your `client` directory
+Unfortunately, this requires quite a few steps:
+*   `.gitignore`: add `/public/webpack/*`
+*   `Gemfile`: bump `react_on_rails` and add `webpacker`
+*   layout views: anything bundled by webpack will need to be requested by a `javascript_pack_tag` or `stylesheet_pack_tag`
+*   `config/initializers/assets.rb`: we no longer need to modify `Rails.application.config.assets.paths` or append anything to `Rails.application.config.assets.precompile`.
+*   `config/initializers/react_on_rails.rb`:
+    *   Delete `config.generated_assets_dir`. Webpacker's config now supplies this information
+    *   Replace `config.npm_build_(test|production)_command` with `config.build_(test|production)_command`
+*   `config/webpacker.yml`: start with our [example config](https://github.com/shakacode/react-webpack-rails-tutorial/blob/master/config/webpacker.yml) (feel free to modify it as needed). I recommend setting dev_server.hmr to false however since HMR is currently broken.
+*   `client/package.json`: bump `react_on_rails` (I recommend bumping `webpack` as well). You'll also need `js-yaml` if you're not already using `eslint` and `webpack-manifest-plugin` regardless.
+
+######  Client Webpack config:
+  *   You'll need the following code to read data from the webpacker config:
+
+```
+const path = require('path');
+const ManifestPlugin = require('webpack-manifest-plugin'); // we'll use this later
+
+const webpackConfigLoader = require('react-on-rails/webpackConfigLoader');
+const configPath = path.resolve('..', 'config');
+const { output } = webpackConfigLoader(configPath);
+```
+
+  *   That output variable will be used for webpack's `output` rules:
+
+```
+  output: {
+    filename: '[name]-[chunkhash].js', // [chunkhash] because we've got to do our own cache-busting now
+    path: output.path,
+    publicPath: output.publicPath,
+  },
+```
+
+  *   ...as well as for the output of plugins like `webpack-manifest-plugin`:
+
+```
+
+      new ManifestPlugin({
+        publicPath: output.publicPath,
+        writeToFileEmit: true
+      }),
+```
+
+  *   If you're using referencing files or images with `url-loader` & `file-loader`, their publicpaths will have to change as well: `publicPath: '/webpack/',`
+  *   If you're using `css-loader`, `webpack.optimize.CommonsChunkPlugin`, or `extract-text-webpack-plugin`, they will also need cache-busting!
+
+...and you're finally done!
+
+##### ...while replacing your `client` directory
+* Make the same changes to `config/initializers/react_on_rails.rb as described above`
+* Upgrade RoR & add Webpacker in the Gemfile
+* Upgrade RoR in the `client/package.json`
+* Run `bundle`
+* Run `rails webpacker:install`
+* Run `rails webpacker:install:react`
+* Run `rails g react_on_rails:install`
+* Move your entry point files to `app/javascript/packs`
+* Either:
+    * Move all your source code to `app/javascript/bundles`, move your linter configs to the root directory, and then delete the `client` directory
+    * or just delete the webpack config and remove webpack, its loaders, and plugins from your `client/package.json`.
+
+...and you're done.
+
+#### From version 8
+
+For an example of upgrading, see [react-webpack-rails-tutorial/pull/416](https://github.com/shakacode/react-webpack-rails-tutorial/pull/416).
+
+- Breaking Configuration Changes
+  1. Added `config.node_modules_location` which defaults to `""` if Webpacker is installed. You may want to set this to 'client'` to `config/initializers/react_on_rails.rb` to keep your node_modules inside of `/client`
+  2. Renamed
+   * config.npm_build_test_command ==> config.build_test_command
+   * config.npm_build_production_command ==> config.build_production_command
+
+- Update the gemfile. Switch over to using the webpacker gem.
+
+```rb
+gem "webpacker"
+```
+
+- Update for the renaming in the `WebpackConfigLoader` in your webpack configuration.
+  You will need to rename the following object properties:
+  - webpackOutputPath      ==> output.path
+  - webpackPublicOutputDir ==> output.publicPath
+  - hotReloadingUrl        ==> output.publicPathWithHost
+  - hotReloadingHostname   ==> settings.dev_server.host
+  - hotReloadingPort       ==> settings.dev_server.port
+  - hmr                    ==> settings.dev_server.hmr
+  - manifest               ==> Remove this one. We use the default for Webpack of manifest.json
+  - env                    ==> Use `const { env } = require('process');`
+  - devBuild               ==> Use `const devBuild = process.env.NODE_ENV !== 'production';`
+
+- Edit your Webpack.config files:
+  - Change your Webpack output to be like this. **Be sure to have the hash or chunkhash in the filename,** unless the bundle is server side.:
+    ```
+    const webpackConfigLoader = require('react-on-rails/webpackConfigLoader');
+    const configPath = resolve('..', 'config');
+    const { output, settings } = webpackConfigLoader(configPath);
+    const hmr = settings.dev_server.hmr;
+    const devBuild = process.env.NODE_ENV !== 'production';
+
+    output: {
+      filename: isHMR ? '[name]-[hash].js' : '[name]-[chunkhash].js',
+      chunkFilename: '[name]-[chunkhash].chunk.js',
+
+      publicPath: output.publicPath,
+      path: output.path,
+    },
+    ```
+  - Change your ManifestPlugin definition to something like the following
+    ```
+    new ManifestPlugin({
+        publicPath: output.publicPath,
+        writeToFileEmit: true
+      }),
+
+    ```
+
+- Find your `webpacker_lite.yml` and rename it to `webpacker.yml`
+  - Consider copying a default webpacker.yml setup such as https://github.com/shakacode/react-on-rails-v9-rc-generator/blob/master/config/webpacker.yml
+  - If you are not using the webpacker webpacker setup, be sure to put in `compile: false` in the `default` section.
+  - Alternately, if you are updating from webpacker_lite, you can manually change these:
+  - Add a default setting
+    ```
+    cache_manifest: false
+    ```
+  - For production, set:  
+    ```
+    cache_manifest: true
+    ```
+  - Add a section like this under your development env:
+    ```
+    dev_server:
+      host: localhost
+      port: 3035
+      hmr: false
+    ```
+    Set hmr to your preference.
+  - See the example `spec/dummy/config/webpacker.yml`.
+  - Remove keys `hot_reloading_host` and `hot_reloading_enabled_by_default`. These are replaced by the `dev_server` key.
+  - Rename `webpack_public_output_dir` to `public_output_path`.
+
+- Edit your Procfile.dev
+  - Remove the env value WEBPACKER_DEV_SERVER as it's not used
+  - For hot loading:
+    - Set the `hmr` key in your `webpacker.yml` to `true`.
+
+### Without integrating webpacker
+* Bump your ReactOnRails versions in `Gemfile` & `package.json`
+* In `/config/initializers/react_on_rails.rb`:
+    *  Rename `config.npm_build_test_command` ==> `config.build_test_command`
+    *  Rename `config.npm_build_production_command` ==> `config.build_production_command`
+    *  Add `config.node_modules_location = "client"`
+
+...and you're done.

data/docs/tutorial.md

@@ -1,9 +1,6 @@
 # React on Rails Basic Tutorial
 
-* NOTE: Please be sure to use the BETA or RC versions of React on Rails until 9.0 is released.*
-
-
-This tutorial setups up a new Rails app with **React on Rails**, demonstrating Rails + React + Redux + Server Rendering. It is updated to 9.0.0.
+This tutorial guides you through setting up a new or existing Rails app with **React on Rails**, demonstrating Rails + React + Redux + Server Rendering. It is updated to 10.0.2.
 
 After finishing this tutorial you will get an application that can do the following (live on Heroku):
 
@@ -39,7 +36,7 @@ gem install rails               # download and install latest stable Rails
 gem install foreman             # download and install Foreman
 ```
 
-Then we need to create a fresh Rails application with webpacker react support as following. Be sure that 
+Then we need to create a fresh Rails application with webpacker react support as following.
 
 First be sure to run `rails -v` and check you are using Rails 5.1.3 or above. If you are using an older version of Rails, you'll need to install webpacker with react per the instructions [here](https://github.com/rails/webpacker).
 
@@ -52,23 +49,22 @@ rails new test-react-on-rails --webpack=react
 cd test-react-on-rails
 ```
 
-Note: you can do the following two commands in an existing Rails app or pre Rails 5.1.3:
+Note: if you are installing React On Rails in an existing app or an app that uses Rails pre 5.1.3, you will need to run these two commands as well:
 
 ```
 bundle exec rails webpacker:install
 bundle exec rails webpacker:install:react
 ```
 
-
-
 Add the **React On Rails** gem to your Gemfile:
 
 ```
-gem 'react_on_rails', '9.0.0'         # use latest gem version, prefer exact version 
+gem 'react_on_rails', '10.0.2'         # prefer exact gem version to match npm version
 ```
 
+Note: Latest released React On Rails version is considered stable. Please use the latest version to ensure you get all the security patches and the best support.
 
-Then run `bundle` and commit the git repository (or `rails generate` will not work properly)
+Run `bundle` and commit the git repository (or `rails generate` will not work properly)
 
 
 ```
@@ -80,7 +76,7 @@ git add -A
 git commit -m "Initial commit"
 ```
 
-Install React on Rails: `rails generator react_on_rails:install` or `rails generate react_on_rails:install --redux`. You need to first git commit your files before running the generator, or else it will generate an error.
+Install React on Rails: `rails generate react_on_rails:install` or `rails generate react_on_rails:install --redux`. You need to first git commit your files before running the generator, or else it will generate an error.
 
 ```
 rails generate react_on_rails:install

data/lib/generators/react_on_rails/base_generator.rb

@@ -9,7 +9,7 @@ module ReactOnRails
     class BaseGenerator < Rails::Generators::Base
       include GeneratorHelper
       Rails::Generators.hide_namespace(namespace)
-      source_root(File.expand_path("../templates", __FILE__))
+      source_root(File.expand_path("templates", __dir__))
 
       # --redux
       class_option :redux,
@@ -43,7 +43,7 @@ module ReactOnRails
       end
 
       def add_yarn_dependencies
-        run "yarn add react-on-rails"
+        run "yarn add react-on-rails --exact"
       end
 
       def append_to_spec_rails_helper
@@ -55,6 +55,7 @@ module ReactOnRails
           if File.exist?(spec_helper)
             add_configure_rspec_to_compile_assets(spec_helper)
           else
+            # rubocop:disable Layout/EmptyLinesAroundArguments
             GeneratorMessages.add_info(
               <<-MSG.strip_heredoc
 
@@ -67,6 +68,8 @@ module ReactOnRails
               ReactOnRails::TestHelper.configure_rspec_to_compile_assets(config)
               MSG
             )
+            # rubocop:enable Layout/EmptyLinesAroundArguments
+
           end
         end
       end
@@ -95,7 +98,7 @@ module ReactOnRails
             - Visit http://localhost:3000/hello_world and see your React On Rails app running!
 
             - Run bin/webpack-dev-server to start the Webpack dev server for compilation of Webpack
-              assets assets as soon as you save. This default setup with the dev server does not work
+              assets as soon as you save. This default setup with the dev server does not work
               for server rendering
 
             - Alternately, you may turn off compile in config/webpacker.yml and run the foreman

data/lib/generators/react_on_rails/dev_tests_generator.rb

@@ -8,7 +8,7 @@ module ReactOnRails
     class DevTestsGenerator < Rails::Generators::Base
       include GeneratorHelper
       Rails::Generators.hide_namespace(namespace)
-      source_root(File.expand_path("../templates/dev_tests", __FILE__))
+      source_root(File.expand_path("templates/dev_tests", __dir__))
 
       # --example-server-rendering
       class_option :example_server_rendering,

data/lib/generators/react_on_rails/install_generator.rb

@@ -10,7 +10,7 @@ module ReactOnRails
       include GeneratorHelper
 
       # fetch USAGE file for details generator description
-      source_root(File.expand_path("../", __FILE__))
+      source_root(File.expand_path(__dir__))
 
       # --redux
       class_option :redux,

data/lib/generators/react_on_rails/react_no_redux_generator.rb

@@ -8,7 +8,7 @@ module ReactOnRails
     class ReactNoReduxGenerator < Rails::Generators::Base
       include GeneratorHelper
       Rails::Generators.hide_namespace(namespace)
-      source_root(File.expand_path("../templates", __FILE__))
+      source_root(File.expand_path("templates", __dir__))
 
       def copy_base_files
         base_js_path = "base/base"

data/lib/generators/react_on_rails/react_with_redux_generator.rb

@@ -6,7 +6,7 @@ module ReactOnRails
   module Generators
     class ReactWithReduxGenerator < Rails::Generators::Base
       Rails::Generators.hide_namespace(namespace)
-      source_root(File.expand_path("../templates", __FILE__))
+      source_root(File.expand_path("templates", __dir__))
 
       def create_redux_directories
         dirs = %w[actions constants containers reducers store startup]
@@ -14,7 +14,7 @@ module ReactOnRails
       end
 
       def copy_base_files
-        base_js_path = "base/base"
+        base_js_path = "redux/base"
         base_files = %w[app/javascript/bundles/HelloWorld/components/HelloWorld.jsx]
         base_files.each { |file| copy_file("#{base_js_path}/#{file}", file) }
       end

data/lib/generators/react_on_rails/templates/base/base/app/javascript/bundles/HelloWorld/components/HelloWorld.jsx

@@ -13,7 +13,7 @@ export default class HelloWorld extends React.Component {
     super(props);
 
     // How to set initial state in ES6 class syntax
-    // https://facebook.github.io/react/docs/reusable-components.html#es6-classes
+    // https://reactjs.org/docs/state-and-lifecycle.html#adding-local-state-to-a-class
     this.state = { name: this.props.name };
   }
 

data/lib/generators/react_on_rails/templates/base/base/config/initializers/react_on_rails.rb

@@ -1,11 +1,12 @@
 # frozen_string_literal: true
 
-# See docs/basics/configuration.md for many more options
+# See https://github.com/shakacode/react_on_rails/blob/master/docs/basics/configuration.md
+# for many more options.
 
 ReactOnRails.configure do |config|
   # This configures the script to run to build the production assets by webpack. Set this to nil
   # if you don't want react_on_rails building this file for you.
-  config.build_production_command = "RAILS_ENV=production bin/webpack"
+  config.build_production_command = "RAILS_ENV=production NODE_ENV=production bin/webpack"
 
   ################################################################################
   ################################################################################

data/lib/generators/react_on_rails/templates/dev_tests/spec/simplecov_helper.rb

@@ -6,13 +6,13 @@ if ENV["COVERAGE"] == "true"
   require "simplecov"
 
   # Using a command name prevents results from getting clobbered by other test suites
-  example_name = File.basename(File.expand_path("../../../.", __FILE__))
+  example_name = File.basename(File.expand_path("../..", __dir__))
   SimpleCov.command_name(example_name)
 
   SimpleCov.start("rails") do
     # Consider the entire gem project as the root
     # (typically this will be the folder named "react_on_rails")
-    gem_root_path = File.expand_path("../../../../../.", __FILE__)
+    gem_root_path = File.expand_path("../../../..", __dir__)
     root gem_root_path
 
     # Don't report anything that has "spec" in the path

data/lib/react_on_rails/assets_precompile.rb

@@ -72,7 +72,7 @@ module ReactOnRails
                  "or manifest.yml at #{@assets_path}, but found none. Canceling symlinking tasks."
         return -1
       end
-      manifest_path = manifest_glob.first
+      manifest_path = take_most_recent_manifest_path(manifest_glob)
       manifest_file = File.new(manifest_path)
       manifest_data = if File.extname(manifest_file) == ".json"
                         manifest_file_data = File.read(manifest_path)
@@ -102,8 +102,8 @@ module ReactOnRails
         next unless File.lstat(filename).symlink?
         begin
           target = File.readlink(filename)
-        rescue # rubocop:disable Lint/RescueWithoutErrorClass
-          puts "React on Rails: Warning: your platform doesn't support File::readlink method." /
+        rescue StandardError
+          puts "React on Rails: Warning: your platform doesn't support File::readlink method." \
                "Skipping broken link check."
           break
         end
@@ -128,6 +128,10 @@ module ReactOnRails
 
     private
 
+    def take_most_recent_manifest_path(manifest_glob)
+      manifest_glob.max_by { |name| File.mtime(name) }
+    end
+
     def symlink_and_points_to_existing_file?(symlink_path)
       # File.exist?(symlink_path) will check the file the sym is pointing to is existing
       # File.lstat(symlink_path).symlink? confirms that this is a symlink
@@ -139,7 +143,7 @@ module ReactOnRails
       # pointing to. We can't use File.exist?, as that would check the file pointed at by the symlink.
       File.lstat(path)
       true
-    rescue # rubocop:disable Lint/RescueWithoutErrorClass
+    rescue StandardError
       false
     end
   end