react_on_rails 10.0.0 → 11.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1c3ced829061ca6995dd0f55349112955883e87b
-  data.tar.gz: be160b38edcaa90ae64ce0ea69a029f48505968b
+  metadata.gz: 31c09a3e5f99dd68c101be042157d0df07ce3d28
+  data.tar.gz: c1b5a351538f6f66b02fd6b7d9dbc9016f9b7a5a
 SHA512:
-  metadata.gz: 69f0ea0f49b5a2e5eab554656ffe8b82b18cad3475ea963a5fced718d2af7498f5aaf23e4a0a9554382f32a6a24f1fa154b1d4e27d208286b54d757ac5032e48
-  data.tar.gz: 7442ea55fa1d838d8c8f75dbfdb83c6db36bce40b5be5e3f10a9d38f8455d91930e7aa2bdfdd55ab3546f5c38a96bef1eef9f18f5b15f325c344c7492767dbc4
+  metadata.gz: ed448da2f9649ab1fe01df7e3f9f5391a0ab0a0d00d19588d4d4ec7463d0967ba4680c820175e20dc4c9a083561aa7783c9d0925c0a9013c8e0af49755c23309
+  data.tar.gz: c4db1f97a32d563a83e11fd0987160cabe408caa88fef4880d96be89da8ca752a5218a426370cf1834bdbdc36ea537c3d97bd5b98eb70110fd299d2ac9a72072

data/.eslintrc

@@ -18,3 +18,7 @@ rules:
 
   # https://github.com/benmosher/eslint-plugin-import/issues/340
   import/no-extraneous-dependencies: 0
+
+settings:
+  import/core-modules:
+    - react-redux

data/.rubocop.yml

@@ -3,7 +3,7 @@
 
 AllCops:
   DisplayCopNames: true
-  TargetRubyVersion: 2.3
+  TargetRubyVersion: 2.1
 
   Include:
     - '**/Rakefile'
@@ -72,7 +72,7 @@ Metrics/PerceivedComplexity:
   Max: 10
 
 Metrics/ClassLength:
-  Max: 140
+  Max: 150
 
 Metrics/ParameterLists:
   Max: 5

data/.travis.yml

@@ -6,6 +6,7 @@ rvm:
   # Rails 5 requires 2.2
   - 2.3.1
   - 2.4.1
+  - 2.5.0
   - 2.2.6
 services:
   - docker
@@ -57,6 +58,8 @@ matrix:
       rvm: 2.3.1
     - gemfile: spec/dummy_no_webpacker/Gemfile.rails32
       rvm: 2.4.1
+    - gemfile: spec/dummy_no_webpacker/Gemfile.rails32
+      rvm: 2.5.0
     - gemfile: spec/dummy/Gemfile
       rvm: 2.2.6
 

data/CHANGELOG.md

@@ -3,10 +3,76 @@ All notable changes to this project's source code will be documented in this fil
 
 Contributors: please follow the recommendations outlined at [keepachangelog.com](http://keepachangelog.com/). Please use the existing headings and styling as a guide, and add a link for the version diff at the bottom of the file. Also, please update the `Unreleased` link to compare to the latest release version.
 
+See [Upgrading React on Rails](./docs/basics/upgrading-react-on-rails.md) for more concise instructions on upgrading.
+
 ## [Unreleased]
 Changes since last non-beta release.
 
-*Please add entries here for your pull requests.*
+*Please add entries here for your pull requests that are not yet released.*
+
+## MIGRATION for v11
+- Unused `server_render_method` was removed from the configuration. If you want to use a custom renderer, contact justin@shakacode.com. We have a custom node rendering solution in production for egghead.io.
+- Removed ReactOnRails::Utils.server_bundle_file_name and ReactOnRails::Utils.bundle_file_name. These are part of the performance features of "React on Rails Pro".
+- Removed ENV["TRACE_REACT_ON_RAILS"] usage and replacing it with config.trace.
+
+#### Enhanchements: Better Error Messages, Support for React on Rails Pro
+- Tracing (debugging) options are simplified with a single `config.trace` setting that defaults to true for development and false otherwise.
+- Calls to setTimeout, setInterval, clearTimeout will now always log some message if config.trace is true. Your JavaScript code should not be calling setTimout when server rendering. 
+- Errors raised are of type ReactOnRailsError, so you can see they came from React on Rails for debugging.
+- Removed ReactOnRails::Utils.server_bundle_file_name and ReactOnRails::Utils.bundle_file_name.
+- No longer logging the `railsContext` when server logging.
+- Rails.env is provided in the default railsContext, as suggested in [issue #697](https://github.com/shakacode/react_on_rails/issues/697).
+[PR 1018](https://github.com/shakacode/react_on_rails/pull/1065) by [justin808](https://github.com/justin808).
+
+#### Fixes
+- More exact version checking. We keep the react_on_rails gem and the react-on-rails node package at
+the same exact versions so that we can be sure that the interaction between them is precise.
+This is so that if a bug is detected after some update, it's critical that
+both the gem and the node package get the updates. This change ensures that the package.json specification does not use a
+~ or ^ as reported in [issue #1062](https://github.com/shakacode/react_on_rails/issues/1062). [PR 1063](https://github.com/shakacode/react_on_rails/pull/1063) by [justin808](https://github.com/justin808).
+- Sprockets: Now use the most recent manifest when creating symlinks. See [issue #1023](https://github.com/shakacode/react_on_rails/issues/1023). [PR 1064](https://github.com/shakacode/react_on_rails/pull/1064) by [justin808](https://github.com/justin808).
+
+### [10.1.4] - 2018-04-11
+
+#### Fixed
+- Changed i18n parsing to convert ruby i18n argument syntax into FormatJS argument syntax. [PR 1046](https://github.com/shakacode/react_on_rails/pull/1046) by [sepehr500](https://github.com/sepehr500).
+
+- Fixed an issue where the spec compiler check would fail if the project path contained spaces. [PR 1045](https://github.com/shakacode/react_on_rails/pull/1045) by [andrewmarkle](https://github.com/andrewmarkle).
+
+- Updated the default `build_production_command` that caused production assets to be built with development settings. [PR 1053](https://github.com/shakacode/react_on_rails/pull/1053) by [Roman Kushnir](https://github.com/RKushnir).
+
+### [10.1.3] - 2018-02-28
+#### Fixed
+- Improved error reporting on version mismatches between Javascript and Ruby packages. [PR 1025](https://github.com/shakacode/react_on_rails/pull/1025) by [theJoeBiz](https://github.com/squadette).
+
+### [10.1.2] - 2018-02-27
+#### Fixed
+- Use ReactDOM.hydrate() for hydrating a SSR component if available. ReactDOM.render() has been deprecated for use on SSR components in React 16 and this addresses the warning. [PR 1028](https://github.com/shakacode/react_on_rails/pull/1028) by [theJoeBiz](https://github.com/theJoeBiz).
+
+### [10.1.1] - 2018-01-26
+#### Fixed
+- Fixed issue with server-rendering error handler: [PR 1020](https://github.com/shakacode/react_on_rails/pull/1020) by [jblasco3](https://github.com/jblasco3).
+
+### [10.1.0] - 2018-01-23
+#### Added
+- Added 2 cache helpers: ReactOnRails::Utils.bundle_file_name(bundle_name) and ReactOnRails::Utils.server_bundle_file_name
+for easy access to the hashed filenames for use in cache keys. [PR 1018](https://github.com/shakacode/react_on_rails/pull/1018) by [justin808](https://github.com/justin808).
+
+#### Fixed
+- Use redux component in generated redux Hello World example: [PR 1006](https://github.com/shakacode/react_on_rails/pull/1006) by [lewaabahmad](https://github.com/lewaabahmad).
+- Fixed `Utils.bundle_js_file_path` generating the incorrect path for `manifest.json` in webpacker projects: [Issue #1011](https://github.com/shakacode/react_on_rails/issues/1011) by [elstgav](https://github.com/elstgav)
+
+### [10.0.2] - 2017-11-10
+#### Fixed
+- Remove unnecessary dependencies from released NPM package: [PR 968](https://github.com/shakacode/react_on_rails/pull/968) by [tricknotes](https://github.com/tricknotes).
+
+### [10.0.1] - 2017-10-28
+#### Fixed
+- Fixed `react_component_hash` functionality in cases of prerendering errors: [PR 960](https://github.com/shakacode/react_on_rails/pull/960) by [Judahmeek](https://github.com/Judahmeek).
+- Fix to add missing dependency to run generator spec individually: [PR 962](https://github.com/shakacode/react_on_rails/pull/962) by [tricknotes](https://github.com/tricknotes).
+- Fixes check for i18n_dir in LocalesToJs returning false when i18n_dir was set. [PR 899](https://github.com/shakacode/react_on_rails/pull/899) by [hakongit](https://github.com/hakongit).
+- Fixed mistake in rubocop comments that led to errors when handling exceptions in ReactOnRails::ServerRendering::Exec [PR 963](https://github.com/shakacode/react_on_rails/pull/963) by [railsme](https://github.com/railsme).
+- Fixed and improved I18n directories checks: [PR 967](https://github.com/shakacode/react_on_rails/pull/967) by [railsme](https://github.com/railsme)
 
 ### [10.0.0] - 2017-10-08
 #### Created
@@ -14,108 +80,27 @@ Changes since last non-beta release.
 #### Deprecated
 - Deprecated `react_component` functionality for react_helmet support.
 To clarify, the method itself is not deprecated, only certain functionality which has been moved to `react_component_hash`
-[PR 951](https://github.com/shakacode/react_on_rails/pull/951) by [Judahmeek](https://github.com/Judahmeek)
+[PR 951](https://github.com/shakacode/react_on_rails/pull/951) by [Judahmeek](https://github.com/Judahmeek).
 
 ### [9.0.3] - 2017-09-20
 #### Improved
-- Improved comments in generated Procfile.dev-server. [PR 940](https://github.com/shakacode/react_on_rails/pull/940) by [justin808](https://github.com/justin808 )
+- Improved comments in generated Procfile.dev-server. [PR 940](https://github.com/shakacode/react_on_rails/pull/940) by [justin808](https://github.com/justin808).
 
 ### [9.0.2] - 2017-09-10
 #### Fixed
-- Improved post install doc comments for generator. [PR 933](https://github.com/shakacode/react_on_rails/pull/933) by [justin808](https://github.com/justin808 )
+- Improved post install doc comments for generator. [PR 933](https://github.com/shakacode/react_on_rails/pull/933) by [justin808](https://github.com/justin808).
 
 ### [9.0.1] - 2017-09-10
 
 #### Fixed
-- Fixes Rails 3.2 compatability issues. [PR 926](https://github.com/shakacode/react_on_rails/pull/926) by [morozovm](https://github.com/morozovm )
+- Fixes Rails 3.2 compatability issues. [PR 926](https://github.com/shakacode/react_on_rails/pull/926) by [morozovm](https://github.com/morozovm).
 
 ### [9.0.0] - 2017-09-06
 Updated React on Rails to depend on [rails/webpacker](https://github.com/rails/webpacker). [PR 908](https://github.com/shakacode/react_on_rails/pull/908) by [justin808](https://github.com/justin808).
 
 
 #### 9.0 from 8.x. Upgrade Instructions
-
-For an example of upgrading, see [react-webpack-rails-tutorial/pull/416](https://github.com/shakacode/react-webpack-rails-tutorial/pull/416).
-
-- Breaking Configuration Changes
-  1. Added `config.node_modules_location` which defaults to `""` if Webpacker is installed. You may want to set this to 'client'` to `config/initializers/react_on_rails.rb` to keep your node_modules inside of `/client`
-  2. Renamed
-   * config.npm_build_test_command ==> config.build_test_command
-   * config.npm_build_production_command ==> config.build_production_command
-
-- Update the gemfile. Switch over to using the webpacker gem.
-
-```rb
-gem "webpacker"
-```
-
-- Update for the renaming in the `WebpackConfigLoader` in your webpack configuration.
-  You will need to rename the following object properties:
-  - webpackOutputPath      ==> output.path
-  - webpackPublicOutputDir ==> output.publicPath
-  - hotReloadingUrl        ==> output.publicPathWithHost
-  - hotReloadingHostname   ==> settings.dev_server.host
-  - hotReloadingPort       ==> settings.dev_server.port
-  - hmr                    ==> settings.dev_server.hmr
-  - manifest               ==> Remove this one. We use the default for Webpack of manifest.json
-  - env                    ==> Use `const { env } = require('process');`
-  - devBuild               ==> Use `const devBuild = process.env.NODE_ENV !== 'production';`
-
-- Edit your Webpack.config files:
-  - Change your Webpack output to be like this. **Be sure to have the hash or chunkhash in the filename,** unless the bundle is server side.:
-    ```
-    const webpackConfigLoader = require('react-on-rails/webpackConfigLoader');
-    const configPath = resolve('..', 'config');
-    const { output, settings } = webpackConfigLoader(configPath);
-    const hmr = settings.dev_server.hmr;
-    const devBuild = process.env.NODE_ENV !== 'production';
-
-    output: {
-      filename: isHMR ? '[name]-[hash].js' : '[name]-[chunkhash].js',
-      chunkFilename: '[name]-[chunkhash].chunk.js',
-
-      publicPath: output.publicPath,
-      path: output.path,
-    },
-    ```
-  - Change your ManifestPlugin definition to something like the following
-    ```
-    new ManifestPlugin({
-        publicPath: output.publicPath,
-        writeToFileEmit: true
-      }),
-
-    ```
-
-- Find your `webpacker_lite.yml` and rename it to `webpacker.yml`
-  - Consider copying a default webpacker.yml setup such as https://github.com/shakacode/react-on-rails-v9-rc-generator/blob/master/config/webpacker.yml
-  - If you are not using the webpacker webpacker setup, be sure to put in `compile: false` in the `default` section.
-  - Alternately, if you are updating from webpacker_lite, you can manually change these:
-  - Add a default setting
-    ```
-    cache_manifest: false
-    ```
-  - For production, set:  
-    ```
-    cache_manifest: true
-    ```
-  - Add a section like this under your development env:
-    ```
-    dev_server:
-      host: localhost
-      port: 3035
-      hmr: false
-    ```
-    Set hmr to your preference.
-  - See the example `spec/dummy/config/webpacker.yml`.
-  - Remove keys `hot_reloading_host` and `hot_reloading_enabled_by_default`. These are replaced by the `dev_server` key.
-  - Rename `webpack_public_output_dir` to `public_output_path`.
-
-- Edit your Procfile.dev
-  - Remove the env value WEBPACKER_DEV_SERVER as it's not used
-  - For hot loading:
-    - Set the `hmr` key in your `webpacker.yml` to `true`.
-
+Moved to [our documentation](docs/basics/upgrading-react-on-rails.md#upgrading-to-version-9).
 
 ### [8.0.7] - 2017-08-16
 #### Fixed
@@ -739,7 +724,15 @@ Best done with Object destructing:
 ##### Fixed
 - Fix several generator related issues.
 
-[Unreleased]: https://github.com/shakacode/react_on_rails/compare/9.0.3...master
+[Unreleased]: https://github.com/shakacode/react_on_rails/compare/10.1.4...master
+[10.1.4]: https://github.com/shakacode/react_on_rails/compare/10.1.3...10.1.4
+[10.1.3]: https://github.com/shakacode/react_on_rails/compare/10.1.2...10.1.3
+[10.1.2]: https://github.com/shakacode/react_on_rails/compare/10.1.1...10.1.2
+[10.1.1]: https://github.com/shakacode/react_on_rails/compare/10.1.0...10.1.1
+[10.1.0]: https://github.com/shakacode/react_on_rails/compare/10.0.2...10.1.0
+[10.0.2]: https://github.com/shakacode/react_on_rails/compare/10.0.1...10.0.2
+[10.0.1]: https://github.com/shakacode/react_on_rails/compare/10.0.0...10.0.1
+[10.0.0]: https://github.com/shakacode/react_on_rails/compare/9.0.3...10.0.0
 [9.0.3]: https://github.com/shakacode/react_on_rails/compare/9.0.2...9.0.3
 [9.0.2]: https://github.com/shakacode/react_on_rails/compare/9.0.1...9.0.2
 [9.0.1]: https://github.com/shakacode/react_on_rails/compare/9.0.0...9.0.1

data/CONTRIBUTING.md

@@ -223,13 +223,6 @@ Run `rake -T` or `rake -D` to see testing options.
 
 See below for verifying changes to the generators.
 
-### Debugging
-Start the sample app like this for some debug printing:
-
-```sh
-TRACE_REACT_ON_RAILS=true && foreman start
-```
-
 ### Install Generator
 In your Rails app add this gem with a path to your fork.
 

data/Dockerfile_tests

@@ -0,0 +1,12 @@
+FROM dylangrafmyre/docker-ci
+
+WORKDIR /app/
+
+COPY ["/lib/react_on_rails/version.rb", "/app/lib/react_on_rails/"]
+COPY ["Gemfile", "Gemfile.lock", "react_on_rails.gemspec", "rakelib/", "/app/"]
+COPY ["/spec/dummy/Gemfile", "/spec/dummy/Gemfile.lock", "/app/spec/dummy/"]
+RUN  bundle install --gemfile=spec/dummy/Gemfile
+
+ENV DISPLAY :99
+ENTRYPOINT service xvfd start \
+           && rake

data/Gemfile

@@ -9,39 +9,34 @@ gemspec
 # They must be defined here because of the way Travis CI works, in that it will only
 # bundle install from a single Gemfile. Therefore, all gems that we will need for any dummy/example
 # app have to be manually added to this file.
+gem "bootsnap", ">= 1.1.0", require: false
 gem "bootstrap-sass"
-gem "jbuilder", "~> 2.0"
+gem "jbuilder"
 gem "jquery-rails"
 gem "mini_racer"
 gem "puma"
-gem "rails", "5.1.2"
+
 gem "rails_12factor"
-gem "rubocop", "~> 0.50", require: false
 gem "ruby-lint", require: false
-gem "sass-rails", "~> 5.0"
+gem "sass-rails"
 gem "scss_lint", require: false
 gem "sdoc", group: :doc
 gem "spring"
 gem "sqlite3"
-gem "turbolinks", "~> 5.0"
+gem "turbolinks"
 gem "uglifier"
 gem "web-console", group: :development
 
 # below are copied from spec/dummy/Gemfile
 gem "capybara"
 gem "capybara-screenshot"
-gem "rspec-rails"
-gem "rspec-retry"
-# Trouble installing on Sierra
-# gem "capybara-webkit"
 gem "chromedriver-helper"
 gem "launchy"
 gem "poltergeist"
+gem "rspec-rails"
+gem "rspec-retry"
 gem "selenium-webdriver"
-gem "webpacker", "3.0.2"
-
-# TODO: remove once we get out of beta.
-# gem 'webpacker', path: "../../forks/webpacker"
+gem "webpacker"
 
 gem "equivalent-xml", github: "mbklein/equivalent-xml"
 gem "rainbow"

data/NEWS.md

@@ -2,6 +2,8 @@
 
 *We'll keep a history of the news. A few bullets at the top will also show on the [README.md](./README.md).*
 
+* 2018-02-27: **Version 10.1.2** Supports the React API for ReactDOM.hydrate.
+* 2017-09-06: **VERSION 9.0.0 shipped!** This version depends on Webpacker directly. See [Upgrading React on Rails](./docs/basics/upgrading-react-on-rails.md) for more concise instructions on upgrading.
 * Always see the [CHANGELOG.md](./CHANGELOG.md) for the latest project changes.
 * [VERSION 8.1.0](https://rubygems.org/gems/react_on_rails/) shipped with [webpacker_lite](https://github.com/shakacode/webpacker_lite) (soon [**webpacker**](https://github.com/rails/webpacker/issues/464#issuecomment-310986140) support! [react-webpack-rails-tutorial PR #395](https://github.com/shakacode/react-webpack-rails-tutorial/pull/395) shows the changes needed to migrate from the Asset Pipeline to Webpacker Lite. For more information, see my article: [Webpacker Lite: Why Fork Webpacker?](https://blog.shakacode.com/webpacker-lite-why-fork-webpacker-f0a7707fac92). Per recent discussions, we [will merge Webpacker Lite changes back into Webpacker](https://github.com/rails/webpacker/issues/464#issuecomment-310986140). There's no reason to wait for this. The upgrade will eventually be trivial.
 * 2017-04-25: 7.0.0 Shipped! Performance improvements! Please upgrade! Only "breaking" change is that you have to update both the node module and the Ruby gem. 

data/PROJECTS.md

@@ -1,13 +1,21 @@
 # Projects using React on Rails
 
+[Click here](https://publicwww.com/websites/%22react-on-rails%22++-undeveloped.com/) for a search for public sites using React on Rails. 
+
+Public Sites Using React on Rails:
+
+March 27, 2018: 2126<br>
+April 11, 2018: 2138
+
 *Please support the project by [emailing Justin Gordon](mailto:justin@shakacode.com) of any projects, yours or others, that use React on Rails. You can confirm a project uses React on Rails as the source will contain **`js-react-on-rails`**.*
 
 ## Commercial Products Live
-* **[Friends and Guests](https://www.friendsandguests.com/)**, the signature product of [ShakaCode](http://www.shakacode.com), which is a "Network Connecting Hosts and Guests".
+* **[Hawaii Chee](https://www.hawaiichee.com/)**, the signature product of [ShakaCode](http://www.shakacode.com), which is a vacation rental site focusing on Hawaii.
 * **[KissKissBankBank](https://www.kisskissbankbank.com/)**, large French crowdfunding platform.
-* **[Nootrobox](https://nootrobox.com)**: Web ecommerce site for "biohacking" products.
+* **[HVMN](https://hvmn.com)**: Web ecommerce site for "biohacking" products.
 * **[GuavaPass](https://guavapass.com/)**: Coaching client of [ShakaCode](http://www.shakacode.com) and React on Rails fan!
 * **[Pivotal Tracker](http://www.pivotaltracker.com/)**: The first (and most-loved) agile project management tool built on Rails.  React on Rails has greatly simplified integration and workflow for our React components in Rails!
+* **[Estately](https://www.estately.com)**: Home search.
 * **[Blink Inc](https://www.blinkinc.com)**: Website and more built by [ShakaCode](http://www.shakacode.com).
 * **[Madrone Analytics](http://madroneco.com/)**: The original client of [ShakaCode](http://www.shakacode.com) that led to the development of React on Rails, as described in [Fast Rich Client Rails Development With Webpack and the ES6 Transpiler](http://www.railsonmaui.com/blog/2014/10/03/integrating-webpack-and-the-es6-transpiler-into-an-existing-rails-project/).
 * **[Deliveroo](https://deliveroo.co.uk/)**: The leading food delivery site in Europe has gone live with React on Rails, with multi-lingual JavaScript support!