rdstation-ruby-client 1.2.1 → 2.0.0

data/spec/lib/rdstation/fields_spec.rb

@@ -1,12 +1,14 @@
 require 'spec_helper'
 
 RSpec.describe RDStation::Fields do
-  let(:valid_auth_token) { 'valid_auth_token' }
-  let(:rdstation_fields_with_valid_token) { described_class.new(valid_auth_token) }
+  let(:valid_access_token) { 'valid_access_token' }
+  let(:rdstation_fields_with_valid_token) do
+    described_class.new(authorization_header: RDStation::AuthorizationHeader.new(access_token: valid_access_token))
+  end
 
   let(:valid_headers) do
     {
-      'Authorization' => "Bearer #{valid_auth_token}",
+      'Authorization' => "Bearer #{valid_access_token}",
       'Content-Type' => 'application/json'
     }
   end

data/spec/lib/rdstation/webhooks_spec.rb

@@ -1,18 +1,21 @@
 require 'spec_helper'
 
 RSpec.describe RDStation::Webhooks do
-  let(:webhooks_client) { described_class.new('auth_token') }
+  let(:webhooks_client) do
+    described_class.new(authorization_header: RDStation::AuthorizationHeader.new(access_token: 'access_token'))
+  end
+
   let(:webhooks_endpoint) { 'https://api.rd.services/integrations/webhooks/' }
 
   let(:headers) do
     {
-      'Authorization' => 'Bearer auth_token',
+      'Authorization' => 'Bearer access_token',
       'Content-Type' => 'application/json'
     }
   end
 
   let(:error_handler) do
-    instance_double(RDStation::ErrorHandler, raise_errors: 'mock raised errors')
+    instance_double(RDStation::ErrorHandler, raise_error: 'mock raised errors')
   end
 
   before do
@@ -63,9 +66,9 @@ RSpec.describe RDStation::Webhooks do
           .to_return(status: 400, body: { 'errors' => ['all errors'] }.to_json)
       end
 
-      it 'calls raise_errors on error handler' do
+      it 'calls raise_error on error handler' do
         webhooks_client.all
-        expect(error_handler).to have_received(:raise_errors)
+        expect(error_handler).to have_received(:raise_error)
       end
     end
   end
@@ -105,9 +108,9 @@ RSpec.describe RDStation::Webhooks do
           .to_return(status: 400, body: { 'errors' => ['all errors'] }.to_json)
       end
 
-      it 'calls raise_errors on error handler' do
+      it 'calls raise_error on error handler' do
         webhooks_client.by_uuid(uuid)
-        expect(error_handler).to have_received(:raise_errors)
+        expect(error_handler).to have_received(:raise_error)
       end
     end
   end
@@ -154,9 +157,9 @@ RSpec.describe RDStation::Webhooks do
           .to_return(status: 400, body: { 'errors' => ['all errors'] }.to_json)
       end
 
-      it 'calls raise_errors on error handler' do
+      it 'calls raise_error on error handler' do
         webhooks_client.create(payload)
-        expect(error_handler).to have_received(:raise_errors)
+        expect(error_handler).to have_received(:raise_error)
       end
     end
   end
@@ -205,9 +208,9 @@ RSpec.describe RDStation::Webhooks do
           .to_return(status: 400, body: { 'errors' => ['all errors'] }.to_json)
       end
 
-      it 'calls raise_errors on error handler' do
+      it 'calls raise_error on error handler' do
         webhooks_client.update(uuid, new_payload)
-        expect(error_handler).to have_received(:raise_errors)
+        expect(error_handler).to have_received(:raise_error)
       end
     end
   end
@@ -234,9 +237,9 @@ RSpec.describe RDStation::Webhooks do
           .to_return(status: 400, body: { 'errors' => ['all errors'] }.to_json)
       end
 
-      it 'calls raise_errors on error handler' do
+      it 'calls raise_error on error handler' do
         webhooks_client.delete(uuid)
-        expect(error_handler).to have_received(:raise_errors)
+        expect(error_handler).to have_received(:raise_error)
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rdstation-ruby-client
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 2.0.0
 platform: ruby
 authors:
 - Paulo L F Casaretto
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-04-05 00:00:00.000000000 Z
+date: 2019-04-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -116,7 +116,10 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".circleci/config.yml"
+- ".github/ISSUE_TEMPLATE/rdsm-ruby-client-issue-template.md"
 - ".gitignore"
+- ".rspec"
+- CHANGELOG.md
 - Gemfile
 - LICENSE
 - README.md
@@ -124,19 +127,19 @@ files:
 - lib/rdstation-ruby-client.rb
 - lib/rdstation/api_response.rb
 - lib/rdstation/authentication.rb
+- lib/rdstation/authorization_header.rb
 - lib/rdstation/client.rb
 - lib/rdstation/contacts.rb
 - lib/rdstation/error.rb
 - lib/rdstation/error/format.rb
 - lib/rdstation/error/formatter.rb
 - lib/rdstation/error_handler.rb
+- lib/rdstation/error_handler/bad_request.rb
 - lib/rdstation/error_handler/conflicting_field.rb
-- lib/rdstation/error_handler/default.rb
 - lib/rdstation/error_handler/expired_access_token.rb
 - lib/rdstation/error_handler/expired_code_grant.rb
 - lib/rdstation/error_handler/invalid_credentials.rb
 - lib/rdstation/error_handler/invalid_event_type.rb
-- lib/rdstation/error_handler/resource_not_found.rb
 - lib/rdstation/error_handler/unauthorized.rb
 - lib/rdstation/events.rb
 - lib/rdstation/fields.rb
@@ -145,16 +148,16 @@ files:
 - rdstation-ruby-client.gemspec
 - spec/lib/rdstation-ruby-client_spec.rb
 - spec/lib/rdstation/authentication_spec.rb
+- spec/lib/rdstation/authorization_header_spec.rb
+- spec/lib/rdstation/client_spec.rb
 - spec/lib/rdstation/contacts_spec.rb
 - spec/lib/rdstation/error/format_spec.rb
 - spec/lib/rdstation/error/formatter_spec.rb
 - spec/lib/rdstation/error_handler/conflicting_field_spec.rb
-- spec/lib/rdstation/error_handler/default_spec.rb
 - spec/lib/rdstation/error_handler/expired_access_token_spec.rb
 - spec/lib/rdstation/error_handler/expired_code_grant_spec.rb
 - spec/lib/rdstation/error_handler/invalid_credentials_spec.rb
 - spec/lib/rdstation/error_handler/invalid_event_type_spec.rb
-- spec/lib/rdstation/error_handler/resource_not_found_spec.rb
 - spec/lib/rdstation/error_handler/unauthorized_spec.rb
 - spec/lib/rdstation/error_handler_spec.rb
 - spec/lib/rdstation/error_spec.rb
@@ -174,7 +177,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.0.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -188,16 +191,16 @@ summary: Ruby API wrapper for RD Station
 test_files:
 - spec/lib/rdstation-ruby-client_spec.rb
 - spec/lib/rdstation/authentication_spec.rb
+- spec/lib/rdstation/authorization_header_spec.rb
+- spec/lib/rdstation/client_spec.rb
 - spec/lib/rdstation/contacts_spec.rb
 - spec/lib/rdstation/error/format_spec.rb
 - spec/lib/rdstation/error/formatter_spec.rb
 - spec/lib/rdstation/error_handler/conflicting_field_spec.rb
-- spec/lib/rdstation/error_handler/default_spec.rb
 - spec/lib/rdstation/error_handler/expired_access_token_spec.rb
 - spec/lib/rdstation/error_handler/expired_code_grant_spec.rb
 - spec/lib/rdstation/error_handler/invalid_credentials_spec.rb
 - spec/lib/rdstation/error_handler/invalid_event_type_spec.rb
-- spec/lib/rdstation/error_handler/resource_not_found_spec.rb
 - spec/lib/rdstation/error_handler/unauthorized_spec.rb
 - spec/lib/rdstation/error_handler_spec.rb
 - spec/lib/rdstation/error_spec.rb

data/lib/rdstation/error_handler/default.rb

@@ -1,15 +0,0 @@
-module RDStation
-  class ErrorHandler
-    class Default
-      attr_reader :errors
-
-      def initialize(errors)
-        @errors = errors
-      end
-
-      def raise_error
-        raise RDStation::Error::Default, errors.first
-      end
-    end
-  end
-end

data/lib/rdstation/error_handler/resource_not_found.rb

@@ -1,24 +0,0 @@
-module RDStation
-  class ErrorHandler
-    class ResourceNotFound
-      attr_reader :errors
-
-      ERROR_CODE = 'RESOURCE_NOT_FOUND'.freeze
-
-      def initialize(errors)
-        @errors = errors
-      end
-
-      def raise_error
-        return if resource_not_found_errors.empty?
-        raise RDStation::Error::ResourceNotFound, resource_not_found_errors.first
-      end
-
-      private
-
-      def resource_not_found_errors
-        errors.select { |error| error['error_type'] == ERROR_CODE }
-      end
-    end
-  end
-end

data/spec/lib/rdstation/error_handler/default_spec.rb

@@ -1,14 +0,0 @@
-require 'spec_helper'
-
-RSpec.describe RDStation::ErrorHandler::Default do
-  describe '#raise_error' do
-    let(:errors) { [{ 'error_message' => 'Error Message' }] }
-    let(:default_error) { described_class.new(errors) }
-
-    it 'raises the received error' do
-      expect do
-        default_error.raise_error
-      end.to raise_error(RDStation::Error::Default, errors.first['error_message'])
-    end
-  end
-end

data/spec/lib/rdstation/error_handler/resource_not_found_spec.rb

@@ -1,54 +0,0 @@
-require 'spec_helper'
-
-RSpec.describe RDStation::ErrorHandler::ResourceNotFound do
-  describe '#raise_error' do
-
-    subject(:resource_not_found_error) { described_class.new(errors) }
-
-    context 'when there is a resource not found error' do
-      let(:errors) do
-        [
-          {
-            'error_message' => 'Error Message',
-            'error_type' => 'RESOURCE_NOT_FOUND'
-          }
-        ]
-      end
-
-      it 'raises an ResourceNotFound error' do
-        expect do
-          resource_not_found_error.raise_error
-        end.to raise_error(RDStation::Error::ResourceNotFound, 'Error Message')
-      end
-    end
-
-    context 'when none of the errors are resource not found errors' do
-      let(:errors) do
-        [
-          {
-            'error_message' => 'Error Message',
-            'error_type' => 'RANDOM_ERROR_TYPE'
-          },
-          {
-            'error_message' => 'Another Error Message',
-            'error_type' => 'ANOTHER_RANDOM_ERROR_TYPE'
-          }
-        ]
-      end
-
-      it 'does not raise an ResourceNotFound error' do
-        result = resource_not_found_error.raise_error
-        expect(result).to be_nil
-      end
-    end
-
-    context 'when there are no errors' do
-      let(:errors) { [] }
-
-      it 'does not raise an ResourceNotFound error' do
-        result = resource_not_found_error.raise_error
-        expect(result).to be_nil
-      end
-    end
-  end
-end