rdstation-ruby-client 1.2.1 → 2.0.0

data/spec/lib/rdstation/contacts_spec.rb

@@ -11,31 +11,38 @@ RSpec.describe RDStation::Contacts do
   let(:endpoint_with_valid_email) { "https://api.rd.services/platform/contacts/email:#{valid_email}" }
   let(:endpoint_with_invalid_email) { "https://api.rd.services/platform/contacts/email:#{invalid_email}" }
 
-  let(:valid_auth_token) { 'valid_auth_token' }
-  let(:invalid_auth_token) { 'invalid_auth_token' }
-  let(:expired_auth_token) { 'expired_auth_token' }
+  let(:valid_access_token) { 'valid_access_token' }
+  let(:invalid_access_token) { 'invalid_access_token' }
+  let(:expired_access_token) { 'expired_access_token' }
+
+  let(:contact_with_valid_token) do
+    described_class.new(authorization_header: RDStation::AuthorizationHeader.new(access_token: valid_access_token))
+  end
+  let(:contact_with_expired_token) do
+    described_class.new(authorization_header: RDStation::AuthorizationHeader.new(access_token: expired_access_token))
+  end
+  let(:contact_with_invalid_token) do
+    described_class.new(authorization_header: RDStation::AuthorizationHeader.new(access_token: invalid_access_token))
+  end
 
-  let(:contact_with_valid_token) { described_class.new(valid_auth_token) }
-  let(:contact_with_expired_token) { described_class.new(expired_auth_token) }
-  let(:contact_with_invalid_token) { described_class.new(invalid_auth_token) }
 
   let(:valid_headers) do
     {
-      'Authorization' => "Bearer #{valid_auth_token}",
+      'Authorization' => "Bearer #{valid_access_token}",
       'Content-Type' => 'application/json'
     }
   end
 
   let(:invalid_token_headers) do
     {
-      'Authorization' => "Bearer #{invalid_auth_token}",
+      'Authorization' => "Bearer #{invalid_access_token}",
       'Content-Type' => 'application/json'
     }
   end
 
   let(:expired_token_headers) do
     {
-      'Authorization' => "Bearer #{expired_auth_token}",
+      'Authorization' => "Bearer #{expired_access_token}",
       'Content-Type' => 'application/json'
     }
   end
@@ -130,7 +137,7 @@ RSpec.describe RDStation::Contacts do
         it 'raises a not found error' do
           expect do
             contact_with_valid_token.by_uuid(invalid_uuid)
-          end.to raise_error(RDStation::Error::ResourceNotFound)
+          end.to raise_error(RDStation::Error::NotFound)
         end
       end
     end
@@ -193,7 +200,7 @@ RSpec.describe RDStation::Contacts do
         it 'raises a not found error' do
           expect do
             contact_with_valid_token.by_email(invalid_email)
-          end.to raise_error(RDStation::Error::ResourceNotFound)
+          end.to raise_error(RDStation::Error::NotFound)
         end
       end
     end
@@ -228,11 +235,11 @@ RSpec.describe RDStation::Contacts do
   end
 
   describe '#update' do
-    context 'with a valid auth_token' do
-      let(:valid_auth_token) { 'valid_auth_token' }
+    context 'with a valid access_token' do
+      let(:valid_access_token) { 'valid_access_token' }
       let(:headers) do
         {
-          'Authorization' => "Bearer #{valid_auth_token}",
+          'Authorization' => "Bearer #{valid_access_token}",
           'Content-Type' => 'application/json'
         }
       end
@@ -264,16 +271,16 @@ RSpec.describe RDStation::Contacts do
         it 'raises a not found error' do
           expect do
             contact_with_valid_token.update(invalid_uuid, {})
-          end.to raise_error(RDStation::Error::ResourceNotFound)
+          end.to raise_error(RDStation::Error::NotFound)
         end
       end
     end
 
     context 'with an invalid auth token' do
-      let(:invalid_auth_token) { 'invalid_auth_token' }
+      let(:invalid_access_token) { 'invalid_access_token' }
       let(:headers) do
         {
-          'Authorization' => "Bearer #{invalid_auth_token}",
+          'Authorization' => "Bearer #{invalid_access_token}",
           'Content-Type' => 'application/json'
         }
       end
@@ -292,10 +299,10 @@ RSpec.describe RDStation::Contacts do
     end
 
     context 'with an expired auth token' do
-      let(:expired_auth_token) { 'expired_auth_token' }
+      let(:expired_access_token) { 'expired_access_token' }
       let(:headers) do
         {
-          'Authorization' => "Bearer #{expired_auth_token}",
+          'Authorization' => "Bearer #{expired_access_token}",
           'Content-Type' => 'application/json'
         }
       end
@@ -315,12 +322,12 @@ RSpec.describe RDStation::Contacts do
   end
 
   describe '#upsert' do
-    context 'with a valid auth_token' do
-      let(:valid_auth_token) { 'valid_auth_token' }
+    context 'with a valid access_token' do
+      let(:valid_access_token) { 'valid_access_token' }
 
       let(:headers) do
         {
-          'Authorization' => "Bearer #{valid_auth_token}",
+          'Authorization' => "Bearer #{valid_access_token}",
           'Content-Type' => 'application/json'
         }
       end
@@ -352,7 +359,7 @@ RSpec.describe RDStation::Contacts do
         it 'raises a not found error' do
           expect do
             contact_with_valid_token.upsert('email', invalid_email, {})
-          end.to raise_error(RDStation::Error::ResourceNotFound)
+          end.to raise_error(RDStation::Error::NotFound)
         end
       end
 
@@ -371,27 +378,13 @@ RSpec.describe RDStation::Contacts do
           end.to raise_error(RDStation::Error::ConflictingField)
         end
       end
-
-      context 'when an unrecognized error occurs' do
-        before do
-          stub_request(:patch, endpoint_with_valid_email)
-            .with(headers: headers)
-            .to_return(unrecognized_error)
-        end
-
-        it 'raises an default error' do
-          expect do
-            contact_with_valid_token.upsert('email', valid_email, {})
-          end.to raise_error(RDStation::Error::Default)
-        end
-      end
     end
 
     context 'with an invalid auth token' do
-      let(:invalid_auth_token) { 'invalid_auth_token' }
+      let(:invalid_access_token) { 'invalid_access_token' }
       let(:headers) do
         {
-          'Authorization' => "Bearer #{invalid_auth_token}",
+          'Authorization' => "Bearer #{invalid_access_token}",
           'Content-Type' => 'application/json'
         }
       end
@@ -410,10 +403,10 @@ RSpec.describe RDStation::Contacts do
     end
 
     context 'with an expired auth token' do
-      let(:expired_auth_token) { 'expired_auth_token' }
+      let(:expired_access_token) { 'expired_access_token' }
       let(:headers) do
         {
-          'Authorization' => "Bearer #{expired_auth_token}",
+          'Authorization' => "Bearer #{expired_access_token}",
           'Content-Type' => 'application/json'
         }
       end

data/spec/lib/rdstation/error_handler/unauthorized_spec.rb

@@ -21,34 +21,5 @@ RSpec.describe RDStation::ErrorHandler::Unauthorized do
         end.to raise_error(RDStation::Error::Unauthorized, 'Error Message')
       end
     end
-
-    context 'when none of the errors are unauthorized errors' do
-      let(:errors) do
-        [
-          {
-            'error_message' => 'Error Message',
-            'error_type' => 'RANDOM_ERROR_TYPE'
-          },
-          {
-            'error_message' => 'Another Error Message',
-            'error_type' => 'ANOTHER_RANDOM_ERROR_TYPE'
-          }
-        ]
-      end
-
-      it 'does not raise an Unauthorized error' do
-        result = unauthorized_error.raise_error
-        expect(result).to be_nil
-      end
-    end
-
-    context 'when there are no errors' do
-      let(:errors) { [] }
-
-      it 'does not raise an Unauthorized error' do
-        result = unauthorized_error.raise_error
-        expect(result).to be_nil
-      end
-    end
   end
 end

data/spec/lib/rdstation/error_handler_spec.rb

@@ -4,45 +4,158 @@ RSpec.describe RDStation::ErrorHandler do
   describe '#raise_errors' do
     subject(:error_handler) { described_class.new(error_response) }
 
-    context 'when the error type is recognized' do
-      let(:error_response) do
-        OpenStruct.new(
-          code: 400,
-          body: {
+    let(:array_of_errors) do
+      [
+        {
+          'error_type' => 'ERROR_TYPE',
+          'error_message' => 'Error Message',
+          'headers' => { 'error' => 'header' },
+          'http_status' => http_status,
+          'body' => {
             'errors' => {
-              'error_type' => 'CONFLICTING_FIELD',
+              'error_type' => 'ERROR_TYPE',
               'error_message' => 'Error Message'
             }
-          }.to_json
-        )
+          }
+        }
+      ]
+    end
+
+    let(:error_response) do
+      OpenStruct.new(
+        code: http_status,
+        headers: { 'error' => 'header' },
+        body: {
+          'errors' => {
+            'error_type' => 'ERROR_TYPE',
+            'error_message' => 'Error Message'
+          }
+        }.to_json
+      )
+    end
+
+    context 'with an error 400' do
+      let(:http_status) { 400 }
+
+      let(:bad_request_handler) { instance_double(RDStation::ErrorHandler::BadRequest, raise_error: 'raised error') }
+
+      before do
+        allow(RDStation::ErrorHandler::BadRequest).to receive(:new).with(array_of_errors).and_return(bad_request_handler)
       end
 
-      it 'raises the corresponding error class' do
-        expect { error_handler.raise_errors }.to raise_error(RDStation::Error::ConflictingField, 'Error Message')
+      it 'calls the bad request error handler' do
+        error_handler.raise_error
+        expect(bad_request_handler).to have_received(:raise_error)
       end
     end
 
-    context 'when the error type is not recognized' do
-      let(:error_response) do
-        OpenStruct.new(
-          code: 400,
-          headers: { 'Content-Type' => 'application/json' },
-          body: {
-            'errors' => {
-              'error_type' => 'UNRECOGNIZED_ERROR_TYPE',
-              'error_message' => 'Error Message'
-            }
-          }.to_json
-        )
+    context 'with an error 401' do
+      let(:http_status) { 401 }
+
+      let(:unauthorized_handler) { instance_double(RDStation::ErrorHandler::Unauthorized, raise_error: 'raised error') }
+
+      before do
+        allow(RDStation::ErrorHandler::Unauthorized).to receive(:new).with(array_of_errors).and_return(unauthorized_handler)
+      end
+
+      it 'calls the unauthorized error handler' do
+        error_handler.raise_error
+        expect(unauthorized_handler).to have_received(:raise_error)
+      end
+    end
+
+    context 'with an error 403' do
+      let(:http_status) { 403 }
+
+      it 'raises a forbidden error' do
+        expect { error_handler.raise_error }.to raise_error(RDStation::Error::Forbidden, 'Error Message')
+      end
+    end
+
+    context 'with an error 404' do
+      let(:http_status) { 404 }
+
+      it 'raises a not found error' do
+        expect { error_handler.raise_error }.to raise_error(RDStation::Error::NotFound, 'Error Message')
+      end
+    end
+
+    context 'with an error 405' do
+      let(:http_status) { 405 }
+
+      it 'raises a method not allowed error' do
+        expect { error_handler.raise_error }.to raise_error(RDStation::Error::MethodNotAllowed, 'Error Message')
+      end
+    end
+
+    context 'with an error 406' do
+      let(:http_status) { 406 }
+
+      it 'raises a not acceptable error' do
+        expect { error_handler.raise_error }.to raise_error(RDStation::Error::NotAcceptable, 'Error Message')
       end
+    end
+
+    context 'with an error 409' do
+      let(:http_status) { 409 }
+
+      it 'raises a conflict error' do
+        expect { error_handler.raise_error }.to raise_error(RDStation::Error::Conflict, 'Error Message')
+      end
+    end
+
+    context 'with an error 415' do
+      let(:http_status) { 415 }
+
+      it 'raises an unsupported media type error' do
+        expect { error_handler.raise_error }.to raise_error(RDStation::Error::UnsupportedMediaType, 'Error Message')
+      end
+    end
+
+    context 'with an error 422' do
+      let(:http_status) { 422 }
+
+      it 'raises an unprocessable entity error' do
+        expect { error_handler.raise_error }.to raise_error(RDStation::Error::UnprocessableEntity, 'Error Message')
+      end
+    end
+
+    context 'with an error 500' do
+      let(:http_status) { 500 }
+
+      it 'raises an internal server error' do
+        expect { error_handler.raise_error }.to raise_error(RDStation::Error::InternalServerError, 'Error Message')
+      end
+    end
+
+    context 'with an error 501' do
+      let(:http_status) { 501 }
+
+      it 'raises a not implemented error' do
+        expect { error_handler.raise_error }.to raise_error(RDStation::Error::NotImplemented, 'Error Message')
+      end
+    end
+
+    context 'with an error 502' do
+      let(:http_status) { 502 }
+
+      it 'raises a bad gateway error' do
+        expect { error_handler.raise_error }.to raise_error(RDStation::Error::BadGateway, 'Error Message')
+      end
+    end
+
+    context 'with an error 503' do
+      let(:http_status) { 503 }
+
+      it 'raises a service unavailable error' do
+        expect { error_handler.raise_error }.to raise_error(RDStation::Error::ServiceUnavailable, 'Error Message')
+      end
+    end
+    context 'with 5xx error' do
+      let(:http_status) { 505 }
 
-      it 'raises the Default error' do
-        expect { error_handler.raise_errors }.to raise_error(RDStation::Error::Default, 'Error Message') do |error|
-          expect(error.details).to be
-          expect(error.headers).to be
-          expect(error.body).to be
-          expect(error.http_status).to be
-        end
+      it 'raises a server error' do
+        expect { error_handler.raise_error }.to raise_error(RDStation::Error::ServerError, 'Error Message')
       end
     end
   end

data/spec/lib/rdstation/events_spec.rb

@@ -1,13 +1,19 @@
 require 'spec_helper'
 
 RSpec.describe RDStation::Events do
-  let(:valid_auth_token) { 'valid_auth_token' }
-  let(:invalid_auth_token) { 'invalid_auth_token' }
-  let(:expired_auth_token) { 'expired_auth_token' }
+  let(:valid_access_token) { 'valid_access_token' }
+  let(:invalid_access_token) { 'invalid_access_token' }
+  let(:expired_access_token) { 'expired_access_token' }
 
-  let(:event_with_valid_token) { described_class.new(valid_auth_token) }
-  let(:event_with_expired_token) { described_class.new(expired_auth_token) }
-  let(:event_with_invalid_token) { described_class.new(invalid_auth_token) }
+  let(:event_with_valid_token) do
+    described_class.new(authorization_header: RDStation::AuthorizationHeader.new(access_token: valid_access_token))
+  end
+  let(:event_with_expired_token) do
+    described_class.new(authorization_header: RDStation::AuthorizationHeader.new(access_token: expired_access_token))
+  end
+  let(:event_with_invalid_token) do
+    described_class.new(authorization_header: RDStation::AuthorizationHeader.new(access_token: invalid_access_token))
+  end
 
   let(:events_endpoint) { 'https://api.rd.services/platform/events' }
 
@@ -45,21 +51,21 @@ RSpec.describe RDStation::Events do
 
   let(:valid_headers) do
     {
-      'Authorization' => "Bearer #{valid_auth_token}",
+      'Authorization' => "Bearer #{valid_access_token}",
       'Content-Type' => 'application/json'
     }
   end
 
   let(:invalid_token_headers) do
     {
-      'Authorization' => "Bearer #{invalid_auth_token}",
+      'Authorization' => "Bearer #{invalid_access_token}",
       'Content-Type' => 'application/json'
     }
   end
 
   let(:expired_token_headers) do
     {
-      'Authorization' => "Bearer #{expired_auth_token}",
+      'Authorization' => "Bearer #{expired_access_token}",
       'Content-Type' => 'application/json'
     }
   end