rbcurse 1.1.5 → 1.2.0.pre

data/lib/rbcurse/rwidget.rb

@@ -26,19 +26,26 @@ require 'logger'
 #require 'rbcurse/mapper'
 require 'rbcurse/colormap'
 require 'rbcurse/orderedhash'
+require 'rbcurse/rinputdataevent' # for FIELD 2010-09-11 12:31 
 require 'rbcurse/io'
 
-module DSL
-## others may not want this, if = sent, it creates DSL and sets
-  # using this resulted in time lost in bedebugging why some method was not working.
-  def OLD_method_missing(sym, *args)
-    $log.debug "METHOD MISSING : #{sym} #{self} "
-    #if "#{sym}"[-1].chr=="="
-    #  sym = "#{sym}"[0..-2]
-    #else
-    self.class.dsl_accessor sym
-    #end
-    send(sym, *args)
+# some of these will get overriden by ncurses when we include
+KEY_TAB    = 9
+#KEY_BTAB  = 353 # nc gives same
+KEY_RETURN = 13  # Nc gives 343 for KEY_ENTER
+KEY_DELETE = 330
+KEY_BSPACE = 127 # Nc gives 263 for BACKSPACE
+KEY_CC     = 3   # C-c
+
+class Object
+# thanks to terminal-table for this method
+  def yield_or_eval &block
+    return unless block
+    if block.arity > 0 
+      yield self
+    else
+      self.instance_eval(&block)
+    end 
   end
 end
 class Module
@@ -52,6 +59,7 @@ class Module
             @#{sym}
           else
             @#{sym} = val.size == 1 ? val[0] : val
+            # i am itching to deprecate next line XXX
             @config["#{sym}"]=@#{sym}
           end
         end
@@ -59,6 +67,8 @@ class Module
       }
     }
   end
+  # Besides creating getters and setters,  this also fires property change handler
+  # if the value changes, and after the object has been painted once.
   def dsl_property(*symbols)
     symbols.each { |sym|
       class_eval %{
@@ -69,14 +79,18 @@ class Module
             oldvalue = @#{sym}
             @#{sym} = val.size == 1 ? val[0] : val
             newvalue = @#{sym}
+            # i am itching to deprecate next line XXX 
             @config["#{sym}"]=@#{sym}
+            return if oldvalue.nil? || @_object_created.nil?
             if oldvalue != newvalue
-              fire_property_change("#{sym}", oldvalue, newvalue)
+              # trying to reduce calls to fire, when object is being created
+              fire_property_change("#{sym}", oldvalue, newvalue) if !oldvalue.nil?
             end
           end
         end
     #attr_writer sym
         def #{sym}=val
+      # TODO if Variable, take .value NEXT VERSION
            #{sym}(val)
         end
       }
@@ -121,12 +135,14 @@ module RubyCurses
                  "\\1\\3\n") 
       end
       def clean_string! content
-          content.chomp! # don't display newline
-          content.gsub!(/[\t\n]/, '  ') # don't display tab
-          content.gsub!(/[^[:print:]]/, '')  # don't display non print characters
-          content
+        content.chomp! # don't display newline
+        content.gsub!(/[\t\n]/, '  ') # don't display tab
+        content.gsub!(/[^[:print:]]/, '')  # don't display non print characters
+        content
       end
       # needs to move to a keystroke class
+      # please use these only for printing or debugging, not comparing
+      # I could soon return symbols instead 2010-09-07 14:14 
       def keycode_tos keycode
         case keycode
         when 33..126
@@ -140,9 +156,9 @@ module RubyCurses
         when ?\M-0.getbyte(0)..?\M-9.getbyte(0)
           return "M-"+ (keycode-?\M-0.getbyte(0)).to_s
         when 32
-          return "Space"
+          return "space" # changed to lowercase so consistent
         when 27
-          return "Esc"
+          return "esc" # changed to lowercase so consistent
         when ?\C-].getbyte(0)
           return "C-]"
         when 258
@@ -167,6 +183,8 @@ module RubyCurses
           return "M-F"+ (keycode-392).to_s
         when 0
           return "C-space" # i hope this is correct, just guessing
+        when 160
+          return "M-space" # at least on OSX Leopard now (don't remember this working on PPC)
         else
           others=[?\M--,?\M-+,?\M-=,?\M-',?\M-",?\M-;,?\M-:,?\M-\,, ?\M-.,?\M-<,?\M->,?\M-?,?\M-/]
           others.collect! {|x| x.getbyte(0)  }  ## added 2009-10-04 14:25 for 1.9
@@ -180,12 +198,20 @@ module RubyCurses
         end
       end
 
+      # if passed a string in second or third param, will create a color 
+      # and return, else it will return default color
+      # Use this in order to create a color pair with the colors
+      # provided, however, if user has not provided, use supplied
+      # default.
+      # @param [Fixnum] color_pair created by ncurses
+      # @param [Symbol] color name such as white black cyan magenta red green yellow
+      # @param [Symbol] bgcolor name such as white black cyan magenta red green yellow
+      # @example get_color $promptcolor, :white, :cyan
       def get_color default=$datacolor, color=@color, bgcolor=@bgcolor
-        if bgcolor.is_a? String and color.is_a? String
-          acolor = ColorMap.get_color(color, bgcolor)
-        else
-          acolor = default
-        end
+        return default if color.nil? || bgcolor.nil?
+        raise ArgumentError, "Color not valid: #{color}: #{ColorMap.colors} " if !ColorMap.is_color? color
+        raise ArgumentError, "Bgolor not valid: #{bgcolor} : #{ColorMap.colors} " if !ColorMap.is_color? bgcolor
+        acolor = ColorMap.get_color(color, bgcolor)
         return acolor
       end
       ## repeats the given action based on how value of universal numerica argument
@@ -197,55 +223,59 @@ module RubyCurses
         $multiplier = 0
         $inside_multiplier_action = false
       end
- 
-    ##
-    # bind an action to a key, required if you create a button which has a hotkey
-    # or a field to be focussed on a key, or any other user defined action based on key
-    # e.g. bind_key ?\C-x, object, block 
-    # added 2009-01-06 19:13 since widgets need to handle keys properly
-    #  2010-02-24 12:43 trying to take in multiple key bindings, TODO unbind
-    #  TODO add symbol so easy to map from config file or mapping file
-    def bind_key keycode, *args, &blk
-      @key_handler ||= {}
-      if !block_given?
-        blk = args.pop
-        raise "If block not passed, last arg should be a method symbol" if !blk.is_a? Symbol
-        $log.debug " #{@name} bind_key received a symbol #{blk} "
-      end
-      case keycode
-      when String
-        keycode = keycode.getbyte(0) #if keycode.class==String ##    1.9 2009-10-05 19:40 
-        $log.debug " #{name} Widg String called bind_key BIND #{keycode}, #{keycode_tos(keycode)}  "
-        @key_handler[keycode] = blk
-      when Array
-        # for starters lets try with 2 keys only
-        a0 = keycode[0]
-        a0 = keycode[0].getbyte(0) if keycode[0].class == String
-        a1 = keycode[1]
-        a1 = keycode[1].getbyte(0) if keycode[1].class == String
-        @key_handler[a0] ||= OrderedHash.new
-        @key_handler[a0][a1] = blk
-      else
-        @key_handler[keycode] = blk
-      end
-      @key_args ||= {}
-      @key_args[keycode] = args
-    end
-    # e.g. process_key ch, self
-    # returns UNHANDLED if no block for it
-    # after form handles basic keys, it gives unhandled key to current field, if current field returns
-    # unhandled, then it checks this map.
-    # added 2009-01-06 19:13 since widgets need to handle keys properly
-    # added 2009-01-18 12:58 returns ret val of blk.call
-    # so that if block does not handle, the key can still be handled
-    # e.g. table last row, last col does not handle, so it will auto go to next field
-    #  2010-02-24 13:45 handles 2 key combinations, copied from Form, must be identical in logic
-    #  except maybe for window pointer. TODO not tested
-    def _process_key keycode, object, window
-      return :UNHANDLED if @key_handler.nil?
-      blk = @key_handler[keycode]
-      return :UNHANDLED if blk.nil?
-      if blk.is_a? OrderedHash
+
+      ##
+      # bind an action to a key, required if you create a button which has a hotkey
+      # or a field to be focussed on a key, or any other user defined action based on key
+      # e.g. bind_key ?\C-x, object, block 
+      # added 2009-01-06 19:13 since widgets need to handle keys properly
+      #  2010-02-24 12:43 trying to take in multiple key bindings, TODO unbind
+      #  TODO add symbol so easy to map from config file or mapping file
+      def bind_key keycode, *args, &blk
+          $log.debug " #{@name} bind_key received #{keycode} "
+        @key_handler ||= {}
+        if !block_given?
+          blk = args.pop
+          raise "If block not passed, last arg should be a method symbol" if !blk.is_a? Symbol
+          #$log.debug " #{@name} bind_key received a symbol #{blk} "
+        end
+        case keycode
+        when String
+          keycode = keycode.getbyte(0) #if keycode.class==String ##    1.9 2009-10-05 19:40 
+          #$log.debug " #{name} Widg String called bind_key BIND #{keycode}, #{keycode_tos(keycode)}  "
+          @key_handler[keycode] = blk
+        when Array
+          # for starters lets try with 2 keys only
+          raise "A one key array will not work. Pass without array" if keycode.size == 1
+          a0 = keycode[0]
+          a0 = keycode[0].getbyte(0) if keycode[0].class == String
+          a1 = keycode[1]
+          a1 = keycode[1].getbyte(0) if keycode[1].class == String
+          @key_handler[a0] ||= OrderedHash.new
+          @key_handler[a0][a1] = blk
+          #$log.debug "XXX XX assigning #{keycode} to  key_handler " if $log.debug? 
+        else
+          #$log.debug "XXX assigning #{keycode} to  key_handler " if $log.debug? 
+          @key_handler[keycode] = blk
+        end
+        @key_args ||= {}
+        @key_args[keycode] = args
+      end
+      # e.g. process_key ch, self
+      # returns UNHANDLED if no block for it
+      # after form handles basic keys, it gives unhandled key to current field, if current field returns
+      # unhandled, then it checks this map.
+      # added 2009-01-06 19:13 since widgets need to handle keys properly
+      # added 2009-01-18 12:58 returns ret val of blk.call
+      # so that if block does not handle, the key can still be handled
+      # e.g. table last row, last col does not handle, so it will auto go to next field
+      #  2010-02-24 13:45 handles 2 key combinations, copied from Form, must be identical in logic
+      #  except maybe for window pointer. TODO not tested
+      def _process_key keycode, object, window
+        return :UNHANDLED if @key_handler.nil?
+        blk = @key_handler[keycode]
+        return :UNHANDLED if blk.nil?
+        if blk.is_a? OrderedHash
           ch = window.getch
           if ch < 0 || ch > 255
             #next
@@ -257,15 +287,22 @@ module RubyCurses
           return nil if blk1.nil?
           $log.debug " process_key: found block for #{keycode} , #{ch} "
           blk = blk1
+        end
+        #$log.debug "called process_key #{object}, kc: #{keycode}, args  #{@key_args[keycode]}"
+        if blk.is_a? Symbol
+          $log.debug "SYMBOL " if $log.debug? 
+          return send(blk, *@key_args[keycode])
+        else
+          $log.debug "BLOCJ " if $log.debug? 
+          return blk.call object,  *@key_args[keycode]
+        end
+        #0
       end
-      #$log.debug "called process_key #{object}, kc: #{keycode}, args  #{@key_args[keycode]}"
-      if blk.is_a? Symbol
-        return send(blk, *@key_args[keycode])
-      else
-        return blk.call object,  *@key_args[keycode]
+      # view a file or array of strings
+      def view what, config={} # :yields: textview for further configuration
+        require 'rbcurse/extras/viewer'
+        RubyCurses::Viewer.view what, config
       end
-      #0
-    end
     end
 
     module EventHandler
@@ -273,10 +310,13 @@ module RubyCurses
       # bind an event to a block, optional args will also be passed when calling
       def bind event, *xargs, &blk
        #$log.debug "#{self} called EventHandler BIND #{event}, args:#{xargs} "
+          if @_events
+            raise ArgumentError, "#{self.class} does not support this event: #{event}. #{@_events} " if !@_events.include? event
+          else
+            $log.debug "BIND #{self.class}  XXXXX no events defined in @_events. Please do so to avoid bugs and debugging. This will become a fatal error soon."
+          end
         @handler ||= {}
         @event_args ||= {}
-        #@handler[event] = blk
-        #@event_args[event] = xargs
         @handler[event] ||= []
         @handler[event] << blk
         @event_args[event] ||= []
@@ -290,19 +330,36 @@ module RubyCurses
       ##
       # Fire all bindings for given event
       # e.g. fire_handler :ENTER, self
-      # currently object usually contains self which is perhaps a bit of a waste,
-      # could contain an event object with source, and some relevant methods or values
+      # The first parameter passed to the calling block is either self, or some action event
+      # The second and beyond are any objects you passed when using `bind` or `command`.
+      # Exceptions are caught here itself, or else they prevent objects from updating, usually the error is 
+      # in the block sent in by application, not our error.
+      # TODO: if an object throws a subclass of VetoException we should not catch it and throw it back for 
+      # caller to catch and take care of, such as prevent LEAVE or update etc.
       def fire_handler event, object
-        $log.debug " def fire_handler evt:#{event}, o: #{object.class}, hdnler:#{@handler}"
+        $log.debug "inside def fire_handler evt:#{event}, o: #{object.class}, hdnler:#{@handler}"
         if !@handler.nil?
-        #blk = @handler[event]
+          if @_events
+            raise ArgumentError, "#{self.class} does not support this event: #{event}. #{@_events} " if !@_events.include? event
+          else
+            $log.debug "bIND #{self.class}  XXXXX TEMPO no events defined in @_events "
+          end
           ablk = @handler[event]
           if !ablk.nil?
             aeve = @event_args[event]
             ablk.each_with_index do |blk, ix|
               #$log.debug "#{self} called EventHandler firehander #{@name}, #{event}, obj: #{object},args: #{aeve[ix]}"
               $log.debug "#{self} called EventHandler firehander #{@name}, #{event}"
-              blk.call object,  *aeve[ix]
+              begin
+                blk.call object,  *aeve[ix]
+              rescue => ex
+                $log.error "======= Error ERROR in block event #{self}: #{name}, #{event}"
+                $log.error ex
+                $log.error(ex.backtrace.join("\n")) 
+                #$error_message = "#{ex}" # changed 2010  
+                $error_message.value = "#{ex}"
+                Ncurses.beep
+              end
             end
           end # if
         end # if
@@ -311,7 +368,9 @@ module RubyCurses
       # goes with dsl_property
       # Need to inform listeners - done 2010-02-25 23:09 
     def fire_property_change text, oldvalue, newvalue
+      # should i return if oldvalue is nil ??? TODO XXX
       #$log.debug " FPC #{self}: #{text} #{oldvalue}, #{newvalue}"
+      return if oldvalue.nil? || @_object_created.nil? # added 2010-09-16 so if called by methods it is still effective
       if @pce.nil?
         @pce = PropertyChangeEvent.new(self, text, oldvalue, newvalue)
       else
@@ -326,8 +385,8 @@ module RubyCurses
     module ConfigSetup
       # private
       def variable_set var, val
-        nvar = "@#{var}"
-        send("#{var}", val)   # 2009-01-08 01:30 BIG CHANGE calling methods too here.
+        #nvar = "@#{var}"
+        send("#{var}", val) #rescue send("#{var}=", val)    # 2009-01-08 01:30 BIG CHANGE calling methods too here.
         #instance_variable_set(nvar, val)   # we should not call this !!! bypassing 
       end
       def configure(*val , &block)
@@ -361,7 +420,6 @@ module RubyCurses
     # NOTE: I may soon remove the config hash. I don't use it and its just making things heavy.
     # Unless someone convinces me otherwise.
   class Widget
-    include DSL
     include EventHandler
     include ConfigSetup
     include RubyCurses::Utils
@@ -377,11 +435,12 @@ module RubyCurses
     dsl_accessor :focusable, :enabled # boolean
     dsl_property :row, :col            # location of object
     dsl_property :color, :bgcolor      # normal foreground and background
+    dsl_property :color_pair           # instead of colors give just color_pair
     dsl_property :attr                 # attribute bold, normal, reverse
     dsl_accessor :name                 # name to refr to or recall object by_name
     attr_accessor :id #, :zorder
     attr_accessor :curpos              # cursor position inside object - column, not row.
-    attr_reader  :config             # COULD GET AXED SOON NOTE
+    attr_reader  :config             # can be used for popping user objects too
     attr_accessor  :form              # made accessor 2008-11-27 22:32 so menu can set
     attr_accessor :state              # normal, selected, highlighted
     attr_reader  :row_offset, :col_offset # where should the cursor be placed to start with
@@ -397,6 +456,7 @@ module RubyCurses
     ## 2010-01-05 13:27 create buffer conditionally, if enclosing component asks. Needs to be passed down
     ##+ to further children or editor components. Default false.
     attr_accessor  :should_create_buffer              # added  2010-01-05 13:16 BUFFERED, trying to create buffersonly where required.
+    attr_accessor  :_object_created   # 2010-09-16 12:12 to prevent needless property change firing when object being set
     
     ## I think parent_form was not a good idea since i can't add parent widget offsets
     ##+ thus we should use parent_comp and push up.
@@ -404,22 +464,40 @@ module RubyCurses
     # tired of getting the cursor wrong and guessing, i am now going to try to get absolute
     # coordinates - 2010-02-07 20:17 this should be updated by parent.
     attr_accessor :ext_col_offset, :ext_row_offset # 2010-02-07 20:16  to get abs position for cursor
-    #attr_accessor :manages_cursor # does this widget manage cursor, or should form handle it 2010-02-07 20:54 
     attr_accessor :rows_panned # moved from form, how many rows scrolled.panned 2010-02-11 15:26 
     attr_accessor :cols_panned # moved from form, how many cols scrolled.panned 2010-02-11 15:26 
 
+    # sometimes inside a container there's no way of knowing if an individual comp is in focus
+    # other than the explicitly set it and inquire . 2010-09-02 14:47 @since 1.1.5
+    attr_accessor :focussed  # is this widget in focus, so they may paint differently
+
     def initialize form, aconfig={}, &block
       @form = form
-      @bgcolor ||=  "black" # 0
-      @row_offset = @col_offset = 0
+      @row_offset ||= 0
+      @col_offset ||= 0
       @ext_row_offset = @ext_col_offset = 0 # 2010-02-07 20:18 
       @state = :NORMAL
-      @color ||= "white" # $datacolor
       @attr = nil
-      @handler = {}
+
+      @handler = nil # we can avoid firing if nil
       @event_args = {}
       config_setup aconfig # @config.each_pair { |k,v| variable_set(k,v) }
-      instance_eval &block if block_given?
+      #instance_eval &block if block_given?
+      if block_given?
+        if block.arity > 0
+          yield self
+        else
+          self.instance_eval(&block)
+        end
+      end
+      # 2010-09-20 13:12 moved down, so it does not create problems with other who want to set their
+      # own default
+      @bgcolor ||=  "black" # 0
+      @color ||= "white" # $datacolor
+      # These are standard events for most widgets which will be fired by 
+      # Form. In the case of CHANGED, form fires if it's editable property is set, so
+      # it does not apply to all widgets.
+      @_events = [:ENTER, :LEAVE, :CHANGED, :PROPERTY_CHANGE]
   #    @id = form.add_widget(self) if !form.nil? and form.respond_to? :add_widget
       set_form(form) unless form.nil? 
     end
@@ -456,11 +534,17 @@ module RubyCurses
 
     ## got left out by mistake 2008-11-26 20:20 
     def on_enter
-      fire_handler :ENTER, self
+      @focussed = true
+      if @handler && @handler.has_key?(:ENTER)
+        fire_handler :ENTER, self
+      end
     end
     ## got left out by mistake 2008-11-26 20:20 
     def on_leave
-      fire_handler :LEAVE, self
+      @focussed = false
+      if @handler && @handler.has_key?(:LEAVE)
+        fire_handler :LEAVE, self
+      end
     end
     ## 
     # @return row and col of a widget where painting data actually starts
@@ -487,11 +571,12 @@ module RubyCurses
         $log.debug("widget repaint : r:#{r} c:#{c} col:#{@color}" )
         value = getvalue_for_paint
         len = @display_length || value.length
-        if @bgcolor.is_a? String and @color.is_a? String
-          acolor = ColorMap.get_color(@color, @bgcolor)
-        else
-          acolor = $datacolor
-        end
+        acolor = @color_pair || get_color($datacolor, @color, @bgcolor)
+        #if @bgcolor.is_a? String and @color.is_a? String
+          #acolor = ColorMap.get_color(@color, @bgcolor)
+        #else
+          #acolor = $datacolor
+        #end
         @graphic.printstring r, c, "%-*s" % [len, value], acolor, @attr
         # next line should be in same color but only have @att so we can change att is nec
         #@form.window.mvchgat(y=r, x=c, max=len, Ncurses::A_NORMAL, @bgcolor, nil)
@@ -569,6 +654,7 @@ module RubyCurses
     def remove
       @form.remove_widget(self)
     end
+    # is this required can we remove
     def move row, col
       @row = row
       @col = col
@@ -582,14 +668,6 @@ module RubyCurses
         @form.select_field @id
       end
     end
-    def get_color default=$datacolor, _color=@color, _bgcolor=@bgcolor
-      if _bgcolor.is_a? String and _color.is_a? String
-        acolor = ColorMap.get_color(_color, _bgcolor)
-      else
-        acolor = default
-      end
-      return acolor
-    end
     ##
     # bind an action to a key, required if you create a button which has a hotkey
     # or a field to be focussed on a key, or any other user defined action based on key
@@ -648,6 +726,7 @@ module RubyCurses
     def handle_key(ch)
       ret = process_key ch, self
       return :UNHANDLED if ret == :UNHANDLED
+      0
     end
     # @since 0.1.3
     def get_preferred_size
@@ -738,7 +817,7 @@ module RubyCurses
       ##+ so i put current window here.
       if screen == nil
         #$log.debug " XXX calling graphic.wrefresh 2010-01-03 12:27 (parent_buffer was nil) "
-        $log.debug " XXX 2010-01-03 20:47 now copying pad #{@graphic} onto form.window"
+        #$log.debug " XXX 2010-01-03 20:47 now copying pad #{@graphic} onto form.window"
         ret = @graphic.wrefresh
        ## 2010-01-03 20:45 rather than writing to phys screen, i write to forms window
        ##+ so later updates to that window do not overwrite this widget.
@@ -793,17 +872,18 @@ module RubyCurses
      # @since 0.1.3
      #
      def width(*val)
-       #$log.debug " inside XXX width() #{val[0]}"
+       #$log.debug " inside XXX width() #{val}"
        if val.empty?
          return @width
        else
          #$log.debug " inside XXX width()"
          oldvalue = @width || 0 # is this default okay, else later nil cries
-         @width = val.size == 1 ? val[0] : val
+         #@width = val.size == 1 ? val[0] : val
+         @width = val[0]
          newvalue = @width
          @config["width"]=@width
          if oldvalue != newvalue
-           fire_property_change("width", oldvalue, newvalue)
+           fire_property_change(:width, oldvalue, newvalue)
            repaint_all(true)  # added 2010-01-08 18:51 so widgets can redraw everything.
          end
          if is_double_buffered? and newvalue != oldvalue
@@ -832,9 +912,9 @@ module RubyCurses
          oldvalue = @height || 0 # is this default okay, else later nil cries
          @height = val.size == 1 ? val[0] : val
          newvalue = @height
-         @config["height"]=@height
+         @config[:height]=@height
          if oldvalue != newvalue
-           fire_property_change("height", oldvalue, newvalue)
+           fire_property_change(:height, oldvalue, newvalue)
            $log.debug " widget #{@name} setting repaint_all to true"
            @repaint_all=true
          end
@@ -988,6 +1068,10 @@ module RubyCurses
           #
       end
      end
+     def event_list
+       return @@events if defined? @@events
+       nil
+     end
      ##
     ## ADD HERE WIDGET
   end
@@ -1040,11 +1124,11 @@ module RubyCurses
       @focusable = true
       @navigation_policy ||= :CYCLICAL
       instance_eval &block if block_given?
-      @firsttime = true # internal, don't touch
+      @_firsttime = true # internal, don't touch
       ## I need some counter so a widget knows it has been panned and can send a correct
       ##+ cursor coordinate to system.
       @rows_panned = @cols_panned = 0 # how many rows were panned, typically at a higher level
-      @firsttime = true; # added on 2010-01-02 19:21 to prevent scrolling crash ! 
+      @_firsttime = true; # added on 2010-01-02 19:21 to prevent scrolling crash ! 
       @name ||= ""
       $kill_ring ||= [] # 2010-03-09 22:42 so textarea and others can copy and paste emacs EMACS
       $kill_ring_pointer = 0 # needs to be incremented with each append, moved with yank-pop
@@ -1053,6 +1137,11 @@ module RubyCurses
 
       #@allow_alt_digits = true ; # capture Alt-1-9 as digit_args. Set to false if you wish to map
                                  # Alt-1-9 to buttons of tabs 
+      $last_key = 0 # last key pressed @since 1.1.5 (not used yet)
+      $current_key = 0 # curr key pressed @since 1.1.5 (so some containers can behave based on whether
+                    # user tabbed in, or backtabbed in (rmultisplit)
+      $error_message ||= Variable.new ""
+      $key_map ||= :vim ## should this come here or in App or ??? 2010-09-20 23:50 
     end
     ##
     # set this menubar as the form's menu bar.
@@ -1114,28 +1203,15 @@ module RubyCurses
       @widgets.each do |f|
         next if f.visible == false # added 2008-12-09 12:17 
         f.repaint
-        # added 2009-10-29 20:11 for double buffered widgets
-        # this should only happen if painting actually happened
-        #$log.debug " #{self} form repaint parent_buffer (#{@parent_buffer}) if #{f.is_double_buffered?} : #{f.name} "
-        pb = @parent_buffer #|| @window
-        # is next line used 2010-02-05 00:04 its wiping off top in scrollpane in tabbedpane
-        # RFED16 - the next line should never execute now, since no outer object is buffered
-        #+ only those within containers are.
-        # Drat - this line is happeing since components inside a TP are double_buffered
-        #x f.buffer_to_screen(pb) if f.is_double_buffered? 
-      end
-      @window.clear_error # suddenly throwing up on a small pad 2010-03-02 15:22 TPNEW
-      @window.print_status_message $status_message unless $status_message.nil?
-      @window.print_error_message $error_message unless $error_message.nil?
-      $error_message = $status_message = nil
+        f._object_created = true # added 2010-09-16 13:02 now prop handlers can be fired
+      end
       #  this can bomb if someone sets row. We need a better way!
-      if @row == -1 and @firsttime == true
+      if @row == -1 and @_firsttime == true
         #set_field_cursor 0
         #  this part caused an endless loop on 2010-01-02 19:20 when scrollpane scrolled up
-       $log.debug "form repaint calling select field 0 SHOULD HAPPEN FIRST TIME ONLY"
-        #select_field 0
-        req_first_field
-        @firsttime = false
+        #$log.debug "form repaint calling select field 0 SHOULD HAPPEN FIRST TIME ONLY"
+        select_first_field
+        @_firsttime = false
       end
        setpos 
        # XXX this creates a problem if window is a pad
@@ -1144,21 +1220,7 @@ module RubyCurses
        if @window.window_type == :WINDOW
          $log.debug " formrepaint #{@name} calling window.wrefresh #{@window} "
          @window.wrefresh
-       else
-         # UGLY HACK TO MAKE TABBEDPANES WORK !!
-         # If the form is based on a Pad, then it would come here to write the Pad onto the parent_buffer
-         # However, I've obviated the need to handle anything here by adding a display_form after handle_key
-         # in TP.
-         #x if @parent_buffer!=nil
-           #x $log.debug " formrep coming to set backing window part #{@window} , type:#{@window.window_type}, #{@parent_buffer}, #{@parent_buffer.window_type} "
-           # XXX RFED19 do we need at all 2010-02-19 15:26 
-           # this is required so that each key stroke registers on tabbedpane
-           # for this to work both have to be pads
-           #x @window.set_backing_window(@parent_buffer)
-           #x @window.copy_pad_to_win
-           #x @window.wrefresh #since the pads are writing onto window directly, i don't think we need  this
-           #x $log.debug " DO I NEED TO DO SOMETHING HERE FOR TABBEDPANES now ? WARN ?? YES, else keystrokes won't be updated "
-         #x end
+         Ncurses::Panel.update_panels ## added 2010-11-05 00:30 to see if clears the stdscr problems
        end
     end
     ## 
@@ -1174,24 +1236,63 @@ module RubyCurses
       return if r<0 or c<0  # added 2010-01-02 18:49 stack too deep coming if goes above screen
       @window.wmove r,c
     end
+    # @return [Widget, nil] current field, nil if no focusable field
     def get_current_field
       select_next_field if @active_index == -1
       return nil if @active_index.nil?   # for forms that have no focusable field 2009-01-08 12:22 
       @widgets[@active_index]
     end
-    def req_first_field
-      @active_index = -1 # FIXME HACK
-      select_next_field
+    # take focus to first focussable field
+    # we shoud not send to select_next. have a separate method to avoid bugs.
+    # but check current_field, in case called from anotehr field TODO FIXME
+    def select_first_field
+      # this results in on_leave of last field being executed when form starts.
+      #@active_index = -1 # FIXME HACK
+      #select_next_field
+      ix =  index_of_first_focusable_field()
+      return unless ix # no focussable field
+
+      # if the user is on a field other than current then fire on_leave
+      if @active_index.nil? || @active_index < 0
+      elsif @active_index != ix
+        f = @widgets[@active_index]
+        begin
+          #$log.debug " XXX select first field, calling on_leave of #{f} #{@active_index} "
+          on_leave f
+        rescue => err
+         $log.error " Caught EXCEPTION req_first_field on_leave #{err}"
+         Ncurses.beep
+         #$error_message = "#{err}"
+         $error_message.value = "#{err}"
+         return
+        end
+      end
+      select_field ix
     end
-    def req_last_field
+    # please do not use req_ i will deprecate it soon.
+    alias :req_first_field :select_first_field
+    # return the offset of first field that takes focus
+    def index_of_first_focusable_field
+      @widgets.each_with_index do |f, i| 
+        if focusable?(f)
+          #select_field i
+          return i
+        end
+      end
+      nil
+    end
+    # take focus to last field on form
+    def select_last_field
       @active_index = nil 
       select_prev_field
     end
+    # please do not use req_ i will deprecate it soon.
+    alias :req_last_field :select_last_field
     ## do not override
     # form's trigger, fired when any widget loses focus
     #  This wont get called in editor components in tables, since  they are formless XXX
     def on_leave f
-      return if f.nil?
+      return if f.nil? || !f.focusable # added focusable, else label was firing
       f.state = :NORMAL
       # on leaving update text_variable if defined. Should happen on modified only
       # should this not be f.text_var ... f.buffer ? XXX 2008-11-25 18:58 
@@ -1205,7 +1306,7 @@ module RubyCurses
       end
     end
     def on_enter f
-      return if f.nil?
+      return if f.nil? || !f.focusable # added focusable, else label was firing 2010-09
       f.state = :HIGHLIGHTED
       f.modified false
       #f.set_modified false
@@ -1246,9 +1347,10 @@ module RubyCurses
       begin
         on_leave f
       rescue => err
-        $log.debug "form: validate_field caught EXCEPTION #{err}"
-        $log.debug(err.backtrace.join("\n")) 
-        $error_message = "#{err}"
+        $log.error "form: validate_field caught EXCEPTION #{err}"
+        $log.error(err.backtrace.join("\n")) 
+#        $error_message = "#{err}" # changed 2010  
+        $error_message.value = "#{err}"
         Ncurses.beep
         return -1
       end
@@ -1257,19 +1359,21 @@ module RubyCurses
     # put focus on next field
     # will cycle by default, unless navigation policy not :CYCLICAL
     # in which case returns :NO_NEXT_FIELD.
+    # FIXME: in the beginning it comes in as -1 and does an on_leave of last field
     def select_next_field
       return if @widgets.nil? or @widgets.empty?
       $log.debug "insdie sele nxt field :  #{@active_index} WL:#{@widgets.length}" 
-      if @active_index.nil?
+      if @active_index.nil?  || @active_index == -1 # needs to be tested out A LOT
         @active_index = -1 
       else
         f = @widgets[@active_index]
         begin
           on_leave f
         rescue => err
-         $log.debug "select_next_field: caught EXCEPTION #{err}"
-         $log.debug(err.backtrace.join("\n")) 
-         $error_message = "#{err}"
+         $log.error "select_next_field: caught EXCEPTION #{err}"
+         $log.error(err.backtrace.join("\n")) 
+#         $error_message = "#{err}" # changed 2010  
+         $error_message.value = "#{err}"
          Ncurses.beep
          return
         end
@@ -1277,7 +1381,7 @@ module RubyCurses
       index = @active_index + 1
       index.upto(@widgets.length-1) do |i|
         f = @widgets[i]
-        $log.debug "insdie sele nxt field :  i #{i}  #{index} WL:#{@widgets.length}, field #{f}" 
+        #$log.debug "insdie sele nxt field :  i #{i}  #{index} WL:#{@widgets.length}, field #{f}" 
         if focusable?(f)
           select_field i
           return
@@ -1305,6 +1409,8 @@ module RubyCurses
     # put focus on previous field
     # will cycle by default, unless navigation policy not :CYCLICAL
     # in which case returns :NO_PREV_FIELD.
+    # @return [nil, :NO_PREV_FIELD] nil if cyclical and it finds a field
+    #  if not cyclical, and no more fields then :NO_PREV_FIELD
     def select_prev_field
       return if @widgets.nil? or @widgets.empty?
       #$log.debug "insdie sele prev field :  #{@active_index} WL:#{@widgets.length}" 
@@ -1315,8 +1421,10 @@ module RubyCurses
         begin
           on_leave f
         rescue => err
-         $log.debug " cauGHT EXCEPTION #{err}"
+         $log.error " Caught EXCEPTION #{err}"
          Ncurses.beep
+#         $error_message = "#{err}" # changed 2010  
+         $error_message.value = "#{err}"
          return
         end
       end
@@ -1379,27 +1487,6 @@ module RubyCurses
       end
     end
 
-    ## added 2009-12-29 15:46  BUFFERED
-    # Set forms row and col, so that the cursor can be displayed at that point.
-    # Widgets should call this rather than touch row and col
-    # directly. This should percolate the row and col
-    # upwards to parent forms, after comparing to prevent 
-    # infinite recursion.
-    # This is being done for embedded objects so that the cursor
-    # can be maintained correctly.
-    def OLDsetrowcol r, c
-      @row = r unless r.nil?
-      @col = c unless c.nil?
-           r +=  @add_rows unless r.nil? # 2010-01-26 20:31 
-           c +=  @add_cols unless c.nil? # 2010-01-26 20:31 
-           $log.debug " addcols #{@add_cols} addrow #{@add_rows} : #{self}  "
-      if !@parent_form.nil? and @parent_form != self
-        $log.debug " (#{@name}) calling parents setrowcol #{r}, #{c} : pare: #{@parent_form}; self:  #{self}, #{self.class}  "
-        r += @parent_form.window.top unless  r.nil?
-        c += @parent_form.window.left unless c.nil?
-        @parent_form.setrowcol r, c
-      end
-    end
     ## Form
     # New attempt at setting cursor using absolute coordinates
     # Also, trying NOT to go up. let this pad or window print cursor.
@@ -1417,32 +1504,6 @@ module RubyCurses
       end
     end
   ##
-  # bind an action to a key, required if you create a button which has a hotkey
-  # or a field to be focussed on a key, or any other user defined action based on key
-  # e.g. bind_key ?\C-x, object, block
-    # 1.9 if string passed then getbyte so user does not need to change much and
-    # less chance of error 2009-10-04 16:08 
-  def OLDbind_key keycode, *args, &blk
-      @key_handler ||= {}
-      case keycode
-      when String
-        $log.debug "FORM String called bind_key BIND #{keycode} #{keycode_tos(keycode)}  "
-        keycode = keycode.getbyte(0) #if keycode.class==String ##    1.9 2009-10-05 19:40 
-        @key_handler[keycode] = blk
-      when Array
-        # for starters lets try with 2 keys only
-        a0 = keycode[0]
-        a0 = keycode[0].getbyte(0) if keycode[0].class == String
-        a1 = keycode[1]
-        a1 = keycode[1].getbyte(0) if keycode[1].class == String
-        @key_handler[a0] ||= OrderedHash.new
-        @key_handler[a0][a1] = blk
-      else
-        @key_handler[keycode] = blk
-      end
-      @key_args ||= {}
-      @key_args[keycode] = args
-  end
 
   # e.g. process_key ch, self
   # returns UNHANDLED if no block for it
@@ -1452,29 +1513,6 @@ module RubyCurses
   def process_key keycode, object
     return _process_key keycode, object, @window
   end
-      #return :UNHANDLED if @key_handler.nil?
-      #blk = @key_handler[keycode]
-      #return :UNHANDLED if blk.nil?
-      #if blk.is_a? OrderedHash
-        ## Please note that this does not wait too long, you have to press next key fast
-        ## since i have set halfdelay in ncurses.rb, test this with getchar to get more keys TODO
-          #ch = @window.getch
-          #if ch < 0 || ch > 255
-            ##next
-            #return nil
-          #end
-          #$log.debug " process_key: got #{keycode} , #{ch} "
-          #yn = ch.chr
-          #blk1 = blk[ch]
-          #return nil if blk1.nil?
-          #$log.debug " process_key: found block for #{keycode} , #{ch} "
-          #blk = blk1
-      #end
-      #$log.debug "called process_key #{object}, kc: #{keycode}, args  #{@key_args[keycode]}"
-     ## return blk.call object,  *@key_args[keycode]
-    #blk.call object,  *@key_args[keycode]
-    #0
-  #end
   # Defines how user can give numeric args to a command even in edit mode
   # User either presses universal_argument (C-u) which generates a series of 4 16 64.
   # Or he presses C-u and then types some numbers. Followed by the action.
@@ -1561,9 +1599,19 @@ module RubyCurses
           end
         end
 
+        $current_key = ch
         case ch
         when -1
           return
+        when Ncurses::KEY_RESIZE # SIGWINCH
+          lines = Ncurses.LINES
+          cols = Ncurses.COLS
+          x = Ncurses.stdscr.getmaxy
+          y = Ncurses.stdscr.getmaxx
+          $log.debug " form RESIZE HK #{ch} #{self}, #{@name}, #{ch}  "
+          alert "SIGWINCH WE NEED TO RECALC AND REPAINT resize #{lines}, #{cols}: #{x}, #{y} "
+          Ncurses.endwin
+          @window.wrefresh
         else
           keycode = keycode_tos(ch)
           $log.debug " form HK #{ch} #{self}, #{@name}, #{keycode}  "
@@ -1573,11 +1621,11 @@ module RubyCurses
           # some widgets like textarea and list handle up and down
           if handled == :UNHANDLED or handled == -1 or field.nil?
             case ch
-            when 9, ?\M-\C-i.getbyte(0)  # tab and M-tab in case widget eats tab (such as Table)
+            when KEY_TAB, ?\M-\C-i.getbyte(0)  # tab and M-tab in case widget eats tab (such as Table)
               ret = select_next_field
               return ret if ret == :NO_NEXT_FIELD
               # alt-shift-tab  or backtab (in case Table eats backtab)
-            when 353, 481 ## backtab added 2008-12-14 18:41 
+            when KEY_BTAB, 481 ## backtab added 2008-12-14 18:41 
               ret = select_prev_field
               return ret if ret == :NO_PREV_FIELD
             when KEY_UP
@@ -1599,6 +1647,7 @@ module RubyCurses
             #when ?\M-K.getbyte(0)
               #field.height -= 1
             else
+              #$log.debug "XXX before calling process_key in form #{ch}  " if $log.debug? 
               ret = process_key ch, self
               $log.debug " process_key #{ch} got ret #{ret} in #{self} "
               return :UNHANDLED if ret == :UNHANDLED
@@ -1607,6 +1656,7 @@ module RubyCurses
         end
        $log.debug " form before repaint #{self} , #{@name}, ret #{ret}"
        repaint
+       $last_key = ch
        #return handled # TRYNG 2010-03-01 23:30 since TP returns NO_NEXT_FIELD sometimes
        #$multiplier = 0
   end
@@ -1641,6 +1691,49 @@ module RubyCurses
   # 2010-02-07 14:50 to aid in debugging and comparing log files.
   def to_s; @name || self; end
 
+  # NOTE: very experimental, use at risk, can change location or be deprec
+  # place given widget below given one, or last added one
+  # Does not check for availability or overlap
+  def place_below me, other=nil
+    w = widgets
+    if other.nil?
+      other = w[-1]
+      # if user calls this after placing this field
+      other = w[-2] if other == me
+    end
+    if other.height.nil? || other.height == 0
+      h = 1
+    else
+      h = other.height
+    end
+    me.row = other.row + h
+    me.col = other.col
+    me
+  end
+  # NOTE: very experimental, use at risk, can change location or be deprec
+  # return location to place next widget (below)
+  # Does not check for availability or overlap
+  def next_position
+    w = widgets.last
+    if w.height.nil? || w.height == 0
+      h = 1
+    else
+      h = w.height
+    end
+    row = w.row + h
+    col = w.col
+    return row, col
+  end
+  ## so if we come back from ncurses cooked mode we can repaint.
+  # not required, we have to stop and restart ncurses. 
+  #def reset_all
+    #$log.debug " form reset:#{self}, #{@name} , r #{@row} c #{@col} "
+    #@widgets.each do |f|
+      #next if f.visible == false # added 2008-12-09 12:17 
+      #f.repaint_all()
+    #end
+  #end
+
     ## ADD HERE FORM
   end
   ## Created and sent to all listeners whenever a property is changed
@@ -1666,8 +1759,13 @@ module RubyCurses
 
   ##
   # Text edit field
-  # To get value use getvalue() 
+  # NOTE: To get value use getvalue() 
   # TODO - test text_variable
+  # TODO: some methods should return self, so chaining can be done. Not sure if the return value of the 
+  #   fire_handler is being checked.
+  #   NOTE: i have just added repain_required check in Field before repaint
+  #   this may mean in some places field does not paint. repaint_require will have to be set
+  #   to true in those cases. this was since field was overriding a popup window that was not modal.
   #  
   class Field < Widget
     dsl_accessor :maxlen             # maximum length allowed into field
@@ -1699,24 +1797,37 @@ module RubyCurses
       @form = form
       @buffer = String.new
       #@type=config.fetch("type", :varchar)
-      @display_length = config.fetch("display_length", 20)
-      @maxlen=config.fetch("maxlen", @display_length) 
-      @row = config.fetch("row", 0)
-      @col = config.fetch("col", 0)
-      @bgcolor = config.fetch("bgcolor", $def_bg_color)
-      @color = config.fetch("color", $def_fg_color)
-      @name = config.fetch("name", nil)
-      @editable = config.fetch("editable", true)
-      @focusable = config.fetch("focusable", true)
-      @handler = {}
+      # 2010-10-19 12:26 slight change, hopefully won't bomb
+      @display_length = 20
+      @maxlen = @display_length
+      @row = 0
+      @col = 0
+      @bgcolor = $def_bg_color
+      @color = $def_fg_color
+      #@name = config.fetch("name", nil)
+      @editable = true
+      @focusable = true
+      # are these redundant ?
+      #@display_length = config.fetch("display_length", 20)
+      #@maxlen=config.fetch("maxlen", @display_length) 
+      #@row = config.fetch("row", 0)
+      #@col = config.fetch("col", 0)
+      #@bgcolor = config.fetch("bgcolor", $def_bg_color)
+      #@color = config.fetch("color", $def_fg_color)
+      #@name = config.fetch("name", nil)
+      #@editable = config.fetch("editable", true)
+      #@focusable = config.fetch("focusable", true)
       @event_args = {}             # arguments passed at time of binding, to use when firing event
+      map_keys 
       init_vars
       super
+      @_events.push(:CHANGE)
     end
     def init_vars
       @pcol = 0   # needed for horiz scrolling
       @curpos = 0                  # current cursor position in buffer
       @modified = false
+      @repaint_required = true
     end
     def text_variable tv
       @text_variable = tv
@@ -1725,18 +1836,25 @@ module RubyCurses
     ##
     # define a datatype, currently only influences chars allowed
     # integer and float. what about allowing a minus sign? XXX
+    #  2010-09-10 20:59 changed string to symbol
     def type dtype
+      return if !@chars_allowed.nil?
       case dtype.to_s.downcase
-      when 'integer'
-        @chars_allowed = /\d/ if @chars_allowed.nil?
-      when 'numeric'
-        @chars_allowed = /[\d\.]/ if @chars_allowed.nil?
-      when 'alpha'
-        @chars_allowed = /[a-zA-Z]/ if @chars_allowed.nil?
-      when 'alnum'
-        @chars_allowed = /[a-zA-Z0-9]/ if @chars_allowed.nil?
-      end
-    end
+      when :integer
+        @chars_allowed = /\d/
+      when :numeric, :float
+        @chars_allowed = /[\d\.]/ 
+      when :alpha
+        @chars_allowed = /[a-zA-Z]/ 
+      when :alnum
+        @chars_allowed = /[a-zA-Z0-9]/ 
+      end
+    end
+    # add a char to field, and validate
+    # NOTE: this should return self for chaining operations and throw an exception
+    # if disabled or exceeding size
+    # @param [char] a character to add
+    # @return [Fixnum] 0 if okay, -1 if not editable or exceeding length
     def putch char
       return -1 if !@editable 
       return -1 if !@overwrite_mode and @buffer.length >= @maxlen
@@ -1744,15 +1862,23 @@ module RubyCurses
         return if char.match(@chars_allowed).nil?
       end
       # added insert or overwrite mode 2010-03-17 20:11 
+      oldchar = nil
       if @overwrite_mode
+        oldchar = @buffer[@curpos] 
         @buffer[@curpos] = char
       else
         @buffer.insert(@curpos, char)
       end
+      oldcurpos = @curpos
       @curpos += 1 if @curpos < @maxlen
       @modified = true
-      $log.debug " FIELD FIRING CHANGE: #{char} at new #{@curpos}: bl:#{@buffer.length} buff:[#{@buffer}]"
-      fire_handler :CHANGE, self    # 2008-12-09 14:51 
+      #$log.debug " FIELD FIRING CHANGE: #{char} at new #{@curpos}: bl:#{@buffer.length} buff:[#{@buffer}]"
+      # i have no way of knowing what change happened and what char was added deleted or changed
+      #fire_handler :CHANGE, self    # 2008-12-09 14:51 
+      if @overwrite_mode
+        fire_handler :CHANGE, InputDataEvent.new(oldcurpos,@curpos, self, :DELETE, 0, oldchar) # 2010-09-11 12:43 
+      end
+      fire_handler :CHANGE, InputDataEvent.new(oldcurpos,@curpos, self, :INSERT, 0, char) # 2010-09-11 12:43 
       0
     end
 
@@ -1769,24 +1895,31 @@ module RubyCurses
             end
           end
           set_modified 
+          return 0 # 2010-09-11 12:59 else would always return -1
         end
       end
       return -1
     end
     def delete_at index=@curpos
       return -1 if !@editable 
-      @buffer.slice!(index,1)
-      $log.debug " delete at #{index}: #{@buffer.length}: #{@buffer}"
+      char = @buffer.slice!(index,1)
+      #$log.debug " delete at #{index}: #{@buffer.length}: #{@buffer}"
       @modified = true
-      fire_handler :CHANGE, self    # 2008-12-09 14:51 
+      #fire_handler :CHANGE, self    # 2008-12-09 14:51 
+      fire_handler :CHANGE, InputDataEvent.new(@curpos,@curpos, self, :DELETE, 0, char)     # 2010-09-11 13:01 
     end
     ## 
-    # should this do a dup ??
+    # should this do a dup ?? YES
     def set_buffer value
+      @repaint_required = true
       @datatype = value.class
       #$log.debug " FIELD DATA #{@datatype}"
-      @buffer = value.to_s
+      @delete_buffer = @buffer.dup
+      @buffer = value.to_s.dup
       @curpos = 0
+      # XXX hope @delete_buffer is not overwritten
+      fire_handler :CHANGE, InputDataEvent.new(@curpos,@curpos, self, :DELETE, 0, @delete_buffer)     # 2010-09-11 13:01 
+      fire_handler :CHANGE, InputDataEvent.new(@curpos,@curpos, self, :INSERT, 0, @buffer)     # 2010-09-11 13:01 
     end
     # converts back into original type
     #  changed to convert on 2009-01-06 23:39 
@@ -1804,11 +1937,22 @@ module RubyCurses
       end
     end
   
+    # create a label linked to this field
+    # Typically one passes a Label, but now we can pass just a String, a label 
+    # is created
+    # @param [Label, String] label object to be associated with this field
   def set_label label
+    # added case for user just using a string
+    case label
+    when String
+      # what if no form at this point
+      label = Label.new @form, {:text => label}
+    end
     @label = label
     label.row  @row if label.row == -1
     label.col  @col-(label.name.length+1) if label.col == -1
     label.label_for(self)
+    label
   end
 
   ## Note that some older widgets like Field repaint every time the form.repaint
@@ -1816,7 +1960,8 @@ module RubyCurses
   ##+ currently I've not implemented events with these widgets. 2010-01-03 15:00 
 
   def repaint
-    $log.debug("repaint FIELD: #{id}, #{name},  #{focusable}")
+    return unless @repaint_required  # 2010-11-20 13:13 its writing over a window i think TESTING
+    #$log.debug("repaint FIELD: #{id}, #{name},  #{focusable}")
     #return if display_length <= 0 # added 2009-02-17 00:17 sometimes editor comp has 0 and that
     # becomes negative below, no because editing still happens
     @display_length = 1 if display_length == 0
@@ -1830,28 +1975,47 @@ module RubyCurses
       end
     end
     #printval = printval[0..display_length-1] if printval.length > display_length
-    if @bgcolor.is_a? String and @color.is_a? String
-      acolor = ColorMap.get_color(@color, @bgcolor)
-    else
-      acolor = $datacolor
-    end
+    acolor = @color_pair || get_color($datacolor, @color, @bgcolor)
+    #if @bgcolor.is_a? String and @color.is_a? String
+      #acolor = ColorMap.get_color(@color, @bgcolor)
+    #else
+      #acolor = $datacolor
+    #end
     @graphic = @form.window if @graphic.nil? ## cell editor listbox hack XXX fix in correct place
-    $log.debug " Field g:#{@graphic}. r,c,displen:#{@row}, #{@col}, #{@display_length} "
+    #$log.debug " Field g:#{@graphic}. r,c,displen:#{@row}, #{@col}, #{@display_length} "
     @graphic.printstring  row, col, sprintf("%-*s", display_length, printval), acolor, @attr
+    @repaint_required = false # 2010-11-20 13:13 
   end
   def set_focusable(tf)
     @focusable = tf
   end
+  def map_keys
+    return if @keys_mapped
+    bind_key(KEY_LEFT){ cursor_backward }
+    bind_key(KEY_RIGHT){ cursor_forward }
+    bind_key(KEY_BACKSPACE){ delete_prev_char }
+    bind_key(127){ delete_prev_char }
+    bind_key(330){ delete_curr_char }
+    bind_key(?\C-a){ cursor_home }
+    bind_key(?\C-e){ cursor_end }
+    bind_key(?\C-k){ delete_eol }
+    bind_key(?\C-_){ undo_delete_eol }
+    bind_key(27){ set_buffer @original_value }
+    @keys_mapped = true
+  end
 
   # field
+  # # TODO bind these keys so they can be overridden
   def handle_key ch
+    @repaint_required = true # added 2010-11-20 13:21 
+    #map_keys unless @keys_mapped # moved to init
     case ch
-    when KEY_LEFT
-      cursor_backward
-    when KEY_RIGHT
-      cursor_forward
-    when KEY_BACKSPACE, 127
-      delete_prev_char if @editable
+    #when KEY_LEFT
+      #cursor_backward
+    #when KEY_RIGHT
+      #cursor_forward
+    #when KEY_BACKSPACE, 127
+      #delete_prev_char if @editable
     #when KEY_UP
     #  $log.debug " FIELD GOT KEY_UP, NOW IGNORING 2009-01-16 17:52 "
       #@form.select_prev_field # in a table this should not happen 2009-01-16 17:47 
@@ -1860,32 +2024,39 @@ module RubyCurses
     #  $log.debug " FIELD GOT KEY_DOWN, NOW IGNORING 2009-01-16 17:52 "
       #@form.select_next_field # in a table this should not happen 2009-01-16 17:47 
     #  return :UNHANDLED
-    when KEY_ENTER, 10, 13
-      if respond_to? :fire
-        fire
-      end
-    when 330
-      delete_curr_char if @editable
-    when ?\C-a.getbyte(0)
-      cursor_home 
-    when ?\C-e.getbyte(0)
-      cursor_end 
-    when ?\C-k.getbyte(0)
-      delete_eol if @editable
-    when ?\C-_.getbyte(0) # changed on 2010-02-26 14:44 so C-u can be used as numeric arg
-      @buffer.insert @curpos, @delete_buffer unless @delete_buffer.nil?
+      # user cannot bind here or on form if i eat up
+    #when KEY_ENTER, 10, 13
+      #if respond_to? :fire
+        #fire
+      #end
+    #when 330
+      #delete_curr_char if @editable
+    #when ?\C-a.getbyte(0)
+      #cursor_home 
+    #when ?\C-e.getbyte(0)
+      #cursor_end 
+    #when ?\C-k.getbyte(0)
+      #delete_eol if @editable
+    #when ?\C-_.getbyte(0) # changed on 2010-02-26 14:44 so C-u can be used as numeric arg
+      #undo_delete_eol
     when 32..126
       #$log.debug("FIELD: ch #{ch} ,at #{@curpos}, buffer:[#{@buffer}] bl: #{@buffer.to_s.length}")
       putc ch
-    when 27 # escape
-      $log.debug " ADDED FIELD ESCAPE on 2009-01-18 12:27 XXX #{@original_value}"
-      set_buffer @original_value 
+    #when 27 # escape
+      #set_buffer @original_value 
     else
       ret = super
       return ret
     end
     0 # 2008-12-16 23:05 without this -1 was going back so no repaint
   end
+  # does an undo on delete_eol, not a real undo
+  def undo_delete_eol
+    return if @delete_buffer.nil?
+    #oldvalue = @buffer
+    @buffer.insert @curpos, @delete_buffer 
+    fire_handler :CHANGE, InputDataEvent.new(@curpos,@curpos+@delete_buffer.length, self, :INSERT, 0, @delete_buffer)     # 2010-09-11 13:01 
+  end
   ## 
   # position cursor at start of field
   def cursor_home
@@ -1912,7 +2083,8 @@ module RubyCurses
     @delete_buffer = @buffer[@curpos..-1]
     # if pos is 0, pos-1 becomes -1, end of line!
     @buffer = pos == -1 ? "" : @buffer[0..pos]
-    fire_handler :CHANGE, self    # 2008-12-09 14:51 
+    #fire_handler :CHANGE, self    # 2008-12-09 14:51 
+    fire_handler :CHANGE, InputDataEvent.new(@curpos,@curpos+@delete_buffer.length, self, :DELETE, 0, @delete_buffer)     # 2010-09-11 13:01 
     return @delete_buffer
   end
   def cursor_forward
@@ -2009,6 +2181,21 @@ module RubyCurses
     def modified?
       getvalue() != @original_value
     end
+    # field, a convenience method, since set_buffer sucks, it was "inspired" by ncurses itself
+    # @since 1.2.0
+    def text(*val)
+      if val.empty?
+        return getvalue()
+      else
+        return unless val # added 2010-11-17 20:11, dup will fail on nil
+        s = val[0].dup
+        set_buffer(s)
+      end
+    end
+    def text=(val)
+      return unless val # added 2010-11-17 20:11, dup will fail on nil
+      set_buffer(val.dup)
+    end
   # ADD HERE FIELD
   end
         
@@ -2116,6 +2303,7 @@ module RubyCurses
   ##
   # the preferred way of printing text on screen, esp if you want to modify it at run time.
   # Use display_length to ensure no spillage.
+  # This can use text or text_variable for setting and getting data (inh from Widget).
   class Label < Widget
     #dsl_accessor :label_for   # related field or buddy
     dsl_accessor :mnemonic    # keyboard focus is passed to buddy based on this key (ALT mask)
@@ -2153,9 +2341,9 @@ module RubyCurses
     # for other widgets, attempt to change focus to that field
     def bind_hotkey
       if !@mnemonic.nil?
-        ch = @mnemonic.downcase()[0].ord   ## FIXME 1.9 DONE 
+        ch = @mnemonic.downcase()[0].ord   ##  1.9 DONE 
         # meta key 
-        mch = ?\M-a.getbyte(0) + (ch - ?a.getbyte(0))  ## FIXME 1.9
+        mch = ?\M-a.getbyte(0) + (ch - ?a.getbyte(0))  ## 1.9
         if @label_for.is_a? RubyCurses::Button and @label_for.respond_to? :fire
           @form.bind_key(mch, @label_for) { |_form, _butt| _butt.fire }
         else
@@ -2170,7 +2358,8 @@ module RubyCurses
     def repaint
       return unless @repaint_required
         r,c = rowcol
-        value = getvalue_for_paint
+        # value often nil so putting blank, but usually some application error
+        value = getvalue_for_paint || ""
         lablist = []
         if @height && @height > 1
           lablist = wrap_text(value, @display_length).split("\n")
@@ -2191,7 +2380,7 @@ module RubyCurses
         str = @justify.to_sym == :right ? "%*s" : "%-*s"  # added 2008-12-22 19:05 
         # loop added for labels that are wrapped.
         # TODO clear separately since value can change in status like labels
-        $log.debug " RWID 1595 #{self.class} value: #{value} form:  #{form} "
+        #$log.debug " RWID 1595 #{self.class} value: #{value} form:  #{form} "
         @graphic = @form.window if @graphic.nil? ## HACK messagebox givig this in repaint, 423 not working ??
         0.upto(_height-1) { |i| 
           @graphic.printstring r+i, c, " " * len , acolor,@attr
@@ -2216,12 +2405,15 @@ module RubyCurses
   end
   ##
   # action buttons
+  # NOTE: When firing event, an ActionEvent will be passed as the first parameter, followed by anything
+  # you may have passed when binding, or calling the command() method. 
   # TODO: phasing out underline, and giving mnemonic and ampersand preference
   #  - Action: may have to listen to Action property changes so enabled, name etc change can be reflected
   class Button < Widget
     dsl_accessor :surround_chars   # characters to use to surround the button, def is square brackets
     dsl_accessor :mnemonic
     def initialize form, config={}, &block
+      require 'rbcurse/ractionevent'
       @focusable = true
       @editable = false
       @handler={} # event handler
@@ -2231,6 +2423,7 @@ module RubyCurses
       @color ||= $datacolor 
       @surround_chars ||= ['[ ', ' ]'] 
       @col_offset = @surround_chars[0].length 
+      @_events.push :PRESS
     end
     ##
     # set button based on Action
@@ -2241,7 +2434,7 @@ module RubyCurses
       command { a.call }
     end
     ##
-    # sets text, checking for ampersand, uses that for hotkey and underlines
+    # button:  sets text, checking for ampersand, uses that for hotkey and underlines
     def text(*val)
       if val.empty?
         return @text
@@ -2271,15 +2464,6 @@ module RubyCurses
       @form.bind_key(mch, self) { |_form, _butt| _butt.fire }
     end
     ##
-    # which index to use as underline.
-    # Instead of using this to make a hotkey, I am thinking of giving this a new usage.
-    # If you wish to override the underline?
-    # @deprecated . use mnemonic or an ampersand in text.
-    def OLDunderline ix
-      _value = @text || getvalue # hack for Togglebutton FIXME
-      raise "#{self}: underline requires text to be set " if _value.nil?
-      mnemonic _value[ix]
-    end
     # bind hotkey to form keys. added 2008-12-15 20:19 
     # use ampersand in name or underline
     def bind_hotkey
@@ -2287,7 +2471,7 @@ module RubyCurses
       _value = @text || getvalue # hack for Togglebutton FIXME
       #_value = getvalue
       $log.debug " bind hot #{_value} #{@underline}"
-      ch = _value[@underline,1].downcase()[0].ord ## XXX 1.9  2009-10-05 18:55  TOTEST
+      ch = _value[@underline,1].downcase()[0].ord ##  1.9  2009-10-05 18:55  TOTEST
       @mnemonic = _value[@underline,1]
       # meta key 
       mch = ?\M-a.getbyte(0) + (ch - ?a.getbyte(0))
@@ -2327,18 +2511,21 @@ module RubyCurses
         @graphic.printstring r, c, "%-*s" % [len, value], color, @attr
 #       @form.window.mvchgat(y=r, x=c, max=len, Ncurses::A_NORMAL, bgcolor, nil)
         # in toggle buttons the underline can change as the text toggles
-        if !@underline.nil? or !@mnemonic.nil?
+        if @underline || @mnemonic
           uline = @underline && (@underline + @text_offset) ||  value.index(@mnemonic) || value.index(@mnemonic.swapcase)
-          $log.debug " mvchgat UNDERLI r= #{r} - #{@graphic.top} c #{c} c+x #{c+uline}- #{@graphic.left} #{@graphic} "
+          #$log.debug " mvchgat UNDERLI r= #{r} - #{@graphic.top} c #{c} c+x #{c+uline}- #{@graphic.left} #{@graphic} "
           #$log.debug " XXX HACK in next line related to UNDERLINES -graphic.top"
-          y=r #-@graphic.top
-          x=c+uline #-@graphic.left
-          if @graphic.window_type == :PAD
-            x -= @graphic.left
-            y -= @graphic.top
+          # if the char is not found don't print it
+          if uline
+            y=r #-@graphic.top
+            x=c+uline #-@graphic.left
+            if @graphic.window_type == :PAD
+              x -= @graphic.left
+              y -= @graphic.top
+            end
+            raise "button underline location error #{x} , #{y} " if x < 0 or c < 0
+            @graphic.mvchgat(y, x, max=1, Ncurses::A_BOLD|Ncurses::A_UNDERLINE, color, nil)
           end
-          raise "button underline location error #{x} , #{y} " if x < 0 or c < 0
-          @graphic.mvchgat(y, x, max=1, Ncurses::A_BOLD|Ncurses::A_UNDERLINE, color, nil)
         end
     end
     ## command of button (invoked on press, hotkey, space)
@@ -2350,7 +2537,9 @@ module RubyCurses
     ## fires PRESS event of button
     def fire
       $log.debug "firing PRESS #{text}"
-      fire_handler :PRESS, @form
+      # why the .... am i passing form ? Pass a ActionEvent with source, text() and getvalue()
+      #fire_handler :PRESS, @form XXX changed on 2010-09-12 19:22 
+      fire_handler :PRESS, ActionEvent.new(self, :PRESS, text)
     end
     # Button
     def handle_key ch
@@ -2431,6 +2620,9 @@ module RubyCurses
     def getvalue
       @value ? @onvalue : @offvalue
     end
+    # added for some standardization 2010-09-07 20:28 
+    # alias :text :getvalue # NEXT VERSION
+    # change existing text to label
     ##
     # is the button on or off
     # added 2008-12-09 19:05 
@@ -2440,7 +2632,12 @@ module RubyCurses
     alias :selected? :checked?
 
     def getvalue_for_paint
-      buttontext = getvalue()
+      unless @display_length
+        if @onvalue && @offvalue
+          @display_length = [ @onvalue.length, @offvalue.length ].max
+        end
+      end
+      buttontext = getvalue().center(@display_length)
       @text_offset = @surround_chars[0].length
       @surround_chars[0] + buttontext + @surround_chars[1]
     end
@@ -2456,6 +2653,8 @@ module RubyCurses
     def toggle
       fire
     end
+    # called on :PRESS event
+    # caller should check state of itemevent passed to block
     def fire
       checked(!@value)
       # added ItemEvent on 2008-12-31 13:44