rbcurse 1.1.5 → 1.2.0.pre

data/lib/rbcurse/rtabbedpane.rb

@@ -160,6 +160,7 @@ module RubyCurses
       @col_offset = 2;  @row_offset = 1 # added 2010-01-10 22:54 
       @recreate_buttons = true
       install_keys
+      @_events.push(*[:OPEN, :INSERT, :DELETE])
     end
     def install_keys
       @form.bind_key([?d, ?d]) { ix = highlighted_tab_index; repeatm { remove_tab(ix) } }
@@ -508,9 +509,9 @@ module RubyCurses
           # We need to convert it so the main form can use it
           if @current_tab != @form
           if ret == :UNHANDLED
-            if ch == 9 #or ch == KEY_DOWN
+            if ch == KEY_TAB #or ch == KEY_DOWN
               ret = :NO_NEXT_FIELD
-            elsif ch == 353 #or ch == KEY_UP # btab
+            elsif ch == KEY_BTAB #or ch == KEY_UP # btab
               ret = :NO_PREV_FIELD
             end
           end

data/lib/rbcurse/rtabbedwindow.rb

@@ -75,7 +75,6 @@ module RubyCurses
     end
   end
   class TabbedWindow
-    include DSL
     include EventHandler
     dsl_accessor :row, :col
     dsl_accessor :height, :width

data/lib/rbcurse/rtable.rb

@@ -66,28 +66,43 @@ module RubyCurses
     attr_reader :editing_col, :editing_row  # r and col being edited, set to nil on leave
     attr_accessor :is_editing # boolean is only true if cell_editing_allowed
     dsl_accessor :editing_policy   # :EDITING_AUTO
+    dsl_accessor :size_to_fit   # boolean, will size columns upon set data just to fit
+    dsl_accessor :estimate_widths   # boolean, will size columns upon set data
     
     # A table should only be editable if this is true regardless of other variables
     # In addition, A column to be editable must either have editable as nil or true
     dsl_accessor :cell_editing_allowed # 2009-01-16 22:55 
 
     def initialize form = nil, config={}, &block
+      _data = config.delete :data
+      _columns = config.delete :columns
+      @_column_widths = config.delete :column_widths
+      # if user leaves width blank but gives us col widths, that means calculate total width
+      if @_column_widths && config[:width].nil?
+        total = @_column_widths.inject(0) { |total, w| total+=w }
+        @width = total+2
+      end
+      @suppress_borders = false
+      @col_offset = @row_offset = 1
+
       super
+      @_events.push(*[:TABLE_TRAVERSAL_EVENT,:TABLE_EDITING_EVENT])
       init_vars
       install_list_keys
       install_keys_bindings
       ## create_buffer needs to move to repaint. widget needs values to use when i creates buffer in repaint.
+      if _data && _columns
+        set_data _data, _columns
+      end
     end
 
     def init_vars
-      @col_offset = @row_offset = 1
       @focusable= true
       @current_index = 0
       @current_column = 0
       @oldrow = @oldcol = 0
       @current_column_offset ||= 0 # added 2009-01-12 19:06 current_column's offset
       @toprow = 0
-      @to_print_borders ||= 1
       @show_grid ||= 1
       @_first_column_print = 0 # intro for horiz scrolling 2009-02-14 16:20 
       @_last_column_print = 0 # 2009-02-16 23:57 so we don't tab further etc. 
@@ -96,6 +111,7 @@ module RubyCurses
       @inter_column_spacing = 1
       # @selected_color ||= 'yellow'
       # @selected_bgcolor ||= 'black'
+      @col_offset = @row_offset = 0 if @suppress_borders
       @table_changed = true
       @repaint_required = true
     end
@@ -105,8 +121,8 @@ module RubyCurses
       # alt-shift-tab prev column
       #bind_key(?\M-\C-i) { next_column }
       #bind_key(481) { previous_column }
-      bind_key(9) { next_column }
-      bind_key(353) { previous_column }
+      bind_key(KEY_TAB) { next_column }
+      bind_key(KEY_BTAB) { previous_column }
       bind_key(KEY_RIGHT) { next_column }
       bind_key(KEY_LEFT) { previous_column }
       bind_key(@KEY_ASK_FIND_FORWARD) { ask_search_forward }
@@ -142,8 +158,11 @@ module RubyCurses
     end
     # added 2009-01-07 13:05 so new scrollable can use
     def scrollatrow
-      #@height -3
-      @height -4 # we forgot to remove 1 from height in border.
+      if @suppress_borders # NOT TESTED XXX
+        @height - 2 # we forgot to remove 1 from height in border.
+      else
+        @height - 4 # we forgot to remove 1 from height in border.
+      end
     end
 
     # 
@@ -153,6 +172,8 @@ module RubyCurses
       # next 2 added in case set_data called again
       @table_changed = true
       @repaint_required = true
+      data ||= [[]]
+      colnames_array ||= [""]
       if data.is_a? Array
         model = RubyCurses::DefaultTableModel.new data, colnames_array
         table_model model
@@ -171,6 +192,19 @@ module RubyCurses
       end
       create_default_list_selection_model
       create_table_header
+      # added 2010-09-09 19:57 if user provides col widths in hash, or size_to_fit
+        $log.debug " XXX @size_to_fit: #{@size_to_fit} "
+      if @_column_widths
+        $log.debug "XXXX inside set column widths "
+        set_column_widths @_column_widths
+      elsif @estimate_widths
+        $log.debug "XXXX inside estimate column widths "
+        cw = estimate_column_widths data
+        set_column_widths cw
+      elsif @size_to_fit
+        $log.debug " XXX inside  @size_to_fit: #{@size_to_fit} "
+        size_columns_to_fit
+      end
     end
     def set_model tm, tcm=nil, lsm=nil
       table_model tm
@@ -632,7 +666,6 @@ module RubyCurses
       $multiplier = 0
       bounds_check
     end
-    #def next_row
     # goto next row
     # added multipler 2010-05-12 20:51 
     def next_row num=(($multiplier.nil? or $multiplier == 0) ? 1 : $multiplier)
@@ -640,7 +673,6 @@ module RubyCurses
       @oldrow = @current_index
       # don't go on if rc 2009-01-16 19:55  XXX
       if @current_index < rc
-        #@current_index += 1 
         @current_index += 1*num if @current_index < rc
         bounds_check
       end
@@ -746,7 +778,7 @@ module RubyCurses
     def bounds_check
       h = scrollatrow()
       rc = row_count
-      #$log.debug " PRE CURR:#{@current_index}, TR: #{@toprow} RC: #{rc} H:#{h}"
+
       @current_index = 0 if @current_index < 0  # not lt 0
       @current_index = rc-1 if @current_index >= rc # not gt rowcount
       @toprow = rc-h-1 if rc > h and @toprow > rc - h - 1 # toprow shows full page if possible
@@ -757,14 +789,14 @@ module RubyCurses
         # curr has gone above table,  move toprow up
         @toprow = @current_index
       end
-      #$log.debug " POST CURR:#{@current_index}, TR: #{@toprow} RC: #{rc} H:#{h}"
+
       if @oldrow != @current_index
         #$log.debug "going to call on leave and on enter"
         on_leave_row @oldrow #if respond_to? :on_leave_row     # to be defined by widget that has included this
         on_enter_row @current_index   #if respond_to? :on_enter_row  # to be defined by widget that has included this
       end
       set_form_row
-      @oldrow = @current_index # added 2009-01-16 19:43 XXX
+      @oldrow = @current_index 
       @repaint_required = true
     end
     def on_leave_row arow
@@ -858,7 +890,7 @@ module RubyCurses
       @win_left = my_win.left # unused remove TODO
       @win_top = my_win.top
 
-      print_border @graphic if @to_print_borders == 1 # do this once only, unless everything changes
+      print_border @graphic if !@suppress_borders  # do this once only, unless everything changes
       return if @table_model.nil? # added 2009-02-17 12:45 
       @_first_column_print ||= 0
       cc = @table_model.column_count
@@ -1104,9 +1136,26 @@ module RubyCurses
     # using the command: @columns, *rows = @db.execute2(command)
     # @param - datatypes is an array returned by following command to DB
     # @datatypes = @content[0].types 
-    def estimate_column_widths columns, datatypes
+    def estimate_column_widths columns, datatypes=nil
       tablewidth = @width-3
       colwidths = {}
+      unless datatypes
+        datatypes = []
+        row = columns[0]
+        $log.debug " XXX row: #{row} "
+
+        row.each do |c| 
+          $log.debug " XXX c: #{c} "
+          case c
+          when Fixnum, Integer
+            datatypes << "int"
+          when Date, Time
+            datatypes << "date"
+          else
+            datatypes << "varchar"
+          end
+        end
+      end
       min_column_width = (tablewidth/columns.length) -1
       $log.debug("min: #{min_column_width}, #{tablewidth}")
       0.upto(20) do |rowix|
@@ -1116,7 +1165,7 @@ module RubyCurses
         @table_column_model.each_with_index do |acolumn, ix|
           col = get_value_at(rowix, ix)
           colwidths[ix] ||= 0
-          colwidths[ix] = [colwidths[ix], col.length].max
+          colwidths[ix] = [colwidths[ix], col.to_s.length].max
         end
       end
       total = 0
@@ -1133,7 +1182,9 @@ module RubyCurses
       column_widths = colwidths
       @max_data_widths = column_widths.dup
 
+      $log.debug "XXXX datatypes #{datatypes} "
       columns.each_with_index do | col, i|
+       break if datatypes[i].nil?
       if datatypes[i].match(/(real|int)/) != nil
         wid = column_widths[i]
         #   cw = [column_widths[i], [8,min_column_width].min].max
@@ -1164,6 +1215,7 @@ module RubyCurses
     # sets column widths given an array of ints
     # You may get such an array from estimate_column_widths
     def set_column_widths cw
+      raise "Cannot call set_column_widths till table set" unless @table_column_model
       tcm = @table_column_model
       tcm.each_with_index do |col, ix|
         col.width cw[ix]
@@ -1182,6 +1234,7 @@ module RubyCurses
     def accomodate_delta delta
       tcm = @table_column_model
       cc = tcm.column_count 
+      return if cc == 0
       average = (delta/cc).ceil
       total = 0
       tcm.each do |col|
@@ -1245,6 +1298,7 @@ module RubyCurses
       @header_value = header_value
       @config={}
       instance_eval &block if block_given?
+      @_events = [:PROPERTY_CHANGE]
     end
     def fire_property_change(text, oldval, newval)
       #$log.debug "TC: def fire_property_change(#{text}, #{oldval}, #{newval})"
@@ -1307,6 +1361,7 @@ module RubyCurses
       ##cols.each_with_index {|c, index| @columns << TableColumn.new(index, c, c, 10) }
       cols.each_with_index {|c, index| add_column(TableColumn.new(index, c, c, 10)) }
       @selected_columns = []
+      @_events = [:TABLE_COLUMN_MODEL_EVENT, :PROPERTY_CHANGE]
     end
     def column ix
       raise "Invalid arg #{ix}" if ix < 0 or ix > (@columns.length() -1)
@@ -1419,6 +1474,7 @@ module RubyCurses
       def initialize data, colnames_array
         @data = data
         @column_identifiers = colnames_array
+        @_events = [:TABLE_MODEL_EVENT, :PROPERTY_CHANGE]
       end
       def column_count
          # 2010-01-12 19:35  changed count to size since size is supported in 1.8.6 also
@@ -1469,11 +1525,30 @@ module RubyCurses
         return ret
       end
       def delete_at row
-        ret = @data.delete_at row
+        if !$multiplier or $multiplier == 0 
+          @delete_buffer = @data.delete_at row
+        else
+          @delete_buffer = @data.slice!(row, $multiplier)
+        end
+        $multiplier = 0
+        #ret = @data.delete_at row
         # create tablemodelevent and fire_table_changed for all listeners 
-        tme = TableModelEvent.new(row, row,:ALL_COLUMNS,  self, :DELETE)
+        # we don;t pass buffer to event as in listeditable. how to undo later?
+        tme = TableModelEvent.new(row, row+@delete_buffer.length,:ALL_COLUMNS,  self, :DELETE)
         fire_handler :TABLE_MODEL_EVENT, tme
-        return ret
+        return @delete_buffer
+      end
+      # a quick method to undo deletes onto given row. More like paste
+      def undo where
+        return unless @delete_buffer
+        case @delete_buffer[0]
+        when Array
+        @delete_buffer.each do |r| 
+          insert where, r 
+        end
+        else
+          insert where, @delete_buffer
+        end
       end
       ## 
       # added 2009-01-17 21:36 
@@ -1546,53 +1621,6 @@ module RubyCurses
     end # class  DTC
 
     ##
-    # LSM 
-    # XXX UNUSED
-    class OLDDefaultListSelectionModel
-      include RubyCurses::EventHandler 
-      attr_accessor :selection_mode
-      attr_reader :anchor_selection_index
-      attr_reader :lead_selection_index
-      def initialize
-        @selected_indices=[]
-        @anchor_selection_index = -1
-        @lead_selection_index = -1
-        @selection_mode = :MULTIPLE
-        $log.debug " OLD VERSION OF LIST SELECTION MODEL IN rtable.rb"
-      end
-
-      def clear_selection
-        @selected_indices=[]
-      end
-      def is_selected_index ix
-        @selected_indices.include? ix
-      end
-      def get_max_selection_index
-        @selected_indices[-1]
-      end
-      def get_min_selection_index
-        @selected_indices[0]
-      end
-      def get_selected_rows
-        @selected_indices
-      end
-      ## TODO should go in sorted, and no dupes
-      def add_selection_interval ix0, ix1
-        @anchor_selection_index = ix0
-        @lead_selection_index = ix1
-        ix0.upto(ix1) {|i| @selected_indices  << i unless @selected_indices.include? i }
-      end
-      def remove_selection_interval ix0, ix1
-        @anchor_selection_index = ix0
-        @lead_selection_index = ix1
-        @selected_indices.delete_if {|x| x >= ix0 and x <= ix1}
-      end
-      def insert_index_interval ix0, len
-        @anchor_selection_index = ix0
-        @lead_selection_index = ix0+len
-        add_selection_interval @anchor_selection_index, @lead_selection_index
-      end
-    end # class DefaultListSelectionModel
     ##
     # Class that manages Table's Header
     # are we not taking events such as column added, removed ?

data/lib/rbcurse/rtextarea.rb

@@ -57,22 +57,19 @@ module RubyCurses
       @col = 0
       @curpos = 0
       @list = []
-      super
+      @suppress_borders = false
       @row_offset = @col_offset = 1 # for cursor display on first entry, so not positioned on border
+      super
       @orig_col = @col
       # this does result in a blank line if we insert after creating. That's required at 
       # present if we wish to only insert
       if @list.empty?
       #  @list << "\r"   # removed this on 2009-02-15 17:25 lets see how it goes
       end
-     # @scrollatrow = @height-2
       @content_rows = @list.length
-      #@win = @form.window
       @win = @graphic # 2009-12-26 14:54 BUFFERED  replace form.window with graphic
-    #  init_scrollable
-      #print_borders
       # 2010-01-10 19:35 compute locally if not set
-      #@maxlen ||= @width-2
+      @_events.push :CHANGE
       install_keys
       init_vars
     end
@@ -82,18 +79,19 @@ module RubyCurses
       @toprow = @current_index = @pcol = 0
       @repaint_all=true 
       ## 2010-02-12 12:20 RFED16 taking care if no border requested
-      @suppress_borders ||= false
       @row_offset = @col_offset = 0 if @suppress_borders == true
       # added 2010-02-11 15:11 RFED16 so we don't need a form.
       @win_left = 0
       @win_top = 0
       @longest_line = 0
+      # if borders used, reduce 2 from width else 0
+      @internal_width = 2
+      @internal_width = 2 if @suppress_borders
       bind_key(?\M-w, :kill_ring_save)
       bind_key(?\C-y, :yank)
       bind_key(?\M-y, :yank_pop)
       bind_key(?\M-\C-w, :append_next_kill)
-      bind_key(?\M-d, :delete_word)
-      bind_key(?\M-f, :forward_word)
+      map_keys
     end
     def rowcol
     #  $log.debug "textarea rowcol : #{@row+@row_offset+@winrow}, #{@col+@col_offset}"
@@ -107,7 +105,7 @@ module RubyCurses
     end
     # private
     def wrap_text(txt, col = @maxlen)
-       col ||= @width - 2
+       col ||= @width - @internal_width
       #$log.debug "inside wrap text for :#{txt}"
       txt.gsub(/(.{1,#{col}})( +|$\n?)|(.{1,#{col}})/,
                "\\1\\3\n") 
@@ -115,7 +113,7 @@ module RubyCurses
     ## 
     # trying to wrap and insert
     def insert off0, data
-       _maxlen = @maxlen || @width - 2
+       _maxlen = @maxlen || @width - @internal_width
       if data.length > _maxlen
         data = wrap_text data
       #  $log.debug "after wrap text done :#{data}"
@@ -135,7 +133,7 @@ module RubyCurses
     # Typically a line is sent in. We wrap and put a hard return at end.
     def << data
       # if width if nil, either set it, or add this to a container that sets it before calling this method
-      _maxlen = @maxlen || @width - 2
+      _maxlen = @maxlen || @width - @internal_width
       if data.length > _maxlen
         #$log.debug "wrapped append for #{data}"
         data = wrap_text data
@@ -199,7 +197,13 @@ module RubyCurses
     end
     # private
     def print_title
-      @graphic.printstring( @row, @col+(@width-@title.length)/2, @title, $datacolor, @title_attrib) unless @title.nil?
+      # truncate title if longer than width
+      return unless @title
+      _title = @title
+      if @title.length > @width - 2
+        _title = @title[0..@width-2]
+      end
+      @graphic.printstring( @row, @col+(@width-_title.length)/2, _title, $datacolor, @title_attrib) unless @title.nil?
     end
     # text_area print footer
     def print_foot
@@ -228,14 +232,40 @@ module RubyCurses
       
       #return unless @repaint_required # 2010-02-12 19:08  TRYING - won't let footer print if only col move
       paint if @repaint_required
-      print_foot if @print_footer && (@repaint_footer_required || @repaint_required)
+      print_foot if @print_footer && !@suppress_borders && (@repaint_footer_required || @repaint_required)
       buffer_to_window # 2010-02-12 14:54 RFED16
     end
     def getvalue
       @list
     end
+
+    def map_keys
+      return if @keys_mapped
+      bind_key(KEY_LEFT){ cursor_backward }
+      bind_key(KEY_RIGHT){ cursor_forward }
+      bind_key(KEY_UP){ up }
+      bind_key(KEY_DOWN){ down }
+      bind_key(?\C-a){ cursor_bol }
+      bind_key(?\C-e){ cursor_eol }
+      bind_key(?\C-n) { scroll_forward }
+      bind_key(?\C-p) { scroll_backward }
+      bind_key(?\C-[) { goto_start }
+      bind_key(?\C-]) { goto_end }
+
+      bind_key(KEY_BACKSPACE){ delete_prev_char if @editable }
+      bind_key(KEY_BSPACE){ delete_prev_char if @editable}
+      bind_key(?\M-d, :delete_word)
+      bind_key(?\M-f, :forward_word)
+
+      #bind_key(127){ delete_prev_char }
+      bind_key(330){ delete_curr_char if @editable }
+      #bind_key(?\C-k){ delete_eol }
+      #bind_key(?\C-_){ undo_delete_eol }
+      #bind_key(27){ set_buffer @original_value }
+      @keys_mapped = true
+    end
+
     # textarea
-    
     def handle_key ch
       @current_key = ch # I need some funcs to know what key they were mapped to
       @buffer = @list[@current_index]
@@ -251,40 +281,27 @@ module RubyCurses
       # in sqlc on pressing Clear.
       # if buffer is nil and user wants to enter something -- added UNHANDLED
       return :UNHANDLED if @buffer.nil?
-      $log.debug "TA: before: curpos #{@curpos} blen: #{@buffer.length}"
+      #$log.debug "TA: before: curpos #{@curpos} blen: #{@buffer.length}"
       # on any line if the cursor is ahead of buffer length, ensure its on last position
       # what if the buffer is somehow gt maxlen ??
       if @curpos > @buffer.length
         addcol(@buffer.length-@curpos)+1
         @curpos = @buffer.length
       end
-      $log.debug "TA: after : curpos #{@curpos} blen: #{@buffer.length}, w: #{@width} max #{@maxlen}"
-      #pre_key
+      #$log.debug "TA: after : curpos #{@curpos} blen: #{@buffer.length}, w: #{@width} max #{@maxlen}"
+      
       case ch
-      when ?\C-n.getbyte(0)
-        scroll_forward
-      when ?\C-p.getbyte(0)
-        scroll_backward
-      when ?\C-[.getbyte(0)
-        goto_start #cursor_start of buffer
-      when ?\C-].getbyte(0)
-        goto_end # cursor_end of buffer
-      when KEY_UP
-        #select_prev_row
-        ret = up
-      when KEY_DOWN
-        ret = down
-      when KEY_ENTER, 10, 13
+      when KEY_ENTER, 10, KEY_RETURN
         insert_break
-      when KEY_LEFT
-        cursor_backward
-      when KEY_RIGHT
-        cursor_forward
-      when KEY_BACKSPACE, 127
+      #when KEY_LEFT
+        #cursor_backward
+      #when KEY_RIGHT
+        #cursor_forward
+      when KEY_BACKSPACE, KEY_BSPACE
         if @editable   # checking here means that i can programmatically bypass!!
           delete_prev_char 
         end
-      when 330, ?\C-d.getbyte(0) # delete char
+      when KEY_DELETE, ?\C-d.getbyte(0) # delete char
         if @editable
           delete_curr_char 
         end
@@ -293,7 +310,7 @@ module RubyCurses
         # Earlier behavior was based on alpine which leaves a blank line
         if @editable
           #if @buffer == ""
-          if @buffer.chomp == "" or @curpos == 0
+          if @buffer.chomp == "" || @curpos == 0
             delete_line
           else
             delete_eol 
@@ -313,11 +330,11 @@ module RubyCurses
       when ?\C-r.getbyte(0) # redo if UndoHandler installed
         return unless @undo_handler
         @undo_handler.redo
-      when ?\C-a.getbyte(0)
-        cursor_bol
-      when ?\C-e.getbyte(0)
-        cursor_eol
-        #set_form_col @buffer.length
+      #when ?\C-a.getbyte(0)
+        #cursor_bol
+      #when ?\C-e.getbyte(0)
+        #cursor_eol
+        
       #when @KEY_ASK_FIND_FORWARD
       #  ask_search_forward
       #when @KEY_ASK_FIND_BACKWARD
@@ -336,7 +353,7 @@ module RubyCurses
         if ret == :UNHANDLED
           # check for bindings, these cannot override above keys since placed at end
           ret = process_key ch, self
-          $log.debug "TA process_key #{ch} got ret #{ret} in #{@name} "
+          #$log.debug "TA process_key #{ch} got ret #{ret} in #{@name} "
           return :UNHANDLED if ret == :UNHANDLED
         end
       end
@@ -491,7 +508,7 @@ module RubyCurses
         up
         return
       end
-      _maxlen = @maxlen || @width - 2
+      _maxlen = @maxlen || @width - @internal_width
       space_left = _maxlen - prevlen
       # prev line is full exit
       return if space_left == 0
@@ -567,7 +584,7 @@ module RubyCurses
         up
         return
       end
-      _maxlen = @maxlen || @width - 2
+      _maxlen = @maxlen || @width - @internal_width
       space_left = _maxlen - prev.length
       # BUG. carry full words up, or if no space then bring down last word of prev lien and join with first
       carry_up = words_in_length @buffer, space_left #@buffer[0..space_left] # XXX
@@ -619,14 +636,18 @@ module RubyCurses
     # I have modified it to push all words that are exceeding maxlen.
     # This was needed for if i push 10 chars to next line, and the last word is less then the line will 
     # exceed. So i must push as many words as exceed length.
+    # 2010-09-07 22:31 this must not return nil, or previous will crash. This happens if no space in line.
     def push_last_word lineno=@current_index
-       _maxlen = @maxlen || @width - 2
+       _maxlen = @maxlen || @width - @internal_width
       #lastspace = @buffer.rindex(" ")
       #lastspace = @list[lineno].rindex(/ \w/)
       line = @list[lineno]
       line = @list[lineno][0.._maxlen+1] if line.length > _maxlen
       lastspace = line.rindex(/ \w/)
       $log.debug " PUSH:2 #{lastspace},#{line},"
+      # fix to ensure something returned 2010-09-07 22:40 
+      lastspace = _maxlen-1 unless lastspace # added 2010-09-07 22:29  XXXX
+
       if !lastspace.nil?
         lastchars = @list[lineno][lastspace+1..-1]
         @list[lineno] = @list[lineno][0..lastspace]
@@ -653,7 +674,7 @@ module RubyCurses
     # this attempts to recursively insert into a row, seeing that any stuff exceeding is pushed down further.
     # Yes, it should check for a para end and insert. Currently it could add to next para.
     def insert_wrap lineno, pos, lastchars
-       _maxlen = @maxlen || @width - 2
+       _maxlen = @maxlen || @width - @internal_width
       @list[lineno].insert pos, lastchars 
       len = @list[lineno].length 
       if len > _maxlen
@@ -663,7 +684,7 @@ module RubyCurses
     ## 
     # add one char. careful, i shoved a string in yesterday.
     def putch char
-       _maxlen = @maxlen || @width - 2
+       _maxlen = @maxlen || @width - @internal_width
       @buffer ||= @list[@current_index]
       return -1 if !@editable #or @buffer.length >= _maxlen
       #if @chars_allowed != nil # remove useless functionality
@@ -715,7 +736,16 @@ module RubyCurses
 
     def putc c
       if c >= 32 and c <= 126
-        ret = putch c.chr
+        begin
+          ret = putch c.chr
+        rescue => ex
+          # this does not prevent entry, it prevents updating
+          # often comes here if error in event block, not our fault
+          Ncurses.beep
+          $log.debug " ERROR IN PUTCH RTEXTAREA  "
+          $log.debug( ex) if ex
+          $log.debug(ex.backtrace.join("\n")) if ex
+        end
         if ret == 0
         # addcol 1
           set_modified 
@@ -735,7 +765,7 @@ module RubyCurses
     def move_chars_up
       oldprow = @current_index
       oldcurpos = @curpos
-       _maxlen = @maxlen || @width - 2
+       _maxlen = @maxlen || @width - @internal_width
       space_left = _maxlen - @buffer.length
       can_move = [space_left, next_line.length].min
       carry_up =  @list[@current_index+1].slice!(0, can_move)
@@ -761,7 +791,7 @@ module RubyCurses
       @form.modified = true if tf and !@form.nil?
     end
     def cursor_eol
-       _maxlen = @maxlen || @width - 2
+       _maxlen = @maxlen || @width - @internal_width
       $log.error "ERROR !!! bufferlen gt _maxlen #{@buffer.length}, #{_maxlen}" if @buffer.length > _maxlen
       set_form_col current_line().chomp().length()-1
     end
@@ -787,7 +817,11 @@ module RubyCurses
     #alias :get_text :to_s
     ## ---- for listscrollable ---- ##
     def scrollatrow
-      @height-3 # 2010-01-02 19:28 BUFFERED 
+      if @suppress_borders
+        @height - 1 
+      else
+        @height - 3 
+      end
     end
     def row_count
       @list.size
@@ -800,7 +834,7 @@ module RubyCurses
       @win_top = my_win.top
       print_borders if (@suppress_borders == false && @repaint_all) # do this once only, unless everything changes
       rc = row_count
-      _maxlen = @maxlen || @width-2 # TODO fix in other branches remove ||= 
+      _maxlen = @maxlen || @width-@internal_width # TODO fix in other branches remove ||= 
       $log.debug " #{@name} textarea repaint width is #{@width}, height is #{@height} , maxlen #{_maxlen}/ #{@maxlen}, #{@graphic.name} "
       tm = get_content
       tr = @toprow
@@ -829,7 +863,7 @@ module RubyCurses
             #renderer = cell_renderer()
             #renderer.repaint @form.window, r+hh, c+(colix*11), content, focussed, selected
             #renderer.repaint @form.window, r+hh, c, content, focussed, selected
-            @graphic.printstring  r+hh, c, "%-*s" % [@width-2,content], acolor, @attr
+            @graphic.printstring  r+hh, c, "%-*s" % [@width-@internal_width,content], acolor, @attr
             if @search_found_ix == tr+hh
               if !@find_offset.nil?
                 @graphic.mvchgat(y=r+hh, x=c+@find_offset, @find_offset1-@find_offset, Ncurses::A_NORMAL, $reversecolor, nil)
@@ -839,7 +873,7 @@ module RubyCurses
         else
           # clear rows
             # TODO the spaces string can be stored once outside loop
-          @graphic.printstring r+hh, c, " " * (@width-2), acolor,@attr
+          @graphic.printstring r+hh, c, " " * (@width-@internal_width), acolor,@attr
         end
       end
       show_caret_func