rake-funnel 0.18.0 → 0.19.0

data/spec/rake/funnel/support/mono_spec.rb

@@ -3,9 +3,9 @@ require 'tmpdir'
 include Rake::Funnel::Support
 
 describe Rake::Funnel::Support::Mono do
-  before {
+  before do
     allow(Rake::Win32).to receive(:windows?).and_return(windows?)
-  }
+  end
 
   context 'on Windows' do
     let(:windows?) { true }
@@ -34,16 +34,16 @@ describe Rake::Funnel::Support::Mono do
   context 'not on Windows' do
     let(:windows?) { false }
 
-    before {
+    before do
       allow(Which).to receive(:which)
-    }
+    end
 
-    before {
+    before do
       @cmd = described_class.invocation('executable.exe')
-    }
+    end
 
     it "should prepend 'mono'" do
-      expect(@cmd.first).to eq('mono')
+      expect(@cmd.first).to eq('mono') # rubocop:disable RSpec/InstanceVariable
     end
 
     it 'should resolve executable through which' do

data/spec/rake/funnel/support/msbuild/build_tool_spec.rb

@@ -1,14 +1,17 @@
+# rubocop:disable RSpec/FilePath
+
 describe Rake::Funnel::Support::MSBuild::BuildTool do
-  before {
+  before do
     allow(Rake::Win32).to receive(:windows?).and_return(windows?)
-  }
+  end
 
-  context 'on Windows', platform: :win32 do
+  context 'on Windows',
+          skip: ('Windows Registry not available' unless defined?(::Win32::Registry)) do
     let(:windows?) { true }
 
-    before {
-      allow(::Win32::Registry::HKEY_LOCAL_MACHINE).to receive(:open).and_yield({ 'MSBuildToolsPath' => 'path'})
-    }
+    before do
+      allow(::Win32::Registry::HKEY_LOCAL_MACHINE).to receive(:open).and_yield('MSBuildToolsPath' => 'path')
+    end
 
     it 'should search the registry for known MSBuild versions' do
       described_class.find
@@ -16,9 +19,9 @@ describe Rake::Funnel::Support::MSBuild::BuildTool do
     end
 
     context 'MSBuild exists' do
-      before {
+      before do
         allow(File).to receive(:exist?).with('path/msbuild.exe').and_return(true)
-      }
+      end
 
       it 'should find msbuild.exe' do
         expect(described_class.find).to eq('path/msbuild.exe')
@@ -26,9 +29,9 @@ describe Rake::Funnel::Support::MSBuild::BuildTool do
     end
 
     context 'MSBuild does not exist' do
-      before {
+      before do
         allow(File).to receive(:exist?).with('path/msbuild.exe').and_return(false)
-      }
+      end
 
       it 'should not find msbuild.exe' do
         expect(described_class.find).to be_nil

data/spec/rake/funnel/support/msdeploy/registry_patch_spec.rb

@@ -1,7 +1,11 @@
+# rubocop:disable RSpec/FilePath
+
 describe Rake::Funnel::Support::MSDeploy::RegistryPatch do
-  before {
+  before do
+    # rubocop:disable RSpec/AnyInstance
     allow_any_instance_of(described_class).to receive(:warn)
-  }
+    # rubocop:enable RSpec/AnyInstance
+  end
 
   describe 'execution' do
     it 'should yield block' do
@@ -21,23 +25,32 @@ describe Rake::Funnel::Support::MSDeploy::RegistryPatch do
 
   describe 'patching' do
     context 'not on Windows' do
-      before {
-        allow_any_instance_of(described_class).to receive(:require).with('win32/registry').and_raise(LoadError)
-      }
+      before do
+        # rubocop:disable RSpec/AnyInstance
+        allow_any_instance_of(described_class).to \
+          receive(:require).with('win32/registry').and_raise(LoadError)
+        # rubocop:enable RSpec/AnyInstance
+      end
 
       it 'should succeed' do
         expect { described_class.new }.not_to raise_error
       end
     end
 
-    context 'on Windows', platform: :win32 do
+    context 'on Windows', skip: ('Windows Registry not available' unless defined?(::Win32::Registry)) do
       let(:root) { Win32::Registry::HKEY_LOCAL_MACHINE }
 
-      let(:keys) {
+      let(:keys) do
         described_class::KEYS.map do |key|
           instance_double(Win32::Registry, keyname: key)
         end
-      }
+      end
+
+      let(:key_access_error) do
+        # rubocop:disable Performance/FixedSize
+        Win32::Registry::Error.new('value does not exist, so getting it raises'.length)
+        # rubocop:enable Performance/FixedSize
+      end
 
       def allow_open_or_create(key)
         allow(root).to receive(:create).with(key.keyname).and_yield(key)
@@ -48,25 +61,25 @@ describe Rake::Funnel::Support::MSDeploy::RegistryPatch do
       end
 
       context 'MSDeploy registry key and "Version" value does not exist' do
-        before {
+        before do
           keys.each do |key|
             allow(key).to receive(:created?).and_return(true)
-            allow(key).to receive(:[]).and_raise(Win32::Registry::Error.new('value does not exist, so getting it raises'.length))
+            allow(key).to receive(:[]).and_raise(key_access_error)
             allow(key).to receive(:[]=)
             allow(key).to receive(:delete_key)
           end
-        }
+        end
 
-        before {
+        before do
           keys.each do |key|
             allow_open_or_create(key)
             allow_open_for_deletion(key)
           end
-        }
+        end
 
-        before {
+        before do
           described_class.new
-        }
+        end
 
         it 'should create the key' do
           keys.each do |key|
@@ -75,26 +88,24 @@ describe Rake::Funnel::Support::MSDeploy::RegistryPatch do
         end
 
         it 'should create the version' do
-          keys.each do |key|
-            expect(key).to have_received(:[]=).with('Version', described_class::FAKE_VERSION)
-          end
+          expect(keys).to all(have_received(:[]=).with('Version', described_class::FAKE_VERSION))
         end
 
         it 'should delete the key' do
-          keys.each do |key|
+          keys.each do |key| # rubocop:disable RSpec/IteratedExpectation
             expect(key).to have_received(:delete_key).with(File.basename(key.keyname), true)
           end
         end
       end
 
       context 'registry access is denied' do
-        before {
+        before do
           allow(root).to receive(:create).and_raise(::Win32::Registry::Error.new(5))
-        }
+        end
 
-        before {
+        before do
           described_class.new
-        }
+        end
 
         it 'should warn' do
           expect(subject).to have_received(:warn).with(/Could not patch registry to pretend MSDeploy is installed/)
@@ -102,53 +113,48 @@ describe Rake::Funnel::Support::MSDeploy::RegistryPatch do
       end
 
       context 'MSDeploy registry key does exist' do
-        before {
+        before do
           keys.each do |key|
             allow_open_or_create(key)
           end
-        }
+        end
 
         context '"Version" value does not exist' do
-          before {
+          before do
             keys.each do |key|
               allow(key).to receive(:created?).and_return(false)
-              allow(key).to receive(:[]).and_raise(Win32::Registry::Error.new('value does not exist, so getting it raises'.length))
+              allow(key).to receive(:[]).and_raise(key_access_error)
               allow(key).to receive(:[]=)
               allow(key).to receive(:delete_value)
             end
-          }
+          end
 
-          before {
+          before do
             described_class.new
-          }
+          end
 
           it 'should create the version' do
-            keys.each do |key|
-              expect(key).to have_received(:[]=).with('Version', described_class::FAKE_VERSION)
-            end
+            expect(keys).to all(have_received(:[]=).with('Version', described_class::FAKE_VERSION))
           end
 
           it 'should delete the version' do
-            keys.each do |key|
-              expect(key).to have_received(:delete_value).with(described_class::VERSION_VALUE)
-            end
+            expect(keys).to all(have_received(:delete_value).with(described_class::VERSION_VALUE))
           end
         end
 
         context '"Version" value does exist' do
-          before {
+          before do
             keys.each do |key|
               allow(key).to receive(:created?).and_return(false)
               allow(key).to receive(:[])
             end
-          }
+          end
 
-          before {
+          before do
             described_class.new
-          }
+          end
 
           it 'should do nothing' do
-            expect(true).to eq(true)
           end
         end
       end

data/spec/rake/funnel/support/patch_spec.rb

@@ -14,7 +14,7 @@ describe Rake::Funnel::Support::Patch do
   end
 
   describe 'with definition' do
-    subject {
+    subject do
       described_class.new do |p|
         p.setup do
           output.puts 'setup'
@@ -25,7 +25,7 @@ describe Rake::Funnel::Support::Patch do
           output.puts memo
         end
       end
-    }
+    end
 
     let(:output) { double.as_null_object }
 
@@ -42,10 +42,10 @@ describe Rake::Funnel::Support::Patch do
     end
 
     context 'when reverting the patch' do
-      let!(:ret) {
+      let!(:ret) do
         subject.apply!
         subject.revert!
-      }
+      end
 
       it 'should execute the reset' do
         expect(output).to have_received(:puts).with(42)
@@ -60,15 +60,15 @@ describe Rake::Funnel::Support::Patch do
       before { subject.revert! }
 
       it 'should not execute the reset' do
-        expect(output).to_not have_received(:puts).with(42)
+        expect(output).not_to have_received(:puts).with(42)
       end
     end
 
     context 'when applying twice' do
-      before {
+      before do
         subject.apply!
         subject.apply!
-      }
+      end
 
       it 'should execute the setup once' do
         expect(output).to have_received(:puts).with('setup').once
@@ -76,11 +76,11 @@ describe Rake::Funnel::Support::Patch do
     end
 
     context 'when reverting twice' do
-      before {
+      before do
         subject.apply!
         subject.revert!
         subject.revert!
-      }
+      end
 
       it 'should execute the revert once' do
         expect(output).to have_received(:puts).with(42).once
@@ -90,13 +90,13 @@ describe Rake::Funnel::Support::Patch do
     describe 'context' do
       let(:context) { 42 }
 
-      subject {
+      subject do
         described_class.new(context) do |p|
           p.setup do |context|
             output.puts context
           end
         end
-      }
+      end
 
       before { subject.apply!.revert! }
 

data/spec/rake/funnel/support/specs_remover/project/paket.references

@@ -1,3 +1,3 @@
-Paket-Ref
-Explicitly-Removed-Package
-Untouched
+Paket-Ref
+Explicitly-Removed-Package
+Untouched

data/spec/rake/funnel/support/specs_remover/project/uncompiled-code/paket.references

@@ -1,3 +1,3 @@
-Paket-Ref
-Explicitly-Removed-Package
-Untouched
+Paket-Ref
+Explicitly-Removed-Package
+Untouched

data/spec/rake/funnel/support/specs_remover/project-specific paket.references/Sample.csproj.paket.references

@@ -1,3 +1,3 @@
-Paket-Ref
-Explicitly-Removed-Package
-Untouched
+Paket-Ref
+Explicitly-Removed-Package
+Untouched

data/spec/rake/funnel/support/specs_remover/project-specific paket.references/paket.references

@@ -1,3 +1,3 @@
-Paket-Ref
-Explicitly-Removed-Package
-Untouched
+Paket-Ref
+Explicitly-Removed-Package
+Untouched

data/spec/rake/funnel/support/specs_remover_spec.rb

@@ -1,7 +1,7 @@
 describe Rake::Funnel::Support::SpecsRemover do
-  before {
+  before do
     allow(Rake::Funnel::Support::Trace).to receive(:message)
-  }
+  end
 
   describe 'removal' do
     let(:projects) {}
@@ -9,25 +9,24 @@ describe Rake::Funnel::Support::SpecsRemover do
     let(:specs) {}
     let(:packages) {}
 
-    before {
+    before do
       allow(File).to receive(:open)
       allow(File).to receive(:write)
       allow(RakeFileUtils).to receive(:rm)
-    }
+    end
 
     describe 'arguments' do
-      before {
+      before do
         described_class.remove(projects: projects,
                                references: references,
                                specs: specs,
                                packages: packages)
-      }
+      end
 
       context 'string projects' do
         let(:projects) { '**/*.??proj' }
 
         it 'should succeed' do
-          expect(true).to be(true)
         end
       end
 
@@ -36,7 +35,6 @@ describe Rake::Funnel::Support::SpecsRemover do
         let(:references) { 'Reference' }
 
         it 'should succeed' do
-          expect(true).to be(true)
         end
       end
 
@@ -45,7 +43,6 @@ describe Rake::Funnel::Support::SpecsRemover do
         let(:specs) { '*Specs.cs' }
 
         it 'should succeed' do
-          expect(true).to be(true)
         end
       end
 
@@ -53,7 +50,6 @@ describe Rake::Funnel::Support::SpecsRemover do
         let(:packages) { 'SomePackage' }
 
         it 'should succeed' do
-          expect(true).to be(true)
         end
       end
     end
@@ -62,14 +58,14 @@ describe Rake::Funnel::Support::SpecsRemover do
       describe Rake::Funnel::Support::SpecsRemover::ProjectFiles do
         let(:projects) { '**/*.??proj' }
 
-        before {
+        before do
           allow(Dir).to receive(:[]).and_return([:some])
           allow(File).to receive(:read).and_return('<root></root>')
-        }
+        end
 
-        before {
+        before do
           described_class.remove_specs_and_references(projects, [], [])
-        }
+        end
 
         it 'should not write the project file' do
           expect(File).not_to have_received(:open)
@@ -79,15 +75,15 @@ describe Rake::Funnel::Support::SpecsRemover do
       describe Rake::Funnel::Support::SpecsRemover::PaketReferences do
         let(:projects) { %w(project.proj) }
 
-        before {
+        before do
           allow(Dir).to receive(:[]).and_return([:some])
           allow(File).to receive(:exist?).and_return(true)
           allow(File).to receive(:read).and_return('SomePackage')
-        }
+        end
 
-        before {
+        before do
           described_class.remove_packages(projects, [])
-        }
+        end
 
         it 'should not write the project file' do
           expect(File).not_to have_received(:write)
@@ -112,29 +108,29 @@ describe Rake::Funnel::Support::SpecsRemover do
 
     let(:temp_dir) { Dir.mktmpdir }
 
-    before {
+    before do
       allow($stderr).to receive(:puts)
-    }
+    end
 
-    before {
+    before do
       FileUtils.cp_r(File.join(example_dir(example), '.'), temp_dir)
-    }
+    end
 
-    after {
+    after do
       FileUtils.rm_rf(temp_dir)
-    }
+    end
 
     context 'project' do
       let(:example) { 'project' }
 
-      before {
+      before do
         Dir.chdir(temp_dir) do
           described_class.remove(projects: projects,
                                  references: references,
                                  specs: specs,
                                  packages: packages)
         end
-      }
+      end
 
       describe 'code files' do
         describe 'production code' do
@@ -165,7 +161,9 @@ describe Rake::Funnel::Support::SpecsRemover do
         end
 
         it 'should remove compiled specs' do
-          expect(content('Sample.csproj')).not_to include(*%w(Specs.cs SampleSpecs.cs DoesNotExistSpecs.cs))
+          expect(content('Sample.csproj')).not_to include('Specs.cs')
+          expect(content('Sample.csproj')).not_to include('SampleSpecs.cs')
+          expect(content('Sample.csproj')).not_to include('DoesNotExistSpecs.cs')
         end
       end
 
@@ -194,14 +192,14 @@ describe Rake::Funnel::Support::SpecsRemover do
     context 'project-specific paket.references' do
       let(:example) { 'project-specific paket.references' }
 
-      before {
+      before do
         Dir.chdir(temp_dir) do
           described_class.remove(projects: projects,
                                  references: references,
                                  specs: specs,
                                  packages: packages)
         end
-      }
+      end
 
       describe 'paket.references' do
         describe 'for project' do
@@ -228,14 +226,14 @@ describe Rake::Funnel::Support::SpecsRemover do
     context 'multiple projects' do
       let(:example) { 'multiple projects' }
 
-      before {
+      before do
         Dir.chdir(temp_dir) do
           described_class.remove(projects: projects,
                                  references: references,
                                  specs: specs,
                                  packages: packages)
         end
-      }
+      end
 
       describe 'projects' do
         it 'should remove references' do
@@ -244,8 +242,8 @@ describe Rake::Funnel::Support::SpecsRemover do
         end
 
         it 'should remove compiled specs' do
-          expect(content('Sample1.csproj')).not_to include(*%w(Specs.cs))
-          expect(content('Sample2.csproj')).not_to include(*%w(Specs.cs))
+          expect(content('Sample1.csproj')).not_to include('Specs.cs')
+          expect(content('Sample2.csproj')).not_to include('Specs.cs')
         end
       end
     end

data/spec/rake/funnel/support/template_engine_spec.rb

@@ -16,17 +16,21 @@ describe Rake::Funnel::Support::TemplateEngine do
   end
 
   it 'should omit newlines for pure ruby lines' do
+    # rubocop:disable Style/IndentHeredoc
     template = <<-EOF
 <%= 42 %>
     EOF
+    # rubocop:enable Style/IndentHeredoc
 
     expect(described_class.render(template)).to eq('42')
   end
 
   it 'should not omit newlines for mixed ruby lines' do
+    # rubocop:disable Style/IndentHeredoc
     template = <<-EOF
 12 <%= 34 %> 56
     EOF
+    # rubocop:enable Style/IndentHeredoc
 
     expect(described_class.render(template)).to eq("12 34 56\n")
   end
@@ -38,8 +42,7 @@ describe Rake::Funnel::Support::TemplateEngine do
   describe 'binding' do
     context 'without binding' do
       it 'should not support contextual variables' do
-        var = 42
-        template = '<%= var %>'
+        template = '<%= undefined_variable %>'
 
         expect { described_class.render(template) }.to raise_error(NameError)
       end
@@ -60,6 +63,6 @@ describe Rake::Funnel::Support::TemplateEngine do
 
   it 'should report errors with file name' do
     expect { described_class.render('<%= undefined %>', 'file.template') }
-      .to raise_error { |ex| expect(ex.backtrace.join("\n")).to match(/file\.template/) }
+      .to(raise_error { |ex| expect(ex.backtrace.join("\n")).to match(/file\.template/) })
   end
 end