rake-funnel 0.18.0 → 0.19.0

data/spec/rake/funnel/integration/teamcity/progress_report_spec.rb

@@ -1,3 +1,5 @@
+# rubocop:disable RSpec/FilePath
+
 include Rake
 include Rake::Funnel::Integration
 include Rake::Funnel::Integration::TeamCity
@@ -8,7 +10,7 @@ describe Rake::Funnel::Integration::TeamCity::ProgressReport do
   let(:teamcity_running?) { false }
   let(:teamcity_rake_runner?) { false }
 
-  before {
+  before do
     allow(TeamCity).to receive(:running?).and_return(teamcity_running?)
     allow(TeamCity).to receive(:rake_runner?).and_return(teamcity_rake_runner?)
     allow(ServiceMessages).to receive(:block_opened)
@@ -18,15 +20,15 @@ describe Rake::Funnel::Integration::TeamCity::ProgressReport do
     allow(ServiceMessages).to receive(:build_problem)
 
     Task.clear
-  }
+  end
 
-  subject! {
+  subject! do
     described_class.new
-  }
+  end
 
-  after {
+  after do
     subject.disable!
-  }
+  end
 
   shared_examples :block_report do
     it 'should write block start' do
@@ -49,14 +51,14 @@ describe Rake::Funnel::Integration::TeamCity::ProgressReport do
   end
 
   context 'when task succeeds' do
-    before {
+    before do
       task :task
 
       Task[:task].invoke
-    }
+    end
 
     it 'should not report build problems' do
-      expect(ServiceMessages).to_not have_received(:build_problem)
+      expect(ServiceMessages).not_to have_received(:build_problem)
     end
 
     context 'not on TeamCity' do
@@ -81,7 +83,7 @@ describe Rake::Funnel::Integration::TeamCity::ProgressReport do
   context 'when task fails' do
     class SpecificError < StandardError; end
 
-    before {
+    before do
       module Rake
         class ApplicationAbortedException < StandardError
           attr_reader :inner_exception
@@ -91,28 +93,27 @@ describe Rake::Funnel::Integration::TeamCity::ProgressReport do
           end
         end
       end
-    }
+    end
 
     let(:error) { SpecificError.new('task error' * 4000) }
 
-    before {
+    before do
       task :task do
         raise error
       end
 
       begin
         Task[:task].invoke
-      rescue ApplicationAbortedException => e
-      rescue SpecificError => e
+      rescue ApplicationAbortedException, SpecificError => e
         @raised_error = e
       end
-    }
+    end
 
     context 'not on TeamCity' do
       it_behaves_like :no_block_report
 
       it 'should not swallow the error' do
-        expect(@raised_error).to be_a_kind_of(SpecificError)
+        expect(@raised_error).to be_a_kind_of(SpecificError) # rubocop:disable RSpec/InstanceVariable
       end
     end
 
@@ -125,11 +126,15 @@ describe Rake::Funnel::Integration::TeamCity::ProgressReport do
         end
 
         it 'should report the error message' do
-          expect(ServiceMessages).to have_received(:build_problem).with(hash_including({ description: be_an_instance_of(String) }))
+          expect(ServiceMessages).to \
+            have_received(:build_problem)
+            .with(hash_including(description: be_an_instance_of(String)))
         end
 
         it 'should report the first 4000 characters of the error message' do
-          expect(ServiceMessages).to have_received(:build_problem).with(hash_including({ description: have(4000).items }))
+          expect(ServiceMessages).to \
+            have_received(:build_problem)
+            .with(hash_including(description: have(4000).items))
         end
       end
 
@@ -143,12 +148,13 @@ describe Rake::Funnel::Integration::TeamCity::ProgressReport do
 
       context 'with rake runner' do
         let(:teamcity_rake_runner?) { true }
-        let(:error) {
+        let(:error) do
           ApplicationAbortedException.new(SpecificError.new('inner message'))
-        }
+        end
 
-        it 'should report the inner error as a build problem (as it will be wrapped in a ApplicationAbortedException)' do
-          expect(ServiceMessages).to have_received(:build_problem).with({ description: 'inner message' })
+        it 'should report the inner error as a build problem (as it will be wrapped in a ApplicationAbortedException)' do # rubocop:disable Metrics/LineLength
+          expect(ServiceMessages).to \
+            have_received(:build_problem).with(description: 'inner message')
         end
 
         it_behaves_like :no_block_report
@@ -159,16 +165,16 @@ describe Rake::Funnel::Integration::TeamCity::ProgressReport do
   context 'when progess report was disabled' do
     let(:teamcity_running?) { true }
 
-    before {
+    before do
       subject.disable!
 
       task :task
 
       Task[:task].invoke
-    }
+    end
 
     it 'should not write' do
-      expect(ServiceMessages).to_not have_received(:block_opened)
+      expect(ServiceMessages).not_to have_received(:block_opened)
     end
   end
 end

data/spec/rake/funnel/integration/teamcity/service_messages_spec.rb

@@ -1,10 +1,12 @@
+# rubocop:disable RSpec/FilePath
+
 include Rake::Funnel::Integration
 
 describe Rake::Funnel::Integration::TeamCity::ServiceMessages do
-  before {
+  before do
     allow(TeamCity).to receive(:running?).and_return(teamcity_running?)
     allow($stdout).to receive(:puts)
-  }
+  end
 
   context 'when running outside TeamCity' do
     let(:teamcity_running?) { false }
@@ -22,9 +24,11 @@ describe Rake::Funnel::Integration::TeamCity::ServiceMessages do
     describe 'escaping' do
       context 'when publishing messages without special characters' do
         it 'should not escape' do
-          described_class.progress_start "the message"
+          described_class.progress_start 'the message'
 
-          expect($stdout).to have_received(:puts).with("##teamcity[progressStart 'the message']")
+          expect($stdout).to \
+            have_received(:puts)
+            .with("##teamcity[progressStart 'the message']")
         end
       end
 
@@ -32,61 +36,81 @@ describe Rake::Funnel::Integration::TeamCity::ServiceMessages do
         it 'should escape apostrophes' do
           described_class.progress_start "'"
 
-          expect($stdout).to have_received(:puts).with("##teamcity[progressStart '|'']")
+          expect($stdout).to \
+            have_received(:puts)
+            .with("##teamcity[progressStart '|'']")
         end
 
         it 'should escape line feeds' do
           described_class.progress_start "\n"
 
-          expect($stdout).to have_received(:puts).with("##teamcity[progressStart '|n']")
+          expect($stdout).to \
+            have_received(:puts)
+            .with("##teamcity[progressStart '|n']")
         end
 
         it 'should escape carriage returns' do
           described_class.progress_start "\r"
 
-          expect($stdout).to have_received(:puts).with("##teamcity[progressStart '|r']")
+          expect($stdout).to \
+            have_received(:puts)
+            .with("##teamcity[progressStart '|r']")
         end
 
         it 'should escape next lines' do
           described_class.progress_start "\u0085"
 
-          expect($stdout).to have_received(:puts).with("##teamcity[progressStart '|x']")
+          expect($stdout).to \
+            have_received(:puts)
+            .with("##teamcity[progressStart '|x']")
         end
 
         it 'should escape line separators' do
           described_class.progress_start "\u2028"
 
-          expect($stdout).to have_received(:puts).with("##teamcity[progressStart '|l']")
+          expect($stdout).to \
+            have_received(:puts)
+            .with("##teamcity[progressStart '|l']")
         end
 
         it 'should escape paragraph separators' do
           described_class.progress_start "\u2029"
 
-          expect($stdout).to have_received(:puts).with("##teamcity[progressStart '|p']")
+          expect($stdout).to \
+            have_received(:puts)
+            .with("##teamcity[progressStart '|p']")
         end
 
         it 'should escape vertical bars' do
           described_class.progress_start '|'
 
-          expect($stdout).to have_received(:puts).with("##teamcity[progressStart '||']")
+          expect($stdout).to \
+            have_received(:puts)
+            .with("##teamcity[progressStart '||']")
         end
 
         it 'should escape opening brackets' do
           described_class.progress_start '['
 
-          expect($stdout).to have_received(:puts).with("##teamcity[progressStart '|[']")
+          expect($stdout).to \
+            have_received(:puts)
+            .with("##teamcity[progressStart '|[']")
         end
 
         it 'should escape closing brackets' do
           described_class.progress_start ']'
 
-          expect($stdout).to have_received(:puts).with("##teamcity[progressStart '|]']")
+          expect($stdout).to \
+            have_received(:puts)
+            .with("##teamcity[progressStart '|]']")
         end
 
         it 'should escape all special characters in a string' do
           described_class.progress_start "[\r|\n]"
 
-          expect($stdout).to have_received(:puts).with("##teamcity[progressStart '|[|r|||n|]']")
+          expect($stdout).to \
+            have_received(:puts)
+            .with("##teamcity[progressStart '|[|r|||n|]']")
         end
       end
     end
@@ -96,7 +120,9 @@ describe Rake::Funnel::Integration::TeamCity::ServiceMessages do
         it 'should print the service message' do
           described_class.enable_service_messages
 
-          expect($stdout).to have_received(:puts).with('##teamcity[enableServiceMessages]')
+          expect($stdout).to \
+            have_received(:puts)
+            .with('##teamcity[enableServiceMessages]')
         end
       end
 
@@ -104,7 +130,9 @@ describe Rake::Funnel::Integration::TeamCity::ServiceMessages do
         it 'should print the service message' do
           described_class.progress_message 'the message'
 
-          expect($stdout).to have_received(:puts).with("##teamcity[progressMessage 'the message']")
+          expect($stdout).to \
+            have_received(:puts)
+            .with("##teamcity[progressMessage 'the message']")
         end
       end
 
@@ -112,7 +140,9 @@ describe Rake::Funnel::Integration::TeamCity::ServiceMessages do
         it 'should print the service message' do
           described_class.progress_message 42
 
-          expect($stdout).to have_received(:puts).with("##teamcity[progressMessage '42']")
+          expect($stdout).to \
+            have_received(:puts)
+            .with("##teamcity[progressMessage '42']")
         end
       end
 
@@ -120,7 +150,9 @@ describe Rake::Funnel::Integration::TeamCity::ServiceMessages do
         it 'should print the service message' do
           described_class.block_opened(name: 'block name')
 
-          expect($stdout).to have_received(:puts).with("##teamcity[blockOpened name='block name']")
+          expect($stdout).to \
+            have_received(:puts)
+            .with("##teamcity[blockOpened name='block name']")
         end
       end
 
@@ -128,7 +160,9 @@ describe Rake::Funnel::Integration::TeamCity::ServiceMessages do
         it 'should print the service message' do
           described_class.test_started(name: 'test name', captureStandardOutput: true)
 
-          expect($stdout).to have_received(:puts).with("##teamcity[testStarted name='test name' captureStandardOutput='true']")
+          expect($stdout).to \
+            have_received(:puts)
+            .with("##teamcity[testStarted name='test name' captureStandardOutput='true']")
         end
       end
 
@@ -136,7 +170,9 @@ describe Rake::Funnel::Integration::TeamCity::ServiceMessages do
         it 'should print the service message' do
           described_class.test_started(capture_standard_output: true)
 
-          expect($stdout).to have_received(:puts).with("##teamcity[testStarted captureStandardOutput='true']")
+          expect($stdout).to \
+            have_received(:puts)
+            .with("##teamcity[testStarted captureStandardOutput='true']")
         end
       end
     end

data/spec/rake/funnel/integration/teamcity/teamcity_spec.rb

@@ -1,8 +1,10 @@
+# rubocop:disable RSpec/FilePath
+
 describe Rake::Funnel::Integration::TeamCity do
   describe 'runner detection' do
-    before {
+    before do
       allow(ENV).to receive(:include?).with(described_class::PROJECT_ENV_VAR).and_return(teamcity_running?)
-    }
+    end
 
     context 'when running outside TeamCity' do
       let(:teamcity_running?) { false }
@@ -38,14 +40,14 @@ describe Rake::Funnel::Integration::TeamCity do
     let(:original_path) { 'original path environment variable contents' }
     let(:jre) { nil }
 
-    before {
+    before do
       allow(ENV).to receive(:[]=)
 
       allow(ENV).to receive(:[]).with('PATH').and_return(original_path)
 
       allow(ENV).to receive(:include?).with(described_class::JRE_ENV_VAR).and_return(!jre.nil?)
       allow(ENV).to receive(:[]).with(described_class::JRE_ENV_VAR).and_return(jre)
-    }
+    end
 
     context 'without block' do
       it 'should not modify environment variables' do
@@ -91,7 +93,7 @@ describe Rake::Funnel::Integration::TeamCity do
 
         context 'block error' do
           it 'should reset path' do
-            expect { described_class.with_java_runtime { fail 'with some error' } }.to raise_error(/with some error/)
+            expect { described_class.with_java_runtime { raise 'with some error' } }.to raise_error(/with some error/)
 
             expect(ENV).to have_received(:[]=).with('PATH', original_path)
           end

data/spec/rake/funnel/support/argument_mapper/styles/msdeploy_spec.rb

@@ -1,3 +1,5 @@
+# rubocop:disable RSpec/FilePath
+
 include Rake::Funnel::Support
 
 describe Rake::Funnel::Support::Mapper::Styles::MSDeploy do

data/spec/rake/funnel/support/argument_mapper/styles/nunit_spec.rb

@@ -1,16 +1,18 @@
+# rubocop:disable RSpec/FilePath
+
 describe Rake::Funnel::Support::Mapper::Styles::NUnit do
   subject { Mapper.new(:NUnit) }
 
   describe 'prefix' do
-    before {
+    before do
       allow(Rake::Win32).to receive(:windows?).and_return(windows?)
-    }
+    end
 
     context 'on Windows' do
       let(:windows?) { true }
 
       it "should use '/'" do
-        expect(subject.map({ switch: nil })).to eq(['/switch'])
+        expect(subject.map(switch: nil)).to eq(['/switch'])
       end
     end
 
@@ -18,7 +20,7 @@ describe Rake::Funnel::Support::Mapper::Styles::NUnit do
       let(:windows?) { false }
 
       it "should use '-'" do
-        expect(subject.map({ switch: nil })).to eq(['-switch'])
+        expect(subject.map(switch: nil)).to eq(['-switch'])
       end
     end
   end

data/spec/rake/funnel/support/argument_mapper/styles/styles_spec.rb

@@ -3,39 +3,39 @@ include Rake::Funnel::Support::ArgumentMapper
 Styles.constants.reject { |x| x == :MSDeploy }.each do |style|
   style_path = Styles.const_get(style)
   describe style_path do
-    subject {
+    subject do
       Mapper.new(style)
-    }
+    end
 
-    let (:style) {
+    let(:style) do
       Styles.const_get(style).new
-    }
+    end
 
-    def styled(switch, key = nil, value = nil)
-      unless style.respond_to?(:separator)
-        styled = [
-          [
-            style.prefix,
-            switch
-          ],
-          [
-            key && key,
-            value && style.value_separator,
-            value && value
-          ]
-        ]
-      else
-        styled = [
-          [
-            style.prefix,
-            switch,
-            key && style.separator,
-            key && key,
-            value && style.value_separator,
-            value && value
-          ]
-        ]
-      end
+    def styled(switch, key = nil, value = nil) # rubocop:disable Metrics/MethodLength, Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity, Metrics/LineLength
+      styled = if style.respond_to?(:separator)
+                 [
+                   [
+                     style.prefix,
+                     switch,
+                     key && style.separator,
+                     key && key,
+                     value && style.value_separator,
+                     value && value
+                   ]
+                 ]
+               else
+                 [
+                   [
+                     style.prefix,
+                     switch
+                   ],
+                   [
+                     key && key,
+                     value && style.value_separator,
+                     value && value
+                   ]
+                 ]
+               end
 
       styled.map(&:join).reject(&:empty?)
     end
@@ -74,30 +74,33 @@ Styles.constants.reject { |x| x == :MSDeploy }.each do |style|
       it 'should convert switch => <truthy> enumerable' do
         args = { switch: [true, 1] }
         expect(subject.map(args)).to match_array(
-            [
-              *styled('switch', 'true'),
-              *styled('switch', '1')
-            ])
+          [
+            *styled('switch', 'true'),
+            *styled('switch', '1')
+          ]
+        )
       end
 
       it 'should convert hash values' do
         args = { switch: { foo: true, bar: true } }
         expect(subject.map(args)).to match_array(
-            [
-              *styled('switch', 'foo', 'true'),
-              *styled('switch', 'bar', 'true')
-            ])
+          [
+            *styled('switch', 'foo', 'true'),
+            *styled('switch', 'bar', 'true')
+          ]
+        )
       end
 
       it 'should convert enumerable hash values' do
         args = { switch: [{ foo: true, bar: 1 }, { baz: :baz, foobar: 'foobar' }] }
         expect(subject.map(args)).to match_array(
-            [
-              *styled('switch', 'foo', 'true'),
-              *styled('switch', 'bar', '1'),
-              *styled('switch', 'baz', 'baz'),
-              *styled('switch', 'foobar', 'foobar'),
-            ])
+          [
+            *styled('switch', 'foo', 'true'),
+            *styled('switch', 'bar', '1'),
+            *styled('switch', 'baz', 'baz'),
+            *styled('switch', 'foobar', 'foobar')
+          ]
+        )
       end
     end
 
@@ -115,28 +118,31 @@ Styles.constants.reject { |x| x == :MSDeploy }.each do |style|
       it 'should convert switch => <falsy> enumerable' do
         args = { switch: [false, nil] }
         expect(subject.map(args)).to match_array(
-            [
-              *styled('switch', 'false'),
-              *styled('switch')
-            ])
+          [
+            *styled('switch', 'false'),
+            *styled('switch')
+          ]
+        )
       end
 
       it 'should convert hash values' do
         args = { switch: { foo: false, bar: nil } }
         expect(subject.map(args)).to match_array(
-            [
-              *styled('switch', 'foo', 'false'),
-              *styled('switch', 'bar')
-            ])
+          [
+            *styled('switch', 'foo', 'false'),
+            *styled('switch', 'bar')
+          ]
+        )
       end
 
       it 'should convert enumerable hash values' do
         args = { switch: [{ foo: false }, { bar: nil }] }
         expect(subject.map(args)).to match_array(
-            [
-              *styled('switch', 'foo', 'false'),
-              *styled('switch', 'bar')
-            ])
+          [
+            *styled('switch', 'foo', 'false'),
+            *styled('switch', 'bar')
+          ]
+        )
       end
     end
 
@@ -144,28 +150,31 @@ Styles.constants.reject { |x| x == :MSDeploy }.each do |style|
       it 'should convert switch => <enumerable>' do
         args = { switch: [1, 'two'] }
         expect(subject.map(args)).to match_array(
-            [
-              *styled('switch', '1'),
-              *styled('switch', 'two')
-            ])
+          [
+            *styled('switch', '1'),
+            *styled('switch', 'two')
+          ]
+        )
       end
 
       it 'should convert switch => <hash>' do
         args = { switch: { one: 1, two: 2 } }
         expect(subject.map(args)).to match_array(
-            [
-              *styled('switch', 'one', '1'),
-              *styled('switch', 'two', '2')
-            ])
+          [
+            *styled('switch', 'one', '1'),
+            *styled('switch', 'two', '2')
+          ]
+        )
       end
 
       it 'should convert switch => <enumerable of hash>' do
         args = { switch: [{ one: 1 }, { two: 2 }] }
         expect(subject.map(args)).to match_array(
-            [
-              *styled('switch', 'one', '1'),
-              *styled('switch', 'two', '2')
-            ])
+          [
+            *styled('switch', 'one', '1'),
+            *styled('switch', 'two', '2')
+          ]
+        )
       end
     end