rails_pulse 0.4.2 → 0.5.0.pre.1

data/app/models/rails_pulse/dashboard/storage_status.rb

@@ -71,6 +71,13 @@ module RailsPulse
           label: "Deployments",
           description: "Deploy markers shown on charts",
           time_column: :started_at
+        },
+        {
+          name: :rails_pulse_events,
+          model: "RailsPulse::Event",
+          label: "Events",
+          description: "What Pulse noticed: writer heartbeats every minute, pruned after a day; any other kind is kept for event_retention_period",
+          time_column: :occurred_at
         }
       ].freeze
 
@@ -137,6 +144,35 @@ module RailsPulse
         }
       end
 
+      # Built from live_processes/dropped_by_process rather than
+      # WriterHeartbeat.summary, which would recompute both internally.
+      def tracking
+        @tracking ||= begin
+          live = RailsPulse::WriterHeartbeat.live_processes
+          dropped_by_process = RailsPulse::WriterHeartbeat.dropped_by_process(window: 1.hour)
+          processes = live.map do |process|
+            {
+              label: process.process_label,
+              queue_depth: process.queue_depth,
+              queue_size: process.queue_size,
+              dropped_last_hour: dropped_by_process.fetch(process.process_label, 0),
+              last_seen_at: process.sampled_at
+            }
+          end
+
+          {
+            processes:       processes,
+            live_count:      processes.size,
+            queue_depth:     live.sum(&:queue_depth),
+            queue_size:      live.map(&:queue_size).max || 0,
+            dropped:         dropped_by_process.values.sum,
+            last_sampled_at: RailsPulse::WriterHeartbeat.events.maximum(:occurred_at)
+          }
+        end
+      rescue ActiveRecord::ActiveRecordError
+        { processes: [], live_count: 0, queue_depth: 0, queue_size: 0, dropped: 0, last_sampled_at: nil }
+      end
+
       def dashboard_tables
         capped = tables.select { |table| table[:limit] }
         return tables.first(4) if capped.empty?

data/app/models/rails_pulse/deployment.rb

@@ -1,5 +1,7 @@
 module RailsPulse
   class Deployment < RailsPulse::ApplicationRecord
+    include HasMetadata
+
     self.table_name = "rails_pulse_deployments"
 
     # The create endpoint is reachable with a CI token, so every field a
@@ -52,13 +54,6 @@ module RailsPulse
       finished_at - started_at
     end
 
-    def metadata_hash
-      return {} if metadata.blank?
-      JSON.parse(metadata)
-    rescue JSON::ParserError
-      {}
-    end
-
     def to_chart_marker
       { timestamp: started_at.to_i * 1000, revision: revision, started_at: started_at.iso8601 }
     end

data/app/models/rails_pulse/event.rb

@@ -0,0 +1,40 @@
+module RailsPulse
+  # What Rails Pulse noticed, as opposed to what it measured. One row per
+  # outcome or sample, tagged by `kind`; `subject` names what it is about,
+  # `value` carries its number and `metadata` the kind-specific detail as JSON.
+  #
+  # The one kind written today is writer_heartbeat (see WriterHeartbeat). The
+  # table is generic so a new kind needs no migration. Decision 0019.
+  #
+  # CleanupService deletes rows older than config.event_retention_period,
+  # except kinds listed in config.event_retention_exempt_kinds (rows a writer
+  # updates in place). Writer heartbeats are pruned after a day by the writer
+  # itself.
+  class Event < RailsPulse::ApplicationRecord
+    include HasMetadata
+
+    self.table_name = "rails_pulse_events"
+
+    validates :kind, :outcome, :occurred_at, presence: true
+
+    scope :of_kind,     ->(*kinds) { where(kind: kinds.flatten.map(&:to_s)) }
+    scope :for_subject, ->(subject) { where(subject: subject) }
+    scope :since,       ->(time) { where(occurred_at: time..) }
+    scope :recent,      -> { order(occurred_at: :desc) }
+
+    def self.ransackable_attributes(_auth_object = nil)
+      %w[kind subject outcome value occurred_at message created_at updated_at]
+    end
+
+    def self.ransackable_associations(_auth_object = nil)
+      []
+    end
+
+    # table_exists?, rescued — for an upgrader who hasn't migrated yet
+    def self.table_available?
+      table_exists?
+    rescue ActiveRecord::ActiveRecordError
+      false
+    end
+  end
+end

data/app/models/rails_pulse/exception_occurrence.rb

@@ -21,7 +21,7 @@ module RailsPulse
     end
 
     def to_breadcrumb
-      occurred_at.getlocal.strftime("%b %d, %Y %l:%M %p")
+      occurred_at.strftime("%b %d, %Y %l:%M %p")
     end
   end
 end

data/app/models/rails_pulse/exceptions/cards/exception_rate.rb

@@ -16,10 +16,7 @@ module RailsPulse
         PER = 1_000
 
         def initialize(disabled_tags: [], show_non_tagged: true, period: 14, period_type: "day")
-          @disabled_tags   = disabled_tags
-          @show_non_tagged = show_non_tagged
-          @period          = period
-          @period_type     = period_type
+          super
         end
 
         def to_metric_card
@@ -63,8 +60,8 @@ module RailsPulse
             .where(period_type: @period_type, period_start: range_start..now)
             .select(
               "SUM(rails_pulse_summaries.count) AS total_count",
-              "SUM(CASE WHEN rails_pulse_summaries.period_start >= #{quote(current_window_start)} THEN rails_pulse_summaries.count ELSE 0 END) AS current_count",
-              "SUM(CASE WHEN rails_pulse_summaries.period_start >= #{quote(range_start)} AND rails_pulse_summaries.period_start < #{quote(current_window_start)} THEN rails_pulse_summaries.count ELSE 0 END) AS previous_count"
+              window_sql("SUM(CASE WHEN rails_pulse_summaries.period_start >= :current_start THEN rails_pulse_summaries.count ELSE 0 END) AS current_count"),
+              window_sql("SUM(CASE WHEN rails_pulse_summaries.period_start >= :range_start AND rails_pulse_summaries.period_start < :current_start THEN rails_pulse_summaries.count ELSE 0 END) AS previous_count")
             )
             .take
 

data/app/models/rails_pulse/exceptions/cards/open_groups.rb

@@ -9,10 +9,7 @@ module RailsPulse
       # you about the other.
       class OpenGroups < RailsPulse::Cards::Base
         def initialize(disabled_tags: [], show_non_tagged: true, period: 14, period_type: "day")
-          @disabled_tags   = disabled_tags
-          @show_non_tagged = show_non_tagged
-          @period          = period
-          @period_type     = period_type
+          super
         end
 
         def to_metric_card

data/app/models/rails_pulse/exceptions/cards/total_occurrences.rb

@@ -11,10 +11,7 @@ module RailsPulse
         SUMMARIZABLE_TYPE = "RailsPulse::ExceptionGroup".freeze
 
         def initialize(disabled_tags: [], show_non_tagged: true, period: 14, period_type: "day")
-          @disabled_tags   = disabled_tags
-          @show_non_tagged = show_non_tagged
-          @period          = period
-          @period_type     = period_type
+          super
         end
 
         def to_metric_card
@@ -24,8 +21,8 @@ module RailsPulse
 
           metrics = base_query.select(
             "SUM(rails_pulse_summaries.count) AS total_count",
-            "SUM(CASE WHEN rails_pulse_summaries.period_start >= #{quote(current_window_start)} THEN rails_pulse_summaries.count ELSE 0 END) AS current_count",
-            "SUM(CASE WHEN rails_pulse_summaries.period_start >= #{quote(range_start)} AND rails_pulse_summaries.period_start < #{quote(current_window_start)} THEN rails_pulse_summaries.count ELSE 0 END) AS previous_count"
+            window_sql("SUM(CASE WHEN rails_pulse_summaries.period_start >= :current_start THEN rails_pulse_summaries.count ELSE 0 END) AS current_count"),
+            window_sql("SUM(CASE WHEN rails_pulse_summaries.period_start >= :range_start AND rails_pulse_summaries.period_start < :current_start THEN rails_pulse_summaries.count ELSE 0 END) AS previous_count")
           ).take
 
           total    = metrics&.total_count.to_i

data/app/models/rails_pulse/exceptions/charts/occurrence_volume.rb

@@ -8,16 +8,15 @@ module RailsPulse
       # silently flattens toward zero the further back you look. Summaries are
       # retained at day granularity indefinitely.
       class OccurrenceVolume
-        def initialize(start_time:, end_time:, period_type: "day")
-          @start_time  = start_time
-          @end_time    = end_time
+        def initialize(window:, period_type: "day")
+          @window      = window
           @period_type = period_type
         end
 
         def to_chart_data
           totals = RailsPulse::Summary
             .overall_exceptions
-            .where(period_type: @period_type, period_start: @start_time..@end_time)
+            .where(period_type: @period_type, period_start: @window.start_time..@window.end_time)
             .group(:period_start)
             .sum(:count)
 
@@ -45,7 +44,7 @@ module RailsPulse
           step = @period_type.to_s == "hour" ? 3600 : 86_400
 
           {}.tap do |padded|
-            (@start_time.to_i..@end_time.to_i).step(step) do |timestamp|
+            (@window.start_time.to_i..@window.end_time.to_i).step(step) do |timestamp|
               padded[timestamp] = raw[timestamp] || 0
             end
           end

data/app/models/rails_pulse/job_run.rb

@@ -40,7 +40,7 @@ module RailsPulse
     after_commit :apply_to_job_caches, on: %i[create update], if: :finalized?
 
     def to_breadcrumb
-      occurred_at.getlocal.strftime("%b %d, %Y %l:%M %p")
+      occurred_at.strftime("%b %d, %Y %l:%M %p")
     end
 
     def all_tags

data/app/models/rails_pulse/jobs/cards/failure_rate.rb

@@ -2,14 +2,8 @@ module RailsPulse
   module Jobs
     module Cards
       class FailureRate < RailsPulse::Cards::Base
-        def initialize(job: nil, disabled_tags: [], show_non_tagged: true, period: 14, period_type: "day", start_time: nil, end_time: nil)
-          @job = job
-          @disabled_tags = disabled_tags
-          @show_non_tagged = show_non_tagged
-          @period = period
-          @period_type = period_type
-          @start_time = start_time
-          @end_time = end_time
+        def initialize(job: nil, period: 14, **kwargs)
+          super(subject: job, period: period, **kwargs)
         end
 
         def to_metric_card
@@ -20,15 +14,15 @@ module RailsPulse
               period_type: @period_type,
               period_start: range_start..now
             )
-          base_query = base_query.where(summarizable_id: @job.id) if @job
+          base_query = base_query.where(summarizable_id: @subject.id) if @subject
 
           metrics = base_query.select(
             "SUM(rails_pulse_summaries.count) AS total_count",
             "SUM(rails_pulse_summaries.error_count) AS total_errors",
-            "SUM(CASE WHEN rails_pulse_summaries.period_start >= #{quote(current_window_start)} THEN rails_pulse_summaries.count ELSE 0 END) AS current_count",
-            "SUM(CASE WHEN rails_pulse_summaries.period_start >= #{quote(current_window_start)} THEN rails_pulse_summaries.error_count ELSE 0 END) AS current_errors",
-            "SUM(CASE WHEN rails_pulse_summaries.period_start >= #{quote(range_start)} AND rails_pulse_summaries.period_start < #{quote(current_window_start)} THEN rails_pulse_summaries.count ELSE 0 END) AS previous_count",
-            "SUM(CASE WHEN rails_pulse_summaries.period_start >= #{quote(range_start)} AND rails_pulse_summaries.period_start < #{quote(current_window_start)} THEN rails_pulse_summaries.error_count ELSE 0 END) AS previous_errors"
+            window_sql("SUM(CASE WHEN rails_pulse_summaries.period_start >= :current_start THEN rails_pulse_summaries.count ELSE 0 END) AS current_count"),
+            window_sql("SUM(CASE WHEN rails_pulse_summaries.period_start >= :current_start THEN rails_pulse_summaries.error_count ELSE 0 END) AS current_errors"),
+            window_sql("SUM(CASE WHEN rails_pulse_summaries.period_start >= :range_start AND rails_pulse_summaries.period_start < :current_start THEN rails_pulse_summaries.count ELSE 0 END) AS previous_count"),
+            window_sql("SUM(CASE WHEN rails_pulse_summaries.period_start >= :range_start AND rails_pulse_summaries.period_start < :current_start THEN rails_pulse_summaries.error_count ELSE 0 END) AS previous_errors")
           ).take
 
           total_runs = metrics&.total_count.to_i
@@ -52,7 +46,7 @@ module RailsPulse
               period_type: @period_type,
               period_start: current_window_start..now
             )
-          sparkline_query = sparkline_query.where(summarizable_id: @job.id) if @job
+          sparkline_query = sparkline_query.where(summarizable_id: @subject.id) if @subject
 
           grouped_errors = bucket_by_period(sparkline_query) { |relation| relation.sum("rails_pulse_summaries.error_count") }
           grouped_counts = bucket_by_period(sparkline_query) { |relation| relation.sum("rails_pulse_summaries.count") }

data/app/models/rails_pulse/jobs/cards/p95_duration.rb

@@ -2,14 +2,8 @@ module RailsPulse
   module Jobs
     module Cards
       class P95Duration < RailsPulse::Cards::Base
-        def initialize(job: nil, disabled_tags: [], show_non_tagged: true, period: 14, period_type: "day", start_time: nil, end_time: nil)
-          @job = job
-          @disabled_tags = disabled_tags
-          @show_non_tagged = show_non_tagged
-          @period = period
-          @period_type = period_type
-          @start_time = start_time
-          @end_time = end_time
+        def initialize(job: nil, period: 14, **kwargs)
+          super(subject: job, period: period, **kwargs)
         end
 
         def to_metric_card
@@ -20,15 +14,15 @@ module RailsPulse
               period_type: @period_type,
               period_start: range_start..now
             )
-          base_query = base_query.where(summarizable_id: @job.id) if @job
+          base_query = base_query.where(summarizable_id: @subject.id) if @subject
 
           metrics = base_query.select(
             "SUM(rails_pulse_summaries.p95_duration * rails_pulse_summaries.count) AS total_weighted_p95",
             "SUM(rails_pulse_summaries.count) AS total_runs",
-            "SUM(CASE WHEN rails_pulse_summaries.period_start >= #{quote(current_window_start)} THEN rails_pulse_summaries.p95_duration * rails_pulse_summaries.count ELSE 0 END) AS current_weighted_p95",
-            "SUM(CASE WHEN rails_pulse_summaries.period_start >= #{quote(current_window_start)} THEN rails_pulse_summaries.count ELSE 0 END) AS current_runs",
-            "SUM(CASE WHEN rails_pulse_summaries.period_start >= #{quote(range_start)} AND rails_pulse_summaries.period_start < #{quote(current_window_start)} THEN rails_pulse_summaries.p95_duration * rails_pulse_summaries.count ELSE 0 END) AS previous_weighted_p95",
-            "SUM(CASE WHEN rails_pulse_summaries.period_start >= #{quote(range_start)} AND rails_pulse_summaries.period_start < #{quote(current_window_start)} THEN rails_pulse_summaries.count ELSE 0 END) AS previous_runs"
+            window_sql("SUM(CASE WHEN rails_pulse_summaries.period_start >= :current_start THEN rails_pulse_summaries.p95_duration * rails_pulse_summaries.count ELSE 0 END) AS current_weighted_p95"),
+            window_sql("SUM(CASE WHEN rails_pulse_summaries.period_start >= :current_start THEN rails_pulse_summaries.count ELSE 0 END) AS current_runs"),
+            window_sql("SUM(CASE WHEN rails_pulse_summaries.period_start >= :range_start AND rails_pulse_summaries.period_start < :current_start THEN rails_pulse_summaries.p95_duration * rails_pulse_summaries.count ELSE 0 END) AS previous_weighted_p95"),
+            window_sql("SUM(CASE WHEN rails_pulse_summaries.period_start >= :range_start AND rails_pulse_summaries.period_start < :current_start THEN rails_pulse_summaries.count ELSE 0 END) AS previous_runs")
           ).take
 
           total_runs = metrics&.total_runs.to_i
@@ -42,7 +36,7 @@ module RailsPulse
           current_p95 = weighted_average(current_weighted_p95, current_runs)
           previous_p95 = weighted_average(previous_weighted_p95, previous_runs)
 
-          baseline = baseline_trend_for(@job, metric: :p95)
+          baseline = baseline_trend_for(@subject, metric: :p95)
 
           if baseline
             trend_icon, trend_amount, trend_caption = baseline

data/app/models/rails_pulse/jobs/cards/total_runs.rb

@@ -2,14 +2,8 @@ module RailsPulse
   module Jobs
     module Cards
       class TotalRuns < RailsPulse::Cards::Base
-        def initialize(job: nil, disabled_tags: [], show_non_tagged: true, period: 14, period_type: "day", start_time: nil, end_time: nil)
-          @job = job
-          @disabled_tags = disabled_tags
-          @show_non_tagged = show_non_tagged
-          @period = period
-          @period_type = period_type
-          @start_time = start_time
-          @end_time = end_time
+        def initialize(job: nil, period: 14, **kwargs)
+          super(subject: job, period: period, **kwargs)
         end
 
         def to_metric_card
@@ -20,12 +14,12 @@ module RailsPulse
               period_type: @period_type,
               period_start: range_start..now
             )
-          base_query = base_query.where(summarizable_id: @job.id) if @job
+          base_query = base_query.where(summarizable_id: @subject.id) if @subject
 
           metrics = base_query.select(
             "SUM(rails_pulse_summaries.count) AS total_count",
-            "SUM(CASE WHEN rails_pulse_summaries.period_start >= #{quote(current_window_start)} THEN rails_pulse_summaries.count ELSE 0 END) AS current_count",
-            "SUM(CASE WHEN rails_pulse_summaries.period_start >= #{quote(range_start)} AND rails_pulse_summaries.period_start < #{quote(current_window_start)} THEN rails_pulse_summaries.count ELSE 0 END) AS previous_count"
+            window_sql("SUM(CASE WHEN rails_pulse_summaries.period_start >= :current_start THEN rails_pulse_summaries.count ELSE 0 END) AS current_count"),
+            window_sql("SUM(CASE WHEN rails_pulse_summaries.period_start >= :range_start AND rails_pulse_summaries.period_start < :current_start THEN rails_pulse_summaries.count ELSE 0 END) AS previous_count")
           ).take
 
           total_runs = metrics&.total_count.to_i

data/app/models/rails_pulse/jobs/charts/duration.rb

@@ -33,7 +33,7 @@ module RailsPulse
           # Convert to final values (weighted averages) and pad missing data
           step = time_step
           daily_data = {}
-          (@start_time.to_i..@end_time.to_i).step(step) do |timestamp|
+          (@window.start_time.to_i..@window.end_time.to_i).step(step) do |timestamp|
             if raw_data[timestamp]
               count = raw_data[timestamp][:total_count]
               daily_data[timestamp] = {

data/app/models/rails_pulse/jobs/charts/execution_volume.rb

@@ -21,7 +21,7 @@ module RailsPulse
           end
 
           # Pad missing data with zeros using base class helper
-          daily_data = pad_data_with_zeros(raw_data, @start_time, @end_time, time_step)
+          daily_data = pad_data_with_zeros(raw_data, @window.start_time, @window.end_time, time_step)
 
           # Build series data as [timestamp_ms, value] pairs for ECharts time axis
           series = [ {

data/app/models/rails_pulse/jobs/charts/failure_rate.rb

@@ -25,7 +25,7 @@ module RailsPulse
           # Pad missing data with zeros
           step = time_step
           daily_data = {}
-          (@start_time.to_i..@end_time.to_i).step(step) do |timestamp|
+          (@window.start_time.to_i..@window.end_time.to_i).step(step) do |timestamp|
             daily_data[timestamp] = raw_data[timestamp] || nil
           end
 

data/app/models/rails_pulse/like_pattern.rb

@@ -0,0 +1,29 @@
+module RailsPulse
+  # Builds LIKE patterns whose `_`, `%` and escape characters match literally.
+  #
+  # Every pattern built here must be used with CLAUSE appended to the LIKE
+  # expression. SQLite has no default escape character, so `foo!_bar` without an
+  # explicit ESCAPE matches a literal `!` while the `_` still wildcards, and the
+  # comparison silently matches nothing. `!` is the escape character rather than
+  # `\` because MySQL and PostgreSQL disagree on how a backslash is quoted.
+  module LikePattern
+    ESCAPE_CHARACTER = "!".freeze
+
+    # Interpolated directly into SQL strings, so it must stay a literal.
+    CLAUSE = "ESCAPE '#{ESCAPE_CHARACTER}'".freeze
+
+    module_function
+
+    # @param value [#to_s] user-supplied text to match anywhere in a column
+    # @return [String] escaped pattern wrapped in leading and trailing wildcards
+    def containing(value)
+      "%#{escape(value)}%"
+    end
+
+    # @param value [#to_s] user-supplied text
+    # @return [String] the text with LIKE metacharacters escaped
+    def escape(value)
+      ActiveRecord::Base.sanitize_sql_like(value.to_s, ESCAPE_CHARACTER)
+    end
+  end
+end

data/app/models/rails_pulse/queries/cards/average_query_times.rb

@@ -2,14 +2,8 @@ module RailsPulse
   module Queries
     module Cards
       class AverageQueryTimes < RailsPulse::Cards::Base
-        def initialize(query: nil, disabled_tags: [], show_non_tagged: true, period: 7, period_type: "day", start_time: nil, end_time: nil)
-          @query = query
-          @disabled_tags = disabled_tags
-          @show_non_tagged = show_non_tagged
-          @period = period
-          @period_type = period_type
-          @start_time = start_time
-          @end_time = end_time
+        def initialize(query: nil, **kwargs)
+          super(subject: query, **kwargs)
         end
 
         def to_metric_card
@@ -19,10 +13,10 @@ module RailsPulse
           metrics = base_query.select(
             "SUM(avg_duration * count) AS total_weighted_duration",
             "SUM(count) AS total_requests",
-            "SUM(CASE WHEN period_start >= #{quote(current_window_start)} THEN avg_duration * count ELSE 0 END) AS current_weighted_duration",
-            "SUM(CASE WHEN period_start >= #{quote(current_window_start)} THEN count ELSE 0 END) AS current_requests",
-            "SUM(CASE WHEN period_start >= #{quote(range_start)} AND period_start < #{quote(current_window_start)} THEN avg_duration * count ELSE 0 END) AS previous_weighted_duration",
-            "SUM(CASE WHEN period_start >= #{quote(range_start)} AND period_start < #{quote(current_window_start)} THEN count ELSE 0 END) AS previous_requests"
+            window_sql("SUM(CASE WHEN period_start >= :current_start THEN avg_duration * count ELSE 0 END) AS current_weighted_duration"),
+            window_sql("SUM(CASE WHEN period_start >= :current_start THEN count ELSE 0 END) AS current_requests"),
+            window_sql("SUM(CASE WHEN period_start >= :range_start AND period_start < :current_start THEN avg_duration * count ELSE 0 END) AS previous_weighted_duration"),
+            window_sql("SUM(CASE WHEN period_start >= :range_start AND period_start < :current_start THEN count ELSE 0 END) AS previous_requests")
           ).take
 
           # Calculate metrics from single query result

data/app/models/rails_pulse/queries/cards/database_load.rb

@@ -2,15 +2,6 @@ module RailsPulse
   module Queries
     module Cards
       class DatabaseLoad < RailsPulse::Cards::Base
-        def initialize(disabled_tags: [], show_non_tagged: true, period: 7, period_type: "day", start_time: nil, end_time: nil)
-          @disabled_tags = disabled_tags
-          @show_non_tagged = show_non_tagged
-          @period = period
-          @period_type = period_type
-          @start_time = start_time
-          @end_time = end_time
-        end
-
         def to_metric_card
           # Use base class time period helpers
           last_n_units = current_window_start

data/app/models/rails_pulse/queries/cards/execution_rate.rb

@@ -2,14 +2,8 @@ module RailsPulse
   module Queries
     module Cards
       class ExecutionRate < RailsPulse::Cards::Base
-        def initialize(query: nil, disabled_tags: [], show_non_tagged: true, period: 7, period_type: "day", start_time: nil, end_time: nil)
-          @query = query
-          @disabled_tags = disabled_tags
-          @show_non_tagged = show_non_tagged
-          @period = period
-          @period_type = period_type
-          @start_time = start_time
-          @end_time = end_time
+        def initialize(query: nil, **kwargs)
+          super(subject: query, **kwargs)
         end
 
         def to_metric_card
@@ -18,8 +12,8 @@ module RailsPulse
 
           metrics = base_query.select(
             "SUM(count) AS total_count",
-            "SUM(CASE WHEN period_start >= #{quote(current_window_start)} THEN count ELSE 0 END) AS current_count",
-            "SUM(CASE WHEN period_start >= #{quote(range_start)} AND period_start < #{quote(current_window_start)} THEN count ELSE 0 END) AS previous_count"
+            window_sql("SUM(CASE WHEN period_start >= :current_start THEN count ELSE 0 END) AS current_count"),
+            window_sql("SUM(CASE WHEN period_start >= :range_start AND period_start < :current_start THEN count ELSE 0 END) AS previous_count")
           ).take
 
           # Calculate metrics from single query result
@@ -38,7 +32,7 @@ module RailsPulse
               period_type: @period_type,
               period_start: current_window_start..now
             )
-          sparkline_query = sparkline_query.where(summarizable_id: @query.id) if @query
+          sparkline_query = sparkline_query.where(summarizable_id: @subject.id) if @subject
 
           grouped_data = bucket_by_period(sparkline_query) { |relation| relation.sum(:count) }
 

data/app/models/rails_pulse/queries/cards/percentile_query_times.rb

@@ -2,14 +2,8 @@ module RailsPulse
   module Queries
     module Cards
       class PercentileQueryTimes < RailsPulse::Cards::Base
-        def initialize(query: nil, disabled_tags: [], show_non_tagged: true, period: 7, period_type: "day", start_time: nil, end_time: nil)
-          @query = query
-          @disabled_tags = disabled_tags
-          @show_non_tagged = show_non_tagged
-          @period = period
-          @period_type = period_type
-          @start_time = start_time
-          @end_time = end_time
+        def initialize(query: nil, **kwargs)
+          super(subject: query, **kwargs)
         end
 
         def to_metric_card
@@ -19,8 +13,8 @@ module RailsPulse
           metrics = base_query.select(
             "SUM(p95_duration * count) / NULLIF(SUM(count), 0) AS overall_p95",
             "SUM(count) AS total_count",
-            "SUM(CASE WHEN period_start >= #{quote(current_window_start)} THEN p95_duration * count ELSE 0 END) / NULLIF(SUM(CASE WHEN period_start >= #{quote(current_window_start)} THEN count ELSE 0 END), 0) AS current_p95",
-            "SUM(CASE WHEN period_start >= #{quote(range_start)} AND period_start < #{quote(current_window_start)} THEN p95_duration * count ELSE 0 END) / NULLIF(SUM(CASE WHEN period_start >= #{quote(range_start)} AND period_start < #{quote(current_window_start)} THEN count ELSE 0 END), 0) AS previous_p95"
+            window_sql("SUM(CASE WHEN period_start >= :current_start THEN p95_duration * count ELSE 0 END) / NULLIF(SUM(CASE WHEN period_start >= :current_start THEN count ELSE 0 END), 0) AS current_p95"),
+            window_sql("SUM(CASE WHEN period_start >= :range_start AND period_start < :current_start THEN p95_duration * count ELSE 0 END) / NULLIF(SUM(CASE WHEN period_start >= :range_start AND period_start < :current_start THEN count ELSE 0 END), 0) AS previous_p95")
           ).take
 
           # Calculate metrics from single query result
@@ -28,7 +22,7 @@ module RailsPulse
           current_period_p95 = metrics.current_p95 || 0
           previous_period_p95 = metrics.previous_p95 || 0
 
-          baseline = baseline_trend_for(@query, metric: :p95)
+          baseline = baseline_trend_for(@subject, metric: :p95)
 
           if baseline
             trend_icon, trend_amount, trend_caption = baseline
@@ -44,7 +38,7 @@ module RailsPulse
               period_type: @period_type,
               period_start: current_window_start..now
             )
-          sparkline_query = sparkline_query.where(summarizable_id: @query.id) if @query
+          sparkline_query = sparkline_query.where(summarizable_id: @subject.id) if @subject
 
           weighted_sums = bucket_by_period(sparkline_query) { |relation| relation.sum("p95_duration * count") }
           period_counts = bucket_by_period(sparkline_query) { |relation| relation.sum(:count) }

data/app/models/rails_pulse/queries/charts/database_load.rb

@@ -2,9 +2,8 @@ module RailsPulse
   module Queries
     module Charts
       class DatabaseLoad
-        def initialize(start_time:, end_time:, period_type: :day, disabled_tags: [], show_non_tagged: true)
-          @start_time = start_time
-          @end_time = end_time
+        def initialize(window:, period_type: :day, disabled_tags: [], show_non_tagged: true)
+          @window = window
           @period_type = period_type
           @disabled_tags = disabled_tags
           @show_non_tagged = show_non_tagged
@@ -19,7 +18,7 @@ module RailsPulse
             .where(
               summarizable_type: "RailsPulse::Query",
               period_type: @period_type,
-              period_start: Time.at(@start_time)..Time.at(@end_time)
+              period_start: @window.start_time..@window.end_time
             )
 
           # Get route summaries (total request time)
@@ -28,7 +27,7 @@ module RailsPulse
             .where(
               summarizable_type: "RailsPulse::Route",
               period_type: @period_type,
-              period_start: Time.at(@start_time)..Time.at(@end_time)
+              period_start: @window.start_time..@window.end_time
             )
 
           return nil if query_summaries.empty? || route_summaries.empty?
@@ -52,7 +51,7 @@ module RailsPulse
           # <25% = green (healthy), 25-40% = yellow (watch), >40% = red (bottleneck)
           bar_data = []
 
-          (@start_time.to_i..@end_time.to_i).step(step) do |timestamp|
+          (@window.start_time.to_i..@window.end_time.to_i).step(step) do |timestamp|
             query_time = query_time_by_period[timestamp] || 0
             request_time = request_time_by_period[timestamp] || 0
             percentage = request_time > 0 ? (query_time.to_f / request_time * 100).round(1) : 0

data/app/models/rails_pulse/queries/charts/execution_volume.rb

@@ -18,7 +18,7 @@ module RailsPulse
           end
 
           # Pad missing data with zeros using base class helper
-          execution_data = pad_data_with_zeros(raw_data, @start_time, @end_time, time_step)
+          execution_data = pad_data_with_zeros(raw_data, @window.start_time, @window.end_time, time_step)
 
           # Build series data as [timestamp_ms, value] pairs for ECharts time axis
           series = [ {

data/app/models/rails_pulse/request.rb

@@ -66,7 +66,7 @@ module RailsPulse
     end
 
     def to_s
-      occurred_at.getlocal.strftime("%b %d, %Y %l:%M %p")
+      occurred_at.strftime("%b %d, %Y %l:%M %p")
     end
 
     private