rails_pulse 0.3.3 → 0.4.0.pre.2

data/app/assets/stylesheets/rails_pulse/components/sidebar_menu.css

@@ -56,28 +56,12 @@
   flex-direction: column;
 }
 
-.sidebar-menu__group-label {
-  color: var(--color-text-subtle);
-  font-size: var(--text-xs);
-  font-weight: var(--font-medium);
-  padding: var(--size-1_5) var(--size-2);
-}
-
 .sidebar-menu__items {
   display: flex;
   flex-direction: column;
   row-gap: var(--size-1);
 }
 
-.sidebar-menu__sub {
-  border-inline-start-width: var(--border);
-  display: flex;
-  flex-direction: column;
-  margin-inline-start: var(--size-4);
-  padding: var(--size-0_5) var(--size-2);
-  row-gap: var(--size-1);
-}
-
 /* Sheet component styles for mobile menu */
 .sheet {
   border: 0;

data/app/assets/stylesheets/rails_pulse/components/storage.css

@@ -0,0 +1,187 @@
+/* Storage status page */
+
+.health-badge-link {
+  text-decoration: none;
+  color: inherit;
+}
+
+.health-badge-link:hover {
+  text-decoration: none;
+}
+
+.health-badge-link:hover .badge {
+  background-color: var(--color-secondary);
+}
+
+.storage-overview-card {
+  min-height: 6.5rem;
+}
+
+.storage-panel-stats {
+  display: grid;
+  grid-template-columns: repeat(4, minmax(0, 1fr));
+  gap: var(--size-4);
+  margin-bottom: var(--size-4);
+  padding-bottom: var(--size-4);
+  border-bottom: 1px solid var(--color-border);
+}
+
+.storage-panel-tables {
+  display: flex;
+  flex-direction: column;
+  gap: var(--size-3);
+}
+
+.storage-panel-row {
+  display: grid;
+  grid-template-columns: 7.5rem 1fr auto;
+  gap: var(--size-3);
+  align-items: center;
+}
+
+.storage-panel-row__label {
+  white-space: nowrap;
+  overflow: hidden;
+  text-overflow: ellipsis;
+}
+
+.storage-panel-row__count {
+  white-space: nowrap;
+  font-variant-numeric: tabular-nums;
+}
+
+.storage-fill--compact {
+  margin-block: 0;
+  height: 0.375rem;
+}
+
+@media (max-width: 768px) {
+  .storage-panel-stats {
+    grid-template-columns: repeat(2, minmax(0, 1fr));
+  }
+
+  .storage-panel-row {
+    grid-template-columns: 1fr auto;
+  }
+
+  .storage-panel-row .storage-fill {
+    grid-column: 1 / -1;
+    order: 3;
+  }
+}
+
+.storage-health--healthy {
+  color: var(--color-positive);
+}
+
+.storage-health--warning {
+  color: var(--color-warning-text);
+}
+
+.storage-health--critical,
+.storage-health--disabled,
+.storage-health--error {
+  color: var(--color-negative);
+}
+
+.storage-tables {
+  display: flex;
+  flex-direction: column;
+  gap: var(--size-5);
+}
+
+.storage-table {
+  padding-bottom: var(--size-5);
+  border-bottom: 1px solid var(--color-border);
+}
+
+.storage-table:last-child {
+  padding-bottom: 0;
+  border-bottom: none;
+}
+
+.storage-table__header {
+  display: flex;
+  align-items: flex-start;
+  justify-content: space-between;
+  gap: var(--size-4);
+}
+
+.storage-table__counts {
+  display: flex;
+  align-items: center;
+  gap: var(--size-2);
+  flex-shrink: 0;
+}
+
+.storage-table__percent {
+  font-variant-numeric: tabular-nums;
+}
+
+.storage-table__percent--healthy {
+  color: var(--color-positive);
+  border-color: color-mix(in srgb, var(--color-positive) 30%, transparent);
+}
+
+.storage-table__percent--warning {
+  color: var(--color-warning-text);
+  border-color: color-mix(in srgb, #eab308 40%, transparent);
+}
+
+.storage-table__percent--critical,
+.storage-table__percent--error {
+  color: var(--color-negative);
+  border-color: color-mix(in srgb, var(--color-negative) 30%, transparent);
+}
+
+.storage-table__percent--uncapped {
+  color: var(--color-text-subtle);
+}
+
+.storage-fill {
+  height: 0.5rem;
+  margin-block: var(--size-2);
+  border-radius: var(--rounded-full, 999px);
+  background: var(--color-secondary);
+  overflow: hidden;
+}
+
+.storage-fill__bar {
+  height: 100%;
+  border-radius: inherit;
+  min-width: 0;
+}
+
+.storage-fill__bar--healthy {
+  background: var(--color-positive);
+}
+
+.storage-fill__bar--warning {
+  background: #eab308;
+}
+
+.storage-fill__bar--critical,
+.storage-fill__bar--error {
+  background: var(--color-negative);
+}
+
+.storage-fill__bar--uncapped {
+  background: transparent;
+}
+
+.storage-table__meta {
+  display: flex;
+  flex-wrap: wrap;
+  gap: var(--size-1) var(--size-4);
+}
+
+.storage-table__meta span + span::before {
+  content: none;
+}
+
+@media (max-width: 768px) {
+  .storage-table__header {
+    flex-direction: column;
+    gap: var(--size-2);
+  }
+}

data/app/assets/stylesheets/rails_pulse/components/tags.css

@@ -31,20 +31,6 @@
   padding-right: 3px !important;
 }
 
-/* Individual Tag */
-.tag {
-  display: inline-flex;
-  align-items: center;
-  gap: 0.25rem;
-  padding: 0.25rem 0.5rem;
-  background-color: var(--color-background-secondary);
-  border: 1px solid var(--color-border);
-  border-radius: 9999px;
-  font-size: 0.875rem;
-  line-height: 1.25;
-  white-space: nowrap;
-}
-
 /* Tag chips — pill shape with subtle translucent fill */
 .tag-list .badge {
   border-radius: 9999px;

data/app/assets/stylesheets/rails_pulse/components/time_range_selector.css

@@ -18,7 +18,7 @@
 
 .time-range-trigger:hover {
   background: var(--color-secondary);
-  border-color: var(--color-border-emphasis);
+  border-color: var(--color-border-dark);
 }
 
 .time-range-trigger svg {
@@ -28,7 +28,7 @@
 
 .time-range-trigger:has(+ [popover]:popover-open) {
   background: var(--color-secondary);
-  border-color: var(--color-border-emphasis);
+  border-color: var(--color-border-dark);
 }
 
 .time-range-trigger:has(+ [popover]:popover-open) svg {
@@ -36,16 +36,16 @@
 }
 
 /* Light mode improvements */
-html[data-color-scheme="light"] .time-range-trigger {
+html:not([data-color-scheme="dark"]) .time-range-trigger {
   border-color: rgba(0, 0, 0, 0.2);
 }
 
-html[data-color-scheme="light"] .time-range-trigger:hover {
+html:not([data-color-scheme="dark"]) .time-range-trigger:hover {
   background: rgba(0, 0, 0, 0.05);
   border-color: rgba(0, 0, 0, 0.3);
 }
 
-html[data-color-scheme="light"] .time-range-trigger:has(+ [popover]:popover-open) {
+html:not([data-color-scheme="dark"]) .time-range-trigger:has(+ [popover]:popover-open) {
   background: rgba(0, 0, 0, 0.05);
   border-color: rgba(0, 0, 0, 0.3);
 }

data/app/assets/stylesheets/rails_pulse/components/utilities.css

@@ -3,37 +3,20 @@
 .w-4 { width: 1rem; }
 .w-6 { width: 1.5rem; }
 .w-8 { width: 2rem; }
-.w-12 { width: 3rem; }
 .w-16 { width: 4rem; }
 .w-20 { width: 5rem; }
 .w-24 { width: 6rem; }
 .w-28 { width: 7rem; }
 .w-32 { width: 8rem; }
 .w-36 { width: 9rem; }
-.w-40 { width: 10rem; }
-.w-44 { width: 11rem; }
 .w-48 { width: 12rem; }
-.w-52 { width: 13rem; }
 .w-56 { width: 14rem; }
 .w-60 { width: 15rem; }
-.w-64 { width: 16rem; }
 
 /* Min-width utilities */
-.min-w-0 { min-width: 0; }
-.min-w-4 { min-width: 1rem; }
-.min-w-8 { min-width: 2rem; }
-.min-w-12 { min-width: 3rem; }
-.min-w-16 { min-width: 4rem; }
-.min-w-20 { min-width: 5rem; }
-.min-w-24 { min-width: 6rem; }
-.min-w-32 { min-width: 8rem; }
 
 /* Max-width utilities */
-.max-w-xs { max-width: 20rem; }
-.max-w-sm { max-width: 24rem; }
-.max-w-md { max-width: 28rem; }
 .max-w-lg { max-width: 32rem; }
-.max-w-xl { max-width: 36rem; }
 
 /* Table layout utilities */
 .table-fixed { table-layout: fixed; }

data/app/controllers/concerns/chart_table_concern.rb

@@ -53,7 +53,7 @@ module ChartTableConcern
   end
 
   def setup_chart_and_table_data
-    ransack_params = params[:q] || {}
+    ransack_params = self.ransack_params
 
     unless partial_request?
       # Setup chart data first using original time range (no sorting from table)
@@ -172,11 +172,18 @@ module ChartTableConcern
     action_name == "show"
   end
 
+  # Hook: override to return param keys that should be excluded from chart queries.
+  # Use this when a filter requires a JOIN that chart queries don't perform
+  # (e.g. route path/action filters that need rails_pulse_routes joined).
+  def chart_filter_exclusions
+    []
+  end
+
   # Builds ransack parameters for chart queries
   # Common pattern: time range + optional duration filter + resource scope
   # Handles "recent" mode where @page_timings.start_time/@end_time may be nil
   def build_chart_ransack_params(ransack_params)
-    base_params = ransack_params.except(:s)
+    base_params = ransack_params.except(:s, *chart_filter_exclusions)
 
     # Add time filters if we have time boundaries (not in "recent" mode)
     if @page_timings&.start_time && @page_timings&.end_time
@@ -196,7 +203,7 @@ module ChartTableConcern
 
     # Scope to specific resource on show pages
     if show_action?
-      base_params.merge(summarizable_id_eq: current_resource.id)
+      base_params.merge(resource_id_scope)
     else
       base_params
     end
@@ -308,4 +315,9 @@ module ChartTableConcern
   def current_resource
     nil
   end
+
+  # Ransack scope for chart summaries on show pages. Override to customize (e.g. IN queries).
+  def resource_id_scope
+    { summarizable_id_eq: current_resource.id }
+  end
 end

data/app/controllers/concerns/ransack_params_concern.rb

@@ -0,0 +1,18 @@
+# RansackParamsConcern
+#
+# Every filterable page reads its Ransack conditions from params[:q]. The
+# dashboard's own forms always send a hash, but a hand-edited URL can make it
+# a string or an array (`?q=foo`), and each caller would then invoke Hash
+# methods on it and 500. Normalise once, here.
+module RansackParamsConcern
+  extend ActiveSupport::Concern
+
+  private
+
+  # params[:q] as an ActionController::Parameters hash, or an empty one when
+  # the value is absent or not hash-shaped.
+  def ransack_params
+    q = params[:q]
+    q.respond_to?(:permit) ? q : ActionController::Parameters.new({})
+  end
+end

data/app/controllers/concerns/response_range_concern.rb

@@ -5,9 +5,9 @@
 # Supports both page-specific duration filters and global performance threshold filters.
 module ResponseRangeConcern
   extend ActiveSupport::Concern
+  include RansackParamsConcern
 
   def setup_duration_range(type = :route)
-    ransack_params = params[:q] || {}
     thresholds = RailsPulse.configuration.public_send("#{type}_thresholds")
 
     # Check all duration-related parameters

data/app/controllers/concerns/time_range_concern.rb

@@ -11,6 +11,7 @@
 # Normalizes times to beginning/end of hour or day based on range duration.
 module TimeRangeConcern
   extend ActiveSupport::Concern
+  include RansackParamsConcern
 
   included do
     # Define the constant in the including class - ordered by most common usage
@@ -40,8 +41,6 @@ module TimeRangeConcern
     end_time = Time.zone.now
     selected_time_range = default_key
 
-    ransack_params = params[:q] || {}
-
     # Priority 1: Page-specific preset from dropdown (check this first!)
     if ransack_params[:period_start_range].present? && ransack_params[:period_start_range].to_sym != :custom
       # Predefined time range from dropdown
@@ -59,22 +58,30 @@ module TimeRangeConcern
     elsif ransack_params[:period_start_range].present? && ransack_params[:period_start_range].to_sym == :custom && ransack_params[:custom_date_range].present? && ransack_params[:custom_date_range].include?(" to ")
       # Custom datetime range from custom range picker
       dates = ransack_params[:custom_date_range].split(" to ")
-      start_time = parse_time_param(dates[0].strip)
-      end_time = parse_time_param(dates[1].strip)
-      selected_time_range = :custom
+      custom_start = parse_time_param(dates[0].strip)
+      custom_end = parse_time_param(dates[1].strip)
+      if custom_start && custom_end
+        start_time = custom_start
+        end_time = custom_end
+        selected_time_range = :custom
+      end
     # Priority 3: Page-specific filters (chart zoom)
     elsif ransack_params[:occurred_at_gteq].present? && ransack_params[:occurred_at_lt].present?
       # Custom time range from chart zoom
-      start_time = parse_time_param(ransack_params[:occurred_at_gteq])
-      end_time = parse_time_param(ransack_params[:occurred_at_lt])
-      selected_time_range = :custom
+      zoom_start = parse_time_param(ransack_params[:occurred_at_gteq])
+      zoom_end = parse_time_param(ransack_params[:occurred_at_lt])
+      if zoom_start && zoom_end
+        start_time = zoom_start
+        end_time = zoom_end
+        selected_time_range = :custom
+      end
     # Priority 4: Time range selector (from session)
     elsif session[:time_range_preference].present?
       preference = session[:time_range_preference]
       if preference.is_a?(Hash) && preference["type"] == "custom"
         # Custom range from time range selector
-        start_time = parse_time_param(preference["start_time"])
-        end_time = parse_time_param(preference["end_time"])
+        start_time = parse_time_param(preference["start_time"]) || start_time
+        end_time = parse_time_param(preference["end_time"]) || end_time
         selected_time_range = :custom
       else
         # Preset from time range selector
@@ -90,8 +97,8 @@ module TimeRangeConcern
       end
     # Priority 5: Global filters (from session)
     elsif session_global_filters["start_time"].present? || session_global_filters["end_time"].present?
-      start_time = parse_time_param(session_global_filters["start_time"]) if session_global_filters["start_time"].present?
-      end_time = parse_time_param(session_global_filters["end_time"]) if session_global_filters["end_time"].present?
+      start_time = parse_time_param(session_global_filters["start_time"]) || start_time
+      end_time = parse_time_param(session_global_filters["end_time"]) || end_time
       selected_time_range = :custom
     end
     # Priority 6: Default time range (already set above)
@@ -112,17 +119,24 @@ module TimeRangeConcern
 
   private
 
+  # Returns nil for anything that does not parse, so a hand-edited or stale
+  # value falls back to the default range instead of raising.
   def parse_time_param(param)
     case param
     when Time, DateTime
       param.in_time_zone
     when String
+      return nil if param.blank?
+
       # Parse as server local time (not UTC, not Time.zone)
       # This ensures flatpickr datetime strings are interpreted in server's timezone
       Time.parse(param).localtime
+    when Numeric
+      Time.zone.at(param)
     else
-      # Assume it's an integer timestamp
-      Time.zone.at(param.to_i)
+      nil
     end
+  rescue ArgumentError, TypeError, RangeError
+    nil
   end
 end