rails_pulse 0.1.2 → 0.1.3

data/app/views/rails_pulse/routes/index.html.erb

@@ -10,64 +10,61 @@
 <% end %>
 
 <div
-  class="row"
   data-controller="rails-pulse--index"
   data-rails-pulse--index-chart-id-value="average_response_times_chart"
 >
-  <div class="grid-item">
-    <%= render 'rails_pulse/components/panel', { title: 'Average Response Time', } do %>
-      <%= search_form_for @ransack_query, url: routes_path, class: "flex items-center justify-between gap mb-4" do |form| %>
-        <div class="flex items-center grow gap">
-          <%= form.search_field :route_path_cont, placeholder: "Filter by route", autocomplete: "off", class: "input", style: "max-inline-size: 250px" %>
-          <%= form.select :period_start_range,
-            RailsPulse::RoutesController::TIME_RANGE_OPTIONS,
-            { selected: @selected_time_range },
-            { class: "input" }
-          %>
-          <%= form.select :avg_duration,
-            duration_options(:route),
-            { selected: @selected_response_range },
-            { class: "input" }
-          %>
-          <%= link_to "Reset", routes_path, class: "btn btn--borderless show@md" if params.has_key?(:q) %>
-          <%= form.submit "Search", class: "btn show@sm" %>
+  <%= render 'rails_pulse/components/panel', { title: 'Average Response Time', card_classes: 'b-full' } do %>
+    <%= search_form_for @ransack_query, url: routes_path, class: "flex items-center justify-between gap mb-4" do |form| %>
+      <div class="flex items-center grow gap">
+        <%= form.search_field :route_path_cont, placeholder: "Filter by route", autocomplete: "off", class: "input", style: "max-inline-size: 250px" %>
+        <%= form.select :period_start_range,
+          RailsPulse::RoutesController::TIME_RANGE_OPTIONS,
+          { selected: @selected_time_range },
+          { class: "input" }
+        %>
+        <%= form.select :avg_duration,
+          duration_options(:route),
+          { selected: @selected_response_range },
+          { class: "input" }
+        %>
+        <%= link_to "Reset", routes_path, class: "btn btn--borderless show@md" if params.has_key?(:q) %>
+        <%= form.submit "Search", class: "btn show@sm" %>
+      </div>
+    <% end %>
+
+    <% if @has_data %>
+      <% if @chart_data && @chart_data.values.any? { |v| v > 0 } %>
+        <div
+          class="chart-container chart-container--slim"
+          data-rails-pulse--index-target="chart"
+        >
+          <%= bar_chart(
+            @chart_data,
+            code: false,
+            id: "average_response_times_chart",
+            height: "100%",
+            options: bar_chart_options(
+              units: "ms",
+              zoom: true,
+              chart_start: 0,
+              chart_end: @chart_data.length - 1,
+              xaxis_formatter: @xaxis_formatter,
+              tooltip_formatter: @tooltip_formatter,
+              zoom_start: @zoom_start,
+              zoom_end: @zoom_end,
+              chart_data: @chart_data
+            )
+          ) %>
         </div>
       <% end %>
 
-      <% if @has_data %>
-        <% if @chart_data && @chart_data.values.any? { |v| v > 0 } %>
-          <div
-            class="chart-container chart-container--slim"
-            data-rails-pulse--index-target="chart"
-          >
-            <%= bar_chart(
-              @chart_data,
-              code: false,
-              id: "average_response_times_chart",
-              height: "100%",
-              options: bar_chart_options(
-                units: "ms",
-                zoom: true,
-                chart_start: 0,
-                chart_end: @chart_data.length - 1,
-                xaxis_formatter: @xaxis_formatter,
-                tooltip_formatter: @tooltip_formatter,
-                zoom_start: @zoom_start,
-                zoom_end: @zoom_end,
-                chart_data: @chart_data
-              )
-            ) %>
-          </div>
-        <% end %>
-
-        <%= turbo_frame_tag :routes_index_table, data: { rails_pulse__index_target: "indexTable" } do %>
-          <%= render 'rails_pulse/routes/table' %>
-        <% end %>
-      <% else %>
-        <%= render 'rails_pulse/components/empty_state', 
-            title: 'No route data found for the selected filters.', 
-            description: 'Try adjusting your time range or filters to see results.' %>
+      <%= turbo_frame_tag :index_table, data: { rails_pulse__index_target: "indexTable" } do %>
+        <%= render 'rails_pulse/routes/table' %>
       <% end %>
+    <% else %>
+      <%= render 'rails_pulse/components/empty_state',
+          title: 'No route data found for the selected filters.',
+          description: 'Try adjusting your time range or filters to see results.' %>
     <% end %>
-  </div>
+  <% end %>
 </div>

data/app/views/rails_pulse/routes/show.html.erb

@@ -1,6 +1,6 @@
 <%= render 'rails_pulse/components/breadcrumbs' %>
 
-<h1 class="text-2xl mbe-2"><%= @route.path_and_method %></h1>
+<h1 class="text-2xl mis-2"><%= @route.path_and_method %></h1>
 
 <% unless turbo_frame_request? %>
   <div class="row">
@@ -61,12 +61,12 @@
           </div>
         <% end %>
 
-        <%= turbo_frame_tag :index_table do %>
+        <%= turbo_frame_tag :index_table, data: { rails_pulse__index_target: "indexTable" } do %>
           <%= render 'rails_pulse/requests/table' %>
         <% end %>
       <% else %>
-        <%= render 'rails_pulse/components/empty_state', 
-            title: 'No route requests found for the selected filters.', 
+        <%= render 'rails_pulse/components/empty_state',
+            title: 'No route requests found for the selected filters.',
             description: 'Try adjusting your time range or filters to see results.' %>
       <% end %>
     <% end %>

data/config/routes.rb

@@ -3,7 +3,11 @@ RailsPulse::Engine.routes.draw do
 
   resources :routes, only: %i[index show]
   resources :requests, only: %i[index show]
-  resources :queries, only: %i[index show]
+  resources :queries, only: %i[index show] do
+    member do
+      post :analyze
+    end
+  end
   resources :operations, only: %i[show]
   resources :caches, only: %i[show], as: :cache
   patch "pagination/limit", to: "application#set_pagination_limit"

data/db/migrate/20250916031656_add_analysis_to_rails_pulse_queries.rb

@@ -0,0 +1,13 @@
+class AddAnalysisToRailsPulseQueries < ActiveRecord::Migration[8.0]
+  def change
+    add_column :rails_pulse_queries, :analyzed_at, :datetime, comment: "When query analysis was last performed"
+    add_column :rails_pulse_queries, :explain_plan, :text, comment: "EXPLAIN output from actual SQL execution"
+    add_column :rails_pulse_queries, :issues, :text, comment: "JSON array of detected performance issues"
+    add_column :rails_pulse_queries, :metadata, :text, comment: "JSON object containing query complexity metrics"
+    add_column :rails_pulse_queries, :query_stats, :text, comment: "JSON object with query characteristics analysis"
+    add_column :rails_pulse_queries, :backtrace_analysis, :text, comment: "JSON object with call chain and N+1 detection"
+    add_column :rails_pulse_queries, :suggestions, :text, comment: "JSON array of optimization recommendations"
+    add_column :rails_pulse_queries, :index_recommendations, :text, comment: "JSON array of database index recommendations"
+    add_column :rails_pulse_queries, :n_plus_one_analysis, :text, comment: "JSON object with enhanced N+1 query detection results"
+  end
+end

data/db/rails_pulse_schema.rb

@@ -25,6 +25,15 @@ RailsPulse::Schema = lambda do |connection|
 
   connection.create_table :rails_pulse_queries do |t|
     t.string :normalized_sql, limit: 1000, null: false, comment: "Normalized SQL query string (e.g., SELECT * FROM users WHERE id = ?)"
+    t.datetime :analyzed_at, comment: "When query analysis was last performed"
+    t.text :explain_plan, comment: "EXPLAIN output from actual SQL execution"
+    t.text :issues, comment: "JSON array of detected performance issues"
+    t.text :metadata, comment: "JSON object containing query complexity metrics"
+    t.text :query_stats, comment: "JSON object with query characteristics analysis"
+    t.text :backtrace_analysis, comment: "JSON object with call chain and N+1 detection"
+    t.text :index_recommendations, comment: "JSON array of database index recommendations"
+    t.text :n_plus_one_analysis, comment: "JSON object with enhanced N+1 query detection results"
+    t.text :suggestions, comment: "JSON array of optimization recommendations"
     t.timestamps
   end
 

data/lib/generators/rails_pulse/convert_to_migrations_generator.rb

@@ -0,0 +1,65 @@
+module RailsPulse
+  module Generators
+    class ConvertToMigrationsGenerator < Rails::Generators::Base
+      include Rails::Generators::Migration
+      source_root File.expand_path("templates", __dir__)
+
+      desc "Convert Rails Pulse schema file to migrations for single database setup"
+
+      def self.next_migration_number(path)
+        next_migration_number = current_migration_number(path) + 1
+        ActiveRecord::Migration.next_migration_number(next_migration_number)
+      end
+
+      def check_schema_file
+        unless File.exist?("db/rails_pulse_schema.rb")
+          say "No db/rails_pulse_schema.rb file found. Run 'rails generate rails_pulse:install' first.", :red
+          exit 1
+        end
+
+        if rails_pulse_tables_exist?
+          say "Rails Pulse tables already exist. No conversion needed.", :yellow
+          say "Use 'rails generate rails_pulse:upgrade' to update existing installation.", :blue
+          exit 0
+        end
+      end
+
+      def create_conversion_migration
+        say "Converting db/rails_pulse_schema.rb to migration...", :green
+
+        migration_template(
+          "migrations/install_rails_pulse_tables.rb",
+          "db/migrate/install_rails_pulse_tables.rb"
+        )
+      end
+
+      def display_completion_message
+        say <<~MESSAGE
+
+          Conversion complete!
+
+          Next steps:
+          1. Run: rails db:migrate
+          2. Delete: db/rails_pulse_schema.rb (no longer needed)
+          3. Remove db/rails_pulse_migrate/ directory if it exists
+          4. Restart your Rails server
+
+          Future Rails Pulse updates will come as regular migrations.
+
+        MESSAGE
+      end
+
+      private
+
+      def rails_pulse_tables_exist?
+        return false unless defined?(ActiveRecord::Base)
+
+        connection = ActiveRecord::Base.connection
+        %w[rails_pulse_routes rails_pulse_queries rails_pulse_requests rails_pulse_operations rails_pulse_summaries]
+          .all? { |table| connection.table_exists?(table) }
+      rescue
+        false
+      end
+    end
+  end
+end

data/lib/generators/rails_pulse/install_generator.rb

@@ -1,9 +1,18 @@
 module RailsPulse
   module Generators
     class InstallGenerator < Rails::Generators::Base
+      include Rails::Generators::Migration
       source_root File.expand_path("templates", __dir__)
 
-      desc "Install Rails Pulse with schema-based setup"
+      desc "Install Rails Pulse with flexible database setup options"
+
+      class_option :database, type: :string, default: "single",
+                   desc: "Database setup: 'single' (default) or 'separate'"
+
+      def self.next_migration_number(path)
+        next_migration_number = current_migration_number(path) + 1
+        ActiveRecord::Migration.next_migration_number(next_migration_number)
+      end
 
       def copy_schema
         copy_file "db/rails_pulse_schema.rb", "db/rails_pulse_schema.rb"
@@ -13,41 +22,85 @@ module RailsPulse
         copy_file "rails_pulse.rb", "config/initializers/rails_pulse.rb"
       end
 
-      def create_database_migration_paths
+      def setup_database_configuration
         if separate_database?
-          create_file "db/rails_pulse_migrate/.keep"
+          create_separate_database_setup
+        else
+          create_single_database_setup
         end
       end
 
       def display_post_install_message
+        if separate_database?
+          display_separate_database_message
+        else
+          display_single_database_message
+        end
+      end
+
+      private
+
+      def separate_database?
+        options[:database] == "separate"
+      end
+
+      def create_separate_database_setup
+        create_file "db/rails_pulse_migrate/.keep"
+
+        say "Setting up separate database configuration...", :green
+
+        # Could add database.yml configuration here if needed
+        # For now, users will configure manually
+      end
+
+      def create_single_database_setup
+        say "Setting up single database configuration...", :green
+
+        # Create a migration that loads the schema
+        migration_template(
+          "migrations/install_rails_pulse_tables.rb",
+          "db/migrate/install_rails_pulse_tables.rb"
+        )
+      end
+
+      def display_separate_database_message
         say <<~MESSAGE
 
-          Rails Pulse installation complete!
+          Rails Pulse installation complete! (Separate Database Setup)
 
           Next steps:
-          1. Configure your database in config/database.yml (see README for examples)
+          1. Add Rails Pulse database configuration to config/database.yml:
+
+             #{Rails.env}:
+               rails_pulse:
+                 <<: *default
+                 database: storage/#{Rails.env}_rails_pulse.sqlite3
+                 migrations_paths: db/rails_pulse_migrate
+
           2. Run: rails db:prepare (creates database and loads schema)
           3. Restart your Rails server
 
-          For separate database setup, add to config/database.yml:
-            #{environment}:
-              rails_pulse:
-                <<: *default
-                database: storage/#{environment}_rails_pulse.sqlite3
-                migrations_paths: db/rails_pulse_migrate
+          Future schema changes will come as regular migrations in db/rails_pulse_migrate/
 
         MESSAGE
       end
 
-      private
+      def display_single_database_message
+        say <<~MESSAGE
 
-      def separate_database?
-        # Could make this configurable via options
-        false
-      end
+          Rails Pulse installation complete! (Single Database Setup)
+
+          Next steps:
+          1. Run: rails db:migrate (creates Rails Pulse tables in your main database)
+          2. Delete: db/rails_pulse_schema.rb (no longer needed)
+          3. Restart your Rails server
 
-      def environment
-        Rails.env.production? ? "production" : "development"
+          Future schema changes will come as regular migrations in db/migrate/
+
+          Note: The installation migration was created from db/rails_pulse_schema.rb
+          and includes all current Rails Pulse tables and columns.
+
+        MESSAGE
       end
     end
   end

data/lib/generators/rails_pulse/templates/migrations/install_rails_pulse_tables.rb

@@ -0,0 +1,22 @@
+# Generated from Rails Pulse schema - automatically loads current schema definition
+class InstallRailsPulseTables < ActiveRecord::Migration[<%= ActiveRecord::Migration.current_version %>]
+  def change
+    # Load and execute the Rails Pulse schema directly
+    # This ensures the migration is always in sync with the schema file
+    schema_file = File.join(::Rails.root.to_s, "db/rails_pulse_schema.rb")
+
+    if File.exist?(schema_file)
+      say "Loading Rails Pulse schema from db/rails_pulse_schema.rb"
+
+      # Load the schema file to define RailsPulse::Schema
+      load schema_file
+
+      # Execute the schema in the context of this migration
+      RailsPulse::Schema.call(connection)
+
+      say "Rails Pulse tables created successfully"
+    else
+      raise "Rails Pulse schema file not found at db/rails_pulse_schema.rb"
+    end
+  end
+end

data/lib/generators/rails_pulse/templates/migrations/upgrade_rails_pulse_tables.rb

@@ -0,0 +1,19 @@
+# Upgrade Rails Pulse tables with new features
+class UpgradeRailsPulseTables < ActiveRecord::Migration[<%= @migration_version %>]
+  def change
+    <% @missing_columns.each do |table_name, columns| %>
+      <% columns.each do |column_name, definition| %>
+    # Add <%= column_name %> column to <%= table_name %>
+    add_column :<%= table_name %>, :<%= column_name %>, :<%= definition[:type] %><% if definition[:comment] %>, comment: "<%= definition[:comment] %>"<% end %>
+      <% end %>
+    <% end %>
+  end
+
+  def down
+    <% @missing_columns.each do |table_name, columns| %>
+      <% columns.each do |column_name, _definition| %>
+    remove_column :<%= table_name %>, :<%= column_name %>
+      <% end %>
+    <% end %>
+  end
+end

data/lib/generators/rails_pulse/upgrade_generator.rb

@@ -0,0 +1,225 @@
+module RailsPulse
+  module Generators
+    class UpgradeGenerator < Rails::Generators::Base
+      include Rails::Generators::Migration
+      source_root File.expand_path("templates", __dir__)
+
+      desc "Upgrade Rails Pulse database schema to the latest version"
+
+      class_option :database, type: :string, default: "detect",
+                   desc: "Database setup: 'single', 'separate', or 'detect' (default)"
+
+      def self.next_migration_number(path)
+        next_migration_number = current_migration_number(path) + 1
+        ActiveRecord::Migration.next_migration_number(next_migration_number)
+      end
+
+      def check_current_installation
+        @database_type = detect_database_setup
+
+        say "Detected database setup: #{@database_type}", :green
+
+        case @database_type
+        when :single
+          upgrade_single_database
+        when :separate
+          upgrade_separate_database
+        when :schema_only
+          offer_conversion_to_migrations
+        when :not_installed
+          say "Rails Pulse not detected. Run 'rails generate rails_pulse:install' first.", :red
+          exit 1
+        end
+      end
+
+      private
+
+      def detect_database_setup
+        # Override with command line option if provided
+        return options[:database].to_sym if options[:database] != "detect"
+
+        # Check for existing Rails Pulse tables
+        tables_exist = rails_pulse_tables_exist?
+
+        if !tables_exist && File.exist?("db/rails_pulse_schema.rb")
+          :schema_only
+        elsif !tables_exist
+          :not_installed
+        elsif File.exist?("db/rails_pulse_migrate")
+          :separate
+        else
+          :single
+        end
+      end
+
+      def rails_pulse_tables_exist?
+        return false unless defined?(ActiveRecord::Base)
+
+        connection = ActiveRecord::Base.connection
+        required_tables = get_rails_pulse_table_names
+
+        required_tables.all? { |table| connection.table_exists?(table) }
+      rescue
+        false
+      end
+
+      def get_rails_pulse_table_names
+        # Load the schema file to get the table names dynamically
+        schema_file = File.join(Rails.root, "db/rails_pulse_schema.rb")
+
+        if File.exist?(schema_file)
+          # Read the schema file and extract the required_tables array
+          schema_content = File.read(schema_file)
+
+          # Extract the required_tables line using regex
+          if match = schema_content.match(/required_tables\s*=\s*\[(.*?)\]/m)
+            # Parse the array content, handling symbols and strings
+            table_names = match[1].scan(/:(\w+)/).flatten
+            return table_names.map(&:to_s)
+          end
+        end
+
+        # Fallback to default table names if schema file parsing fails
+        %w[rails_pulse_routes rails_pulse_queries rails_pulse_requests rails_pulse_operations rails_pulse_summaries]
+      end
+
+      def upgrade_single_database
+        missing_columns = detect_missing_columns
+
+        if missing_columns.empty?
+          say "Rails Pulse is up to date! No migration needed.", :green
+          return
+        end
+
+        # Format missing columns by table for the template
+        missing_by_table = format_missing_columns_by_table(missing_columns)
+
+        say "Creating upgrade migration for missing columns: #{missing_columns.keys.join(', ')}", :blue
+
+        # Set instance variables for template
+        @migration_version = ActiveRecord::Migration.current_version
+        @missing_columns = missing_by_table
+
+        migration_template(
+          "migrations/upgrade_rails_pulse_tables.rb",
+          "db/migrate/upgrade_rails_pulse_tables.rb"
+        )
+
+        say <<~MESSAGE
+
+          Upgrade migration created successfully!
+
+          Next steps:
+          1. Run: rails db:migrate
+          2. Restart your Rails server
+
+          This migration will add: #{missing_columns.keys.join(', ')}
+
+        MESSAGE
+      end
+
+      def upgrade_separate_database
+        # For separate database, we'd need to check the schema file and generate migrations
+        # in db/rails_pulse_migrate/ directory
+        say "Separate database upgrade not implemented yet. Please check db/rails_pulse_schema.rb for updates.", :yellow
+      end
+
+      def offer_conversion_to_migrations
+        say <<~MESSAGE
+
+          Rails Pulse schema detected but no tables found.
+
+          To convert to single database setup:
+          1. Run: rails generate rails_pulse:convert_to_migrations
+          2. Run: rails db:migrate
+          3. Delete: db/rails_pulse_schema.rb
+
+        MESSAGE
+      end
+
+      def detect_missing_columns
+        return {} unless rails_pulse_tables_exist?
+
+        connection = ActiveRecord::Base.connection
+        missing = {}
+
+        # Get expected schema from the schema file
+        expected_schema = get_expected_schema_from_file
+
+        expected_schema.each do |table_name, columns|
+          table_symbol = table_name.to_sym
+
+          if connection.table_exists?(table_symbol)
+            existing_columns = connection.columns(table_symbol).map(&:name)
+
+            columns.each do |column_name, definition|
+              unless existing_columns.include?(column_name)
+                missing[column_name] = definition
+              end
+            end
+          end
+        end
+
+        missing
+      end
+
+      def get_expected_schema_from_file
+        schema_file = File.join(Rails.root, "db/rails_pulse_schema.rb")
+        return {} unless File.exist?(schema_file)
+
+        schema_content = File.read(schema_file)
+        expected_columns = {}
+
+        # Find each create_table block and parse its contents
+        table_blocks = schema_content.scan(/connection\.create_table\s+:(\w+).*?do\s*\|t\|(.*?)(?:connection\.add_index|connection\.create_table|\z)/m)
+
+        table_blocks.each do |table_name, table_block|
+          columns = {}
+
+          # Split the table block into lines and process each line
+          table_block.split("\n").each do |line|
+            # Match column definitions like: t.text :index_recommendations, comment: "..."
+            if match = line.match(/t\.(\w+)\s+:([a-zA-Z_][a-zA-Z0-9_]*)(?:.*?comment:\s*"([^"]*)")?/)
+              column_type, column_name, comment = match.captures
+
+              # Skip timestamps and references as they're handled by Rails
+              next if %w[timestamps references].include?(column_type)
+
+              columns[column_name] = {
+                type: column_type.to_sym,
+                comment: comment
+              }.compact
+            end
+          end
+
+          expected_columns[table_name] = columns if columns.any?
+        end
+
+        expected_columns
+      end
+
+      def format_missing_columns_by_table(missing_columns)
+        # The missing_columns are already organized by table from detect_missing_columns
+        # but we need to restructure them for the template
+        missing_by_table = {}
+
+        # Get expected schema to find which table each missing column belongs to
+        expected_schema = get_expected_schema_from_file
+
+        expected_schema.each do |table_name, expected_columns|
+          table_missing = {}
+
+          expected_columns.each do |column_name, definition|
+            if missing_columns.key?(column_name)
+              table_missing[column_name] = definition
+            end
+          end
+
+          missing_by_table[table_name] = table_missing if table_missing.any?
+        end
+
+        missing_by_table
+      end
+    end
+  end
+end

data/lib/rails_pulse/version.rb

@@ -1,3 +1,3 @@
 module RailsPulse
-  VERSION = "0.1.2"
+  VERSION = "0.1.3"
 end